Repository navigation
[backport cloud/1.59] send missing nodes and models to the Build (#21186) - #22537
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T00:07:39.945Z",
"gitSha": "99084540e4272b4f761acb841e0704b36a41ab66",
"branch": "bl/cloud-1.59-deployment-build-actions",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.1139999999778,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3819999999999997,
"layouts": 9,
"layoutDurationMs": 2.526,
"taskDurationMs": 509.92400000000004,
"heapDeltaBytes": 3910644,
"heapUsedBytes": 65784692,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8.250999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.632000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3579999999999997,
"layouts": 9,
"layoutDurationMs": 2.4960000000000004,
"taskDurationMs": 504.97399999999993,
"heapDeltaBytes": 2627884,
"heapUsedBytes": 63883728,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.792000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.2800000000045,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.459000000000001,
"layouts": 8,
"layoutDurationMs": 1.9889999999999999,
"taskDurationMs": 853.645,
"heapDeltaBytes": 21483256,
"heapUsedBytes": 83225156,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.925,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.4460000000058,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.136,
"layouts": 9,
"layoutDurationMs": 2.309,
"taskDurationMs": 845.437,
"heapDeltaBytes": 21385700,
"heapUsedBytes": 83161788,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 156.654,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.8560000000302,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.523,
"layouts": 10,
"layoutDurationMs": 2.631,
"taskDurationMs": 382.50600000000003,
"heapDeltaBytes": 24444880,
"heapUsedBytes": 86075560,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.147999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9010000000162,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.593,
"layouts": 11,
"layoutDurationMs": 2.648,
"taskDurationMs": 395.315,
"heapDeltaBytes": 24173148,
"heapUsedBytes": 83973508,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.527000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 651.627000000019,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.059,
"layouts": 10,
"layoutDurationMs": 2.6860000000000004,
"taskDurationMs": 488.60900000000004,
"heapDeltaBytes": 7486352,
"heapUsedBytes": 77148564,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 169.389,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 690.2460000000019,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.4810000000000003,
"layouts": 9,
"layoutDurationMs": 2.451,
"taskDurationMs": 492.92699999999996,
"heapDeltaBytes": 6612500,
"heapUsedBytes": 77880840,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 168.434,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.7839999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.823,
"heapDeltaBytes": -1215912,
"heapUsedBytes": 75609576,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 77.93900000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.465999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.654,
"heapDeltaBytes": -1153508,
"heapUsedBytes": 75654396,
"domNodes": -191,
"jsHeapTotalBytes": 15474688,
"scriptDurationMs": 63.92399999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 490,
"frameDurationMs": 31.529729729729727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.4599999999809,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.9970000000003,
"heapDeltaBytes": -14809588,
"heapUsedBytes": 66408996,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 172.955,
"eventListeners": -107,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.324324324324323,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.0110000000191,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.7500000000002,
"heapDeltaBytes": -3480196,
"heapUsedBytes": 71338384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.862,
"eventListeners": 0,
"totalBlockingTimeMs": 206,
"frameDurationMs": 24.072222222222234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10692.304999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9817.348,
"heapDeltaBytes": 15255468,
"heapUsedBytes": 77503444,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7949.459,
"eventListeners": 0,
"totalBlockingTimeMs": 1096,
"frameDurationMs": 31.60621301775148,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10088.543999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9271.522,
"heapDeltaBytes": -24161368,
"heapUsedBytes": 65149612,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 7483.648999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 698,
"frameDurationMs": 31.5090625,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10794.018999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10040.837,
"heapDeltaBytes": 91828404,
"heapUsedBytes": 153428844,
"domNodes": -170,
"jsHeapTotalBytes": 87293952,
"scriptDurationMs": 8174.9980000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 1256,
"frameDurationMs": 31.3031884057971,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9812.81800000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.028000000000000247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9022.440999999999,
"heapDeltaBytes": -9508740,
"heapUsedBytes": 79339416,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 7239.304,
"eventListeners": -69,
"totalBlockingTimeMs": 717,
"frameDurationMs": 31.462500000000002,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 268.85099999998374,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.652999999999999,
"layouts": 11,
"layoutDurationMs": 3.08,
"taskDurationMs": 225.49999999999997,
"heapDeltaBytes": -491132,
"heapUsedBytes": 68636656,
"domNodes": -2315,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.755999999999998,
"eventListeners": -574,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 248.0860000000007,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.993,
"layouts": 9,
"layoutDurationMs": 3.033,
"taskDurationMs": 187.529,
"heapDeltaBytes": 14646800,
"heapUsedBytes": 70777336,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.066,
"eventListeners": -574,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2040.5169999999941,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4880000000000004,
"layouts": 10,
"layoutDurationMs": 2.5120000000000005,
"taskDurationMs": 633.7859999999998,
"heapDeltaBytes": -29907304,
"heapUsedBytes": 61239144,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 33.827,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.4949999999644,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3419999999999996,
"layouts": 8,
"layoutDurationMs": 2.277,
"taskDurationMs": 620.536,
"heapDeltaBytes": -12073448,
"heapUsedBytes": 63303172,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.521,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2653.0180000000314,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.376999999999999,
"layouts": 7,
"layoutDurationMs": 1.6400000000000001,
"taskDurationMs": 1760.576,
"heapDeltaBytes": -10071512,
"heapUsedBytes": 72337940,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 863.509,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2505.9400000000096,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.358,
"layouts": 7,
"layoutDurationMs": 1.6889999999999998,
"taskDurationMs": 1682.191,
"heapDeltaBytes": 1335500,
"heapUsedBytes": 81046136,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 819.153,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.1849999999827,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.364,
"layouts": 64,
"layoutDurationMs": 10.677,
"taskDurationMs": 1774.7549999999999,
"heapDeltaBytes": -26087660,
"heapUsedBytes": 65938520,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 767.884,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3698.6060000000407,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.526,
"layouts": 64,
"layoutDurationMs": 10.248,
"taskDurationMs": 1797.803,
"heapDeltaBytes": -8017016,
"heapUsedBytes": 70720228,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 785.9189999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3071.575999999993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.162,
"layouts": 6,
"layoutDurationMs": 1.2669999999999995,
"taskDurationMs": 1953.2469999999998,
"heapDeltaBytes": 19729164,
"heapUsedBytes": 99128972,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 962.2409999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.848087431693987,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2964.7260000000415,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.655,
"layouts": 5,
"layoutDurationMs": 1.0840000000000003,
"taskDurationMs": 1929.1499999999999,
"heapDeltaBytes": -12922156,
"heapUsedBytes": 74581572,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 955.766,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85337078651685,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3094.180000000023,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8369999999999993,
"layouts": 7,
"layoutDurationMs": 1.7480000000000002,
"taskDurationMs": 816.3909999999998,
"heapDeltaBytes": 2355728,
"heapUsedBytes": 79705516,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 370.137,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66540540540541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3084.7870000000057,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6909999999999998,
"layouts": 6,
"layoutDurationMs": 1.7309999999999999,
"taskDurationMs": 784.771,
"heapDeltaBytes": -19129552,
"heapUsedBytes": 74189028,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 371.52500000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.309000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9770000000000005,
"layouts": 7,
"layoutDurationMs": 2.0740000000000003,
"taskDurationMs": 636.5039999999999,
"heapDeltaBytes": -15252528,
"heapUsedBytes": 61767232,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.314,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2047.5010000000111,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9789999999999999,
"layouts": 8,
"layoutDurationMs": 1.8679999999999999,
"taskDurationMs": 618.9459999999999,
"heapDeltaBytes": -12257820,
"heapUsedBytes": 65541772,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.416000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2808.6580000000085,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.104999999999999,
"layouts": 7,
"layoutDurationMs": 2.156,
"taskDurationMs": 640.0669999999999,
"heapDeltaBytes": -6013876,
"heapUsedBytes": 71742700,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 197.845,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2772.862000000032,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.239,
"layouts": 9,
"layoutDurationMs": 2.1590000000000003,
"taskDurationMs": 588.646,
"heapDeltaBytes": -26082688,
"heapUsedBytes": 66735732,
"domNodes": -241,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 185.266,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3240.7839999999906,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8050000000000002,
"layouts": 7,
"layoutDurationMs": 1.673,
"taskDurationMs": 938.7040000000001,
"heapDeltaBytes": -18312776,
"heapUsedBytes": 61326940,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 370.602,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3240.8790000000067,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.693,
"layouts": 6,
"layoutDurationMs": 1.4989999999999999,
"taskDurationMs": 920.357,
"heapDeltaBytes": -33222444,
"heapUsedBytes": 60658592,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 366.098,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751546391752576,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.6540000000064,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.941999999999999,
"layouts": 9,
"layoutDurationMs": 2.462,
"taskDurationMs": 447.224,
"heapDeltaBytes": 983536,
"heapUsedBytes": 62552212,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 150.122,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.8550000000232,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.976,
"layouts": 9,
"layoutDurationMs": 2.336,
"taskDurationMs": 438.3400000000001,
"heapDeltaBytes": 672104,
"heapUsedBytes": 63035096,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 144.79500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2006.7200000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.045,
"layouts": 8,
"layoutDurationMs": 2.114,
"taskDurationMs": 509.181,
"heapDeltaBytes": 1916008,
"heapUsedBytes": 64584168,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.6110000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.347999999928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.713,
"layouts": 9,
"layoutDurationMs": 2.7819999999999996,
"taskDurationMs": 545.5749999999999,
"heapDeltaBytes": 1323068,
"heapUsedBytes": 63819996,
"domNodes": -183,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.917000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6640000000077,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.171,
"layouts": 10,
"layoutDurationMs": 2.2740000000000005,
"taskDurationMs": 813.2589999999999,
"heapDeltaBytes": -5301364,
"heapUsedBytes": 67615824,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 108.319,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5179999999891,
"styleRecalcs": 78,
"styleRecalcDurationMs": 12.827,
"layouts": 9,
"layoutDurationMs": 2.161,
"taskDurationMs": 812.812,
"heapDeltaBytes": 18024772,
"heapUsedBytes": 80657908,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 107.767,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.448000000004,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.121000000000002,
"layouts": 5,
"layoutDurationMs": 13.905000000000001,
"taskDurationMs": 1016.0219999999999,
"heapDeltaBytes": 13999976,
"heapUsedBytes": 117712160,
"domNodes": 16030,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 33.94,
"eventListeners": 3246,
"totalBlockingTimeMs": 155,
"frameDurationMs": 19.820270270270267,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9421.47299999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.225,
"layouts": 9,
"layoutDurationMs": 2.459,
"taskDurationMs": 6052.181,
"heapDeltaBytes": 1376312,
"heapUsedBytes": 75515948,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2827.396,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601769911504,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9207.993999999984,
"styleRecalcs": 248,
"styleRecalcDurationMs": 29.701000000000004,
"layouts": 5,
"layoutDurationMs": 1.4850000000000003,
"taskDurationMs": 6007.314,
"heapDeltaBytes": -10330188,
"heapUsedBytes": 71761104,
"domNodes": -257,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 2789.643,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696370235934662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23296.63900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22658.555,
"heapDeltaBytes": -32929908,
"heapUsedBytes": 259307820,
"domNodes": -307,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 317.39,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.03281786941581,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 22977.22699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22246.642,
"heapDeltaBytes": 10430604,
"heapUsedBytes": 282731192,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 356.20099999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.17902097902098,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28206.976999999995,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.273999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27850.485000000004,
"heapDeltaBytes": -16299936,
"heapUsedBytes": 275361696,
"domNodes": -3347,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 937.206,
"eventListeners": -651,
"totalBlockingTimeMs": 108,
"frameDurationMs": 52.543016759776535,
"p95FrameDurationMs": 116.60000000000582
},
{
"name": "vue-large-graph-pan",
"durationMs": 27763.751999999953,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.30900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27369.173000000003,
"heapDeltaBytes": -19142504,
"heapUsedBytes": 264040360,
"domNodes": -3343,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 844.035,
"eventListeners": -651,
"totalBlockingTimeMs": 45,
"frameDurationMs": 50.300000000000004,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8266.889999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.221,
"layouts": 20,
"layoutDurationMs": 21.617999999999984,
"taskDurationMs": 8124.575,
"heapDeltaBytes": -30161512,
"heapUsedBytes": 257726572,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 122.476,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.96279069767442,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8350.265000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.04500000000003,
"layouts": 20,
"layoutDurationMs": 25.933999999999997,
"taskDurationMs": 8213.390000000001,
"heapDeltaBytes": -17345920,
"heapUsedBytes": 283858808,
"domNodes": -3343,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 128.894,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.815168539325846,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11632.717999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11214.643,
"heapDeltaBytes": 10230552,
"heapUsedBytes": 284710500,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 155.57299999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.70238907849829,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11360.092000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11031.333999999999,
"heapDeltaBytes": -5523936,
"heapUsedBytes": 258717916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.364,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.82315789473685,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 142.8629999999771,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.880999999999998,
"layouts": 10,
"layoutDurationMs": 4.326,
"taskDurationMs": 105.52700000000002,
"heapDeltaBytes": 4993328,
"heapUsedBytes": 72075528,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.876000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 488.5909999999285,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.105,
"layouts": 14,
"layoutDurationMs": 4.995,
"taskDurationMs": 141.88,
"heapDeltaBytes": -10880868,
"heapUsedBytes": 63323288,
"domNodes": 133,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.888,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 489.6170000000666,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6769999999999999,
"layouts": 76,
"layoutDurationMs": 15.020999999999999,
"taskDurationMs": 437.93699999999995,
"heapDeltaBytes": -4443588,
"heapUsedBytes": 41318312,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 212.24599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 488.8210000000299,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.653,
"layouts": 76,
"layoutDurationMs": 14.567,
"taskDurationMs": 441.69399999999996,
"heapDeltaBytes": -4083236,
"heapUsedBytes": 40358312,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 216.025,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 486.5940000000819,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.463,
"layouts": 76,
"layoutDurationMs": 13.889000000000001,
"taskDurationMs": 446.673,
"heapDeltaBytes": 557232,
"heapUsedBytes": 102859648,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 176.35500000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 497.7670000000671,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.519,
"layouts": 76,
"layoutDurationMs": 13.879000000000001,
"taskDurationMs": 462.879,
"heapDeltaBytes": 226680,
"heapUsedBytes": 103061120,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 186.09499999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: b7e04ad | Docs | View more details | Give us feedback! |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
…1186) On a custom deployment, missing nodes and models must be added to the Build that deployment runs. The Issues panel now offers Edit build on Platform and an agent brief identifying the deployment, Build, release, missing packs and models (with their folders), and packs the Build has but cannot load (with ComfyUI's cause, to fix rather than add again). Cloud model import is hidden on deployments; Comfy Cloud and local behavior are preserved. Stack: 2 of 4, after #21184 (merged); #21188 follows. Board M3 of DES-1254. The brief-copy behavior and build-recipe section are shared with the custom-deployment dialog. The Platform link opens the Build page because there is no direct link to its models step. Once the deployment moves past the release the page loaded (`changeSinceBoot`: a new release, or this browser now runs on another deployment), the panel swaps the Build actions for the switcher's "Reload to get its nodes" message and a Reload button, so a second copy of the brief cannot send the agent to redo the work. Returning to the window re-reads the deployment listing while the Build actions show, at most once a minute (the switcher's focus-retry limit), since the listing otherwise only reloads when the switcher opens. The reload step and change message are shared with the switcher. - After merging main: `can_start` added to the deployment fixtures (CI typecheck). Workspace, Issues panel, error catalog and missing-model suites pass (57 files, 1363 tests), including a reload after a new release or another deployment, the once-a-minute focus refresh, and the summary line. - Focused suites pass (610 tests across the Issues panel, missing-model card, error messages, agent brief and workspace components), including regression tests for model folders, packs that fail to load, repeated node types and a deployment name with `'` and `&`. - Formatting, stylelint, type-aware oxlint, ESLint, server-fact checks and application typecheck pass on the PR changes. - Normal pre-push dependency audit, knip and Fallow pass; Fallow reports advisory architecture/style warnings. - Browser verification remains pending. --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> (cherry picked from commit d95cd07)
06e1523 to
b7e04ad
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## bl/cloud-1.59-custom-deployment-dialog #22537 +/- ##
==========================================================================
+ Coverage 87.26% 87.27% +0.01%
==========================================================================
Files 3045 3048 +3
Lines 159999 160106 +107
Branches 42703 42752 +49
==========================================================================
+ Hits 139619 139735 +116
+ Misses 19701 19692 -9
Partials 679 679
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #21186 to
cloud/1.59. On a custom deployment, the Issues panel offers Edit build and an agent brief for missing nodes/models and failed node packs. A changed release offers Reload.Part 5 of 9 in the Cloud workflow deployment backport stack. Keeps the Issues panel in 1.59's existing directory, its manager imports, and its current switcher behavior. Part 8 supplies the Start feature.
Verification
cloud/1.59at7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, inSignUpForm.test.ts, is intermittent and also fails oncloud/1.59without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.