Repository navigation
[backport cloud/1.59] add the custom-deployment introduction (#21184) - #22536
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T00:07:45.321Z",
"gitSha": "57d1f7651a8ea7c31a4eea14976200d080facb5a",
"branch": "bl/cloud-1.59-custom-deployment-dialog",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.139999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5649999999999995,
"layouts": 8,
"layoutDurationMs": 2.5029999999999997,
"taskDurationMs": 603.345,
"heapDeltaBytes": 1474548,
"heapUsedBytes": 62881104,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.024999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.525999999947,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.556,
"layouts": 8,
"layoutDurationMs": 2.5130000000000003,
"taskDurationMs": 633.2529999999999,
"heapDeltaBytes": 1433064,
"heapUsedBytes": 63904136,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.310999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.5819999999921,
"styleRecalcs": 80,
"styleRecalcDurationMs": 14.911000000000001,
"layouts": 9,
"layoutDurationMs": 2.8339999999999996,
"taskDurationMs": 1017.341,
"heapDeltaBytes": 21691272,
"heapUsedBytes": 82675460,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 170.256,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637931034483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.5759999999864,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.403999999999998,
"layouts": 8,
"layoutDurationMs": 2.792,
"taskDurationMs": 1000.394,
"heapDeltaBytes": 21889184,
"heapUsedBytes": 84305644,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 164.557,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.0419999999922,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.231999999999999,
"layouts": 9,
"layoutDurationMs": 2.772,
"taskDurationMs": 490.622,
"heapDeltaBytes": 25246368,
"heapUsedBytes": 86558384,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 16.374000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3749999999327,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.463000000000001,
"layouts": 9,
"layoutDurationMs": 2.618,
"taskDurationMs": 490.74899999999997,
"heapDeltaBytes": -1653296,
"heapUsedBytes": 59589680,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.003000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 759.6290000000181,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.733,
"layouts": 8,
"layoutDurationMs": 2.5789999999999997,
"taskDurationMs": 557.8430000000001,
"heapDeltaBytes": 5460460,
"heapUsedBytes": 67906232,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 174.99699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66739130434783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 734.911000000011,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8389999999999995,
"layouts": 9,
"layoutDurationMs": 2.132,
"taskDurationMs": 547.154,
"heapDeltaBytes": 5540856,
"heapUsedBytes": 66923952,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 173.742,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1273.8149999999848,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 998.9039999999999,
"heapDeltaBytes": -12518132,
"heapUsedBytes": 75215192,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 61.80099999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 572,
"frameDurationMs": 34.23243243243242,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1243.3160000000498,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 953.0590000000001,
"heapDeltaBytes": 16677808,
"heapUsedBytes": 83227784,
"domNodes": 0,
"jsHeapTotalBytes": 12484608,
"scriptDurationMs": 66.37099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 593,
"frameDurationMs": 36.27058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 822.2220000000107,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.9119999999999,
"heapDeltaBytes": -4309424,
"heapUsedBytes": 70324884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.324,
"eventListeners": 0,
"totalBlockingTimeMs": 188,
"frameDurationMs": 24.017647058823542,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.706999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.4819999999997,
"heapDeltaBytes": -30426132,
"heapUsedBytes": 65970336,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 154.24500000000003,
"eventListeners": -107,
"totalBlockingTimeMs": 193,
"frameDurationMs": 24.07500000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10936.699000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9950.952,
"heapDeltaBytes": 71965096,
"heapUsedBytes": 146670408,
"domNodes": -257,
"jsHeapTotalBytes": 64876544,
"scriptDurationMs": 7636.828,
"eventListeners": -69,
"totalBlockingTimeMs": 882,
"frameDurationMs": 31.506916426512966,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10456.617999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9532.273,
"heapDeltaBytes": 5754568,
"heapUsedBytes": 66659796,
"domNodes": -257,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7467.2,
"eventListeners": -69,
"totalBlockingTimeMs": 668,
"frameDurationMs": 31.380180180180183,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10646.59500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9767.205,
"heapDeltaBytes": 74142732,
"heapUsedBytes": 156457068,
"domNodes": -257,
"jsHeapTotalBytes": 80867328,
"scriptDurationMs": 7535.823,
"eventListeners": -69,
"totalBlockingTimeMs": 578,
"frameDurationMs": 30.77919075144509,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10033.796999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9121.588000000002,
"heapDeltaBytes": 77828728,
"heapUsedBytes": 153162424,
"domNodes": -257,
"jsHeapTotalBytes": 61206528,
"scriptDurationMs": 7010.3640000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 431,
"frameDurationMs": 30.37048192771085,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 334.99700000001553,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.99,
"layouts": 11,
"layoutDurationMs": 3.9229999999999996,
"taskDurationMs": 284.37100000000004,
"heapDeltaBytes": -15227536,
"heapUsedBytes": 60837860,
"domNodes": -2485,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 13.687000000000001,
"eventListeners": -641,
"totalBlockingTimeMs": 8,
"frameDurationMs": 27.775000000000016,
"p95FrameDurationMs": 116.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 311.1250000000041,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.58,
"layouts": 11,
"layoutDurationMs": 4.1370000000000005,
"taskDurationMs": 268.57599999999996,
"heapDeltaBytes": -13521104,
"heapUsedBytes": 62316080,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 10.581999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 26.39166666666665,
"p95FrameDurationMs": 100.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2054.352999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.589,
"layouts": 8,
"layoutDurationMs": 3.153,
"taskDurationMs": 739.391,
"heapDeltaBytes": -14847268,
"heapUsedBytes": 59590752,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 39.334999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.9769999999844,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4470000000000005,
"layouts": 8,
"layoutDurationMs": 2.731,
"taskDurationMs": 745.555,
"heapDeltaBytes": -6215976,
"heapUsedBytes": 71552980,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 41.815999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2645.4370000000154,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.415,
"layouts": 6,
"layoutDurationMs": 1.8139999999999996,
"taskDurationMs": 1725.3690000000001,
"heapDeltaBytes": -14126008,
"heapUsedBytes": 60509788,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 884.293,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2886.6669999999885,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.995,
"layouts": 6,
"layoutDurationMs": 1.7509999999999994,
"taskDurationMs": 1890.398,
"heapDeltaBytes": -1692836,
"heapUsedBytes": 81513056,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 876.39,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763372093023253,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3956.277,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.353000000000002,
"layouts": 64,
"layoutDurationMs": 11.205,
"taskDurationMs": 2021.2890000000004,
"heapDeltaBytes": 2950428,
"heapUsedBytes": 79704480,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 838.9720000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80720338983051,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3992.166999999995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.167000000000002,
"layouts": 64,
"layoutDurationMs": 11.603,
"taskDurationMs": 2016.181,
"heapDeltaBytes": 7107128,
"heapUsedBytes": 84034564,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 850.336,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80675105485232,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3262.0660000000044,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.981,
"layouts": 5,
"layoutDurationMs": 1.8510000000000002,
"taskDurationMs": 2184.544,
"heapDeltaBytes": -2371816,
"heapUsedBytes": 78297636,
"domNodes": -257,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 1009.23,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83937823834197,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3441.1549999999806,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2281.21,
"heapDeltaBytes": 18096924,
"heapUsedBytes": 82692460,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1074.3170000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91231527093596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3229.541000000012,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5009999999999997,
"layouts": 6,
"layoutDurationMs": 1.8860000000000001,
"taskDurationMs": 932.747,
"heapDeltaBytes": -14010744,
"heapUsedBytes": 79782300,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 396.594,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3186.6850000000113,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3879999999999995,
"layouts": 5,
"layoutDurationMs": 1.308,
"taskDurationMs": 901.213,
"heapDeltaBytes": 2539048,
"heapUsedBytes": 79519372,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 399.752,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753684210526316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.2709999999906,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3650000000000007,
"layouts": 7,
"layoutDurationMs": 2.38,
"taskDurationMs": 788.616,
"heapDeltaBytes": -18464528,
"heapUsedBytes": 61204152,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 40.689,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2081.3309999999774,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.6750000000000003,
"layouts": 7,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 795.167,
"heapDeltaBytes": -26497016,
"heapUsedBytes": 65704548,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 44.20600000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3079.6789999999987,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.216000000000001,
"layouts": 6,
"layoutDurationMs": 1.6029999999999998,
"taskDurationMs": 761.005,
"heapDeltaBytes": -4728848,
"heapUsedBytes": 71863988,
"domNodes": -254,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 221.887,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3069.5200000000114,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.710999999999999,
"layouts": 7,
"layoutDurationMs": 2.6229999999999998,
"taskDurationMs": 738.0580000000001,
"heapDeltaBytes": 1058052,
"heapUsedBytes": 85438256,
"domNodes": -244,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 211.60000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3367.342000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7480000000000004,
"layouts": 7,
"layoutDurationMs": 1.8740000000000003,
"taskDurationMs": 1073.153,
"heapDeltaBytes": -14084252,
"heapUsedBytes": 63102672,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 403.126,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3448.703000000023,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.445,
"layouts": 5,
"layoutDurationMs": 1.212,
"taskDurationMs": 1125.865,
"heapDeltaBytes": -995872,
"heapUsedBytes": 77953624,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 433.86199999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747087378640774,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 741.499000000033,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.519,
"layouts": 6,
"layoutDurationMs": 1.9470000000000003,
"taskDurationMs": 513.946,
"heapDeltaBytes": -1351656,
"heapUsedBytes": 61928160,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 158.363,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 722.5240000000213,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.682,
"layouts": 9,
"layoutDurationMs": 2.6359999999999997,
"taskDurationMs": 482.63800000000003,
"heapDeltaBytes": 1622020,
"heapUsedBytes": 74311100,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 145.776,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069764,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2040.898999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8569999999999993,
"layouts": 9,
"layoutDurationMs": 3.0370000000000004,
"taskDurationMs": 632.571,
"heapDeltaBytes": 1793048,
"heapUsedBytes": 63513856,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.219,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.8640000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6269999999999993,
"layouts": 8,
"layoutDurationMs": 2.5840000000000005,
"taskDurationMs": 640.054,
"heapDeltaBytes": 2185356,
"heapUsedBytes": 64463604,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.094000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.3900000000103,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.46,
"layouts": 8,
"layoutDurationMs": 2.53,
"taskDurationMs": 958.493,
"heapDeltaBytes": 17400792,
"heapUsedBytes": 80104160,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 115.68,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.7069999999821,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.609000000000002,
"layouts": 8,
"layoutDurationMs": 2.4419999999999997,
"taskDurationMs": 977.9889999999999,
"heapDeltaBytes": 19252700,
"heapUsedBytes": 82437316,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 121.002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.7570000000474,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.054999999999996,
"layouts": 5,
"layoutDurationMs": 12.836000000000004,
"taskDurationMs": 1080.977,
"heapDeltaBytes": 13965432,
"heapUsedBytes": 117460044,
"domNodes": 16030,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 32.37,
"eventListeners": 3246,
"totalBlockingTimeMs": 157,
"frameDurationMs": 19.861643835616434,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10313.195000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.02000000000001,
"layouts": 7,
"layoutDurationMs": 2.379,
"taskDurationMs": 6906.731,
"heapDeltaBytes": -9418792,
"heapUsedBytes": 72535548,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 3017.313,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9524.742999999944,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.808,
"layouts": 7,
"layoutDurationMs": 1.9240000000000002,
"taskDurationMs": 6592.540000000001,
"heapDeltaBytes": -2009984,
"heapUsedBytes": 72806516,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2924.4950000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602451838879,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20999.77000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20616.187,
"heapDeltaBytes": -16676540,
"heapUsedBytes": 278021912,
"domNodes": -3347,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 307.029,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.38976234003656,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 21005.10499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20493.319999999996,
"heapDeltaBytes": 8963696,
"heapUsedBytes": 286291744,
"domNodes": -3343,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 298.68899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.97024647887324,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 26381.470999999976,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.491000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26156.778000000002,
"heapDeltaBytes": -6914884,
"heapUsedBytes": 278799268,
"domNodes": -3343,
"jsHeapTotalBytes": 11452416,
"scriptDurationMs": 1083.534,
"eventListeners": -651,
"totalBlockingTimeMs": 132,
"frameDurationMs": 50.930888030888035,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 27348.38400000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.984000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27082.840000000004,
"heapDeltaBytes": -10135980,
"heapUsedBytes": 281727876,
"domNodes": -3343,
"jsHeapTotalBytes": 11456512,
"scriptDurationMs": 963.8090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 45,
"frameDurationMs": 53.909664694280075,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 7842.220999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.088,
"layouts": 20,
"layoutDurationMs": 32.1,
"taskDurationMs": 7729.420999999999,
"heapDeltaBytes": -30599712,
"heapUsedBytes": 261570848,
"domNodes": -3343,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 125.82700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.57065217391305,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7903.556999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.62499999999998,
"layouts": 20,
"layoutDurationMs": 25.055000000000007,
"taskDurationMs": 7767.652000000001,
"heapDeltaBytes": -27738144,
"heapUsedBytes": 268548564,
"domNodes": -3343,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 126.527,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.93315217391305,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10356.172000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10143.685,
"heapDeltaBytes": -15979032,
"heapUsedBytes": 265794200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.498550724637674,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10367.19000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10230.783,
"heapDeltaBytes": -27992844,
"heapUsedBytes": 246274876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.27800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.423104693140786,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 522.767999999985,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.412,
"layouts": 9,
"layoutDurationMs": 4.183,
"taskDurationMs": 166.88200000000003,
"heapDeltaBytes": 7285600,
"heapUsedBytes": 69868724,
"domNodes": 138,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.357,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66774193548388,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 158.54200000001129,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.158000000000001,
"layouts": 10,
"layoutDurationMs": 4.441000000000001,
"taskDurationMs": 107.338,
"heapDeltaBytes": 4648256,
"heapUsedBytes": 73918096,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.826999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 560.8429999999771,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.746,
"layouts": 76,
"layoutDurationMs": 18.599,
"taskDurationMs": 519.552,
"heapDeltaBytes": -760096,
"heapUsedBytes": 45585468,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 234.667,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 646.7159999999694,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.735,
"layouts": 76,
"layoutDurationMs": 20.523,
"taskDurationMs": 594.04,
"heapDeltaBytes": -3324840,
"heapUsedBytes": 40622168,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 274.444,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 961.8339999999534,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.294,
"layouts": 76,
"layoutDurationMs": 23.196,
"taskDurationMs": 920.941,
"heapDeltaBytes": 4909140,
"heapUsedBytes": 111182356,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 402.322,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.95789473684211,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 776.5039999999317,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.179,
"layouts": 76,
"layoutDurationMs": 20.012999999999998,
"taskDurationMs": 742.853,
"heapDeltaBytes": -24154732,
"heapUsedBytes": 78937172,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 303.913,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66808510638297,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 60.0% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3122 passed, 0 failed · 8 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 39aed79c9b004832d7c16d9d83e4fee988eb511e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (254)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
… and a dot on the engine button (#21184) In an empty workspace, **Create a custom deployment** in the Run on menu opens a dialog explaining custom nodes, models, GPU choice, and API use. On Comfy Cloud, accounts in the custom deployment rollout reach the same dialog through **Extensions**; other accounts keep the existing survey. The engine button shows a dot until its first open closes, however it closes, with the seen state saved across devices. - Both entry points reach the same accounts: those the deployments listing is served to. Ingest answers that listing 403 for accounts outside the rollout and for API keys ("Not in the rollout, or an API key"), and the engine button already shows only when it is served. Extensions reads that answer alone: not `builds_visible`, which only goes false when comfy-builder rejects ingest's token, and not a client-side Cloud or API-key check. - Extensions waits at most 5 s (`DEPLOYMENT_LISTING_EXTENSIONS_WAIT_MS`) for a listing that has not answered yet, then opens the survey. - Preserve the current menu's compatibility grouping, keyboard focus, shared unsaved-work protection, and **Manage deployments** link for workspaces with deployments. - The dialog offers documentation, a copyable agent brief, and Platform's `/profile/builds` page. Shared video assets and agent marks remain available to dependent PRs. - Rebased onto main; the already-merged save-prompt changes are excluded. #21186 builds on this; #21153 is a separate sibling dependency. - 980 tests pass across `src/platform/workspace` and `TopMenuSection`, including a listing that never answers (survey after the wait), a served listing without Build names (dialog), and the dot clearing when the switcher closes itself to ask about unsaved work. - Commit and push hooks pass: formatting, stylelint, type-aware oxlint, ESLint, server-fact checks, app typecheck, dependency-cycle, unused-code, and changed-code audits. The audit retains one advisory boundary warning for the test's manager-survey mock. - Chrome/Storybook with Cloud configuration: empty-workspace dialog opens through the real global dialog renderer; copy shows **Copied**; the notification clears after closing the menu; populated workspaces retain **Manage deployments** pointing at `/profile/builds`. - Browser verification used seeded component state, not a live Cloud deployment. --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> (cherry picked from commit 40d27cb)
833a29e to
f1d305c
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## bl/cloud-1.59-deployment-readiness #22536 +/- ##
======================================================================
+ Coverage 86.61% 87.26% +0.64%
======================================================================
Files 2674 3045 +371
Lines 139160 159999 +20839
Branches 42672 42703 +31
======================================================================
+ Hits 120538 139619 +19081
- Misses 17802 19701 +1899
+ Partials 820 679 -141
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1802 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #21184 to
cloud/1.59. Create a custom deployment and Extensions open the custom-deployment introduction for eligible Cloud accounts; the engine button marks its first opening.Part 4 of 9 in the Cloud workflow deployment backport stack. Uses 1.59's existing UI, Video, telemetry and manager modules; preserves unrelated settings.
Verification
cloud/1.59at7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, inSignUpForm.test.ts, is intermittent and also fails oncloud/1.59without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.