Repository navigation
[backport cloud/1.59] group and align the deployment menu (#21836) - #22534
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T00:18:16.939Z",
"gitSha": "308400ea8cc64541f957119a279f73036c864949",
"branch": "bl/cloud-1.59-deployment-menu",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6580000000206,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.68,
"layouts": 9,
"layoutDurationMs": 2.471,
"taskDurationMs": 444.942,
"heapDeltaBytes": 3079196,
"heapUsedBytes": 70964632,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.2409999999745,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3449999999999998,
"layouts": 9,
"layoutDurationMs": 2.0080000000000005,
"taskDurationMs": 440.69499999999994,
"heapDeltaBytes": 4291272,
"heapUsedBytes": 74904380,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.0570000000191,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.337,
"layouts": 9,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 739.238,
"heapDeltaBytes": 23007824,
"heapUsedBytes": 84654308,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 126.52199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.4350000000318,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.710999999999999,
"layouts": 11,
"layoutDurationMs": 2.4979999999999998,
"taskDurationMs": 746.17,
"heapDeltaBytes": -7273180,
"heapUsedBytes": 55219016,
"domNodes": -161,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 126.305,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.7789999999968,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.3240000000000007,
"layouts": 5,
"layoutDurationMs": 1.2520000000000002,
"taskDurationMs": 333.68699999999995,
"heapDeltaBytes": -341672,
"heapUsedBytes": 60977152,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.636999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.320000000077,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.21,
"layouts": 11,
"layoutDurationMs": 2.618,
"taskDurationMs": 329.743,
"heapDeltaBytes": 24220540,
"heapUsedBytes": 86265204,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.373,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 575.2469999999903,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6290000000000004,
"layouts": 9,
"layoutDurationMs": 2.0419999999999994,
"taskDurationMs": 418.50399999999996,
"heapDeltaBytes": 5817152,
"heapUsedBytes": 67513364,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 137.81099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 565.8659999999713,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5460000000000003,
"layouts": 9,
"layoutDurationMs": 2.247,
"taskDurationMs": 403.87300000000005,
"heapDeltaBytes": 5251240,
"heapUsedBytes": 66775724,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 138.33200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1061.5909999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.3359999999999,
"heapDeltaBytes": -13651108,
"heapUsedBytes": 74904504,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 49.583000000000006,
"eventListeners": -107,
"totalBlockingTimeMs": 398,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1070.4770000000394,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.892,
"heapDeltaBytes": -12110624,
"heapUsedBytes": 76030060,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 53.793000000000006,
"eventListeners": -107,
"totalBlockingTimeMs": 380,
"frameDurationMs": 28.827027027027025,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.9590000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.6510000000002,
"heapDeltaBytes": -2833812,
"heapUsedBytes": 70861184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.80499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.4960000000156,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.7760000000002,
"heapDeltaBytes": -29148632,
"heapUsedBytes": 63685464,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 118.70999999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 169,
"frameDurationMs": 23.147222222222226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7710.715999999991,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9450000000000005,
"layouts": 4,
"layoutDurationMs": 1.0180000000000002,
"taskDurationMs": 6870.816,
"heapDeltaBytes": 77158648,
"heapUsedBytes": 151713912,
"domNodes": -257,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 5298.305,
"eventListeners": -69,
"totalBlockingTimeMs": 28,
"frameDurationMs": 23.98660436137072,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7550.297999999998,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7930000000000003,
"layouts": 3,
"layoutDurationMs": 0.7300000000000002,
"taskDurationMs": 6720.704000000001,
"heapDeltaBytes": 57817504,
"heapUsedBytes": 131781544,
"domNodes": -257,
"jsHeapTotalBytes": 65662976,
"scriptDurationMs": 5206.195,
"eventListeners": -69,
"totalBlockingTimeMs": 60,
"frameDurationMs": 24.354193548387094,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7764.546999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6911.847,
"heapDeltaBytes": 43213684,
"heapUsedBytes": 118141176,
"domNodes": -257,
"jsHeapTotalBytes": 52293632,
"scriptDurationMs": 5355.483,
"eventListeners": -69,
"totalBlockingTimeMs": 170,
"frameDurationMs": 24.346081504702195,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7574.198000000024,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.268,
"layouts": 1,
"layoutDurationMs": 0.3160000000000003,
"taskDurationMs": 6758.393999999999,
"heapDeltaBytes": 46270508,
"heapUsedBytes": 120404180,
"domNodes": -257,
"jsHeapTotalBytes": 54390784,
"scriptDurationMs": 5256.959999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 55,
"frameDurationMs": 23.79339622641509,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 200.06699999999,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.399999999999999,
"layouts": 11,
"layoutDurationMs": 2.909,
"taskDurationMs": 147.41500000000002,
"heapDeltaBytes": 14389572,
"heapUsedBytes": 90428880,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.093999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.211111111111123,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 189.03099999999995,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.501999999999999,
"layouts": 10,
"layoutDurationMs": 2.7099999999999995,
"taskDurationMs": 154.88800000000003,
"heapDeltaBytes": 14482700,
"heapUsedBytes": 85236092,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.487999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2026.5080000000069,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.699,
"layouts": 9,
"layoutDurationMs": 2.3169999999999997,
"taskDurationMs": 548.1560000000001,
"heapDeltaBytes": -14319884,
"heapUsedBytes": 60539072,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.877999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2029.1910000000257,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8750000000000009,
"layouts": 7,
"layoutDurationMs": 1.5849999999999995,
"taskDurationMs": 516.6569999999999,
"heapDeltaBytes": -26459656,
"heapUsedBytes": 69527764,
"domNodes": -257,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.306999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2568.565000000007,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.26,
"layouts": 7,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 1408.858,
"heapDeltaBytes": -16826740,
"heapUsedBytes": 61645120,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 668.701,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665584415584412,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2357.573000000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.909,
"layouts": 7,
"layoutDurationMs": 1.6509999999999998,
"taskDurationMs": 1452.239,
"heapDeltaBytes": -28346844,
"heapUsedBytes": 62041116,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 714.5020000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3804.33000000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.664,
"layouts": 65,
"layoutDurationMs": 11.061,
"taskDurationMs": 1603.3289999999997,
"heapDeltaBytes": 3747348,
"heapUsedBytes": 84330396,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 680.9110000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3391.268000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.664,
"layouts": 64,
"layoutDurationMs": 10.027999999999999,
"taskDurationMs": 1444.8020000000001,
"heapDeltaBytes": 1753788,
"heapUsedBytes": 74131424,
"domNodes": 24,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 650.907,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2517.2930000000233,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.509,
"layouts": 6,
"layoutDurationMs": 1.5939999999999994,
"taskDurationMs": 1656.9719999999998,
"heapDeltaBytes": 11473332,
"heapUsedBytes": 89931032,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 807.3439999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77733333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2536.5400000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.5569999999999995,
"layouts": 6,
"layoutDurationMs": 1.6200000000000003,
"taskDurationMs": 1662.9830000000002,
"heapDeltaBytes": -17198716,
"heapUsedBytes": 67318756,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 814.432,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77615894039735,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3078.2839999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2849999999999997,
"layouts": 8,
"layoutDurationMs": 1.9969999999999997,
"taskDurationMs": 687.419,
"heapDeltaBytes": -6900648,
"heapUsedBytes": 68746724,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 317.05000000000007,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2958.231000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.229,
"layouts": 8,
"layoutDurationMs": 2.0039999999999996,
"taskDurationMs": 639.4949999999999,
"heapDeltaBytes": -2685552,
"heapUsedBytes": 79418280,
"domNodes": -257,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 285.921,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.6319999999823,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.654,
"layouts": 8,
"layoutDurationMs": 2.183,
"taskDurationMs": 547.642,
"heapDeltaBytes": -29401452,
"heapUsedBytes": 63646876,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 30.904,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.998000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.437,
"layouts": 9,
"layoutDurationMs": 2.341,
"taskDurationMs": 532.379,
"heapDeltaBytes": 28856,
"heapUsedBytes": 79180068,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.296999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2709.676999999999,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.176000000000002,
"layouts": 7,
"layoutDurationMs": 1.8030000000000002,
"taskDurationMs": 518.263,
"heapDeltaBytes": -9723408,
"heapUsedBytes": 82406044,
"domNodes": -238,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 159.239,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.959999999961,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.303,
"layouts": 9,
"layoutDurationMs": 1.9829999999999999,
"taskDurationMs": 492.28499999999997,
"heapDeltaBytes": -14453568,
"heapUsedBytes": 68148712,
"domNodes": -248,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 155.952,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3081.513000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9389999999999998,
"layouts": 7,
"layoutDurationMs": 1.6190000000000002,
"taskDurationMs": 797.4679999999998,
"heapDeltaBytes": 6999972,
"heapUsedBytes": 84930416,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 299.533,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3051.678000000038,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0740000000000003,
"layouts": 8,
"layoutDurationMs": 1.744,
"taskDurationMs": 764.153,
"heapDeltaBytes": -15891656,
"heapUsedBytes": 76877964,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 300.75500000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.3319999999967,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.781999999999999,
"layouts": 9,
"layoutDurationMs": 2.1310000000000002,
"taskDurationMs": 365.46099999999996,
"heapDeltaBytes": 1100012,
"heapUsedBytes": 63242884,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 122.28699999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.8829999998998,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.489,
"layouts": 9,
"layoutDurationMs": 2.218,
"taskDurationMs": 361.11199999999997,
"heapDeltaBytes": 587812,
"heapUsedBytes": 62952292,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 120.35600000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.3860000000063,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.595000000000001,
"layouts": 9,
"layoutDurationMs": 2.1569999999999996,
"taskDurationMs": 438.886,
"heapDeltaBytes": 3206916,
"heapUsedBytes": 65513700,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9.238,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.7009999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.658,
"layouts": 9,
"layoutDurationMs": 2.3040000000000003,
"taskDurationMs": 417.49899999999997,
"heapDeltaBytes": 1830980,
"heapUsedBytes": 64606344,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.891,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6249999999925,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.524,
"layouts": 9,
"layoutDurationMs": 1.9940000000000002,
"taskDurationMs": 689.547,
"heapDeltaBytes": 17451212,
"heapUsedBytes": 80179948,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 95.299,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.807000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.338,
"layouts": 10,
"layoutDurationMs": 2.4079999999999995,
"taskDurationMs": 727.322,
"heapDeltaBytes": -10429644,
"heapUsedBytes": 61143772,
"domNodes": -175,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 94.233,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.1169999999684,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.584000000000003,
"layouts": 5,
"layoutDurationMs": 10.218000000000002,
"taskDurationMs": 885.23,
"heapDeltaBytes": 9642884,
"heapUsedBytes": 101975444,
"domNodes": 16030,
"jsHeapTotalBytes": 7213056,
"scriptDurationMs": 27.519999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 114,
"frameDurationMs": 19.014084507042252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8813.854000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.999999999999996,
"layouts": 8,
"layoutDurationMs": 2.0080000000000005,
"taskDurationMs": 4843.753000000001,
"heapDeltaBytes": -5601784,
"heapUsedBytes": 76167244,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 2231.003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665973534971645,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9159.75500000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.294,
"layouts": 8,
"layoutDurationMs": 2.179,
"taskDurationMs": 4969.530000000001,
"heapDeltaBytes": -13433892,
"heapUsedBytes": 61524596,
"domNodes": -257,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 2262.829,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20437.337000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19900.716000000004,
"heapDeltaBytes": -37762792,
"heapUsedBytes": 258497836,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 278.362,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.3915750915751,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20695.02,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19906.219,
"heapDeltaBytes": -12251680,
"heapUsedBytes": 280663344,
"domNodes": -3343,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 284.555,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.25078809106831,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24520.482999999957,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.987000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24229.237,
"heapDeltaBytes": -13704500,
"heapUsedBytes": 278293472,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 773.1260000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 47.11365384615385,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24064.10299999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.60999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23830.211,
"heapDeltaBytes": -23512568,
"heapUsedBytes": 253811128,
"domNodes": -3343,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 735.705,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 45.83942857142857,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7286.579000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.08700000000002,
"layouts": 20,
"layoutDurationMs": 22.918000000000006,
"taskDurationMs": 7220.410999999999,
"heapDeltaBytes": -54216772,
"heapUsedBytes": 248646376,
"domNodes": -3343,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 115.81099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.68098159509202,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7324.276999999938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.20699999999997,
"layouts": 20,
"layoutDurationMs": 21.223000000000006,
"taskDurationMs": 7238.44,
"heapDeltaBytes": -16326392,
"heapUsedBytes": 261661328,
"domNodes": -3343,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 110.77100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.90285714285714,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10503.090999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10179.024,
"heapDeltaBytes": -36804556,
"heapUsedBytes": 256227840,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 164.06899999999996,
"eventListeners": -646,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.232624113475175,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10107.163000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9793.836999999998,
"heapDeltaBytes": 14713884,
"heapUsedBytes": 266773800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.74700000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.129642857142855,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 270.55100000001175,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.905,
"layouts": 5,
"layoutDurationMs": 1.793,
"taskDurationMs": 249.218,
"heapDeltaBytes": 4750312,
"heapUsedBytes": 72633516,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.977000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 125,
"frameDurationMs": 40.471428571428596,
"p95FrameDurationMs": 166.69999999999982
},
{
"name": "workflow-execution",
"durationMs": 94.3929999999682,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.564,
"layouts": 7,
"layoutDurationMs": 3.0550000000000006,
"taskDurationMs": 68.412,
"heapDeltaBytes": 4615652,
"heapUsedBytes": 71739276,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.555000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 287.09600000001956,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 11.405,
"taskDurationMs": 244.04600000000002,
"heapDeltaBytes": 10242068,
"heapUsedBytes": 51587352,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 110.113,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 270.86100000008173,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.629,
"layouts": 76,
"layoutDurationMs": 11.398,
"taskDurationMs": 234.884,
"heapDeltaBytes": 10144372,
"heapUsedBytes": 49331784,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.456,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 308.4279999999353,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7260000000000002,
"layouts": 76,
"layoutDurationMs": 11.758,
"taskDurationMs": 280.09399999999994,
"heapDeltaBytes": -1234820,
"heapUsedBytes": 96952032,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 96.555,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736813,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 366.4090000000897,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.777,
"layouts": 76,
"layoutDurationMs": 11.991,
"taskDurationMs": 327.75,
"heapDeltaBytes": -287244,
"heapUsedBytes": 96918260,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 121.684,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 59.9% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3126 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 40243eae5dcbc1ed19f81fe00c71c205441c962a
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (246)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 9fba378 | Docs | View more details | Give us feedback! |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
…sh entry (Comfy-Org#22576) ## Summary Locale collection rewrites `src/locales/en/commands.json` from the commands the running app has registered, so a command whose extension had not loaded is pruned. Nothing fails at that moment, because ESLint caches on file content and config rather than on catalog content — so the prune reaches a release branch and only surfaces later as an `@intlify/vue-i18n/no-missing-keys` error in an unrelated pull request. `Comfy.3DViewer.Open3DViewer` has been through that cycle three times: pruned by the 1.59.2 bump, restored by Comfy-Org#22130, pruned again by the 1.59.3 bump (`342a87f0d9`), and fixed at the source for the lazy 3D extension by Comfy-Org#22168. **The third prune is still live on `cloud/1.59` and is currently failing `lint-pr / lint` on six open carriers (Comfy-Org#22534–Comfy-Org#22539)** — which is how it was found. Comfy-Org#22168 fixed collection for that one extension; nothing fails when it happens to the next one. This adds the missing mechanical check. `scripts/check-command-locales.ts` reads command ids out of the source tree with the TypeScript AST — `commands: [...]` on a `ComfyExtension` and `const commands = [...]` as `useCoreCommands` declares them — and requires each one to keep a `commands.<normalized id>.label` string. It needs neither a browser nor a regeneration run, so it works on any branch. Two wiring points, for two different failure moments: - **`i18n-update-core.yaml`, right after `pnpm collect-i18n`** — fails the regeneration before the pruned catalog is translated and committed. This is the step that prunes, so failing here also avoids spending OpenAI tokens on a catalog that is about to be rejected. - **`repo-checks`** — catches an already-pruned branch on any pull request. `locale:check` compares the non-English catalogs against the English ones, so it cannot see a key missing from the English catalog itself. Non-obvious decisions: - A computed id (`id: \`Comfy.${suffix}\``) cannot be resolved statically. Those are counted and reported in the pass line rather than ignored silently or failed on. - The reverse direction is deliberately not checked. The catalog carries 122 entries against 113 statically declared ids, because some commands are registered only at runtime, so flagging catalog entries with no declaration would be false-positive-prone. - Comfy-Org#22168's one-key output assertion in `collect-i18n-general.ts` is left in place. This guard subsumes it, but removing it is a separate call for that file's author. ## Verification Red on the real broken states, green on the real repaired ones — not only on fixtures. | state | result | | --- | --- | | `main` at `ac70ad8a8c` | **pass** — 113 declared commands across 1661 files | | `origin/cloud/1.59` at `122b615f36` (live) | **fail**, exit 1 — `src/extensions/core/load3d/load3d.ts:60 command 'Comfy.3DViewer.Open3DViewer' has no commands.Comfy_3DViewer_Open3DViewer entry` | | same tree, with the 3-line entry restored | **pass** — 113 declared commands | | `342a87f0d9` (the 1.59.3 bump that pruned it) | **fail**, exit 1, same single finding | | `e05ecb7577` (Comfy-Org#22130's restore) | **pass** | So the guard would have failed the version-bump PR that reintroduced the defect, and fails the release branch that still carries it, naming the declaration site rather than a downstream call site. - Tests: `scripts/check-command-locales.test.ts`, 13 cases, hermetic (temp-directory trees, no network, no browser). Covers the AST cases — extension array, `const commands`, `as const` / `satisfies` unwrapping, a `menuCommands` reference array that must *not* count as a declaration, a computed id — and the catalog cases: missing entry, restored entry, absent/blank/`tooltip`-only label, duplicate declaration reported once, and test/`__tests__` files skipped so a fixture command needs no locale entry. `vitest run scripts/check-command-locales.test.ts` → 13 passed. - `pnpm typecheck:scripts` → exit 0. `pnpm knip` → exit 0. `pnpm format:check` → all 6469 files correct. `pnpm deps:audit`, `pnpm knip` and `pnpm fallow:audit` all pass via the `pre-push` hook, not bypassed. Both edited YAML files re-parsed and their step order asserted. - No manual repair is pushed to `cloud/1.59` or to Comfy-Org#22534–Comfy-Org#22539 here; that is the release owner's call and is tracked separately. ## Related - Comfy-Org#22168 (FE-3637) fixed collection for the lazy 3D extension; this adds the check that fails when the same thing happens to another extension. - Comfy-Org#22130 restored the entry the second time. Comfy-Org#22160 is complementary and independent: it makes the ESLint cache honest on `cloud/1.59` so the prune is *visible* sooner, while this makes the regeneration refuse to produce it.
…workflow (DES-1280) (#21836) The Run on menu in the Run bar, and its Workspace default submenu, keep one width and one row layout, so long Build names and mixed statuses no longer make them lopsided. With `deployment_compatibility_marks_enabled` on, the Run on menu also groups its rows by whether they can run the open workflow, using the compatibility check from #20372. Closes DES-1280. **Layout (everyone)** - Both menus are 336 px wide, and never wider than the space Reka reports for them (`--reka-dropdown-menu-content-available-width`). - Each row has four columns: the Build name (takes the free space and truncates first), the deployment name (64 px), the Release version when ready or else the status, and the check. - A row whose text is cut off shows its full label in a tooltip to the left, on hover or keyboard focus. - Failed reads Failed with an orange dot, in the menu and on the Run bar button. Stopping reads Stopping. Queued reads Starting. - The row this browser runs on comes first. - Footer link: Manage deployments with deployments, Create a custom deployment without; both open Platform's Builds page (`/profile/builds`) in a new tab. Before, it opened the Builds section of the Deploy page. - Both menus build their rows from one helper, `deploymentRowLabels`. **Grouping (behind `deployment_compatibility_marks_enabled`)** - The inline marks ("Runs this workflow", "Missing N nodes", "Not checked") are gone. A row that cannot run the open workflow names the missing nodes on hover and in its accessible description. A row the check could not read says "Could not check whether X can run this workflow." - When the check answers, the current row sits alone under "Running on". The rows that run the workflow follow under "Compatible environments", and all other rows under "Incompatible environments". A group whose only row was the current one is left out. Comfy Cloud goes in whichever group it belongs to. A deployment the check could not read goes under "Incompatible environments". - The menu stays one "Run on" list while the flag is off, if the check fails, if every row is in one group, or until the check has answered for every listed row. - When the answer regroups the open menu, keyboard focus stays on the same row, and arrow keys keep moving through the menu. Design: the "Deployment menu" canvas, https://claude.ai/artifact/MGGME6U7xjXtberxNaoNUy (boards R2 to R11 for the rows, F1 for the groups). - `sectionRows` in `useDeploymentRows.ts` is a pure function that decides the groups, tested as a table in `useDeploymentRows.test.ts`. Each group is its own radio group, labelled by its header, with the same picked value. - `useKeepRowFocus.ts`: the groups are keyed by name, so regrouping re-creates every row and focus fell to the page. It notes the focused row's `data-focus-row` before the re-render and focuses the same row after, also when a listing refresh only moves the row, since a moved element loses focus. It does not keep stale answers, so #21897 stands. - Rows show their checked state with `aria-checked` styles, not `data-state=checked`: the tooltip wrapper puts its own `data-state` on the row. - Current row on top: a "Running on" group of one above the two groups, over moving the current row's group first or putting the row first in its own group. Trade-off: when the current deployment cannot run the workflow, its row does not sit under "Incompatible environments"; only its tooltip and description say so. - Group names: Eric Sun asked for "Compatible/incompatible environments" in the Homestead dogfooding thread. "Environments" covers Comfy Cloud as well as deployments. - DES-1279 is split in two, stacked on this PR: #21858 (only a ready deployment can be picked), and #21839 (start a stopped deployment) on - When the answer arrives with the menu open, the rows still move under the pointer; a click during the move can land on a different row. Opening the menu reloads the listing, and a changed status re-runs the check, so this happens on ordinary opens. - Unit: `DeploymentSwitcher.test.ts`, `useDeploymentRows.test.ts`, `useDeploymentLabels.test.ts`, `ComfyActionbar.test.ts` and `CurrentUserButton.test.ts` pass (122). The focus tests fail without `useKeepRowFocus`, and the moved-row one without its check that the row still has focus; the Build name tooltip test fails without measuring the Build name; the Workspace default column test fails without the detail binding. - Browser: the screenshots are from earlier heads of this PR (local Cloud dev build, mocked listing and compatibility answer, 1440 px). Since then the Comfy Cloud row renders an empty deployment column (seen in a local Storybook with the switcher forced on), the width cap uses Reka's available width, and focus is kept through regrouping; the last two were not re-checked in a browser. | State | Before (main) | After | | --- | --- | --- | | Several deployments, on Comfy Cloud | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-02-open-several-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-02-open-several-after.png"> | | On a deployment | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-03b-open-active-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-03b-open-active-after.png"> | | Long Build and deployment names | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-04-long-names-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-04-long-names-after.png"> | | No deployments | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-05-empty-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-05-empty-after.png"> | | Every status | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-06-statuses-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-06-statuses-after.png"> | | Owner, Workspace default | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-08-default-submenu-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-08-default-submenu-after.png"> | | Mixed states | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-11-mixed-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-11-mixed-after.png"> | | Compatibility check on | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-compat-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-compat-after.png"> | The current deployment cannot run the workflow: <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-current-incompatible.png"> A cut-off row on hover, and a row that cannot run the workflow: <img width="700" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-12-mixed-tooltip.png"> <img width="700" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-s2-sections-missing-tooltip.png"> --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> (cherry picked from commit c53b293)
e01f663 to
9fba378
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## bl/cloud-1.59-unsupported-packs #22534 +/- ##
==================================================================
Coverage 87.24% 87.25%
==================================================================
Files 3038 3040 +2
Lines 159803 159862 +59
Branches 42651 40154 -2497
==================================================================
+ Hits 139425 139484 +59
Misses 19699 19699
Partials 679 679
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #21836 to
cloud/1.59. The Run on menu groups deployments by whether they can run the open workflow and keeps its rows aligned.Part 2 of 9 in the Cloud workflow deployment backport stack. Uses 1.59's local menu/tooltip components and preserves its submenu portal.
Verification
cloud/1.59at7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, inSignUpForm.test.ts, is intermittent and also fails oncloud/1.59without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.