Repository navigation
[backport cloud/1.59] explain custom-node packs that failed to load (#21957) - #22533
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T00:07:36.898Z",
"gitSha": "118c8bce2e3df98ac7c71c839cdb8488438a8e40",
"branch": "bl/cloud-1.59-unsupported-packs",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.3789999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.037000000000001,
"layouts": 9,
"layoutDurationMs": 3.247,
"taskDurationMs": 570.5790000000001,
"heapDeltaBytes": 956064,
"heapUsedBytes": 63106424,
"domNodes": -161,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.618000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.713000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8989999999999996,
"layouts": 9,
"layoutDurationMs": 2.5610000000000004,
"taskDurationMs": 687.864,
"heapDeltaBytes": 1915424,
"heapUsedBytes": 63627128,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 15.088999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.3080000000132,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.038000000000002,
"layouts": 9,
"layoutDurationMs": 2.349,
"taskDurationMs": 825.858,
"heapDeltaBytes": 22262080,
"heapUsedBytes": 84019448,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 156.32399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.5489999999645,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.315000000000001,
"layouts": 9,
"layoutDurationMs": 2.504,
"taskDurationMs": 1021.557,
"heapDeltaBytes": 21773788,
"heapUsedBytes": 83385996,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 179.532,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.5269999999841,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.512,
"layouts": 9,
"layoutDurationMs": 2.481,
"taskDurationMs": 380.957,
"heapDeltaBytes": -988708,
"heapUsedBytes": 60596044,
"domNodes": 56,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9.227000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.5899999999974,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.0809999999999995,
"layouts": 10,
"layoutDurationMs": 2.843,
"taskDurationMs": 441.83099999999996,
"heapDeltaBytes": 489644,
"heapUsedBytes": 69424688,
"domNodes": 56,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 13.113,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.2290000000294,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.692,
"layouts": 10,
"layoutDurationMs": 2.489,
"taskDurationMs": 477.624,
"heapDeltaBytes": 7834816,
"heapUsedBytes": 76755036,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 163.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 778.6510000000817,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.723,
"layouts": 8,
"layoutDurationMs": 2.363,
"taskDurationMs": 559.6690000000001,
"heapDeltaBytes": 5435144,
"heapUsedBytes": 66274716,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 184.567,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.2200000000435,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 875.577,
"heapDeltaBytes": -12046556,
"heapUsedBytes": 75864332,
"domNodes": -191,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 65.508,
"eventListeners": -107,
"totalBlockingTimeMs": 505,
"frameDurationMs": 31.981081081081086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1461.9000000000142,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.0370000000003,
"heapDeltaBytes": -1179080,
"heapUsedBytes": 75460524,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 73.346,
"eventListeners": -107,
"totalBlockingTimeMs": 758,
"frameDurationMs": 39.18648648648648,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.760000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.09899999999993,
"heapDeltaBytes": -4667684,
"heapUsedBytes": 69857424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.07399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 933.8179999999738,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.8389999999994,
"heapDeltaBytes": -28802688,
"heapUsedBytes": 66960760,
"domNodes": -191,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 178.12600000000006,
"eventListeners": -107,
"totalBlockingTimeMs": 252,
"frameDurationMs": 25.224324324324353,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10021.937000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9177.327,
"heapDeltaBytes": 63363216,
"heapUsedBytes": 137086564,
"domNodes": -257,
"jsHeapTotalBytes": 56487936,
"scriptDurationMs": 7307.3369999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 848,
"frameDurationMs": 31.5090625,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12389.985000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11568.519,
"heapDeltaBytes": -6550160,
"heapUsedBytes": 67376400,
"domNodes": -257,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 9209.692000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1643,
"frameDurationMs": 31.832390745501282,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10334.339,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9593.081,
"heapDeltaBytes": 70500152,
"heapUsedBytes": 145219692,
"domNodes": -257,
"jsHeapTotalBytes": 65662976,
"scriptDurationMs": 7752.380999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 892,
"frameDurationMs": 31.59908256880734,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11370.036000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10539.981000000002,
"heapDeltaBytes": 69653056,
"heapUsedBytes": 143471096,
"domNodes": -257,
"jsHeapTotalBytes": 71692288,
"scriptDurationMs": 8401.787,
"eventListeners": -69,
"totalBlockingTimeMs": 1328,
"frameDurationMs": 31.22582417582418,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 286.28600000001825,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.286,
"layouts": 12,
"layoutDurationMs": 3.9,
"taskDurationMs": 232.91699999999997,
"heapDeltaBytes": -16819336,
"heapUsedBytes": 58490028,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 9.847,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.75454545454547,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 277.73899999999685,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.552,
"layouts": 8,
"layoutDurationMs": 2.947999999999999,
"taskDurationMs": 230.41500000000002,
"heapDeltaBytes": -924760,
"heapUsedBytes": 68674328,
"domNodes": -2315,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 10.717999999999998,
"eventListeners": -574,
"totalBlockingTimeMs": 8,
"frameDurationMs": 22.216666666666697,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "large-graph-idle",
"durationMs": 2039.1910000000166,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.560999999999999,
"layouts": 8,
"layoutDurationMs": 2.224,
"taskDurationMs": 634.2589999999999,
"heapDeltaBytes": 5841588,
"heapUsedBytes": 86177928,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.235,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.833000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.05,
"layouts": 8,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 665.5609999999999,
"heapDeltaBytes": -15304976,
"heapUsedBytes": 60601400,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 38.263000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2284.4649999999547,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.5569999999999995,
"layouts": 5,
"layoutDurationMs": 1.193,
"taskDurationMs": 1590.2779999999996,
"heapDeltaBytes": -9785484,
"heapUsedBytes": 72537384,
"domNodes": -257,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 788.743,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2807.4080000000095,
"styleRecalcs": 64,
"styleRecalcDurationMs": 7.721,
"layouts": 3,
"layoutDurationMs": 0.8710000000000002,
"taskDurationMs": 1775.5249999999999,
"heapDeltaBytes": 15577628,
"heapUsedBytes": 76987496,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 870.734,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665680473372785,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3889.9640000000204,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.769,
"layouts": 64,
"layoutDurationMs": 10.626,
"taskDurationMs": 1902.1680000000001,
"heapDeltaBytes": -9643820,
"heapUsedBytes": 84308228,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 827.863,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665811965811965,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3685.049999999933,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.001999999999999,
"layouts": 63,
"layoutDurationMs": 10.202,
"taskDurationMs": 1797.5579999999998,
"heapDeltaBytes": -8299080,
"heapUsedBytes": 70321732,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 777.391,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66561085972851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3001.856000000032,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.822,
"layouts": 6,
"layoutDurationMs": 1.4720000000000002,
"taskDurationMs": 1922.5339999999997,
"heapDeltaBytes": 17305216,
"heapUsedBytes": 90697052,
"domNodes": 0,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 942.116,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3066.9129999999996,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.976,
"layouts": 5,
"layoutDurationMs": 1.1450000000000002,
"taskDurationMs": 1967.8530000000003,
"heapDeltaBytes": 9739600,
"heapUsedBytes": 81593932,
"domNodes": 0,
"jsHeapTotalBytes": 3633152,
"scriptDurationMs": 965.763,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.847282608695654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3135.362999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0610000000000004,
"layouts": 7,
"layoutDurationMs": 1.8539999999999996,
"taskDurationMs": 869.1880000000001,
"heapDeltaBytes": -20628548,
"heapUsedBytes": 73039168,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 392.64500000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542553191489,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3263.2939999999735,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3570000000000007,
"layouts": 5,
"layoutDurationMs": 1.1250000000000002,
"taskDurationMs": 971.3620000000001,
"heapDeltaBytes": -15130828,
"heapUsedBytes": 69056176,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 457.81899999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.8619999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2309999999999994,
"layouts": 8,
"layoutDurationMs": 2.411,
"taskDurationMs": 627.4259999999999,
"heapDeltaBytes": -15506360,
"heapUsedBytes": 65475052,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.152000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.01300000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.289,
"layouts": 8,
"layoutDurationMs": 2.1630000000000003,
"taskDurationMs": 633.6659999999999,
"heapDeltaBytes": -3289836,
"heapUsedBytes": 76189656,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.256999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2756.142000000011,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.131999999999998,
"layouts": 8,
"layoutDurationMs": 1.7659999999999998,
"taskDurationMs": 591.985,
"heapDeltaBytes": -28359060,
"heapUsedBytes": 65434860,
"domNodes": -255,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 186.942,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3029.451999999992,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.604999999999999,
"layouts": 5,
"layoutDurationMs": 1.677,
"taskDurationMs": 745.1569999999999,
"heapDeltaBytes": -17867188,
"heapUsedBytes": 76060220,
"domNodes": -253,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 220.678,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3217.1650000000227,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.141999999999999,
"layouts": 7,
"layoutDurationMs": 1.6650000000000003,
"taskDurationMs": 913.421,
"heapDeltaBytes": -14900628,
"heapUsedBytes": 62138544,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 352.70599999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665803108808287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3402.740999999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3490000000000004,
"layouts": 5,
"layoutDurationMs": 1.5839999999999999,
"taskDurationMs": 1088.4279999999999,
"heapDeltaBytes": -11254168,
"heapUsedBytes": 66436780,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 411.997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748275862068965,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5179999999837,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.638,
"layouts": 9,
"layoutDurationMs": 2.6559999999999997,
"taskDurationMs": 428.23300000000006,
"heapDeltaBytes": 1108748,
"heapUsedBytes": 63021924,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 144.816,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.9749999999585,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.789000000000001,
"layouts": 9,
"layoutDurationMs": 2.38,
"taskDurationMs": 440.32899999999995,
"heapDeltaBytes": -1345596,
"heapUsedBytes": 61123856,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.52900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.7420000000075,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.299000000000001,
"layouts": 9,
"layoutDurationMs": 2.568,
"taskDurationMs": 502.483,
"heapDeltaBytes": 2664180,
"heapUsedBytes": 64782544,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.453000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3049999999999997,
"layouts": 9,
"layoutDurationMs": 3.009,
"taskDurationMs": 682.2309999999999,
"heapDeltaBytes": 5588124,
"heapUsedBytes": 77660984,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 14.854000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5460000000362,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.938000000000002,
"layouts": 9,
"layoutDurationMs": 2.326,
"taskDurationMs": 806.145,
"heapDeltaBytes": 17584876,
"heapUsedBytes": 80259576,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 105.012,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1808.7249999999813,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.496,
"layouts": 9,
"layoutDurationMs": 2.876,
"taskDurationMs": 994.0000000000001,
"heapDeltaBytes": 19984492,
"heapUsedBytes": 83522248,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 132.843,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1486.0419999999976,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.990999999999996,
"layouts": 5,
"layoutDurationMs": 14.374,
"taskDurationMs": 1202.699,
"heapDeltaBytes": 16453416,
"heapUsedBytes": 118311668,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 33.48,
"eventListeners": 3246,
"totalBlockingTimeMs": 176,
"frameDurationMs": 20.319178082191783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9162.980000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.669999999999998,
"layouts": 9,
"layoutDurationMs": 2.4299999999999997,
"taskDurationMs": 5934.595,
"heapDeltaBytes": 5717288,
"heapUsedBytes": 85181416,
"domNodes": -257,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 2715.427,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8977.317000000085,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.185000000000002,
"layouts": 7,
"layoutDurationMs": 1.9009999999999998,
"taskDurationMs": 5889.896000000001,
"heapDeltaBytes": 3538316,
"heapUsedBytes": 82638640,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2736.383,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696840148698882,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23456.368999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22850.353000000003,
"heapDeltaBytes": -39213440,
"heapUsedBytes": 252946920,
"domNodes": -3343,
"jsHeapTotalBytes": 10477568,
"scriptDurationMs": 332.364,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.56937716262976,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 22704.441999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21964.450999999997,
"heapDeltaBytes": -24497480,
"heapUsedBytes": 258158124,
"domNodes": -3343,
"jsHeapTotalBytes": 8380416,
"scriptDurationMs": 295.754,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.24290657439447,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27558.021999999994,
"styleRecalcs": 180,
"styleRecalcDurationMs": 22.337999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27167.138000000003,
"heapDeltaBytes": 2817304,
"heapUsedBytes": 285539048,
"domNodes": -3343,
"jsHeapTotalBytes": 16171008,
"scriptDurationMs": 934.331,
"eventListeners": -651,
"totalBlockingTimeMs": 56,
"frameDurationMs": 52.40608365019012,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27440.058000000023,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.651,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27096.054000000004,
"heapDeltaBytes": -40548584,
"heapUsedBytes": 261735424,
"domNodes": -3343,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 879.972,
"eventListeners": -651,
"totalBlockingTimeMs": 78,
"frameDurationMs": 52.283619047619055,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8174.581000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.634,
"layouts": 20,
"layoutDurationMs": 22.564,
"taskDurationMs": 8031.392000000001,
"heapDeltaBytes": -11273772,
"heapUsedBytes": 280271712,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 118.295,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7848.875999999905,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.53799999999998,
"layouts": 20,
"layoutDurationMs": 20.09699999999999,
"taskDurationMs": 7723.912,
"heapDeltaBytes": -43441224,
"heapUsedBytes": 248075940,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 104.93399999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.03846153846154,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12127.047000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11802.962999999998,
"heapDeltaBytes": -18072456,
"heapUsedBytes": 264610660,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 173.92399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.965248226950344,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11151.221999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10771.168000000001,
"heapDeltaBytes": 7769904,
"heapUsedBytes": 259285296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.84799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.713541666666664,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 154.97199999998656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.415000000000001,
"layouts": 8,
"layoutDurationMs": 4.923,
"taskDurationMs": 105.22299999999998,
"heapDeltaBytes": 4775620,
"heapUsedBytes": 66880284,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.394999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 131.4710000000332,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.017000000000001,
"layouts": 8,
"layoutDurationMs": 3.9450000000000007,
"taskDurationMs": 90.56,
"heapDeltaBytes": 4601704,
"heapUsedBytes": 64566540,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.258999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.61200000002646,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.634,
"layouts": 76,
"layoutDurationMs": 14.516,
"taskDurationMs": 422.284,
"heapDeltaBytes": -4418864,
"heapUsedBytes": 39373952,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 206.31,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 482.1980000000394,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.614,
"layouts": 76,
"layoutDurationMs": 14.858,
"taskDurationMs": 437.29400000000004,
"heapDeltaBytes": -4285488,
"heapUsedBytes": 39567512,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 212.10299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 549.8880000000099,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.053,
"layouts": 76,
"layoutDurationMs": 14.856,
"taskDurationMs": 520.417,
"heapDeltaBytes": 478416,
"heapUsedBytes": 94609384,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 208.98600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 516.371999999933,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.734,
"layouts": 76,
"layoutDurationMs": 14.988,
"taskDurationMs": 483.064,
"heapDeltaBytes": 802920,
"heapUsedBytes": 99134788,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 193.047,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.200000000000024,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 60.0% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3134 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7482c071906d8f9cc2b3932629ba22248940d879
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (243)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d7eb020e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * The packs the build of the Release this browser's deployment runs now | ||
| * could not load, and why, with that Release's id; empty on Comfy Cloud. | ||
| * GET /api/release/unsupported-packs |
There was a problem hiding this comment.
Shorten the new API JSDoc to the permitted contract
The new JSDoc contains three content lines, exceeding the explicit AGENTS.md exception allowing only one or two contract lines on exported APIs. Remove the redundant endpoint line, which is already visible in the request below, to bring this addition within the repository's review requirements.
AGENTS.md reference: AGENTS.md:L270-L273
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22533 +/- ##
=============================================
Coverage ? 87.24%
=============================================
Files ? 3038
Lines ? 159803
Branches ? 42651
=============================================
Hits ? 139425
Misses ? 19699
Partials ? 679
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
…build (#21957) **Why** On a Homestead deployment, a custom node pack the customer's build could not load shows up today as a red placeholder and a bare entry in the missing-node card, so the person cannot tell whether the node is missing, broken, or not supported on that build. Rob reported this in [#pillar3-dev-platform-feedback](https://comfy-organization.slack.com/archives/C0BN4TN2LMB/p1792971608213479); the build already records why each pack failed, and this PR shows that reason on the card. ## What changes On Comfy Cloud, a person opens the editor on a picked Homestead deployment and loads a workflow with a node from a custom node pack that the deployment's build could not load (for example `RTXTrueHDR` from NVIDIA VFX). - **Before:** the node is a red placeholder. The missing-node card ("These nodes aren't on {deployment}") lists the pack with no reason. - **After:** the pack's row also says why, for example "Not supported on this build: NVIDIA VFX needs a GPU to load". When the build gave no reason, the row says "Not supported on this build". The list of packs comes from ingest's `GET /api/release/unsupported-packs` (added in Comfy-Org/cloud#16408). If that call fails, returns no packs, or returns the list of a release other than the one the page loaded, the card looks exactly as it does today. ## How it works - `deploymentPickStore` asks for the list once, when the page has booted on a deployment (`bootDeployment`). Standard Cloud with no pick never sets a boot deployment, and neither does a local install, so neither makes the request. - Ingest answers for the deployment's current release, which an owner can update while the page loads, and names that release in `release_id`. The store keeps the packs only when `release_id` equals the `release_id` of the deployment the page booted on (`bootDeployment.release_id`, from the boot deployment listing). Another release, no release (`null`), or a failed call leaves today's card. - The pack row matches a node's `cnrId` to a pack's `registry_id` first, then to its `folder`. A node with no `cnrId` gets no reason. - `@comfyorg/ingest-types` is regenerated by the package's own generator from ingest's `openapi.yaml` for the new route (first commit). ## Chosen behaviour, where it differs from the ticket - **No refetch when the deployment changes.** Switching deployment already reloads the page (`deploymentSwitchReload.ts`). The editor keeps the node list it booted with until then, so the list is fetched again on that reload. - **No flag check in the browser.** Ingest applies `cloud_on_customer_build_enabled`. With the flag off the deployment listing is refused, so no boot deployment is set and no request is made. - **The match runs when the row is drawn,** not when nodes are scanned (the ticket said to fill `hint`). That way it is right whichever arrives first, the list or the scan, and the scan code stays as it is. - **A failed call is logged as a warning** (`reportError`) with no toast. ## Tests - `deploymentPickStore.test.ts`: asks once the page boots on a deployment; matches by registry id, then by folder, and prefers the registry id; does not ask with no pick, with the listing refused (403, flag off), on an ingest without the route (404), or when the listing never answered; a 502, a network error or a bad body leaves no match and reports once; keeps the boot build's packs when a later listing names another deployment; asks again after a switch reloads onto a different deployment. Drops the packs when the answer names another release than the page booted on, both while the deployment listing still names the boot release and once it names the new one, and when the answer names no release; reads the deployment listing only once. - `workspaceApi.test.ts`: sends the GET and reads the packs and their `release_id`; rejects a body without `packs`. - `MissingPackGroupRow.test.ts`: shows the cause as logged, including apostrophes, `<`, `/` and `&` (no HTML escaping); shows the short copy when there is no cause; shows nothing for nodes with no `cnrId` or with no matching pack. - With the store, row, API and locale changes reverted, 18 of these tests fail; with them, all tests in these files and `deploymentPickState.test.ts` pass (276). Screenshots: in the review ask's Slack thread (light, dark, phone width, no reason, and today's card). Try it: needs Comfy-Org/cloud#16408 on staging first. Then on staging Cloud, pick a Homestead deployment whose build could not load a pack, load a workflow with a node from that pack, and open the errors tab: the pack's row reads "Not supported on this build: <reason>". Not run: a real Cloud page against a live ingest build, the card at narrow widths, keyboard and screen-reader passes. Ref BE-23485 (cherry picked from commit 9243ab4)
…59.3 bump
`lint-pr / lint` fails on this carrier with
'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
message resources @intlify/vue-i18n/no-missing-keys
in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.
The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.
Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.
(cherry picked from commit a358582)
caa437c to
40243ea
Compare
Summary
Backport of #21957 to
cloud/1.59. A custom node pack that failed to load now shows the build's reason, and the deployment store exposes that reason to the later Edit build panel.Part 1 of 9 in the Cloud workflow deployment backport stack. The unsupported-packs endpoint and schemas are already on
cloud/1.59through #22027, so the generated API files are unchanged. Also restores the 3D viewer command locale key the 1.59.3 version bump dropped, which lint requires.Verification
cloud/1.59at7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, inSignUpForm.test.ts, is intermittent and also fails oncloud/1.59without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.