Repository navigation
[backport cloud/1.58] fix(agent): move an agent-inserted workflow clear of the nodes it lands on (#21527) - #22529
Conversation
…ds on (#21527) ## Summary When the agent inserts a workflow into a tab that already has nodes, the inserted nodes can land on top of the existing graph ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). `get_template` commits as one `insert_workflow` op that carries the template's baked-in coordinates, and neither cloud nor comfy-multi-player translates them. The follower's placement (ADR-CRDT-PLACEMENT-0035, from [PM-1142](https://linear.app/comfyorg/issue/PM-1142)) only moved a batch that landed far away and offscreen, so a batch landing on the user's nodes kept its overlapping position. The Z-Image template spans x −420 to 1350, the same region as the default workflow. Now, in a live frame written by an agent turn, a created batch with any node that intersects an existing node moves beside the existing content by the same single offset. The batch's internal layout is unchanged. Catch-up frames, tab-return applies and human writes are excluded, so a node a human pasted over another is not moved when the follower resubscribes (`agentPastedNodeOrphanedOnRetarget.spec.ts` catches that if the scope is dropped). Behavior change to an existing pin: `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` asserted that two inserts of the same template render pixel-identically on top of each other. The second copy now lands beside the first. Its op fixture also used `agent:e2e`, which fails the actor grammar and is dropped by the follower; it now uses `agent:<thread>:<turn>` as cloud stamps it. Known limitation, recorded in the ADR: an agent insert that lands while its tab is inactive is applied on tab return without collision placement, because the collected changes do not record their writer. ## Verification - New black-box case `browser_tests/tests/agent/agentInsertWorkflowOverlap.spec.ts`: a canvas with three nodes, then one `insert_workflow` carrying the Z-Image template's node rects. Fails on `main` (`inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)`), passes here; also asserts the template's relative layout is preserved. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` side-by-side assertion fails on `main`, passes here. - Unit: `batchPlacement.test.ts` (collision cases, hull-interior non-collision stays put) and `liveGraphApplier.test.ts` (a live agent batch moves, a replayed one does not). Both fail on `main`. - `pnpm exec vitest run src/workbench/extensions/agent`: 177 files, 4027 passed. - Full `browser_tests/tests/agent` on the `cloud` project locally: 352 of 355 passed. The three failures (two `agentConversationReplay` screenshot comparisons and `agentReplyDrafts` "keeps its run approval action live", which already passes under `test.fail`) fail identically on `main` in the same environment. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt clean. (cherry picked from commit bc0250c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-31T20:45:15.651Z",
"gitSha": "8242def13406a4f0f2eabd04c3e3581837585054",
"branch": "backport-21527-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2044.429000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7040000000000006,
"layouts": 8,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 451.56100000000004,
"heapDeltaBytes": -1607304,
"heapUsedBytes": 85972372,
"domNodes": -201,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 11.147,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.6829999999918,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.111,
"layouts": 10,
"layoutDurationMs": 3.1540000000000004,
"taskDurationMs": 509.864,
"heapDeltaBytes": 1440968,
"heapUsedBytes": 89335636,
"domNodes": -200,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 11.182,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.5199999999954,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.373,
"layouts": 9,
"layoutDurationMs": 2.604,
"taskDurationMs": 839.1899999999999,
"heapDeltaBytes": 1968312,
"heapUsedBytes": 89916212,
"domNodes": -200,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 175.02200000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.4119999999893,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.982999999999999,
"layouts": 8,
"layoutDurationMs": 2.437,
"taskDurationMs": 842.5749999999999,
"heapDeltaBytes": 1923572,
"heapUsedBytes": 91170900,
"domNodes": -180,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 175.001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.6640000000175,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.451999999999999,
"layouts": 10,
"layoutDurationMs": 2.7489999999999997,
"taskDurationMs": 469.03399999999993,
"heapDeltaBytes": 21551068,
"heapUsedBytes": 109053176,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 15.175999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.4229999999898,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.230000000000001,
"layouts": 11,
"layoutDurationMs": 3.25,
"taskDurationMs": 371.11400000000003,
"heapDeltaBytes": 21519088,
"heapUsedBytes": 112181480,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 13.629,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 643.3090000000163,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.858,
"layouts": 9,
"layoutDurationMs": 2.659,
"taskDurationMs": 456.975,
"heapDeltaBytes": 579836,
"heapUsedBytes": 88545588,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 177.155,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 657.7230000000327,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.137,
"layouts": 9,
"layoutDurationMs": 2.8119999999999994,
"taskDurationMs": 473.76400000000007,
"heapDeltaBytes": 662104,
"heapUsedBytes": 88644392,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 176.983,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1293.533000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 959.4650000000001,
"heapDeltaBytes": -16384788,
"heapUsedBytes": 102504348,
"domNodes": -230,
"jsHeapTotalBytes": 15093760,
"scriptDurationMs": 79.34600000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 607,
"frameDurationMs": 35.132432432432424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1338.6340000000132,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.554,
"heapDeltaBytes": -1360900,
"heapUsedBytes": 102464808,
"domNodes": -230,
"jsHeapTotalBytes": 11112448,
"scriptDurationMs": 82.359,
"eventListeners": -168,
"totalBlockingTimeMs": 640,
"frameDurationMs": 35.08421052631581,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.1530000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.48600000000044,
"heapDeltaBytes": -3203292,
"heapUsedBytes": 98458576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.937,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.8100000000154,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.3549999999996,
"heapDeltaBytes": -2886772,
"heapUsedBytes": 94846552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.74799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10911.193999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10011.87,
"heapDeltaBytes": -8256312,
"heapUsedBytes": 112168424,
"domNodes": -276,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 8044.506,
"eventListeners": -130,
"totalBlockingTimeMs": 1201,
"frameDurationMs": 31.50173410404624,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9971.61299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9161.726,
"heapDeltaBytes": 18429976,
"heapUsedBytes": 139582772,
"domNodes": -276,
"jsHeapTotalBytes": 32047104,
"scriptDurationMs": 7615.668,
"eventListeners": -130,
"totalBlockingTimeMs": 1089,
"frameDurationMs": 31.8408945686901,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10150.42600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9371.77,
"heapDeltaBytes": 29621444,
"heapUsedBytes": 134076080,
"domNodes": -296,
"jsHeapTotalBytes": 21639168,
"scriptDurationMs": 7783.6990000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 1103,
"frameDurationMs": 32.01735015772871,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10814.245999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10042.08,
"heapDeltaBytes": 18834752,
"heapUsedBytes": 140351156,
"domNodes": -296,
"jsHeapTotalBytes": 31522816,
"scriptDurationMs": 8014.851000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1229,
"frameDurationMs": 31.35159420289855,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 216.16000000000213,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.055,
"layouts": 11,
"layoutDurationMs": 3.4589999999999996,
"taskDurationMs": 168.676,
"heapDeltaBytes": 13194752,
"heapUsedBytes": 118464596,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.116000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.329999999999927,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 280.44599999998354,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.279000000000003,
"layouts": 12,
"layoutDurationMs": 3.84,
"taskDurationMs": 226.09999999999997,
"heapDeltaBytes": 15453520,
"heapUsedBytes": 118120480,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.253,
"eventListeners": 196,
"totalBlockingTimeMs": 7,
"frameDurationMs": 23.60833333333335,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2053.501000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.581,
"layouts": 8,
"layoutDurationMs": 2.354,
"taskDurationMs": 521.7,
"heapDeltaBytes": 277732,
"heapUsedBytes": 102091804,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 34.949000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.684999999902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.279000000000001,
"layouts": 8,
"layoutDurationMs": 3.1660000000000004,
"taskDurationMs": 739.657,
"heapDeltaBytes": -30764052,
"heapUsedBytes": 90574144,
"domNodes": -296,
"jsHeapTotalBytes": -1888256,
"scriptDurationMs": 35.247,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2284.2979999999784,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.977,
"layouts": 7,
"layoutDurationMs": 2.1329999999999996,
"taskDurationMs": 1580.1349999999998,
"heapDeltaBytes": 1999768,
"heapUsedBytes": 104563428,
"domNodes": -276,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 846.5619999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.913333333333334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2290.4359999999997,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.014000000000001,
"layouts": 4,
"layoutDurationMs": 1.2359999999999998,
"taskDurationMs": 1566.3290000000002,
"heapDeltaBytes": -3630140,
"heapUsedBytes": 103794416,
"domNodes": -296,
"jsHeapTotalBytes": -1204224,
"scriptDurationMs": 842.6329999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.9125925925926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3640.8539999999903,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.046,
"layouts": 65,
"layoutDurationMs": 11.349,
"taskDurationMs": 1673.7630000000001,
"heapDeltaBytes": -11830172,
"heapUsedBytes": 92523300,
"domNodes": -272,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 813.4899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3650.3730000000587,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.082,
"layouts": 64,
"layoutDurationMs": 10.968,
"taskDurationMs": 1675.6419999999998,
"heapDeltaBytes": -11458376,
"heapUsedBytes": 92591088,
"domNodes": -252,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 795.493,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3115.0749999999903,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.231,
"layouts": 4,
"layoutDurationMs": 1.293,
"taskDurationMs": 1881.8500000000001,
"heapDeltaBytes": 20415864,
"heapUsedBytes": 126331656,
"domNodes": 0,
"jsHeapTotalBytes": 7237632,
"scriptDurationMs": 1031.806,
"eventListeners": 182,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.116216216216216,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3223.90299999995,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.797999999999999,
"layouts": 3,
"layoutDurationMs": 0.7599999999999998,
"taskDurationMs": 2027.7530000000002,
"heapDeltaBytes": -11240956,
"heapUsedBytes": 98953092,
"domNodes": 0,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 985.1110000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.01631578947368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.5869999999882,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5069999999999997,
"layouts": 7,
"layoutDurationMs": 2.277,
"taskDurationMs": 636.195,
"heapDeltaBytes": 1260952,
"heapUsedBytes": 109873652,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 40.339999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.278000000043,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9680000000000002,
"layouts": 7,
"layoutDurationMs": 2.0629999999999997,
"taskDurationMs": 476.2609999999999,
"heapDeltaBytes": 807092,
"heapUsedBytes": 103865740,
"domNodes": -296,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 33.286,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 635.1419999999735,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.5889999999999995,
"layouts": 10,
"layoutDurationMs": 3.261,
"taskDurationMs": 449.608,
"heapDeltaBytes": 22447832,
"heapUsedBytes": 112383688,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 158.04000000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736848,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.3420000000069,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.608,
"layouts": 9,
"layoutDurationMs": 3.3089999999999997,
"taskDurationMs": 413.188,
"heapDeltaBytes": 25116412,
"heapUsedBytes": 114735540,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 154.624,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.670000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.777,
"layouts": 9,
"layoutDurationMs": 2.5000000000000004,
"taskDurationMs": 595.108,
"heapDeltaBytes": -715812,
"heapUsedBytes": 89234480,
"domNodes": -218,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 9.078999999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.0790000000525,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1839999999999993,
"layouts": 10,
"layoutDurationMs": 3.1049999999999995,
"taskDurationMs": 600.6850000000001,
"heapDeltaBytes": -782952,
"heapUsedBytes": 91193268,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.799,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2008.5990000000038,
"styleRecalcs": 88,
"styleRecalcDurationMs": 15.503,
"layouts": 9,
"layoutDurationMs": 2.4979999999999998,
"taskDurationMs": 1161.287,
"heapDeltaBytes": -3828008,
"heapUsedBytes": 85979584,
"domNodes": -210,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 117.844,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1994.7409999999763,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.558,
"layouts": 10,
"layoutDurationMs": 2.9549999999999996,
"taskDurationMs": 1018.997,
"heapDeltaBytes": -4107576,
"heapUsedBytes": 85926756,
"domNodes": -210,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 120.71499999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.8790000000195,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.135000000000005,
"layouts": 5,
"layoutDurationMs": 16.575000000000003,
"taskDurationMs": 1082.825,
"heapDeltaBytes": 16507304,
"heapUsedBytes": 137693364,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 30.745000000000008,
"eventListeners": 3244,
"totalBlockingTimeMs": 156,
"frameDurationMs": 20.089041095890412,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8335.975000000019,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.769,
"layouts": 7,
"layoutDurationMs": 2.007,
"taskDurationMs": 5334.197999999999,
"heapDeltaBytes": 1891148,
"heapUsedBytes": 103575768,
"domNodes": -296,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 2712.853,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73319919517103,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8388.393000000066,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.734000000000005,
"layouts": 8,
"layoutDurationMs": 2.4290000000000003,
"taskDurationMs": 5743.535,
"heapDeltaBytes": 4347396,
"heapUsedBytes": 110055468,
"domNodes": -276,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 2921.608,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600397614314,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22651.234999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22035.398,
"heapDeltaBytes": -26151892,
"heapUsedBytes": 298163360,
"domNodes": -3344,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 326.051,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.63419117647059,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 16229.968999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15087.207000000002,
"heapDeltaBytes": -32314944,
"heapUsedBytes": 274444472,
"domNodes": -3348,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 245.722,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.635034013605438,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19311.69399999999,
"styleRecalcs": 154,
"styleRecalcDurationMs": 15.988000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18873.305,
"heapDeltaBytes": -31351280,
"heapUsedBytes": 280114644,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 853.327,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 35.6731977818854,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19419.535999999993,
"styleRecalcs": 151,
"styleRecalcDurationMs": 14.705999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19039.927,
"heapDeltaBytes": -18453332,
"heapUsedBytes": 310830932,
"domNodes": -2766,
"jsHeapTotalBytes": 18006016,
"scriptDurationMs": 859.801,
"eventListeners": -533,
"totalBlockingTimeMs": 39,
"frameDurationMs": 35.56025641025641,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8614.278000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.15800000000002,
"layouts": 20,
"layoutDurationMs": 25.033,
"taskDurationMs": 8521.679,
"heapDeltaBytes": 141253072,
"heapUsedBytes": 500030512,
"domNodes": -3344,
"jsHeapTotalBytes": 148099072,
"scriptDurationMs": 132.44299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.236571428571416,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8146.478000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.09000000000002,
"layouts": 20,
"layoutDurationMs": 28.46900000000001,
"taskDurationMs": 8045.429,
"heapDeltaBytes": -31169956,
"heapUsedBytes": 274703096,
"domNodes": -3119,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 125.808,
"eventListeners": -608,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.30511363636364,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11358.013000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11041.819999999998,
"heapDeltaBytes": -20262816,
"heapUsedBytes": 278577800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.20399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.73549488054608,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11317.934000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10902.300000000001,
"heapDeltaBytes": -23403728,
"heapUsedBytes": 277139348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.93699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.02137931034483,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 489.49699999997165,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.283,
"layouts": 10,
"layoutDurationMs": 5.851999999999999,
"taskDurationMs": 147.30499999999998,
"heapDeltaBytes": 7064156,
"heapUsedBytes": 97956052,
"domNodes": 100,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.757,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 123.26200000006793,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.364,
"layouts": 8,
"layoutDurationMs": 4.4,
"taskDurationMs": 94.664,
"heapDeltaBytes": 4659524,
"heapUsedBytes": 95868328,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.316000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 474.47999999997137,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.666,
"layouts": 76,
"layoutDurationMs": 15.25,
"taskDurationMs": 436.017,
"heapDeltaBytes": -14165084,
"heapUsedBytes": 82233012,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 206.77,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 452.62800000000425,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6859999999999999,
"layouts": 76,
"layoutDurationMs": 14.59,
"taskDurationMs": 405.02299999999997,
"heapDeltaBytes": -14683556,
"heapUsedBytes": 81195652,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 195.06900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 558.6570000000393,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.072,
"layouts": 76,
"layoutDurationMs": 14.022,
"taskDurationMs": 517.417,
"heapDeltaBytes": 1016636,
"heapUsedBytes": 117016516,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 211.73600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.172727272727293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 625.4280000000563,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.655,
"layouts": 76,
"layoutDurationMs": 13.931000000000001,
"taskDurationMs": 587.104,
"heapDeltaBytes": 1359172,
"heapUsedBytes": 119041440,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 247.969,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 63.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2993 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 625ed96d8318431b0d19ed794592d395f6d3dfbc
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (142)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22529 +/- ##
=============================================
Coverage ? 84.25%
=============================================
Files ? 3172
Lines ? 165495
Branches ? 39083
=============================================
Hits ? 139433
Misses ? 25670
Partials ? 392
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21527 to
cloud/1.58.An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset and keeps its internal layout. Catch-up, tab-return and human frames are unchanged.
The fix is on the 1.57 and 1.59 lines but skipped 1.58: the 1.58 branch was cut before it merged and no backport was opened.
cloud/1.58is the line Comfy Cloud production serves, so the bug is still live there. Tracked in https://linear.app/comfyorg/issue/PM-2232.The cherry-pick is clean, no conflicts and no changes from the source. Companion
core/1.58carrier opened alongside this one.