Repository navigation
[backport core/1.58] fix(agent): move an agent-inserted workflow clear of the nodes it lands on (#21527) - #22528
Conversation
…ds on (#21527) ## Summary When the agent inserts a workflow into a tab that already has nodes, the inserted nodes can land on top of the existing graph ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). `get_template` commits as one `insert_workflow` op that carries the template's baked-in coordinates, and neither cloud nor comfy-multi-player translates them. The follower's placement (ADR-CRDT-PLACEMENT-0035, from [PM-1142](https://linear.app/comfyorg/issue/PM-1142)) only moved a batch that landed far away and offscreen, so a batch landing on the user's nodes kept its overlapping position. The Z-Image template spans x −420 to 1350, the same region as the default workflow. Now, in a live frame written by an agent turn, a created batch with any node that intersects an existing node moves beside the existing content by the same single offset. The batch's internal layout is unchanged. Catch-up frames, tab-return applies and human writes are excluded, so a node a human pasted over another is not moved when the follower resubscribes (`agentPastedNodeOrphanedOnRetarget.spec.ts` catches that if the scope is dropped). Behavior change to an existing pin: `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` asserted that two inserts of the same template render pixel-identically on top of each other. The second copy now lands beside the first. Its op fixture also used `agent:e2e`, which fails the actor grammar and is dropped by the follower; it now uses `agent:<thread>:<turn>` as cloud stamps it. Known limitation, recorded in the ADR: an agent insert that lands while its tab is inactive is applied on tab return without collision placement, because the collected changes do not record their writer. ## Verification - New black-box case `browser_tests/tests/agent/agentInsertWorkflowOverlap.spec.ts`: a canvas with three nodes, then one `insert_workflow` carrying the Z-Image template's node rects. Fails on `main` (`inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)`), passes here; also asserts the template's relative layout is preserved. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` side-by-side assertion fails on `main`, passes here. - Unit: `batchPlacement.test.ts` (collision cases, hull-interior non-collision stays put) and `liveGraphApplier.test.ts` (a live agent batch moves, a replayed one does not). Both fail on `main`. - `pnpm exec vitest run src/workbench/extensions/agent`: 177 files, 4027 passed. - Full `browser_tests/tests/agent` on the `cloud` project locally: 352 of 355 passed. The three failures (two `agentConversationReplay` screenshot comparisons and `agentReplyDrafts` "keeps its run approval action live", which already passes under `test.fail`) fail identically on `main` in the same environment. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt clean. (cherry picked from commit bc0250c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T20:45:01.020Z",
"gitSha": "377ee8149569ee42f4fd1f9668ea2551c6193951",
"branch": "backport-21527-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.7219999999597,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.409,
"layouts": 10,
"layoutDurationMs": 2.915,
"taskDurationMs": 573.3050000000001,
"heapDeltaBytes": -12243232,
"heapUsedBytes": 87963988,
"domNodes": -200,
"jsHeapTotalBytes": 5910528,
"scriptDurationMs": 8.491999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.7809999999618,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3819999999999997,
"layouts": 9,
"layoutDurationMs": 2.5129999999999995,
"taskDurationMs": 573.905,
"heapDeltaBytes": -1943712,
"heapUsedBytes": 88473364,
"domNodes": -200,
"jsHeapTotalBytes": 1114112,
"scriptDurationMs": 8.669,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.2739999999576,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.432999999999998,
"layouts": 9,
"layoutDurationMs": 2.3569999999999998,
"taskDurationMs": 768.9090000000001,
"heapDeltaBytes": 7319064,
"heapUsedBytes": 97631540,
"domNodes": -180,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 159.62199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.8239999999569,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.056999999999999,
"layouts": 9,
"layoutDurationMs": 2.4280000000000004,
"taskDurationMs": 784.959,
"heapDeltaBytes": 1893636,
"heapUsedBytes": 92711004,
"domNodes": -200,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 163.05999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5790000000056,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.771999999999999,
"layouts": 11,
"layoutDurationMs": 2.6790000000000003,
"taskDurationMs": 391.613,
"heapDeltaBytes": 24043216,
"heapUsedBytes": 114355840,
"domNodes": 47,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.568999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.6110000000235,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.777000000000001,
"layouts": 11,
"layoutDurationMs": 3.2929999999999997,
"taskDurationMs": 438.789,
"heapDeltaBytes": 25487828,
"heapUsedBytes": 115410860,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.687999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 620.4529999999977,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7159999999999997,
"layouts": 9,
"layoutDurationMs": 2.541,
"taskDurationMs": 439.90700000000004,
"heapDeltaBytes": 3286612,
"heapUsedBytes": 94026932,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 167.19699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 601.8950000000132,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.677,
"layouts": 9,
"layoutDurationMs": 2.7019999999999995,
"taskDurationMs": 427.71299999999997,
"heapDeltaBytes": 3736548,
"heapUsedBytes": 94194596,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 168.61599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1199.2380000000367,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.006,
"heapDeltaBytes": -15353420,
"heapUsedBytes": 102454272,
"domNodes": -240,
"jsHeapTotalBytes": 15015936,
"scriptDurationMs": 72.52600000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 512,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.9100000000508,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.602,
"heapDeltaBytes": 11180868,
"heapUsedBytes": 129768680,
"domNodes": -210,
"jsHeapTotalBytes": 14123008,
"scriptDurationMs": 68.19699999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 578,
"frameDurationMs": 35.785294117647055,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4379999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.2900000000001,
"heapDeltaBytes": -3557864,
"heapUsedBytes": 97921576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.41499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.377000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.10900000000015,
"heapDeltaBytes": -2844296,
"heapUsedBytes": 97723832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.48200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9381.119000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8569.106,
"heapDeltaBytes": 21587756,
"heapUsedBytes": 125632900,
"domNodes": -276,
"jsHeapTotalBytes": 20250624,
"scriptDurationMs": 7018.107,
"eventListeners": -130,
"totalBlockingTimeMs": 760,
"frameDurationMs": 32.0763698630137,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10741.280000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9897.436,
"heapDeltaBytes": 40632476,
"heapUsedBytes": 155768260,
"domNodes": -276,
"jsHeapTotalBytes": 37629952,
"scriptDurationMs": 8385.443000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1513,
"frameDurationMs": 32.72256097560975,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10169.264999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9393.359,
"heapDeltaBytes": 29237648,
"heapUsedBytes": 143408508,
"domNodes": -276,
"jsHeapTotalBytes": 30552064,
"scriptDurationMs": 7511.1179999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 633,
"frameDurationMs": 31.670716510903425,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9900.121999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9127.988,
"heapDeltaBytes": 25938800,
"heapUsedBytes": 139736416,
"domNodes": -276,
"jsHeapTotalBytes": 26648576,
"scriptDurationMs": 7247.3189999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 712,
"frameDurationMs": 31.42730158730159,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 220.35199999999122,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.838,
"layouts": 11,
"layoutDurationMs": 3.3669999999999995,
"taskDurationMs": 162.54500000000002,
"heapDeltaBytes": 13240116,
"heapUsedBytes": 120781832,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.059000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.659999999999947,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 218.21299999999155,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.690000000000001,
"layouts": 10,
"layoutDurationMs": 3.1809999999999996,
"taskDurationMs": 164.06999999999996,
"heapDeltaBytes": 13197196,
"heapUsedBytes": 120298632,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.226999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 4,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2041.5009999999825,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.457,
"layouts": 9,
"layoutDurationMs": 2.497,
"taskDurationMs": 657.1949999999998,
"heapDeltaBytes": -28492644,
"heapUsedBytes": 93898456,
"domNodes": -297,
"jsHeapTotalBytes": -1748992,
"scriptDurationMs": 29.758,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2006.9500000000744,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.665000000000001,
"layouts": 8,
"layoutDurationMs": 2.5669999999999997,
"taskDurationMs": 482.12999999999994,
"heapDeltaBytes": -27235712,
"heapUsedBytes": 94341052,
"domNodes": -296,
"jsHeapTotalBytes": -2441216,
"scriptDurationMs": 30.31199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2229.3019999999615,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.671999999999999,
"layouts": 7,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 1503.678,
"heapDeltaBytes": -2682364,
"heapUsedBytes": 108352412,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 809.5519999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2533.97300000006,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.166,
"layouts": 8,
"layoutDurationMs": 2.2680000000000002,
"taskDurationMs": 1740.259,
"heapDeltaBytes": -9376180,
"heapUsedBytes": 103858724,
"domNodes": -296,
"jsHeapTotalBytes": -417792,
"scriptDurationMs": 842.5120000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776158940397348,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3524.5310000000245,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.906,
"layouts": 64,
"layoutDurationMs": 10.224,
"taskDurationMs": 1582.128,
"heapDeltaBytes": -24587764,
"heapUsedBytes": 88099828,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 787.377,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3847.4499999999807,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.840000000000002,
"layouts": 65,
"layoutDurationMs": 10.51,
"taskDurationMs": 1820.871,
"heapDeltaBytes": -7176428,
"heapUsedBytes": 105480300,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 807.6139999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738864628820963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2808.339999999987,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.065,
"layouts": 5,
"layoutDurationMs": 1.1940000000000002,
"taskDurationMs": 1751.6349999999998,
"heapDeltaBytes": -12051820,
"heapUsedBytes": 102986196,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 959.689,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.969090909090905,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2956.286999999975,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.188000000000001,
"layouts": 5,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 1942.699,
"heapDeltaBytes": 21989792,
"heapUsedBytes": 126051204,
"domNodes": 0,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 957.663,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76079545454546,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2057.1030000000405,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.66,
"layouts": 6,
"layoutDurationMs": 1.5430000000000001,
"taskDurationMs": 663.057,
"heapDeltaBytes": 733972,
"heapUsedBytes": 113675596,
"domNodes": -296,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 35.226,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2050.5379999999604,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1670000000000007,
"layouts": 8,
"layoutDurationMs": 2.363,
"taskDurationMs": 528.174,
"heapDeltaBytes": 796800,
"heapUsedBytes": 113511176,
"domNodes": -296,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 37.923,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.099999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.130000000000001,
"layouts": 10,
"layoutDurationMs": 2.392,
"taskDurationMs": 427.29499999999996,
"heapDeltaBytes": -193024,
"heapUsedBytes": 90713452,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.94299999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.8989999999703,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.4030000000000005,
"layouts": 10,
"layoutDurationMs": 3.036,
"taskDurationMs": 395.447,
"heapDeltaBytes": 705912,
"heapUsedBytes": 102809216,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.04799999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2056.564000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4939999999999998,
"layouts": 10,
"layoutDurationMs": 2.736,
"taskDurationMs": 569.4390000000001,
"heapDeltaBytes": 3650620,
"heapUsedBytes": 94608324,
"domNodes": -218,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 7.9799999999999995,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.891999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 9,
"layoutDurationMs": 2.393,
"taskDurationMs": 418.752,
"heapDeltaBytes": 6040820,
"heapUsedBytes": 97055596,
"domNodes": -218,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 8.282,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.6350000000207,
"styleRecalcs": 78,
"styleRecalcDurationMs": 12.768,
"layouts": 9,
"layoutDurationMs": 2.4610000000000003,
"taskDurationMs": 718.456,
"heapDeltaBytes": 4000680,
"heapUsedBytes": 95262620,
"domNodes": -190,
"jsHeapTotalBytes": 3735552,
"scriptDurationMs": 110.586,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.013000000019,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.341,
"layouts": 9,
"layoutDurationMs": 2.5740000000000003,
"taskDurationMs": 878.191,
"heapDeltaBytes": -2239768,
"heapUsedBytes": 88738428,
"domNodes": -210,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 112.82400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 950.0370000000089,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.86,
"layouts": 5,
"layoutDurationMs": 16.981999999999996,
"taskDurationMs": 780.71,
"heapDeltaBytes": 35350588,
"heapUsedBytes": 137930312,
"domNodes": 16030,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 24.967999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 174,
"frameDurationMs": 21.588636363636354,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9372.023000000012,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.770999999999997,
"layouts": 9,
"layoutDurationMs": 2.148,
"taskDurationMs": 5913.014,
"heapDeltaBytes": -14140040,
"heapUsedBytes": 107846532,
"domNodes": -297,
"jsHeapTotalBytes": 372736,
"scriptDurationMs": 2683.2659999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666192170818505,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8306.87499999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.590999999999998,
"layouts": 7,
"layoutDurationMs": 1.9239999999999997,
"taskDurationMs": 5177.593,
"heapDeltaBytes": 2853896,
"heapUsedBytes": 113325104,
"domNodes": -296,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 2694.886,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73319919517103,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22584.81900000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21607.074999999997,
"heapDeltaBytes": -43117200,
"heapUsedBytes": 282227140,
"domNodes": -3344,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 289.40200000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.67770154373928,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22720.421999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21825.308,
"heapDeltaBytes": -33818696,
"heapUsedBytes": 300184148,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 309.03499999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.50573913043479,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 18805.759000000024,
"styleRecalcs": 162,
"styleRecalcDurationMs": 14.355000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18427.413,
"heapDeltaBytes": -28047104,
"heapUsedBytes": 291507596,
"domNodes": -3344,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 804.838,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 34.27304189435337,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27773.337999999967,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.41799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27321.568,
"heapDeltaBytes": -2372060,
"heapUsedBytes": 303014916,
"domNodes": -3344,
"jsHeapTotalBytes": 6995968,
"scriptDurationMs": 896.669,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 50.605100182149364,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8105.48,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.01599999999999,
"layouts": 20,
"layoutDurationMs": 21.638999999999992,
"taskDurationMs": 7961.234000000001,
"heapDeltaBytes": -47224528,
"heapUsedBytes": 272725348,
"domNodes": -3344,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 118.49699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.72312138728323,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8107.413000000065,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.78700000000001,
"layouts": 20,
"layoutDurationMs": 22.464000000000013,
"taskDurationMs": 7986.012000000001,
"heapDeltaBytes": -15251484,
"heapUsedBytes": 285311912,
"domNodes": -3344,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 123.257,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.9156069364162,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7251.614000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7045.424000000001,
"heapDeltaBytes": 10245628,
"heapUsedBytes": 285437144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.85299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.715986394557824,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7574.342999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7235.710000000001,
"heapDeltaBytes": 31881592,
"heapUsedBytes": 308984440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.88799999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.39060402684563,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 476.1169999999879,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.339,
"layouts": 12,
"layoutDurationMs": 4.7620000000000005,
"taskDurationMs": 127.927,
"heapDeltaBytes": 7326768,
"heapUsedBytes": 97027200,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.454,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.80599999990045,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.163,
"layouts": 11,
"layoutDurationMs": 3.009,
"taskDurationMs": 92.17,
"heapDeltaBytes": 6758896,
"heapUsedBytes": 97109164,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.678,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 512.2350000000324,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.644,
"layouts": 76,
"layoutDurationMs": 15.382,
"taskDurationMs": 468.688,
"heapDeltaBytes": -13842972,
"heapUsedBytes": 80841628,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 231.56099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 569.0479999999525,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.67,
"layouts": 76,
"layoutDurationMs": 15.272,
"taskDurationMs": 515.755,
"heapDeltaBytes": -12201716,
"heapUsedBytes": 82261568,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 260.501,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 507.47999999998683,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.469,
"layouts": 76,
"layoutDurationMs": 13.85,
"taskDurationMs": 465.75699999999995,
"heapDeltaBytes": 104240,
"heapUsedBytes": 117692672,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.52899999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 545.1659999999947,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.488,
"layouts": 76,
"layoutDurationMs": 13.832,
"taskDurationMs": 515.823,
"heapDeltaBytes": 905980,
"heapUsedBytes": 117973540,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 213.924,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696954,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2984 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d68fef80d9f41956c50438dad045b59ca1db24fd
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (138)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22528 +/- ##
=============================================
- Coverage 84.05% 84.05% -0.01%
=============================================
Files 3175 3175
Lines 166152 166164 +12
Branches 39645 39646 +1
=============================================
+ Hits 139653 139663 +10
- Misses 26106 26108 +2
Partials 393 393
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
dante01yoon
left a comment
There was a problem hiding this comment.
Approving the backport to core/1.58. Checks are green.
Backport of #21527 to
core/1.58.An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset and keeps its internal layout. Catch-up, tab-return and human frames are unchanged.
The fix is on the 1.57 and 1.59 lines but skipped 1.58: the 1.58 branch was cut before it merged and no backport was opened.
cloud/1.58is the line Comfy Cloud production serves, so the bug is still live there. Tracked in https://linear.app/comfyorg/issue/PM-2232.The cherry-pick is clean, no conflicts and no changes from the source. Companion
cloud/1.58carrier opened alongside this one.