Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/workbench/extensions/agent/AgentPanelRoot.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9033,6 +9033,45 @@ describe('AgentPanelRoot workflow binding', () => {
}
)

it('puts the draft back when App Mode releases the hold in the update that closes the panel', async () => {
Object.assign(useAgentPanelStore(), { enabled: true, isOpen: true })
makeTab('wf-42')
const bodies = mockMessagesEndpoint('wf-42')
const settleSubmission = vi.spyOn(
useAgentComposerStore(),
'settleSubmission'
)
const { unmount } = renderWithSelectedTarget()
await sendHeldByCoach('build me a workflow')
const stopCloseOnAppMode = watch(
() => canvasStore.linearMode,
() => {
useAgentPanelStore().close('close_button')
unmount()
},
{ flush: 'post' }
)

try {
canvasStore.linearMode = true

await waitFor(() =>
expect(settleSubmission).toHaveBeenCalledWith(
expect.any(Number),
false
)
)
} finally {
stopCloseOnAppMode()
}
expect(bodies).toHaveLength(0)
renderWithSelectedTarget()
expect(await screen.findByRole('textbox')).toHaveTextContent(
'build me a workflow'
)
expect(bodies).toHaveLength(0)
})

it('puts the draft back when consent is cleared before App Mode releases the hold', async () => {
makeTab('wf-42')
const bodies = mockMessagesEndpoint('wf-42')
Expand Down
9 changes: 6 additions & 3 deletions src/workbench/extensions/agent/AgentPanelRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ const coachDeferredBy = computed(() =>
: null
)
const coachCompletionWaiters = new Set<(proceed: boolean) => void>()
let coachReleaseRevoked = false
function releaseCoachCompletionWaiters(proceed = true): void {
for (const resolve of coachCompletionWaiters) resolve(proceed)
coachCompletionWaiters.clear()
Expand Down Expand Up @@ -694,9 +695,10 @@ async function waitForCoachCompletion(): Promise<boolean> {
return true
sendHeldByCoach.value = true
try {
return await new Promise<boolean>((resolve) =>
const proceed = await new Promise<boolean>((resolve) =>
coachCompletionWaiters.add(resolve)
)
return proceed && !coachReleaseRevoked
} finally {
sendHeldByCoach.value = false
}
Expand Down Expand Up @@ -1589,9 +1591,10 @@ void refreshCloudWorkflowIds()
onBeforeUnmount(() => {
runPanelTeardown({
releaseCoachCompletionWaiters: () => {
releaseCoachCompletionWaiters(
const proceed =
coachDeferredBy.value !== null && agentPanelStore.isVisible
)
if (!proceed) coachReleaseRevoked = true
releaseCoachCompletionWaiters(proceed)
},
invalidateConsentHeldSubmission: () => {
if (
Expand Down
Loading