Repository navigation
[backport core/1.59] fix(agent): force a fresh billing read after Agent consent (#22425) - #22510
Conversation
## Summary After Agree, the free-use notice could still miss a just-created grant if the startup billing read had not finished. This makes the post-consent refresh start its own read. Linear: https://linear.app/comfyorg/issue/PM-2399/force-a-fresh-legacy-billing-read-after-agent-consent ## What changed - `fetchSubscriptionStatus` takes `{ fresh: true }`. If a read is in flight, it waits for that read to land and then reads again. Ordinary reads stay shared. - `fetchStatus` on the billing context and the legacy adapter pass the option through. Workspace billing already reads fresh on every call. A fresh request made while routing is unknown runs once routing is known. - `useAgentDockMount` asks for a fresh read after a confirmed acceptance. The fresh read runs after the shared one instead of replacing it. An independent review showed that replacing it dropped the startup answer, which could briefly show a subscribe prompt to a paying user, and keep it there if the new read failed. Status `error` and `isLoading` now follow only the latest read. **Scope:** this is the legacy path, which reads status on Cloud only (`performFetchSubscriptionStatus` returns early off Cloud). The Local notice is served through the workspace path, which has no shared read, so this mainly protects Cloud personal workspaces. ## Tests Red before, green after: - `useSubscription.test.ts`: a fresh caller reads again after the shared read and its answer wins; if that read fails, the shared answer stays. - `useAgentDockMount.test.ts`: the post-consent refresh asks for a fresh read. `useLegacyBilling.test.ts` covers the pass-through. Billing and dock-mount suites pass, plus app typecheck. (cherry picked from commit 9d92f8d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T16:36:44.651Z",
"gitSha": "1fe5a39a9657571d6fcbf5f20daddffaf0227103",
"branch": "backport-22425-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.06999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6069999999999998,
"layouts": 9,
"layoutDurationMs": 2.661,
"taskDurationMs": 523.975,
"heapDeltaBytes": 1770664,
"heapUsedBytes": 63205916,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.196999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.5950000000375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.988,
"layouts": 10,
"layoutDurationMs": 2.988,
"taskDurationMs": 544.8040000000001,
"heapDeltaBytes": 5061080,
"heapUsedBytes": 75126060,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.709999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.5310000000104,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.04,
"layouts": 9,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 875.494,
"heapDeltaBytes": -1387888,
"heapUsedBytes": 68278928,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 161.41499999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.2500000000282,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.822,
"layouts": 9,
"layoutDurationMs": 2.412,
"taskDurationMs": 891.3069999999999,
"heapDeltaBytes": -1885380,
"heapUsedBytes": 68856208,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 164.67600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.630999999988,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.762,
"layouts": 10,
"layoutDurationMs": 3.2079999999999997,
"taskDurationMs": 454.06399999999996,
"heapDeltaBytes": 24236216,
"heapUsedBytes": 85490212,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.147000000000004,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.8329999999842,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.314,
"layouts": 10,
"layoutDurationMs": 3.0789999999999997,
"taskDurationMs": 407.029,
"heapDeltaBytes": -68536,
"heapUsedBytes": 60859768,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 11.130999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 700.0840000000039,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.3990000000000005,
"layouts": 11,
"layoutDurationMs": 3.6009999999999995,
"taskDurationMs": 494.5040000000001,
"heapDeltaBytes": 7405648,
"heapUsedBytes": 77862568,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 165.501,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 694.1819999999552,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.843,
"layouts": 10,
"layoutDurationMs": 3.0219999999999994,
"taskDurationMs": 495.34299999999996,
"heapDeltaBytes": 3760612,
"heapUsedBytes": 65412652,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 170.315,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.167000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.8629999999999,
"heapDeltaBytes": -12659904,
"heapUsedBytes": 74952244,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 66.294,
"eventListeners": -106,
"totalBlockingTimeMs": 494,
"frameDurationMs": 31.981081081081072,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1245.603000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 948.917,
"heapDeltaBytes": -11897284,
"heapUsedBytes": 75439360,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 80.737,
"eventListeners": -106,
"totalBlockingTimeMs": 562,
"frameDurationMs": 33.78378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.6040000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.211,
"heapDeltaBytes": -27583848,
"heapUsedBytes": 66395560,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 172.96200000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 892.8079999999454,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.4220000000004,
"heapDeltaBytes": -27363396,
"heapUsedBytes": 66536588,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 169.809,
"eventListeners": -106,
"totalBlockingTimeMs": 227,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10976.168000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.23999999999999977,
"layouts": 1,
"layoutDurationMs": 0.21199999999999994,
"taskDurationMs": 10045.079000000002,
"heapDeltaBytes": 64830760,
"heapUsedBytes": 147324136,
"domNodes": -257,
"jsHeapTotalBytes": 70643712,
"scriptDurationMs": 8079.174,
"eventListeners": -68,
"totalBlockingTimeMs": 1103,
"frameDurationMs": 31.694219653179193,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11833.613999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11036.197,
"heapDeltaBytes": 15829408,
"heapUsedBytes": 90864156,
"domNodes": -257,
"jsHeapTotalBytes": 16379904,
"scriptDurationMs": 8904.330999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1489,
"frameDurationMs": 32.50769230769231,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10643.986999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9812.744999999999,
"heapDeltaBytes": 71136604,
"heapUsedBytes": 143512468,
"domNodes": -257,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 7910.860999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1091,
"frameDurationMs": 30.820289855072463,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10328.546999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9548.946,
"heapDeltaBytes": 84498768,
"heapUsedBytes": 158331232,
"domNodes": -257,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 7690.923,
"eventListeners": -68,
"totalBlockingTimeMs": 808,
"frameDurationMs": 31.40699088145897,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 291.23200000000793,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.583,
"layouts": 10,
"layoutDurationMs": 3.3009999999999997,
"taskDurationMs": 246.85000000000002,
"heapDeltaBytes": -16953224,
"heapUsedBytes": 58403680,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 10.901000000000002,
"eventListeners": -640,
"totalBlockingTimeMs": 3,
"frameDurationMs": 23.076923076923077,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 321.9960000000128,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.684,
"layouts": 11,
"layoutDurationMs": 4.097999999999999,
"taskDurationMs": 268.883,
"heapDeltaBytes": -22647052,
"heapUsedBytes": 59713732,
"domNodes": -2485,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.658000000000001,
"eventListeners": -640,
"totalBlockingTimeMs": 5,
"frameDurationMs": 28.781818181818213,
"p95FrameDurationMs": 116.5
},
{
"name": "large-graph-idle",
"durationMs": 2039.9999999999636,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0349999999999997,
"layouts": 9,
"layoutDurationMs": 2.793,
"taskDurationMs": 647.066,
"heapDeltaBytes": -29111408,
"heapUsedBytes": 61887992,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 34.765,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.724000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5629999999999993,
"layouts": 8,
"layoutDurationMs": 2.3980000000000006,
"taskDurationMs": 672.957,
"heapDeltaBytes": -10196996,
"heapUsedBytes": 65321392,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.747,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2410.6370000000084,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.427,
"layouts": 7,
"layoutDurationMs": 2.02,
"taskDurationMs": 1713.7730000000001,
"heapDeltaBytes": -19085644,
"heapUsedBytes": 72608796,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 818.7880000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666206896551728,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2525.9170000000495,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.607999999999999,
"layouts": 7,
"layoutDurationMs": 1.8059999999999998,
"taskDurationMs": 1719.1199999999997,
"heapDeltaBytes": -2616616,
"heapUsedBytes": 76644804,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 829.558,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3736.376000000007,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.636000000000001,
"layouts": 64,
"layoutDurationMs": 10.719,
"taskDurationMs": 1746.05,
"heapDeltaBytes": 5715352,
"heapUsedBytes": 82635296,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 768.7479999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3791.1289999999553,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.887,
"layouts": 64,
"layoutDurationMs": 11.071000000000002,
"taskDurationMs": 1859.679,
"heapDeltaBytes": 6886092,
"heapUsedBytes": 78399848,
"domNodes": -233,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 799.892,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3077.2420000000125,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.967999999999999,
"layouts": 5,
"layoutDurationMs": 1.353,
"taskDurationMs": 1944.543,
"heapDeltaBytes": 22791648,
"heapUsedBytes": 106313564,
"domNodes": 0,
"jsHeapTotalBytes": 7757824,
"scriptDurationMs": 956.8249999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.027717391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.589000000042,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.141000000000001,
"layouts": 5,
"layoutDurationMs": 1.3789999999999996,
"taskDurationMs": 2013.283,
"heapDeltaBytes": 18643548,
"heapUsedBytes": 102099668,
"domNodes": 0,
"jsHeapTotalBytes": 7233536,
"scriptDurationMs": 989.427,
"eventListeners": 182,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.026486486486483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3088.1500000000133,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9180000000000004,
"layouts": 7,
"layoutDurationMs": 1.8539999999999996,
"taskDurationMs": 795.6669999999999,
"heapDeltaBytes": -27309652,
"heapUsedBytes": 65585648,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 361.852,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3033.966000000021,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.202,
"layouts": 5,
"layoutDurationMs": 1.091,
"taskDurationMs": 791.0679999999999,
"heapDeltaBytes": 8426332,
"heapUsedBytes": 85656272,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 357.837,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666483516483513,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.0649999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.217,
"layouts": 7,
"layoutDurationMs": 1.8920000000000003,
"taskDurationMs": 650.817,
"heapDeltaBytes": -9050440,
"heapUsedBytes": 68658220,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 34.79600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.5649999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3280000000000003,
"layouts": 7,
"layoutDurationMs": 2.3379999999999996,
"taskDurationMs": 651.7099999999999,
"heapDeltaBytes": -19884292,
"heapUsedBytes": 72959348,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 37.282999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2785.1060000000134,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.155000000000001,
"layouts": 6,
"layoutDurationMs": 1.9729999999999994,
"taskDurationMs": 610.2239999999999,
"heapDeltaBytes": -1491548,
"heapUsedBytes": 77173952,
"domNodes": -252,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 191.026,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2766.8780000000197,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.277,
"layouts": 6,
"layoutDurationMs": 1.382,
"taskDurationMs": 612.6949999999999,
"heapDeltaBytes": -905952,
"heapUsedBytes": 75472020,
"domNodes": -253,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 187.082,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3278.644000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0159999999999996,
"layouts": 7,
"layoutDurationMs": 1.8809999999999998,
"taskDurationMs": 935.956,
"heapDeltaBytes": -8139708,
"heapUsedBytes": 71353972,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 380.844,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751282051282054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3352.5109999999927,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5209999999999997,
"layouts": 5,
"layoutDurationMs": 1.6999999999999997,
"taskDurationMs": 1032.538,
"heapDeltaBytes": -899032,
"heapUsedBytes": 75986388,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 410.682,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749000000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.2829999999808,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.602,
"layouts": 8,
"layoutDurationMs": 2.3830000000000005,
"taskDurationMs": 439.58700000000005,
"heapDeltaBytes": 623764,
"heapUsedBytes": 63211924,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 144.471,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.4799999999286,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.6979999999999995,
"layouts": 10,
"layoutDurationMs": 2.479,
"taskDurationMs": 434.86099999999993,
"heapDeltaBytes": 2204992,
"heapUsedBytes": 74098848,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 141.49399999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.9470000000063,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7340000000000004,
"layouts": 9,
"layoutDurationMs": 2.7340000000000004,
"taskDurationMs": 537.889,
"heapDeltaBytes": 5465692,
"heapUsedBytes": 77231440,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.665,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.4989999999916,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.015,
"layouts": 9,
"layoutDurationMs": 2.7230000000000003,
"taskDurationMs": 542.13,
"heapDeltaBytes": 5501384,
"heapUsedBytes": 77433496,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 9.566,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5429999999965,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.238,
"layouts": 9,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 851.129,
"heapDeltaBytes": 17548476,
"heapUsedBytes": 79975952,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 112.18799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1610000000182,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.622000000000002,
"layouts": 8,
"layoutDurationMs": 2.5140000000000002,
"taskDurationMs": 836.994,
"heapDeltaBytes": 17177116,
"heapUsedBytes": 79520004,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 109.748,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1502.490000000023,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.566000000000006,
"layouts": 5,
"layoutDurationMs": 16.968000000000004,
"taskDurationMs": 1223.345,
"heapDeltaBytes": 11594136,
"heapUsedBytes": 113305916,
"domNodes": 16030,
"jsHeapTotalBytes": 16388096,
"scriptDurationMs": 35.666000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 178,
"frameDurationMs": 20.222666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9689.192999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.269000000000002,
"layouts": 8,
"layoutDurationMs": 2.141,
"taskDurationMs": 6056.0419999999995,
"heapDeltaBytes": 7989204,
"heapUsedBytes": 87157484,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2775.3889999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666092943201377,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9716.548999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.157,
"layouts": 8,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 6115.2519999999995,
"heapDeltaBytes": -19798140,
"heapUsedBytes": 71841036,
"domNodes": -257,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2737.254,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23253.275999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22674.386,
"heapDeltaBytes": -26579464,
"heapUsedBytes": 250568204,
"domNodes": -3343,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 324.316,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.015662650602415,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23154.994999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22592.878,
"heapDeltaBytes": -33200468,
"heapUsedBytes": 267193132,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 315.957,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.18940972222222,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19154.780000000017,
"styleRecalcs": 148,
"styleRecalcDurationMs": 14.317000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18731.368000000002,
"heapDeltaBytes": -15332784,
"heapUsedBytes": 261182544,
"domNodes": -3343,
"jsHeapTotalBytes": 23846912,
"scriptDurationMs": 827.116,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 34.94379562043796,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27901.853000000076,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.64099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27459.348000000005,
"heapDeltaBytes": -24952656,
"heapUsedBytes": 266575676,
"domNodes": -3343,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 876.0880000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 51.66462962962962,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8366.945999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.08400000000002,
"layouts": 20,
"layoutDurationMs": 27.936000000000003,
"taskDurationMs": 8233.688,
"heapDeltaBytes": -12959712,
"heapUsedBytes": 274911712,
"domNodes": -307,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 124.763,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.92631578947368,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8248.728000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.16,
"layouts": 20,
"layoutDurationMs": 22.490999999999996,
"taskDurationMs": 8132.472,
"heapDeltaBytes": -34331728,
"heapUsedBytes": 247908684,
"domNodes": -3343,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 143.307,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.96337209302326,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11364.220999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10971.164,
"heapDeltaBytes": 3210676,
"heapUsedBytes": 261731228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.61800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.792491467576795,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11368.885000000091,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11084.900999999998,
"heapDeltaBytes": -6658900,
"heapUsedBytes": 258901632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.04899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.925342465753424,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 162.8490000000511,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.008,
"layouts": 9,
"layoutDurationMs": 4.675000000000001,
"taskDurationMs": 127.20799999999998,
"heapDeltaBytes": -12664384,
"heapUsedBytes": 63263680,
"domNodes": 105,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 17.055,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 116.21999999999844,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.588999999999999,
"layouts": 8,
"layoutDurationMs": 3.6719999999999997,
"taskDurationMs": 83.57999999999998,
"heapDeltaBytes": 4638220,
"heapUsedBytes": 72160348,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.322000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 513.5309999999436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.79,
"layouts": 76,
"layoutDurationMs": 15.668999999999999,
"taskDurationMs": 469.47299999999996,
"heapDeltaBytes": -1071352,
"heapUsedBytes": 47090340,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 227.333,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 538.2799999999861,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.642,
"layouts": 76,
"layoutDurationMs": 15.368,
"taskDurationMs": 481.388,
"heapDeltaBytes": -3628096,
"heapUsedBytes": 40502096,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 236.073,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 494.17000000005373,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.976,
"layouts": 76,
"layoutDurationMs": 14.562999999999999,
"taskDurationMs": 465.29,
"heapDeltaBytes": 553280,
"heapUsedBytes": 102767916,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 185.01199999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 540.986000000089,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.807,
"layouts": 76,
"layoutDurationMs": 14.642000000000001,
"taskDurationMs": 503.24199999999996,
"heapDeltaBytes": 1112028,
"heapUsedBytes": 94941748,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 207.512,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.172727272727293,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3128 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bfd842d99aa74579f2e969e9708893c68a20603c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (231)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.59 #22510 +/- ##
=============================================
+ Coverage 87.15% 87.16% +0.01%
=============================================
Files 3029 3029
Lines 158937 158963 +26
Branches 42395 40245 -2150
=============================================
+ Hits 138514 138554 +40
+ Misses 19746 19731 -15
- Partials 677 678 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22425 — LGTM.
Summary
1.59 copy of #22425. After Agree, the post-consent billing refresh starts its own read instead of joining a read already in flight, so a just-created grant is not missed. Ordinary reads stay shared.
Linear: https://linear.app/comfyorg/issue/PM-2399/force-a-fresh-legacy-billing-read-after-agent-consent
Conflict
The automatic backport failed in
useBillingContext.tsand its test, on imports only. 1.59 keeps@/platform/telemetry/reportErrorand has noworkspaceBillingStateStore, so the resolution uses the 1.59 path and drops the store import. No behaviour or test logic changed from main.Tests
Billing composables,
useSubscription, anduseAgentDockMountsuites pass on this branch, plustypecheck:app.