Repository navigation
[backport cloud/1.59] fix: handle rejected play() in AudioPreviewPlayer - #22504
Conversation
## Summary Fixes Sentry `NotSupportedError: The operation is not supported.` from the audio widget preview ([FRONT-3745](https://linear.app/comfyorg/issue/FRONT-3745), [FRONT-3747](https://linear.app/comfyorg/issue/FRONT-3747)). Safari rejects `HTMLMediaElement.play()` with that error when it cannot play a source. `AudioPreviewPlayer.togglePlayPause` called `void play()` and set `isPlaying = true` regardless. So the rejection went unhandled, the click did nothing, the button switched to pause, and the next click called `pause()` instead of retrying. Confirmed from the events: [CLOUD-FRONTEND-PROD-363](https://comfy-org.sentry.io/issues/7819622225/) (Safari 26.6.2, release 1.58.0) and [CLOUD-FRONTEND-PROD-2QY](https://comfy-org.sentry.io/issues/7794752354/) (release 1.56.3) both show `togglePlayPause` as the only first-party frame under `[native code] play`. Impact: 4 events, 3 users, 15 days. ## Changes - `play()` is awaited in `try/catch`. On failure the button returns to play, a warning is logged, and a localized error toast is shown. `AbortError` stays silent. - A `playAttempt` counter ignores late results from attempts superseded by pause, a source change, or unmount. - The toast has a stable id per player, so repeat clicks replace it. It clears on a successful retry, a source change, or unmount. - Clearing the source now pauses the element. Removing the `src` attribute alone leaves audio playing. - One `watch(modelValue)` replaces the previous `whenever`. Its `immediate` was a no-op because the template ref is null during setup. - `aria-pressed` on the toggle. - A failed source is reloaded before a retry, since `play()` keeps rejecting until `load()` runs. - The player follows `pause` and `error` events from the element, so media keys and mid-playback failures no longer leave the button stuck. - Clearing the source resets the shown time. - Failures go through `reportError` at warning level (`error_playing_audio`), so they stay measurable. ## Verification - Unit: 19 component tests. - Real WebKit via Playwright, isolated pattern page rather than the full app: old `void play()` logged the unhandled production message; the handled pattern stayed paused (screenshot below). ## Not in this PR - [FRONT-3746](https://linear.app/comfyorg/issue/FRONT-3746), fixed in #22451: the same error from `useWaveAudioPlayer` ([CLOUD-FRONTEND-PROD-31S](https://comfy-org.sentry.io/issues/7811786061/)). - Other alerts in this family come from the `comfyui-videohelpersuite` custom node, outside this repo. ## Screenshots  ## Update: 208fc8d (@dante01yoon, comment 4430258389) Fixed the double `reportError`. `handleError` now claims the pending play attempt (`playAttempt++`), so the `play()` rejection that follows is ignored as stale. One click on a failed source now reports once, whichever arrives first: - error event first: `handleError` reports, and the stale catch exits. - rejection first: the catch reports and sets `isPlaying=false`, and the later error event hits the `!isPlaying` guard. There's a test for each order. The error-first test fails without the fix. Results: 24/24 component tests pass, lint/typecheck are clean, and the deep-reviewer verdict was PASS. ## Update: 577f69f (@dante01yoon, comments 4431351009/11/14/17) - Removed the JSDoc on the non-exported `toPlaybackError` and the three `//` comments in the tests. Behaviour and assertions are unchanged. - Renamed two tests so their titles carry the intent: "resets the shown elapsed time when the source is cleared mid-playback" and "dismisses only its own error toast when %s". - The older section comments (`// Refs`, `// Computed`, …) were already in the file before this PR, so I left them alone. - 24/24 component tests pass and lint is clean. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T13:06:44.735Z",
"gitSha": "380935fe5e4797e2ddc0e3b69fb1709d4d58e320",
"branch": "backport-22390-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.161000000006,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6359999999999992,
"layouts": 11,
"layoutDurationMs": 2.6759999999999997,
"taskDurationMs": 423.89899999999994,
"heapDeltaBytes": 5102112,
"heapUsedBytes": 74910688,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 8.42,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.6040000000157,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6750000000000003,
"layouts": 7,
"layoutDurationMs": 2.498,
"taskDurationMs": 521.64,
"heapDeltaBytes": 5245024,
"heapUsedBytes": 76084364,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 11.853999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.593999999995,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.404000000000002,
"layouts": 10,
"layoutDurationMs": 2.1200000000000006,
"taskDurationMs": 704.607,
"heapDeltaBytes": 23156948,
"heapUsedBytes": 84292528,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 122.517,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.9030000000444,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.594999999999999,
"layouts": 9,
"layoutDurationMs": 2.6229999999999993,
"taskDurationMs": 767.2429999999999,
"heapDeltaBytes": 21422392,
"heapUsedBytes": 82978568,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 131.065,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.707000000018,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.065999999999999,
"layouts": 10,
"layoutDurationMs": 2.5900000000000003,
"taskDurationMs": 385.30600000000004,
"heapDeltaBytes": -1214888,
"heapUsedBytes": 60217944,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 13.343,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.411999999982,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.034999999999999,
"layouts": 11,
"layoutDurationMs": 2.471,
"taskDurationMs": 310.246,
"heapDeltaBytes": 24511908,
"heapUsedBytes": 86205024,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.284999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 567.1879999999874,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.3129999999999997,
"layouts": 10,
"layoutDurationMs": 2.5930000000000004,
"taskDurationMs": 414.127,
"heapDeltaBytes": 3428832,
"heapUsedBytes": 65013084,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 140.071,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 610.984999999971,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9310000000000005,
"layouts": 9,
"layoutDurationMs": 2.505,
"taskDurationMs": 453.63599999999997,
"heapDeltaBytes": 3093192,
"heapUsedBytes": 64371608,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 149.174,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1068.6019999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 725.6819999999999,
"heapDeltaBytes": -13166392,
"heapUsedBytes": 75146148,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 53.066,
"eventListeners": -106,
"totalBlockingTimeMs": 397,
"frameDurationMs": 29.625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1066.2080000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.944,
"heapDeltaBytes": -11962868,
"heapUsedBytes": 75505396,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 53.476000000000006,
"eventListeners": -106,
"totalBlockingTimeMs": 395,
"frameDurationMs": 29.627777777777762,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 817.4720000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.5560000000004,
"heapDeltaBytes": -26451756,
"heapUsedBytes": 66413708,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 131.733,
"eventListeners": -106,
"totalBlockingTimeMs": 162,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.7669999999885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.6810000000001,
"heapDeltaBytes": -4434456,
"heapUsedBytes": 70222088,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.76799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.532352941176455,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8152.389999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.621,
"layouts": 2,
"layoutDurationMs": 0.5479999999999998,
"taskDurationMs": 7124.571,
"heapDeltaBytes": 66464204,
"heapUsedBytes": 140449456,
"domNodes": -257,
"jsHeapTotalBytes": 61206528,
"scriptDurationMs": 5522.174000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 116,
"frameDurationMs": 24.871559633027523,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7851.089999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7000000000000001,
"layouts": 2,
"layoutDurationMs": 0.614,
"taskDurationMs": 6975.025000000001,
"heapDeltaBytes": 69269364,
"heapUsedBytes": 143570868,
"domNodes": -257,
"jsHeapTotalBytes": 52031488,
"scriptDurationMs": 5413.802000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 97,
"frameDurationMs": 23.93170731707317,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7817.960999999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04399999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7046.1359999999995,
"heapDeltaBytes": 80599936,
"heapUsedBytes": 153200980,
"domNodes": -257,
"jsHeapTotalBytes": 59895808,
"scriptDurationMs": 5554.6759999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 160,
"frameDurationMs": 24.73512658227848,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7675.892999999974,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8289999999999998,
"layouts": 3,
"layoutDurationMs": 0.7859999999999998,
"taskDurationMs": 6827.712,
"heapDeltaBytes": 50148300,
"heapUsedBytes": 123359816,
"domNodes": -257,
"jsHeapTotalBytes": 57274368,
"scriptDurationMs": 5321.692000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 69,
"frameDurationMs": 24.084952978056428,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 206.4009999999996,
"styleRecalcs": 24,
"styleRecalcDurationMs": 11.753,
"layouts": 13,
"layoutDurationMs": 3.632,
"taskDurationMs": 184.729,
"heapDeltaBytes": 2410372,
"heapUsedBytes": 71582428,
"domNodes": 721,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.397999999999998,
"eventListeners": 73,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 203.52499999995644,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.333,
"layouts": 11,
"layoutDurationMs": 3.0450000000000004,
"taskDurationMs": 150.52699999999996,
"heapDeltaBytes": 14542412,
"heapUsedBytes": 84388320,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.309999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2023.729000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8539999999999996,
"layouts": 10,
"layoutDurationMs": 2.699,
"taskDurationMs": 627.6980000000001,
"heapDeltaBytes": -13968140,
"heapUsedBytes": 61587764,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.818999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.1549999999784,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8219999999999998,
"layouts": 8,
"layoutDurationMs": 1.837,
"taskDurationMs": 505.317,
"heapDeltaBytes": -10545160,
"heapUsedBytes": 63871836,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.841000000000008,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2399.930000000012,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.286,
"layouts": 7,
"layoutDurationMs": 1.682,
"taskDurationMs": 1415.942,
"heapDeltaBytes": 7889572,
"heapUsedBytes": 84867492,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 663.2399999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597222222222,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2254.2499999999563,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.134,
"layouts": 8,
"layoutDurationMs": 1.8539999999999999,
"taskDurationMs": 1358.118,
"heapDeltaBytes": -4385268,
"heapUsedBytes": 72078616,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 664.203,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665185185185184,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3734.7899999999754,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.431,
"layouts": 64,
"layoutDurationMs": 10.839,
"taskDurationMs": 1595.325,
"heapDeltaBytes": 1491092,
"heapUsedBytes": 77910408,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 676.18,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3270.6420000000094,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.784,
"layouts": 65,
"layoutDurationMs": 10.016,
"taskDurationMs": 1489.1870000000001,
"heapDeltaBytes": -6674480,
"heapUsedBytes": 73513672,
"domNodes": -233,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 657.247,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2735.2070000000026,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.683000000000001,
"layouts": 6,
"layoutDurationMs": 1.5720000000000005,
"taskDurationMs": 1716.0500000000002,
"heapDeltaBytes": 14218852,
"heapUsedBytes": 92853508,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 831.332,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768098159509204,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2379.5330000000376,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.393,
"layouts": 6,
"layoutDurationMs": 1.49,
"taskDurationMs": 1570.8690000000001,
"heapDeltaBytes": 14264776,
"heapUsedBytes": 95674552,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 778.87,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2933.3969999999854,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9420000000000002,
"layouts": 8,
"layoutDurationMs": 1.71,
"taskDurationMs": 620.3029999999999,
"heapDeltaBytes": -7729932,
"heapUsedBytes": 70667872,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 281.94800000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534090909091,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2978.2519999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0140000000000002,
"layouts": 7,
"layoutDurationMs": 1.8190000000000002,
"taskDurationMs": 705.5959999999999,
"heapDeltaBytes": 9088604,
"heapUsedBytes": 85464776,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 326.949,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666480446927377,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.0190000000384,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2450000000000006,
"layouts": 7,
"layoutDurationMs": 1.951,
"taskDurationMs": 633.4000000000001,
"heapDeltaBytes": -14874104,
"heapUsedBytes": 61084112,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.211999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.9370000000372,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0959999999999996,
"layouts": 9,
"layoutDurationMs": 2.032,
"taskDurationMs": 517.873,
"heapDeltaBytes": -10382292,
"heapUsedBytes": 66889124,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.285,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2727.5490000000104,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.64,
"layouts": 8,
"layoutDurationMs": 1.4220000000000002,
"taskDurationMs": 468.695,
"heapDeltaBytes": 706404,
"heapUsedBytes": 81949148,
"domNodes": -244,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 147.63400000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634144,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2762.2709999999984,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.707999999999998,
"layouts": 8,
"layoutDurationMs": 1.5280000000000002,
"taskDurationMs": 499.6670000000001,
"heapDeltaBytes": -7519004,
"heapUsedBytes": 68677992,
"domNodes": -254,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 155.526,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3045.299,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7889999999999997,
"layouts": 8,
"layoutDurationMs": 1.6109999999999998,
"taskDurationMs": 762.3399999999999,
"heapDeltaBytes": -18761088,
"heapUsedBytes": 74467844,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 288.161,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3066.032000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.08,
"layouts": 8,
"layoutDurationMs": 1.7820000000000003,
"taskDurationMs": 782.1149999999999,
"heapDeltaBytes": -1981456,
"heapUsedBytes": 74185544,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 294.653,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.8090000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.128000000000001,
"layouts": 9,
"layoutDurationMs": 2.2019999999999995,
"taskDurationMs": 382.7360000000001,
"heapDeltaBytes": -1420784,
"heapUsedBytes": 61007096,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 123.744,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.9210000000076,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.553,
"layouts": 10,
"layoutDurationMs": 2.416,
"taskDurationMs": 355.252,
"heapDeltaBytes": -817764,
"heapUsedBytes": 61427580,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 121.517,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.1489999999794,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3180000000000005,
"layouts": 9,
"layoutDurationMs": 2.122,
"taskDurationMs": 410.675,
"heapDeltaBytes": 1835840,
"heapUsedBytes": 63963556,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.1620000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2030000000000003,
"layouts": 10,
"layoutDurationMs": 2.3870000000000005,
"taskDurationMs": 410.0659999999999,
"heapDeltaBytes": 1771760,
"heapUsedBytes": 63858260,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.119000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5780000000022,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.974999999999998,
"layouts": 9,
"layoutDurationMs": 2.303,
"taskDurationMs": 730.343,
"heapDeltaBytes": 17573212,
"heapUsedBytes": 79520012,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 96.28500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.854999999956,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.613000000000001,
"layouts": 10,
"layoutDurationMs": 2.2849999999999997,
"taskDurationMs": 664.541,
"heapDeltaBytes": 17820004,
"heapUsedBytes": 80396432,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 85.56800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1354.0949999999725,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.355,
"layouts": 5,
"layoutDurationMs": 10.776000000000002,
"taskDurationMs": 949.7260000000001,
"heapDeltaBytes": 11632524,
"heapUsedBytes": 113307376,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 27.842,
"eventListeners": 3246,
"totalBlockingTimeMs": 106,
"frameDurationMs": 18.720547945205485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11478.588000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.448,
"layouts": 9,
"layoutDurationMs": 2.1850000000000005,
"taskDurationMs": 5374.603999999999,
"heapDeltaBytes": -14544440,
"heapUsedBytes": 61362608,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2383.959,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.018999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.537,
"layouts": 9,
"layoutDurationMs": 1.901,
"taskDurationMs": 4727.35,
"heapDeltaBytes": -7464928,
"heapUsedBytes": 71857032,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2190.966,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666132264529054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20741.29100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20173.435,
"heapDeltaBytes": -30970184,
"heapUsedBytes": 266372612,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 292.93,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.07174311926605,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20164.39500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19589.606,
"heapDeltaBytes": -25126248,
"heapUsedBytes": 252973716,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 279.224,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.46636528028933,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25160.654000000024,
"styleRecalcs": 179,
"styleRecalcDurationMs": 23.09999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24892.057999999997,
"heapDeltaBytes": 8350168,
"heapUsedBytes": 286149088,
"domNodes": -3343,
"jsHeapTotalBytes": 15650816,
"scriptDurationMs": 785.5609999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 47.9942748091603,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24488.605000000007,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.143999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24189.586,
"heapDeltaBytes": -22766008,
"heapUsedBytes": 279833456,
"domNodes": -3343,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 748.0029999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.66342412451361,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7494.01899999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.22900000000002,
"layouts": 20,
"layoutDurationMs": 22.599999999999994,
"taskDurationMs": 7409.669,
"heapDeltaBytes": -35124956,
"heapUsedBytes": 257027556,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 135.431,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.505813953488364,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 5548.745000000054,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.79699999999999,
"layouts": 20,
"layoutDurationMs": 28.180999999999997,
"taskDurationMs": 5451.0070000000005,
"heapDeltaBytes": -12558032,
"heapUsedBytes": 279685440,
"domNodes": -3343,
"jsHeapTotalBytes": 26726400,
"scriptDurationMs": 87.08399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.94601226993865,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10305.995999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10085.806000000002,
"heapDeltaBytes": 23784836,
"heapUsedBytes": 286587980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.72999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.00627306273063,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9970.317000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9556.893,
"heapDeltaBytes": -237948,
"heapUsedBytes": 281578528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.92399999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.66284722222222,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 112.41400000000112,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.934999999999999,
"layouts": 8,
"layoutDurationMs": 3.618,
"taskDurationMs": 92.40600000000002,
"heapDeltaBytes": -12960768,
"heapUsedBytes": 63175996,
"domNodes": 132,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.193,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 103.92000000001644,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.588,
"layouts": 7,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 63.24,
"heapDeltaBytes": 4631628,
"heapUsedBytes": 65033028,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.107000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 289.84700000000885,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.592,
"layouts": 76,
"layoutDurationMs": 11.684999999999999,
"taskDurationMs": 246.213,
"heapDeltaBytes": 10311228,
"heapUsedBytes": 52098208,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 113.89699999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666643,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 273.3220000000074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5910000000000001,
"layouts": 76,
"layoutDurationMs": 11.548,
"taskDurationMs": 236.28400000000002,
"heapDeltaBytes": 10134512,
"heapUsedBytes": 51282724,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 106.149,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 334.165999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.482,
"layouts": 76,
"layoutDurationMs": 11.405999999999999,
"taskDurationMs": 303.532,
"heapDeltaBytes": -1687296,
"heapUsedBytes": 92242940,
"domNodes": 4,
"jsHeapTotalBytes": 1314816,
"scriptDurationMs": 108.99000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 321.35300000004463,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.45,
"layouts": 76,
"layoutDurationMs": 11.142000000000001,
"taskDurationMs": 288.32099999999997,
"heapDeltaBytes": -5459124,
"heapUsedBytes": 77245156,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 104.27499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 3126 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7eb31bbceb40c90a027bc92a083c83caf72e3638
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22504 +/- ##
=============================================
Coverage ? 86.57%
=============================================
Files ? 2669
Lines ? 138699
Branches ? 42511
=============================================
Hits ? 120074
Misses ? 17805
Partials ? 820
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22390 to
cloud/1.59Automatically created by backport workflow.