Repository navigation
[backport cloud/1.58] fix: handle rejected play() in AudioPreviewPlayer - #22502
Conversation
## Summary Fixes Sentry `NotSupportedError: The operation is not supported.` from the audio widget preview ([FRONT-3745](https://linear.app/comfyorg/issue/FRONT-3745), [FRONT-3747](https://linear.app/comfyorg/issue/FRONT-3747)). Safari rejects `HTMLMediaElement.play()` with that error when it cannot play a source. `AudioPreviewPlayer.togglePlayPause` called `void play()` and set `isPlaying = true` regardless. So the rejection went unhandled, the click did nothing, the button switched to pause, and the next click called `pause()` instead of retrying. Confirmed from the events: [CLOUD-FRONTEND-PROD-363](https://comfy-org.sentry.io/issues/7819622225/) (Safari 26.6.2, release 1.58.0) and [CLOUD-FRONTEND-PROD-2QY](https://comfy-org.sentry.io/issues/7794752354/) (release 1.56.3) both show `togglePlayPause` as the only first-party frame under `[native code] play`. Impact: 4 events, 3 users, 15 days. ## Changes - `play()` is awaited in `try/catch`. On failure the button returns to play, a warning is logged, and a localized error toast is shown. `AbortError` stays silent. - A `playAttempt` counter ignores late results from attempts superseded by pause, a source change, or unmount. - The toast has a stable id per player, so repeat clicks replace it. It clears on a successful retry, a source change, or unmount. - Clearing the source now pauses the element. Removing the `src` attribute alone leaves audio playing. - One `watch(modelValue)` replaces the previous `whenever`. Its `immediate` was a no-op because the template ref is null during setup. - `aria-pressed` on the toggle. - A failed source is reloaded before a retry, since `play()` keeps rejecting until `load()` runs. - The player follows `pause` and `error` events from the element, so media keys and mid-playback failures no longer leave the button stuck. - Clearing the source resets the shown time. - Failures go through `reportError` at warning level (`error_playing_audio`), so they stay measurable. ## Verification - Unit: 19 component tests. - Real WebKit via Playwright, isolated pattern page rather than the full app: old `void play()` logged the unhandled production message; the handled pattern stayed paused (screenshot below). ## Not in this PR - [FRONT-3746](https://linear.app/comfyorg/issue/FRONT-3746), fixed in #22451: the same error from `useWaveAudioPlayer` ([CLOUD-FRONTEND-PROD-31S](https://comfy-org.sentry.io/issues/7811786061/)). - Other alerts in this family come from the `comfyui-videohelpersuite` custom node, outside this repo. ## Screenshots  ## Update: 208fc8d (@dante01yoon, comment 4430258389) Fixed the double `reportError`. `handleError` now claims the pending play attempt (`playAttempt++`), so the `play()` rejection that follows is ignored as stale. One click on a failed source now reports once, whichever arrives first: - error event first: `handleError` reports, and the stale catch exits. - rejection first: the catch reports and sets `isPlaying=false`, and the later error event hits the `!isPlaying` guard. There's a test for each order. The error-first test fails without the fix. Results: 24/24 component tests pass, lint/typecheck are clean, and the deep-reviewer verdict was PASS. ## Update: 577f69f (@dante01yoon, comments 4431351009/11/14/17) - Removed the JSDoc on the non-exported `toPlaybackError` and the three `//` comments in the tests. Behaviour and assertions are unchanged. - Renamed two tests so their titles carry the intent: "resets the shown elapsed time when the source is cleared mid-playback" and "dismisses only its own error toast when %s". - The older section comments (`// Refs`, `// Computed`, …) were already in the file before this PR, so I left them alone. - 24/24 component tests pass and lint is clean. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T13:04:18.906Z",
"gitSha": "cf2014938585b8632d6c10a7ee741fc7681853c4",
"branch": "backport-22390-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.7640000000056,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.678,
"layouts": 10,
"layoutDurationMs": 3.5599999999999996,
"taskDurationMs": 698.35,
"heapDeltaBytes": -5844560,
"heapUsedBytes": 86237696,
"domNodes": -200,
"jsHeapTotalBytes": 2764800,
"scriptDurationMs": 13.217000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2039.5530000000122,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1229999999999998,
"layouts": 9,
"layoutDurationMs": 2.9299999999999997,
"taskDurationMs": 499.48499999999996,
"heapDeltaBytes": 964844,
"heapUsedBytes": 89011368,
"domNodes": -200,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 13.204,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.7320000000068,
"styleRecalcs": 54,
"styleRecalcDurationMs": 13.688,
"layouts": 9,
"layoutDurationMs": 2.835,
"taskDurationMs": 860.921,
"heapDeltaBytes": 5194292,
"heapUsedBytes": 92646976,
"domNodes": -180,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 175.827,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.7859999999591,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.235999999999999,
"layouts": 9,
"layoutDurationMs": 2.726,
"taskDurationMs": 858.548,
"heapDeltaBytes": 1799044,
"heapUsedBytes": 89740372,
"domNodes": -200,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 178.41899999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.7270000000244,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.594,
"layouts": 11,
"layoutDurationMs": 2.963,
"taskDurationMs": 451.6329999999999,
"heapDeltaBytes": 21579988,
"heapUsedBytes": 109373436,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.000000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.3140000000776,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.392,
"layouts": 10,
"layoutDurationMs": 2.671,
"taskDurationMs": 457.38900000000007,
"heapDeltaBytes": 21501900,
"heapUsedBytes": 111724096,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 14.327999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 674.3319999999926,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.044,
"layouts": 9,
"layoutDurationMs": 3.4219999999999997,
"taskDurationMs": 478.694,
"heapDeltaBytes": 679964,
"heapUsedBytes": 87697456,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 180.51600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8389999999686,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.8140000000000005,
"layouts": 10,
"layoutDurationMs": 3.065,
"taskDurationMs": 484.89200000000005,
"heapDeltaBytes": 255600,
"heapUsedBytes": 88193128,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 180.082,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1278.6250000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 965.8729999999999,
"heapDeltaBytes": -14570544,
"heapUsedBytes": 102256276,
"domNodes": -230,
"jsHeapTotalBytes": 16850944,
"scriptDurationMs": 72.19500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 601,
"frameDurationMs": 34.681081081081075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1278.396999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 955.7800000000001,
"heapDeltaBytes": -14401156,
"heapUsedBytes": 102280756,
"domNodes": -230,
"jsHeapTotalBytes": 16850944,
"scriptDurationMs": 82.073,
"eventListeners": -168,
"totalBlockingTimeMs": 596,
"frameDurationMs": 34.68378378378379,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 850.2249999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.3730000000003,
"heapDeltaBytes": -2769068,
"heapUsedBytes": 98597040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.66899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.751000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.5609999999999,
"heapDeltaBytes": -2215396,
"heapUsedBytes": 92996644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.641,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11931.310999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11048.3,
"heapDeltaBytes": 41200896,
"heapUsedBytes": 166508220,
"domNodes": -299,
"jsHeapTotalBytes": 52572160,
"scriptDurationMs": 8806.339,
"eventListeners": -130,
"totalBlockingTimeMs": 1768,
"frameDurationMs": 32.33848238482385,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11118.516,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10280.667,
"heapDeltaBytes": 37419468,
"heapUsedBytes": 159079124,
"domNodes": -276,
"jsHeapTotalBytes": 39911424,
"scriptDurationMs": 8202.593,
"eventListeners": -130,
"totalBlockingTimeMs": 1125,
"frameDurationMs": 30.878333333333334,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10881.73999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10152.712000000001,
"heapDeltaBytes": 28301204,
"heapUsedBytes": 149251216,
"domNodes": -276,
"jsHeapTotalBytes": 41746432,
"scriptDurationMs": 8109.440000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1116,
"frameDurationMs": 31.182808022922632,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10328.062999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.39099999999999985,
"layouts": 1,
"layoutDurationMs": 0.22299999999999967,
"taskDurationMs": 9534.795,
"heapDeltaBytes": 33250832,
"heapUsedBytes": 154830496,
"domNodes": -296,
"jsHeapTotalBytes": 35717120,
"scriptDurationMs": 7873.419999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1166,
"frameDurationMs": 31.84043209876543,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 257.35999999997716,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.485999999999997,
"layouts": 12,
"layoutDurationMs": 4.1499999999999995,
"taskDurationMs": 206.41700000000003,
"heapDeltaBytes": 15364984,
"heapUsedBytes": 117128776,
"domNodes": 917,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.417000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 8,
"frameDurationMs": 26.660000000000036,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 269.5939999999837,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.529,
"layouts": 12,
"layoutDurationMs": 4.210999999999999,
"taskDurationMs": 217.07499999999996,
"heapDeltaBytes": 15531396,
"heapUsedBytes": 116179220,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 9.175,
"eventListeners": 196,
"totalBlockingTimeMs": 7,
"frameDurationMs": 24.24545454545453,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2050.7760000000135,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3549999999999995,
"layouts": 6,
"layoutDurationMs": 2.0120000000000005,
"taskDurationMs": 770.711,
"heapDeltaBytes": -8636276,
"heapUsedBytes": 94829216,
"domNodes": -276,
"jsHeapTotalBytes": -2740224,
"scriptDurationMs": 39.748,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.9729999998945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.633,
"layouts": 8,
"layoutDurationMs": 2.7509999999999994,
"taskDurationMs": 573.158,
"heapDeltaBytes": 16932,
"heapUsedBytes": 102000352,
"domNodes": -296,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 37.825,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3054.4380000000046,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.521999999999998,
"layouts": 7,
"layoutDurationMs": 1.8929999999999998,
"taskDurationMs": 1892.896,
"heapDeltaBytes": 13125536,
"heapUsedBytes": 119785972,
"domNodes": -296,
"jsHeapTotalBytes": 6135808,
"scriptDurationMs": 886.3389999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2965.1369999999133,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.636999999999999,
"layouts": 6,
"layoutDurationMs": 1.419,
"taskDurationMs": 1860.3759999999997,
"heapDeltaBytes": -3611076,
"heapUsedBytes": 103872180,
"domNodes": -296,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 874.783,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76079545454546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3607.2059999999624,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.318999999999999,
"layouts": 64,
"layoutDurationMs": 10.838000000000001,
"taskDurationMs": 1725.9409999999998,
"heapDeltaBytes": -14174000,
"heapUsedBytes": 92535096,
"domNodes": -272,
"jsHeapTotalBytes": -2347008,
"scriptDurationMs": 827.61,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666203703703705,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3616.9590000000653,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.089999999999998,
"layouts": 63,
"layoutDurationMs": 10.452,
"taskDurationMs": 1637.2970000000003,
"heapDeltaBytes": 7104108,
"heapUsedBytes": 111582960,
"domNodes": 24,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 798.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74305555555556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3008.194000000003,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.327,
"layouts": 5,
"layoutDurationMs": 1.5269999999999997,
"taskDurationMs": 1838.533,
"heapDeltaBytes": 22378064,
"heapUsedBytes": 128486568,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 976.7849999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.943333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3207.0990000000847,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.15,
"layouts": 5,
"layoutDurationMs": 1.5269999999999997,
"taskDurationMs": 2130.569,
"heapDeltaBytes": -3269248,
"heapUsedBytes": 98539952,
"domNodes": 0,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 1023.761,
"eventListeners": 182,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.107407407407415,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.5460000000257,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.394,
"layouts": 7,
"layoutDurationMs": 2.418,
"taskDurationMs": 762.7080000000001,
"heapDeltaBytes": -23047388,
"heapUsedBytes": 98824584,
"domNodes": -296,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 39.191,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.2030000000486,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.398999999999999,
"layouts": 7,
"layoutDurationMs": 2.028,
"taskDurationMs": 733.887,
"heapDeltaBytes": 467532,
"heapUsedBytes": 103015996,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 35.801,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.910000000019,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.504,
"layouts": 11,
"layoutDurationMs": 2.9810000000000003,
"taskDurationMs": 439.94899999999996,
"heapDeltaBytes": 22532136,
"heapUsedBytes": 111973228,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 147.897,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736848,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.8850000000848,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.9719999999999995,
"layouts": 10,
"layoutDurationMs": 3.3880000000000003,
"taskDurationMs": 404.39300000000003,
"heapDeltaBytes": 22446508,
"heapUsedBytes": 114593928,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 152.061,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2051.066999999989,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.583,
"layouts": 8,
"layoutDurationMs": 2.8930000000000002,
"taskDurationMs": 686.575,
"heapDeltaBytes": 7858728,
"heapUsedBytes": 97178124,
"domNodes": -198,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 12.126999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.5100000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.084000000000001,
"layouts": 9,
"layoutDurationMs": 2.866,
"taskDurationMs": 586.853,
"heapDeltaBytes": -725844,
"heapUsedBytes": 91198968,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.995999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.4559999999935,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.360999999999999,
"layouts": 9,
"layoutDurationMs": 2.8939999999999997,
"taskDurationMs": 789.945,
"heapDeltaBytes": -2816180,
"heapUsedBytes": 86646864,
"domNodes": -210,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 116.667,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1992.6479999999174,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.482999999999997,
"layouts": 11,
"layoutDurationMs": 3.418,
"taskDurationMs": 999.58,
"heapDeltaBytes": 4874064,
"heapUsedBytes": 94953300,
"domNodes": -190,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 119.25300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.98699999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.780000000000005,
"layouts": 5,
"layoutDurationMs": 17.116000000000003,
"taskDurationMs": 1176.7259999999999,
"heapDeltaBytes": 36019964,
"heapUsedBytes": 137635624,
"domNodes": 16030,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 45.892,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8321.66699999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.923,
"layouts": 8,
"layoutDurationMs": 2.234,
"taskDurationMs": 5521.858,
"heapDeltaBytes": 1727128,
"heapUsedBytes": 103515236,
"domNodes": -296,
"jsHeapTotalBytes": -4096,
"scriptDurationMs": 2771.098,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766733870967744,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10950.770000000033,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.110999999999997,
"layouts": 6,
"layoutDurationMs": 1.885,
"taskDurationMs": 6471.6050000000005,
"heapDeltaBytes": 10107644,
"heapUsedBytes": 111402824,
"domNodes": -276,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 2936.6160000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691463414634146,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16527.02499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15543.753999999999,
"heapDeltaBytes": -57517516,
"heapUsedBytes": 261953428,
"domNodes": -3344,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 241.14599999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.553886010362696,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16301.062999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15291.582999999999,
"heapDeltaBytes": -12658488,
"heapUsedBytes": 287969300,
"domNodes": -307,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 263.3299999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.150777202072536,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 28265.445999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.763000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27958.939,
"heapDeltaBytes": -27640660,
"heapUsedBytes": 302969864,
"domNodes": -3344,
"jsHeapTotalBytes": 8830976,
"scriptDurationMs": 900.608,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 53.53314393939393,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 28280.662000000008,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.179000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27844.535,
"heapDeltaBytes": -48029776,
"heapUsedBytes": 281644892,
"domNodes": -3344,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 912.6730000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 52.76529850746268,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8324.76399999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.86699999999999,
"layouts": 20,
"layoutDurationMs": 34.70200000000001,
"taskDurationMs": 8214.673,
"heapDeltaBytes": -40603304,
"heapUsedBytes": 265013040,
"domNodes": -3344,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 131.79800000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.785714285714285,
"p95FrameDurationMs": 99.99999999999818
},
{
"name": "vue-node-resize-workload",
"durationMs": 8393.785999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.253,
"layouts": 20,
"layoutDurationMs": 23.909999999999986,
"taskDurationMs": 8254.401,
"heapDeltaBytes": -3807172,
"heapUsedBytes": 301359924,
"domNodes": -3344,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 124.86399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.83240223463686,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8179.544999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7694.152000000001,
"heapDeltaBytes": 2788820,
"heapUsedBytes": 287391892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.39899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.217241379310344,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11818.374000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11495.888,
"heapDeltaBytes": -8288468,
"heapUsedBytes": 519639756,
"domNodes": 0,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 158.325,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.02881944444443,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 147.35100000001466,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.985000000000001,
"layouts": 9,
"layoutDurationMs": 4.111,
"taskDurationMs": 118.51,
"heapDeltaBytes": -14890548,
"heapUsedBytes": 89778964,
"domNodes": 120,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.049,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 128.620000000069,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.728,
"layouts": 8,
"layoutDurationMs": 4.103000000000001,
"taskDurationMs": 96.222,
"heapDeltaBytes": 4592100,
"heapUsedBytes": 95341968,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.723000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 444.32500000004893,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.669,
"layouts": 76,
"layoutDurationMs": 14.985999999999999,
"taskDurationMs": 387.535,
"heapDeltaBytes": 11180880,
"heapUsedBytes": 81723800,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 183.96699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 452.3510000000215,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.61,
"layouts": 76,
"layoutDurationMs": 14.652999999999999,
"taskDurationMs": 403.83599999999996,
"heapDeltaBytes": -14559288,
"heapUsedBytes": 81196148,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 191.86700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 533.2980000000589,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.778,
"layouts": 76,
"layoutDurationMs": 13.757,
"taskDurationMs": 502.129,
"heapDeltaBytes": 347852,
"heapUsedBytes": 118046920,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 204.563,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.19062500000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 672.715999999923,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.789,
"layouts": 76,
"layoutDurationMs": 17.467,
"taskDurationMs": 613.5429999999999,
"heapDeltaBytes": 1472488,
"heapUsedBytes": 117033876,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 252.13800000000003,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414636,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 2996 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 999421093be65286223cf30f3b0acdb230c7a639
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (143)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22502 +/- ##
=============================================
Coverage ? 86.05%
=============================================
Files ? 2600
Lines ? 136067
Branches ? 41569
=============================================
Hits ? 117094
Misses ? 18556
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22390 to
cloud/1.58Automatically created by backport workflow.