Repository navigation
[backport cloud/1.59] fix(agent): trim the onboarding tour to the panel and say how chats follow tabs - #22500
Conversation
…ollow tabs (#22269) ## Summary Two tour fixes from #pillar5-agent feedback, plus the redundant last-card control from PM-2285. - **Card 2 copy was out of date.** "It switches with your tabs until you send a message…" stopped being true after #21512: switching a workflow tab now brings up that workflow's latest chat, and a chat stays with the workflow it started on. New copy: **"Each chat works on one workflow"** / "The workflow it's editing is named above the message box. Switching tabs brings up that workflow's latest chat, if it has one." - **Card 3 removed.** It moved the spotlight and focus across the screen to the canvas (often a cluttered default graph), which testers found jarring, and four cards felt long (PM-2285). The tour now has three cards, all inside the Agent panel. The `graph-bottom` placement and `toolbarTarget` that only it used are deleted. - **Last card offers Done only.** Skip and Done did the same thing there. Escape still dismisses. The `targetFollowsVisibleWorkflow` banner is unchanged: it describes a fresh chat before you engage with it, which is still accurate. Linear: https://linear.app/comfyorg/issue/PM-2396, related https://linear.app/comfyorg/issue/PM-2285 ## Tests - Red first on `main`: `OnboardingCoach.test.ts` "offers Skip on every card but the last…" and `AgentPanelRoot.test.ts` "walks through the three cards…" failed; green on this branch. - "sends once when a coach step never finds its target" used the canvas card as its missing target. It now detaches the history button's id, asserts the history card never appears, and still fails if the detach is removed. - `OnboardingCoach`, `useOnboarding`, `AgentPanelRoot` unit suites green. Updated `agentOnboarding.spec.ts` (also asserts no Skip on the last card) and `agentActivationConsent.spec.ts`. - `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, `locale:check`, knip, pre-push Fallow audit clean. ## Notes - **Telemetry:** `agent_onboarding_step` sends `step: index + 1` with no step id. After this ships, step 3 is the history card (was the canvas card) and `finish` fires on step 3 (was 4). Funnels that span the release should split on app version. - Adversarial review (fresh Claude reviewer; Codex unavailable on this host): no blockers. Applied: "if it has one" in the copy, removed added comments, dropped a duplicated Skip assertion, pinned that the missing-target test never shows the history card. Left as is: the `index < 2` card border (renders the same as before). - Copy only changes `en`; other locales follow through the i18n workflow. - README and the cloud E2E runbook now describe a three-card tour.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-31T14:10:52.744Z",
"gitSha": "04a31fdf045928ec0abe66cb283a3dc514dd63f3",
"branch": "backport-22269-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9799999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.935,
"layouts": 8,
"layoutDurationMs": 2.0210000000000004,
"taskDurationMs": 499.36,
"heapDeltaBytes": 3412856,
"heapUsedBytes": 64661540,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7.926000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2007.7120000000832,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.756,
"layouts": 10,
"layoutDurationMs": 2.952000000000001,
"taskDurationMs": 510.572,
"heapDeltaBytes": 4042124,
"heapUsedBytes": 64504968,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9.270999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.3399999999992,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.232999999999999,
"layouts": 10,
"layoutDurationMs": 2.8649999999999993,
"taskDurationMs": 873.073,
"heapDeltaBytes": -1985508,
"heapUsedBytes": 69153776,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 159.267,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.4439999999167,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.091000000000001,
"layouts": 10,
"layoutDurationMs": 2.7670000000000003,
"taskDurationMs": 838.9459999999999,
"heapDeltaBytes": -2199628,
"heapUsedBytes": 68325048,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 154.11799999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1810000000305,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.994,
"layouts": 11,
"layoutDurationMs": 3.1439999999999997,
"taskDurationMs": 386.367,
"heapDeltaBytes": 24074476,
"heapUsedBytes": 84853832,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.500000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6730000000389,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.052000000000001,
"layouts": 12,
"layoutDurationMs": 3.015,
"taskDurationMs": 394.574,
"heapDeltaBytes": 47648,
"heapUsedBytes": 70650836,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.621999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 641.3530000000378,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.4699999999999998,
"layouts": 9,
"layoutDurationMs": 2.2379999999999995,
"taskDurationMs": 487.479,
"heapDeltaBytes": 3869728,
"heapUsedBytes": 65236372,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 166.22699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 659.6700000000055,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6299999999999994,
"layouts": 9,
"layoutDurationMs": 2.366,
"taskDurationMs": 477.36100000000005,
"heapDeltaBytes": 4210924,
"heapUsedBytes": 65226392,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 169.031,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.187000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.6320000000001,
"heapDeltaBytes": -12075988,
"heapUsedBytes": 75648548,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 70.39599999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 534,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.2580000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.673,
"heapDeltaBytes": -13713904,
"heapUsedBytes": 75430284,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 65.415,
"eventListeners": -106,
"totalBlockingTimeMs": 503,
"frameDurationMs": 32.86944444444444,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 912.2619999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.1689999999998,
"heapDeltaBytes": -28815608,
"heapUsedBytes": 66328112,
"domNodes": -191,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 163.05599999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 249,
"frameDurationMs": 25.461111111111123,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 895.725000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.3210000000004,
"heapDeltaBytes": -15037444,
"heapUsedBytes": 66114756,
"domNodes": -191,
"jsHeapTotalBytes": 1703936,
"scriptDurationMs": 166.869,
"eventListeners": -106,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10621.255999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9766.834,
"heapDeltaBytes": 57149096,
"heapUsedBytes": 130589344,
"domNodes": -257,
"jsHeapTotalBytes": 65138688,
"scriptDurationMs": 7769.999,
"eventListeners": -68,
"totalBlockingTimeMs": 1035,
"frameDurationMs": 31.976807228915664,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10075.210000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9325.108999999999,
"heapDeltaBytes": 53817520,
"heapUsedBytes": 128616264,
"domNodes": -257,
"jsHeapTotalBytes": 61992960,
"scriptDurationMs": 7450.444,
"eventListeners": -68,
"totalBlockingTimeMs": 677,
"frameDurationMs": 32.160383386581465,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9541.037999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11200000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8754.122,
"heapDeltaBytes": 62706700,
"heapUsedBytes": 136134816,
"domNodes": -257,
"jsHeapTotalBytes": 56225792,
"scriptDurationMs": 6944.418000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 603,
"frameDurationMs": 31.462046204620464,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9564.322999999946,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.034000000000000176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8804.043,
"heapDeltaBytes": 50916080,
"heapUsedBytes": 125130644,
"domNodes": -257,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 6994.876,
"eventListeners": -68,
"totalBlockingTimeMs": 658,
"frameDurationMs": 31.46776315789474,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 211.51900000000978,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.405,
"layouts": 11,
"layoutDurationMs": 2.902,
"taskDurationMs": 158.12699999999998,
"heapDeltaBytes": 14464108,
"heapUsedBytes": 84755928,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.901,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 27.07499999999999,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 256.3119999999799,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.354000000000001,
"layouts": 10,
"layoutDurationMs": 3.3949999999999996,
"taskDurationMs": 208.61899999999997,
"heapDeltaBytes": -338392,
"heapUsedBytes": 68405588,
"domNodes": -2315,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 8.667,
"eventListeners": -573,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2056.0010000000375,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.012,
"layouts": 8,
"layoutDurationMs": 1.966,
"taskDurationMs": 621.6830000000001,
"heapDeltaBytes": 5518232,
"heapUsedBytes": 81715600,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 33.489000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.056000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5640000000000005,
"layouts": 8,
"layoutDurationMs": 2.6440000000000006,
"taskDurationMs": 621.4600000000002,
"heapDeltaBytes": -10888196,
"heapUsedBytes": 64325008,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 31.889,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2432.1560000000204,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.536999999999999,
"layouts": 8,
"layoutDurationMs": 2.1550000000000002,
"taskDurationMs": 1687.3060000000003,
"heapDeltaBytes": 5791616,
"heapUsedBytes": 80742852,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 836.729,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172413,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2344.910000000027,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.768,
"layouts": 7,
"layoutDurationMs": 1.8599999999999999,
"taskDurationMs": 1669.3799999999999,
"heapDeltaBytes": -12000928,
"heapUsedBytes": 80479436,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 813.0110000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3699.856000000011,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.248,
"layouts": 64,
"layoutDurationMs": 10.34,
"taskDurationMs": 1787.5580000000002,
"heapDeltaBytes": -1190064,
"heapUsedBytes": 70174028,
"domNodes": -233,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 785.497,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3654.465000000073,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.103,
"layouts": 64,
"layoutDurationMs": 10.329999999999998,
"taskDurationMs": 1753.6150000000005,
"heapDeltaBytes": -7693480,
"heapUsedBytes": 69665028,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 775.9979999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3054.1090000000395,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.9750000000000005,
"layouts": 5,
"layoutDurationMs": 1.2439999999999998,
"taskDurationMs": 1967.582,
"heapDeltaBytes": -7234276,
"heapUsedBytes": 73663936,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 990.3990000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8489010989011,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2876.355999999987,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.614000000000001,
"layouts": 4,
"layoutDurationMs": 1.095,
"taskDurationMs": 1903.336,
"heapDeltaBytes": 17276252,
"heapUsedBytes": 98594680,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 952.5759999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763157894736842,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3073.9670000000388,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.844,
"layouts": 8,
"layoutDurationMs": 1.694,
"taskDurationMs": 768.7719999999999,
"heapDeltaBytes": -12689652,
"heapUsedBytes": 80503832,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 363.771,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3054.0909999999712,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9789999999999999,
"layouts": 8,
"layoutDurationMs": 1.933,
"taskDurationMs": 767.2639999999999,
"heapDeltaBytes": -19758704,
"heapUsedBytes": 60548604,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 353.009,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.6959999999876,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.013,
"layouts": 8,
"layoutDurationMs": 1.723,
"taskDurationMs": 626.714,
"heapDeltaBytes": -9669444,
"heapUsedBytes": 71100060,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 35.24000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.1339999999518,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8390000000000004,
"layouts": 7,
"layoutDurationMs": 1.8470000000000002,
"taskDurationMs": 615.192,
"heapDeltaBytes": -12368340,
"heapUsedBytes": 64716248,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 31.468999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2757.6080000000047,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.206000000000001,
"layouts": 7,
"layoutDurationMs": 1.6100000000000003,
"taskDurationMs": 573.7729999999999,
"heapDeltaBytes": 433720,
"heapUsedBytes": 81673116,
"domNodes": -244,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 181.729,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2931.630999999925,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.946000000000002,
"layouts": 6,
"layoutDurationMs": 1.4160000000000001,
"taskDurationMs": 617.5749999999999,
"heapDeltaBytes": -7031128,
"heapUsedBytes": 72418012,
"domNodes": -247,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 189.091,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285717,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3248.014000000012,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6440000000000006,
"layouts": 7,
"layoutDurationMs": 1.7890000000000001,
"taskDurationMs": 928.928,
"heapDeltaBytes": -7612220,
"heapUsedBytes": 84915492,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 363.908,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752331606217616,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3263.6380000000145,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4860000000000004,
"layouts": 6,
"layoutDurationMs": 1.5559999999999996,
"taskDurationMs": 920.223,
"heapDeltaBytes": -15243900,
"heapUsedBytes": 77610312,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 382.25299999999993,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752061855670107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.7899999999654,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.549999999999999,
"layouts": 10,
"layoutDurationMs": 2.573,
"taskDurationMs": 426.428,
"heapDeltaBytes": 2155092,
"heapUsedBytes": 74057596,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 142.403,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.7089999999844,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.502999999999999,
"layouts": 9,
"layoutDurationMs": 2.233,
"taskDurationMs": 429.451,
"heapDeltaBytes": -911584,
"heapUsedBytes": 60840048,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 147.66899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.6379999999858,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4220000000000006,
"layouts": 9,
"layoutDurationMs": 2.5089999999999995,
"taskDurationMs": 493.661,
"heapDeltaBytes": 2905944,
"heapUsedBytes": 65172660,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 6.9670000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.2040000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.398,
"layouts": 9,
"layoutDurationMs": 2.532,
"taskDurationMs": 507.80499999999995,
"heapDeltaBytes": 3385236,
"heapUsedBytes": 65552052,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 7.370999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1530000000148,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.796000000000001,
"layouts": 8,
"layoutDurationMs": 2.196,
"taskDurationMs": 798.898,
"heapDeltaBytes": 17539824,
"heapUsedBytes": 80056360,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 106.333,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.2160000000313,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.044,
"layouts": 9,
"layoutDurationMs": 2.495,
"taskDurationMs": 911.385,
"heapDeltaBytes": 17472664,
"heapUsedBytes": 79133984,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 115.73200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.2869999999557,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.377000000000002,
"layouts": 5,
"layoutDurationMs": 14.445,
"taskDurationMs": 1036.9899999999998,
"heapDeltaBytes": 40432400,
"heapUsedBytes": 116837656,
"domNodes": 16030,
"jsHeapTotalBytes": 10096640,
"scriptDurationMs": 44.30500000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 158,
"frameDurationMs": 19.55466666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9149.305000000026,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.989,
"layouts": 8,
"layoutDurationMs": 1.9189999999999998,
"taskDurationMs": 5879.209000000001,
"heapDeltaBytes": -3948780,
"heapUsedBytes": 71944688,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2693.3849999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618181818182,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8772.362000000045,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.899,
"layouts": 8,
"layoutDurationMs": 1.9330000000000003,
"taskDurationMs": 5817.208,
"heapDeltaBytes": 4866404,
"heapUsedBytes": 83730884,
"domNodes": -257,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2681.9739999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665969581749053,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23053.23499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22368.047000000002,
"heapDeltaBytes": -33861636,
"heapUsedBytes": 266946552,
"domNodes": -3343,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 301.21,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.73965517241379,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 22760.775999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21873.959,
"heapDeltaBytes": -25635200,
"heapUsedBytes": 255962868,
"domNodes": -3343,
"jsHeapTotalBytes": 12406784,
"scriptDurationMs": 297.27899999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.1552495697074,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27848.814000000006,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.208000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27457.260999999995,
"heapDeltaBytes": -32686652,
"heapUsedBytes": 263385572,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 881.501,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 51.16213235294117,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27887.856999999938,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.482999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27575.389000000003,
"heapDeltaBytes": -48357164,
"heapUsedBytes": 253265048,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 882.322,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 51.44335793357934,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8258.045999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.616999999999976,
"layouts": 20,
"layoutDurationMs": 22.139000000000006,
"taskDurationMs": 8111.823999999999,
"heapDeltaBytes": -24477716,
"heapUsedBytes": 251841392,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 117.534,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.346067415730346,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8169.713000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.516,
"layouts": 20,
"layoutDurationMs": 33.56900000000002,
"taskDurationMs": 8055.941000000001,
"heapDeltaBytes": -43713388,
"heapUsedBytes": 258478408,
"domNodes": -3343,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 118.996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.66457142857143,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11367.943000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11103.670000000002,
"heapDeltaBytes": -11190548,
"heapUsedBytes": 258407544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.86900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.02183098591549,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11296.65799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10744.918000000001,
"heapDeltaBytes": -4542656,
"heapUsedBytes": 258253908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.82899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.98956228956228,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 120.10700000001862,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.27,
"layouts": 9,
"layoutDurationMs": 3.2769999999999997,
"taskDurationMs": 90.26299999999999,
"heapDeltaBytes": 4742680,
"heapUsedBytes": 64369356,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.985999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 469.15899999999056,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.272,
"layouts": 13,
"layoutDurationMs": 4.720000000000001,
"taskDurationMs": 119.311,
"heapDeltaBytes": 6637388,
"heapUsedBytes": 69060288,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.838000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 492.8589999999531,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.585,
"layouts": 76,
"layoutDurationMs": 15.103,
"taskDurationMs": 438.433,
"heapDeltaBytes": -4030824,
"heapUsedBytes": 38744768,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 213.063,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 508.64000000001397,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.644,
"layouts": 76,
"layoutDurationMs": 14.64,
"taskDurationMs": 459.03299999999996,
"heapDeltaBytes": -3870348,
"heapUsedBytes": 41161216,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 227.481,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 475.9070000000065,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.501,
"layouts": 76,
"layoutDurationMs": 13.982,
"taskDurationMs": 443.77500000000003,
"heapDeltaBytes": -420932,
"heapUsedBytes": 93319288,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 174.15900000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 452.30400000002646,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.601,
"layouts": 76,
"layoutDurationMs": 13.49,
"taskDurationMs": 426.835,
"heapDeltaBytes": 86384,
"heapUsedBytes": 89655776,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.62199999999999,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
}
]
}🎭 Playwright: ✅ 3127 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dc08fda5b4f859efd11027fcedc977cfe0bfe8a8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (226)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22500 +/- ##
=============================================
Coverage ? 86.42%
=============================================
Files ? 2661
Lines ? 137956
Branches ? 39796
=============================================
Hits ? 119227
Misses ? 17911
Partials ? 818
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Same changed lines as #22269, required checks green at this head.
Backport of #22269 to
cloud/1.59Automatically created by backport workflow.