Skip to content

[backport cloud/1.58] fix(agent): point the tour card at its target and answer clicks on the highlight - #22497

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-22347-to-cloud-1.58
Oct 31, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-22347-to-cloud-1.58

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #22347 to the 1.58 train. Tour card arrow, and clicks on the dimmed screen or highlight now outline the card.

The automatic backport failed on one conflict in OnboardingCoach.vue: this branch keeps v-reka-z-index on the overlay (main uses the z-tour class). The scrim test id and click handler come from #22347. Nothing else differs.

…e highlight (#22347)

- Tour card now has an arrow pointing at what it describes.
- Clicking the dimmed screen or the highlighted panel outlines the card
and moves focus to it.
- Fixes "tour looked broken": users clicked the highlighted panel and
never noticed the card (PM-2276).

<details><summary>Full context for agent readers</summary>

Report: https://linear.app/comfyorg/issue/PM-2276 . After accepting the
Agent consent card, the tour started. The first card ("Meet your Comfy
Agent") floats left of the spotlit panel with nothing tying it to the
highlight, so it read as another canvas node. The scrim swallows every
click while a card is up, so clicking the highlighted panel did nothing;
the reporter clicked around the panel for about a minute thinking the
tour was broken.

`OnboardingCoach.vue`:
- Side-placed cards (`left-*` placements) render an arrow on their right
edge, positioned with floating-ui's `arrow` middleware so it points at
the middle of the target, kept 20px off the rounded corners. The arrow
is hidden when `shift()` pushed the card past the 16px gap onto its
target (no room beside it) or the target's middle is outside the arrow's
reach. The canvas card (`graph-bottom`, main only) gets no arrow because
it sits on its target.
- The card's scroll moves to an inner wrapper (`min-h-0
overflow-y-auto`, 4px padding offset by a negative margin so button
focus rings are not clipped) so the arrow is not clipped; the card keeps
its max height.
- A click on the scrim (which also covers the spotlit area, since the
spotlight is `pointer-events-none`) sets `data-nudged` for 1.2s, which
draws a ring around the card, and moves focus to the card itself (not
Next, so a following Space or Enter cannot advance or finish the tour).
It does not advance, skip or report a step, and the ring clears when the
card changes or the tour ends. The ring is static, so nothing moves for
reduced-motion users.
- `describedBy` and `advanceLabelKey` computeds keep the template under
the complexity gate. They are written exactly as in #22269 so the two
PRs merge cleanly there.

README "First-use tour" describes both behaviours.

- The other half of PM-2276 (the typed message seemed to vanish): the
message is held until the tour ends, then sent (#19619). #21285 added a
note on the card ("Your message will send when you finish or skip the
tour."), released in v1.58.2 and cloud v1.59.2, and on core/cloud 1.57
for the next 1.57 patch. #21933 (main only, next minor) shows the
consent card when the panel first opens on the first two launches, so
most users meet it before typing.
- Overlaps #22269 (removes the canvas card) in `OnboardingCoach.vue` and
its test fixture. Whichever merges second resolves a small conflict. The
arrow check uses `placement.startsWith('left')`, so it typechecks with
or without `graph-bottom` in the union.

- `OnboardingCoach.test.ts`: the arrow's center (measured at its real
12px size) matches the target's center for each side-placed card (one
table case each) and is absent on the canvas card; the arrow hides when
the card is pushed onto a target with no room beside it and when the
target's center is out of reach, and stays when a small shift leaves a
gap; a scrim click marks the card, focuses it, keeps the tour open,
writes no completion and sends no step telemetry; the mark clears after
the timeout and when the user moves to the next card. The first three
failed on `main`; the hide and clear cases were checked by reverting
each guard. Each guard was checked by reverting it (the matching test
fails). `OnboardingCoach` 47/47, `AgentPanelRoot` 566/566 on this
branch.
- `agentOnboarding.spec.ts` (`@cloud`): the arrow is visible, sits left
of the spotlight and its center is within 4px of the spotlight's;
clicking the center of the spotlit panel focuses the card and keeps it
open. Not run locally (no cloud backend on this host); CI runs it.
- `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, stylelint,
oxfmt and the pre-push fallow audit are clean.

Fresh Claude reviewer (Codex unavailable on this host): no blockers.
Applied in 6da398c: arrow hidden when the card overlaps its target or
cannot reach its middle; ring cleared on card change; synchronous nudge;
new comments removed (repo rule); unit arrow measured at real size; e2e
checks arrow geometry and focus instead of `toBeVisible` and the 1.2s
attribute window.

All github-actions and CodeRabbit findings fixed in 0e2e166 (card
focus instead of Next, gap-aware arrow hiding, focus-ring padding,
table-driven arrow cases, polled e2e geometry) and their threads
resolved.

core/1.58, cloud/1.58, core/1.59, cloud/1.59: the card markup is the
same on all four. Cloud serves the 1.59 train; the local Desktop Agent
ships from 1.58 onward.

</details>

(cherry picked from commit 84536b2)
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 31, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 31, 2026 13:37
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 104.4 MB heap
dom-widget-clipping: · 59.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.0 MB heap
dom-widget-order-dense-n200-w200-i120: · 33.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 399ms TBT · 97.8 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 160ms TBT · 92.8 MB heap
extension-clean-combined-draw: · 41.1 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 79ms TBT · 121.3 MB heap
extension-rgthree-prototype-draw: · 40.8 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 89ms TBT · 126.8 MB heap
large-combo-open: · 46.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.1 MB heap
large-graph-zoom: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.8 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 116.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
subgraph-transition-enter: · 48.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 117ms TBT · 133.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 104.0 MB heap
vue-large-graph-idle: · 27.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 272.0 MB heap
vue-large-graph-pan: · 24.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 21ms TBT · 280.4 MB heap
vue-node-resize-workload: · 22.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 285.4 MB heap
vue-zoom-out-idle: · 29.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 348.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.2 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 113.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 469ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 95.1 MB
canvas-idle: DOM nodes -100
canvas-idle: event listeners -65
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 801ms
canvas-mouse-sweep: script duration 129ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 80.2 MB
canvas-mouse-sweep: DOM nodes -190
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 359ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 104.4 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 415ms
dom-widget-clipping: script duration 138ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 90.0 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 733ms
dom-widget-order-dense-n200-w200-i120: script duration 55ms
dom-widget-order-dense-n200-w200-i120: TBT 399ms
dom-widget-order-dense-n200-w200-i120: heap used 97.8 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -230
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 391ms
dom-widget-order-sparse-n1000-w20-i120: script duration 121ms
dom-widget-order-sparse-n1000-w20-i120: TBT 160ms
dom-widget-order-sparse-n1000-w20-i120: heap used 92.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 2
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 6770ms
extension-clean-combined-draw: script duration 5260ms
extension-clean-combined-draw: TBT 79ms
extension-clean-combined-draw: heap used 121.3 MB
extension-clean-combined-draw: DOM nodes -286
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 2
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6574ms
extension-rgthree-prototype-draw: script duration 5141ms
extension-rgthree-prototype-draw: TBT 89ms
extension-rgthree-prototype-draw: heap used 126.8 MB
extension-rgthree-prototype-draw: DOM nodes -296
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 22ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 12ms
large-combo-open: layout count 12
large-combo-open: style recalc count 23
large-combo-open: task duration 136ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 110.9 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 614ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 97.9 MB
large-graph-idle: DOM nodes -296
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1283ms
large-graph-pan: script duration 660ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 101.1 MB
large-graph-pan: DOM nodes -296
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1432ms
large-graph-zoom: script duration 663ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 95.8 MB
large-graph-zoom: DOM nodes -124
large-graph-zoom: event listeners -65
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 6
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1526ms
legacy-node-drag: script duration 782ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 116.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 9
minimap-idle: task duration 622ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 101.7 MB
minimap-idle: DOM nodes -296
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 371ms
subgraph-dom-widget-clipping: script duration 123ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 97.2 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 458ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 85.7 MB
subgraph-idle: DOM nodes -219
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 714ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 85.0 MB
subgraph-mouse-sweep: DOM nodes -200
subgraph-mouse-sweep: event listeners -174
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 752ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 117ms
subgraph-transition-enter: heap used 133.4 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5287ms
viewport-pan-sweep: script duration 2313ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 104.0 MB
viewport-pan-sweep: DOM nodes -286
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 36ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 19250ms
vue-large-graph-idle: script duration 275ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 272.0 MB
vue-large-graph-idle: DOM nodes -3346
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 41ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 153
vue-large-graph-pan: task duration 20500ms
vue-large-graph-pan: script duration 771ms
vue-large-graph-pan: TBT 21ms
vue-large-graph-pan: heap used 280.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 44ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 30ms
vue-node-resize-workload: style recalc duration 67ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 7137ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 285.4 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 34ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9092ms
vue-zoom-out-idle: script duration 128ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 348.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 8ms
workflow-execution: layout count 8
workflow-execution: style recalc count 8
workflow-execution: task duration 76ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 91.2 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 12ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 291ms
agent-composer-empty-conversation-typing: script duration 135ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 81.9 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 12ms
agent-composer-long-conversation-typing: style recalc duration 3ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 357ms
agent-composer-long-conversation-typing: script duration 133ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 113.1 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-31T13:48:45.211Z",
  "gitSha": "87db0f44c2da70044ffa4b5ec59384d90f7c20d9",
  "branch": "backport-22347-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.133999999994,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.8260000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.627,
      "taskDurationMs": 479.76800000000003,
      "heapDeltaBytes": -4459872,
      "heapUsedBytes": 83440836,
      "domNodes": -200,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 8.350999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.6470000000436,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.011,
      "layouts": 10,
      "layoutDurationMs": 2.702,
      "taskDurationMs": 457.882,
      "heapDeltaBytes": 26008332,
      "heapUsedBytes": 115995724,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 10.059000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1744.5069999999987,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.373,
      "layouts": 9,
      "layoutDurationMs": 2.33,
      "taskDurationMs": 786.306,
      "heapDeltaBytes": -8345448,
      "heapUsedBytes": 80477404,
      "domNodes": -200,
      "jsHeapTotalBytes": 327680,
      "scriptDurationMs": 127.15599999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1760.0490000000946,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.965000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.4299999999999997,
      "taskDurationMs": 815.772,
      "heapDeltaBytes": -995860,
      "heapUsedBytes": 87732312,
      "domNodes": -180,
      "jsHeapTotalBytes": 1900544,
      "scriptDurationMs": 131.03500000000003,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.4810000000257,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.462999999999999,
      "layouts": 11,
      "layoutDurationMs": 2.5969999999999995,
      "taskDurationMs": 335.156,
      "heapDeltaBytes": 1800440,
      "heapUsedBytes": 106039080,
      "domNodes": 47,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 11.011,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.3359999999939,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.442000000000001,
      "layouts": 11,
      "layoutDurationMs": 3.066,
      "taskDurationMs": 383.266,
      "heapDeltaBytes": 21480580,
      "heapUsedBytes": 112847816,
      "domNodes": 47,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 13.888000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 539.431000000036,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.833,
      "layouts": 10,
      "layoutDurationMs": 2.4210000000000003,
      "taskDurationMs": 360.26099999999997,
      "heapDeltaBytes": 241180,
      "heapUsedBytes": 89893144,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 135.534,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 618.1009999999105,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.874,
      "layouts": 9,
      "layoutDurationMs": 2.181,
      "taskDurationMs": 469.125,
      "heapDeltaBytes": 979056,
      "heapUsedBytes": 98754432,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 140.755,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.13055555555555,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1070.2989999999772,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 741.3219999999999,
      "heapDeltaBytes": -16092260,
      "heapUsedBytes": 102114552,
      "domNodes": -230,
      "jsHeapTotalBytes": 15355904,
      "scriptDurationMs": 54.528999999999996,
      "eventListeners": -168,
      "totalBlockingTimeMs": 403,
      "frameDurationMs": 29.627777777777776,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1072.2150000000283,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 723.9449999999999,
      "heapDeltaBytes": -13808720,
      "heapUsedBytes": 102885792,
      "domNodes": -230,
      "jsHeapTotalBytes": 15802368,
      "scriptDurationMs": 55.11099999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 395,
      "frameDurationMs": 29.627777777777787,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 780.0480000000221,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.4350000000002,
      "heapDeltaBytes": -4026020,
      "heapUsedBytes": 97678848,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 117.75,
      "eventListeners": 0,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 781.6470000000209,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.7909999999999,
      "heapDeltaBytes": -3752984,
      "heapUsedBytes": 97023248,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 123.744,
      "eventListeners": 0,
      "totalBlockingTimeMs": 161,
      "frameDurationMs": 23.035294117647055,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7831.291000000021,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5460000000000005,
      "layouts": 2,
      "layoutDurationMs": 0.41200000000000003,
      "taskDurationMs": 6946.928,
      "heapDeltaBytes": 7201780,
      "heapUsedBytes": 130011080,
      "domNodes": -296,
      "jsHeapTotalBytes": 20328448,
      "scriptDurationMs": 5245.366000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 74,
      "frameDurationMs": 24.32577639751553,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7403.547000000003,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.268,
      "layouts": 1,
      "layoutDurationMs": 0.22999999999999973,
      "taskDurationMs": 6592.295,
      "heapDeltaBytes": 2673616,
      "heapUsedBytes": 124270924,
      "domNodes": -276,
      "jsHeapTotalBytes": 26804224,
      "scriptDurationMs": 5273.942,
      "eventListeners": -130,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 24.341118421052627,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6810.170999999968,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6116.876,
      "heapDeltaBytes": -388292,
      "heapUsedBytes": 123040976,
      "domNodes": -296,
      "jsHeapTotalBytes": 18755584,
      "scriptDurationMs": 4898.137000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 83,
      "frameDurationMs": 24.87737226277372,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7903.683000000001,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.928,
      "layouts": 4,
      "layoutDurationMs": 1.105,
      "taskDurationMs": 7030.3060000000005,
      "heapDeltaBytes": 40609520,
      "heapUsedBytes": 142945444,
      "domNodes": -296,
      "jsHeapTotalBytes": 31784960,
      "scriptDurationMs": 5383.447,
      "eventListeners": -130,
      "totalBlockingTimeMs": 94,
      "frameDurationMs": 24.084756097560977,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 170.48600000003944,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 11.524000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.8230000000000004,
      "taskDurationMs": 134.92600000000002,
      "heapDeltaBytes": 15473388,
      "heapUsedBytes": 116073012,
      "domNodes": 917,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 7.589,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.36666666666669,
      "p95FrameDurationMs": 49.90000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 196.12000000006446,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 13.379000000000001,
      "layouts": 12,
      "layoutDurationMs": 3.375,
      "taskDurationMs": 137.92900000000003,
      "heapDeltaBytes": 13225944,
      "heapUsedBytes": 116594488,
      "domNodes": 917,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.471000000000002,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.91249999999991,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.3420000000096,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.7489999999999997,
      "layouts": 8,
      "layoutDurationMs": 2.2579999999999996,
      "taskDurationMs": 586.011,
      "heapDeltaBytes": -23727620,
      "heapUsedBytes": 97297812,
      "domNodes": -296,
      "jsHeapTotalBytes": -393216,
      "scriptDurationMs": 30.846,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.4920000000384,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.5579999999999994,
      "layouts": 8,
      "layoutDurationMs": 2.174,
      "taskDurationMs": 642.538,
      "heapDeltaBytes": 1670268,
      "heapUsedBytes": 108093272,
      "domNodes": -296,
      "jsHeapTotalBytes": -2031616,
      "scriptDurationMs": 34.321999999999996,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2188.4729999999877,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.31,
      "layouts": 8,
      "layoutDurationMs": 1.9880000000000002,
      "taskDurationMs": 1209.601,
      "heapDeltaBytes": -1939536,
      "heapUsedBytes": 104530756,
      "domNodes": -296,
      "jsHeapTotalBytes": 106496,
      "scriptDurationMs": 642.0389999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66564885496183,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2218.354999999974,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.637,
      "layouts": 7,
      "layoutDurationMs": 1.7940000000000003,
      "taskDurationMs": 1356.626,
      "heapDeltaBytes": 344816,
      "heapUsedBytes": 107512012,
      "domNodes": -296,
      "jsHeapTotalBytes": -1204224,
      "scriptDurationMs": 677.989,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66691729323308,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3247.6330000000075,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 10.356,
      "layouts": 66,
      "layoutDurationMs": 10.618,
      "taskDurationMs": 1344.9370000000001,
      "heapDeltaBytes": 7267032,
      "heapUsedBytes": 112011876,
      "domNodes": 24,
      "jsHeapTotalBytes": 5509120,
      "scriptDurationMs": 674.5400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7520618556701,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3567.8380000000516,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.54,
      "layouts": 64,
      "layoutDurationMs": 9.897,
      "taskDurationMs": 1519.64,
      "heapDeltaBytes": -13273096,
      "heapUsedBytes": 88938024,
      "domNodes": -272,
      "jsHeapTotalBytes": -2609152,
      "scriptDurationMs": 651.575,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.74460093896714,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2376.841000000013,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.015,
      "layouts": 5,
      "layoutDurationMs": 1.121,
      "taskDurationMs": 1608.1940000000002,
      "heapDeltaBytes": 17043408,
      "heapUsedBytes": 117460556,
      "domNodes": 0,
      "jsHeapTotalBytes": 3305472,
      "scriptDurationMs": 789.052,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78439716312057,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2216.3570000000163,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.566999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.4389999999999998,
      "taskDurationMs": 1443.5959999999998,
      "heapDeltaBytes": 15429616,
      "heapUsedBytes": 126383040,
      "domNodes": 0,
      "jsHeapTotalBytes": 6713344,
      "scriptDurationMs": 774.77,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.793893129770993,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2049.0819999999985,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.444,
      "layouts": 9,
      "layoutDurationMs": 2.355,
      "taskDurationMs": 582.4999999999999,
      "heapDeltaBytes": 1148836,
      "heapUsedBytes": 110308120,
      "domNodes": -296,
      "jsHeapTotalBytes": -2031616,
      "scriptDurationMs": 32.07599999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.0559999999978,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.529,
      "layouts": 8,
      "layoutDurationMs": 2.5100000000000002,
      "taskDurationMs": 661.613,
      "heapDeltaBytes": 655664,
      "heapUsedBytes": 103074252,
      "domNodes": -296,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 38.199000000000005,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 600.3790000000322,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.4430000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.3939999999999992,
      "taskDurationMs": 383.929,
      "heapDeltaBytes": -24988,
      "heapUsedBytes": 89681864,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 124.02400000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66388888888889,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 531.4799999999877,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.966999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.3030000000000004,
      "taskDurationMs": 358.50399999999996,
      "heapDeltaBytes": 22458004,
      "heapUsedBytes": 114083840,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 121.09,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.6110000000026,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.5329999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.2399999999999998,
      "taskDurationMs": 370.373,
      "heapDeltaBytes": 1000028,
      "heapUsedBytes": 90929872,
      "domNodes": -219,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 8.740000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.590999999963,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5269999999999997,
      "layouts": 8,
      "layoutDurationMs": 2.124,
      "taskDurationMs": 545.014,
      "heapDeltaBytes": -837960,
      "heapUsedBytes": 88897816,
      "domNodes": -218,
      "jsHeapTotalBytes": 1376256,
      "scriptDurationMs": 10.874000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.396000000032,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 13.995999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.237,
      "taskDurationMs": 755.9800000000001,
      "heapDeltaBytes": -3835460,
      "heapUsedBytes": 85984348,
      "domNodes": -210,
      "jsHeapTotalBytes": -3342336,
      "scriptDurationMs": 96.50200000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.859000000065,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.001,
      "layouts": 10,
      "layoutDurationMs": 3.0489999999999995,
      "taskDurationMs": 671.6869999999999,
      "heapDeltaBytes": 2727040,
      "heapUsedBytes": 92232384,
      "domNodes": -190,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 101.851,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 900.7389999999305,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 20.878,
      "layouts": 5,
      "layoutDurationMs": 12.552,
      "taskDurationMs": 752.4629999999999,
      "heapDeltaBytes": 35771044,
      "heapUsedBytes": 139925812,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16654336,
      "scriptDurationMs": 23.487999999999996,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 117,
      "frameDurationMs": 20.45227272727274,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10773.770000000013,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 32.827000000000005,
      "layouts": 8,
      "layoutDurationMs": 2.255,
      "taskDurationMs": 5235.774,
      "heapDeltaBytes": 669064,
      "heapUsedBytes": 104575100,
      "domNodes": -296,
      "jsHeapTotalBytes": -2285568,
      "scriptDurationMs": 2291.932,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.691782945736435,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11212.409999999978,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 32.287,
      "layouts": 8,
      "layoutDurationMs": 2.149,
      "taskDurationMs": 5338.078,
      "heapDeltaBytes": -6602656,
      "heapUsedBytes": 113578216,
      "domNodes": -276,
      "jsHeapTotalBytes": 847872,
      "scriptDurationMs": 2333.3280000000004,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612184249629,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 20032.97900000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19403.198999999997,
      "heapDeltaBytes": -54656220,
      "heapUsedBytes": 269599760,
      "domNodes": -3348,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 279.91900000000004,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.422909090909094,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19545.792000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19097.173,
      "heapDeltaBytes": -11712000,
      "heapUsedBytes": 300885252,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15716352,
      "scriptDurationMs": 270.322,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.166173752310534,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17411.873000000014,
      "styleRecalcs": 129,
      "styleRecalcDurationMs": 16.74600000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17179.907,
      "heapDeltaBytes": -25761076,
      "heapUsedBytes": 293841932,
      "domNodes": -3344,
      "jsHeapTotalBytes": 12308480,
      "scriptDurationMs": 730.98,
      "eventListeners": -651,
      "totalBlockingTimeMs": 33,
      "frameDurationMs": 33.20458015267175,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24054.687000000056,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 25.252999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23820.003,
      "heapDeltaBytes": -29666052,
      "heapUsedBytes": 294153648,
      "domNodes": -3344,
      "jsHeapTotalBytes": 11784192,
      "scriptDurationMs": 810.7260000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 47.90637450199204,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7281.247000000008,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.18299999999999,
      "layouts": 20,
      "layoutDurationMs": 30.017000000000003,
      "taskDurationMs": 7190.87,
      "heapDeltaBytes": -10039424,
      "heapUsedBytes": 295508740,
      "domNodes": -3344,
      "jsHeapTotalBytes": 19386368,
      "scriptDurationMs": 110.68,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 44.95740740740741,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7211.039000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 66.29899999999999,
      "layouts": 20,
      "layoutDurationMs": 30.5,
      "taskDurationMs": 7082.335,
      "heapDeltaBytes": -22449628,
      "heapUsedBytes": 302945220,
      "domNodes": -3344,
      "jsHeapTotalBytes": 18337792,
      "scriptDurationMs": 134.06,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 42.9547619047619,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9958.981999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9613.368,
      "heapDeltaBytes": 24028516,
      "heapUsedBytes": 303752916,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 131.64699999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.17028985507246,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8729.999000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8570.115999999998,
      "heapDeltaBytes": -39700724,
      "heapUsedBytes": 427684180,
      "domNodes": 0,
      "jsHeapTotalBytes": -43778048,
      "scriptDurationMs": 125.22699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.932846715328463,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.46800000003986,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.744,
      "layouts": 8,
      "layoutDurationMs": 2.97,
      "taskDurationMs": 81.60000000000001,
      "heapDeltaBytes": 5011020,
      "heapUsedBytes": 100760432,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.592000000000002,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.657142857142844,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 92.43100000003324,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.366999999999999,
      "layouts": 7,
      "layoutDurationMs": 2.8109999999999995,
      "taskDurationMs": 70.44600000000001,
      "heapDeltaBytes": -19825240,
      "heapUsedBytes": 90588040,
      "domNodes": 116,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 4.698,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.68333333333332,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 298.8300000000663,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.625,
      "layouts": 76,
      "layoutDurationMs": 12.271,
      "taskDurationMs": 264.36199999999997,
      "heapDeltaBytes": 10264932,
      "heapUsedBytes": 102175388,
      "domNodes": 4,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 121.03,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.672222222222242,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 346.66200000003755,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.8109999999999999,
      "layouts": 76,
      "layoutDurationMs": 12.181000000000001,
      "taskDurationMs": 317.587,
      "heapDeltaBytes": -21222148,
      "heapUsedBytes": 69580432,
      "domNodes": 4,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 148.12,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66818181818181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 414.7289999999657,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.693,
      "layouts": 76,
      "layoutDurationMs": 11.799000000000001,
      "taskDurationMs": 370.74999999999994,
      "heapDeltaBytes": -208392,
      "heapUsedBytes": 121050544,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 139.05399999999997,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667999999999992,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 377.0389999999679,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.536,
      "layouts": 76,
      "layoutDurationMs": 11.472,
      "taskDurationMs": 342.402,
      "heapDeltaBytes": -924796,
      "heapUsedBytes": 116086268,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 127.301,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66818181818185,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Line coverage: 63.6%

Coverage totals
Metric Covered Total Pct
Lines 57481 90349 63.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1170
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 314
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.9% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2988 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2288 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 671 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/31/2026, 01:38:59 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fbca485a5c5cc9d97ffa2295f892c5c1f4da293b

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (142)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/workspaceApi.webSessionRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 92 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife October 31, 2026 13:38
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 31, 2026
@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.58   #22497   +/-   ##
=============================================
  Coverage              ?   84.24%           
=============================================
  Files                 ?     3172           
  Lines                 ?   165481           
  Branches              ?    39080           
=============================================
  Hits                  ?   139409           
  Misses                ?    25680           
  Partials              ?      392           
Flag Coverage Δ
e2e 63.83% <ø> (?)
unit 86.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/components/agent/OnboardingCoach.vue 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approval.

@comfy-pr-bot
comfy-pr-bot merged commit 7c7fb25 into cloud/1.58 Oct 31, 2026
132 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-22347-to-cloud-1.58 branch October 31, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants