Repository navigation
[backport core/1.58] fix(agent): point the tour card at its target and answer clicks on the highlight - #22496
Conversation
…e highlight (#22347) - Tour card now has an arrow pointing at what it describes. - Clicking the dimmed screen or the highlighted panel outlines the card and moves focus to it. - Fixes "tour looked broken": users clicked the highlighted panel and never noticed the card (PM-2276). <details><summary>Full context for agent readers</summary> Report: https://linear.app/comfyorg/issue/PM-2276 . After accepting the Agent consent card, the tour started. The first card ("Meet your Comfy Agent") floats left of the spotlit panel with nothing tying it to the highlight, so it read as another canvas node. The scrim swallows every click while a card is up, so clicking the highlighted panel did nothing; the reporter clicked around the panel for about a minute thinking the tour was broken. `OnboardingCoach.vue`: - Side-placed cards (`left-*` placements) render an arrow on their right edge, positioned with floating-ui's `arrow` middleware so it points at the middle of the target, kept 20px off the rounded corners. The arrow is hidden when `shift()` pushed the card past the 16px gap onto its target (no room beside it) or the target's middle is outside the arrow's reach. The canvas card (`graph-bottom`, main only) gets no arrow because it sits on its target. - The card's scroll moves to an inner wrapper (`min-h-0 overflow-y-auto`, 4px padding offset by a negative margin so button focus rings are not clipped) so the arrow is not clipped; the card keeps its max height. - A click on the scrim (which also covers the spotlit area, since the spotlight is `pointer-events-none`) sets `data-nudged` for 1.2s, which draws a ring around the card, and moves focus to the card itself (not Next, so a following Space or Enter cannot advance or finish the tour). It does not advance, skip or report a step, and the ring clears when the card changes or the tour ends. The ring is static, so nothing moves for reduced-motion users. - `describedBy` and `advanceLabelKey` computeds keep the template under the complexity gate. They are written exactly as in #22269 so the two PRs merge cleanly there. README "First-use tour" describes both behaviours. - The other half of PM-2276 (the typed message seemed to vanish): the message is held until the tour ends, then sent (#19619). #21285 added a note on the card ("Your message will send when you finish or skip the tour."), released in v1.58.2 and cloud v1.59.2, and on core/cloud 1.57 for the next 1.57 patch. #21933 (main only, next minor) shows the consent card when the panel first opens on the first two launches, so most users meet it before typing. - Overlaps #22269 (removes the canvas card) in `OnboardingCoach.vue` and its test fixture. Whichever merges second resolves a small conflict. The arrow check uses `placement.startsWith('left')`, so it typechecks with or without `graph-bottom` in the union. - `OnboardingCoach.test.ts`: the arrow's center (measured at its real 12px size) matches the target's center for each side-placed card (one table case each) and is absent on the canvas card; the arrow hides when the card is pushed onto a target with no room beside it and when the target's center is out of reach, and stays when a small shift leaves a gap; a scrim click marks the card, focuses it, keeps the tour open, writes no completion and sends no step telemetry; the mark clears after the timeout and when the user moves to the next card. The first three failed on `main`; the hide and clear cases were checked by reverting each guard. Each guard was checked by reverting it (the matching test fails). `OnboardingCoach` 47/47, `AgentPanelRoot` 566/566 on this branch. - `agentOnboarding.spec.ts` (`@cloud`): the arrow is visible, sits left of the spotlight and its center is within 4px of the spotlight's; clicking the center of the spotlit panel focuses the card and keeps it open. Not run locally (no cloud backend on this host); CI runs it. - `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, stylelint, oxfmt and the pre-push fallow audit are clean. Fresh Claude reviewer (Codex unavailable on this host): no blockers. Applied in 6da398c: arrow hidden when the card overlaps its target or cannot reach its middle; ring cleared on card change; synchronous nudge; new comments removed (repo rule); unit arrow measured at real size; e2e checks arrow geometry and focus instead of `toBeVisible` and the 1.2s attribute window. All github-actions and CodeRabbit findings fixed in 0e2e166 (card focus instead of Next, gap-aware arrow hiding, focus-ring padding, table-driven arrow cases, polled e2e geometry) and their threads resolved. core/1.58, cloud/1.58, core/1.59, cloud/1.59: the card markup is the same on all four. Cloud serves the 1.59 train; the local Desktop Agent ships from 1.58 onward. </details> (cherry picked from commit 84536b2)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T13:47:49.415Z",
"gitSha": "024454b70db0c3139f0acb0c7ba971600031379c",
"branch": "backport-22347-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.6190000000101,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.895,
"layouts": 9,
"layoutDurationMs": 1.9240000000000002,
"taskDurationMs": 407.86999999999995,
"heapDeltaBytes": 4180700,
"heapUsedBytes": 104073220,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.942000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.757000000032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.279,
"layouts": 10,
"layoutDurationMs": 2.119,
"taskDurationMs": 339.111,
"heapDeltaBytes": 2049692,
"heapUsedBytes": 92986072,
"domNodes": -200,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 8.439999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.215000000001,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.695,
"layouts": 10,
"layoutDurationMs": 2.0740000000000003,
"taskDurationMs": 723.5769999999999,
"heapDeltaBytes": -20919476,
"heapUsedBytes": 78707560,
"domNodes": -200,
"jsHeapTotalBytes": 1191936,
"scriptDurationMs": 112.33600000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.5969999999793,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.092,
"layouts": 11,
"layoutDurationMs": 2.3309999999999995,
"taskDurationMs": 731.076,
"heapDeltaBytes": -21395032,
"heapUsedBytes": 83412736,
"domNodes": -200,
"jsHeapTotalBytes": 3239936,
"scriptDurationMs": 112.733,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.1939999999822,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.82,
"layouts": 11,
"layoutDurationMs": 2.091,
"taskDurationMs": 315.94,
"heapDeltaBytes": 25378208,
"heapUsedBytes": 115801028,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.403,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.8820000000028,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.967999999999999,
"layouts": 12,
"layoutDurationMs": 2.306,
"taskDurationMs": 230.736,
"heapDeltaBytes": -243252,
"heapUsedBytes": 90805348,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.489,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 552.1439999999984,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6189999999999998,
"layouts": 10,
"layoutDurationMs": 2.2329999999999997,
"taskDurationMs": 394.111,
"heapDeltaBytes": 3274864,
"heapUsedBytes": 94081580,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 130.229,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696968,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 584.384,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.4699999999999998,
"layouts": 10,
"layoutDurationMs": 2.142,
"taskDurationMs": 373.772,
"heapDeltaBytes": 3784932,
"heapUsedBytes": 94120772,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 130.902,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.5860000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.5469999999999,
"heapDeltaBytes": -15556736,
"heapUsedBytes": 102844108,
"domNodes": -230,
"jsHeapTotalBytes": 15802368,
"scriptDurationMs": 54.12500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 362,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1041.4289999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.3000000000001,
"heapDeltaBytes": -15266164,
"heapUsedBytes": 102834396,
"domNodes": -230,
"jsHeapTotalBytes": 15278080,
"scriptDurationMs": 51.01,
"eventListeners": -168,
"totalBlockingTimeMs": 381,
"frameDurationMs": 29.16666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.3270000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.5510000000002,
"heapDeltaBytes": -4532376,
"heapUsedBytes": 97123324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.07800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.3890000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.65000000000003,
"heapDeltaBytes": -3781076,
"heapUsedBytes": 97301712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.21900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7396.993999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053000000000000096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6626.789,
"heapDeltaBytes": 16716480,
"heapUsedBytes": 131775696,
"domNodes": -297,
"jsHeapTotalBytes": 19804160,
"scriptDurationMs": 5089.044000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 100,
"frameDurationMs": 24.942567567567572,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6511.026999999956,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8749999999999999,
"layouts": 4,
"layoutDurationMs": 1.032,
"taskDurationMs": 5836.737999999999,
"heapDeltaBytes": 10361904,
"heapUsedBytes": 113693704,
"domNodes": -296,
"jsHeapTotalBytes": 13434880,
"scriptDurationMs": 4651.1320000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 60,
"frameDurationMs": 24.90306513409962,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7346.810000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8170000000000001,
"layouts": 3,
"layoutDurationMs": 0.7469999999999999,
"taskDurationMs": 6556.115,
"heapDeltaBytes": 6203152,
"heapUsedBytes": 130203144,
"domNodes": -277,
"jsHeapTotalBytes": 20066304,
"scriptDurationMs": 5082.3769999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 123,
"frameDurationMs": 24.663422818791947,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7094.720999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.588,
"layouts": 2,
"layoutDurationMs": 0.5289999999999999,
"taskDurationMs": 6394.717,
"heapDeltaBytes": 25482944,
"heapUsedBytes": 128649300,
"domNodes": -296,
"jsHeapTotalBytes": 26542080,
"scriptDurationMs": 4893.063,
"eventListeners": -130,
"totalBlockingTimeMs": 39,
"frameDurationMs": 24.594097222222224,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 156.09799999998586,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.074,
"layouts": 11,
"layoutDurationMs": 2.534,
"taskDurationMs": 117.98100000000001,
"heapDeltaBytes": 13336432,
"heapUsedBytes": 118854840,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.35,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.849999999999966,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 160.2940000000217,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.987,
"layouts": 13,
"layoutDurationMs": 3.1,
"taskDurationMs": 119.984,
"heapDeltaBytes": 15510604,
"heapUsedBytes": 121133700,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.327000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2041.117000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.81,
"layouts": 8,
"layoutDurationMs": 1.7029999999999998,
"taskDurationMs": 536.068,
"heapDeltaBytes": -204220,
"heapUsedBytes": 104514880,
"domNodes": -296,
"jsHeapTotalBytes": -1953792,
"scriptDurationMs": 30.170999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2044.6080000000393,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1339999999999995,
"layouts": 9,
"layoutDurationMs": 2.0930000000000004,
"taskDurationMs": 398.258,
"heapDeltaBytes": -10755424,
"heapUsedBytes": 101941324,
"domNodes": -276,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 28.886999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2153.7379999999757,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.576,
"layouts": 8,
"layoutDurationMs": 1.7470000000000003,
"taskDurationMs": 1159.682,
"heapDeltaBytes": -8473972,
"heapUsedBytes": 108498320,
"domNodes": -296,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 624.7750000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2234.55899999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.633000000000003,
"layouts": 8,
"layoutDurationMs": 1.6520000000000004,
"taskDurationMs": 1335.5679999999998,
"heapDeltaBytes": -2088584,
"heapUsedBytes": 109518144,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 639.4909999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3315.091999999993,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.695000000000002,
"layouts": 65,
"layoutDurationMs": 9.316999999999998,
"taskDurationMs": 1448.207,
"heapDeltaBytes": -6224204,
"heapUsedBytes": 100329500,
"domNodes": -272,
"jsHeapTotalBytes": -2580480,
"scriptDurationMs": 618.151,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3220.852999999977,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.65,
"layouts": 67,
"layoutDurationMs": 10.085,
"taskDurationMs": 1310.143,
"heapDeltaBytes": -17611124,
"heapUsedBytes": 96156260,
"domNodes": -272,
"jsHeapTotalBytes": 458752,
"scriptDurationMs": 624.0550000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2571.044000000001,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.800000000000001,
"layouts": 6,
"layoutDurationMs": 1.1540000000000001,
"taskDurationMs": 1528.8549999999998,
"heapDeltaBytes": -11736472,
"heapUsedBytes": 102514720,
"domNodes": 0,
"jsHeapTotalBytes": 6033408,
"scriptDurationMs": 758.499,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665359477124184,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2194.6759999999585,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.05,
"layouts": 7,
"layoutDurationMs": 1.314,
"taskDurationMs": 1380.245,
"heapDeltaBytes": -12030236,
"heapUsedBytes": 102984260,
"domNodes": 0,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 735.9369999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.922307692307697,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.5079999999934,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.568,
"layouts": 7,
"layoutDurationMs": 1.565,
"taskDurationMs": 524.84,
"heapDeltaBytes": -9240984,
"heapUsedBytes": 96207032,
"domNodes": -296,
"jsHeapTotalBytes": -2449408,
"scriptDurationMs": 29.034000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.693,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5129999999999997,
"layouts": 7,
"layoutDurationMs": 1.496,
"taskDurationMs": 523.9150000000001,
"heapDeltaBytes": -813980,
"heapUsedBytes": 103126936,
"domNodes": -296,
"jsHeapTotalBytes": -2695168,
"scriptDurationMs": 30.988000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.0820000000335,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.574999999999999,
"layouts": 10,
"layoutDurationMs": 2.207,
"taskDurationMs": 403.93100000000004,
"heapDeltaBytes": 871580,
"heapUsedBytes": 102704128,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 119.542,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.9920000000025,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.392999999999999,
"layouts": 10,
"layoutDurationMs": 2.148,
"taskDurationMs": 351.39500000000004,
"heapDeltaBytes": 2728344,
"heapUsedBytes": 109540036,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 117.192,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.261999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.693999999999999,
"layouts": 9,
"layoutDurationMs": 3.45,
"taskDurationMs": 437.638,
"heapDeltaBytes": 3491608,
"heapUsedBytes": 96912252,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2021.6730000000211,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1420000000000003,
"layouts": 10,
"layoutDurationMs": 1.9459999999999997,
"taskDurationMs": 322.41200000000003,
"heapDeltaBytes": 4951728,
"heapUsedBytes": 106926564,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.209000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.1650000000118,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.751,
"layouts": 9,
"layoutDurationMs": 1.788,
"taskDurationMs": 518.15,
"heapDeltaBytes": 20749328,
"heapUsedBytes": 114058268,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 80.724,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.543999999984,
"styleRecalcs": 76,
"styleRecalcDurationMs": 10.766000000000002,
"layouts": 10,
"layoutDurationMs": 2.0419999999999994,
"taskDurationMs": 565.6940000000001,
"heapDeltaBytes": 1150652,
"heapUsedBytes": 92705632,
"domNodes": -210,
"jsHeapTotalBytes": 3211264,
"scriptDurationMs": 81.414,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.584000000044,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.480999999999998,
"layouts": 5,
"layoutDurationMs": 12.028000000000002,
"taskDurationMs": 814.7560000000001,
"heapDeltaBytes": 7112836,
"heapUsedBytes": 126086932,
"domNodes": 16030,
"jsHeapTotalBytes": 19275776,
"scriptDurationMs": 23.527000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 111,
"frameDurationMs": 18.77746478873239,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8326.971000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.938,
"layouts": 8,
"layoutDurationMs": 1.7460000000000002,
"taskDurationMs": 4669.084,
"heapDeltaBytes": -8632932,
"heapUsedBytes": 107754992,
"domNodes": -296,
"jsHeapTotalBytes": -380928,
"scriptDurationMs": 2040.4140000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699397590361443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8377.202000000012,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.128000000000004,
"layouts": 8,
"layoutDurationMs": 1.5839999999999999,
"taskDurationMs": 4783.158,
"heapDeltaBytes": 2587564,
"heapUsedBytes": 103822528,
"domNodes": -296,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 2230.137,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13817.629000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12787.727,
"heapDeltaBytes": -32050900,
"heapUsedBytes": 291983648,
"domNodes": -3344,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 184.34699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.070034843205573,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 18887.92000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18355.095,
"heapDeltaBytes": -31453036,
"heapUsedBytes": 292900048,
"domNodes": -3344,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 257.714,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.50017211703959,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 16487.94400000003,
"styleRecalcs": 103,
"styleRecalcDurationMs": 11.13,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16028.553000000002,
"heapDeltaBytes": -25841480,
"heapUsedBytes": 298175664,
"domNodes": -3344,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 684.187,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.02313296903461,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 22583.183000000077,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.874000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22216.43,
"heapDeltaBytes": -27372860,
"heapUsedBytes": 302381672,
"domNodes": -3344,
"jsHeapTotalBytes": 5423104,
"scriptDurationMs": 703.391,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 42.416917293233084,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 4977.926000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.706,
"layouts": 20,
"layoutDurationMs": 20.134,
"taskDurationMs": 4863.022000000001,
"heapDeltaBytes": -12885492,
"heapUsedBytes": 311981572,
"domNodes": -3344,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 75.902,
"eventListeners": -657,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.638505747126437,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4982.496999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.762,
"layouts": 20,
"layoutDurationMs": 20.143000000000008,
"taskDurationMs": 4865.394,
"heapDeltaBytes": -40996220,
"heapUsedBytes": 288302224,
"domNodes": -307,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 78.487,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.04327485380117,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7034.351000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6398.6269999999995,
"heapDeltaBytes": 19078356,
"heapUsedBytes": 305857864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.09299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.447386759581885,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9306.626999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9042.184,
"heapDeltaBytes": -14153364,
"heapUsedBytes": 280608608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.433,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.06758620689655,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 82.52499999997553,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.186,
"layouts": 5,
"layoutDurationMs": 1.671,
"taskDurationMs": 60.006,
"heapDeltaBytes": 4780396,
"heapUsedBytes": 95732384,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.423000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 443.6309999999821,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.572,
"layouts": 12,
"layoutDurationMs": 2.7990000000000004,
"taskDurationMs": 95.05199999999999,
"heapDeltaBytes": 6746912,
"heapUsedBytes": 104744600,
"domNodes": 95,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 7.672,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 281.9359999999733,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.558,
"layouts": 76,
"layoutDurationMs": 10.676,
"taskDurationMs": 233.061,
"heapDeltaBytes": 10157088,
"heapUsedBytes": 99051116,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 110.221,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658823529411755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 277.0590000000084,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5860000000000001,
"layouts": 76,
"layoutDurationMs": 11.267,
"taskDurationMs": 232.738,
"heapDeltaBytes": 10048240,
"heapUsedBytes": 98786104,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 109.76700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 378.9890000000469,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.821,
"layouts": 76,
"layoutDurationMs": 11.297,
"taskDurationMs": 340.514,
"heapDeltaBytes": -765620,
"heapUsedBytes": 119671904,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 129.59699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660869565217382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 306.60599999998794,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.512,
"layouts": 76,
"layoutDurationMs": 10.267,
"taskDurationMs": 268.916,
"heapDeltaBytes": -1546232,
"heapUsedBytes": 115523948,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.43499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736813,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2985 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 50b43953a9ac12581a1bfc1384a6713d50eb0aaf
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (138)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22496 +/- ##
=============================================
- Coverage 84.05% 84.05% -0.01%
=============================================
Files 3175 3175
Lines 166124 166148 +24
Branches 41837 39643 -2194
=============================================
+ Hits 139636 139653 +17
- Misses 26095 26102 +7
Partials 393 393
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22347 to the 1.58 train. Tour card arrow, and clicks on the dimmed screen or highlight now outline the card.
The automatic backport failed on one conflict in
OnboardingCoach.vue: this branch keepsv-reka-z-indexon the overlay (main uses thez-tourclass). The scrim test id and click handler come from #22347. Nothing else differs.