Repository navigation
test(agent): strengthen BE-23369 unresolved-output assertion - #22489
christian-byrne merged 1 commit into
Conversation
Drop the enable_telemetry flag the describe block no longer needs: the
BE-23369 case asserts the plain console diagnostic rather than
hostTelemetryFixture, logReport fires regardless of the flag, and the
flag was silently turning host telemetry on for the other two tests in
the describe.
Pin the expected console text to the error message, not just the
error-type substring, so the assertion can fail independently of the
page.on('console') collection filter. Verified with a temporary mutation
of the production error message: red under the mutation, green restored.
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T12:37:22.117Z",
"gitSha": "506f6a58cbfea8cf4820d7dde68ff5ec9b33dfe4",
"branch": "oploop1063-fe22382fu-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.5310000000009,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9799999999999995,
"layouts": 10,
"layoutDurationMs": 2.576,
"taskDurationMs": 557.313,
"heapDeltaBytes": 9767356,
"heapUsedBytes": 71028980,
"domNodes": -178,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.695000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2006.5159999999764,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.543,
"layouts": 10,
"layoutDurationMs": 2.307,
"taskDurationMs": 447.78000000000003,
"heapDeltaBytes": -13925848,
"heapUsedBytes": 62480972,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8.911000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.996999999983,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.436000000000003,
"layouts": 10,
"layoutDurationMs": 2.4250000000000007,
"taskDurationMs": 801.628,
"heapDeltaBytes": -23535324,
"heapUsedBytes": 54381556,
"domNodes": -178,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 129.698,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1684.3980000000442,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.193,
"layouts": 6,
"layoutDurationMs": 1.3620000000000003,
"taskDurationMs": 744.525,
"heapDeltaBytes": 259672,
"heapUsedBytes": 61771636,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 127.055,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673274,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.480999999988,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.14,
"layouts": 12,
"layoutDurationMs": 3.1009999999999995,
"taskDurationMs": 418.3450000000001,
"heapDeltaBytes": 1636152,
"heapUsedBytes": 62712400,
"domNodes": 57,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 14.822999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.054,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.654999999999999,
"layouts": 12,
"layoutDurationMs": 2.736,
"taskDurationMs": 342.951,
"heapDeltaBytes": 3827116,
"heapUsedBytes": 72310052,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 10.628,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.1460000000015,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1399999999999997,
"layouts": 10,
"layoutDurationMs": 2.658,
"taskDurationMs": 475.41600000000005,
"heapDeltaBytes": 6401760,
"heapUsedBytes": 83514304,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 154.657,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 566.9530000000123,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.85,
"layouts": 9,
"layoutDurationMs": 2.4240000000000004,
"taskDurationMs": 423.269,
"heapDeltaBytes": 3753132,
"heapUsedBytes": 65096480,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.613,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1083.2530000000133,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.549,
"heapDeltaBytes": -10852300,
"heapUsedBytes": 77798660,
"domNodes": -208,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 55.059999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 415,
"frameDurationMs": 30.088888888888896,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1003.0280000000289,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.194,
"heapDeltaBytes": 23715816,
"heapUsedBytes": 86217132,
"domNodes": 0,
"jsHeapTotalBytes": 10387456,
"scriptDurationMs": 50.82500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 365,
"frameDurationMs": 29.408823529411766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.3569999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.04599999999994,
"heapDeltaBytes": -3005824,
"heapUsedBytes": 73205144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.54099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 792.7210000000287,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.4770000000001,
"heapDeltaBytes": -3486076,
"heapUsedBytes": 73195616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.01499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8734.531000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5650000000000004,
"layouts": 2,
"layoutDurationMs": 0.5270000000000001,
"taskDurationMs": 7769.699000000001,
"heapDeltaBytes": 69709804,
"heapUsedBytes": 145757376,
"domNodes": -274,
"jsHeapTotalBytes": 76673024,
"scriptDurationMs": 6042.598,
"eventListeners": -68,
"totalBlockingTimeMs": 99,
"frameDurationMs": 24.191135734072024,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7922.321000000011,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.23699999999999938,
"layouts": 1,
"layoutDurationMs": 0.2149999999999999,
"taskDurationMs": 6992.101,
"heapDeltaBytes": 39259496,
"heapUsedBytes": 122811920,
"domNodes": -274,
"jsHeapTotalBytes": 58585088,
"scriptDurationMs": 5329.789,
"eventListeners": -68,
"totalBlockingTimeMs": 68,
"frameDurationMs": 23.701497005988024,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7983.394000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7177.607,
"heapDeltaBytes": 52437596,
"heapUsedBytes": 128771400,
"domNodes": -274,
"jsHeapTotalBytes": 60682240,
"scriptDurationMs": 5571.6320000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 191,
"frameDurationMs": 24.946875,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7997.4770000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7082.624,
"heapDeltaBytes": 61636308,
"heapUsedBytes": 135749412,
"domNodes": -274,
"jsHeapTotalBytes": 68022272,
"scriptDurationMs": 5441.755000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 50,
"frameDurationMs": 23.787537091988128,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 212.27799999999775,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.514000000000001,
"layouts": 11,
"layoutDurationMs": 2.7399999999999998,
"taskDurationMs": 165.12800000000001,
"heapDeltaBytes": 14804128,
"heapUsedBytes": 91059776,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 7.385999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 192.09799999998722,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.723999999999998,
"layouts": 10,
"layoutDurationMs": 2.544,
"taskDurationMs": 143.63799999999998,
"heapDeltaBytes": 14928568,
"heapUsedBytes": 75502132,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.839999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.924999999999955,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2026.724999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.725,
"layouts": 9,
"layoutDurationMs": 2.269,
"taskDurationMs": 600.536,
"heapDeltaBytes": 6941004,
"heapUsedBytes": 80927984,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.749,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.3850000000284,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2629999999999995,
"layouts": 8,
"layoutDurationMs": 1.905,
"taskDurationMs": 567.0059999999999,
"heapDeltaBytes": -17706032,
"heapUsedBytes": 75758564,
"domNodes": -274,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 35.213,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2966.048999999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.857999999999999,
"layouts": 9,
"layoutDurationMs": 2.393,
"taskDurationMs": 1527.8339999999998,
"heapDeltaBytes": 4857260,
"heapUsedBytes": 87924972,
"domNodes": -274,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 719.395,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2455.9279999999717,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.738,
"layouts": 8,
"layoutDurationMs": 1.739,
"taskDurationMs": 1379.901,
"heapDeltaBytes": -8959880,
"heapUsedBytes": 81483556,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 655.433,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3762.9909999999995,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.391,
"layouts": 65,
"layoutDurationMs": 10.687999999999999,
"taskDurationMs": 1588.4229999999998,
"heapDeltaBytes": 7925360,
"heapUsedBytes": 80590276,
"domNodes": -250,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 683.635,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3888.9789999999493,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.585999999999999,
"layouts": 64,
"layoutDurationMs": 10.068000000000001,
"taskDurationMs": 1564.611,
"heapDeltaBytes": 8952768,
"heapUsedBytes": 86147004,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 681.7800000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665665236051503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3023.471999999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.3660000000000005,
"layouts": 5,
"layoutDurationMs": 1.122,
"taskDurationMs": 1739.945,
"heapDeltaBytes": 23399928,
"heapUsedBytes": 95762568,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 842.22,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723756,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2487.302999999997,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.864999999999999,
"layouts": 6,
"layoutDurationMs": 1.46,
"taskDurationMs": 1634.948,
"heapDeltaBytes": -9988056,
"heapUsedBytes": 76545856,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 791.528,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77837837837838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2988.1049999999905,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.039,
"layouts": 7,
"layoutDurationMs": 1.803,
"taskDurationMs": 682.0360000000001,
"heapDeltaBytes": -844020,
"heapUsedBytes": 80869000,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 294.933,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3006.0020000000236,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0439999999999996,
"layouts": 8,
"layoutDurationMs": 1.6460000000000001,
"taskDurationMs": 679.4290000000001,
"heapDeltaBytes": -3576636,
"heapUsedBytes": 83875968,
"domNodes": -274,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 321.51800000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2073.0030000000284,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4219999999999997,
"layouts": 8,
"layoutDurationMs": 4.841,
"taskDurationMs": 633.4620000000001,
"heapDeltaBytes": -18921084,
"heapUsedBytes": 65474016,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 35.60600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.7110000000157,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8789999999999996,
"layouts": 8,
"layoutDurationMs": 1.737,
"taskDurationMs": 541.937,
"heapDeltaBytes": -5729884,
"heapUsedBytes": 83689276,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 29.805999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2860.0119999999833,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.956,
"layouts": 9,
"layoutDurationMs": 2.3949999999999996,
"taskDurationMs": 511.41800000000006,
"heapDeltaBytes": -18640416,
"heapUsedBytes": 73208828,
"domNodes": 19,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 163.76800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2773.2520000000136,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.324000000000002,
"layouts": 7,
"layoutDurationMs": 1.8760000000000001,
"taskDurationMs": 538.0460000000002,
"heapDeltaBytes": -9012688,
"heapUsedBytes": 75195608,
"domNodes": -264,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 164.717,
"eventListeners": -90,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3082.7729999999747,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1789999999999994,
"layouts": 8,
"layoutDurationMs": 1.8159999999999996,
"taskDurationMs": 773.9929999999999,
"heapDeltaBytes": -15879724,
"heapUsedBytes": 75082508,
"domNodes": 0,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 308.217,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3034.739000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7759999999999998,
"layouts": 9,
"layoutDurationMs": 1.7630000000000003,
"taskDurationMs": 736.42,
"heapDeltaBytes": -17682520,
"heapUsedBytes": 74526848,
"domNodes": 0,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 286.669,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.4420000000032,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.4590000000000005,
"layouts": 10,
"layoutDurationMs": 2.3870000000000005,
"taskDurationMs": 380.48499999999996,
"heapDeltaBytes": 24324820,
"heapUsedBytes": 86097088,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 127.59899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.0869999999572,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.549000000000001,
"layouts": 9,
"layoutDurationMs": 2.093,
"taskDurationMs": 364.84499999999997,
"heapDeltaBytes": 24404236,
"heapUsedBytes": 87077384,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 121.99000000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2035.4220000000112,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6550000000000002,
"layouts": 9,
"layoutDurationMs": 2.1659999999999995,
"taskDurationMs": 535.485,
"heapDeltaBytes": -3279048,
"heapUsedBytes": 58730388,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.895000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2075.601000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8840000000000003,
"layouts": 9,
"layoutDurationMs": 3.716,
"taskDurationMs": 540.8470000000001,
"heapDeltaBytes": -8376444,
"heapUsedBytes": 53421472,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.944000000000003,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0709999999992,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.911999999999999,
"layouts": 9,
"layoutDurationMs": 2.1539999999999995,
"taskDurationMs": 776.121,
"heapDeltaBytes": 7898996,
"heapUsedBytes": 68900512,
"domNodes": -192,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 97.43599999999999,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.6870000000072,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.731,
"layouts": 9,
"layoutDurationMs": 2.2550000000000003,
"taskDurationMs": 750.111,
"heapDeltaBytes": 14392884,
"heapUsedBytes": 77823880,
"domNodes": -200,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 94.692,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1352.228000000025,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.055999999999997,
"layouts": 5,
"layoutDurationMs": 10.793000000000001,
"taskDurationMs": 962.3830000000003,
"heapDeltaBytes": 11182536,
"heapUsedBytes": 87215420,
"domNodes": 15949,
"jsHeapTotalBytes": 13766656,
"scriptDurationMs": 28.76500000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 117,
"frameDurationMs": 18.98055555555556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11443.352000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.736,
"layouts": 9,
"layoutDurationMs": 2.036,
"taskDurationMs": 5321.975,
"heapDeltaBytes": -6042952,
"heapUsedBytes": 87197384,
"domNodes": -274,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2334.9669999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665938864628824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9045.567000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.298,
"layouts": 8,
"layoutDurationMs": 1.681,
"taskDurationMs": 4871.195,
"heapDeltaBytes": 377660,
"heapUsedBytes": 82314308,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2215.4410000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666298342541435,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19831.091000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19272.472,
"heapDeltaBytes": -36853144,
"heapUsedBytes": 262237980,
"domNodes": -3388,
"jsHeapTotalBytes": 14925824,
"scriptDurationMs": 268.608,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.190875912408764,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20274.336999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19293.695999999996,
"heapDeltaBytes": -17136720,
"heapUsedBytes": 268459512,
"domNodes": -3388,
"jsHeapTotalBytes": 14139392,
"scriptDurationMs": 296.403,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.24504347826087,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24248.924000000046,
"styleRecalcs": 179,
"styleRecalcDurationMs": 21.780000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23939.634,
"heapDeltaBytes": -31324328,
"heapUsedBytes": 267767308,
"domNodes": -3388,
"jsHeapTotalBytes": 13615104,
"scriptDurationMs": 855.6700000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 89,
"frameDurationMs": 46.188571428571436,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23950.42000000001,
"styleRecalcs": 180,
"styleRecalcDurationMs": 20.887000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23692.175,
"heapDeltaBytes": -17134748,
"heapUsedBytes": 277762216,
"domNodes": -3388,
"jsHeapTotalBytes": 19120128,
"scriptDurationMs": 764.2339999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 46.355319148936175,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7292.893999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.805,
"layouts": 20,
"layoutDurationMs": 28.678000000000008,
"taskDurationMs": 7191.968999999999,
"heapDeltaBytes": -29783276,
"heapUsedBytes": 249703276,
"domNodes": -3388,
"jsHeapTotalBytes": 16760832,
"scriptDurationMs": 127.168,
"eventListeners": -653,
"totalBlockingTimeMs": 2,
"frameDurationMs": 43.710778443113774,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7285.98599999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.432000000000016,
"layouts": 20,
"layoutDurationMs": 28.252,
"taskDurationMs": 7151.999999999999,
"heapDeltaBytes": -27554092,
"heapUsedBytes": 251708096,
"domNodes": -3388,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 106.61700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.93941176470588,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10113.866999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9806.301999999998,
"heapDeltaBytes": 14714568,
"heapUsedBytes": 273026040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.11700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.449280575539575,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9762.035999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9411.88,
"heapDeltaBytes": 10311584,
"heapUsedBytes": 269900176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.70699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.56116838487973,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 91.7919999999981,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.162,
"layouts": 7,
"layoutDurationMs": 1.853,
"taskDurationMs": 72.099,
"heapDeltaBytes": 4999280,
"heapUsedBytes": 65978448,
"domNodes": 101,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.2970000000000015,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 94.16799999996783,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.801000000000001,
"layouts": 8,
"layoutDurationMs": 1.9720000000000002,
"taskDurationMs": 63.376000000000005,
"heapDeltaBytes": 4850096,
"heapUsedBytes": 79194192,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.939000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 311.7540000000645,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.64,
"layouts": 76,
"layoutDurationMs": 11.906,
"taskDurationMs": 273.895,
"heapDeltaBytes": -5592520,
"heapUsedBytes": 37424800,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 128.96400000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 311.37999999998556,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5910000000000001,
"layouts": 76,
"layoutDurationMs": 12.057,
"taskDurationMs": 277.63,
"heapDeltaBytes": -5499584,
"heapUsedBytes": 38247388,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 130.00400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 352.9829999999947,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2569999999999997,
"layouts": 76,
"layoutDurationMs": 11.476999999999999,
"taskDurationMs": 311.49000000000007,
"heapDeltaBytes": -2087724,
"heapUsedBytes": 89268956,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.621,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 340.6559999999672,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2569999999999997,
"layouts": 76,
"layoutDurationMs": 11.975,
"taskDurationMs": 313.53600000000006,
"heapDeltaBytes": -1167444,
"heapUsedBytes": 97600184,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.946,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3191 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Telemetry setup and unresolved-output assertion browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts |
The suite no longer enables telemetry through test.use. The unresolved-output test checks each captured report for the specific “No live node resolves the executed output” error. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#22382: Adds the unresolved-output diagnostic and original Playwright coverage that this PR follows up on.
Suggested reviewers: dante01yoon
Merge Risk: 
Minimal · up to 7b0b7
-
No actionable merge-blocking risk is identified in this test-only change.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description provides a clear summary, explains the telemetry and assertion changes, documents the testing performed, and reports mutation-test results. It uses a "Testing" heading instead of the template's "Verification" heading, but it includes the required verification information.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The pull request changes only
browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts. It updates an existing Playwright spec and does not change application code undersrc/orpackages/. This check encourages, but does not require, an end-to-end test for user-facing changes.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed-file list contains only
browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts. It does not modifysrc/lib/litegraph/,src/ecs/, or a graph-entity implementation file. The ADR-LAYOUT and ADR-ECS checks do not apply.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22489 +/- ##
==========================================
- Coverage 87.53% 87.43% -0.10%
==========================================
Files 2983 2875 -108
Lines 162069 158693 -3376
Branches 43399 42229 -1170
==========================================
- Hits 141867 138758 -3109
+ Misses 19274 19175 -99
+ Partials 928 760 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. Dropping the describe-level telemetry flag is right: logReport in packages/telemetry/src/reportError.ts logs whether or not host telemetry is on. Pinning the message text makes the final assertion able to fail, and it matches src/stores/nodeOutputStore.ts:333. The E2E checks are green on every project, including mobile-safari, so how the console formats the Error argument holds across browsers. LGTM.
Summary
Promised test-only follow-up to #22382, addressing @dante01yoon's two non-blocking nits in
browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts:initialFeatureFlags: { enable_telemetry: true }. The BE-23369 case asserts the plainconsole.warndiagnostic, nothostTelemetryFixture;logReportinpackages/telemetry/src/reportError.tsruns regardless of that flag; and the flag was silently turning host telemetry on for the other two tests in the samedescribe.page.on('console')listener only pushes messages that already containfailure_resolving_node_output_execution_id, so the finaltoEqual(Array(3).fill(expect.stringContaining(...)))check was tautological once the count-of-3 poll passed — it could never catch a content regression. The assertion now pins the error's own message text (...Error: No live node resolves the executed output) in addition to the error type, which the collection filter does not already guarantee.Verified empirically that
reportUnresolvedExecutionId'stags.executionIdnever reaches the console text in this harness (Sentry/Datadog are not live in E2E, and the Desktop sink only forwards tags tohostTelemetryFixture's capture, not toconsole.warn) — only the error type and message appear. So "match the stale execution id" from the literal diagnostic text isn't reachable without a production change, which is out of scope here; pinning the message text is the strongest available non-tautological check.Testing
pnpm exec playwright test browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts --project=chromium --workers=1— 3 passed.src/stores/nodeOutputStore.tsfromNo live node resolves the executed outputtoExecution id could not be resolved to a node— the BE-23369 case failed on the new assertion (red) while the old assertion would have passed unchanged (samefailure_resolving_node_output_execution_idsubstring). Reverted; 3/3 green again.pnpm run typecheck:browser— passed.npx oxlint --type-aware/npx oxfmt --checkon the changed file — passed.