Repository navigation
[backport core/1.58] FE-3099 fix(auth): one sign-in notice per local SSO attempt, and recover the menu after a token outage - #22467
Conversation
…ver the menu after a token outage (#22388) QA on staging (stock core v0.43.0 + `core/1.58` head, Local SSO test plan) passed L4, L9, L10, L11a and L14 with the popup sign-in, but found two UI defects: 1. **Toasts:** a blocked popup shows three toasts at once; repeated clicks stack them; "Finish signing in in your browser" stays after a successful sign-in. 2. **L11b:** with `/oauth/token` unreachable and the token expired, the account menu shows no workspace, 0 credits and no switcher. Once the endpoint answers again the node runs, but the menu stays like that until a reload. 1. `SignInContent.signInWithDesktopHost` raises "Finish signing in in your browser" on a fixed 6 s timer and never clears it, then "Sign-in didn't finish" on any non-success. The local web session separately raises "Allow pop-ups for this page to sign in." for a blocked popup, so the two layers report the same failure twice. Each click awaits the same single-flight sign-in but raises its own toasts, so they stack. 2. During the outage `getWorkspaceToken` returns null. The workspace list request then fails, and `teamWorkspaceStore` ends in `initState: 'error'`. Nothing initializes it again: the host session never changes (same account, same tokens), so no watcher fires when tokens come back. Fixing that exposed a second gap: any session announcement bumped the session revision, which dropped the token read that was in flight at the time, so the run that triggered recovery would still have gone out without a token. - **One owner for local web sign-in notices.** `startLocalWebSession` takes `onSignInFailed` next to `onPopupBlocked`. `main.ts` shows both in one shared toast slot (one `ToastId`), and the session is started with `reportsSignInFailures: true`. `SignInContent` leaves notices to such a session. For Desktop, the button still reports failure, and now dismisses its "Finish signing in in your browser" toast when the sign-in ends. - **Recovery after an outage.** The local web bridge remembers that a token read came back empty while still signed in, and announces the session again on the next successful read. `teamWorkspaceStore` initializes again from `error` when the host session is announced. `desktopHostSession` no longer bumps its revision when the announcement is the same signed-in account and workspace, so in-flight token reads survive; a real change (sign-out, another account or workspace) still drops them. Desktop: no behavior change except the in-browser toast being dismissed on completion. The other changes only take effect when a session reports its own failures (local web) or when the same session is announced again. Tests: `SignInContent` (Desktop and self-reporting session, success and failure), `localWebSession` (blocked popup → one notice, session owns it), bridge (outage → no announcement, recovery → announcement), `desktopHostSession` (token read across a same-session announcement is kept; sign-out still drops), `teamWorkspaceStore` (re-initializes after a failed start). Each new test fails on `main`'s code. Browser (Playwright), this branch's dev server against a stand-in issuer (`/oauth/token` 503 mode, `/api/workspaces` requires auth), toast store and workspace store read from the running app: | Case | AS IS | TO BE | |---|---|---| | Popup blocked, 1 click | info "Finish signing in…", error "Allow pop-ups…", error "Sign-in didn't finish" | error "Allow pop-ups…" | | Popup blocked, 3 clicks | the same three ×3 (9 toasts) | error "Allow pop-ups…" | | Exchange refused, 3 clicks | 3× info + 3× error | error "Sign-in didn't finish" | | Successful sign-in | info "Finish signing in…" left over | none | | L11b: token endpoint down, then back | workspace store `error`, 0 workspaces, stays after the token is served again | back to `ready`, 3 workspaces; the triggering token read returns a token | **Popup blocked, 1 click** | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-asis-popup-blocked.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-tobe-popup-blocked.png" width="420"> | **Popup blocked, 3 clicks** | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-asis-popup-blocked-x3.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-tobe-popup-blocked-x3.png" width="420"> | **Exchange refused, 3 clicks** | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-asis-exchange-refused-x3.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-tobe-exchange-refused-x3.png" width="420"> | **Successful sign-in** | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-asis-success.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/toast-tobe-success.png" width="420"> | **L11b, account menu while `/oauth/token` is down** (both branches: workspace store `error`, menu shows no workspace) | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/l11b-menu-asis-outage.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/l11b-menu-tobe-outage.png" width="420"> | **L11b, account menu after `/oauth/token` answers again** (AS IS stays in `error`; TO BE is back to `ready` with the Personal switcher and Workspace settings) | AS IS | TO BE | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/l11b-menu-asis-recovered.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/7aa7ca17d1a20239df4b050793207f3c/raw/l11b-menu-tobe-recovered.png" width="420"> | - Fixes the QA findings in #proj-sso (L11b, sign-in toasts) (cherry picked from commit 9538554)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T06:26:50.922Z",
"gitSha": "1070d1907e9789dda39c4a69aeae9b5edeff9758",
"branch": "backport-22388-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.1099999998896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.93,
"layouts": 9,
"layoutDurationMs": 2.9259999999999997,
"taskDurationMs": 589.7170000000001,
"heapDeltaBytes": -5684,
"heapUsedBytes": 90381172,
"domNodes": -200,
"jsHeapTotalBytes": 1114112,
"scriptDurationMs": 11.397,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.838000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.085,
"layouts": 10,
"layoutDurationMs": 3.007,
"taskDurationMs": 447.94999999999993,
"heapDeltaBytes": 4073864,
"heapUsedBytes": 94419128,
"domNodes": -200,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 11.220999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.962999999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.820999999999998,
"layouts": 9,
"layoutDurationMs": 2.4599999999999995,
"taskDurationMs": 769.514,
"heapDeltaBytes": -2888056,
"heapUsedBytes": 97033388,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 150.02599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1977.9760000000124,
"styleRecalcs": 85,
"styleRecalcDurationMs": 14.964,
"layouts": 11,
"layoutDurationMs": 3.0869999999999997,
"taskDurationMs": 893.28,
"heapDeltaBytes": -2865176,
"heapUsedBytes": 97087844,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 141.796,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.376999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.904,
"layouts": 11,
"layoutDurationMs": 3.4589999999999996,
"taskDurationMs": 408.42699999999996,
"heapDeltaBytes": 25463520,
"heapUsedBytes": 115712080,
"domNodes": 47,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 13.441999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3419999999314,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.999999999999999,
"layouts": 12,
"layoutDurationMs": 2.9589999999999996,
"taskDurationMs": 313.246,
"heapDeltaBytes": -928084,
"heapUsedBytes": 99068740,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.796000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 745.4239999999572,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8140000000000005,
"layouts": 8,
"layoutDurationMs": 2.6249999999999996,
"taskDurationMs": 506.83900000000006,
"heapDeltaBytes": 3312884,
"heapUsedBytes": 93213636,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 170.32,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 699.7750000000451,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8190000000000004,
"layouts": 9,
"layoutDurationMs": 2.6339999999999995,
"taskDurationMs": 491.21400000000006,
"heapDeltaBytes": 4069544,
"heapUsedBytes": 103937116,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 159.414,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1199.226000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.1299999999999,
"heapDeltaBytes": -15497996,
"heapUsedBytes": 102145372,
"domNodes": -230,
"jsHeapTotalBytes": 13443072,
"scriptDurationMs": 56.88900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1203.3080000001064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 830.506,
"heapDeltaBytes": 9915076,
"heapUsedBytes": 128442640,
"domNodes": -150,
"jsHeapTotalBytes": 15695872,
"scriptDurationMs": 52.079,
"eventListeners": -168,
"totalBlockingTimeMs": 562,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.268999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.37500000000034,
"heapDeltaBytes": -3531976,
"heapUsedBytes": 98357892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.24499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 775.8949999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.801,
"heapDeltaBytes": -2760636,
"heapUsedBytes": 97793588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.73700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8948.476999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7989.88,
"heapDeltaBytes": 30802140,
"heapUsedBytes": 134005192,
"domNodes": -276,
"jsHeapTotalBytes": 32833536,
"scriptDurationMs": 6227.811,
"eventListeners": -130,
"totalBlockingTimeMs": 242,
"frameDurationMs": 27.604643962848296,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8671.335999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7731.3150000000005,
"heapDeltaBytes": 27304724,
"heapUsedBytes": 137344928,
"domNodes": -296,
"jsHeapTotalBytes": 35717120,
"scriptDurationMs": 6082.458,
"eventListeners": -130,
"totalBlockingTimeMs": 81,
"frameDurationMs": 26.998130841121494,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9541.26599999995,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3250000000000006,
"layouts": 1,
"layoutDurationMs": 0.20499999999999988,
"taskDurationMs": 8605.79,
"heapDeltaBytes": 49769688,
"heapUsedBytes": 153416876,
"domNodes": -276,
"jsHeapTotalBytes": 39649280,
"scriptDurationMs": 6551.206999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 196,
"frameDurationMs": 27.472622478386167,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8464.080000000082,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3309999999999997,
"layouts": 1,
"layoutDurationMs": 0.2590000000000001,
"taskDurationMs": 7573.888999999999,
"heapDeltaBytes": 10797532,
"heapUsedBytes": 125078340,
"domNodes": -276,
"jsHeapTotalBytes": 26095616,
"scriptDurationMs": 5921.357,
"eventListeners": -130,
"totalBlockingTimeMs": 102,
"frameDurationMs": 26.374766355140185,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 210.7540000000654,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.656999999999996,
"layouts": 11,
"layoutDurationMs": 3.855,
"taskDurationMs": 160.183,
"heapDeltaBytes": 13215496,
"heapUsedBytes": 120702224,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.907000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.659999999999947,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 198.77299999996012,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.829,
"layouts": 11,
"layoutDurationMs": 2.961,
"taskDurationMs": 146.401,
"heapDeltaBytes": 13140028,
"heapUsedBytes": 120700440,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.188,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2056.589000000031,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.566,
"layouts": 7,
"layoutDurationMs": 1.996,
"taskDurationMs": 696.818,
"heapDeltaBytes": 1433864,
"heapUsedBytes": 111720312,
"domNodes": -276,
"jsHeapTotalBytes": 65536,
"scriptDurationMs": 36.07999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.161999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4079999999999995,
"layouts": 8,
"layoutDurationMs": 2.19,
"taskDurationMs": 504.9960000000001,
"heapDeltaBytes": -659368,
"heapUsedBytes": 109813088,
"domNodes": -296,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 36.263,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2311.351000000059,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.288,
"layouts": 7,
"layoutDurationMs": 2.0610000000000004,
"taskDurationMs": 1570.5390000000002,
"heapDeltaBytes": 1939708,
"heapUsedBytes": 113639696,
"domNodes": -276,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 806.447,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786231884057973,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2291.3800000000037,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.142999999999999,
"layouts": 8,
"layoutDurationMs": 1.974,
"taskDurationMs": 1593.3590000000002,
"heapDeltaBytes": -17234832,
"heapUsedBytes": 88242456,
"domNodes": -296,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 746.717,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3608.3589999999504,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.610999999999997,
"layouts": 65,
"layoutDurationMs": 12.843,
"taskDurationMs": 1597.402,
"heapDeltaBytes": 7723448,
"heapUsedBytes": 121373768,
"domNodes": 24,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 765.1099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3617.4310000000105,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.916,
"layouts": 65,
"layoutDurationMs": 12.802,
"taskDurationMs": 1692.2400000000002,
"heapDeltaBytes": -957964,
"heapUsedBytes": 104038720,
"domNodes": -252,
"jsHeapTotalBytes": 14430208,
"scriptDurationMs": 735.587,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635944700461,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3126.386000000025,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.89,
"layouts": 4,
"layoutDurationMs": 1.161,
"taskDurationMs": 1965.03,
"heapDeltaBytes": 22062544,
"heapUsedBytes": 137493500,
"domNodes": 0,
"jsHeapTotalBytes": 8548352,
"scriptDurationMs": 933.5329999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.116756756756754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3066.802999999936,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.157000000000001,
"layouts": 5,
"layoutDurationMs": 1.2009999999999998,
"taskDurationMs": 1954.937,
"heapDeltaBytes": -1252672,
"heapUsedBytes": 120348452,
"domNodes": 0,
"jsHeapTotalBytes": 6750208,
"scriptDurationMs": 932.9240000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84945054945055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.6339999999736,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.411999999999999,
"layouts": 7,
"layoutDurationMs": 2.0559999999999996,
"taskDurationMs": 648.586,
"heapDeltaBytes": -23925864,
"heapUsedBytes": 99833524,
"domNodes": -296,
"jsHeapTotalBytes": -4276224,
"scriptDurationMs": 32.160000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.240999999811,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.144999999999999,
"layouts": 8,
"layoutDurationMs": 2.2620000000000005,
"taskDurationMs": 506.271,
"heapDeltaBytes": -30037392,
"heapUsedBytes": 89574040,
"domNodes": -296,
"jsHeapTotalBytes": -1470464,
"scriptDurationMs": 34.599000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.4680000000862,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.542,
"layouts": 9,
"layoutDurationMs": 2.5289999999999995,
"taskDurationMs": 380.378,
"heapDeltaBytes": -190156,
"heapUsedBytes": 91158748,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 137.753,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.6570000000156,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.816,
"layouts": 9,
"layoutDurationMs": 2.306,
"taskDurationMs": 376.526,
"heapDeltaBytes": -655600,
"heapUsedBytes": 90454300,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 141.466,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2057.119999999941,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0929999999999995,
"layouts": 9,
"layoutDurationMs": 2.9529999999999994,
"taskDurationMs": 599.209,
"heapDeltaBytes": 5822116,
"heapUsedBytes": 97524596,
"domNodes": -199,
"jsHeapTotalBytes": 327680,
"scriptDurationMs": 13.820000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.8219999999583,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.319,
"layouts": 9,
"layoutDurationMs": 2.1620000000000004,
"taskDurationMs": 428.842,
"heapDeltaBytes": 6256896,
"heapUsedBytes": 97558808,
"domNodes": -218,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 10.311999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.4790000000785,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.107,
"layouts": 10,
"layoutDurationMs": 2.969,
"taskDurationMs": 893.295,
"heapDeltaBytes": -6288648,
"heapUsedBytes": 95675952,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 111.204,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.3020000000424,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.969000000000001,
"layouts": 9,
"layoutDurationMs": 2.4650000000000003,
"taskDurationMs": 736.9859999999999,
"heapDeltaBytes": -484472,
"heapUsedBytes": 90904648,
"domNodes": -210,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 102.693,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.0260000000035,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.128999999999994,
"layouts": 5,
"layoutDurationMs": 12.543000000000003,
"taskDurationMs": 743.9039999999999,
"heapDeltaBytes": 35404388,
"heapUsedBytes": 138218540,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 27.327000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 156,
"frameDurationMs": 21.59090909090909,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8325.999000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.227000000000004,
"layouts": 8,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 5514.756,
"heapDeltaBytes": 4351660,
"heapUsedBytes": 114860940,
"domNodes": -276,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 2723.209,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73299798792757,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8425.706999999875,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.339,
"layouts": 7,
"layoutDurationMs": 1.768,
"taskDurationMs": 5986.402,
"heapDeltaBytes": 12818104,
"heapUsedBytes": 123132796,
"domNodes": -276,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 2736.182,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765936254980076,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19165.402000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18756.527,
"heapDeltaBytes": -30783616,
"heapUsedBytes": 273167592,
"domNodes": -3344,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 287.34700000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.874614065180104,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 18785.507999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18275.252,
"heapDeltaBytes": -46885580,
"heapUsedBytes": 272546780,
"domNodes": -3344,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 267.38,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.41241379310345,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23902.949999999917,
"styleRecalcs": 180,
"styleRecalcDurationMs": 25.075999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23574.483999999997,
"heapDeltaBytes": -22547796,
"heapUsedBytes": 302703780,
"domNodes": -3344,
"jsHeapTotalBytes": 8044544,
"scriptDurationMs": 870.554,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.40380228136882,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 17106.665000000023,
"styleRecalcs": 111,
"styleRecalcDurationMs": 17.02300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16645.77,
"heapDeltaBytes": -18602128,
"heapUsedBytes": 286724892,
"domNodes": -3344,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 810.6759999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 30.72890484739677,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 7031.386999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.41299999999999,
"layouts": 20,
"layoutDurationMs": 23.300999999999988,
"taskDurationMs": 6936.343,
"heapDeltaBytes": -13306144,
"heapUsedBytes": 292070132,
"domNodes": -3344,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 120.01299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.51179775280899,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5230.183000000125,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.62399999999998,
"layouts": 20,
"layoutDurationMs": 24.149000000000004,
"taskDurationMs": 5078.342,
"heapDeltaBytes": 120968,
"heapUsedBytes": 306047336,
"domNodes": -3344,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 101.635,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.979885057471265,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9308.88600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9051.437,
"heapDeltaBytes": 124380,
"heapUsedBytes": 270313052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.58999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.581016949152534,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6983.84400000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6534.05,
"heapDeltaBytes": 77536,
"heapUsedBytes": 261574212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.49100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.304861111111116,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 479.77400000002035,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.750000000000001,
"layouts": 11,
"layoutDurationMs": 3.7059999999999995,
"taskDurationMs": 121.02499999999999,
"heapDeltaBytes": 7015224,
"heapUsedBytes": 97081260,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.517999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 148.7769999998818,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.800999999999998,
"layouts": 10,
"layoutDurationMs": 4.1530000000000005,
"taskDurationMs": 121.63200000000002,
"heapDeltaBytes": -11944544,
"heapUsedBytes": 90195516,
"domNodes": 116,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 6.827000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 395.96400000004905,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.683,
"layouts": 76,
"layoutDurationMs": 14.992999999999999,
"taskDurationMs": 355.147,
"heapDeltaBytes": -15033776,
"heapUsedBytes": 79302068,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 160.668,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 430.8300000000145,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.732,
"layouts": 76,
"layoutDurationMs": 15.561,
"taskDurationMs": 390.305,
"heapDeltaBytes": -14553748,
"heapUsedBytes": 79442720,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 177.10099999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 388.53199999994104,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7329999999999999,
"layouts": 76,
"layoutDurationMs": 12.985999999999999,
"taskDurationMs": 352.59700000000004,
"heapDeltaBytes": -869540,
"heapUsedBytes": 116304020,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.09500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 504.7219999999015,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.771,
"layouts": 76,
"layoutDurationMs": 15.459,
"taskDurationMs": 461.63400000000007,
"heapDeltaBytes": 149700,
"heapUsedBytes": 130100460,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 176.60299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2986 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 32d8ae0a74820eab3f306b1aba9dc8cf80433e36
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (138)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22467 +/- ##
==========================================
Coverage 84.04% 84.04%
==========================================
Files 3175 3175
Lines 166025 166103 +78
Branches 39607 39629 +22
==========================================
+ Hits 139536 139606 +70
- Misses 26096 26104 +8
Partials 393 393
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #22388 to
core/1.58. The auto-backport hit a conflict insrc/main.ts.Why
QA (Denys, #proj-sso) runs the local SSO plan on
core/1.58head. The sign-in toast stacking and the L11b menu recovery fixes must be on that branch to be retested.Root cause of the conflict
On
main,startLocalAuthSessionis wrapped inbootstrapTracer.settle('startup/local-auth', …);core/1.58does not have that wrapper. The change itself is unrelated to the wrapper.How
Kept the
core/1.58shape ofstartLocalAuthSessionand applied only #22388's change there: onecreateToastId()slot shared byonPopupBlockedand the newonSignInFailed. Every other file cherry-picked cleanly.useToast().error(…, { id })already exists oncore/1.58.Verified: the 6 affected test files (247 tests) pass on this branch, and the pre-commit typecheck passes.
AS IS / TO BE
Same behavior as #22388; see the screenshots there.