Repository navigation
M4 feat(billing): show the served display plan balance on the Credits card - #22438
Conversation
The Credits card plan amount reads cloud_credit_display_balance_cents when the balance response serves it, and keeps cloud_credit_balance_cents unchanged when it is omitted. There is no client-side cap. The field already rides the generated balance schema and the SDK projection; this carries it into BalanceInfo on the workspace rail.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-31T00:28:23.150Z",
"gitSha": "65202f92d2351e7d78d204d04a5ffc529e43366c",
"branch": "dante/m4-display-plan-balance",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.5849999999787,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9989999999999999,
"layouts": 9,
"layoutDurationMs": 1.868,
"taskDurationMs": 458.2869999999999,
"heapDeltaBytes": -5788856,
"heapUsedBytes": 56516640,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7.718000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2007.5120000000197,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5470000000000006,
"layouts": 9,
"layoutDurationMs": 2.327,
"taskDurationMs": 430.743,
"heapDeltaBytes": 4934992,
"heapUsedBytes": 73237816,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.383,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.501000000022,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.36,
"layouts": 11,
"layoutDurationMs": 2.429,
"taskDurationMs": 719.629,
"heapDeltaBytes": -9336088,
"heapUsedBytes": 59102852,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 114.14600000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.897999999986,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.337000000000002,
"layouts": 9,
"layoutDurationMs": 2.169,
"taskDurationMs": 768.489,
"heapDeltaBytes": 128832,
"heapUsedBytes": 61607872,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 131.607,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.797999999988,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.354,
"layouts": 12,
"layoutDurationMs": 2.483,
"taskDurationMs": 335.31600000000003,
"heapDeltaBytes": -13358832,
"heapUsedBytes": 59735340,
"domNodes": 57,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 10.000000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.4689999999932,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.5040000000000004,
"layouts": 11,
"layoutDurationMs": 2.537,
"taskDurationMs": 388.555,
"heapDeltaBytes": 3704200,
"heapUsedBytes": 65863892,
"domNodes": 57,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 12.310999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 533.1669999999917,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3569999999999998,
"layouts": 10,
"layoutDurationMs": 2.424,
"taskDurationMs": 353.12100000000004,
"heapDeltaBytes": -16697064,
"heapUsedBytes": 60301008,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 134.79799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 551.3639999999782,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2849999999999997,
"layouts": 9,
"layoutDurationMs": 2.047,
"taskDurationMs": 408.977,
"heapDeltaBytes": 6484344,
"heapUsedBytes": 68028900,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 136.736,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.7460000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.0609999999999,
"heapDeltaBytes": 13892484,
"heapUsedBytes": 104353064,
"domNodes": -148,
"jsHeapTotalBytes": 24281088,
"scriptDurationMs": 45.794000000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 394,
"frameDurationMs": 29.522857142857134,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1069.1439999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.696,
"heapDeltaBytes": -4057624,
"heapUsedBytes": 78030516,
"domNodes": -208,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 51.56499999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 400,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 804.4049999999743,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.2159999999997,
"heapDeltaBytes": -29563104,
"heapUsedBytes": 63242332,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 118.563,
"eventListeners": -106,
"totalBlockingTimeMs": 157,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.2769999999791,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.8879999999999,
"heapDeltaBytes": -3457164,
"heapUsedBytes": 72563892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.24000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.041176470588226,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7622.730000000019,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.556,
"layouts": 2,
"layoutDurationMs": 0.4810000000000001,
"taskDurationMs": 6783.614,
"heapDeltaBytes": 65268384,
"heapUsedBytes": 141090372,
"domNodes": -273,
"jsHeapTotalBytes": 59371520,
"scriptDurationMs": 5202.468,
"eventListeners": -68,
"totalBlockingTimeMs": 91,
"frameDurationMs": 24.80912052117264,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7991.979000000015,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2199999999999997,
"layouts": 1,
"layoutDurationMs": 0.20199999999999993,
"taskDurationMs": 7163.085,
"heapDeltaBytes": 62321256,
"heapUsedBytes": 144627424,
"domNodes": -274,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 5618.7880000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 59,
"frameDurationMs": 24.04518072289157,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7787.5160000000105,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.1620000000000007,
"layouts": 1,
"layoutDurationMs": 0.1870000000000001,
"taskDurationMs": 6981.962,
"heapDeltaBytes": 52997228,
"heapUsedBytes": 129189716,
"domNodes": -274,
"jsHeapTotalBytes": 60944384,
"scriptDurationMs": 5477.837,
"eventListeners": -68,
"totalBlockingTimeMs": 109,
"frameDurationMs": 24.629746835443036,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7149.271999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8219999999999998,
"layouts": 3,
"layoutDurationMs": 0.67,
"taskDurationMs": 6392.219,
"heapDeltaBytes": 37574448,
"heapUsedBytes": 119544264,
"domNodes": -274,
"jsHeapTotalBytes": 54128640,
"scriptDurationMs": 4857.813,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 23.99228187919463,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 172.11299999999596,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.873000000000001,
"layouts": 11,
"layoutDurationMs": 2.6260000000000003,
"taskDurationMs": 126.72300000000003,
"heapDeltaBytes": 14819052,
"heapUsedBytes": 91232420,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.858000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 175.07999999997992,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.050999999999998,
"layouts": 10,
"layoutDurationMs": 2.431,
"taskDurationMs": 130.856,
"heapDeltaBytes": 14797892,
"heapUsedBytes": 91966712,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.9209999999999985,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.81428571428569,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2026.1930000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0359999999999996,
"layouts": 9,
"layoutDurationMs": 1.934,
"taskDurationMs": 526.2119999999999,
"heapDeltaBytes": -10132520,
"heapUsedBytes": 71165140,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.453,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.220000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3699999999999997,
"layouts": 9,
"layoutDurationMs": 2.027,
"taskDurationMs": 544.222,
"heapDeltaBytes": -19333200,
"heapUsedBytes": 62468972,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.315000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2271.4980000000082,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.536,
"layouts": 8,
"layoutDurationMs": 1.6600000000000001,
"taskDurationMs": 1401.0439999999999,
"heapDeltaBytes": -7077768,
"heapUsedBytes": 83595068,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 681.9399999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665441176470587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2320.873000000006,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.858,
"layouts": 8,
"layoutDurationMs": 1.8,
"taskDurationMs": 1380.686,
"heapDeltaBytes": -5685956,
"heapUsedBytes": 77196316,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 647.0200000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665467625899282,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3333.506,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.117,
"layouts": 65,
"layoutDurationMs": 9.812000000000001,
"taskDurationMs": 1414.637,
"heapDeltaBytes": 12800388,
"heapUsedBytes": 96906204,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 630.3559999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3848.122999999987,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.308000000000002,
"layouts": 66,
"layoutDurationMs": 10.408000000000001,
"taskDurationMs": 1588.0639999999996,
"heapDeltaBytes": -14195236,
"heapUsedBytes": 81695332,
"domNodes": 24,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 710.999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2381.6050000000077,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.085999999999999,
"layouts": 8,
"layoutDurationMs": 1.8259999999999998,
"taskDurationMs": 1587.554,
"heapDeltaBytes": -2782976,
"heapUsedBytes": 91383004,
"domNodes": 0,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 783.467,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549297,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2710.347000000013,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.352000000000001,
"layouts": 6,
"layoutDurationMs": 1.2959999999999998,
"taskDurationMs": 1618.6660000000002,
"heapDeltaBytes": -5399848,
"heapUsedBytes": 80342016,
"domNodes": 0,
"jsHeapTotalBytes": 5468160,
"scriptDurationMs": 784.428,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76894409937888,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2924.027999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.536,
"layouts": 7,
"layoutDurationMs": 1.374,
"taskDurationMs": 615.357,
"heapDeltaBytes": -10351752,
"heapUsedBytes": 74204760,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 273.98499999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2957.6339999999846,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8710000000000002,
"layouts": 8,
"layoutDurationMs": 1.7120000000000002,
"taskDurationMs": 608.011,
"heapDeltaBytes": -18834916,
"heapUsedBytes": 73128956,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 291.24100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2029.0379999999573,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6150000000000002,
"layouts": 7,
"layoutDurationMs": 1.492,
"taskDurationMs": 527.159,
"heapDeltaBytes": -4981072,
"heapUsedBytes": 68358032,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.464999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2034.7869999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3800000000000003,
"layouts": 8,
"layoutDurationMs": 2.1519999999999997,
"taskDurationMs": 623.5079999999999,
"heapDeltaBytes": -29007624,
"heapUsedBytes": 63100968,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 33.747,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2692.5019999999904,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.421,
"layouts": 7,
"layoutDurationMs": 1.664,
"taskDurationMs": 483.7870000000001,
"heapDeltaBytes": -6752024,
"heapUsedBytes": 65218400,
"domNodes": -259,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 159.11,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2676.159000000041,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.949,
"layouts": 8,
"layoutDurationMs": 1.762,
"taskDurationMs": 443.00100000000003,
"heapDeltaBytes": 8283364,
"heapUsedBytes": 91023736,
"domNodes": 19,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 147.90200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3037.908000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.778,
"layouts": 8,
"layoutDurationMs": 1.5369999999999997,
"taskDurationMs": 744.0740000000001,
"heapDeltaBytes": -2621008,
"heapUsedBytes": 69411628,
"domNodes": -274,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 282.129,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3059.902999999963,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5929999999999997,
"layouts": 7,
"layoutDurationMs": 1.373,
"taskDurationMs": 740.7530000000002,
"heapDeltaBytes": 10213300,
"heapUsedBytes": 94250832,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 299.23100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.2680000000491,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.651,
"layouts": 10,
"layoutDurationMs": 2.2039999999999997,
"taskDurationMs": 349.33,
"heapDeltaBytes": -1037908,
"heapUsedBytes": 60716376,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 118.06800000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.4350000000072,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.664000000000001,
"layouts": 9,
"layoutDurationMs": 2.0949999999999998,
"taskDurationMs": 367.94699999999995,
"heapDeltaBytes": 2948684,
"heapUsedBytes": 65184608,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 120.22200000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.8950000000195,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3109999999999995,
"layouts": 9,
"layoutDurationMs": 2.1729999999999996,
"taskDurationMs": 420.577,
"heapDeltaBytes": 4623816,
"heapUsedBytes": 65586624,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.878000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.3400000000047,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.784,
"layouts": 10,
"layoutDurationMs": 2.6439999999999997,
"taskDurationMs": 468.479,
"heapDeltaBytes": -6959248,
"heapUsedBytes": 55127724,
"domNodes": -200,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.755999999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2159999999783,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.465000000000002,
"layouts": 10,
"layoutDurationMs": 2.179,
"taskDurationMs": 697.0350000000001,
"heapDeltaBytes": -7497348,
"heapUsedBytes": 56877944,
"domNodes": -200,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 83.037,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6030000000528,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.189,
"layouts": 10,
"layoutDurationMs": 2.431,
"taskDurationMs": 682.9240000000001,
"heapDeltaBytes": 22872952,
"heapUsedBytes": 85283880,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 90.91099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.7680000000341,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.994000000000002,
"layouts": 5,
"layoutDurationMs": 10.075000000000001,
"taskDurationMs": 829.528,
"heapDeltaBytes": 10654896,
"heapUsedBytes": 113779660,
"domNodes": 15869,
"jsHeapTotalBytes": 10358784,
"scriptDurationMs": 25.514000000000003,
"eventListeners": 3246,
"totalBlockingTimeMs": 95,
"frameDurationMs": 18.77887323943662,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8375.97199999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.565000000000005,
"layouts": 9,
"layoutDurationMs": 2.042,
"taskDurationMs": 4717.8550000000005,
"heapDeltaBytes": -16567296,
"heapUsedBytes": 77401076,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2150.245,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600397614314,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "viewport-pan-sweep",
"durationMs": 10324.87500000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.366,
"layouts": 10,
"layoutDurationMs": 2.28,
"taskDurationMs": 5105.813,
"heapDeltaBytes": -18972580,
"heapUsedBytes": 74488464,
"domNodes": -274,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2280.8269999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19462.621999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18986.632,
"heapDeltaBytes": -21323236,
"heapUsedBytes": 277448712,
"domNodes": -3329,
"jsHeapTotalBytes": 15712256,
"scriptDurationMs": 240.21499999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.730714285714285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20316.276000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19510.561,
"heapDeltaBytes": 3600764,
"heapUsedBytes": 288539064,
"domNodes": -3329,
"jsHeapTotalBytes": 16236544,
"scriptDurationMs": 265.37899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.70741410488246,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23337.61400000003,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.901,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22903.551,
"heapDeltaBytes": -15049468,
"heapUsedBytes": 279616212,
"domNodes": -3329,
"jsHeapTotalBytes": 11517952,
"scriptDurationMs": 718.187,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.8578947368421,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23904.688999999962,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.47199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23622.326999999997,
"heapDeltaBytes": -9921768,
"heapUsedBytes": 274948908,
"domNodes": -3329,
"jsHeapTotalBytes": 10469376,
"scriptDurationMs": 735.805,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 46.34825581395349,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6929.64900000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.49199999999999,
"layouts": 20,
"layoutDurationMs": 19.512,
"taskDurationMs": 6826.544000000001,
"heapDeltaBytes": -32478408,
"heapUsedBytes": 262176644,
"domNodes": -3329,
"jsHeapTotalBytes": 22790144,
"scriptDurationMs": 103.257,
"eventListeners": -653,
"totalBlockingTimeMs": 8,
"frameDurationMs": 38.949438202247194,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 7183.505999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.992000000000004,
"layouts": 20,
"layoutDurationMs": 21.523,
"taskDurationMs": 7100.268,
"heapDeltaBytes": 7073804,
"heapUsedBytes": 287391988,
"domNodes": -3329,
"jsHeapTotalBytes": 23314432,
"scriptDurationMs": 112.00299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.35176470588235,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9752.67500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9505.602,
"heapDeltaBytes": -3330132,
"heapUsedBytes": 261395380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.84400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.944444444444436,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10044.316999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9788.798000000003,
"heapDeltaBytes": 4158452,
"heapUsedBytes": 284848232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.091,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.00845588235295,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 102.7920000000222,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.155,
"layouts": 7,
"layoutDurationMs": 1.8249999999999997,
"taskDurationMs": 73.31299999999999,
"heapDeltaBytes": 5001660,
"heapUsedBytes": 67051088,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.642000000000002,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 103.01400000003014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.196,
"layouts": 8,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 79.08500000000001,
"heapDeltaBytes": -12720072,
"heapUsedBytes": 60810300,
"domNodes": 132,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 5.471000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 303.4450000000106,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.642,
"layouts": 76,
"layoutDurationMs": 11.831,
"taskDurationMs": 259.965,
"heapDeltaBytes": -5916428,
"heapUsedBytes": 36994388,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 118.02199999999999,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 278.1039999999848,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.584,
"layouts": 76,
"layoutDurationMs": 11.844999999999999,
"taskDurationMs": 241.529,
"heapDeltaBytes": 10430260,
"heapUsedBytes": 52539288,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 108.4,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 363.0640000000085,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.327,
"layouts": 76,
"layoutDurationMs": 12.594,
"taskDurationMs": 332.452,
"heapDeltaBytes": -833552,
"heapUsedBytes": 96539728,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.07700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.422727272727283,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 364.2820000000029,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.439,
"layouts": 76,
"layoutDurationMs": 11.960999999999999,
"taskDurationMs": 329.49199999999996,
"heapDeltaBytes": -1851940,
"heapUsedBytes": 89384200,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.8,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3184 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d06ee9a6b863db54be3947a14ff0b5fec5808b45
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (295)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dante/m4-next-credit-refill #22438 +/- ##
============================================================
Coverage 87.47% 87.47%
============================================================
Files 2961 2961
Lines 161085 161089 +4
Branches 43121 43125 +4
============================================================
+ Hits 140907 140912 +5
+ Misses 19256 19255 -1
Partials 922 922
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The Credits card prefers the served display-only plan remainder and retains the prior plan-balance field only as the older-server fallback. The amount stays in the established cents contract.
…refill on the Credits card and out-of-credits banners (#22437) (#22833) ## Why The automatic backport of #22437 failed with cherry-pick conflicts: the merged change sits on the After-M4 billing SDK refactor #22746, which must not reach the 1.60 line. ## How - Rebuilt from the pre-SDK head of #22437, `8618e8cfa5` (pushed 2026-11-02T12:21Z, before the SDK rebuild force-push). It is not a descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main merge `dcb6476d28`, so the commit carries only the PR's own net change, which folds in #22438 (display plan balance) and #22453 (purchases-paused state). - Conflicts were with #22711 (refused Add credits reason), which is already on 1.60. They were resolved the way the merged #22437 resolved them on main. The paused top-up reason goes through the refused-reason path and uses the dated paused copy. The Credits card keeps 1.60's `AddCreditsButton` / `AddCreditsRefusalReason` and drops the pre-SDK `topUpPaused` prop. The `src/` files match the merged #22437 diff, except that `deriveCreditsCard` stays in 1.60's `src/platform/billing/components/billingTab/creditsCard.ts`. - No SDK code from #22746 or #22759 is included. Nothing under `packages/account-core/src/core/billing/billingTab` or `packages/account-ui` is touched. The only `packages/` edits are #22453's pre-SDK changes to files that already exist on 1.60: `capabilityDenials.ts` (decode `topup_purchases_paused`) and its tests. ## Verification On this branch: - `pnpm vitest run packages/account-core/src/core/billing src/platform/billing src/platform/workspace src/platform/account`: all pass - `pnpm typecheck:app`: pass - `pnpm fallow:audit --base origin/core/1.60`: exit 0 - `pnpm architecture:check`: exit 0 AS IS / TO BE: same behaviour as #22437; screenshots are in #22437. - Backport of #22437
… refill on the Credits card and out-of-credits banners (#22437) (#22834) ## Why The automatic backport of #22437 failed with cherry-pick conflicts: the merged change sits on the After-M4 billing SDK refactor #22746, which must not reach the 1.60 line. ## How - Rebuilt from the pre-SDK head of #22437, `8618e8cfa5` (pushed 2026-11-02T12:21Z, before the SDK rebuild force-push). It is not a descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main merge `dcb6476d28`, so the commit carries only the PR's own net change, which folds in #22438 (display plan balance) and #22453 (purchases-paused state). - Conflicts were with #22711 (refused Add credits reason), which is already on 1.60. They were resolved the way the merged #22437 resolved them on main. The paused top-up reason goes through the refused-reason path and uses the dated paused copy. The Credits card keeps 1.60's `AddCreditsButton` / `AddCreditsRefusalReason` and drops the pre-SDK `topUpPaused` prop. The `src/` files match the merged #22437 diff, except that `deriveCreditsCard` stays in 1.60's `src/platform/billing/components/billingTab/creditsCard.ts`. - No SDK code from #22746 or #22759 is included. Nothing under `packages/account-core/src/core/billing/billingTab` or `packages/account-ui` is touched. The only `packages/` edits are #22453's pre-SDK changes to files that already exist on 1.60: `capabilityDenials.ts` (decode `topup_purchases_paused`) and its tests. ## Verification On this branch: - `pnpm vitest run packages/account-core/src/core/billing src/platform/billing src/platform/workspace src/platform/account`: all pass - `pnpm typecheck:app`: pass - `pnpm fallow:audit --base origin/cloud/1.60`: exit 0 - `pnpm architecture:check`: exit 0 AS IS / TO BE: same behaviour as #22437; screenshots are in #22437. - Backport of #22437
… card and out-of-credits banners (Comfy-Org#22437) Depends on Comfy-Org#22350 (Credits card allowance) and Comfy-Org#22434 (ingest-types sync, cloud v0.521.1). Based on `dante/m4-credits-allowance` with `dante/m4-ingest-types-sync` merged in; retargets to `main` after both land. Until Comfy-Org#22434 lands, the diff against this base also shows the main commits that branch carries; the change itself is commit d06ee9a. Supersedes Comfy-Org#20497 (FRONT-3307), which worked out the refill window on the client from plan cadence. This PR keeps its copy and surfaces but drops the client math. ## Why BE-24556 serves `BillingStatusResponse.next_credit_refill_at`: the next eligible credit refill, the same value for the Credits card and the out-of-credits banner. The server decides eligibility (cadence, the 31-day window for annual grants, Enterprise invoices, cancellation). When it is omitted, the field description says to show no refill hint. Until now the card and banners read `renewal_date`, and Comfy-Org#22350 added an interim `plan_kind === 'self_serve'` gate. Both are client derivations that ADR-0042 rules out now that the fact is served. ## How - `next_credit_refill_at` is carried through both rails (`useWorkspaceBilling`, `useLegacyBilling`) into `useBillingContext().nextCreditRefillAt`, as received, `null` when omitted. - Credits card (`creditsCard.ts`): the `Refills {date}` line reads `nextCreditRefillAt`. When it is omitted there is no line. `servedPlanKind` and `renewalDate` are removed from `CreditsCardFacts`, which replaces Comfy-Org#22350's interim self_serve rule. - The paused `Refills when the payment goes through` line keeps its existing rule (plan row kind `paused`). The ending `Available until {date}` line is unchanged. - Cloud out-of-credits banner (`BillingStatusBanner.vue`) and local banner (`BillingLocalCreditBanner.vue`): the `…or wait until credits refill on {date}` clause uses the same served date, and the existing no-date bodies are used when it is omitted. This covers owner, member and personal. - No date math, no fallback to `renewal_date`, no combining it with plan kind or tier. `pnpm lint:server-facts --staged`: no findings. ## Design reference - Alex, #proj-billing (https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1793344068770879): "follow when credits actually refill". The same field drives both lines. - Wei: "omission means no eligible refill hint, with no renewal-date fallback". - Figma `C1fxz3akrW7Pl22zM2b301`: [2017-21360](https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/?node-id=2017-21360) (Plan x billing period, "Refills {date}") and [2052-32765](https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/?node-id=2052-32765) (banner matrix, Out of credits row). - No new copy. Existing strings only. ## AS IS / TO BE Taken in the running app with the real testcloud session in Ego Lite; listed API responses stubbed. AS IS = base `dante/m4-credits-allowance`, TO BE = this branch. Settings > Billing, Team workspace, dark theme, 1280px. Every state serves Pro monthly with `renewal_date` November 30 (`/api/billing/status`), `plan_kind: self_serve` (`/api/billing/capabilities`), and balance via `/api/billing/balance`. The Auto top-up card missing from TO BE comes from the main merge in this branch, not from this change. **Credits card: status merged with `next_credit_refill_at: 2026-11-28T00:00:00Z`** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-asis-refill-served.png" alt="AS IS Credits card: status merged with next_credit_refill_at: 2026-11-28T00:00:00Z" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-tobe-refill-served.png" alt="TO BE Credits card: status merged with next_credit_refill_at: 2026-11-28T00:00:00Z" width="420"> | **Credits card: `next_credit_refill_at` omitted** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-asis-refill-omitted.png" alt="AS IS Credits card: next_credit_refill_at omitted" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-tobe-refill-omitted.png" alt="TO BE Credits card: next_credit_refill_at omitted" width="420"> | **Out of credits: balance zeroed, `has_funds: false`, `next_credit_refill_at: 2026-11-28T00:00:00Z`** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-asis-ooc-refill-served.png" alt="AS IS Out of credits: balance zeroed, has_funds: false, next_credit_refill_at: 2026-11-28T00:00:00Z" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-tobe-ooc-refill-served.png" alt="TO BE Out of credits: balance zeroed, has_funds: false, next_credit_refill_at: 2026-11-28T00:00:00Z" width="420"> | **Out of credits: balance zeroed, `has_funds: false`, `next_credit_refill_at` omitted** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-asis-ooc-refill-omitted.png" alt="AS IS Out of credits: balance zeroed, has_funds: false, next_credit_refill_at omitted" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/83b897860ff719a2697c8a2b593f59bb29480d8f/22437-tobe-ooc-refill-omitted.png" alt="TO BE Out of credits: balance zeroed, has_funds: false, next_credit_refill_at omitted" width="420"> | The local out-of-credits banner (`BillingLocalCreditBanner`) is not shown: it needs a localhost build, which cannot use the real testcloud session. | | AS IS | TO BE | |---|---|---| | Credits card, self-serve plan | `Refills {renewal_date}` | `Refills {next_credit_refill_at}`, or no line when omitted | | Credits card, sales-managed plan | no line | `Refills {next_credit_refill_at}` when served, otherwise no line | | Out-of-credits banner (cloud and local) | `…wait until credits refill on {renewal_date}` | same clause with `next_credit_refill_at`, or the no-date body when omitted | | Paused plan | `Refills when the payment goes through` | unchanged | ## Tests `pnpm exec vitest run` on the touched files, table-driven with `it.for`, served and omitted cases: - `BillingCreditsCard.test.ts`: served date shows the line for active and sales-managed plans. Omitted shows no line. Paused still shows the after-payment line when a date is served. Ending is unchanged. - `BillingTab.test.ts`: the mounted tab shows the served refill date for self_serve and sales_managed, and no line when it is omitted, even with a served `renewal_date`. - `BillingStatusBanner.test.ts`, `BillingLocalCreditBanner.test.ts`: the clause follows the served date, and the no-date body is used when it is omitted, with `renewal_date` always served to prove there is no fallback. - `useBillingContext.test.ts`: both rails forward the field as served or as `null`. oxfmt, oxlint --type-aware, eslint and `typecheck:app` (pre-commit) are clean. ## Plan position | PR | Served field | | |---|---|---| | Comfy-Org#22434 | ingest-types sync (cloud v0.521.1) | base | | **this PR** | **`next_credit_refill_at` (BE-24556)** | **refill line and out-of-credits banner** | | Comfy-Org#22438 | `cloud_credit_display_balance_cents` (BE-24449) | Credits card plan amount, stacked on this PR | | Comfy-Org#22435 | served top-up minimum | Add credits min | | Comfy-Org#22436 | workspace creation facts | workspace list | ## After the SDK rebuild Rendered from the stack top (e6202d5), behaviour unchanged by the rebuild unless noted. | State | Render | | --- | --- | | `credits-plan` | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/b6a16e0bc3d5b6099a1bd2dd3074b3b3726bdf65/credits-plan.png"> | | `banner-out-of-credits-owner` | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/b6a16e0bc3d5b6099a1bd2dd3074b3b3726bdf65/banner-out-of-credits-owner.png"> | | `banner-out-of-credits-paused` | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/b6a16e0bc3d5b6099a1bd2dd3074b3b3726bdf65/banner-out-of-credits-paused.png"> | The paused banner uses the dated paused copy after merging with Comfy-Org#22711.
Stacked on #22437 (
dante/m4-next-credit-refill), which depends on #22350 and #22434. Retargets down the stack tomainafter they land. The change itself is commit 0f51dcb.Why
BE-24449 serves
BillingBalanceResponse.cloud_credit_display_balance_cents. The field description says it is the "display-only subscription remainder… capped at the known configured period_credit_grant", and "when omitted, display cloud_credit_balance_cents unchanged, without a client-side cap or zero substitution". The Credits card plan amount (planCents) read the rawcloud_credit_balance_*. After a downgrade, that could read above the plan grant ("1,266 of 1,000"). Capping on the client would be a derivation that ADR-0042 rules out. The server now does the cap.How
BillingBalanceSchemaextends the generatedzBillingBalanceResponse, which carries the field since chore(ingest-types): sync from cloud main for M4 billing follow-ups #22434, andprojectBillingBalance(billingBalanceView.ts) spreads unknown fields through. Neither needed a code change. Tests now pin both.BalanceInfo.cloudCreditDisplayBalanceCentsis mapped as received on the workspace rail (useWorkspaceBilling). The legacy/customers/balancerail does not serve the field, so it is absent there.creditsCard.ts:planCentsuses the served display value when present, otherwise today's servedcloudCreditBalanceMicros. No client cap and no zero substitution. The existing overdrawn and paused rules are unchanged.pnpm lint:server-facts --staged: no findings.Design reference
AS IS / TO BE
Taken in the running app with the real testcloud session in Ego Lite; listed API responses stubbed.
AS IS = base
dante/m4-next-credit-refill, TO BE = this branch. Settings > Billing, Credits card, Team workspace, dark theme./api/billing/statusserves Pro monthly with a 21,100 grant;/api/billing/balanceservescloud_credit_balance_cents: 2200(4,642 credits) andprepaid_balance_cents: 1000.Balance merged with
cloud_credit_display_balance_cents: 1000(2,110 credits), below the raw plan balancecloud_credit_display_balance_centsomitted1,266 of 1,000890 of 1,000(display as served)844 of 1,0000 of 1,000, top-up shown as In use nowTests
Table-driven with
it.for, served and omitted cases:BillingCreditsCard.test.ts: a served display value below raw, a served zero, and omitted for both a normal raw value and a raw value above the grant (no client cap).useWorkspaceBilling.test.ts: the field passes intoBalanceInfoas received.billingBalanceView.test.ts: the SDK projection carries the field when served and leaves it out when omitted.packages/account-core/.../credits.test.ts: the zod read keeps fractional, negative and omitted values as received.pnpm exec vitest runon the touched files passes. oxfmt, oxlint --type-aware, eslint andtypecheck:app(pre-commit) are clean.Plan position
next_credit_refill_at(BE-24556)cloud_credit_display_balance_cents(BE-24449)