Repository navigation
[backport core/1.59] fix(agent): keep a signed-out consent accept across a sign-in reload (#21658) - #22422
Conversation
…oss a sign-in reload (#21658) Desktop's Google and GitHub sign-in reloads the page. A signed-out user who clicked Agree on the Agent consent card lost the agreement and their message, and the card asked again. This keeps a short-lived record across the reload. Adapted for core/1.59, which does not have the shared Cloud and Desktop onboarding policy from #21933: the resume runs ahead of the existing introduceBeforeSignIn gate, and the sessionEnded check stays out because the branch has no such helper. The redirect-only local web bridge tests are dropped because core/1.59 signs in through a popup. (cherry picked from commit 1ce8cbc)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T23:30:30.125Z",
"gitSha": "310c9acf74c4a04c29e2cd33bb780aa667ce608a",
"branch": "backport-21658-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.30200000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.973,
"layouts": 9,
"layoutDurationMs": 2.9199999999999995,
"taskDurationMs": 578.4730000000001,
"heapDeltaBytes": 3058556,
"heapUsedBytes": 64755628,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 12.358999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2024.8470000000225,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1719999999999993,
"layouts": 10,
"layoutDurationMs": 3.1080000000000005,
"taskDurationMs": 571.6519999999999,
"heapDeltaBytes": 4921108,
"heapUsedBytes": 75151620,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.683,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.6969999999774,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.898,
"layouts": 9,
"layoutDurationMs": 2.7670000000000003,
"taskDurationMs": 938.4549999999999,
"heapDeltaBytes": 21776280,
"heapUsedBytes": 82641116,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 172.483,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.2349999999387,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.330000000000002,
"layouts": 9,
"layoutDurationMs": 2.9170000000000003,
"taskDurationMs": 944.038,
"heapDeltaBytes": 21767392,
"heapUsedBytes": 83190768,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.837,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.671000000019,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.5630000000000015,
"layouts": 10,
"layoutDurationMs": 3.361,
"taskDurationMs": 453.498,
"heapDeltaBytes": 694400,
"heapUsedBytes": 70064560,
"domNodes": 56,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 14.354,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.332999999996,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.118,
"layouts": 10,
"layoutDurationMs": 2.89,
"taskDurationMs": 425.63400000000007,
"heapDeltaBytes": -1486784,
"heapUsedBytes": 60278696,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 13.543,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.7029999999822,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0019999999999993,
"layouts": 9,
"layoutDurationMs": 2.842,
"taskDurationMs": 537.135,
"heapDeltaBytes": 3328764,
"heapUsedBytes": 64638076,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 757.9990000000407,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0959999999999996,
"layouts": 9,
"layoutDurationMs": 2.872,
"taskDurationMs": 519.707,
"heapDeltaBytes": 6450720,
"heapUsedBytes": 77228808,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 175.85099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.0660000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 967.9620000000001,
"heapDeltaBytes": -1471160,
"heapUsedBytes": 75539096,
"domNodes": -191,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 72.198,
"eventListeners": -106,
"totalBlockingTimeMs": 549,
"frameDurationMs": 33.33243243243243,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.9649999999074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 946.734,
"heapDeltaBytes": -13982132,
"heapUsedBytes": 75436412,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 69.937,
"eventListeners": -106,
"totalBlockingTimeMs": 532,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 924.4009999999889,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.3969999999996,
"heapDeltaBytes": -28413104,
"heapUsedBytes": 66421476,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 181.388,
"eventListeners": -106,
"totalBlockingTimeMs": 236,
"frameDurationMs": 24.772972972972983,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 933.8979999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.8129999999999,
"heapDeltaBytes": -26699716,
"heapUsedBytes": 66981140,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 178.40499999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 228,
"frameDurationMs": 24.560526315789456,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11802.27099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10924.467,
"heapDeltaBytes": 72874444,
"heapUsedBytes": 147159244,
"domNodes": -257,
"jsHeapTotalBytes": 81915904,
"scriptDurationMs": 8814.939,
"eventListeners": -68,
"totalBlockingTimeMs": 1564,
"frameDurationMs": 32.284699453551916,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10637.659999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9835.205,
"heapDeltaBytes": 72898968,
"heapUsedBytes": 147817472,
"domNodes": -257,
"jsHeapTotalBytes": 68808704,
"scriptDurationMs": 7865.097000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 974,
"frameDurationMs": 31.273235294117647,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11380.308999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10585.742000000002,
"heapDeltaBytes": -17433952,
"heapUsedBytes": 71861292,
"domNodes": -257,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 8645.784,
"eventListeners": -68,
"totalBlockingTimeMs": 1679,
"frameDurationMs": 31.9747191011236,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11572.129000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10770.823999999999,
"heapDeltaBytes": 73057136,
"heapUsedBytes": 156437132,
"domNodes": -257,
"jsHeapTotalBytes": 79556608,
"scriptDurationMs": 8733.957,
"eventListeners": -68,
"totalBlockingTimeMs": 1626,
"frameDurationMs": 32.35446927374302,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 257.78600000001006,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.433,
"layouts": 10,
"layoutDurationMs": 3.1949999999999994,
"taskDurationMs": 220.98999999999998,
"heapDeltaBytes": -14211128,
"heapUsedBytes": 68840240,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.456999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 9,
"frameDurationMs": 22.73636363636359,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 284.13499999999203,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.446999999999997,
"layouts": 11,
"layoutDurationMs": 4.034000000000001,
"taskDurationMs": 239.76,
"heapDeltaBytes": 2945672,
"heapUsedBytes": 71155616,
"domNodes": 721,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 10.346,
"eventListeners": 73,
"totalBlockingTimeMs": 8,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2056.490999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.463999999999999,
"layouts": 8,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 696.754,
"heapDeltaBytes": -27420932,
"heapUsedBytes": 63700020,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 35.879,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.9929999999913,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.261,
"layouts": 7,
"layoutDurationMs": 1.935,
"taskDurationMs": 688.474,
"heapDeltaBytes": -11270200,
"heapUsedBytes": 62889796,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.558,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2748.019999999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.583,
"layouts": 6,
"layoutDurationMs": 1.6189999999999998,
"taskDurationMs": 1795.1770000000001,
"heapDeltaBytes": 6044052,
"heapUsedBytes": 80812836,
"domNodes": -257,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 857.495,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767682926829266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2650.03999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.61,
"layouts": 7,
"layoutDurationMs": 1.9969999999999997,
"taskDurationMs": 1743.3200000000002,
"heapDeltaBytes": -15874388,
"heapUsedBytes": 60826572,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 834.5830000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3819.029999999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.147,
"layouts": 65,
"layoutDurationMs": 11.411,
"taskDurationMs": 1841.077,
"heapDeltaBytes": 8268700,
"heapUsedBytes": 85299460,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 812.75,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666228070175436,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3903.6820000000034,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.770000000000001,
"layouts": 64,
"layoutDurationMs": 10.642000000000001,
"taskDurationMs": 1871.246,
"heapDeltaBytes": 6609484,
"heapUsedBytes": 84198696,
"domNodes": -233,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 807.136,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666239316239313,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3211.5969999999834,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.207,
"layouts": 4,
"layoutDurationMs": 1.2459999999999998,
"taskDurationMs": 2097.5190000000002,
"heapDeltaBytes": -4050808,
"heapUsedBytes": 76568912,
"domNodes": 0,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 996.2800000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.92842105263158,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3247.3400000000083,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.6000000000000005,
"layouts": 5,
"layoutDurationMs": 1.373,
"taskDurationMs": 2113.0860000000002,
"heapDeltaBytes": -4027728,
"heapUsedBytes": 78188204,
"domNodes": -257,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1027.1180000000002,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.840104166666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3140.016000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.823,
"layouts": 7,
"layoutDurationMs": 1.8560000000000005,
"taskDurationMs": 823.54,
"heapDeltaBytes": 12061720,
"heapUsedBytes": 88194920,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 390.082,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66648936170213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3141.3560000000302,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3750000000000004,
"layouts": 8,
"layoutDurationMs": 2.5769999999999995,
"taskDurationMs": 860.4659999999999,
"heapDeltaBytes": -31842716,
"heapUsedBytes": 61791640,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 394.887,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542553191489,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.3049999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.603,
"layouts": 8,
"layoutDurationMs": 2.2459999999999996,
"taskDurationMs": 702.0939999999999,
"heapDeltaBytes": -29087736,
"heapUsedBytes": 63448200,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 39.687999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.7470000000058,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5949999999999993,
"layouts": 7,
"layoutDurationMs": 2.5260000000000007,
"taskDurationMs": 699.018,
"heapDeltaBytes": -10591396,
"heapUsedBytes": 66188904,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.12,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2705.777000000012,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.64,
"layouts": 8,
"layoutDurationMs": 2.5090000000000003,
"taskDurationMs": 640.0949999999999,
"heapDeltaBytes": -19227732,
"heapUsedBytes": 61517252,
"domNodes": -243,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 204.498,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2903.019000000029,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.849,
"layouts": 7,
"layoutDurationMs": 1.9460000000000002,
"taskDurationMs": 662.027,
"heapDeltaBytes": 3767396,
"heapUsedBytes": 81449292,
"domNodes": -251,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 206.53299999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379312,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3343.0229999999883,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.497,
"layouts": 5,
"layoutDurationMs": 1.4069999999999998,
"taskDurationMs": 1010.4029999999999,
"heapDeltaBytes": 237140,
"heapUsedBytes": 77275548,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 397.898,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7495,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3352.9490000000806,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5250000000000004,
"layouts": 5,
"layoutDurationMs": 1.582,
"taskDurationMs": 1017.2560000000002,
"heapDeltaBytes": -3809052,
"heapUsedBytes": 75485020,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 385.77,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749499999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.5080000000025,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.986000000000001,
"layouts": 8,
"layoutDurationMs": 2.225,
"taskDurationMs": 453.573,
"heapDeltaBytes": -2059480,
"heapUsedBytes": 60611384,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 146.297,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 672.723000000019,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.846,
"layouts": 8,
"layoutDurationMs": 2.1660000000000004,
"taskDurationMs": 460.99999999999994,
"heapDeltaBytes": -113160,
"heapUsedBytes": 62344708,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 149.072,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.437999999981,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.785,
"layouts": 9,
"layoutDurationMs": 2.5610000000000004,
"taskDurationMs": 559.624,
"heapDeltaBytes": 3999020,
"heapUsedBytes": 65858764,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 11.664000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2023.967999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6499999999999995,
"layouts": 8,
"layoutDurationMs": 2.645,
"taskDurationMs": 577.6170000000001,
"heapDeltaBytes": 2069648,
"heapUsedBytes": 64751492,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.807000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0060000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.967999999999998,
"layouts": 10,
"layoutDurationMs": 2.565,
"taskDurationMs": 871.671,
"heapDeltaBytes": 18213836,
"heapUsedBytes": 80338120,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 115.831,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.0090000000237,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.267000000000001,
"layouts": 9,
"layoutDurationMs": 2.5640000000000005,
"taskDurationMs": 892.3310000000001,
"heapDeltaBytes": -5759492,
"heapUsedBytes": 66058476,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 117.02199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1502.5460000000521,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.377999999999997,
"layouts": 5,
"layoutDurationMs": 15.110999999999995,
"taskDurationMs": 1205.145,
"heapDeltaBytes": 37985808,
"heapUsedBytes": 113769748,
"domNodes": 16030,
"jsHeapTotalBytes": 7999488,
"scriptDurationMs": 34.336,
"eventListeners": 3246,
"totalBlockingTimeMs": 198,
"frameDurationMs": 20,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10174.599999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.849999999999998,
"layouts": 8,
"layoutDurationMs": 2.057,
"taskDurationMs": 6271.594999999999,
"heapDeltaBytes": 2147652,
"heapUsedBytes": 76663328,
"domNodes": -257,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2808.9649999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69326765188834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10535.67899999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.537,
"layouts": 8,
"layoutDurationMs": 2.036,
"taskDurationMs": 6326.621,
"heapDeltaBytes": 1362300,
"heapUsedBytes": 80010664,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2842.797,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598101265823,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 24149.065000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23502.693,
"heapDeltaBytes": -34886940,
"heapUsedBytes": 256402692,
"domNodes": -3343,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 337.404,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.35547576301616,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23549.270999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23075.683,
"heapDeltaBytes": -20459484,
"heapUsedBytes": 256381012,
"domNodes": -3343,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 317.502,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.14055944055944,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28717.01200000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.124000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28307.851,
"heapDeltaBytes": -19991744,
"heapUsedBytes": 262365352,
"domNodes": -3343,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 921.198,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.774344569288395,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28340.347000000067,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.57400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27963.517999999996,
"heapDeltaBytes": -37690684,
"heapUsedBytes": 263252532,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 887.207,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 52.957383177570094,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8491.244999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.522,
"layouts": 20,
"layoutDurationMs": 29.036999999999992,
"taskDurationMs": 8388.716,
"heapDeltaBytes": -50099120,
"heapUsedBytes": 251950444,
"domNodes": -3343,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 130.184,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.48435754189944,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8529.671000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.854,
"layouts": 20,
"layoutDurationMs": 22.302000000000003,
"taskDurationMs": 8394.787999999999,
"heapDeltaBytes": -25314788,
"heapUsedBytes": 256252656,
"domNodes": -307,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 155.70499999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.2271676300578,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11579.738999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11366.133999999998,
"heapDeltaBytes": 10253644,
"heapUsedBytes": 272095440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.67399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.499650349650345,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11623.869000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11385.427999999998,
"heapDeltaBytes": -15902676,
"heapUsedBytes": 259961332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.53240418118467,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 128.41600000001563,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.517999999999999,
"layouts": 7,
"layoutDurationMs": 4.933999999999999,
"taskDurationMs": 96.666,
"heapDeltaBytes": 4814120,
"heapUsedBytes": 64821468,
"domNodes": 105,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.096,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 150.78600000003917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.597999999999999,
"layouts": 9,
"layoutDurationMs": 4.337000000000001,
"taskDurationMs": 99.639,
"heapDeltaBytes": 4639648,
"heapUsedBytes": 72185444,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.499999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 547.0470000000205,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.661,
"layouts": 76,
"layoutDurationMs": 16.795,
"taskDurationMs": 501.8589999999999,
"heapDeltaBytes": -3916136,
"heapUsedBytes": 40963296,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 240.564,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 599.48200000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.671,
"layouts": 76,
"layoutDurationMs": 17.007,
"taskDurationMs": 556.0169999999999,
"heapDeltaBytes": -3134216,
"heapUsedBytes": 40700416,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 279.8310000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 581.4179999999851,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.866,
"layouts": 76,
"layoutDurationMs": 16.019,
"taskDurationMs": 549.228,
"heapDeltaBytes": 971024,
"heapUsedBytes": 103740016,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 220.87599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 660.1239999999962,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9559999999999997,
"layouts": 76,
"layoutDurationMs": 16.468,
"taskDurationMs": 628.953,
"heapDeltaBytes": 1752876,
"heapUsedBytes": 92293780,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 260.315,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3132 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fb1d1ff7e08b462cbd1f0122a09c7d5d28ac16a3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (229)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.59 #22422 +/- ##
=============================================
- Coverage 87.14% 87.13% -0.01%
=============================================
Files 3027 3028 +1
Lines 158723 158798 +75
Branches 42343 40202 -2141
=============================================
+ Hits 138313 138376 +63
- Misses 19735 19747 +12
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@dante01yoon one small commit landed after your approval: 7ded2c6 moves the resume check into a helper to clear the fallow complexity gate, with no behavior change. Could you re-approve at this head? Independent review of the adaptation found no defects. Base is 1 commit behind core/1.59: the new commit is the source of the backport below, with no file overlap if the gate confirms it. |
|
Merge record: auto-merge landed this at 7ded2c6 on Oct 30. The approval was on fa572d5; the one later commit only moves the resume check into a helper. The base was 1 commit behind core/1.59 (8a96c85), and check-merge-ready.sh measured zero file overlap with that delta. Required checks were green at this head. |
|
Follow-up for the stale-approval merge noted above: #22569 makes the backport sweep merge only when an approval is on the current head. Separately, the Desktop rollout will run the main-based build 1.60.0.dev1, which has the original #21658, so this core/1.59 copy reaches users only through a core/1.59 release. |
## Summary The backport sweep used `reviewDecision == APPROVED`, but release-branch protection can preserve that decision after the head changes. On Oct 30 the sweep merged #22422 with its only approval one commit behind the merged head. ## Changes - Require the latest non-comment review from a write-capable reviewer to approve the current head. - Pin each merge attempt with `--match-head-commit`. - Fail closed and report review or permission lookup errors. - Merge only the currently authorized frontend trains: `core/1.56` through `core/1.59` and `cloud/1.56` through `cloud/1.59`. Retired 1.54/1.55 and unknown future trains are rejected until the allowlist is deliberately updated. ## Tests `NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run scripts/cicd/backport-auto-merge.test.ts` The 23 cases cover all eight authorized bases, retired and unknown bases, stale/current/dismissed/comment-only reviews, insufficient reviewer permission, API failures, pagination behavior, and head-pinned merge arguments. ## Review focus Version-bump PRs with the `Release` label follow the same exact-head and active-train rules.
Backport of #21658 to core/1.59. Decision on https://linear.app/comfyorg/issue/FRONT-3672: this fix goes to core/1.59; the onboarding change #21933 rides 1.60.
Why now: Desktop's Google and GitHub sign-in reloads the page, so a signed-out user who clicks Agree loses the agreement and their message, and the card asks again. In production on the Desktop rollout build, about 3,800 of about 8,000 people who agreed while signed out saw the consent card again within the hour (PostHog, Oct 23 to 30). It needs to be on the branch before the next 1.59 wheel.
Conflicts, all because 21933 is absent here:
agentPanel.ts: core/1.59 still has theintroduceBeforeSignIngate, so Cloud does not wait on auth before this function continues. The resume check runs first and only once auth is initialized. Cloud has no record to resume, so its path is unchanged. ThesessionEndedguard stays out; core/1.59 has no such helper.agentPanel.test.ts: uses the source's spied module, and the mock keeps callingonShown, which the 1.59 tests rely on.useAgentConsent.ts: keeps both sets of imports and stores.localWebAuthBridge.test.ts: source tests dropped. They cover the redirect flow, and core/1.59 signs in through a popup.Verified locally:
agentPanel,useAgentConsent,localWebAuthBridgeandWorkflowTabsunit tests pass, plus app typecheck.