Repository navigation
chore: remove unused getRestoredWidgetValueCount - #22418
Conversation
Its only caller, the saved row ceiling, is gone, and it counted retained DynamicGroup keys as rows (multi-player ADR-039 flagged that for audit).
📦 Bundle: 12 MB gzip 🟢 -141 BDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.61 MB (baseline 2.61 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 9 unchanged Panels & Settings — 878 kB (baseline 878 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed / 29 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 11 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 10 added / 10 removed / 7 unchanged UI Components — 352 kB (baseline 352 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 24 unchanged Data & Services — 1.93 MB (baseline 1.93 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 20 added / 20 removed / 22 unchanged Utilities & Hooks — 2.46 MB (baseline 2.46 MB) • 🟢 -320 BHelpers, composables, and utility bundles
Status: 31 added / 31 removed / 52 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 82 added / 82 removed / 669 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T22:36:47.775Z",
"gitSha": "3101a6422e388936f4542e6511310b7950ad95f0",
"branch": "chore/drop-unused-restored-count",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.5429999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2849999999999997,
"layouts": 8,
"layoutDurationMs": 2.058,
"taskDurationMs": 580.6600000000001,
"heapDeltaBytes": -1640416,
"heapUsedBytes": 59551740,
"domNodes": -178,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.709000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.1930000000448,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9530000000000007,
"layouts": 9,
"layoutDurationMs": 2.8270000000000004,
"taskDurationMs": 579.889,
"heapDeltaBytes": -4744748,
"heapUsedBytes": 55988796,
"domNodes": -178,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.784,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.032000000009,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.153,
"layouts": 9,
"layoutDurationMs": 2.5020000000000002,
"taskDurationMs": 779.2020000000001,
"heapDeltaBytes": 993852,
"heapUsedBytes": 73833876,
"domNodes": -178,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 159.17700000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.2419999999947,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.969000000000003,
"layouts": 9,
"layoutDurationMs": 2.536,
"taskDurationMs": 944.7549999999999,
"heapDeltaBytes": 7990996,
"heapUsedBytes": 68950548,
"domNodes": -178,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 163.131,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864867,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.6350000000198,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.175,
"layouts": 11,
"layoutDurationMs": 2.83,
"taskDurationMs": 412.631,
"heapDeltaBytes": 25316528,
"heapUsedBytes": 86472312,
"domNodes": 57,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.270999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9909999999927,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.999,
"layouts": 11,
"layoutDurationMs": 2.8169999999999997,
"taskDurationMs": 424.706,
"heapDeltaBytes": 8212840,
"heapUsedBytes": 83761700,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.149000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 698.853999999983,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.75,
"layouts": 9,
"layoutDurationMs": 2.511,
"taskDurationMs": 508.39,
"heapDeltaBytes": -16475180,
"heapUsedBytes": 60181224,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 169.84199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 646.6929999999138,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.5640000000000005,
"layouts": 9,
"layoutDurationMs": 2.2830000000000004,
"taskDurationMs": 490.27700000000004,
"heapDeltaBytes": 6932528,
"heapUsedBytes": 67485188,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 171.737,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.8489999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.112,
"heapDeltaBytes": -7724164,
"heapUsedBytes": 79830912,
"domNodes": -208,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 74.25000000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 528,
"frameDurationMs": 33.80857142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.8370000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.378,
"heapDeltaBytes": -10833652,
"heapUsedBytes": 77473456,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 69.62199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.88378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.2500000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.4599999999996,
"heapDeltaBytes": -32359292,
"heapUsedBytes": 65377644,
"domNodes": -208,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 165.64600000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.533333333333328,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.3930000000391,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.4540000000002,
"heapDeltaBytes": -2477656,
"heapUsedBytes": 73364340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.972,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11186.62999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10320.835000000001,
"heapDeltaBytes": 79493288,
"heapUsedBytes": 155035360,
"domNodes": -274,
"jsHeapTotalBytes": 77983744,
"scriptDurationMs": 8221.051,
"eventListeners": -68,
"totalBlockingTimeMs": 1047,
"frameDurationMs": 31.67960339943342,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10324.17799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9531.339000000002,
"heapDeltaBytes": 80521788,
"heapUsedBytes": 155280668,
"domNodes": -274,
"jsHeapTotalBytes": 73789440,
"scriptDurationMs": 7581.862,
"eventListeners": -68,
"totalBlockingTimeMs": 826,
"frameDurationMs": 30.979879879879878,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10029.987000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9260.801000000001,
"heapDeltaBytes": 51782352,
"heapUsedBytes": 126245328,
"domNodes": -274,
"jsHeapTotalBytes": 59895808,
"scriptDurationMs": 7354.347000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 619,
"frameDurationMs": 31.697151898734173,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10274.72499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9465.712,
"heapDeltaBytes": 79878836,
"heapUsedBytes": 156004328,
"domNodes": -274,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 7528.776,
"eventListeners": -68,
"totalBlockingTimeMs": 786,
"frameDurationMs": 31.109696969696973,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 273.05699999999433,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.173000000000002,
"layouts": 12,
"layoutDurationMs": 3.3899999999999997,
"taskDurationMs": 223.234,
"heapDeltaBytes": 14772960,
"heapUsedBytes": 93118072,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.874,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.24545454545457,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 291.2890000000061,
"styleRecalcs": 27,
"styleRecalcDurationMs": 14.780999999999999,
"layouts": 12,
"layoutDurationMs": 3.661,
"taskDurationMs": 238.4,
"heapDeltaBytes": 14851752,
"heapUsedBytes": 90205960,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 9.600999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 23.076923076923077,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2040.6169999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.436000000000001,
"layouts": 8,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 647.866,
"heapDeltaBytes": -20356880,
"heapUsedBytes": 61874132,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.861,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.218000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9779999999999998,
"layouts": 9,
"layoutDurationMs": 2.8280000000000003,
"taskDurationMs": 665.7710000000001,
"heapDeltaBytes": -8037016,
"heapUsedBytes": 78765716,
"domNodes": -274,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 37.162,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2653.182999999956,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.595,
"layouts": 7,
"layoutDurationMs": 1.9989999999999999,
"taskDurationMs": 1732.787,
"heapDeltaBytes": -10472424,
"heapUsedBytes": 82171540,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 818.92,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2615.9999999999854,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.312,
"layouts": 6,
"layoutDurationMs": 1.522,
"taskDurationMs": 1777.3340000000003,
"heapDeltaBytes": -20152628,
"heapUsedBytes": 74853756,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 879.795,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.772435897435898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3822.277999999983,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.601000000000003,
"layouts": 65,
"layoutDurationMs": 10.22,
"taskDurationMs": 1807.3389999999997,
"heapDeltaBytes": -2546004,
"heapUsedBytes": 80983092,
"domNodes": -250,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 788.076,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665938864628824,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3787.17800000004,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.401,
"layouts": 64,
"layoutDurationMs": 9.789,
"taskDurationMs": 1850.066,
"heapDeltaBytes": -14654840,
"heapUsedBytes": 76387012,
"domNodes": -250,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 817.0039999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154184,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3009.732999999983,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.279000000000001,
"layouts": 6,
"layoutDurationMs": 1.698,
"taskDurationMs": 1963.974,
"heapDeltaBytes": 19653200,
"heapUsedBytes": 91318780,
"domNodes": 0,
"jsHeapTotalBytes": 2777088,
"scriptDurationMs": 957.5079999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85337078651685,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3005.5119999999533,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.969,
"layouts": 5,
"layoutDurationMs": 1.1750000000000003,
"taskDurationMs": 1928.7649999999999,
"heapDeltaBytes": -5969312,
"heapUsedBytes": 80072036,
"domNodes": 0,
"jsHeapTotalBytes": 6254592,
"scriptDurationMs": 947.3820000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480448,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3043.9120000000057,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8320000000000003,
"layouts": 7,
"layoutDurationMs": 1.5339999999999998,
"taskDurationMs": 793.0440000000001,
"heapDeltaBytes": -8800524,
"heapUsedBytes": 74471820,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 356.979,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3073.5429999999724,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.033,
"layouts": 8,
"layoutDurationMs": 1.762,
"taskDurationMs": 806.7729999999999,
"heapDeltaBytes": -7769536,
"heapUsedBytes": 67917224,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 370.26599999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.6949999999902,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2760000000000002,
"layouts": 7,
"layoutDurationMs": 2.0889999999999995,
"taskDurationMs": 666.5519999999999,
"heapDeltaBytes": -19194336,
"heapUsedBytes": 65390352,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.382999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.9549999999117,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8619999999999999,
"layouts": 7,
"layoutDurationMs": 1.903,
"taskDurationMs": 653.806,
"heapDeltaBytes": -21809492,
"heapUsedBytes": 63212556,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.991000000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2739.9660000000094,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.888000000000002,
"layouts": 8,
"layoutDurationMs": 1.853,
"taskDurationMs": 509.373,
"heapDeltaBytes": -155616,
"heapUsedBytes": 71573748,
"domNodes": -258,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 182.90800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665243902439027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2785.43099999996,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.378,
"layouts": 6,
"layoutDurationMs": 1.5339999999999998,
"taskDurationMs": 615.076,
"heapDeltaBytes": -6396436,
"heapUsedBytes": 77894924,
"domNodes": -256,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 196.907,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3271.451999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.07,
"layouts": 7,
"layoutDurationMs": 1.796,
"taskDurationMs": 958.8320000000001,
"heapDeltaBytes": -2371524,
"heapUsedBytes": 87277768,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 367.71,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3285.8809999999607,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6439999999999997,
"layouts": 7,
"layoutDurationMs": 1.751,
"taskDurationMs": 982.244,
"heapDeltaBytes": -26613224,
"heapUsedBytes": 61868176,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 388.756,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751530612244895,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 617.211999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.080000000000001,
"layouts": 10,
"layoutDurationMs": 2.334,
"taskDurationMs": 452.64899999999994,
"heapDeltaBytes": 3701708,
"heapUsedBytes": 67764284,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 146.81300000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.4960000000119,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.808000000000001,
"layouts": 8,
"layoutDurationMs": 2.163,
"taskDurationMs": 448.82200000000006,
"heapDeltaBytes": -1244368,
"heapUsedBytes": 60819964,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.52700000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.9560000000179,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4870000000000005,
"layouts": 10,
"layoutDurationMs": 2.3590000000000004,
"taskDurationMs": 564.5669999999999,
"heapDeltaBytes": 12115536,
"heapUsedBytes": 74229016,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.915,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.1069999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.534,
"layouts": 8,
"layoutDurationMs": 2.176,
"taskDurationMs": 528.789,
"heapDeltaBytes": 4635868,
"heapUsedBytes": 66079676,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.559999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1806.9590000000062,
"styleRecalcs": 81,
"styleRecalcDurationMs": 15.108,
"layouts": 10,
"layoutDurationMs": 2.656,
"taskDurationMs": 918.522,
"heapDeltaBytes": 3483972,
"heapUsedBytes": 65579192,
"domNodes": -192,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.281,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.7189999999791,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.312999999999999,
"layouts": 7,
"layoutDurationMs": 1.95,
"taskDurationMs": 885.5289999999999,
"heapDeltaBytes": -5360604,
"heapUsedBytes": 69335756,
"domNodes": -200,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 108.93599999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1487.146999999993,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.373000000000005,
"layouts": 5,
"layoutDurationMs": 15.743,
"taskDurationMs": 1141.911,
"heapDeltaBytes": 39423924,
"heapUsedBytes": 113686416,
"domNodes": 15869,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 29.465999999999998,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.479220779220785,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9855.39399999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.256,
"layouts": 9,
"layoutDurationMs": 2.0740000000000003,
"taskDurationMs": 6103.121,
"heapDeltaBytes": -18726300,
"heapUsedBytes": 63356516,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2766.8999999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665989847715736,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9909.253000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.644000000000002,
"layouts": 9,
"layoutDurationMs": 2.247,
"taskDurationMs": 6173.93,
"heapDeltaBytes": -18187748,
"heapUsedBytes": 63497136,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2837.5,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69393939393939,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23140.15899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22619.793999999998,
"heapDeltaBytes": -18498596,
"heapUsedBytes": 261210492,
"domNodes": -3329,
"jsHeapTotalBytes": 6537216,
"scriptDurationMs": 313.98900000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.77491408934708,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23127.912000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22553.259000000002,
"heapDeltaBytes": -7906244,
"heapUsedBytes": 276484260,
"domNodes": -3329,
"jsHeapTotalBytes": 6537216,
"scriptDurationMs": 306.79599999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.27142857142858,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 27945.335,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.045000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27538.434,
"heapDeltaBytes": 8278980,
"heapUsedBytes": 286612720,
"domNodes": -3329,
"jsHeapTotalBytes": 15384576,
"scriptDurationMs": 873.611,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 50.81618181818182,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27910.610999999903,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.825000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27479.377000000004,
"heapDeltaBytes": -3124140,
"heapUsedBytes": 286033048,
"domNodes": -3329,
"jsHeapTotalBytes": 14602240,
"scriptDurationMs": 888.761,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.374296435272036,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8386.341000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.831999999999994,
"layouts": 20,
"layoutDurationMs": 22.24899999999999,
"taskDurationMs": 8253.101,
"heapDeltaBytes": -6871600,
"heapUsedBytes": 277664976,
"domNodes": -3329,
"jsHeapTotalBytes": 10469376,
"scriptDurationMs": 117.117,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.36214689265536,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8433.136999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.88700000000001,
"layouts": 20,
"layoutDurationMs": 24.915000000000006,
"taskDurationMs": 8272.983,
"heapDeltaBytes": -10038260,
"heapUsedBytes": 283202448,
"domNodes": -3329,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 128.97199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.01843575418994,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11711.901000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11459.804000000002,
"heapDeltaBytes": -11308476,
"heapUsedBytes": 257492172,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 162.83999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.067123287671244,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11400.228999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11153.324999999999,
"heapDeltaBytes": -25152428,
"heapUsedBytes": 255299200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.38400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.90648464163822,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 187.54999999998745,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.979,
"layouts": 12,
"layoutDurationMs": 5.091,
"taskDurationMs": 132.76699999999997,
"heapDeltaBytes": 5186072,
"heapUsedBytes": 66630284,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.793000000000003,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 115.24800000006508,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.9830000000000005,
"layouts": 8,
"layoutDurationMs": 3.0559999999999996,
"taskDurationMs": 97.15400000000001,
"heapDeltaBytes": -13021552,
"heapUsedBytes": 60891616,
"domNodes": 121,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.775,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.32000000005337,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.625,
"layouts": 76,
"layoutDurationMs": 14.279,
"taskDurationMs": 425.058,
"heapDeltaBytes": -4224556,
"heapUsedBytes": 40623680,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 208.65900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 469.8070000000598,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.653,
"layouts": 76,
"layoutDurationMs": 14.545,
"taskDurationMs": 422.169,
"heapDeltaBytes": -4192736,
"heapUsedBytes": 40738636,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 205.013,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 519.313000000011,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.675,
"layouts": 76,
"layoutDurationMs": 13.617,
"taskDurationMs": 477.6170000000001,
"heapDeltaBytes": 21752,
"heapUsedBytes": 103421360,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 190.63,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 538.0399999999099,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.517,
"layouts": 76,
"layoutDurationMs": 13.869,
"taskDurationMs": 497.368,
"heapDeltaBytes": 286260,
"heapUsedBytes": 103678584,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 203.38600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3186 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d95cd070a23bc8116c3203d054aa28159b6ffe26
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (294)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove restored-value count API src/stores/widgetValueStore.ts |
The store removes getRestoredWidgetValueCount and no longer includes it in the returned API. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21788: That PR removes the DynamicGroup validation caller; this change removes the store method that it no longer uses.
Suggested reviewers: jaeone94
Merge Risk: 
Minimal · up to f1014
-
The unused store method can be removed without affecting any identified caller. The PR is mergeable after normal checks.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description explains why the unused function was removed, states that behavior does not change, and reports that store tests pass. It covers the required summary and verification information, although it does not use the template headings.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR removes an unused store method from
src/stores/widgetValueStore.ts. The available diff summary states that the method had no callers and that the change has no behavior change. This is maintenance, not a frontend bug fix or user-facing feature change, so the end-to-end test suggestion does not apply.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The change removes
getRestoredWidgetValueCountfromsrc/stores/widgetValueStore.ts. Although the file relates to widget state, the diff contains only a method removal and introduces no entity mutation API, ECS component pattern, god-object growth, or extension callback change. No ADR-LAYOUT or ADR-ECS failure condition is present.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22418 +/- ##
==========================================
- Coverage 87.47% 87.37% -0.11%
==========================================
Files 2961 2853 -108
Lines 161039 157644 -3395
Branches 41090 39913 -1177
==========================================
- Hits 140875 137742 -3133
+ Misses 19241 19145 -96
+ Partials 923 757 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 120 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed f10145e. The diff removes only the unused restoration-count function and its Pinia return entry. A repository-wide search finds no callers; the remaining restoration getters and row-bound handling are unchanged. This matches the ADR-039 audit without changing retained-row behavior.
Own validation in an isolated checkout with its own frozen install: 58 widget-value/store-reactivity tests, app typecheck, scoped type-aware oxlint, ESLint and formatting PASS. No server/API shape or permission changes. Build and browser/live-backend checks were NOT_RUN: there is no executable caller to exercise for this dead-code removal, and operational acceptance is outside this code review.
|
Merging at approved head |
Removes a store function with no callers. Multi-player ADR-039 flagged it for audit because it counts retained DynamicGroup keys, which would inflate a saved row ceiling; the ceiling that used it no longer exists, so there is nothing left to correct.
No behaviour change. Store tests pass.