Repository navigation
Conversation
… menu On local ComfyUI and Desktop with open_on_cloud_enabled on, a plain cloud sits in the rocket's slot, left of the right panel toggle. It is the one entry point on local, so LocalEngineMenu, its test and its story are gone. With the flag off, local keeps the rocket. Comfy Cloud is unchanged. The check runs when the pointer reaches the button, or on Enter or Space. A running check is kept. While it runs, the button spins the Figma progress ring, its tooltip reads "Checking Comfy Cloud…" and it is aria-busy. There is no checking modal. A click opens the one modal that the answer picks (Figma 196:280495): ready opens Run on Comfy Cloud with #21153's handoff, missing node packs (with or without models) open DeploySetupCard, and signed out opens Run on Comfy Cloud with Sign in. A click during a check opens the modal when the answer arrives. A new check while the modal shows closes it and reopens it with the new answer. The check state carries the modal: checking knows whether the modal opens with the answer, and answered knows whether it shows. One pure reducer moves it; one watch syncs it to the dialog store, and the dialog's removal dismisses it. The checker's answer now names the missing node packs and models, or signed out. The dev-only switch gains those scenarios, rechecks when it changes, and renders only in dev builds.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T20:37:33.930Z",
"gitSha": "b0fbd4c24ee63a1f4982680f6ec43765e2c25ee8",
"branch": "willie/des-1261-cloud-button",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.8680000000072,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2910000000000004,
"layouts": 10,
"layoutDurationMs": 2.941,
"taskDurationMs": 417.961,
"heapDeltaBytes": 1851492,
"heapUsedBytes": 61668496,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.371,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2009.0470000000096,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.412,
"layouts": 10,
"layoutDurationMs": 2.9960000000000004,
"taskDurationMs": 466.012,
"heapDeltaBytes": 1984236,
"heapUsedBytes": 63409444,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.016,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.6500000000005,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.674000000000001,
"layouts": 9,
"layoutDurationMs": 2.502,
"taskDurationMs": 687.477,
"heapDeltaBytes": -2948384,
"heapUsedBytes": 67143116,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 123.87600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.542000000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.768,
"layouts": 9,
"layoutDurationMs": 2.6710000000000003,
"taskDurationMs": 719.329,
"heapDeltaBytes": 17521152,
"heapUsedBytes": 77767608,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 131.659,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.8329999999992,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.368,
"layouts": 12,
"layoutDurationMs": 3.193,
"taskDurationMs": 341.17600000000004,
"heapDeltaBytes": 814888,
"heapUsedBytes": 71131104,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 14.285,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.3109999999765,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.582000000000001,
"layouts": 12,
"layoutDurationMs": 3.3770000000000002,
"taskDurationMs": 336.488,
"heapDeltaBytes": 19676752,
"heapUsedBytes": 80996224,
"domNodes": 57,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 14.972000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 618.7840000000051,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.817,
"layouts": 8,
"layoutDurationMs": 2.603,
"taskDurationMs": 407.71599999999995,
"heapDeltaBytes": 3815340,
"heapUsedBytes": 64306228,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 130.236,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 565.6880000000228,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2750000000000004,
"layouts": 9,
"layoutDurationMs": 2.7289999999999996,
"taskDurationMs": 395.885,
"heapDeltaBytes": 5180132,
"heapUsedBytes": 66703720,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 130.303,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 982.9950000000167,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.1689999999999,
"heapDeltaBytes": -13797688,
"heapUsedBytes": 74787212,
"domNodes": -203,
"jsHeapTotalBytes": 19406848,
"scriptDurationMs": 44.733,
"eventListeners": -106,
"totalBlockingTimeMs": 309,
"frameDurationMs": 27.31666666666667,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1014.4970000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.8190000000001,
"heapDeltaBytes": -14835400,
"heapUsedBytes": 75179312,
"domNodes": -203,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 48.096,
"eventListeners": -106,
"totalBlockingTimeMs": 328,
"frameDurationMs": 27.475675675675674,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 748.4120000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.31000000000006,
"heapDeltaBytes": -11900648,
"heapUsedBytes": 66391956,
"domNodes": -203,
"jsHeapTotalBytes": 1703936,
"scriptDurationMs": 111.17799999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 104,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 713.009999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.51699999999994,
"heapDeltaBytes": -4453316,
"heapUsedBytes": 70023052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.494,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7014.181999999977,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8909999999999995,
"layouts": 3,
"layoutDurationMs": 0.7789999999999994,
"taskDurationMs": 6012.902,
"heapDeltaBytes": 47388544,
"heapUsedBytes": 126711240,
"domNodes": -269,
"jsHeapTotalBytes": 61730816,
"scriptDurationMs": 4534.466,
"eventListeners": -68,
"totalBlockingTimeMs": 53,
"frameDurationMs": 21.50795107033639,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6562.157000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9060000000000006,
"layouts": 3,
"layoutDurationMs": 0.7879999999999996,
"taskDurationMs": 5723.614,
"heapDeltaBytes": 60078252,
"heapUsedBytes": 138433784,
"domNodes": -269,
"jsHeapTotalBytes": 59633664,
"scriptDurationMs": 4217.596,
"eventListeners": -68,
"totalBlockingTimeMs": 33,
"frameDurationMs": 20.779746835443035,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6713.990999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8960000000000001,
"layouts": 3,
"layoutDurationMs": 0.7440000000000003,
"taskDurationMs": 6015.523,
"heapDeltaBytes": 33488800,
"heapUsedBytes": 117573536,
"domNodes": -269,
"jsHeapTotalBytes": 51769344,
"scriptDurationMs": 4535.915,
"eventListeners": -68,
"totalBlockingTimeMs": 54,
"frameDurationMs": 24.692647058823532,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6817.702999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.725,
"layouts": 3,
"layoutDurationMs": 0.895,
"taskDurationMs": 6163.796,
"heapDeltaBytes": 54994000,
"heapUsedBytes": 136794212,
"domNodes": -269,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 4616.428,
"eventListeners": -68,
"totalBlockingTimeMs": 46,
"frameDurationMs": 24.968131868131866,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 155.84400000000187,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.399999999999999,
"layouts": 11,
"layoutDurationMs": 3.2739999999999996,
"taskDurationMs": 121.38100000000001,
"heapDeltaBytes": 14514612,
"heapUsedBytes": 90593888,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.909,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 177.63400000001184,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.109,
"layouts": 12,
"layoutDurationMs": 3.579,
"taskDurationMs": 135.50500000000002,
"heapDeltaBytes": -6310256,
"heapUsedBytes": 72418668,
"domNodes": 936,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.173000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2025.9780000000092,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0729999999999995,
"layouts": 9,
"layoutDurationMs": 2.677,
"taskDurationMs": 593.356,
"heapDeltaBytes": -29678380,
"heapUsedBytes": 63511360,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 36.338,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2043.4290000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0789999999999993,
"layouts": 9,
"layoutDurationMs": 2.8789999999999996,
"taskDurationMs": 593.44,
"heapDeltaBytes": -1123976,
"heapUsedBytes": 84852244,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 36.89000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2966.637999999989,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.974,
"layouts": 8,
"layoutDurationMs": 2.1950000000000003,
"taskDurationMs": 1390.3029999999999,
"heapDeltaBytes": -21171272,
"heapUsedBytes": 72638564,
"domNodes": -269,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 648.981,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3032.026999999971,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.988,
"layouts": 8,
"layoutDurationMs": 2.259,
"taskDurationMs": 1434.898,
"heapDeltaBytes": 10739764,
"heapUsedBytes": 87016516,
"domNodes": -269,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 654.0930000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3917.5479999999825,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.843999999999998,
"layouts": 67,
"layoutDurationMs": 13.588,
"taskDurationMs": 1437.0130000000001,
"heapDeltaBytes": -17111120,
"heapUsedBytes": 72421224,
"domNodes": 24,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 623.267,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665531914893617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4019.386000000054,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.908000000000001,
"layouts": 64,
"layoutDurationMs": 12.14,
"taskDurationMs": 1537.7799999999997,
"heapDeltaBytes": -23400528,
"heapUsedBytes": 65734056,
"domNodes": -245,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 664.055,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665560165975105,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3071.836000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.9030000000000005,
"layouts": 7,
"layoutDurationMs": 1.8289999999999995,
"taskDurationMs": 1615.5130000000001,
"heapDeltaBytes": -10571904,
"heapUsedBytes": 79310624,
"domNodes": 0,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 797.385,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3196.867999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.779999999999999,
"layouts": 6,
"layoutDurationMs": 1.99,
"taskDurationMs": 1778.9020000000003,
"heapDeltaBytes": -17210700,
"heapUsedBytes": 69335264,
"domNodes": -269,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 898.489,
"eventListeners": 114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75421052631579,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2956.038000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.730000000000001,
"layouts": 8,
"layoutDurationMs": 2.294,
"taskDurationMs": 651.4649999999999,
"heapDeltaBytes": -16321836,
"heapUsedBytes": 72520800,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 286.936,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66573033707865,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2972.401999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2310000000000003,
"layouts": 7,
"layoutDurationMs": 2.0320000000000005,
"taskDurationMs": 629.8340000000001,
"heapDeltaBytes": -19074532,
"heapUsedBytes": 69314620,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 285.715,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2050.337999999954,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3219999999999996,
"layouts": 7,
"layoutDurationMs": 2.128,
"taskDurationMs": 576.833,
"heapDeltaBytes": -533200,
"heapUsedBytes": 74192392,
"domNodes": -269,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 35.32599999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.6850000000154,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3759999999999994,
"layouts": 7,
"layoutDurationMs": 2.083,
"taskDurationMs": 567.8499999999999,
"heapDeltaBytes": -493340,
"heapUsedBytes": 74216348,
"domNodes": -269,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.190999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2730.1779999999953,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.835,
"layouts": 8,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 483.22900000000004,
"heapDeltaBytes": -20425208,
"heapUsedBytes": 69556316,
"domNodes": -266,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 152.10700000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2736.440000000016,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.760999999999997,
"layouts": 8,
"layoutDurationMs": 2.144,
"taskDurationMs": 502.003,
"heapDeltaBytes": 13674804,
"heapUsedBytes": 85295808,
"domNodes": -262,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 155.524,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3044.864999999987,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.314000000000001,
"layouts": 7,
"layoutDurationMs": 2.1,
"taskDurationMs": 768.0709999999999,
"heapDeltaBytes": -1702900,
"heapUsedBytes": 86087496,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 294.60999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3078.028999999958,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3099999999999996,
"layouts": 8,
"layoutDurationMs": 2.04,
"taskDurationMs": 789.164,
"heapDeltaBytes": -14920388,
"heapUsedBytes": 74680192,
"domNodes": -269,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 303.306,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.6450000000086,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.311,
"layouts": 9,
"layoutDurationMs": 2.598,
"taskDurationMs": 371.913,
"heapDeltaBytes": 2270256,
"heapUsedBytes": 74106432,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 119.348,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.0339999999965,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.118,
"layouts": 8,
"layoutDurationMs": 2.413,
"taskDurationMs": 360.37600000000003,
"heapDeltaBytes": 22087952,
"heapUsedBytes": 83275600,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 113.232,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.5330000000047,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3030000000000004,
"layouts": 10,
"layoutDurationMs": 2.7940000000000005,
"taskDurationMs": 403.06699999999995,
"heapDeltaBytes": 2243160,
"heapUsedBytes": 63589416,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.425,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2026.270000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2400000000000007,
"layouts": 9,
"layoutDurationMs": 2.82,
"taskDurationMs": 506.6120000000001,
"heapDeltaBytes": -14334832,
"heapUsedBytes": 58203508,
"domNodes": -195,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 12.956000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5810000000035,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.164,
"layouts": 9,
"layoutDurationMs": 2.4560000000000004,
"taskDurationMs": 693.7959999999999,
"heapDeltaBytes": 13365332,
"heapUsedBytes": 74190340,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 104.259,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.29700000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.617,
"layouts": 10,
"layoutDurationMs": 3.3919999999999995,
"taskDurationMs": 732.2740000000001,
"heapDeltaBytes": -6956152,
"heapUsedBytes": 63586940,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 110.236,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.7710000000225,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.884,
"layouts": 5,
"layoutDurationMs": 10.769,
"taskDurationMs": 867.4379999999998,
"heapDeltaBytes": 11987804,
"heapUsedBytes": 114784596,
"domNodes": 16029,
"jsHeapTotalBytes": 16388096,
"scriptDurationMs": 29.824999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 92,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10972.159000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.896,
"layouts": 9,
"layoutDurationMs": 2.9,
"taskDurationMs": 4904.814,
"heapDeltaBytes": -12927248,
"heapUsedBytes": 72471684,
"domNodes": -269,
"jsHeapTotalBytes": 4026368,
"scriptDurationMs": 2231.03,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11289.894000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.181,
"layouts": 9,
"layoutDurationMs": 2.4600000000000004,
"taskDurationMs": 4963.528,
"heapDeltaBytes": -10833964,
"heapUsedBytes": 62192732,
"domNodes": -269,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 2224.811,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.690532544378698,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17819.703000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17294.555,
"heapDeltaBytes": -21455500,
"heapUsedBytes": 275872152,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 256.988,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.984347826086957,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 16979.923999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16438.907,
"heapDeltaBytes": 1361212,
"heapUsedBytes": 278851032,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 227.841,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.981305114638445,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21440.628000000004,
"styleRecalcs": 161,
"styleRecalcDurationMs": 26.037000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21170.115,
"heapDeltaBytes": -26784704,
"heapUsedBytes": 265174564,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 761.2509999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 40.47018867924529,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19424.64199999995,
"styleRecalcs": 139,
"styleRecalcDurationMs": 19.917999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19089.243,
"heapDeltaBytes": -22413296,
"heapUsedBytes": 269464740,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 679.0509999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 36.49605263157895,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6361.395000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.99899999999999,
"layouts": 20,
"layoutDurationMs": 24.198999999999998,
"taskDurationMs": 6254.436999999999,
"heapDeltaBytes": -18928828,
"heapUsedBytes": 278057292,
"domNodes": -3343,
"jsHeapTotalBytes": 25681920,
"scriptDurationMs": 97.223,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.673033707865166,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6095.577999999932,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.89,
"layouts": 20,
"layoutDurationMs": 22.073999999999998,
"taskDurationMs": 5987.824999999999,
"heapDeltaBytes": 5422484,
"heapUsedBytes": 288086820,
"domNodes": -3343,
"jsHeapTotalBytes": 31973376,
"scriptDurationMs": 91.29899999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.78235294117648,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8693.753000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8402.626000000002,
"heapDeltaBytes": -14369544,
"heapUsedBytes": 260053320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.346,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.254006968641107,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6461.656000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6181.558000000001,
"heapDeltaBytes": 19767160,
"heapUsedBytes": 290185324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.65400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.498999999999995,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 108.37800000001607,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.604000000000001,
"layouts": 8,
"layoutDurationMs": 3.232,
"taskDurationMs": 71.45,
"heapDeltaBytes": 4774100,
"heapUsedBytes": 67912084,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.496000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.56600000000981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.119000000000001,
"layouts": 8,
"layoutDurationMs": 2.438,
"taskDurationMs": 58.613000000000014,
"heapDeltaBytes": 4616432,
"heapUsedBytes": 65835724,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.044,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 401.81300000006104,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.623,
"layouts": 76,
"layoutDurationMs": 18.061,
"taskDurationMs": 353.466,
"heapDeltaBytes": 11354176,
"heapUsedBytes": 50565232,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 158.28300000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 304.0659999999207,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.593,
"layouts": 76,
"layoutDurationMs": 14.456,
"taskDurationMs": 257.181,
"heapDeltaBytes": 10666060,
"heapUsedBytes": 50348896,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 114.691,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 364.3899999999576,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.406,
"layouts": 76,
"layoutDurationMs": 16.858,
"taskDurationMs": 332.285,
"heapDeltaBytes": -5020080,
"heapUsedBytes": 77895880,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.339,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 268.7989999999445,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.313,
"layouts": 76,
"layoutDurationMs": 10.803999999999998,
"taskDurationMs": 233.895,
"heapDeltaBytes": -6044300,
"heapUsedBytes": 73854912,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 76.599,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3157 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 96f58a4700e2d3cbe0e3a392c8d4af12d7d2c1f0
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (308)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 5 |
Panel: 6/6 reviewers contributed findings.
The store derives isModalShown, and the opener checks it again after the lazy import, so a new check that starts while the chunk loads opens no empty modal. A modal that fails to open dismisses itself in the check, so the next click retries. The watch runs at mount, so a button that remounts opens a modal its answer already asked for. Sign in and Open on Comfy Cloud report a rejected hand-off in a toast.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 2 — ledger: 8 prior finding(s) across 1 round(s) (0 never answered).
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## willie/des-1261-comfyui_frontend-open-on-comfy-cloud-from-local-comfyui #22401 +/- ##
===========================================================================================================
- Coverage 87.37% 87.01% -0.36%
===========================================================================================================
Files 2835 2903 +68
Lines 155551 157687 +2136
Branches 42379 40392 -1987
===========================================================================================================
+ Hits 135912 137213 +1301
- Misses 18884 19719 +835
Partials 755 755
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 137 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This PR is intended as the design and frontend guide only. Ben Lu (
benceruleanlu) implements the feature from it in DPLAT-3609.Summary
Stacked on #21153. Part of DES-1261. #21153 closes the issue.
On local ComfyUI and Desktop with
open_on_cloud_enabledon, a plain cloud replaces the rocket and the local engine menu. A click opens the one modal that the answer from Comfy Cloud picks. With the flag off, local keeps the rocket. Comfy Cloud does not change. Design: Figma section 196:280495.What the approved prototype decided:
aria-busy. There is no checking modal.DeploySetupCard. Signed out opens Run on Comfy Cloud with Sign in, which opens the existing sign-in dialog.How it works:
CloudWorkflowCheckStateis one union: idle, checking withopensModal, and answered withshowsModal.reduceCloudWorkflowCheckis the pure transition. One watch inCloudButtonsyncsshowsModalto the dialog store. TheonRemovedof the dialog dispatchesmodalDismissed.nodePacksandmodels, orsignedOut. The UI renders it as received.LocalEngineMenu, its test, its story and its locale keys are deleted. ItsOpenedOnCloudtoast story moved toCloudButton.stories.ts.Judgement calls:
DeploySetupCardfor now. The Upload models dialog comes in a later PR stacked on this one.ProgressRing(Figma part115:186963) ships here because the checking state spins it. The upload PR can use it for upload progress.false, as in feat(open-on-cloud): open the workflow on Comfy Cloud from local ComfyUI #21153. The prototype turned it on in dev builds. To see the button on the dev server, setlocalStorage['ff:open_on_cloud_enabled'] = 'true'.import.meta.env.DEVis true. It hasdata-dismissable-layer, so a click on it keeps the modal open.No backend ticket exists yet. No Cloud endpoint answers this check from local:
/api/object_inforeturns 401 and has no CORS for local origins. The check stays behind theCloudWorkflowCheckerstand-in. AGENTS.md asks forpendingServerFact('BE-xxxx', …), so this PR has no such call until a BE ticket exists.Not changed here:
GlobalDialoggives headless dialogs no rekaDialogTitle, so reka logs a warning for this modal.DeploySetupCardin #21153 logs the same warning. The agent button in Deploy your setup is also from #21153. Another PR on this stack changes it.Verification
pnpm test:unit src/platform/openOnCloud src/components/TopMenuSection.test.ts src/components/actionbarpasses, 185 tests in 17 files. New tests: a reducer table with 13 rows, and aCloudButtontest with the real dialog host. It covers hover, a click during a check, Enter, a kept check, each answer and its modal, a new answer while open, Cancel, a failed open, a remount, and the two handoffs.openRunOnCloudDialoggets a test for a late lazy import.TopMenuSectiongets a table for cloud versus rocket.typecheck:appand the unused i18n key check pass.fallow auditpasses with nothing introduced.window.openwithtestcloud.comfy.org/?from_local=…(stubbed). With the flag off, the rocket shows and the cloud and the dev switch do not.21f45e7b50, 5 answered as approved design or real-endpoint scope. All threads resolved.