Repository navigation
[backport core/1.59] fix(agent): name the ask kind on the superseded-answer report (FRONT-3663) (#22222) - #22378
Conversation
…3663) (#22222) ## Summary The superseded-answer report (`agent_ask_answer_superseded`) now says which card lost: `ask_kind` is `run_approval`, `ask_user`, `delete_approval`, or `unknown`. Follow-up to #21327 (FRONT-3663). <details><summary>Full context for agent readers</summary> - The store reads the card's kind when the answer is recorded (`recordAskAnswer`), while the card is on screen, so a report that arrives after a thread switch still names it. No card found for that ask id → `unknown`. - `takeSubmittedAskAnswer` now returns `{ answer, kind }`; both report paths (202 receipt, 409 conflict, `agent_ask_resolved` frame) read the kind from there. No behaviour change for the user. - Old message-text check from the residual: no Datadog monitor or agent dashboard references the old `agent ask resolved as …` text or the error type, and there are no matching RUM events or Sentry issues in the last 30 days. Sentry alert rules could not be listed with the available token. </details> Fixes FRONT-3663 ## Verification - Red first: the new and updated tests in `useAgentSession.test.ts` failed (8) before the change, pass after: one row per kind plus `unknown`; existing exact-tag assertions now include `ask_kind`. - `vitest run src/workbench/extensions/agent`: 4537 passed. One unrelated timing failure in `AgentPanel.test.ts` under full-suite load; it passes in isolation with and without this change. - `pnpm typecheck` clean; pre-commit and pre-push hooks (lint, knip, fallow) passed. (cherry picked from commit 8515c1b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T11:40:50.396Z",
"gitSha": "890e3adec592765151348b0bf494357aef1d78ac",
"branch": "backport-22222-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.67,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.508000000000001,
"layouts": 7,
"layoutDurationMs": 2.3809999999999993,
"taskDurationMs": 630.153,
"heapDeltaBytes": 1618596,
"heapUsedBytes": 63524768,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.578000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2021.9990000000507,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0749999999999997,
"layouts": 9,
"layoutDurationMs": 2.825,
"taskDurationMs": 537.194,
"heapDeltaBytes": 5603732,
"heapUsedBytes": 76666868,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.745000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.2179999999896,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.765999999999998,
"layouts": 9,
"layoutDurationMs": 2.7729999999999997,
"taskDurationMs": 954.987,
"heapDeltaBytes": 21862500,
"heapUsedBytes": 83321020,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.596,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.096999999936,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.706000000000001,
"layouts": 9,
"layoutDurationMs": 2.609,
"taskDurationMs": 911.5889999999998,
"heapDeltaBytes": 22620288,
"heapUsedBytes": 83727572,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 167.156,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0699999999874,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.235,
"layouts": 10,
"layoutDurationMs": 3.0109999999999997,
"taskDurationMs": 458.052,
"heapDeltaBytes": 24297600,
"heapUsedBytes": 85176632,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.015,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8630000000512,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.279000000000001,
"layouts": 11,
"layoutDurationMs": 3.2090000000000005,
"taskDurationMs": 410.743,
"heapDeltaBytes": 1053760,
"heapUsedBytes": 71510736,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.503,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 742.2570000000235,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8249999999999993,
"layouts": 9,
"layoutDurationMs": 2.73,
"taskDurationMs": 515.2330000000001,
"heapDeltaBytes": 3401772,
"heapUsedBytes": 64793788,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 173.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 717.6300000000992,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.019,
"layouts": 10,
"layoutDurationMs": 2.8680000000000003,
"taskDurationMs": 500.08799999999997,
"heapDeltaBytes": 3882128,
"heapUsedBytes": 65084088,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 166.47099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069764,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1272.233,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 995.4549999999999,
"heapDeltaBytes": -12606216,
"heapUsedBytes": 74971672,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 72.98700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 580,
"frameDurationMs": 34.229729729729726,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1261.3620000000196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 971.813,
"heapDeltaBytes": -13989396,
"heapUsedBytes": 75182536,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 74.01700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 569,
"frameDurationMs": 34.23243243243243,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 866.8360000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.9520000000006,
"heapDeltaBytes": 22638468,
"heapUsedBytes": 88090112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.939,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 911.0259999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.1149999999998,
"heapDeltaBytes": -27162712,
"heapUsedBytes": 66406700,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 171.88699999999994,
"eventListeners": -106,
"totalBlockingTimeMs": 240,
"frameDurationMs": 24.775675675675647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11421.57400000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.037000000000000574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10485.492,
"heapDeltaBytes": 1332248,
"heapUsedBytes": 90228156,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8414.651,
"eventListeners": -68,
"totalBlockingTimeMs": 1191,
"frameDurationMs": 31.624099722991687,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10512.297999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9700.148000000001,
"heapDeltaBytes": -9325992,
"heapUsedBytes": 78905968,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7804.175,
"eventListeners": -68,
"totalBlockingTimeMs": 956,
"frameDurationMs": 31.391940298507468,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11134.128000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05299999999999923,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10317.914999999999,
"heapDeltaBytes": 62845188,
"heapUsedBytes": 145562324,
"domNodes": -257,
"jsHeapTotalBytes": 66449408,
"scriptDurationMs": 8280.315,
"eventListeners": -68,
"totalBlockingTimeMs": 1322,
"frameDurationMs": 31.010863509749303,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11143.53699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10378.859999999999,
"heapDeltaBytes": 79466980,
"heapUsedBytes": 153865376,
"domNodes": -257,
"jsHeapTotalBytes": 74838016,
"scriptDurationMs": 8401.98,
"eventListeners": -68,
"totalBlockingTimeMs": 1172,
"frameDurationMs": 31.99137931034483,
"p95FrameDurationMs": 66.5
},
{
"name": "large-combo-open",
"durationMs": 219.92599999998674,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.434,
"layouts": 8,
"layoutDurationMs": 2.575,
"taskDurationMs": 164.858,
"heapDeltaBytes": 14515292,
"heapUsedBytes": 74439884,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.504000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 272.36299999998437,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.991000000000001,
"layouts": 11,
"layoutDurationMs": 3.3400000000000003,
"taskDurationMs": 228.90899999999996,
"heapDeltaBytes": -800152,
"heapUsedBytes": 68442576,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 14.168999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 3,
"frameDurationMs": 22.224999999999984,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2057.5959999999895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.926999999999999,
"layouts": 8,
"layoutDurationMs": 2.9459999999999997,
"taskDurationMs": 740.893,
"heapDeltaBytes": -10162588,
"heapUsedBytes": 64151088,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 38.955999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.5640000000649,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7290000000000005,
"layouts": 8,
"layoutDurationMs": 2.2939999999999996,
"taskDurationMs": 647.809,
"heapDeltaBytes": -28089604,
"heapUsedBytes": 63256536,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 31.668000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2705.7229999999777,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.761000000000001,
"layouts": 6,
"layoutDurationMs": 1.8280000000000003,
"taskDurationMs": 1775.325,
"heapDeltaBytes": 5624608,
"heapUsedBytes": 81455232,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 853.7470000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2546.7139999999517,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.277,
"layouts": 7,
"layoutDurationMs": 1.5719999999999998,
"taskDurationMs": 1701.1530000000002,
"heapDeltaBytes": 4692464,
"heapUsedBytes": 80847796,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 819.6500000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601307189542,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3722.943999999984,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.517000000000001,
"layouts": 64,
"layoutDurationMs": 10.583,
"taskDurationMs": 1780.5310000000004,
"heapDeltaBytes": -831872,
"heapUsedBytes": 70436852,
"domNodes": -233,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 779.8580000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004483,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3631.9189999999253,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.546,
"layouts": 64,
"layoutDurationMs": 10.834,
"taskDurationMs": 1762.4370000000001,
"heapDeltaBytes": 5879508,
"heapUsedBytes": 82217836,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 784.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3051.1449999999627,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.025,
"layouts": 5,
"layoutDurationMs": 1.723,
"taskDurationMs": 1977.385,
"heapDeltaBytes": 20031380,
"heapUsedBytes": 99616124,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 963.166,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757692307692306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2943.832000000043,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.497999999999999,
"layouts": 4,
"layoutDurationMs": 1.2269999999999999,
"taskDurationMs": 1918.4989999999998,
"heapDeltaBytes": 20250192,
"heapUsedBytes": 99493832,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 947.845,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3069.4030000000225,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.653,
"layouts": 6,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 814.7410000000001,
"heapDeltaBytes": 8800500,
"heapUsedBytes": 85592380,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 365.761,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3070.2229999999986,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6300000000000003,
"layouts": 6,
"layoutDurationMs": 1.4820000000000002,
"taskDurationMs": 802.3420000000001,
"heapDeltaBytes": 879188,
"heapUsedBytes": 80137364,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 360.774,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826085,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.4120000000266,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3689999999999998,
"layouts": 7,
"layoutDurationMs": 2.0029999999999997,
"taskDurationMs": 709.551,
"heapDeltaBytes": -12635692,
"heapUsedBytes": 68150492,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 45.972,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.8489999999283,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.751,
"layouts": 7,
"layoutDurationMs": 1.6210000000000002,
"taskDurationMs": 639.7479999999998,
"heapDeltaBytes": -22931464,
"heapUsedBytes": 70203236,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 32.575,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2817.6959999999835,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.273,
"layouts": 6,
"layoutDurationMs": 1.787,
"taskDurationMs": 660.8510000000001,
"heapDeltaBytes": -19466824,
"heapUsedBytes": 73562620,
"domNodes": -253,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 219.72699999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2734.645999999998,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.52,
"layouts": 6,
"layoutDurationMs": 1.9480000000000002,
"taskDurationMs": 610.7049999999999,
"heapDeltaBytes": -25754276,
"heapUsedBytes": 68020908,
"domNodes": -255,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 188.817,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3332.4929999999995,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.562,
"layouts": 5,
"layoutDurationMs": 1.5440000000000003,
"taskDurationMs": 999.3949999999999,
"heapDeltaBytes": -6326476,
"heapUsedBytes": 72135044,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 410.395,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3321.524000000011,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5900000000000003,
"layouts": 6,
"layoutDurationMs": 1.7739999999999996,
"taskDurationMs": 998.732,
"heapDeltaBytes": -2345084,
"heapUsedBytes": 74800648,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 391.374,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.8809999999726,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.863,
"layouts": 8,
"layoutDurationMs": 2.273,
"taskDurationMs": 437.208,
"heapDeltaBytes": 921052,
"heapUsedBytes": 62476900,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 144.657,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.7669999999234,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.595999999999999,
"layouts": 9,
"layoutDurationMs": 2.3560000000000003,
"taskDurationMs": 423.731,
"heapDeltaBytes": -1434308,
"heapUsedBytes": 60453560,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 142.706,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.442999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8120000000000003,
"layouts": 8,
"layoutDurationMs": 3.378,
"taskDurationMs": 606.692,
"heapDeltaBytes": 1842832,
"heapUsedBytes": 63813208,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.998999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.769000000053,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4930000000000003,
"layouts": 10,
"layoutDurationMs": 2.7279999999999993,
"taskDurationMs": 514.866,
"heapDeltaBytes": 1945536,
"heapUsedBytes": 63944804,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.607000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.6719999999705,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.742999999999999,
"layouts": 9,
"layoutDurationMs": 2.6590000000000003,
"taskDurationMs": 887.98,
"heapDeltaBytes": 19874452,
"heapUsedBytes": 82203172,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 117.95599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4879999999885,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.515,
"layouts": 10,
"layoutDurationMs": 2.7929999999999997,
"taskDurationMs": 805.245,
"heapDeltaBytes": -5349716,
"heapUsedBytes": 66352920,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 106.049,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1470.536999999979,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.113999999999997,
"layouts": 5,
"layoutDurationMs": 17.378,
"taskDurationMs": 1151.681,
"heapDeltaBytes": 7201168,
"heapUsedBytes": 95532496,
"domNodes": 16030,
"jsHeapTotalBytes": 16650240,
"scriptDurationMs": 32.923,
"eventListeners": 3246,
"totalBlockingTimeMs": 172,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9869.876000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.46,
"layouts": 8,
"layoutDurationMs": 2.283,
"taskDurationMs": 6246.826999999999,
"heapDeltaBytes": -15979120,
"heapUsedBytes": 62931832,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2808.877,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587837837838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9367.345999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.969,
"layouts": 8,
"layoutDurationMs": 1.842,
"taskDurationMs": 5965.856,
"heapDeltaBytes": -787476,
"heapUsedBytes": 73579512,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2745.662,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23219.858000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22804.500999999997,
"heapDeltaBytes": -17424560,
"heapUsedBytes": 263009100,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 316.81499999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.16557093425606,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 22853.725000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21948.865,
"heapDeltaBytes": -22684456,
"heapUsedBytes": 258485008,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 323.565,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.259621993127155,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27808.020999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.7,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27435.065000000002,
"heapDeltaBytes": -9263388,
"heapUsedBytes": 267047372,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 890.477,
"eventListeners": -651,
"totalBlockingTimeMs": 83,
"frameDurationMs": 50.75821167883211,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27729.67700000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.352000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27372.378,
"heapDeltaBytes": -762680,
"heapUsedBytes": 281545356,
"domNodes": -3343,
"jsHeapTotalBytes": 9879552,
"scriptDurationMs": 853.2010000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 50.97849264705882,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8332.822000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.01500000000001,
"layouts": 20,
"layoutDurationMs": 22.879000000000012,
"taskDurationMs": 8234.366999999998,
"heapDeltaBytes": -17166556,
"heapUsedBytes": 273979812,
"domNodes": -3343,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 130.464,
"eventListeners": -653,
"totalBlockingTimeMs": 12,
"frameDurationMs": 47.89080459770116,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8172.967000000085,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.52799999999998,
"layouts": 20,
"layoutDurationMs": 22.488999999999994,
"taskDurationMs": 8017.948,
"heapDeltaBytes": -14731092,
"heapUsedBytes": 281246528,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 122.96099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.93333333333333,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11523.891000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11370.428,
"heapDeltaBytes": 27585980,
"heapUsedBytes": 276318316,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 156.11799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.575268817204304,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11397.289999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10952.488000000001,
"heapDeltaBytes": -20161112,
"heapUsedBytes": 256909712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.053,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.03938356164384,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 474.2230000000518,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.642000000000001,
"layouts": 11,
"layoutDurationMs": 4.1770000000000005,
"taskDurationMs": 137.742,
"heapDeltaBytes": 7065528,
"heapUsedBytes": 67289344,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.482999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 133.46200000000863,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.408,
"layouts": 9,
"layoutDurationMs": 3.7359999999999998,
"taskDurationMs": 92.15099999999998,
"heapDeltaBytes": 4659936,
"heapUsedBytes": 72762224,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.232000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 407.75700000006054,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.603,
"layouts": 76,
"layoutDurationMs": 13.799999999999999,
"taskDurationMs": 359.8,
"heapDeltaBytes": -1902692,
"heapUsedBytes": 43498836,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 172.63400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 482.98299999999017,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.63,
"layouts": 76,
"layoutDurationMs": 14.55,
"taskDurationMs": 431.802,
"heapDeltaBytes": -4237440,
"heapUsedBytes": 39708904,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 211.82799999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 495.54700000010143,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.519,
"layouts": 76,
"layoutDurationMs": 13.591000000000001,
"taskDurationMs": 461.69300000000004,
"heapDeltaBytes": 543096,
"heapUsedBytes": 90061464,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 182.85999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 739.7169999999278,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.115,
"layouts": 76,
"layoutDurationMs": 20.907,
"taskDurationMs": 668.5690000000001,
"heapDeltaBytes": 164800,
"heapUsedBytes": 90649056,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 245.39799999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.29268292682927,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d2fc9ae60f4cd796237ff02c7abe79c4735a394c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.59 #22378 +/- ##
=============================================
- Coverage 87.12% 87.12% -0.01%
=============================================
Files 3027 3027
Lines 158712 158722 +10
Branches 40187 42347 +2160
=============================================
+ Hits 138283 138291 +8
- Misses 19753 19755 +2
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit c951b1b has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #22222 to
core/1.59. Clean cherry-pick (-x), no conflicts.The 1.59 copies of #21327 already merged (#22248, #22249); this adds the matching follow-up so the superseded-answer report carries
ask_kindon 1.59 too.Local:
useAgentSession.test.ts+agentConversationStore.test.ts409 passed with the change; 9 of the new tests fail without it.Fixes FRONT-3663