Repository navigation
[backport core/1.58] feat(extensions): mark agent-created extensions in the Extensions panel (#21950) - #22374
christian-byrne wants to merge 1 commit into
Conversation
…el (#21950) ## Summary Users can now find extensions the agent made. In Settings › Extensions, an extension that declares `provenance.createdBy: 'comfy-agent'` or uses the `agent.<pack>.` name prefix shows a **Created by agent** badge and its provenance summary. A new **Agent-created** filter lists only those, and **Disable all agent-created** sits next to **Disable Third-Party** in the actions menu. This is the part of #21787 that needs no policy decision. It adds no new setting, no new store write path, and no new cross-domain import. The bulk action reuses the existing `Comfy.Extension.Disabled` path that **Disable Third-Party** already uses, so a disable takes effect on reload exactly as other disables do today. Disabling a whole pack before import (FE-3474, #21934), the first-load toast, sidebar badges, the `?filter=agent` deep link, and lost-response persistence stay in #21787 for their owner decisions. Linear: https://linear.app/comfyorg/issue/FE-3475 ## Verification - Black-box: `browser_tests/tests/settings/agentExtensionProvenance.spec.ts` (Chromium, local backend). On `main` it fails at `getByText('Created by agent')`; on this branch it passes. Its first two steps are unchanged from #21787's spec, and a third step disables every agent-created extension and checks the persisted `Comfy.Extension.Disabled` value. - Unit: `ExtensionPanel.test.ts` and `extensionStore.test.ts`, 23/23. The two new cases fail on `main`. Removing the `agent.` prefix branch fails the store case, and `agentic.toolbar` checks that a near-miss name is not attributed. - `pnpm typecheck:app`, `pnpm typecheck:browser`, oxfmt, type-aware oxlint, and the pre-commit and pre-push hooks pass (Fallow: no issues in the 8 changed files). (cherry picked from commit 32f8edb)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
🎭 Playwright: ✅ 2988 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6d2dea681075bbbcb18714c01dc47344f6cf868
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (136)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
Superseded by #22375 after re-reading live product pins: ComfyUI v0.43.0 uses frontend 1.57.4, current master uses 1.57.6, and Desktop stable resolves the latest stable Core tag. The core/1.57 carrier is therefore the immediate default local/Desktop release path. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22374 +/- ##
==========================================
Coverage 84.04% 84.04%
==========================================
Files 3175 3175
Lines 166036 166056 +20
Branches 39605 39612 +7
==========================================
+ Hits 139540 139561 +21
Misses 26104 26104
+ Partials 392 391 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #21950 to core/1.58 so the next 1.58 frontend package can identify, filter, and bulk-disable Agent-created extensions. The cherry-pick is clean and patch-identical to source commit 32f8edb (stable patch id c068fdb8b907435e5733696ebc3728ee694f705b).
Linear: https://linear.app/comfyorg/issue/FRONT-3664/release-reach-agent-catalog-notice-fe-3493-and-agent-pack-marking-fe
Verification