Skip to content

[backport core/1.58] feat(extensions): mark agent-created extensions in the Extensions panel (#21950) - #22374

Closed
christian-byrne wants to merge 1 commit into
core/1.58from
backport/oploop1051-front3664-core-1.58
Closed

christian-byrne wants to merge 1 commit into
core/1.58from
backport/oploop1051-front3664-core-1.58

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #21950 to core/1.58 so the next 1.58 frontend package can identify, filter, and bulk-disable Agent-created extensions. The cherry-pick is clean and patch-identical to source commit 32f8edb (stable patch id c068fdb8b907435e5733696ebc3728ee694f705b).

Linear: https://linear.app/comfyorg/issue/FRONT-3664/release-reach-agent-catalog-notice-fe-3493-and-agent-pack-marking-fe

Verification

  • Black-box target-parent proof: browser_tests/tests/settings/agentExtensionProvenance.spec.ts fails 2/2 on core/1.58 c6d2dea because the Created by agent UI and Disable all agent-created action are absent.
  • Black-box exact-head proof: the same Chromium spec passes 2/2 on f321e99.
  • Unit: ExtensionPanel.test.ts and extensionStore.test.ts pass 25/25 on f321e99.
  • Focused oxfmt and type-aware oxlint pass for all changed files.
  • Pre-push dependency-cruiser, knip, and changed-surface Fallow gates pass.

…el (#21950)

## Summary

Users can now find extensions the agent made. In Settings › Extensions,
an extension that declares `provenance.createdBy: 'comfy-agent'` or uses
the `agent.<pack>.` name prefix shows a **Created by agent** badge and
its provenance summary. A new **Agent-created** filter lists only those,
and **Disable all agent-created** sits next to **Disable Third-Party**
in the actions menu.

This is the part of #21787 that needs no policy decision. It adds no new
setting, no new store write path, and no new cross-domain import. The
bulk action reuses the existing `Comfy.Extension.Disabled` path that
**Disable Third-Party** already uses, so a disable takes effect on
reload exactly as other disables do today. Disabling a whole pack before
import (FE-3474, #21934), the first-load toast, sidebar badges, the
`?filter=agent` deep link, and lost-response persistence stay in #21787
for their owner decisions.

Linear: https://linear.app/comfyorg/issue/FE-3475

## Verification

- Black-box:
`browser_tests/tests/settings/agentExtensionProvenance.spec.ts`
(Chromium, local backend). On `main` it fails at `getByText('Created by
agent')`; on this branch it passes. Its first two steps are unchanged
from #21787's spec, and a third step disables every agent-created
extension and checks the persisted `Comfy.Extension.Disabled` value.
- Unit: `ExtensionPanel.test.ts` and `extensionStore.test.ts`, 23/23.
The two new cases fail on `main`. Removing the `agent.` prefix branch
fails the store case, and `agentic.toolbar` checks that a near-miss name
is not attributed.
- `pnpm typecheck:app`, `pnpm typecheck:browser`, oxfmt, type-aware
oxlint, and the pre-commit and pre-push hooks pass (Fallow: no issues in
the 8 changed files).

(cherry picked from commit 32f8edb)
@christian-byrne
christian-byrne requested a review from a team as a code owner October 30, 2026 09:19
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2286 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 673 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/30/2026, 09:21:13 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c6d2dea681075bbbcb18714c01dc47344f6cf868

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (136)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/workspaceApi.webSessionRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 86 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by #22375 after re-reading live product pins: ComfyUI v0.43.0 uses frontend 1.57.4, current master uses 1.57.6, and Desktop stable resolves the latest stable Core tag. The core/1.57 carrier is therefore the immediate default local/Desktop release path.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/platform/settings/components/ExtensionPanel.vue 94.73% 1 Missing ⚠️
@@            Coverage Diff             @@
##           core/1.58   #22374   +/-   ##
==========================================
  Coverage      84.04%   84.04%           
==========================================
  Files           3175     3175           
  Lines         166036   166056   +20     
  Branches       39605    39612    +7     
==========================================
+ Hits          139540   139561   +21     
  Misses         26104    26104           
+ Partials         392      391    -1     
Flag Coverage Δ
unit 85.98% <95.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/extensionStore.ts 97.77% <100.00%> (+0.27%) ⬆️
...rc/platform/settings/components/ExtensionPanel.vue 87.85% <94.73%> (+2.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants