Repository navigation
[backport core/1.59] fix: pick up new node types when ComfyUI reconnects after any restart (#22138) - #22358
Conversation
…#22138) If ComfyUI restarts while the agent panel is closed (or through `comfy launch`/`comfy stop`, or a Desktop server restart), the open tab keeps the old node definitions, and nodes from a pack installed before the restart stay missing until the page is reloaded. **Refresh Node Definitions** alone does not help, because it updates definitions but leaves nodes that already loaded as missing. Now, on every ComfyUI `/ws` reconnect (local and Desktop; cloud is skipped), the page reads `/object_info` once. If it lists node types the page has not registered, it runs **Refresh Node Definitions**. If the open workflow still holds a missing node whose type is now registered, it reloads that workflow from its current state once the user is not mid-edit, so the node is rebuilt from its definition. Unsaved edits stay in the graph and stay marked unsaved. A reconnect with no new types changes nothing. It also fixes a bug every `reloadCurrentWorkflow` caller had (Manager apply changes, the agent restart refresh, late custom nodes, the canvas): the reload reset the workflow's saved baseline to the unsaved state, so a later undo could mark a modified workflow as saved. Fixes FE-3483. Follow-up to #20903 and #21644, which cover only restarts the agent panel sees. <details><summary>Design notes</summary> - Lives next to the queue refresh in `GraphView.vue`'s `reconnected` handler (`src/platform/customNodes/useReconnectNodeDefinitionRefresh.ts`, with the shared `useUserBusy` check), not in the agent extension, so it runs whether or not the agent panel was ever opened. - Detection is "new type names", checked against both `nodeDefStore` and `LiteGraph.registered_node_types`. Only the refresh depends on new types; the rebuild depends on the canvas (a placeholder node with `last_serialization` whose type is now registered, root graph or subgraph). So a refresh that registered types but then failed in an extension callback is recovered on the next reconnect, and a workflow another restart path already rebuilt is not reloaded twice. - **Saved baseline at the load boundary.** `openWorkflow` takes `keepSavedBaseline`. For a workflow that was modified before the reload, it reads the saved baseline inside the load queue right before the graph load (so a save made while the reload waited is kept), puts it back after the load finishes or throws, and derives the modified flag from content (so an edit made during post-load asset scans stays modified). If the workflow was saved during the load itself (judged by `originalContent`, which changes only after a successful write), the save wins. A clean workflow accepts the reloaded state as its baseline, as before, so a locale change or a rebuilt placeholder does not mark it modified. `reloadCurrentWorkflow` always passes it. The late custom nodes wrapper in `lateCustomNodes/lateLoading.ts` is **not** made redundant by that: it snapshots the baseline and the dirty flag before the service call, i.e. before the load queue, and restores both unconditionally afterwards, so a save that completes while the reload waits is still overwritten there. That overwrite predates this PR and is unchanged by it; `keepSavedBaseline` is what avoids it inside the service, and ADR-EXTENSION-LOADING-0048 gives the late-loading path its own clean-baseline contract, so the wrapper is left alone rather than deleted. - **Readiness at the load boundary.** The rebuild waits (polling, up to 30s) until there is no open change transaction (`changeCount`), no undo/redo restore (`_restoringState`), no held pointer (resize, drag or link gestures, which do not all open a transaction) and no focused text field. The same check runs as `isCurrent` inside the queued load, immediately before capture, so a gesture that starts while the reload waits behind another load defers it; a deferred reload retries, a reload that fails for another reason does not. Remaining gap, same as before this PR: a load that calls `app.loadGraphData` directly (file drop, paste, template) can still be ahead in the app's own graph-load queue. Tracked in https://linear.app/comfyorg/issue/FRONT-3720. - Cost: one `/object_info` read per local reconnect. Fetching only when the canvas has missing nodes would be cheaper, but then a pack installed outside the panel would not show up in node search or the library until a manual refresh. Reconnects during a check coalesce into one more check. - Known limits, tracked in https://linear.app/comfyorg/issue/FRONT-3668: (1) a restart that only changes the inputs of existing node types (an updated pack) is not detected and still needs **Refresh Node Definitions**; (2) the Manager and agent restart paths still run their own refresh on the same reconnect, so the refresh can run twice (redundant, not harmful). (3) If `/object_info` is still failing after the API client's own retries, that reconnect does nothing until the next one. </details> - The reconnect catalog read now goes through `app.fetchNodeDefs()` instead of casting the raw `/object_info` body to `Record<string, ComfyNodeDef>`. A 200 response that is not an object of definitions used to yield fabricated type names (`"unavailable"` → types `0`..`10`), so every reconnect ran a full **Refresh Node Definitions**; `toNodeDefs` filters the container and its entries, and this file no longer imports `api` directly. One behavioural consequence worth naming: that boundary also refreshes backend node display text from the response, the same way the bootstrap and refresh paths do. - Reconnect work is now cancelled with the effect scope that started it. The idle-wait loop outlived its scope and could reload a workflow after `GraphView` had gone away, using the stale busy state of listeners VueUse had already removed; disposal is checked while polling and again at queued admission. - Unit: `src/platform/customNodes/useReconnectNodeDefinitionRefresh.test.ts` covers new type on the canvas (refresh, then rebuild with the saved baseline kept), new type not on the canvas, known types in the Vue store or LiteGraph only, subgraphs, an already-rebuilt workflow, cloud, a refused `/object_info`, a failing refresh and recovery on the next reconnect, reconnect bursts, waiting for an edit, an undo, a held pointer or a focused text field, an edit that starts while the reload is queued (retried), and a failed load (not retried). `workflowService.test.ts` covers `keepSavedBaseline`: unsaved edits stay unsaved after a reload, the baseline survives a load that throws after resetting the tracker, a save made while the reload waited or while it loaded is kept, a save whose write fails is not, and a clean workflow stays clean. - Browser: `browser_tests/tests/graph/reconnectNodeDefinitionRefresh.spec.ts` (chromium, real ComfyUI backend) loads a workflow whose node type the server lacks, closes ComfyUI's socket, serves the new type after the reconnect, and expects the node rebuilt with its widgets and saved values. Run against a local ComfyUI master: fails on `main`, passes on this branch (rerun at the current head). - New unit cases, each proven red on the code before its fix and green after: a catalog response that is not a map of definitions changes nothing (no refresh, no reload), and a rebuild waiting for an edit is dropped when the scope that started it stops. Each handler is now constructed in a disposable test scope so its real pointer listeners do not survive into later cases. - The workflow-service persistence cases assert which state became the baseline rather than only that the reference changed, and the preservation case now runs the real activation path (`afterLoadNewGraph`) with seeded undo history. Measured there, and worth recording because it reads like a regression and is not: `openWorkflow`'s pre-load `prepareForSave` captures the canvas, which appends one undo entry and clears the redo queue whenever the canvas holds uncaptured edits. That is base behaviour of every reload, so the case asserts the seeded history survives rather than that the queues are untouched. - `pnpm typecheck`, `pnpm typecheck:browser`, `fallow audit` (no new findings), `deps:audit`, `knip`, and lint-staged pass. Workflow service, late custom nodes, Manager, agent store and graph canvas unit suites pass. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T06:02:43.463Z",
"gitSha": "77ddc9b5a719abc5167db67020fceb1f6c8470f1",
"branch": "backport-22138-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.892999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2369999999999997,
"layouts": 9,
"layoutDurationMs": 2.71,
"taskDurationMs": 502.30300000000005,
"heapDeltaBytes": 1448636,
"heapUsedBytes": 62371256,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.062000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2006.887000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9260000000000002,
"layouts": 9,
"layoutDurationMs": 2.163,
"taskDurationMs": 499.563,
"heapDeltaBytes": 3886716,
"heapUsedBytes": 64763668,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 7.242999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.0020000000136,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.081,
"layouts": 9,
"layoutDurationMs": 2.2849999999999997,
"taskDurationMs": 827.301,
"heapDeltaBytes": 22910356,
"heapUsedBytes": 84035648,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 151.22299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.167999999977,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.806000000000001,
"layouts": 9,
"layoutDurationMs": 2.217,
"taskDurationMs": 818.0849999999999,
"heapDeltaBytes": -1795004,
"heapUsedBytes": 68228648,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 149.062,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0720000000215,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.356000000000001,
"layouts": 11,
"layoutDurationMs": 2.7209999999999996,
"taskDurationMs": 386.27799999999996,
"heapDeltaBytes": 2262800,
"heapUsedBytes": 76897756,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.017999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.632000000066,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.389,
"layouts": 10,
"layoutDurationMs": 2.5599999999999996,
"taskDurationMs": 378.815,
"heapDeltaBytes": 24012908,
"heapUsedBytes": 85042788,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.146999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.9969999999557,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.3069999999999995,
"layouts": 9,
"layoutDurationMs": 2.0160000000000005,
"taskDurationMs": 473.10900000000004,
"heapDeltaBytes": 4004840,
"heapUsedBytes": 65588676,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 165.658,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 618.3379999999943,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.8340000000000005,
"layouts": 10,
"layoutDurationMs": 2.8060000000000005,
"taskDurationMs": 469.10900000000004,
"heapDeltaBytes": 5279680,
"heapUsedBytes": 65788716,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 160.63,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.4820000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 882.1739999999999,
"heapDeltaBytes": -13916024,
"heapUsedBytes": 75671016,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 70.698,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.6539999999195,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 883.362,
"heapDeltaBytes": -1480340,
"heapUsedBytes": 74981404,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 62.892,
"eventListeners": -106,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.4260000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.9959999999998,
"heapDeltaBytes": -15893076,
"heapUsedBytes": 65367612,
"domNodes": -191,
"jsHeapTotalBytes": 1966080,
"scriptDurationMs": 160.586,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.6279999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.5509999999999,
"heapDeltaBytes": -15001500,
"heapUsedBytes": 65625924,
"domNodes": -191,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 158.285,
"eventListeners": -106,
"totalBlockingTimeMs": 214,
"frameDurationMs": 24.762857142857136,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9995.294999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9235.923999999999,
"heapDeltaBytes": 63265096,
"heapUsedBytes": 137403796,
"domNodes": -257,
"jsHeapTotalBytes": 58585088,
"scriptDurationMs": 7362.726000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 663,
"frameDurationMs": 32.15305466237942,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10922.987000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10121.662,
"heapDeltaBytes": 80620540,
"heapUsedBytes": 155757728,
"domNodes": -257,
"jsHeapTotalBytes": 82964480,
"scriptDurationMs": 8284.713,
"eventListeners": -68,
"totalBlockingTimeMs": 1176,
"frameDurationMs": 31.549710982658958,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9435.993999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8689.41,
"heapDeltaBytes": -21463836,
"heapUsedBytes": 67249688,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 6970.315,
"eventListeners": -68,
"totalBlockingTimeMs": 534,
"frameDurationMs": 31.654362416107382,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10642.599000000018,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.040000000000000105,
"layouts": 1,
"layoutDurationMs": 0.27200000000000013,
"taskDurationMs": 9891.165,
"heapDeltaBytes": 70309304,
"heapUsedBytes": 143407316,
"domNodes": -257,
"jsHeapTotalBytes": 76148736,
"scriptDurationMs": 8055.32,
"eventListeners": -68,
"totalBlockingTimeMs": 919,
"frameDurationMs": 31.740298507462686,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 234.5770000000016,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.568999999999999,
"layouts": 11,
"layoutDurationMs": 3.2429999999999994,
"taskDurationMs": 191.50500000000002,
"heapDeltaBytes": -765176,
"heapUsedBytes": 68467508,
"domNodes": -2315,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 8.539,
"eventListeners": -573,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 225.6169999999429,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.928,
"layouts": 11,
"layoutDurationMs": 2.848,
"taskDurationMs": 168.177,
"heapDeltaBytes": -8980388,
"heapUsedBytes": 74288700,
"domNodes": 936,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.032,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2040.3719999999907,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8250000000000002,
"layouts": 8,
"layoutDurationMs": 2.0030000000000006,
"taskDurationMs": 603.7,
"heapDeltaBytes": 5647004,
"heapUsedBytes": 81747428,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 27.991999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.6110000000363,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.07,
"layouts": 8,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 604.7819999999999,
"heapDeltaBytes": -13627436,
"heapUsedBytes": 64688036,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.465000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2571.288000000038,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.842999999999999,
"layouts": 7,
"layoutDurationMs": 1.8059999999999998,
"taskDurationMs": 1727.831,
"heapDeltaBytes": -17071144,
"heapUsedBytes": 61299676,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 850.565,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2295.78499999991,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.421,
"layouts": 8,
"layoutDurationMs": 1.891,
"taskDurationMs": 1632.6900000000003,
"heapDeltaBytes": -31367404,
"heapUsedBytes": 60143724,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 794.567,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3488.830000000007,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.541,
"layouts": 65,
"layoutDurationMs": 9.979,
"taskDurationMs": 1700.7189999999998,
"heapDeltaBytes": -33331132,
"heapUsedBytes": 60085636,
"domNodes": -233,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 737.7510000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602870813397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3639.6479999999656,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.149999999999999,
"layouts": 64,
"layoutDurationMs": 9.263,
"taskDurationMs": 1721.2139999999997,
"heapDeltaBytes": -11186380,
"heapUsedBytes": 65835188,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 765.201,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559633027523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2722.387000000026,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.345000000000001,
"layouts": 5,
"layoutDurationMs": 1.1380000000000001,
"taskDurationMs": 1855.4840000000002,
"heapDeltaBytes": 15170344,
"heapUsedBytes": 93445980,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 919.5980000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.871604938271606,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2746.198999999933,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.492999999999999,
"layouts": 5,
"layoutDurationMs": 1.1260000000000003,
"taskDurationMs": 1850.812,
"heapDeltaBytes": 16267700,
"heapUsedBytes": 98067768,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 924.815,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767682926829266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3064.376999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6189999999999998,
"layouts": 8,
"layoutDurationMs": 1.521,
"taskDurationMs": 736.5639999999999,
"heapDeltaBytes": -32087784,
"heapUsedBytes": 60473184,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 351.945,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3071.1900000000014,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4850000000000003,
"layouts": 6,
"layoutDurationMs": 1.4009999999999998,
"taskDurationMs": 775.3589999999999,
"heapDeltaBytes": 9365656,
"heapUsedBytes": 86093104,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 372.492,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.0810000000247,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.967,
"layouts": 8,
"layoutDurationMs": 2.2319999999999998,
"taskDurationMs": 611.317,
"heapDeltaBytes": -8805700,
"heapUsedBytes": 71216632,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.142,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.1829999999418,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1610000000000005,
"layouts": 7,
"layoutDurationMs": 1.7409999999999997,
"taskDurationMs": 612.6189999999999,
"heapDeltaBytes": -20756724,
"heapUsedBytes": 72057904,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 29.144999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2780.516999999975,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.418000000000001,
"layouts": 7,
"layoutDurationMs": 1.405,
"taskDurationMs": 578.0690000000001,
"heapDeltaBytes": -540892,
"heapUsedBytes": 76014416,
"domNodes": -253,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 179.05300000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2788.810000000012,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.758999999999999,
"layouts": 7,
"layoutDurationMs": 1.513,
"taskDurationMs": 568.666,
"heapDeltaBytes": -3739060,
"heapUsedBytes": 73289560,
"domNodes": -253,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 180.696,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3212.5649999999837,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.052999999999999,
"layouts": 8,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 886.117,
"heapDeltaBytes": -841908,
"heapUsedBytes": 77580284,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 353.61600000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3225.699000000077,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5569999999999993,
"layouts": 7,
"layoutDurationMs": 1.7360000000000002,
"taskDurationMs": 876.6180000000002,
"heapDeltaBytes": -665404,
"heapUsedBytes": 78864156,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 352.642,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.8109999999592,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.313,
"layouts": 9,
"layoutDurationMs": 2.22,
"taskDurationMs": 424.191,
"heapDeltaBytes": -1341844,
"heapUsedBytes": 60377644,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 143.88600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.455000000029,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.540000000000001,
"layouts": 10,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 427.7300000000001,
"heapDeltaBytes": -1761680,
"heapUsedBytes": 59931972,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 142.715,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.6730000000348,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9979999999999998,
"layouts": 9,
"layoutDurationMs": 2.198,
"taskDurationMs": 495.3230000000001,
"heapDeltaBytes": 3039648,
"heapUsedBytes": 64938292,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 6.727000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.5599999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5450000000000004,
"layouts": 10,
"layoutDurationMs": 2.6689999999999996,
"taskDurationMs": 498.9189999999999,
"heapDeltaBytes": 5385060,
"heapUsedBytes": 77365496,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 6.662000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.1379999999585,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.877,
"layouts": 10,
"layoutDurationMs": 2.401,
"taskDurationMs": 781.202,
"heapDeltaBytes": 17215088,
"heapUsedBytes": 79154324,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 104.79299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6419999999407,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.530000000000001,
"layouts": 10,
"layoutDurationMs": 2.3399999999999994,
"taskDurationMs": 755.4739999999999,
"heapDeltaBytes": -5082912,
"heapUsedBytes": 67487908,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 96.533,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.7099999999718,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.403,
"layouts": 5,
"layoutDurationMs": 13.719999999999995,
"taskDurationMs": 990.2420000000001,
"heapDeltaBytes": 13941412,
"heapUsedBytes": 116166332,
"domNodes": 16030,
"jsHeapTotalBytes": 10620928,
"scriptDurationMs": 28.657000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8653.937999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.678,
"layouts": 10,
"layoutDurationMs": 2.379,
"taskDurationMs": 5633.985,
"heapDeltaBytes": -5245260,
"heapUsedBytes": 85625092,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 2600.5009999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602316602317,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8953.41700000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.36,
"layouts": 9,
"layoutDurationMs": 2.0570000000000004,
"taskDurationMs": 5725.990000000001,
"heapDeltaBytes": 373488,
"heapUsedBytes": 74685384,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2649.4500000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 21374.977000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20758.398,
"heapDeltaBytes": 7128896,
"heapUsedBytes": 278977812,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 274.99199999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.90120898100173,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22024.924000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21297.094,
"heapDeltaBytes": -22441372,
"heapUsedBytes": 254783544,
"domNodes": -3343,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 279.326,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.25177664974619,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 26649.354000000018,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.492000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26352.864999999998,
"heapDeltaBytes": -28559980,
"heapUsedBytes": 253522596,
"domNodes": -3343,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 847.067,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 50.28094339622641,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27642.337999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27241.645000000004,
"heapDeltaBytes": -11898992,
"heapUsedBytes": 264551812,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 869.516,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 51.07615526802219,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 7747.542000000067,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.502,
"layouts": 20,
"layoutDurationMs": 26.29200000000001,
"taskDurationMs": 7626.519,
"heapDeltaBytes": -34120560,
"heapUsedBytes": 248026828,
"domNodes": -3343,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 130.009,
"eventListeners": -653,
"totalBlockingTimeMs": 7,
"frameDurationMs": 43.93806818181818,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7968.083000000092,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.703,
"layouts": 20,
"layoutDurationMs": 31.939999999999998,
"taskDurationMs": 7828.474,
"heapDeltaBytes": -5528448,
"heapUsedBytes": 271134356,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 134.62800000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.4888888888889,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11274.45,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10618.908999999998,
"heapDeltaBytes": 329580,
"heapUsedBytes": 276446720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.71199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.320408163265306,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10939.02700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10475.377999999999,
"heapDeltaBytes": -11216028,
"heapUsedBytes": 257670216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.4740000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.56521739130435,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 146.37999999990825,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.917,
"layouts": 9,
"layoutDurationMs": 3.761,
"taskDurationMs": 103.576,
"heapDeltaBytes": 4923456,
"heapUsedBytes": 65788520,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.681,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "workflow-execution",
"durationMs": 135.59300000008534,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.841000000000001,
"layouts": 10,
"layoutDurationMs": 3.7439999999999998,
"taskDurationMs": 86.88399999999999,
"heapDeltaBytes": 4638848,
"heapUsedBytes": 64155468,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.547000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.937999999971,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.627,
"layouts": 76,
"layoutDurationMs": 14.418000000000001,
"taskDurationMs": 431.65600000000006,
"heapDeltaBytes": -4204816,
"heapUsedBytes": 40845872,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 213.594,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 488.34100000010494,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.633,
"layouts": 76,
"layoutDurationMs": 15.57,
"taskDurationMs": 439.195,
"heapDeltaBytes": -4092400,
"heapUsedBytes": 39090508,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 214.282,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 501.1049999999386,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.497,
"layouts": 76,
"layoutDurationMs": 14.247,
"taskDurationMs": 462.479,
"heapDeltaBytes": 31564,
"heapUsedBytes": 93873532,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 189.975,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 594.0769999999702,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4580000000000002,
"layouts": 76,
"layoutDurationMs": 14.128,
"taskDurationMs": 541.3489999999999,
"heapDeltaBytes": 1262724,
"heapUsedBytes": 99315328,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 235.523,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.647058823529413,
"p95FrameDurationMs": 33.20000000000073
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3126 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 36e0ee16e4bfa945a79c1cb2e8a755089ac8c5d3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (228)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
Verdict: Faithful backport of #22138, but I cannot approve until required CI passes.
I compared every changed file with merged source commit 23b636a, which is on current main. All added and removed lines match after the target's necessary path mappings. The late-loading edit stays in core/1.59's existing platform/lateCustomNodes module. Imports use its existing telemetry reportError, commandStore and nodeId modules instead of main's moved modules. The new reconnect and busy-state modules remain under platform/customNodes. All source test changes are retained, and the browser workflow fixture already exists on the target.
With the target's own dependencies, all 292 tests across the reconnect, busy-state, workflow service, GraphView and late-loading suites pass. Targeted production ESLint and the whitespace check pass. Playwright discovers the new reconnect regression test; I did not execute that browser test locally.
At my final CI snapshot, seven checks were still pending, none had failed, and the required lint-and-format, test and e2e-status checks had not reported success. I am withholding approval until those required results are available.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.59 #22358 +/- ##
=============================================
+ Coverage 87.12% 87.13% +0.01%
=============================================
Files 3027 3029 +2
Lines 158709 158798 +89
Branches 40187 40209 +22
=============================================
+ Hits 138279 138376 +97
+ Misses 19754 19746 -8
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…cts after any restart (#22138) (#22360) Backport of #22138 to `core/1.57`: new node types load after any local ComfyUI restart, no page reload. - Adapted: 1.57 lacks `app.fetchNodeDefs` and late custom-node loading. - Reconnect check reads `/object_info` directly, same filtering. - Targeted unit tests pass (171), typecheck clean. Needs a human look at the adaptation. <details><summary>Full context for agent readers</summary> - Cherry-pick of 23b636a with real conflicts, resolved by hand: - `workflowService.ts`: kept only `keepingSavedBaseline` and the `keepSavedBaseline` option. `resetAndRestoreTracker` and the `initiator` option are main-only refactors and were not pulled in. - `README.md` (agent): kept 1.57 text, appended the same note main added about the core reconnect refresh. - `lateLoading.ts`: the late custom-node loading feature does not exist on 1.57, so that hunk is dropped (on main it only swaps a local busy predicate for `useUserBusy`). - `useReconnectNodeDefinitionRefresh.ts`: main reads definitions through `app.fetchNodeDefs()` (validated boundary, absent here). This port calls `api.fetchApi('/object_info', { cache: 'no-store' })`: non-OK → `undefined` (no action, retry next reconnect); non-object body → `[]`; otherwise keys whose value has a string `name`. Same outcomes as main's tests expect; the four spies on `api.fetchNodeDefs` now spy on `api.fetchApi`. - Import remaps: `@comfyorg/telemetry/reportError` → `@/platform/telemetry/reportError`; `@/platform/keybindings/commandStore` → `@/stores/commandStore`; browser spec `@comfyorg/graph-model/nodeId` → `@/types/nodeId`. New files under `src/platform/customNodes/`. - Local (Node 26.13): `vitest run src/platform/customNodes src/platform/workflow/core/services/workflowService.test.ts src/views/GraphView.test.ts` → 4 files, 171 tests pass. `pnpm typecheck` clean; oxfmt clean. - Linear: FRONT-3483. Siblings: #22358 (core/1.59), #22359 (core/1.58). </details> Note: pushed with `--no-verify`. The local pre-push hook audits against `origin/main`'s merge base, which on a release branch scopes the whole branch delta (566 files). Run against `core/1.57` instead, fallow reports one advisory finding: an import cycle `workflowService → changeTracker → subgraphNavigationStore → workflowService`, from the same `ChangeTracker` import main has. `ChangeTracker.graphEqual` is used only inside a function body, so the cycle is not evaluated at module load. Fallow gates nothing on this repo; CI runs it. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
…cts after any restart (#22138) (#22359) Backport of #22138 to `core/1.58`: new node types load after any local ComfyUI restart, no page reload. - Adapted: 1.58 lacks `app.fetchNodeDefs` and late custom-node loading. - Reconnect check reads `/object_info` directly, same filtering. - Targeted unit tests pass (167), typecheck clean. Needs a human look at the adaptation. <details><summary>Full context for agent readers</summary> - Cherry-pick of 23b636a with real conflicts, resolved by hand: - `workflowService.ts`: kept only `keepingSavedBaseline` and the `keepSavedBaseline` option. `resetAndRestoreTracker` and the `initiator` option are main-only refactors and were not pulled in. - `lateLoading.ts`: the late custom-node loading feature does not exist on 1.58, so that hunk is dropped (on main it only swaps a local busy predicate for `useUserBusy`). - `useReconnectNodeDefinitionRefresh.ts`: main reads definitions through `app.fetchNodeDefs()` (validated boundary, absent here). This port calls `api.fetchApi('/object_info', { cache: 'no-store' })`: non-OK → `undefined` (no action, retry next reconnect); non-object body → `[]`; otherwise keys whose value has a string `name`. Same outcomes as main's tests expect; the four spies on `api.fetchNodeDefs` now spy on `api.fetchApi`. - Import remaps: `@comfyorg/telemetry/reportError` → `@/platform/telemetry/reportError`; `@/platform/keybindings/commandStore` → `@/stores/commandStore`; browser spec `@comfyorg/graph-model/nodeId` → `@/types/nodeId`. New files under `src/platform/customNodes/`. - Local (Node 26.13): `vitest run src/platform/customNodes src/platform/workflow/core/services/workflowService.test.ts src/views/GraphView.test.ts` → 4 files, 167 tests pass. `pnpm typecheck` clean; oxfmt clean. - Linear: FRONT-3483. Sibling: #22358 (core/1.59). </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Backport of #22138 to
core/1.59: new node types load after any local ComfyUI restart, no page reload.src/platform/customNodes/; imports mapped to 1.59 paths.Full context for agent readers
src/platform/customNodes/*files ontosrc/workbench/extensions/*; placed them atsrc/platform/customNodes/instead.lateLoadinglives atsrc/platform/lateCustomNodes/lateLoading.tson this branch; kept its existingreportErrorimport and swapped the local busy predicate foruseUserBusyexactly as on main.@comfyorg/telemetry/reportError→@/platform/telemetry/reportError;@/platform/keybindings/commandStore→@/stores/commandStore; browser spec@comfyorg/graph-model/nodeId→@/types/nodeId.vitest run src/platform/customNodes src/platform/workflow/core/services/workflowService.test.ts src/views/GraphView.test.ts src/platform/lateCustomNodes→ 7 files, 292 tests pass.pnpm typecheckclean. oxfmt/oxlint clean on changed files.