Repository navigation
[backport core/1.59] FE-3099 fix(auth): open each local web sign-in popup in its own window - #22346
Conversation
#22335) ## Why Follow-up to Christian's non-blocking note on #22179: the local web sign-in popup used the fixed target name `comfy-local-web-sign-in`, so a concurrent sign-in from another tab could take over the same popup. ## Root cause `window.open(url, name)` reuses an existing window with that name from the same browsing context group. A ComfyUI tab opened from another ComfyUI tab (link, `window.open`) is in the same group, so its sign-in found the first tab's popup and navigated it to its own authorize URL. Only one popup and one code exchange happened; the first tab's attempt was overwritten. Tabs the user opens independently are in separate groups and were not affected. ## How - `openPopup` uses `_blank`, so every attempt gets its own window. `window.opener` is kept (no `noopener`), so `local-callback.html` still posts back to the tab that started the attempt. - New unit test: two bridges sign in at once on a shared token store, each hearing both callbacks; each finishes only from its own popup with its own code, and neither reports a failure. Removing the popup-source check turns it red. ## AS IS / TO BE Real Chromium, this branch's dev server, ComfyUI on :8188, a stand-in Cloud issuer serving `oauth/local-callback.html`. Tab B opened from tab A; Continue with SSO clicked in A, then in B; consent in each popup. | | AS IS (fixed name) | TO BE (`_blank`) | |---|---|---| | Popups opened | 1 (B retargeted A's popup) | 2 (opener A, opener B) | | Code exchanges | 1 (`ws-personal`) | 2 (`ws-personal`, `ws-team-a`) | | Tab B workspace | `ws-personal` (not what B chose) | `ws-team-a` | | Failure toasts | none | none | Two independently opened tabs behave the same before and after (2 popups, 2 exchanges). All 9 popup scenarios from #22179's verification (success, refused exchange, popup closed, switch to unkept/kept workspace, refused kept refresh, sign-out during popup, cross-tab forget, late refused refresh) give the same results on this branch.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T03:45:48.559Z",
"gitSha": "f92ebeab2e729c321e38453555a1bbf774bf23f4",
"branch": "backport-22335-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.176000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5580000000000003,
"layouts": 10,
"layoutDurationMs": 3.4040000000000004,
"taskDurationMs": 585.6870000000001,
"heapDeltaBytes": 2922472,
"heapUsedBytes": 64545312,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 10.896999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.0770000000339,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.312,
"layouts": 9,
"layoutDurationMs": 2.9380000000000006,
"taskDurationMs": 640.4069999999999,
"heapDeltaBytes": 1439024,
"heapUsedBytes": 63313628,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 13.549999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.1409999999926,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.141,
"layouts": 9,
"layoutDurationMs": 2.725,
"taskDurationMs": 960.4699999999999,
"heapDeltaBytes": -1731032,
"heapUsedBytes": 68184284,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 176.05599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.9339999999802,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.064999999999998,
"layouts": 6,
"layoutDurationMs": 1.6629999999999996,
"taskDurationMs": 950.2730000000001,
"heapDeltaBytes": 22805660,
"heapUsedBytes": 83783452,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 174.17,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5699999999715,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.486,
"layouts": 9,
"layoutDurationMs": 3.362,
"taskDurationMs": 465.743,
"heapDeltaBytes": 24062040,
"heapUsedBytes": 85146944,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.358000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9849999999806,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.072000000000001,
"layouts": 11,
"layoutDurationMs": 3.779,
"taskDurationMs": 476.59799999999996,
"heapDeltaBytes": -30892,
"heapUsedBytes": 71031760,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 14.671,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 724.6069999999918,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.6319999999999997,
"layouts": 8,
"layoutDurationMs": 2.106,
"taskDurationMs": 523.4859999999999,
"heapDeltaBytes": 3758760,
"heapUsedBytes": 64826472,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 178.257,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 794.0969999999652,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2250000000000005,
"layouts": 9,
"layoutDurationMs": 2.926,
"taskDurationMs": 557.6999999999999,
"heapDeltaBytes": 7403620,
"heapUsedBytes": 77384020,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 187.063,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668085106382982,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.873999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 949.3,
"heapDeltaBytes": -2219760,
"heapUsedBytes": 75062256,
"domNodes": -191,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 75.56400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 542,
"frameDurationMs": 33.335135135135125,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1335.2919999999813,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1064.862,
"heapDeltaBytes": -12423908,
"heapUsedBytes": 75409800,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 81.519,
"eventListeners": -106,
"totalBlockingTimeMs": 637,
"frameDurationMs": 35.084210526315786,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.2910000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.9449999999999,
"heapDeltaBytes": -15498120,
"heapUsedBytes": 65188944,
"domNodes": -191,
"jsHeapTotalBytes": 1966080,
"scriptDurationMs": 182.68,
"eventListeners": -106,
"totalBlockingTimeMs": 241,
"frameDurationMs": 25.000000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 925.3839999998945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.4149999999997,
"heapDeltaBytes": -32006740,
"heapUsedBytes": 65630192,
"domNodes": -191,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 185.64999999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 229,
"frameDurationMs": 24.77297297297296,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10904.320999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10065.208,
"heapDeltaBytes": 62384628,
"heapUsedBytes": 136071252,
"domNodes": -257,
"jsHeapTotalBytes": 70381568,
"scriptDurationMs": 8087.593,
"eventListeners": -68,
"totalBlockingTimeMs": 1133,
"frameDurationMs": 30.964772727272727,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11085.697000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10316.043,
"heapDeltaBytes": -10976124,
"heapUsedBytes": 77327860,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 8391.019,
"eventListeners": -68,
"totalBlockingTimeMs": 1291,
"frameDurationMs": 31.847413793103446,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11889.476000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11022.571000000002,
"heapDeltaBytes": 74749976,
"heapUsedBytes": 148943168,
"domNodes": -257,
"jsHeapTotalBytes": 76410880,
"scriptDurationMs": 9008.318000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1764,
"frameDurationMs": 32.37847411444142,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11168.637000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10347.577000000001,
"heapDeltaBytes": 72279500,
"heapUsedBytes": 155163272,
"domNodes": -257,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 8275.327000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1140,
"frameDurationMs": 31.277591036414563,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "large-combo-open",
"durationMs": 227.27800000001253,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.537999999999998,
"layouts": 8,
"layoutDurationMs": 3.0429999999999997,
"taskDurationMs": 176.80799999999996,
"heapDeltaBytes": 14637740,
"heapUsedBytes": 72784968,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.792,
"eventListeners": 205,
"totalBlockingTimeMs": 9,
"frameDurationMs": 25.922222222222192,
"p95FrameDurationMs": 100.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 289.6149999999693,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.647000000000002,
"layouts": 11,
"layoutDurationMs": 4.631000000000001,
"taskDurationMs": 256.08700000000005,
"heapDeltaBytes": -9679524,
"heapUsedBytes": 66621836,
"domNodes": -2315,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.313,
"eventListeners": -573,
"totalBlockingTimeMs": 5,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2073.896999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8340000000000005,
"layouts": 8,
"layoutDurationMs": 2.7079999999999993,
"taskDurationMs": 734.783,
"heapDeltaBytes": -30564264,
"heapUsedBytes": 60198080,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 37.775999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66693548387097,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.9309999999914,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5199999999999987,
"layouts": 8,
"layoutDurationMs": 2.6359999999999997,
"taskDurationMs": 762.576,
"heapDeltaBytes": -24175876,
"heapUsedBytes": 66941872,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 35.508,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2942.264000000023,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.659,
"layouts": 7,
"layoutDurationMs": 2.291,
"taskDurationMs": 1910.1409999999998,
"heapDeltaBytes": 4996444,
"heapUsedBytes": 80754128,
"domNodes": -257,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 911.018,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2766.5530000000444,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.436,
"layouts": 7,
"layoutDurationMs": 1.9939999999999998,
"taskDurationMs": 1810.682,
"heapDeltaBytes": -6587736,
"heapUsedBytes": 72255320,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 865.272,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86890243902439,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3942.1689999999785,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.366999999999997,
"layouts": 63,
"layoutDurationMs": 11.09,
"taskDurationMs": 1956.1299999999999,
"heapDeltaBytes": 7487984,
"heapUsedBytes": 84049280,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 841.776,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665822784810125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3948.792000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.654,
"layouts": 64,
"layoutDurationMs": 11.067,
"taskDurationMs": 1928.217,
"heapDeltaBytes": 4232356,
"heapUsedBytes": 83273532,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 829.68,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3241.2279999999782,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.817,
"layouts": 6,
"layoutDurationMs": 1.702,
"taskDurationMs": 2118.161,
"heapDeltaBytes": -2014528,
"heapUsedBytes": 80135564,
"domNodes": -257,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 1001.355,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838341968911916,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3225.2979999999525,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.726999999999999,
"layouts": 6,
"layoutDurationMs": 1.8129999999999995,
"taskDurationMs": 2122.073,
"heapDeltaBytes": -12227800,
"heapUsedBytes": 70459352,
"domNodes": 0,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 1043.0759999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.926562500000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3171.779000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9429999999999994,
"layouts": 7,
"layoutDurationMs": 1.8899999999999997,
"taskDurationMs": 890.011,
"heapDeltaBytes": -13824136,
"heapUsedBytes": 78889316,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 405.658,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3118.4970000000476,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.985999999999999,
"layouts": 7,
"layoutDurationMs": 2.087,
"taskDurationMs": 872.4350000000001,
"heapDeltaBytes": -1759692,
"heapUsedBytes": 80141672,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 393.586,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.1489999999808,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4920000000000004,
"layouts": 7,
"layoutDurationMs": 2.179,
"taskDurationMs": 725.4280000000001,
"heapDeltaBytes": -12414312,
"heapUsedBytes": 64266840,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 41.543,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.9779999999246,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.389,
"layouts": 7,
"layoutDurationMs": 2.2729999999999997,
"taskDurationMs": 724.955,
"heapDeltaBytes": -13869540,
"heapUsedBytes": 67492744,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 39.818000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2995.7370000000196,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.005000000000003,
"layouts": 6,
"layoutDurationMs": 1.5819999999999996,
"taskDurationMs": 667.6100000000001,
"heapDeltaBytes": -1185072,
"heapUsedBytes": 75435212,
"domNodes": -253,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 205.967,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555557,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2962.3220000000288,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.696999999999997,
"layouts": 6,
"layoutDurationMs": 1.8050000000000002,
"taskDurationMs": 686.79,
"heapDeltaBytes": -2318312,
"heapUsedBytes": 73760064,
"domNodes": -253,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 215.42799999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66629213483146,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3369.7209999999986,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2700000000000002,
"layouts": 4,
"layoutDurationMs": 1.42,
"taskDurationMs": 1004.1999999999999,
"heapDeltaBytes": 2539240,
"heapUsedBytes": 79237192,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 409.221,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748756218905474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3438.742999999988,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8669999999999998,
"layouts": 6,
"layoutDurationMs": 1.8840000000000003,
"taskDurationMs": 1108.6260000000002,
"heapDeltaBytes": 6429416,
"heapUsedBytes": 86505592,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 428.23499999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747317073170734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.8709999999805,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.353,
"layouts": 9,
"layoutDurationMs": 2.4360000000000004,
"taskDurationMs": 461.563,
"heapDeltaBytes": 1379960,
"heapUsedBytes": 73864840,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 153.089,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.437000000039,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.071000000000001,
"layouts": 8,
"layoutDurationMs": 2.6990000000000003,
"taskDurationMs": 454.67300000000006,
"heapDeltaBytes": -1659676,
"heapUsedBytes": 60609484,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 150.436,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.4479999999924,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9309999999999996,
"layouts": 9,
"layoutDurationMs": 2.918,
"taskDurationMs": 619.146,
"heapDeltaBytes": 5404448,
"heapUsedBytes": 78241580,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 11.662000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.9370000000463,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4350000000000005,
"layouts": 9,
"layoutDurationMs": 3.3159999999999994,
"taskDurationMs": 623.928,
"heapDeltaBytes": 2986744,
"heapUsedBytes": 65377704,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 12.158999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.0490000000038,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.113000000000001,
"layouts": 9,
"layoutDurationMs": 2.4690000000000003,
"taskDurationMs": 910.6909999999999,
"heapDeltaBytes": -6183868,
"heapUsedBytes": 65661256,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 119.463,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.328999999988,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.764999999999999,
"layouts": 8,
"layoutDurationMs": 2.153,
"taskDurationMs": 905.4660000000001,
"heapDeltaBytes": 17454944,
"heapUsedBytes": 79876812,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 121.15299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.0239999999903,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.549999999999994,
"layouts": 5,
"layoutDurationMs": 15.179000000000002,
"taskDurationMs": 1208.5940000000003,
"heapDeltaBytes": 13988572,
"heapUsedBytes": 116144004,
"domNodes": 16030,
"jsHeapTotalBytes": 10096640,
"scriptDurationMs": 33.537000000000006,
"eventListeners": 3246,
"totalBlockingTimeMs": 163,
"frameDurationMs": 19.777333333333324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10054.645999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.099999999999998,
"layouts": 8,
"layoutDurationMs": 2.6560000000000006,
"taskDurationMs": 6261.539,
"heapDeltaBytes": -29417800,
"heapUsedBytes": 61131008,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 2805.2259999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666003316749585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10338.758999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.052,
"layouts": 8,
"layoutDurationMs": 2.2260000000000004,
"taskDurationMs": 6320.247,
"heapDeltaBytes": -3654996,
"heapUsedBytes": 73330408,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2853.838,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23306.684999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22919.347999999998,
"heapDeltaBytes": 5371848,
"heapUsedBytes": 282202692,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 334.81500000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.67996422182469,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23639.33700000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23233.534,
"heapDeltaBytes": -7044880,
"heapUsedBytes": 275351368,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 328.61899999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.763703703703705,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28638.499000000025,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.502999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28368.395,
"heapDeltaBytes": -51012072,
"heapUsedBytes": 250746568,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 926.405,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 53.250743494423794,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28508.360999999924,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.816000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28231.980000000003,
"heapDeltaBytes": -12573724,
"heapUsedBytes": 270027436,
"domNodes": -3343,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 938.2009999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 54.491395793499045,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8528.741000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.743,
"layouts": 20,
"layoutDurationMs": 26.29400000000001,
"taskDurationMs": 8413.226999999999,
"heapDeltaBytes": -16593596,
"heapUsedBytes": 266832768,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 179.86400000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.11468926553672,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8442.825000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.36200000000001,
"layouts": 20,
"layoutDurationMs": 25.927999999999994,
"taskDurationMs": 8327.283000000001,
"heapDeltaBytes": -12803440,
"heapUsedBytes": 276542536,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 126.583,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.644067796610166,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11635.25500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11405.960999999998,
"heapDeltaBytes": 8031956,
"heapUsedBytes": 263139068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.54300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.616433566433564,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11500.839000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11250.081000000002,
"heapDeltaBytes": 23698280,
"heapUsedBytes": 274710528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.4979999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.929166666666674,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 501.20400000002974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10.582,
"layouts": 10,
"layoutDurationMs": 3.9040000000000004,
"taskDurationMs": 132.618,
"heapDeltaBytes": 7091072,
"heapUsedBytes": 68158660,
"domNodes": 136,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.743000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 126.73199999994722,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.297999999999996,
"layouts": 9,
"layoutDurationMs": 3.6900000000000004,
"taskDurationMs": 92.639,
"heapDeltaBytes": 4617804,
"heapUsedBytes": 63955284,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.387000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000034,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 525.5650000000287,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.694,
"layouts": 76,
"layoutDurationMs": 15.890999999999998,
"taskDurationMs": 485.872,
"heapDeltaBytes": -3902060,
"heapUsedBytes": 39664916,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 234.03099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 498.04000000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.687,
"layouts": 76,
"layoutDurationMs": 15.322000000000001,
"taskDurationMs": 451.325,
"heapDeltaBytes": -4206496,
"heapUsedBytes": 38316584,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 219.368,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 657.6660000000629,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.1940000000000004,
"layouts": 76,
"layoutDurationMs": 16.22,
"taskDurationMs": 616.443,
"heapDeltaBytes": 1632436,
"heapUsedBytes": 95202192,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 258.49899999999997,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.09487179487179,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 587.6480000000583,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.439,
"layouts": 76,
"layoutDurationMs": 15.688,
"taskDurationMs": 543.6039999999999,
"heapDeltaBytes": 1105956,
"heapUsedBytes": 94304380,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 213.235,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3121 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9e7a98b24e59acb65bb25392d7240bc611da0c7d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #22335: same three files and 53 changed lines as the original.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22346 +/- ##
==========================================
Coverage 87.12% 87.13%
==========================================
Files 3027 3027
Lines 158688 158688
Branches 40177 40177
==========================================
+ Hits 138257 138265 +8
+ Misses 19755 19747 -8
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22335 to
core/1.59Automatically created by backport workflow.