Repository navigation
[backport core/1.58] FE-3099 fix(auth): open each local web sign-in popup in its own window - #22345
Conversation
#22335) ## Why Follow-up to Christian's non-blocking note on #22179: the local web sign-in popup used the fixed target name `comfy-local-web-sign-in`, so a concurrent sign-in from another tab could take over the same popup. ## Root cause `window.open(url, name)` reuses an existing window with that name from the same browsing context group. A ComfyUI tab opened from another ComfyUI tab (link, `window.open`) is in the same group, so its sign-in found the first tab's popup and navigated it to its own authorize URL. Only one popup and one code exchange happened; the first tab's attempt was overwritten. Tabs the user opens independently are in separate groups and were not affected. ## How - `openPopup` uses `_blank`, so every attempt gets its own window. `window.opener` is kept (no `noopener`), so `local-callback.html` still posts back to the tab that started the attempt. - New unit test: two bridges sign in at once on a shared token store, each hearing both callbacks; each finishes only from its own popup with its own code, and neither reports a failure. Removing the popup-source check turns it red. ## AS IS / TO BE Real Chromium, this branch's dev server, ComfyUI on :8188, a stand-in Cloud issuer serving `oauth/local-callback.html`. Tab B opened from tab A; Continue with SSO clicked in A, then in B; consent in each popup. | | AS IS (fixed name) | TO BE (`_blank`) | |---|---|---| | Popups opened | 1 (B retargeted A's popup) | 2 (opener A, opener B) | | Code exchanges | 1 (`ws-personal`) | 2 (`ws-personal`, `ws-team-a`) | | Tab B workspace | `ws-personal` (not what B chose) | `ws-team-a` | | Failure toasts | none | none | Two independently opened tabs behave the same before and after (2 popups, 2 exchanges). All 9 popup scenarios from #22179's verification (success, refused exchange, popup closed, switch to unkept/kept workspace, refused kept refresh, sign-out during popup, cross-tab forget, late refused refresh) give the same results on this branch.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T03:43:19.980Z",
"gitSha": "3029410933a75be8e668c7cf2578efb1af1c4be7",
"branch": "backport-22335-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.47199999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.556,
"layouts": 11,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 352.855,
"heapDeltaBytes": 9187012,
"heapUsedBytes": 99047592,
"domNodes": -180,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 8.559000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.197000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3669999999999995,
"layouts": 10,
"layoutDurationMs": 2.189,
"taskDurationMs": 344.57400000000007,
"heapDeltaBytes": 2464728,
"heapUsedBytes": 92871640,
"domNodes": -200,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 8.559000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.1009999999885,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.002,
"layouts": 10,
"layoutDurationMs": 2.183,
"taskDurationMs": 691.254,
"heapDeltaBytes": -2411732,
"heapUsedBytes": 97028536,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 116.49000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.462999999962,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.463999999999999,
"layouts": 9,
"layoutDurationMs": 2.4210000000000003,
"taskDurationMs": 751.1999999999999,
"heapDeltaBytes": -909636,
"heapUsedBytes": 87647944,
"domNodes": -180,
"jsHeapTotalBytes": -1216512,
"scriptDurationMs": 123.795,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5039999999913,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.334999999999999,
"layouts": 12,
"layoutDurationMs": 2.75,
"taskDurationMs": 322.861,
"heapDeltaBytes": 25368000,
"heapUsedBytes": 115713604,
"domNodes": 47,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.938,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1809.252000000015,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.6659999999999995,
"layouts": 12,
"layoutDurationMs": 4.808000000000001,
"taskDurationMs": 422.99100000000004,
"heapDeltaBytes": 1821104,
"heapUsedBytes": 106582852,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.645000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 551.9799999999861,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.674,
"layouts": 9,
"layoutDurationMs": 2.2380000000000004,
"taskDurationMs": 368.33900000000006,
"heapDeltaBytes": 3694020,
"heapUsedBytes": 95703204,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 139.16299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 550.0789999999824,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7680000000000007,
"layouts": 10,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 406.21799999999996,
"heapDeltaBytes": 7617820,
"heapUsedBytes": 108365352,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 135.458,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696954,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.3160000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.072,
"heapDeltaBytes": -15531240,
"heapUsedBytes": 102563648,
"domNodes": -230,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 47.705999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 372,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1064.6640000000502,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.866,
"heapDeltaBytes": -9145520,
"heapUsedBytes": 102801640,
"domNodes": -230,
"jsHeapTotalBytes": 8540160,
"scriptDurationMs": 49.574999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 391,
"frameDurationMs": 28.827027027027036,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.3950000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.443,
"heapDeltaBytes": -3453824,
"heapUsedBytes": 97499264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.32900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.6940000000159,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.0960000000001,
"heapDeltaBytes": -4169208,
"heapUsedBytes": 96621416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.302,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7463.675000000023,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7150000000000003,
"layouts": 3,
"layoutDurationMs": 0.7009999999999998,
"taskDurationMs": 6614.82,
"heapDeltaBytes": 28709596,
"heapUsedBytes": 142731160,
"domNodes": -276,
"jsHeapTotalBytes": 39202816,
"scriptDurationMs": 5047.224999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 82,
"frameDurationMs": 24.18766233766234,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6859.781999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7270000000000002,
"layouts": 3,
"layoutDurationMs": 0.637,
"taskDurationMs": 6051.728,
"heapDeltaBytes": 23385764,
"heapUsedBytes": 133397492,
"domNodes": -277,
"jsHeapTotalBytes": 21299200,
"scriptDurationMs": 4831.139,
"eventListeners": -130,
"totalBlockingTimeMs": 76,
"frameDurationMs": 24.610752688172045,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7430.036000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5640000000000003,
"layouts": 3,
"layoutDurationMs": 0.7109999999999999,
"taskDurationMs": 6673.988,
"heapDeltaBytes": 23256880,
"heapUsedBytes": 126344336,
"domNodes": -296,
"jsHeapTotalBytes": 25923584,
"scriptDurationMs": 5135.825,
"eventListeners": -130,
"totalBlockingTimeMs": 138,
"frameDurationMs": 24.942953020134226,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7608.826000000022,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06000000000000016,
"layouts": 1,
"layoutDurationMs": 0.28300000000000025,
"taskDurationMs": 6816.969999999999,
"heapDeltaBytes": 42758124,
"heapUsedBytes": 153180592,
"domNodes": -296,
"jsHeapTotalBytes": 37814272,
"scriptDurationMs": 5567.441,
"eventListeners": -130,
"totalBlockingTimeMs": 32,
"frameDurationMs": 24.35801282051282,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 174.86900000000105,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.508,
"layouts": 11,
"layoutDurationMs": 2.527,
"taskDurationMs": 132.733,
"heapDeltaBytes": 15496240,
"heapUsedBytes": 121050036,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.710000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 175.6809999999973,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.539999999999997,
"layouts": 12,
"layoutDurationMs": 2.802,
"taskDurationMs": 128.732,
"heapDeltaBytes": 15485520,
"heapUsedBytes": 121020212,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.711999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2042.9869999999823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1280000000000006,
"layouts": 9,
"layoutDurationMs": 1.9429999999999998,
"taskDurationMs": 401.8789999999999,
"heapDeltaBytes": -372068,
"heapUsedBytes": 110907740,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 28.426,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.7760000000271,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.396,
"layouts": 9,
"layoutDurationMs": 2.1519999999999997,
"taskDurationMs": 528.0250000000001,
"heapDeltaBytes": -584824,
"heapUsedBytes": 102243732,
"domNodes": -296,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 28.538999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2359.3010000000163,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.938999999999998,
"layouts": 9,
"layoutDurationMs": 2.086,
"taskDurationMs": 1456.5490000000002,
"heapDeltaBytes": -17698408,
"heapUsedBytes": 106288256,
"domNodes": -296,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 722.46,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2188.277000000028,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.506,
"layouts": 9,
"layoutDurationMs": 2.1069999999999998,
"taskDurationMs": 1226.4060000000002,
"heapDeltaBytes": -34405156,
"heapUsedBytes": 88313708,
"domNodes": -276,
"jsHeapTotalBytes": -344064,
"scriptDurationMs": 622.293,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3406.0739999999896,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.017000000000001,
"layouts": 67,
"layoutDurationMs": 10.367,
"taskDurationMs": 1479.539,
"heapDeltaBytes": -19658480,
"heapUsedBytes": 104695900,
"domNodes": -272,
"jsHeapTotalBytes": 311296,
"scriptDurationMs": 632.4909999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748275862068965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3339.8410000000354,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.232999999999999,
"layouts": 67,
"layoutDurationMs": 10.474,
"taskDurationMs": 1488.727,
"heapDeltaBytes": -12932148,
"heapUsedBytes": 100801240,
"domNodes": -273,
"jsHeapTotalBytes": 458752,
"scriptDurationMs": 629.525,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75050505050505,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2209.3750000000227,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.904000000000001,
"layouts": 8,
"layoutDurationMs": 1.856,
"taskDurationMs": 1431.991,
"heapDeltaBytes": -11476004,
"heapUsedBytes": 103651200,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 772.5580000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992365,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2244.4489999999746,
"styleRecalcs": 50,
"styleRecalcDurationMs": 5.911999999999999,
"layouts": 8,
"layoutDurationMs": 1.826,
"taskDurationMs": 1444.2740000000001,
"heapDeltaBytes": -11852360,
"heapUsedBytes": 102932576,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 753.1770000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.916541353383458,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.15200000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9259999999999997,
"layouts": 7,
"layoutDurationMs": 1.546,
"taskDurationMs": 531.3399999999999,
"heapDeltaBytes": -1374372,
"heapUsedBytes": 102488460,
"domNodes": -296,
"jsHeapTotalBytes": -2002944,
"scriptDurationMs": 30.64,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.6549999999725,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.092,
"layouts": 8,
"layoutDurationMs": 1.9279999999999997,
"taskDurationMs": 421.42999999999995,
"heapDeltaBytes": -27521320,
"heapUsedBytes": 96956204,
"domNodes": -297,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 31.255,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.1330000000116,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.651000000000001,
"layouts": 9,
"layoutDurationMs": 1.9950000000000003,
"taskDurationMs": 359.08099999999996,
"heapDeltaBytes": 23736780,
"heapUsedBytes": 117835484,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 120.284,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.0030000000206,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.6979999999999995,
"layouts": 9,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 311.787,
"heapDeltaBytes": 822080,
"heapUsedBytes": 93742048,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 119.987,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.124999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3,
"layouts": 10,
"layoutDurationMs": 2.214,
"taskDurationMs": 489.23199999999997,
"heapDeltaBytes": 2364768,
"heapUsedBytes": 93184284,
"domNodes": -218,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 8.081,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.665999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.052,
"layouts": 10,
"layoutDurationMs": 2.6549999999999994,
"taskDurationMs": 436.826,
"heapDeltaBytes": 4455392,
"heapUsedBytes": 106372492,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.538999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2930000000208,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.495000000000001,
"layouts": 9,
"layoutDurationMs": 1.961,
"taskDurationMs": 600.346,
"heapDeltaBytes": -476856,
"heapUsedBytes": 90948460,
"domNodes": -210,
"jsHeapTotalBytes": 2686976,
"scriptDurationMs": 86.948,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.3280000000177,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.103,
"layouts": 9,
"layoutDurationMs": 2.057,
"taskDurationMs": 590.437,
"heapDeltaBytes": -1919028,
"heapUsedBytes": 89138720,
"domNodes": -210,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 91.117,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.3049999999876,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.383,
"layouts": 5,
"layoutDurationMs": 12.099,
"taskDurationMs": 650.2589999999999,
"heapDeltaBytes": 37898768,
"heapUsedBytes": 137848232,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 22.019,
"eventListeners": 3244,
"totalBlockingTimeMs": 111,
"frameDurationMs": 21.139024390243897,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "viewport-pan-sweep",
"durationMs": 8443.128999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.489,
"layouts": 8,
"layoutDurationMs": 1.751,
"taskDurationMs": 4747.656999999999,
"heapDeltaBytes": -13149776,
"heapUsedBytes": 90366388,
"domNodes": -276,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 2102.801,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587771203156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8243.852000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.351000000000003,
"layouts": 7,
"layoutDurationMs": 1.6290000000000002,
"taskDurationMs": 4145.554,
"heapDeltaBytes": -33128904,
"heapUsedBytes": 89087584,
"domNodes": -296,
"jsHeapTotalBytes": 442368,
"scriptDurationMs": 2126.788,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14036.061000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13184.547999999999,
"heapDeltaBytes": -15869768,
"heapUsedBytes": 284821816,
"domNodes": -3344,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 196.202,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.249307958477505,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14423.551999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13723.234000000002,
"heapDeltaBytes": -11738688,
"heapUsedBytes": 292835180,
"domNodes": -3344,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 204.209,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.454673721340388,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 23399.856999999996,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.784999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23134.539,
"heapDeltaBytes": -38554344,
"heapUsedBytes": 291138636,
"domNodes": -3344,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 776.551,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.48479087452471,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23855.598999999984,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23574.196,
"heapDeltaBytes": -20752420,
"heapUsedBytes": 310534288,
"domNodes": -3344,
"jsHeapTotalBytes": 19054592,
"scriptDurationMs": 737.7280000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 44.828759398496246,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6974.841000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.926,
"layouts": 20,
"layoutDurationMs": 20.82600000000001,
"taskDurationMs": 6855.241999999999,
"heapDeltaBytes": -39072604,
"heapUsedBytes": 285064132,
"domNodes": -3344,
"jsHeapTotalBytes": 24629248,
"scriptDurationMs": 100.48500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 8,
"frameDurationMs": 40.50232558139535,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 5180.097000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.981,
"layouts": 20,
"layoutDurationMs": 21.454,
"taskDurationMs": 5039.471,
"heapDeltaBytes": -25946640,
"heapUsedBytes": 279676968,
"domNodes": -3344,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 78.36399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.60487804878049,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9355.582000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9194.504000000003,
"heapDeltaBytes": -4259240,
"heapUsedBytes": 286867148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.55799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.909897610921508,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7101.027999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6649.744999999999,
"heapDeltaBytes": -8462504,
"heapUsedBytes": 281102364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.329,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.56643598615917,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 95.12699999999086,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.704,
"layouts": 8,
"layoutDurationMs": 2.5260000000000002,
"taskDurationMs": 67.46500000000002,
"heapDeltaBytes": 4808184,
"heapUsedBytes": 97289940,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.284999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 87.82499999995252,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.046,
"layouts": 7,
"layoutDurationMs": 2.185,
"taskDurationMs": 61.12199999999999,
"heapDeltaBytes": 4648356,
"heapUsedBytes": 95290800,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.393000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 283.23599999998805,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.596,
"layouts": 76,
"layoutDurationMs": 11.514,
"taskDurationMs": 250.17899999999997,
"heapDeltaBytes": 10288412,
"heapUsedBytes": 98767128,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 115.37700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 272.90800000002946,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.597,
"layouts": 76,
"layoutDurationMs": 11.530999999999999,
"taskDurationMs": 227.96800000000002,
"heapDeltaBytes": 9636504,
"heapUsedBytes": 99178356,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 102.277,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 347.5229999999101,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.633,
"layouts": 76,
"layoutDurationMs": 11.15,
"taskDurationMs": 319.757,
"heapDeltaBytes": -994304,
"heapUsedBytes": 116026348,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 117.91,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 315.0110000000268,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.486,
"layouts": 76,
"layoutDurationMs": 10.649000000000001,
"taskDurationMs": 290.838,
"heapDeltaBytes": -1505520,
"heapUsedBytes": 115885932,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 107.473,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 2982 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 385fb6606b7f3546f2e4f4bc5f96f0cdbe928a8f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (136)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #22335: same three files and 53 changed lines as the original.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22345 +/- ##
==========================================
Coverage 84.03% 84.03%
==========================================
Files 3175 3175
Lines 166011 166011
Branches 39595 39595
==========================================
+ Hits 139502 139510 +8
+ Misses 26117 26109 -8
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22335 to
core/1.58Automatically created by backport workflow.