Repository navigation
fix: preview dropdown options from their root and subfolder #22331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6e37d3d
eb01010
552ec19
393b393
1349af8
f8e7421
bd9c3e5
658d06a
5289e0a
bc182d5
4f34702
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -215,7 +215,7 @@ export function useWidgetSelectItems(options: UseWidgetSelectItemsOptions) { | |
| .filter((value) => !missing.has(String(value))) | ||
| .map((value, index) => ({ | ||
| id: `input-${index}`, | ||
| preview_url: getMediaUrl(String(value), 'input', kind), | ||
| preview_url: getAnnotatedValueMediaUrl(String(value), kind), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Low — Every input option now goes through Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh edge-case, gpt-5.6-sol-xhigh edge-case, kimi-k3-high edge-case).
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keeping the check as it is. It mirrors how ComfyUI joins the path on Windows: Python's |
||
| name: String(value), | ||
| label: getDisplayLabel(String(value), labelFn) | ||
| })) | ||
|
|
@@ -259,7 +259,8 @@ export function useWidgetSelectItems(options: UseWidgetSelectItemsOptions) { | |
| preview_url: | ||
| kind === 'mesh' | ||
| ? '' | ||
| : asset.preview_url || getMediaUrl(filenameForUrl, 'output', kind), | ||
| : asset.preview_url || | ||
| getMediaUrl(filenameForUrl, rootFolder, kind, subfolder), | ||
| name: annotatedPath, | ||
| label: getDisplayLabel(displayLabel, labelFn) | ||
| }) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.