Repository navigation
[backport cloud/1.59] fix(billing): report a failed background balance read instead of leaving it unhandled (#22201) - #22313
Conversation
…ead of leaving it unhandled (#22201) Opening the account menu (legacy or workspace) or the Credits settings section starts a balance read that nothing awaits. When it fails, the rejection is unhandled, so Sentry files it as a new high-priority error. Now: - the failure is reported as a `billing` warning (`error_refreshing_balance`), at most once every five minutes, so reopening the menu during an outage does not repeat it; - a workspace balance read that a newer read has replaced settles quietly instead of rejecting, matching the rail path's `SUPERSEDED` handling, so the warning only covers failures the billing state actually kept; - the same applies across a workspace switch. A balance read for the previous workspace could still land after the switch replaced the billing adapter, writing that workspace's balance into the discarded adapter or reporting a warning for a failure the billing state never kept. `fetchStatus` already captured and rechecked the workspace id, so `fetchBalance` now shares that guard rather than carrying a second copy. What the user sees is unchanged. Note that the two popovers still show 0 credits when the read fails; that display bug is tracked separately in https://linear.app/comfyorg/issue/FRONT-3164. Evidence: both events of Sentry `CLOUD-FRONTEND-PROD-2V0` ("AuthStoreError: Failed to fetch balance: Balance temporarily unavailable") are `onunhandledrejection` from `useLegacyBilling.fetchBalance`, right after a 503 from `/customers/balance`. #21322 now retries that 503; this covers the failure left after the retries run out. Linear: https://linear.app/comfyorg/issue/FRONT-3684 - Red before the fix, green after: one test per call site (`CurrentUserPopoverLegacy`, `CurrentUserPopoverWorkspace`, `SettingDialog` Credits section), the helper's five-minute report budget, `useWorkspaceBilling` settling a superseded failed read, and `useWorkspaceBilling` dropping a balance read on both paths once the workspace changed. - `pnpm typecheck`, oxlint, oxfmt and the pre-push fallow audit pass. - After release: `CLOUD-FRONTEND-PROD-2V0` gets no new unhandled events; a persistent balance outage shows up as `error_refreshing_balance` warnings instead.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T00:04:10.981Z",
"gitSha": "cf51d691872552c1b2a421fa9a653bee815afa14",
"branch": "backport-22201-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.8279999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.562,
"layouts": 9,
"layoutDurationMs": 2.713,
"taskDurationMs": 496.41999999999996,
"heapDeltaBytes": 3215004,
"heapUsedBytes": 64415092,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 7.956000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.286000000032,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.646,
"layouts": 9,
"layoutDurationMs": 2.348,
"taskDurationMs": 505.53099999999995,
"heapDeltaBytes": 5370768,
"heapUsedBytes": 75148316,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.532999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.032000000006,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.277999999999999,
"layouts": 9,
"layoutDurationMs": 2.349,
"taskDurationMs": 841.5559999999999,
"heapDeltaBytes": 21696672,
"heapUsedBytes": 82219896,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 143.569,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.8909999999682,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.551,
"layouts": 9,
"layoutDurationMs": 2.3099999999999996,
"taskDurationMs": 834.774,
"heapDeltaBytes": 23176860,
"heapUsedBytes": 84260492,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 140.75,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622637,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.0020000000359,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.745,
"layouts": 10,
"layoutDurationMs": 2.6040000000000005,
"taskDurationMs": 396.97799999999995,
"heapDeltaBytes": 409704,
"heapUsedBytes": 70433508,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.194999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4949999999335,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.572000000000001,
"layouts": 10,
"layoutDurationMs": 3.015,
"taskDurationMs": 395.09,
"heapDeltaBytes": 24175948,
"heapUsedBytes": 86456296,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.166000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 632.7919999999949,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.601,
"layouts": 9,
"layoutDurationMs": 2.3950000000000005,
"taskDurationMs": 467.225,
"heapDeltaBytes": 5439860,
"heapUsedBytes": 66507140,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 155.846,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 660.4290000000219,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.505,
"layouts": 9,
"layoutDurationMs": 2.349,
"taskDurationMs": 481.27299999999997,
"heapDeltaBytes": 5314964,
"heapUsedBytes": 66550312,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 165.53699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.4450000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.951,
"heapDeltaBytes": -12922912,
"heapUsedBytes": 74666352,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 62.36600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 541,
"frameDurationMs": 33.79722222222222,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.7270000000099,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 892.379,
"heapDeltaBytes": -2473772,
"heapUsedBytes": 75022776,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 59.647000000000006,
"eventListeners": -106,
"totalBlockingTimeMs": 524,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.9200000000149,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.34199999999987,
"heapDeltaBytes": -4161820,
"heapUsedBytes": 65136856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.16,
"eventListeners": 0,
"totalBlockingTimeMs": 180,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.0450000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.29900000000055,
"heapDeltaBytes": 22793168,
"heapUsedBytes": 87878448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.61199999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 178,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10079.636999999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03999999999999924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9230.518,
"heapDeltaBytes": 73458492,
"heapUsedBytes": 147180096,
"domNodes": -257,
"jsHeapTotalBytes": 69857280,
"scriptDurationMs": 7221.423000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 441,
"frameDurationMs": 29.60647058823529,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9261.306999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8406.794999999998,
"heapDeltaBytes": 61556164,
"heapUsedBytes": 136048548,
"domNodes": -257,
"jsHeapTotalBytes": 70119424,
"scriptDurationMs": 6540.771000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 140,
"frameDurationMs": 27.86024096385542,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9462.429000000015,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0430000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8720.818000000001,
"heapDeltaBytes": 59358396,
"heapUsedBytes": 133410504,
"domNodes": -257,
"jsHeapTotalBytes": 67760128,
"scriptDurationMs": 6826.637,
"eventListeners": -68,
"totalBlockingTimeMs": 368,
"frameDurationMs": 29.216975308641977,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9215.206000000024,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.029999999999999645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8428.359,
"heapDeltaBytes": 69336912,
"heapUsedBytes": 143694724,
"domNodes": -257,
"jsHeapTotalBytes": 64876544,
"scriptDurationMs": 6578.433999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 249,
"frameDurationMs": 30.11862745098039,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 265.34300000000144,
"styleRecalcs": 27,
"styleRecalcDurationMs": 13.740000000000002,
"layouts": 12,
"layoutDurationMs": 3.528,
"taskDurationMs": 209.48400000000004,
"heapDeltaBytes": 14446032,
"heapUsedBytes": 90538592,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 12.023,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.515384615384637,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 200.73300000001382,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.583,
"layouts": 9,
"layoutDurationMs": 2.4059999999999997,
"taskDurationMs": 161.88699999999997,
"heapDeltaBytes": 14587596,
"heapUsedBytes": 70852560,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.097,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2039.8289999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.829,
"layouts": 8,
"layoutDurationMs": 1.83,
"taskDurationMs": 594.4019999999999,
"heapDeltaBytes": -12269276,
"heapUsedBytes": 61207260,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.742000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2056.5600000000472,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3429999999999995,
"layouts": 8,
"layoutDurationMs": 2.205,
"taskDurationMs": 632.623,
"heapDeltaBytes": 8539372,
"heapUsedBytes": 83669912,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.10799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2225.1320000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.757,
"layouts": 6,
"layoutDurationMs": 1.4669999999999999,
"taskDurationMs": 1609.0300000000002,
"heapDeltaBytes": 9744504,
"heapUsedBytes": 85061528,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 782.154,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834585,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2288.193999999976,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.052,
"layouts": 7,
"layoutDurationMs": 2.1209999999999996,
"taskDurationMs": 1653.7699999999998,
"heapDeltaBytes": 6176168,
"heapUsedBytes": 81818504,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 785.032,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3555.054000000013,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.712000000000002,
"layouts": 63,
"layoutDurationMs": 9.718000000000002,
"taskDurationMs": 1719.379,
"heapDeltaBytes": -16093360,
"heapUsedBytes": 64071264,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 737.6270000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3574.32799999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.295000000000002,
"layouts": 64,
"layoutDurationMs": 10.120000000000001,
"taskDurationMs": 1722.0369999999998,
"heapDeltaBytes": 5284876,
"heapUsedBytes": 85653772,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 753.8729999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3025.4189999999994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.587,
"layouts": 5,
"layoutDurationMs": 1.0410000000000004,
"taskDurationMs": 1909.3840000000002,
"heapDeltaBytes": 19450116,
"heapUsedBytes": 97356484,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 917.8309999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758888888888887,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2923.7190000000055,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9879999999999995,
"layouts": 6,
"layoutDurationMs": 1.424,
"taskDurationMs": 1900.27,
"heapDeltaBytes": 16512456,
"heapUsedBytes": 93907276,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 922.0939999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76149425287356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3091.87399999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.013,
"layouts": 7,
"layoutDurationMs": 1.8530000000000004,
"taskDurationMs": 818.2499999999999,
"heapDeltaBytes": 9338864,
"heapUsedBytes": 85542768,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 370.536,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3084.7689999999943,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3980000000000008,
"layouts": 5,
"layoutDurationMs": 1.2759999999999998,
"taskDurationMs": 774.2139999999999,
"heapDeltaBytes": 5586988,
"heapUsedBytes": 81857028,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 361.77600000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.6770000000215,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8660000000000005,
"layouts": 7,
"layoutDurationMs": 1.6829999999999998,
"taskDurationMs": 624.689,
"heapDeltaBytes": -9587352,
"heapUsedBytes": 67370524,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.982,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.3729999999696,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8779999999999994,
"layouts": 7,
"layoutDurationMs": 2.03,
"taskDurationMs": 621.1419999999999,
"heapDeltaBytes": -16492896,
"heapUsedBytes": 75888016,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 33.492000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2897.1889999999976,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.992,
"layouts": 7,
"layoutDurationMs": 1.6450000000000002,
"taskDurationMs": 618.56,
"heapDeltaBytes": -1013920,
"heapUsedBytes": 75958132,
"domNodes": -253,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 180.67,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2770.6699999999955,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.568,
"layouts": 7,
"layoutDurationMs": 1.547,
"taskDurationMs": 608.1050000000001,
"heapDeltaBytes": -1209408,
"heapUsedBytes": 79037692,
"domNodes": -245,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 188.045,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3252.770000000027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2199999999999998,
"layouts": 5,
"layoutDurationMs": 1.2180000000000004,
"taskDurationMs": 951.7999999999998,
"heapDeltaBytes": -3146200,
"heapUsedBytes": 75618144,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 356.505,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3273.329999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7300000000000006,
"layouts": 8,
"layoutDurationMs": 1.9170000000000003,
"taskDurationMs": 931.35,
"heapDeltaBytes": -1905356,
"heapUsedBytes": 76450100,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 362.64199999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75179487179487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.669000000009,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.038,
"layouts": 9,
"layoutDurationMs": 2.0829999999999997,
"taskDurationMs": 415.239,
"heapDeltaBytes": -1154864,
"heapUsedBytes": 60817564,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 131.917,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.7239999999811,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.066999999999999,
"layouts": 9,
"layoutDurationMs": 2.545,
"taskDurationMs": 428.913,
"heapDeltaBytes": 25067572,
"heapUsedBytes": 86306612,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 139.53,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.7059999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.705,
"layouts": 11,
"layoutDurationMs": 2.7360000000000007,
"taskDurationMs": 492.33799999999997,
"heapDeltaBytes": 993440,
"heapUsedBytes": 63296912,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.153000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2056.0820000000035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.62,
"layouts": 9,
"layoutDurationMs": 2.708,
"taskDurationMs": 528.63,
"heapDeltaBytes": 898908,
"heapUsedBytes": 62925296,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.533000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.776000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.365,
"layouts": 9,
"layoutDurationMs": 2.3019999999999996,
"taskDurationMs": 807.442,
"heapDeltaBytes": 17319904,
"heapUsedBytes": 79288600,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 99.229,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9010000000162,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.042,
"layouts": 9,
"layoutDurationMs": 2.193,
"taskDurationMs": 770.5640000000001,
"heapDeltaBytes": 18666128,
"heapUsedBytes": 80815400,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 94.653,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.2710000000238,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.493000000000002,
"layouts": 5,
"layoutDurationMs": 13.700000000000001,
"taskDurationMs": 971.1769999999999,
"heapDeltaBytes": 11841104,
"heapUsedBytes": 104706568,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 28.733,
"eventListeners": 3246,
"totalBlockingTimeMs": 145,
"frameDurationMs": 19.331999999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.319000000029,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.587,
"layouts": 9,
"layoutDurationMs": 2.078,
"taskDurationMs": 5635.7339999999995,
"heapDeltaBytes": -2558084,
"heapUsedBytes": 71206360,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2530.9429999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.287000000008,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.040000000000003,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 5737.697,
"heapDeltaBytes": -4347672,
"heapUsedBytes": 72300520,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2573.833,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586345381526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20357.681000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19714.461999999996,
"heapDeltaBytes": -11651672,
"heapUsedBytes": 278887160,
"domNodes": -3343,
"jsHeapTotalBytes": 11001856,
"scriptDurationMs": 311.43,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.9821554770318,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20418.71800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19712.989,
"heapDeltaBytes": -40269792,
"heapUsedBytes": 255550684,
"domNodes": -3343,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 286.588,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.851805054151626,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24988.160999999993,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.39200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24689.91,
"heapDeltaBytes": -1295444,
"heapUsedBytes": 275516436,
"domNodes": -3343,
"jsHeapTotalBytes": 12242944,
"scriptDurationMs": 872.1949999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 47.890804597701155,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24865.21099999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.00099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24575.072,
"heapDeltaBytes": -7751488,
"heapUsedBytes": 284183756,
"domNodes": -3343,
"jsHeapTotalBytes": 14073856,
"scriptDurationMs": 864.817,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 47.00529300567108,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7309.867000000054,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.82100000000001,
"layouts": 20,
"layoutDurationMs": 22.50600000000001,
"taskDurationMs": 7183.553999999999,
"heapDeltaBytes": -1553308,
"heapUsedBytes": 280219468,
"domNodes": -3343,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 103.48100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.341818181818184,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7291.338999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.94199999999999,
"layouts": 20,
"layoutDurationMs": 22.41199999999999,
"taskDurationMs": 7191.203,
"heapDeltaBytes": -42138868,
"heapUsedBytes": 249189580,
"domNodes": -2276,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 133.314,
"eventListeners": -433,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.85432098765432,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10100.707999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9719.948,
"heapDeltaBytes": -171732,
"heapUsedBytes": 275872684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.91799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.68763250883393,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10180.87300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9848.097,
"heapDeltaBytes": -18850784,
"heapUsedBytes": 258234944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.525,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.1029197080292,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 121.28100000001041,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.83,
"layouts": 8,
"layoutDurationMs": 2.479,
"taskDurationMs": 93.53599999999999,
"heapDeltaBytes": 4729076,
"heapUsedBytes": 64404392,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.075999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 126.7249999999649,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.910000000000002,
"layouts": 8,
"layoutDurationMs": 3.885,
"taskDurationMs": 88.941,
"heapDeltaBytes": 4608960,
"heapUsedBytes": 64897768,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.391,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 417.6680000000488,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 14.432,
"taskDurationMs": 366.92900000000003,
"heapDeltaBytes": -5191480,
"heapUsedBytes": 37871656,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 167.353,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 569.9899999999616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.632,
"layouts": 76,
"layoutDurationMs": 17.264000000000003,
"taskDurationMs": 517.738,
"heapDeltaBytes": -3519032,
"heapUsedBytes": 39103300,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 248.498,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 566.4090000000215,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.657,
"layouts": 76,
"layoutDurationMs": 15.665,
"taskDurationMs": 530.761,
"heapDeltaBytes": 442532,
"heapUsedBytes": 90907616,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 207.827,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 503.2929999999851,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.663,
"layouts": 76,
"layoutDurationMs": 14.59,
"taskDurationMs": 462.924,
"heapDeltaBytes": 751828,
"heapUsedBytes": 94572124,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.05700000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3113 passed, 0 failed · 8 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ad13efd5c8bee8d20093a0392888eb6bfa070d23
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (221)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 6759259 and the full merged-parent discussion. The backport preserves this branch's workspaceApi and telemetry paths while retaining stale-request/workspace guards and the five-minute reporting budget. Own isolated-checkout validation: all 193 tests across the five affected suites, application type check and scoped lint/format PASS. Reverting each of the three call-site handlers separately, removing the stale-rejection guard, or removing the warning budget each fails retained tests; the restored 193-test run passes. No remaining code blocker.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22313 +/- ##
=============================================
Coverage ? 87.11%
=============================================
Files ? 3028
Lines ? 158410
Branches ? 42291
=============================================
Hits ? 137994
Misses ? 19740
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #22201 (
44cf08fb7b) tocloud/1.59. The auto-backport failed on conflicts.What
Opening the account menu or the Credits settings section starts a balance read nobody awaits. When it fails, the rejection is unhandled and Sentry files a new error. With this change it is reported as one
billingwarning at most every 5 minutes, and a balance read replaced by a newer read (or by a workspace switch) settles quietly.Conflict resolution for 1.59
useWorkspaceBilling.ts: 1.59 reads throughworkspaceApi, notbillingApi. KeptworkspaceApi, applied the sharedisStaleBillingReadguard unchanged.SettingDialog.vue: import-only conflict (1.59 has noworkspaceBillingStateStoreimport). Added only therefreshBalanceInBackgroundimport.@comfyorg/telemetrypackage and no globalreportErrormock, so the new helper imports@/platform/telemetry/reportErrorand the four new tests mock it withvi.mock(import('@/platform/telemetry/reportError')).Verification
pnpm typecheck:app, oxfmt and oxlint pass.Linear: https://linear.app/comfyorg/issue/FRONT-3684