Repository navigation
[backport core/1.59] fix(billing): report a failed background balance read instead of leaving it unhandled (#22201) - #22312
Conversation
…ead of leaving it unhandled (#22201) Opening the account menu (legacy or workspace) or the Credits settings section starts a balance read that nothing awaits. When it fails, the rejection is unhandled, so Sentry files it as a new high-priority error. Now: - the failure is reported as a `billing` warning (`error_refreshing_balance`), at most once every five minutes, so reopening the menu during an outage does not repeat it; - a workspace balance read that a newer read has replaced settles quietly instead of rejecting, matching the rail path's `SUPERSEDED` handling, so the warning only covers failures the billing state actually kept; - the same applies across a workspace switch. A balance read for the previous workspace could still land after the switch replaced the billing adapter, writing that workspace's balance into the discarded adapter or reporting a warning for a failure the billing state never kept. `fetchStatus` already captured and rechecked the workspace id, so `fetchBalance` now shares that guard rather than carrying a second copy. What the user sees is unchanged. Note that the two popovers still show 0 credits when the read fails; that display bug is tracked separately in https://linear.app/comfyorg/issue/FRONT-3164. Evidence: both events of Sentry `CLOUD-FRONTEND-PROD-2V0` ("AuthStoreError: Failed to fetch balance: Balance temporarily unavailable") are `onunhandledrejection` from `useLegacyBilling.fetchBalance`, right after a 503 from `/customers/balance`. #21322 now retries that 503; this covers the failure left after the retries run out. Linear: https://linear.app/comfyorg/issue/FRONT-3684 - Red before the fix, green after: one test per call site (`CurrentUserPopoverLegacy`, `CurrentUserPopoverWorkspace`, `SettingDialog` Credits section), the helper's five-minute report budget, `useWorkspaceBilling` settling a superseded failed read, and `useWorkspaceBilling` dropping a balance read on both paths once the workspace changed. - `pnpm typecheck`, oxlint, oxfmt and the pre-push fallow audit pass. - After release: `CLOUD-FRONTEND-PROD-2V0` gets no new unhandled events; a persistent balance outage shows up as `error_refreshing_balance` warnings instead.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T00:05:10.101Z",
"gitSha": "b21e41a5fbb4e1c0b0ba77bb0e58c5cbfba44361",
"branch": "backport-22201-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.3809999999862,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.712,
"layouts": 10,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 513.346,
"heapDeltaBytes": 5390616,
"heapUsedBytes": 75721020,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.924000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.5000000000364,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1149999999999998,
"layouts": 8,
"layoutDurationMs": 2.386,
"taskDurationMs": 513.785,
"heapDeltaBytes": 1724768,
"heapUsedBytes": 63027524,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.002000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.8370000000086,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.174,
"layouts": 9,
"layoutDurationMs": 2.4409999999999994,
"taskDurationMs": 850.655,
"heapDeltaBytes": 23464480,
"heapUsedBytes": 84515732,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 157.62300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.8800000000983,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.592,
"layouts": 8,
"layoutDurationMs": 2.43,
"taskDurationMs": 858.333,
"heapDeltaBytes": 22364668,
"heapUsedBytes": 83543396,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 157.006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.266,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.089999999999999,
"layouts": 10,
"layoutDurationMs": 3.1029999999999998,
"taskDurationMs": 409.76199999999994,
"heapDeltaBytes": 23921524,
"heapUsedBytes": 85448956,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.74,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.4480000000149,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.43,
"layouts": 11,
"layoutDurationMs": 2.948,
"taskDurationMs": 396.51800000000003,
"heapDeltaBytes": 766056,
"heapUsedBytes": 70665996,
"domNodes": 56,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 10.782999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.0280000000153,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.483,
"layouts": 9,
"layoutDurationMs": 2.378,
"taskDurationMs": 488.565,
"heapDeltaBytes": 7037212,
"heapUsedBytes": 76923716,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 167.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 644.8779999999488,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6370000000000005,
"layouts": 10,
"layoutDurationMs": 2.606,
"taskDurationMs": 493.80199999999996,
"heapDeltaBytes": 3759020,
"heapUsedBytes": 64679264,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 171.311,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.1190000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 944.841,
"heapDeltaBytes": -748052,
"heapUsedBytes": 75571692,
"domNodes": -191,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 71.404,
"eventListeners": -106,
"totalBlockingTimeMs": 540,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.8159999998988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.323,
"heapDeltaBytes": -769192,
"heapUsedBytes": 74690612,
"domNodes": -191,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 68.98199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 525,
"frameDurationMs": 32.42972972972973,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.2739999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.0170000000006,
"heapDeltaBytes": -28114928,
"heapUsedBytes": 64732104,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 170.99999999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.356999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.5660000000004,
"heapDeltaBytes": -28653008,
"heapUsedBytes": 64683292,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 168.40200000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10879.658000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9996.257,
"heapDeltaBytes": 63324840,
"heapUsedBytes": 136665976,
"domNodes": -257,
"jsHeapTotalBytes": 71430144,
"scriptDurationMs": 7985.207,
"eventListeners": -68,
"totalBlockingTimeMs": 1047,
"frameDurationMs": 31.6798833819242,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10069.326000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9287.236,
"heapDeltaBytes": 55625904,
"heapUsedBytes": 128149532,
"domNodes": -257,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 7372.25,
"eventListeners": -68,
"totalBlockingTimeMs": 747,
"frameDurationMs": 31.216408668730654,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10122.067000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9323.433,
"heapDeltaBytes": 65232576,
"heapUsedBytes": 140058724,
"domNodes": -253,
"jsHeapTotalBytes": 62255104,
"scriptDurationMs": 7412.499000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 766,
"frameDurationMs": 31.51495327102804,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10662.46000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9900.866,
"heapDeltaBytes": 80364588,
"heapUsedBytes": 154618900,
"domNodes": -257,
"jsHeapTotalBytes": 73789440,
"scriptDurationMs": 7981.76,
"eventListeners": -68,
"totalBlockingTimeMs": 1096,
"frameDurationMs": 31.230205278592376,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 265.85000000000036,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.999999999999998,
"layouts": 12,
"layoutDurationMs": 3.416,
"taskDurationMs": 211.31299999999996,
"heapDeltaBytes": 14459288,
"heapUsedBytes": 89464824,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.424999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.24545454545457,
"p95FrameDurationMs": 100.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 251.75899999999274,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.931,
"layouts": 13,
"layoutDurationMs": 4.066,
"taskDurationMs": 235.56500000000003,
"heapDeltaBytes": -8111904,
"heapUsedBytes": 67132812,
"domNodes": -2315,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.564,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2057.0319999999924,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4570000000000007,
"layouts": 8,
"layoutDurationMs": 2.2600000000000002,
"taskDurationMs": 661.829,
"heapDeltaBytes": -11008936,
"heapUsedBytes": 65501980,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 40.783,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.4779999999464,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.975,
"layouts": 8,
"layoutDurationMs": 2.103,
"taskDurationMs": 665.9419999999999,
"heapDeltaBytes": -13611108,
"heapUsedBytes": 77686128,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 32.82500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2495.3390000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.080999999999998,
"layouts": 7,
"layoutDurationMs": 1.8780000000000001,
"taskDurationMs": 1683.3370000000002,
"heapDeltaBytes": -31388448,
"heapUsedBytes": 60452616,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 813.3870000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2408.990000000017,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.115,
"layouts": 6,
"layoutDurationMs": 1.689,
"taskDurationMs": 1668.227,
"heapDeltaBytes": -13744180,
"heapUsedBytes": 60781128,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 822.56,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66620689655172,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3671.0520000000315,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.872000000000002,
"layouts": 64,
"layoutDurationMs": 10.323,
"taskDurationMs": 1782.7900000000004,
"heapDeltaBytes": -1403244,
"heapUsedBytes": 70040084,
"domNodes": -233,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 781.74,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3684.7960000000057,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.100999999999999,
"layouts": 64,
"layoutDurationMs": 10.363000000000001,
"taskDurationMs": 1768.533,
"heapDeltaBytes": -1638848,
"heapUsedBytes": 69514868,
"domNodes": -233,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 773.723,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665610859728506,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2945.4559999999788,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9319999999999995,
"layouts": 5,
"layoutDurationMs": 1.373,
"taskDurationMs": 1934.3799999999997,
"heapDeltaBytes": 7255696,
"heapUsedBytes": 79338020,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 970.011,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2981.3219999999774,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.077,
"layouts": 6,
"layoutDurationMs": 1.3309999999999997,
"taskDurationMs": 1905.2570000000003,
"heapDeltaBytes": 9790888,
"heapUsedBytes": 81313544,
"domNodes": 0,
"jsHeapTotalBytes": 3108864,
"scriptDurationMs": 941.88,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759887005649716,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3048.54499999999,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5589999999999997,
"layouts": 6,
"layoutDurationMs": 1.5600000000000003,
"taskDurationMs": 775.1150000000001,
"heapDeltaBytes": -14520408,
"heapUsedBytes": 78725392,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 355.854,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3087.0689999999286,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9929999999999999,
"layouts": 7,
"layoutDurationMs": 1.868,
"taskDurationMs": 790.407,
"heapDeltaBytes": -27660276,
"heapUsedBytes": 65154664,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 356.965,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.648999999964,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6769999999999996,
"layouts": 7,
"layoutDurationMs": 1.692,
"taskDurationMs": 606.1739999999999,
"heapDeltaBytes": -8904668,
"heapUsedBytes": 67106924,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.994000000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.5409999999338,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8719999999999994,
"layouts": 7,
"layoutDurationMs": 1.904,
"taskDurationMs": 630.734,
"heapDeltaBytes": 8329516,
"heapUsedBytes": 85332160,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.277,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2756.819999999948,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.991,
"layouts": 7,
"layoutDurationMs": 1.824,
"taskDurationMs": 596.2840000000001,
"heapDeltaBytes": -208056,
"heapUsedBytes": 80281416,
"domNodes": -245,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 190.59599999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767073170731706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2813.1819999999834,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.054,
"layouts": 6,
"layoutDurationMs": 1.4739999999999995,
"taskDurationMs": 616.348,
"heapDeltaBytes": -23535900,
"heapUsedBytes": 69658060,
"domNodes": -254,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 203.405,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3223.388,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7870000000000004,
"layouts": 7,
"layoutDurationMs": 2.043,
"taskDurationMs": 916.8000000000001,
"heapDeltaBytes": -2694732,
"heapUsedBytes": 76812528,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 354.11199999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3240.2289999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7630000000000008,
"layouts": 7,
"layoutDurationMs": 1.8800000000000001,
"taskDurationMs": 937.1100000000001,
"heapDeltaBytes": -29906952,
"heapUsedBytes": 63265508,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 366.569,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.8380000000011,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.04,
"layouts": 8,
"layoutDurationMs": 2.236,
"taskDurationMs": 448.137,
"heapDeltaBytes": -204780,
"heapUsedBytes": 62328912,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 145.784,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.7979999998979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.8469999999999995,
"layouts": 9,
"layoutDurationMs": 2.7060000000000004,
"taskDurationMs": 432.8419999999999,
"heapDeltaBytes": -1216784,
"heapUsedBytes": 60138824,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 147.27200000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.9019999999778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7519999999999993,
"layouts": 10,
"layoutDurationMs": 2.6959999999999997,
"taskDurationMs": 512.0749999999999,
"heapDeltaBytes": 1314800,
"heapUsedBytes": 63154504,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.648999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.3000000000766,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.339,
"layouts": 9,
"layoutDurationMs": 2.214,
"taskDurationMs": 503.7100000000001,
"heapDeltaBytes": 1462396,
"heapUsedBytes": 63959956,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.095999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3289999999784,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.453,
"layouts": 8,
"layoutDurationMs": 1.971,
"taskDurationMs": 825.979,
"heapDeltaBytes": 17386348,
"heapUsedBytes": 79898788,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 114.685,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.7280000000646,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.209999999999999,
"layouts": 10,
"layoutDurationMs": 2.7109999999999994,
"taskDurationMs": 827.615,
"heapDeltaBytes": -5702064,
"heapUsedBytes": 65913404,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 112.18,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1486.105000000066,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.284,
"layouts": 5,
"layoutDurationMs": 17.930999999999994,
"taskDurationMs": 1197.7009999999998,
"heapDeltaBytes": 16615476,
"heapUsedBytes": 110611164,
"domNodes": 16030,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 36.9,
"eventListeners": 3246,
"totalBlockingTimeMs": 186,
"frameDurationMs": 20.546575342465747,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9332.601000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.850999999999996,
"layouts": 8,
"layoutDurationMs": 2.069,
"taskDurationMs": 5920.923,
"heapDeltaBytes": -4137684,
"heapUsedBytes": 71507864,
"domNodes": -257,
"jsHeapTotalBytes": 5824512,
"scriptDurationMs": 2695.965,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8849.570999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.165,
"layouts": 9,
"layoutDurationMs": 2.828,
"taskDurationMs": 5813.253000000001,
"heapDeltaBytes": -9987632,
"heapUsedBytes": 80796192,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2677.834,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23300.09199999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22947.104999999996,
"heapDeltaBytes": -20579900,
"heapUsedBytes": 259284076,
"domNodes": -3373,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 324.02799999999996,
"eventListeners": -669,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.87543859649123,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23048.287000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22341.837,
"heapDeltaBytes": -16577584,
"heapUsedBytes": 260505248,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 317.44899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.877162629757784,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28378.099999999904,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.30800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28117.822999999997,
"heapDeltaBytes": -24322592,
"heapUsedBytes": 271811016,
"domNodes": -3343,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 921.965,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 56.09130434782608,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27578.969999999914,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.412999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27164.925,
"heapDeltaBytes": -14334384,
"heapUsedBytes": 261908056,
"domNodes": -3343,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 855.397,
"eventListeners": -651,
"totalBlockingTimeMs": 55,
"frameDurationMs": 50.42468007312614,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8377.73900000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.215,
"layouts": 20,
"layoutDurationMs": 29.899000000000008,
"taskDurationMs": 8266.925000000001,
"heapDeltaBytes": -38368884,
"heapUsedBytes": 252360080,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 121.75499999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.536363636363646,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8233.372999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.92500000000001,
"layouts": 20,
"layoutDurationMs": 22.403999999999993,
"taskDurationMs": 8115.522,
"heapDeltaBytes": -5479468,
"heapUsedBytes": 272277208,
"domNodes": -3064,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 145.078,
"eventListeners": -590,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.23626373626374,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11734.370000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11484.914,
"heapDeltaBytes": -4314448,
"heapUsedBytes": 263767300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.43600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.08216783216783,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11389.591999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11053.926,
"heapDeltaBytes": 27546872,
"heapUsedBytes": 286396980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.86899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.71734693877551,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 502.10600000002614,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.491999999999999,
"layouts": 13,
"layoutDurationMs": 4.651,
"taskDurationMs": 145.269,
"heapDeltaBytes": 7269164,
"heapUsedBytes": 75191820,
"domNodes": 138,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.786000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 120.48300000003564,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.743,
"layouts": 9,
"layoutDurationMs": 3.5919999999999996,
"taskDurationMs": 80.596,
"heapDeltaBytes": 4602208,
"heapUsedBytes": 64613568,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.5059999999999985,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 432.7569999999241,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.61,
"layouts": 76,
"layoutDurationMs": 14.278,
"taskDurationMs": 382.376,
"heapDeltaBytes": -5015888,
"heapUsedBytes": 39002580,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 182.30300000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923079,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 491.45500000008724,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.633,
"layouts": 76,
"layoutDurationMs": 14.286,
"taskDurationMs": 442.29400000000004,
"heapDeltaBytes": -4034560,
"heapUsedBytes": 39789572,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 214.641,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 510.4790000000321,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6900000000000002,
"layouts": 76,
"layoutDurationMs": 14.116999999999999,
"taskDurationMs": 469.11,
"heapDeltaBytes": 890844,
"heapUsedBytes": 99005992,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 187.052,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 549.1550000000416,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5759999999999998,
"layouts": 76,
"layoutDurationMs": 14.523,
"taskDurationMs": 512.435,
"heapDeltaBytes": 570424,
"heapUsedBytes": 91230320,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 213.476,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3125 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8f24d4844e9f6840299c139efd5f4ca31be1592b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (221)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 8d16dc9 and the full merged-parent discussion. The backport preserves this branch's workspaceApi and telemetry paths while retaining stale-request/workspace guards and the five-minute reporting budget. Own isolated-checkout validation: all 193 tests across the five affected suites, application type check and scoped lint/format PASS. Reverting each of the three call-site handlers separately, removing the stale-rejection guard, or removing the warning budget each fails retained tests; the restored 193-test run passes. No remaining code blocker.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22312 +/- ##
==========================================
Coverage 87.11% 87.12%
==========================================
Files 3027 3028 +1
Lines 158494 158507 +13
Branches 42267 42272 +5
==========================================
+ Hits 138078 138092 +14
+ Misses 19740 19739 -1
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #22201 (
44cf08fb7b) tocore/1.59. The auto-backport failed on conflicts.What
Opening the account menu or the Credits settings section starts a balance read nobody awaits. When it fails, the rejection is unhandled and Sentry files a new error. With this change it is reported as one
billingwarning at most every 5 minutes, and a balance read replaced by a newer read (or by a workspace switch) settles quietly.Conflict resolution for 1.59
useWorkspaceBilling.ts: 1.59 reads throughworkspaceApi, notbillingApi. KeptworkspaceApi, applied the sharedisStaleBillingReadguard unchanged.SettingDialog.vue: import-only conflict (1.59 has noworkspaceBillingStateStoreimport). Added only therefreshBalanceInBackgroundimport.@comfyorg/telemetrypackage and no globalreportErrormock, so the new helper imports@/platform/telemetry/reportErrorand the four new tests mock it withvi.mock(import('@/platform/telemetry/reportError')).Verification
pnpm typecheck:app, oxfmt and oxlint pass.Linear: https://linear.app/comfyorg/issue/FRONT-3684