Repository navigation
[backport cloud/1.59] fix(billing): route the free-tier cloud-subscription 402 to the subscribe dialog (#21592) - #22306
Conversation
…ribe dialog (#21592) A FREE-tier Cloud account with no usable free run is refused at submit with a typed 402, `error.type: CLOUD_SUBSCRIPTION_REQUIRED` (the GTM-303 gate). The error catalog only knew the older `PAYMENT_REQUIRED` paywall string, so a canvas Run refused this way showed a raw error in the error panel instead of opening the subscription dialog. This matches the refusal by type, because its message changes with `credits_locked` ("…to queue workflows." / "…to use your credits on cloud."). The same free-tier gate also returns `FREE_TIER_EXHAUSTED`, `PARTNER_NODE_PAYMENT_REQUIRED` and `MODEL_PAYMENT_REQUIRED` 402s, whose remedy is also a plan. They now route to the subscribe dialog too. The retryable `FREE_TIER_UNAVAILABLE` 429 does not. The dialog opener waits for the selected pricing component to load; if loading fails or the dialog is unavailable, the original queue error stays visible. Extension callbacks retain their `Promise<void>` contract. Production case (2026-10-21, cloud `1.57.0`): a new email/password account was refused on every run because the free-run allowance is Google-sign-in only. Its canvas runs got this 402 with no subscribe prompt, and a few minutes later it bought credits on the platform billing page, which still cannot unlock Cloud runs without a plan. Identifiers stay in the internal tracker. <details><summary>Full context for agent readers</summary> - The Cloud ingest subscription gate refuses FREE-tier runs when `FreeTierRequireGoogleSignIn` withholds the allowance or no free run was consumed. - Queue submissions normalize the server refusal and resolve its account precondition. Unmatched refusals still use the error overlay or error dialog. - `FE-3434` assumes "a run rejected for no plan still goes to Subscribe / Resubscribe through `useAccountPreconditionDialog`". This change covers these typed refusals. - The Run button can show **Run** before a reload because workflow eligibility deliberately fails open while authenticated remote config is not loaded. A refused submission now attempts Subscribe and retains the error-panel fallback. Selling platform top-ups to Cloud free-tier accounts remains a separate product question. </details> - Targeted queue, classifier, billing-dialog, pricing, paywall, and URL-loader tests pass. Queue coverage uses the real account-precondition adapter and checks both dialog takeover and the original-error fallback. - The pricing-import regression fails against the original dialog implementation and passes with this fix. Forcing the adapter to return success also fails the queue fallback regression. - The retained local-distribution browser fallback tests pass against a running frontend and backend. The redundant Cloud-subscription browser case was removed because it passed before the fix; it did not prove successful subscription routing. - Cloud-distribution subscription dialog rendering has not been captured. The local browser checks verify the fallback overlay, not the Cloud pricing UI. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T23:21:40.401Z",
"gitSha": "fecf67cb9e043fc985109c6fe37b70b9443b53ca",
"branch": "backport-21592-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.1399999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9899999999999998,
"layouts": 9,
"layoutDurationMs": 2.897,
"taskDurationMs": 415.46900000000005,
"heapDeltaBytes": 1835592,
"heapUsedBytes": 63441860,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 11.278,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.4150000000136,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7810000000000006,
"layouts": 9,
"layoutDurationMs": 2.6750000000000003,
"taskDurationMs": 427.9789999999999,
"heapDeltaBytes": 24345468,
"heapUsedBytes": 85975176,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 11.404,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.8670000000116,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.381999999999998,
"layouts": 9,
"layoutDurationMs": 2.321,
"taskDurationMs": 682.619,
"heapDeltaBytes": 17309864,
"heapUsedBytes": 77466016,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 121.009,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5660000000325,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.401000000000002,
"layouts": 9,
"layoutDurationMs": 2.5140000000000007,
"taskDurationMs": 727.17,
"heapDeltaBytes": 17387484,
"heapUsedBytes": 78250024,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 126.79799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7739999999721,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.2299999999999995,
"layouts": 10,
"layoutDurationMs": 3.469,
"taskDurationMs": 335.92,
"heapDeltaBytes": 401908,
"heapUsedBytes": 70256112,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 13.656000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4010000000003,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.164999999999999,
"layouts": 11,
"layoutDurationMs": 3.184,
"taskDurationMs": 349.457,
"heapDeltaBytes": 19684976,
"heapUsedBytes": 80476468,
"domNodes": 56,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.406,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 574.5780000000025,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8410000000000006,
"layouts": 9,
"layoutDurationMs": 3.0450000000000004,
"taskDurationMs": 397.747,
"heapDeltaBytes": 3697580,
"heapUsedBytes": 63901428,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 138.229,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 588.8689999999883,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.738,
"layouts": 8,
"layoutDurationMs": 2.3360000000000003,
"taskDurationMs": 425.38,
"heapDeltaBytes": 4238152,
"heapUsedBytes": 63937988,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 143.749,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1019.5160000000101,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.639,
"heapDeltaBytes": -14655516,
"heapUsedBytes": 74262344,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 44.156,
"eventListeners": -106,
"totalBlockingTimeMs": 351,
"frameDurationMs": 28.238888888888887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1033.4980000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.9369999999999,
"heapDeltaBytes": -12913072,
"heapUsedBytes": 75384168,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 46.64,
"eventListeners": -106,
"totalBlockingTimeMs": 361,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.2249999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.1480000000001,
"heapDeltaBytes": -25110340,
"heapUsedBytes": 65294292,
"domNodes": -191,
"jsHeapTotalBytes": 2490368,
"scriptDurationMs": 103.548,
"eventListeners": -106,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.294444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.5769999999939,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.54000000000013,
"heapDeltaBytes": -26312800,
"heapUsedBytes": 66008972,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 108.52600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 119,
"frameDurationMs": 21.75833333333331,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7413.279000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6564.036,
"heapDeltaBytes": 51171612,
"heapUsedBytes": 125134628,
"domNodes": -257,
"jsHeapTotalBytes": 58322944,
"scriptDurationMs": 4872.557,
"eventListeners": -68,
"totalBlockingTimeMs": 78,
"frameDurationMs": 24.74816053511706,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7496.454000000029,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6100000000000003,
"layouts": 3,
"layoutDurationMs": 0.6750000000000003,
"taskDurationMs": 6586.628999999999,
"heapDeltaBytes": 65125892,
"heapUsedBytes": 139246000,
"domNodes": -257,
"jsHeapTotalBytes": 59633664,
"scriptDurationMs": 4994.817,
"eventListeners": -68,
"totalBlockingTimeMs": 77,
"frameDurationMs": 24.35,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7282.4540000000015,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.915,
"layouts": 3,
"layoutDurationMs": 0.872,
"taskDurationMs": 6430.336,
"heapDeltaBytes": 43931604,
"heapUsedBytes": 118458808,
"domNodes": -257,
"jsHeapTotalBytes": 52817920,
"scriptDurationMs": 4780.052000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 98,
"frameDurationMs": 24.941780821917806,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6850.909999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7200000000000002,
"layouts": 3,
"layoutDurationMs": 0.6410000000000001,
"taskDurationMs": 6027.049,
"heapDeltaBytes": -23195228,
"heapUsedBytes": 65078508,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 4485.162000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 62,
"frameDurationMs": 24.37651245551601,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 216.0030000000006,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.527000000000001,
"layouts": 11,
"layoutDurationMs": 3.326,
"taskDurationMs": 169.921,
"heapDeltaBytes": 14486884,
"heapUsedBytes": 84299644,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.603000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 162.87499999998545,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.158999999999999,
"layouts": 10,
"layoutDurationMs": 2.474,
"taskDurationMs": 119.123,
"heapDeltaBytes": 14357832,
"heapUsedBytes": 90385924,
"domNodes": 936,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.955000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912499999999966,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2043.1099999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6439999999999997,
"layouts": 10,
"layoutDurationMs": 2.7239999999999998,
"taskDurationMs": 495.71500000000003,
"heapDeltaBytes": -11615220,
"heapUsedBytes": 62442232,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.968,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.5709999999804,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8840000000000003,
"layouts": 8,
"layoutDurationMs": 2.5410000000000004,
"taskDurationMs": 570.957,
"heapDeltaBytes": 5277232,
"heapUsedBytes": 78210060,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 39.022999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2185.148999999996,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.649,
"layouts": 9,
"layoutDurationMs": 2.0060000000000002,
"taskDurationMs": 1325.4610000000002,
"heapDeltaBytes": -12810852,
"heapUsedBytes": 61198836,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 629.615,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2172.8780000000256,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.987999999999998,
"layouts": 7,
"layoutDurationMs": 1.69,
"taskDurationMs": 1440.671,
"heapDeltaBytes": 5930072,
"heapUsedBytes": 81194004,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 680.802,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3324.589000000003,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.690999999999999,
"layouts": 66,
"layoutDurationMs": 12.745,
"taskDurationMs": 1472.743,
"heapDeltaBytes": 5307876,
"heapUsedBytes": 82244980,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 625.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3421.6940000000022,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.517,
"layouts": 64,
"layoutDurationMs": 12.671999999999999,
"taskDurationMs": 1628.017,
"heapDeltaBytes": 7350748,
"heapUsedBytes": 82540800,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 674.479,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2182.7450000000113,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.207,
"layouts": 6,
"layoutDurationMs": 1.274,
"taskDurationMs": 1505.116,
"heapDeltaBytes": 11558396,
"heapUsedBytes": 90731508,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 708.4010000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615387,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2613.371000000029,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.824000000000001,
"layouts": 6,
"layoutDurationMs": 1.529,
"taskDurationMs": 1702.6800000000003,
"heapDeltaBytes": 11889360,
"heapUsedBytes": 89463664,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 804.029,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7741935483871,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3002.6260000000207,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2,
"layouts": 8,
"layoutDurationMs": 1.778,
"taskDurationMs": 690.621,
"heapDeltaBytes": 9002216,
"heapUsedBytes": 85112156,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 302.032,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3036.286999999959,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5849999999999995,
"layouts": 7,
"layoutDurationMs": 1.4729999999999999,
"taskDurationMs": 697.5600000000001,
"heapDeltaBytes": 5322476,
"heapUsedBytes": 81868284,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 311.226,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2018.417999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.332,
"layouts": 7,
"layoutDurationMs": 1.9279999999999997,
"taskDurationMs": 524.3910000000001,
"heapDeltaBytes": -14017064,
"heapUsedBytes": 61370244,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.628000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.2049999999622,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.432,
"layouts": 8,
"layoutDurationMs": 2.18,
"taskDurationMs": 528.481,
"heapDeltaBytes": 4521084,
"heapUsedBytes": 84419992,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.501999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3014.066000000014,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.113000000000001,
"layouts": 8,
"layoutDurationMs": 2.273,
"taskDurationMs": 581.6220000000001,
"heapDeltaBytes": -3620356,
"heapUsedBytes": 73243776,
"domNodes": -253,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 166.026,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66685082872928,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2675.0899999999547,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.878,
"layouts": 7,
"layoutDurationMs": 1.9040000000000004,
"taskDurationMs": 533.785,
"heapDeltaBytes": -14557896,
"heapUsedBytes": 64100116,
"domNodes": -249,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 154.721,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3133.312999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7889999999999997,
"layouts": 7,
"layoutDurationMs": 1.642,
"taskDurationMs": 791.03,
"heapDeltaBytes": -13313824,
"heapUsedBytes": 61840636,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 302.67499999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3164.92599999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.149,
"layouts": 8,
"layoutDurationMs": 2.027,
"taskDurationMs": 820.23,
"heapDeltaBytes": 261436,
"heapUsedBytes": 71391372,
"domNodes": -257,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 310.12,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665608465608464,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.2830000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.637,
"layouts": 9,
"layoutDurationMs": 2.425,
"taskDurationMs": 379.64,
"heapDeltaBytes": -1652384,
"heapUsedBytes": 60499268,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 124.113,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.519999999959,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.4110000000000005,
"layouts": 9,
"layoutDurationMs": 2.48,
"taskDurationMs": 371.633,
"heapDeltaBytes": -1336884,
"heapUsedBytes": 60364504,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 120.151,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.193000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9459999999999997,
"layouts": 10,
"layoutDurationMs": 2.657,
"taskDurationMs": 401.86000000000007,
"heapDeltaBytes": 547024,
"heapUsedBytes": 81812928,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.661,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2016.3149999999632,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0289999999999995,
"layouts": 11,
"layoutDurationMs": 2.8489999999999998,
"taskDurationMs": 435.27599999999995,
"heapDeltaBytes": 23571204,
"heapUsedBytes": 83449840,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.784999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5890000000118,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.921,
"layouts": 11,
"layoutDurationMs": 3.01,
"taskDurationMs": 684.2810000000001,
"heapDeltaBytes": 17471548,
"heapUsedBytes": 79913008,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 97.47500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1620000000098,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.207999999999998,
"layouts": 10,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 710.5500000000001,
"heapDeltaBytes": 13124428,
"heapUsedBytes": 75419696,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 99.218,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.4820000000345,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.502,
"layouts": 5,
"layoutDurationMs": 9.474,
"taskDurationMs": 766.8450000000003,
"heapDeltaBytes": 11469880,
"heapUsedBytes": 113117488,
"domNodes": 16030,
"jsHeapTotalBytes": 11669504,
"scriptDurationMs": 23.717999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 118,
"frameDurationMs": 20.452272727272717,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8263.435999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.017,
"layouts": 9,
"layoutDurationMs": 2.252,
"taskDurationMs": 4995.339999999999,
"heapDeltaBytes": -1770260,
"heapUsedBytes": 71902844,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2273.196,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66626262626263,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8218.107999999973,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.71,
"layouts": 8,
"layoutDurationMs": 2.234,
"taskDurationMs": 5103.641,
"heapDeltaBytes": 2057616,
"heapUsedBytes": 76101812,
"domNodes": -257,
"jsHeapTotalBytes": 3235840,
"scriptDurationMs": 2321.042,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16525.23199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15651.195,
"heapDeltaBytes": 36440332,
"heapUsedBytes": 308755868,
"domNodes": -3343,
"jsHeapTotalBytes": 49537024,
"scriptDurationMs": 261.758,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.238879456706282,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 18155.777000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17195.069,
"heapDeltaBytes": -10210096,
"heapUsedBytes": 262210268,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 266.52200000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.345768566493955,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 19973.041000000023,
"styleRecalcs": 161,
"styleRecalcDurationMs": 21.352999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19617.444000000003,
"heapDeltaBytes": -21426160,
"heapUsedBytes": 266581212,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 792.496,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.56758241758242,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20693.427999999927,
"styleRecalcs": 157,
"styleRecalcDurationMs": 23.41299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20354.42,
"heapDeltaBytes": -2978412,
"heapUsedBytes": 279487292,
"domNodes": -3343,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 834.3,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.690093457943924,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6026.175000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.59600000000001,
"layouts": 20,
"layoutDurationMs": 29.500999999999998,
"taskDurationMs": 5940.213999999999,
"heapDeltaBytes": -33080408,
"heapUsedBytes": 258459816,
"domNodes": -3343,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 100.007,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.9909604519774,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6326.656999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.16200000000001,
"layouts": 20,
"layoutDurationMs": 25.080000000000005,
"taskDurationMs": 6210.633000000001,
"heapDeltaBytes": -48189812,
"heapUsedBytes": 247853684,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 124.92100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 12,
"frameDurationMs": 37.47337278106509,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8876.29800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8604.354000000001,
"heapDeltaBytes": 14912732,
"heapUsedBytes": 276929580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.78999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.552669039145904,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8828.76699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8436.17,
"heapDeltaBytes": -14449696,
"heapUsedBytes": 262898464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.04,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.21166077738516,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 111.2070000000358,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7090000000000005,
"layouts": 8,
"layoutDurationMs": 2.4339999999999997,
"taskDurationMs": 74.00699999999999,
"heapDeltaBytes": 4728800,
"heapUsedBytes": 81413712,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 129.42599999996673,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.163,
"layouts": 8,
"layoutDurationMs": 2.838,
"taskDurationMs": 78.02199999999998,
"heapDeltaBytes": 4590824,
"heapUsedBytes": 65145836,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.464999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 297.77200000000903,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 12.059999999999999,
"taskDurationMs": 262.818,
"heapDeltaBytes": -6090600,
"heapUsedBytes": 35827992,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 109.739,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 295.65999999999804,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.655,
"layouts": 76,
"layoutDurationMs": 12.046,
"taskDurationMs": 256.373,
"heapDeltaBytes": -2133336,
"heapUsedBytes": 45621092,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.512,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672222222222242,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 414.3819999999323,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.772,
"layouts": 76,
"layoutDurationMs": 12.692,
"taskDurationMs": 369.195,
"heapDeltaBytes": -506408,
"heapUsedBytes": 92934848,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 134.457,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 384.69899999995505,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.789,
"layouts": 76,
"layoutDurationMs": 12.127,
"taskDurationMs": 343.219,
"heapDeltaBytes": -894492,
"heapUsedBytes": 92628912,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 120.256,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a0352720e387bb14875acc0725ae28c90b71a0f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #22306 +/- ##
=============================================
Coverage ? 87.10%
=============================================
Files ? 3027
Lines ? 158397
Branches ? 40157
=============================================
Hits ? 137979
Misses ? 19742
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #21592 to
cloud/1.59(auto-backport hit conflicts).Full context for agent readers
Cherry-pick of cef6e2f. Resolutions:
@comfyorg/telemetryimports mapped back to@/platform/telemetry(+reportErrorfrom@/platform/telemetry/reportError; the loading test mocks that module explicitly).startTeamWorkspaceUpgradeFlowkeeps this branch'suseWorkspaceDialogs().showTeamWorkspacesDialogand only gainsvoid showPricingTable().useBillingUImock maps touseWorkspaceUI.Tracking: https://linear.app/comfyorg/issue/PM-2273