Repository navigation
[backport core/1.58] FE-3099 fix(auth): switch local web SSO workspaces and say when sign-in fails - #22290
Conversation
…in fails (#22153) Two local web SSO QA findings (FE-3099, Denys, L11a and L14): - **L14, no workspace switcher.** Root cause: the local web auth bridge did not implement `switchWorkspace`, so `canDesktopHostSwitchWorkspace()` was false and the account menu hid the dropdown even though the workspace list was loaded. The OAuth token is bound to the workspace picked on consent and ingest has no endpoint that re-scopes it, so this does what Desktop's `CloudSession.switchWorkspace` does: keep each workspace's tokens (`Comfy.LocalWebSignIn.WorkspaceTokens`), switch straight to a workspace this page signed in to before (refreshing its tokens if expired), and go through consent otherwise. Sign-out forgets every workspace. - **L11a, silent failed sign-in.** Root cause: `startLocalWebSession` only called `reportError` when the returned sign-in failed. It now returns `sign-in-failed`, and `main.ts` shows the existing `auth.desktopHost.signInFailed` toast once Pinia is up. A declined consent still shows nothing. Not in this PR: L14's "User" instead of the account name. Host sessions show no display name on purpose (#20536) and the OAuth access token carries no `name` claim, so the name needs a server fact (a `name` claim, or a loopback-CORS profile endpoint). Same on Desktop. - Unit: `src/platform/auth/localWeb` + `desktopHost` (63 tests). New cases: switch to the current workspace, consent for an unknown workspace, instant switch back to a kept workspace, refresh of an expired kept workspace, sign-out forgets all, storage persistence of per-workspace tokens, `sign-in-failed` result. - Manual, staging: this branch built with `VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org`, core with Comfy-Org/ComfyUI#17410, `local_web_sso` + `partner_node_token` on, Chrome. | | AS IS | TO BE | | --- | --- | --- | | Failed sign-in (`/?code=bogus&state=bogus`) | Signed out, nothing shown (QA L11a) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/a4f7071eed4ea211ca8dbc8f9ca7ea73cd5d7f33/signin-failed-toast.jpg" width="420"> | | Account menu | Current workspace only, no dropdown (QA L14) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/f3d6973862faa142ec7463fbd2f265d1cd3bef63/workspace-switcher.jpg" width="420"> | | Switch back to a kept workspace | Log out and pick on consent | No page load, Personal active with its credits: <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/cd0ac1eca585549a0b95639d596c0dd846853fa4/switched-back-personal.jpg" width="420"> | Switching to `team-test` (never signed in to from this page) went through stagingcloud consent and came back on `team-test`; switching back to Personal then happened in place.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T20:19:27.135Z",
"gitSha": "cfb977f0b6231202651244d4369776e8a587f082",
"branch": "backport-22153-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.883000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.229,
"layouts": 9,
"layoutDurationMs": 2.9530000000000003,
"taskDurationMs": 610.355,
"heapDeltaBytes": 4181476,
"heapUsedBytes": 103595652,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.753,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2031.1179999999922,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3299999999999996,
"layouts": 9,
"layoutDurationMs": 3.2059999999999995,
"taskDurationMs": 680.394,
"heapDeltaBytes": 4166524,
"heapUsedBytes": 103636216,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 15.011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.6360000000004,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.72,
"layouts": 10,
"layoutDurationMs": 3.0460000000000003,
"taskDurationMs": 812.695,
"heapDeltaBytes": 1689116,
"heapUsedBytes": 102816164,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 173.04,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2025.0300000000152,
"styleRecalcs": 81,
"styleRecalcDurationMs": 15.933,
"layouts": 9,
"layoutDurationMs": 2.93,
"taskDurationMs": 1083.2820000000002,
"heapDeltaBytes": -2788496,
"heapUsedBytes": 87671984,
"domNodes": -210,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 188.793,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.1820000000462,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.354,
"layouts": 10,
"layoutDurationMs": 3.3449999999999993,
"taskDurationMs": 456.08200000000005,
"heapDeltaBytes": 25425384,
"heapUsedBytes": 115640896,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.504999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9060000000036,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.011000000000001,
"layouts": 10,
"layoutDurationMs": 3.284,
"taskDurationMs": 505.13999999999993,
"heapDeltaBytes": -1259012,
"heapUsedBytes": 89062340,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 17.395999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 762.0650000000069,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2030000000000003,
"layouts": 9,
"layoutDurationMs": 2.982,
"taskDurationMs": 528.481,
"heapDeltaBytes": 4083228,
"heapUsedBytes": 94456432,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 175.969,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 683.7900000000445,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1859999999999995,
"layouts": 10,
"layoutDurationMs": 2.7950000000000004,
"taskDurationMs": 469.83799999999997,
"heapDeltaBytes": 5380780,
"heapUsedBytes": 103940644,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 176.615,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1292.2499999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 972.6530000000001,
"heapDeltaBytes": 14420368,
"heapUsedBytes": 132983004,
"domNodes": -210,
"jsHeapTotalBytes": 13598720,
"scriptDurationMs": 83.09199999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 629,
"frameDurationMs": 36.665714285714294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1302.4819999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1034.8899999999999,
"heapDeltaBytes": -15032192,
"heapUsedBytes": 102812752,
"domNodes": -230,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 73.123,
"eventListeners": -168,
"totalBlockingTimeMs": 587,
"frameDurationMs": 34.21052631578947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.32499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.3720000000003,
"heapDeltaBytes": -4129640,
"heapUsedBytes": 97745004,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 179.078,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.234285714285736,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.8109999999892,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.75899999999984,
"heapDeltaBytes": -4034468,
"heapUsedBytes": 97812780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.59999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11688.310000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10836.286,
"heapDeltaBytes": 53751908,
"heapUsedBytes": 157980096,
"domNodes": -296,
"jsHeapTotalBytes": 43319296,
"scriptDurationMs": 9050.738000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1729,
"frameDurationMs": 33.475071633237825,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11698.225999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10807.110999999999,
"heapDeltaBytes": 50812740,
"heapUsedBytes": 157038788,
"domNodes": -276,
"jsHeapTotalBytes": 37629952,
"scriptDurationMs": 8643.821,
"eventListeners": -130,
"totalBlockingTimeMs": 1335,
"frameDurationMs": 31.198666666666668,
"p95FrameDurationMs": 66.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9934.63,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9099.138,
"heapDeltaBytes": 38582724,
"heapUsedBytes": 142930528,
"domNodes": -296,
"jsHeapTotalBytes": 29425664,
"scriptDurationMs": 7399.459,
"eventListeners": -130,
"totalBlockingTimeMs": 877,
"frameDurationMs": 31.08557993730407,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11469.855999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10644.556,
"heapDeltaBytes": 36792080,
"heapUsedBytes": 151183104,
"domNodes": -296,
"jsHeapTotalBytes": 32911360,
"scriptDurationMs": 8557.422,
"eventListeners": -130,
"totalBlockingTimeMs": 1495,
"frameDurationMs": 31.89666666666667,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 241.30499999998278,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.306,
"layouts": 12,
"layoutDurationMs": 3.846,
"taskDurationMs": 181.13799999999998,
"heapDeltaBytes": 13246596,
"heapUsedBytes": 119973584,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.353000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25.933333333333394,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 236.32400000002463,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.856999999999996,
"layouts": 12,
"layoutDurationMs": 3.526,
"taskDurationMs": 177.278,
"heapDeltaBytes": 13308936,
"heapUsedBytes": 120142284,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.91,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25.933333333333394,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2057.8009999999836,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0730000000000004,
"layouts": 8,
"layoutDurationMs": 3.006,
"taskDurationMs": 615.2390000000001,
"heapDeltaBytes": -260328,
"heapUsedBytes": 110332924,
"domNodes": -297,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 39.666,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.5749999999525,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.123999999999999,
"layouts": 9,
"layoutDurationMs": 3.46,
"taskDurationMs": 609.713,
"heapDeltaBytes": 834156,
"heapUsedBytes": 111510532,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 36.67400000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2959.3909999999823,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.753000000000002,
"layouts": 6,
"layoutDurationMs": 1.751,
"taskDurationMs": 1897.517,
"heapDeltaBytes": -35089824,
"heapUsedBytes": 88465088,
"domNodes": -297,
"jsHeapTotalBytes": 471040,
"scriptDurationMs": 892.945,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2956.719000000021,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.082999999999998,
"layouts": 6,
"layoutDurationMs": 1.925,
"taskDurationMs": 1931.416,
"heapDeltaBytes": 748884,
"heapUsedBytes": 104649920,
"domNodes": -296,
"jsHeapTotalBytes": -466944,
"scriptDurationMs": 910.8739999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3849.5959999999627,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.77,
"layouts": 65,
"layoutDurationMs": 12.642,
"taskDurationMs": 1867.031,
"heapDeltaBytes": -7530796,
"heapUsedBytes": 105378928,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 879.162,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73930131004367,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4011.8760000000293,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.672999999999998,
"layouts": 64,
"layoutDurationMs": 11.453999999999999,
"taskDurationMs": 1978.7890000000002,
"heapDeltaBytes": -18520024,
"heapUsedBytes": 87274504,
"domNodes": -272,
"jsHeapTotalBytes": -299008,
"scriptDurationMs": 858.307,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73541666666667,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3252.5679999999966,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.202999999999999,
"layouts": 5,
"layoutDurationMs": 1.611,
"taskDurationMs": 1996.902,
"heapDeltaBytes": -15214476,
"heapUsedBytes": 99185336,
"domNodes": 0,
"jsHeapTotalBytes": 2519040,
"scriptDurationMs": 1045.471,
"eventListeners": 182,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.102094240837697,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2923.7550000000283,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.952000000000001,
"layouts": 6,
"layoutDurationMs": 1.8119999999999998,
"taskDurationMs": 1873.5620000000001,
"heapDeltaBytes": -12030788,
"heapUsedBytes": 103079388,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 1002.456,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858381502890172,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.7299999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 7,
"layoutDurationMs": 2.022,
"taskDurationMs": 512.8779999999999,
"heapDeltaBytes": -278424,
"heapUsedBytes": 111746196,
"domNodes": -296,
"jsHeapTotalBytes": 327680,
"scriptDurationMs": 35.013,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2071.578999999929,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5120000000000005,
"layouts": 7,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 751.939,
"heapDeltaBytes": -22198132,
"heapUsedBytes": 101175460,
"domNodes": -296,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 39.221999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 710.2939999999762,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9769999999999985,
"layouts": 8,
"layoutDurationMs": 2.0190000000000006,
"taskDurationMs": 494.82800000000003,
"heapDeltaBytes": 22560192,
"heapUsedBytes": 114328504,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 146.677,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 708.4020000000919,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.143000000000001,
"layouts": 8,
"layoutDurationMs": 2.481,
"taskDurationMs": 468.427,
"heapDeltaBytes": 4885004,
"heapUsedBytes": 108159124,
"domNodes": 0,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 147.361,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2054.649000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4659999999999993,
"layouts": 9,
"layoutDurationMs": 3.3510000000000004,
"taskDurationMs": 543.718,
"heapDeltaBytes": 6253936,
"heapUsedBytes": 97118316,
"domNodes": -218,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 14.067,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2057.8540000000203,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.614,
"layouts": 10,
"layoutDurationMs": 3.51,
"taskDurationMs": 724.928,
"heapDeltaBytes": -12354440,
"heapUsedBytes": 89897100,
"domNodes": -218,
"jsHeapTotalBytes": 7221248,
"scriptDurationMs": 14.606000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2043.275000000051,
"styleRecalcs": 89,
"styleRecalcDurationMs": 16.831,
"layouts": 9,
"layoutDurationMs": 2.755,
"taskDurationMs": 1176.13,
"heapDeltaBytes": -6391824,
"heapUsedBytes": 94987752,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 120.77899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.0810000000238,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.137999999999998,
"layouts": 9,
"layoutDurationMs": 3.0950000000000006,
"taskDurationMs": 878.7739999999999,
"heapDeltaBytes": 2287008,
"heapUsedBytes": 93441520,
"domNodes": -190,
"jsHeapTotalBytes": 2686976,
"scriptDurationMs": 126.62899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.7169999999933,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.816000000000003,
"layouts": 5,
"layoutDurationMs": 17.842,
"taskDurationMs": 978.7909999999999,
"heapDeltaBytes": 35393360,
"heapUsedBytes": 137485992,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 46.657000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 193,
"frameDurationMs": 20.60138888888889,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10509.334000000024,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.427000000000003,
"layouts": 6,
"layoutDurationMs": 1.8999999999999997,
"taskDurationMs": 6445.990999999999,
"heapDeltaBytes": 10382964,
"heapUsedBytes": 113119680,
"domNodes": -276,
"jsHeapTotalBytes": -2072576,
"scriptDurationMs": 2843.427,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69253968253968,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10218.996999999945,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.948000000000004,
"layouts": 9,
"layoutDurationMs": 2.5080000000000005,
"taskDurationMs": 6312.668,
"heapDeltaBytes": -9613112,
"heapUsedBytes": 112849264,
"domNodes": -296,
"jsHeapTotalBytes": -413696,
"scriptDurationMs": 2827.111,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666068515497553,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16986.762999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16078.344000000001,
"heapDeltaBytes": 643764,
"heapUsedBytes": 305313232,
"domNodes": -3344,
"jsHeapTotalBytes": -12288,
"scriptDurationMs": 263.68100000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.330915371329883,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16654.37499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15744.881,
"heapDeltaBytes": -44803304,
"heapUsedBytes": 280926748,
"domNodes": -2766,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 251.292,
"eventListeners": -535,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.034668989547036,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19949.112000000016,
"styleRecalcs": 150,
"styleRecalcDurationMs": 17.66899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19584.771,
"heapDeltaBytes": -39843996,
"heapUsedBytes": 283995112,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 899.873,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.604220183486234,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 28278.013999999985,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.751000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27913.972,
"heapDeltaBytes": -4523228,
"heapUsedBytes": 306205612,
"domNodes": -2276,
"jsHeapTotalBytes": 7782400,
"scriptDurationMs": 934.5419999999999,
"eventListeners": -421,
"totalBlockingTimeMs": 35,
"frameDurationMs": 53.062288930581616,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8486.466000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.051,
"layouts": 20,
"layoutDurationMs": 25.525999999999993,
"taskDurationMs": 8395.121,
"heapDeltaBytes": -60374096,
"heapUsedBytes": 259287056,
"domNodes": -3344,
"jsHeapTotalBytes": 3919872,
"scriptDurationMs": 129.064,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.75229885057471,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8241.325999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.67599999999999,
"layouts": 20,
"layoutDurationMs": 24.555999999999994,
"taskDurationMs": 8125.557000000001,
"heapDeltaBytes": -12043692,
"heapUsedBytes": 293836040,
"domNodes": -3373,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 125.48799999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.08715083798883,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8080.215000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7643.564999999999,
"heapDeltaBytes": -8967520,
"heapUsedBytes": 285231076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.70600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.36140350877193,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11415.155000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11098.904,
"heapDeltaBytes": -20173096,
"heapUsedBytes": 270699328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.13400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.366206896551724,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 152.66100000002325,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.997,
"layouts": 9,
"layoutDurationMs": 4.4670000000000005,
"taskDurationMs": 118.81,
"heapDeltaBytes": 4984608,
"heapUsedBytes": 95072040,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.535,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 130.0499999999829,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.753,
"layouts": 9,
"layoutDurationMs": 2.9160000000000004,
"taskDurationMs": 91.596,
"heapDeltaBytes": 4761636,
"heapUsedBytes": 95193652,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.638000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 471.7150000000174,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6849999999999999,
"layouts": 76,
"layoutDurationMs": 15.858,
"taskDurationMs": 425.96700000000004,
"heapDeltaBytes": -14933332,
"heapUsedBytes": 81769744,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 197.69,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 511.8280000000368,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.785,
"layouts": 76,
"layoutDurationMs": 15.270000000000001,
"taskDurationMs": 467.92699999999996,
"heapDeltaBytes": 12712092,
"heapUsedBytes": 81873456,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 228.617,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 858.2959999999957,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.842,
"layouts": 76,
"layoutDurationMs": 18.575000000000003,
"taskDurationMs": 775.302,
"heapDeltaBytes": 3744808,
"heapUsedBytes": 125061712,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 331.31,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 622.8839999999991,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.036,
"layouts": 76,
"layoutDurationMs": 15.737999999999998,
"taskDurationMs": 568.9100000000001,
"heapDeltaBytes": 904364,
"heapUsedBytes": 118595800,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 229.30100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 59.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2984 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7af2ab1af15601828ffdbc2bf25f4030325d442b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (131)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.58 #22290 +/- ##
=============================================
- Coverage 84.30% 84.02% -0.29%
=============================================
Files 3106 3175 +69
Lines 163583 165818 +2235
Branches 41708 41744 +36
=============================================
+ Hits 137913 139331 +1418
- Misses 25278 26095 +817
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 116 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The core/1.58 backport preserves the workspace-switch and failed-sign-in behavior from PR 22153.
Full context for agent readers
All seven source files are present. Four resulting files match byte-for-byte. The three differences are required by the older branch: its bootstrap is not tracer-wrapped, its local sign-in test still uses the redirect flow, and its identity fixture includes the older name field. No package manifest changed.
Manual backport of #22153 to
core/1.58. The bot cherry-pick conflicted insrc/main.ts.Why
Local SSO QA (L11a, L14) passes only on the #22153 build. QA needs it on
core/1.58to retest and to cut v1.58.2.How
Cherry-pick of e921e69. The only conflict is in
src/main.ts: oncore/1.58,startLocalAuthSessionis not wrapped in main'sstartup/local-authtracer span. I kept 1.58's structure and ported only the change, which makes it return whether the returned sign-in failed soshowLocalSignInFailurecan toast once Pinia is up. All other files apply unchanged.src/platform/auth/localWebanddesktopHosttests pass on this branch (74).AS IS / TO BE
Same as #22153 (screenshots there): a failed return shows "Sign-in didn't finish. Try again.", and the account menu lists every workspace and switches in place.