Repository navigation
refactor: resolve extension-manager role violations - #22289
Conversation
📦 Bundle: 12 MB gzip 🟢 -3.25 kBDetailsSummary
Category Glance App Entry Points — 6.68 kB (baseline 6.68 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.58 MB (baseline 2.59 MB) • 🟢 -10.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 5 unchanged Panels & Settings — 873 kB (baseline 873 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 21 unchanged Data & Services — 1.91 MB (baseline 1.91 MB) • 🟢 -1.5 kBStores, services, APIs, and repositories
Status: 36 added / 36 removed / 6 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +145 BHelpers, composables, and utility bundles
Status: 49 added / 49 removed / 35 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🟢 -1.21 kBBundles that do not match a named category
Status: 119 added / 119 removed / 628 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T23:05:05.617Z",
"gitSha": "d0a2d61b2ea06933cb8acfd9e6291f33ddfa2141",
"branch": "refactor/manager-role-violations",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.494999999949,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8669999999999995,
"layouts": 9,
"layoutDurationMs": 2.8890000000000002,
"taskDurationMs": 529.0640000000001,
"heapDeltaBytes": 1682724,
"heapUsedBytes": 63263468,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.542000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2022.7219999999306,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9959999999999996,
"layouts": 10,
"layoutDurationMs": 3.0420000000000003,
"taskDurationMs": 558.341,
"heapDeltaBytes": 5278324,
"heapUsedBytes": 76751592,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.208000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.6069999999827,
"styleRecalcs": 80,
"styleRecalcDurationMs": 12.985,
"layouts": 10,
"layoutDurationMs": 2.8289999999999997,
"taskDurationMs": 904.6469999999999,
"heapDeltaBytes": 22235584,
"heapUsedBytes": 83567728,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 152.788,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.8580000000593,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.725,
"layouts": 9,
"layoutDurationMs": 2.3770000000000002,
"taskDurationMs": 909.423,
"heapDeltaBytes": 21994324,
"heapUsedBytes": 83416004,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 152.14999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.7950000000847,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.819999999999999,
"layouts": 10,
"layoutDurationMs": 3.386,
"taskDurationMs": 473.441,
"heapDeltaBytes": 24117212,
"heapUsedBytes": 86026900,
"domNodes": 57,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 14.411,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4909999999436,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.844,
"layouts": 11,
"layoutDurationMs": 2.7599999999999993,
"taskDurationMs": 434.54200000000003,
"heapDeltaBytes": -520552,
"heapUsedBytes": 61120076,
"domNodes": 57,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 13.150999999999996,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.5110000000586,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.698000000000001,
"layouts": 10,
"layoutDurationMs": 2.4940000000000007,
"taskDurationMs": 491.04699999999997,
"heapDeltaBytes": 5775416,
"heapUsedBytes": 67488548,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 158.829,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 703.4030000000939,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2430000000000003,
"layouts": 10,
"layoutDurationMs": 2.6950000000000003,
"taskDurationMs": 508.4789999999999,
"heapDeltaBytes": 7321324,
"heapUsedBytes": 77259516,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 164.822,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.5209999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 902.241,
"heapDeltaBytes": -13141620,
"heapUsedBytes": 75289516,
"domNodes": -203,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 58.928999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 529,
"frameDurationMs": 33.33055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1227.5220000000218,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 950.601,
"heapDeltaBytes": -13064896,
"heapUsedBytes": 75369512,
"domNodes": -203,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 67.794,
"eventListeners": -106,
"totalBlockingTimeMs": 542,
"frameDurationMs": 33.335135135135125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.353999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.6339999999997,
"heapDeltaBytes": -15939400,
"heapUsedBytes": 65732880,
"domNodes": -203,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 138.43499999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 187,
"frameDurationMs": 23.613888888888873,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 889.2070000000558,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.4130000000001,
"heapDeltaBytes": -29106348,
"heapUsedBytes": 67043464,
"domNodes": -203,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 149.89999999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 197,
"frameDurationMs": 23.875675675675666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10304.981999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9392.937,
"heapDeltaBytes": 70818292,
"heapUsedBytes": 152366508,
"domNodes": -269,
"jsHeapTotalBytes": 63303680,
"scriptDurationMs": 7149.7880000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 556,
"frameDurationMs": 30.29294117647059,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9485.742000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8621.067000000001,
"heapDeltaBytes": 38655776,
"heapUsedBytes": 131959176,
"domNodes": -269,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 6596.364,
"eventListeners": -68,
"totalBlockingTimeMs": 261,
"frameDurationMs": 29.6340625,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9811.466000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8969.259000000002,
"heapDeltaBytes": 44006748,
"heapUsedBytes": 123130196,
"domNodes": -269,
"jsHeapTotalBytes": 58060800,
"scriptDurationMs": 6883.744,
"eventListeners": -68,
"totalBlockingTimeMs": 477,
"frameDurationMs": 30.96624605678233,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10331.727,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3849999999999999,
"layouts": 1,
"layoutDurationMs": 0.3290000000000003,
"taskDurationMs": 9539.786,
"heapDeltaBytes": 68683164,
"heapUsedBytes": 151383572,
"domNodes": -269,
"jsHeapTotalBytes": 73527296,
"scriptDurationMs": 7451.351,
"eventListeners": -68,
"totalBlockingTimeMs": 578,
"frameDurationMs": 31.502743902439022,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 283.4100000000035,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.995,
"layouts": 12,
"layoutDurationMs": 3.939999999999999,
"taskDurationMs": 236.479,
"heapDeltaBytes": -6993204,
"heapUsedBytes": 75290384,
"domNodes": 936,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.477000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.600000000000023,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 266.2359999999353,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.831999999999999,
"layouts": 12,
"layoutDurationMs": 4.204999999999999,
"taskDurationMs": 217.76700000000002,
"heapDeltaBytes": 14500648,
"heapUsedBytes": 86037304,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.977,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 26.66999999999998,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2040.5499999999392,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.352,
"layouts": 8,
"layoutDurationMs": 2.262,
"taskDurationMs": 638.661,
"heapDeltaBytes": -23462880,
"heapUsedBytes": 69099268,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 32.942,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2056.732000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3419999999999996,
"layouts": 8,
"layoutDurationMs": 2.446,
"taskDurationMs": 676.4069999999999,
"heapDeltaBytes": -25176120,
"heapUsedBytes": 62358028,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 32.93500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2733.4119999999302,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.935,
"layouts": 7,
"layoutDurationMs": 1.865,
"taskDurationMs": 1873.573,
"heapDeltaBytes": -17972316,
"heapUsedBytes": 72990988,
"domNodes": -269,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 865.2409999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7680981595092,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2635.462999999959,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.785999999999998,
"layouts": 7,
"layoutDurationMs": 1.9120000000000001,
"taskDurationMs": 1852.4509999999998,
"heapDeltaBytes": -20052828,
"heapUsedBytes": 73083356,
"domNodes": -269,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 882.33,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665822784810125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4041.08599999995,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.13,
"layouts": 64,
"layoutDurationMs": 11.581999999999999,
"taskDurationMs": 2078.348,
"heapDeltaBytes": -30108396,
"heapUsedBytes": 61237680,
"domNodes": -245,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 890.595,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3668.6369999999897,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.058,
"layouts": 65,
"layoutDurationMs": 10.912999999999998,
"taskDurationMs": 1870.539,
"heapDeltaBytes": -6648192,
"heapUsedBytes": 70273332,
"domNodes": -245,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 808.669,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3320.4240000000027,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.351999999999999,
"layouts": 4,
"layoutDurationMs": 0.9690000000000002,
"taskDurationMs": 2245.387,
"heapDeltaBytes": 13406576,
"heapUsedBytes": 85842004,
"domNodes": -269,
"jsHeapTotalBytes": 3166208,
"scriptDurationMs": 1049.751,
"eventListeners": -60,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.835532994923856,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3180.4659999999103,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.213,
"layouts": 5,
"layoutDurationMs": 1.254,
"taskDurationMs": 2092.7540000000004,
"heapDeltaBytes": -2433300,
"heapUsedBytes": 70355764,
"domNodes": 0,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1013.7150000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.020744680851063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3140.1290000000017,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4810000000000005,
"layouts": 5,
"layoutDurationMs": 1.3239999999999996,
"taskDurationMs": 837.294,
"heapDeltaBytes": -7916248,
"heapUsedBytes": 86637656,
"domNodes": -269,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 377.162,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3168.745000000058,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8349999999999997,
"layouts": 7,
"layoutDurationMs": 1.6849999999999994,
"taskDurationMs": 858.984,
"heapDeltaBytes": -21263476,
"heapUsedBytes": 69000216,
"domNodes": -269,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 389.294,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754497354497357,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.918999999946,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1710000000000003,
"layouts": 7,
"layoutDurationMs": 2.377,
"taskDurationMs": 734.0120000000001,
"heapDeltaBytes": -8251460,
"heapUsedBytes": 66708904,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.632999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.4219999999832,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9180000000000004,
"layouts": 6,
"layoutDurationMs": 1.7289999999999996,
"taskDurationMs": 659.9609999999999,
"heapDeltaBytes": -27941784,
"heapUsedBytes": 61891680,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 34.18000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2854.473999999982,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.858999999999998,
"layouts": 7,
"layoutDurationMs": 2.215,
"taskDurationMs": 662.901,
"heapDeltaBytes": -20140892,
"heapUsedBytes": 68824632,
"domNodes": -266,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 197.21800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666081871345032,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2942.356000000018,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.488999999999999,
"layouts": 7,
"layoutDurationMs": 2.3280000000000003,
"taskDurationMs": 665.059,
"heapDeltaBytes": -10858060,
"heapUsedBytes": 65359336,
"domNodes": -267,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 189.54299999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3351.5259999999785,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0019999999999993,
"layouts": 7,
"layoutDurationMs": 1.98,
"taskDurationMs": 1026.0699999999997,
"heapDeltaBytes": -14925240,
"heapUsedBytes": 74713048,
"domNodes": -269,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 393.14400000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666169154228854,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3360.141999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.152,
"layouts": 7,
"layoutDurationMs": 2.0660000000000003,
"taskDurationMs": 1038.6850000000002,
"heapDeltaBytes": -31912260,
"heapUsedBytes": 60479152,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 395.415,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 680.5209999999988,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.927,
"layouts": 9,
"layoutDurationMs": 2.8299999999999996,
"taskDurationMs": 486.431,
"heapDeltaBytes": -311396,
"heapUsedBytes": 61786304,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 152.984,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.5289999999541,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.32,
"layouts": 9,
"layoutDurationMs": 2.554,
"taskDurationMs": 463.6020000000001,
"heapDeltaBytes": -182684,
"heapUsedBytes": 62625176,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 144.033,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.1630000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.576,
"layouts": 9,
"layoutDurationMs": 2.755,
"taskDurationMs": 522.2090000000001,
"heapDeltaBytes": 1886344,
"heapUsedBytes": 64433060,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.398,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.3140000000276,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6870000000000003,
"layouts": 9,
"layoutDurationMs": 2.9530000000000003,
"taskDurationMs": 567.2120000000001,
"heapDeltaBytes": 2215180,
"heapUsedBytes": 65283572,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.214,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.9530000000277,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.781999999999998,
"layouts": 8,
"layoutDurationMs": 2.228,
"taskDurationMs": 864.457,
"heapDeltaBytes": 18444940,
"heapUsedBytes": 81177544,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 103.20400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.4879999999648,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.507,
"layouts": 8,
"layoutDurationMs": 2.2650000000000006,
"taskDurationMs": 884.5390000000001,
"heapDeltaBytes": 20421080,
"heapUsedBytes": 82463544,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 106.50899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.7099999999718,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.683999999999997,
"layouts": 5,
"layoutDurationMs": 12.677000000000001,
"taskDurationMs": 1101.798,
"heapDeltaBytes": 11622240,
"heapUsedBytes": 113454292,
"domNodes": 16029,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 29.305999999999997,
"eventListeners": 3246,
"totalBlockingTimeMs": 145,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9394.908999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.53,
"layouts": 8,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 6602.983,
"heapDeltaBytes": -27957776,
"heapUsedBytes": 62456076,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 2912.909,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6955595026643,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8494.102999999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 28.165000000000003,
"layouts": 4,
"layoutDurationMs": 1.046,
"taskDurationMs": 6175.903,
"heapDeltaBytes": 19796516,
"heapUsedBytes": 80340264,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 2729.669,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698622047244093,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21272.606999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21023.54,
"heapDeltaBytes": -22142908,
"heapUsedBytes": 279768272,
"domNodes": -3343,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 335.54599999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.505820105820106,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21035.793000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20357.827999999998,
"heapDeltaBytes": -8428712,
"heapUsedBytes": 275120880,
"domNodes": -3343,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 292.38599999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.83450087565674,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 26190.770000000044,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.411000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25995.97,
"heapDeltaBytes": -23231652,
"heapUsedBytes": 265774412,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 912.2020000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.153846153846146,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25883.003999999914,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.346999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25608.171000000002,
"heapDeltaBytes": -38739668,
"heapUsedBytes": 253464940,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 898.8439999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 30,
"frameDurationMs": 48.050092764378476,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7662.5380000000405,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.00999999999999,
"layouts": 20,
"layoutDurationMs": 30.218000000000007,
"taskDurationMs": 7564.945999999999,
"heapDeltaBytes": -13187048,
"heapUsedBytes": 264917956,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 125.771,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.431443298969064,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 7623.604,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.686,
"layouts": 20,
"layoutDurationMs": 34.61399999999999,
"taskDurationMs": 7504.121,
"heapDeltaBytes": -10423736,
"heapUsedBytes": 266857732,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 150.364,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.64010695187165,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10463.056000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10184.189,
"heapDeltaBytes": -8558180,
"heapUsedBytes": 271855624,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 145.24999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.379285714285714,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10235.560999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10037.956,
"heapDeltaBytes": 18806956,
"heapUsedBytes": 269912120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.07599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.325842696629216,
"p95FrameDurationMs": 83.19999999999709
},
{
"name": "workflow-execution",
"durationMs": 162.28300000000218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.948,
"layouts": 9,
"layoutDurationMs": 3.7670000000000003,
"taskDurationMs": 117.406,
"heapDeltaBytes": -12782984,
"heapUsedBytes": 63529396,
"domNodes": 105,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.156999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 141.64199999993343,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.477999999999998,
"layouts": 9,
"layoutDurationMs": 4.085,
"taskDurationMs": 104.63000000000001,
"heapDeltaBytes": 4690440,
"heapUsedBytes": 64224676,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.502,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 559.0429999999742,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.639,
"layouts": 76,
"layoutDurationMs": 17.502,
"taskDurationMs": 511.89000000000004,
"heapDeltaBytes": -3768280,
"heapUsedBytes": 39679584,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 239.84900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 520.2389999999468,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.636,
"layouts": 76,
"layoutDurationMs": 16.279999999999998,
"taskDurationMs": 465.331,
"heapDeltaBytes": -4069072,
"heapUsedBytes": 40544068,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 213.398,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 581.7000000000689,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.925,
"layouts": 76,
"layoutDurationMs": 16.154999999999998,
"taskDurationMs": 538.525,
"heapDeltaBytes": 1526604,
"heapUsedBytes": 103832796,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 207.689,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 616.2139999998999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.806,
"layouts": 76,
"layoutDurationMs": 16.328,
"taskDurationMs": 566.252,
"heapDeltaBytes": 524116,
"heapUsedBytes": 94776884,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 219.527,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison. Line coverage: 63.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3166 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e41f40b4c5131e5aa84dcddb770280799144ac16
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (289)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
This function should probably go into platform/customNodes
There was a problem hiding this comment.
Moved extractCustomNodeName into platform/customNodes/manager/utils/packUtils.ts, next to normalizePackId, in 082c227. nodeHelpUtil and nodeHelpService now import it from there. nodeHelpService (node-library) crossing into extension-manager would have been a new boundary violation, so node-library now lists extension-manager as a dependency, and extension-manager lists node-library as a consumer.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22289 +/- ##
=========================================
Coverage 87.51% 87.52%
=========================================
Files 2938 2832 -106
Lines 159350 155419 -3931
Branches 41706 40553 -1153
=========================================
- Hits 139455 136029 -3426
+ Misses 18973 18633 -340
+ Partials 922 757 -165
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 310 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Composables that open Vue dialogs import their components, so they belong to the presentation role, matching useEditKeybindingDialog. Their only callers are components, the workflow-error adapter, and useHelpCenter, which now follow them. Tests that render components alongside the store or mock the manager service are integration. Amp-Thread-ID: https://ampcode.com/threads/T-c306b114-e2dd-4bcd-b141-3ea4af961de4
Lets the extension-manager record claim the dialog composables and the domain types as directories instead of listing each file. Amp-Thread-ID: https://ampcode.com/threads/T-c306b114-e2dd-4bcd-b141-3ea4af961de4
useServerLogs, packUtils and mapperUtil are only used by the manager, so they move under it and the record claims them through services/** and utils/**. packUpdateStatus moves beside its nodePack callers, removing its application exception. Amp-Thread-ID: https://ampcode.com/threads/T-c306b114-e2dd-4bcd-b141-3ea4af961de4
It parses a custom_nodes module path into a normalized pack id, so it belongs beside normalizePackId. node-library now declares its dependency on extension-manager for nodeHelpService's import. Amp-Thread-ID: https://ampcode.com/threads/T-c306b114-e2dd-4bcd-b141-3ea4af961de4
082c227 to
a0bfce4
Compare
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: a0bfce4 | Docs | View more details | Give us feedback! |
…#22292) ## Summary Stacked on Comfy-Org#22289. A test that no record names now takes the domain and role of the file path it checks (`foo.ts` claims `foo.test.ts` and `foo.cloud.test.ts`; the longest matching file path wins), so records list a test only when its role differs from its subject's. `architecture:check` warns about test entries that repeat their subject's role, and the redundant entries across the records are removed. Tests that were unclassified now join their subject's domain. Their existing cross-domain imports become visible as inherited boundary violations, most from `src/extensions/core/index.test.ts`. The `new-only` audit gate treats them as inherited. ## Verification - `pnpm test:unit tools/architecture`: a new case covers inheritance, the longest-subject tie-break, and a name that only shares a prefix staying unclassified; it fails when the tie-break is reversed. - `pnpm architecture:check` passes; unclassified-file warnings drop because those tests are now classified. - `pnpm exec fallow audit` passes.
Summary
Follow-up to #22156. Removes every role-direction violation inside the extension-manager domain by recording the roles these files already play, and groups files so the record claims directories instead of listing files. The domain directory is the home for its modules; remaining per-file entries are role exceptions.
useManagerDialog,useManagerSurveyDialog,useNodeConflictDialog,useImportFailedNodeDialog) import the Vue components they open, so they are presentation, matchinguseEditKeybindingDialogin keybindings. They move tocomposables/dialogs/, which the record claims as one presentation directory.usePackInstall,useImportFailedDetectionand help-center'suseHelpCenteropen those dialogs and are only called from components, so they are presentation too.types/**is claimed as domain, withimportFailedTypesas the one presentation exception.useServerLogsjoinsservices/(claimed as infrastructure), andpackUtilsandmapperUtiljoinutils/.packUpdateStatusmoves fromutils/tocomposables/nodePack/, beside its only callers, so it needs no application exception.extractCustomNodeNamemoves fromworkbench/utils/nodeHelpUtilinto the manager'spackUtils, besidenormalizePackId. node-library declares its dependency on extension-manager fornodeHelpService's import.workflowErrorManageradapts manager composables to the workflow-errors port, so it is integration.Verification
pnpm exec fallow dead-code --boundary-violations, compared before and after: 13 fewer violations, none new. No extension-manager to extension-manager violations remain. The directory move leaves the violation set unchanged apart from the renamed paths.pnpm architecture:checkpasses with the same warning count as main;fallow auditreports no issues.pnpm typecheckand the unit tests for the moved composables and their importers pass.