Repository navigation
[backport core/1.59] FE-3099 fix(auth): switch local web SSO workspaces and say when sign-in fails - #22288
Conversation
…in fails (#22153) ## Summary Two local web SSO QA findings (FE-3099, Denys, L11a and L14): - **L14, no workspace switcher.** Root cause: the local web auth bridge did not implement `switchWorkspace`, so `canDesktopHostSwitchWorkspace()` was false and the account menu hid the dropdown even though the workspace list was loaded. The OAuth token is bound to the workspace picked on consent and ingest has no endpoint that re-scopes it, so this does what Desktop's `CloudSession.switchWorkspace` does: keep each workspace's tokens (`Comfy.LocalWebSignIn.WorkspaceTokens`), switch straight to a workspace this page signed in to before (refreshing its tokens if expired), and go through consent otherwise. Sign-out forgets every workspace. - **L11a, silent failed sign-in.** Root cause: `startLocalWebSession` only called `reportError` when the returned sign-in failed. It now returns `sign-in-failed`, and `main.ts` shows the existing `auth.desktopHost.signInFailed` toast once Pinia is up. A declined consent still shows nothing. Not in this PR: L14's "User" instead of the account name. Host sessions show no display name on purpose (#20536) and the OAuth access token carries no `name` claim, so the name needs a server fact (a `name` claim, or a loopback-CORS profile endpoint). Same on Desktop. ## Verification - Unit: `src/platform/auth/localWeb` + `desktopHost` (63 tests). New cases: switch to the current workspace, consent for an unknown workspace, instant switch back to a kept workspace, refresh of an expired kept workspace, sign-out forgets all, storage persistence of per-workspace tokens, `sign-in-failed` result. - Manual, staging: this branch built with `VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org`, core with Comfy-Org/ComfyUI#17410, `local_web_sso` + `partner_node_token` on, Chrome. | | AS IS | TO BE | | --- | --- | --- | | Failed sign-in (`/?code=bogus&state=bogus`) | Signed out, nothing shown (QA L11a) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/a4f7071eed4ea211ca8dbc8f9ca7ea73cd5d7f33/signin-failed-toast.jpg" width="420"> | | Account menu | Current workspace only, no dropdown (QA L14) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/f3d6973862faa142ec7463fbd2f265d1cd3bef63/workspace-switcher.jpg" width="420"> | | Switch back to a kept workspace | Log out and pick on consent | No page load, Personal active with its credits: <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/cd0ac1eca585549a0b95639d596c0dd846853fa4/switched-back-personal.jpg" width="420"> | Switching to `team-test` (never signed in to from this page) went through stagingcloud consent and came back on `team-test`; switching back to Personal then happened in place.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T20:12:13.408Z",
"gitSha": "9f617413a7150fdc52d29f4d0d1ad3a53bfdd355",
"branch": "backport-22153-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9560000000024,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.2390000000000003,
"layouts": 11,
"layoutDurationMs": 2.8330000000000006,
"taskDurationMs": 387.755,
"heapDeltaBytes": 1906764,
"heapUsedBytes": 61877828,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.076000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.5639999999785,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9109999999999996,
"layouts": 10,
"layoutDurationMs": 2.555,
"taskDurationMs": 332.758,
"heapDeltaBytes": 4721332,
"heapUsedBytes": 74550760,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8.036999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.3220000000038,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.591,
"layouts": 10,
"layoutDurationMs": 2.5500000000000003,
"taskDurationMs": 614.3620000000001,
"heapDeltaBytes": 21735264,
"heapUsedBytes": 82507264,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 113.364,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.5729999999953,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.738999999999999,
"layouts": 9,
"layoutDurationMs": 2.3560000000000003,
"taskDurationMs": 586.816,
"heapDeltaBytes": 17373140,
"heapUsedBytes": 78271556,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 111.141,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673267,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8170000000057,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.9239999999999995,
"layouts": 11,
"layoutDurationMs": 2.9639999999999995,
"taskDurationMs": 268.926,
"heapDeltaBytes": 24531616,
"heapUsedBytes": 85086420,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.991,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.621000000027,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.6290000000000004,
"layouts": 10,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 232.13299999999998,
"heapDeltaBytes": 24114492,
"heapUsedBytes": 84721840,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 6.744,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 527.1669999999915,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.4880000000000004,
"layouts": 11,
"layoutDurationMs": 3.1009999999999995,
"taskDurationMs": 357.425,
"heapDeltaBytes": 1100000,
"heapUsedBytes": 70944012,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 116.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 511.1349999999675,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.989,
"layouts": 10,
"layoutDurationMs": 2.5799999999999996,
"taskDurationMs": 325.956,
"heapDeltaBytes": -1116672,
"heapUsedBytes": 59407800,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 112.80199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 968.9960000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.9950000000001,
"heapDeltaBytes": -5736440,
"heapUsedBytes": 75025080,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 42.951,
"eventListeners": -106,
"totalBlockingTimeMs": 300,
"frameDurationMs": 26.849999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 908.9179999999715,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.4870000000001,
"heapDeltaBytes": -11732264,
"heapUsedBytes": 75003284,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 36.39999999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 273,
"frameDurationMs": 26.18857142857144,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.108000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.546,
"heapDeltaBytes": -3972744,
"heapUsedBytes": 69524848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.04100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 21.21212121212121,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.2079999999473,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.8319999999997,
"heapDeltaBytes": -22682560,
"heapUsedBytes": 66350528,
"domNodes": -191,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 91.91199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.47714285714285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6455.519999999979,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0940000000000003,
"layouts": 3,
"layoutDurationMs": 0.8960000000000001,
"taskDurationMs": 5674.104,
"heapDeltaBytes": 65410716,
"heapUsedBytes": 137739596,
"domNodes": -257,
"jsHeapTotalBytes": 58322944,
"scriptDurationMs": 4143.484,
"eventListeners": -68,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.499333333333333,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6717.063999999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1799999999999997,
"layouts": 4,
"layoutDurationMs": 1.049,
"taskDurationMs": 5593.879,
"heapDeltaBytes": 72454384,
"heapUsedBytes": 144655988,
"domNodes": -257,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 4212.417,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.23012048192771,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6486.5269999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9269999999999998,
"layouts": 3,
"layoutDurationMs": 0.7560000000000001,
"taskDurationMs": 5726.691,
"heapDeltaBytes": -9997856,
"heapUsedBytes": 79226316,
"domNodes": -257,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 4358.681,
"eventListeners": -68,
"totalBlockingTimeMs": 78,
"frameDurationMs": 24.935,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6713.28299999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9510000000000005,
"layouts": 3,
"layoutDurationMs": 0.8800000000000001,
"taskDurationMs": 5717.9619999999995,
"heapDeltaBytes": 63038128,
"heapUsedBytes": 136957692,
"domNodes": -257,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 4294.959,
"eventListeners": -68,
"totalBlockingTimeMs": 10,
"frameDurationMs": 20.476524390243902,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 199.55299999998033,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.164,
"layouts": 12,
"layoutDurationMs": 3.8319999999999994,
"taskDurationMs": 183.34799999999998,
"heapDeltaBytes": -4271340,
"heapUsedBytes": 66118088,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.209999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 150.28100000000677,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.203999999999999,
"layouts": 10,
"layoutDurationMs": 2.7979999999999996,
"taskDurationMs": 108.438,
"heapDeltaBytes": 14466764,
"heapUsedBytes": 91706096,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.307,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2026.485000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8589999999999995,
"layouts": 9,
"layoutDurationMs": 2.5320000000000005,
"taskDurationMs": 475.864,
"heapDeltaBytes": -25515484,
"heapUsedBytes": 65462936,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 30.99699999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.3149999999778,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8330000000000006,
"layouts": 8,
"layoutDurationMs": 2.6029999999999998,
"taskDurationMs": 486.92900000000003,
"heapDeltaBytes": 5814924,
"heapUsedBytes": 79925576,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.343999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2817.1330000000125,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.548000000000002,
"layouts": 10,
"layoutDurationMs": 2.623,
"taskDurationMs": 1254.69,
"heapDeltaBytes": -30993000,
"heapUsedBytes": 60742908,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 579.34,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66627218934911,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2463.3460000000014,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.507,
"layouts": 7,
"layoutDurationMs": 1.8409999999999997,
"taskDurationMs": 1212.453,
"heapDeltaBytes": -1238836,
"heapUsedBytes": 72834920,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 574.452,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.1470000000086,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.204,
"layouts": 67,
"layoutDurationMs": 12.723999999999998,
"taskDurationMs": 1313.8,
"heapDeltaBytes": -27508720,
"heapUsedBytes": 65101816,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 553.628,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666350710900474,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3900.9450000000356,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.634000000000002,
"layouts": 64,
"layoutDurationMs": 12.409,
"taskDurationMs": 1397.915,
"heapDeltaBytes": 6869564,
"heapUsedBytes": 83653960,
"domNodes": -233,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 590.0219999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665811965811965,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2324.6579999999994,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.594,
"layouts": 8,
"layoutDurationMs": 2.167,
"taskDurationMs": 1352.713,
"heapDeltaBytes": 13395508,
"heapUsedBytes": 92456944,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 663.415,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2678.767999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.43,
"layouts": 7,
"layoutDurationMs": 1.7240000000000002,
"taskDurationMs": 1390.081,
"heapDeltaBytes": 14661008,
"heapUsedBytes": 94058148,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 680.0110000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2889.1030000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5189999999999997,
"layouts": 8,
"layoutDurationMs": 2.2160000000000006,
"taskDurationMs": 599.3359999999999,
"heapDeltaBytes": -15351340,
"heapUsedBytes": 60677440,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 260.438,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2838.8929999999846,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.216999999999999,
"layouts": 8,
"layoutDurationMs": 2.028,
"taskDurationMs": 539.417,
"heapDeltaBytes": -2788008,
"heapUsedBytes": 72871280,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 236.743,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588235294118,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.3729999999975,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8510000000000004,
"layouts": 9,
"layoutDurationMs": 2.376,
"taskDurationMs": 433.565,
"heapDeltaBytes": -14374920,
"heapUsedBytes": 62476136,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.339000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.6800000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0609999999999995,
"layouts": 9,
"layoutDurationMs": 1.8750000000000002,
"taskDurationMs": 399.04699999999997,
"heapDeltaBytes": -13052264,
"heapUsedBytes": 62187812,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 25.077,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2744.4189999999935,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.665,
"layouts": 7,
"layoutDurationMs": 2.0420000000000003,
"taskDurationMs": 505.46000000000004,
"heapDeltaBytes": -12711192,
"heapUsedBytes": 80600096,
"domNodes": -251,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 158.144,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2743.7439999999924,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.512999999999998,
"layouts": 9,
"layoutDurationMs": 2.415,
"taskDurationMs": 451.7830000000001,
"heapDeltaBytes": -10101908,
"heapUsedBytes": 66090164,
"domNodes": -255,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 153.422,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3058.3369999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2680000000000002,
"layouts": 7,
"layoutDurationMs": 1.9020000000000001,
"taskDurationMs": 763.0139999999999,
"heapDeltaBytes": -16316860,
"heapUsedBytes": 66347604,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 291.72700000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2915.6340000000114,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0949999999999998,
"layouts": 8,
"layoutDurationMs": 1.796,
"taskDurationMs": 626.312,
"heapDeltaBytes": -15443360,
"heapUsedBytes": 77333564,
"domNodes": -257,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 239.774,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.2490000000041,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.720999999999999,
"layouts": 10,
"layoutDurationMs": 2.542,
"taskDurationMs": 299.92600000000004,
"heapDeltaBytes": 22199488,
"heapUsedBytes": 82997612,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 101.86300000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.4489999999864,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.307000000000001,
"layouts": 10,
"layoutDurationMs": 2.501000000000001,
"taskDurationMs": 287.282,
"heapDeltaBytes": 22140168,
"heapUsedBytes": 84134380,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 97.908,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.7249999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2509999999999994,
"layouts": 10,
"layoutDurationMs": 2.8040000000000003,
"taskDurationMs": 401.98199999999997,
"heapDeltaBytes": 24206220,
"heapUsedBytes": 85219932,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.554999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.9079999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4349999999999996,
"layouts": 9,
"layoutDurationMs": 2.135,
"taskDurationMs": 306.46299999999997,
"heapDeltaBytes": 24298920,
"heapUsedBytes": 85174704,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.178999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.859000000008,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.485000000000001,
"layouts": 10,
"layoutDurationMs": 2.6240000000000006,
"taskDurationMs": 656.293,
"heapDeltaBytes": -19355992,
"heapUsedBytes": 53454760,
"domNodes": -175,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 91.575,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.8369999999873,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.059,
"layouts": 11,
"layoutDurationMs": 2.799,
"taskDurationMs": 596.563,
"heapDeltaBytes": 17495468,
"heapUsedBytes": 79820616,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 92.646,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 848.7680000000069,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.286000000000001,
"layouts": 5,
"layoutDurationMs": 8.956000000000001,
"taskDurationMs": 636.0140000000001,
"heapDeltaBytes": 9629112,
"heapUsedBytes": 109964420,
"domNodes": 16030,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 20.105999999999998,
"eventListeners": 3246,
"totalBlockingTimeMs": 81,
"frameDurationMs": 19.767441860465116,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "viewport-pan-sweep",
"durationMs": 8941.035999999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.481,
"layouts": 9,
"layoutDurationMs": 2.4139999999999997,
"taskDurationMs": 4237.715999999999,
"heapDeltaBytes": 13020612,
"heapUsedBytes": 86062132,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1935.4230000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666108007448788,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9004.887999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.835,
"layouts": 9,
"layoutDurationMs": 2.3579999999999997,
"taskDurationMs": 4215.955,
"heapDeltaBytes": -3725180,
"heapUsedBytes": 71013792,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 1933.876,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69685185185185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12785.38900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12226.357,
"heapDeltaBytes": -16207880,
"heapUsedBytes": 261607344,
"domNodes": -3343,
"jsHeapTotalBytes": 34856960,
"scriptDurationMs": 175.884,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.620777027027028,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 15698.554000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14847.271,
"heapDeltaBytes": -15104476,
"heapUsedBytes": 262721632,
"domNodes": -3343,
"jsHeapTotalBytes": 33284096,
"scriptDurationMs": 186.61099999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.745144804088586,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18678.942000000006,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18331.443,
"heapDeltaBytes": -5016140,
"heapUsedBytes": 277897252,
"domNodes": -3343,
"jsHeapTotalBytes": 18866176,
"scriptDurationMs": 633.8059999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.88675373134329,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18208.461999999996,
"styleRecalcs": 151,
"styleRecalcDurationMs": 16.939999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17871.897,
"heapDeltaBytes": -17481520,
"heapUsedBytes": 279131088,
"domNodes": -3343,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 630.738,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.143445692883894,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6008.693999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.057999999999986,
"layouts": 20,
"layoutDurationMs": 21.990999999999996,
"taskDurationMs": 5904.889000000001,
"heapDeltaBytes": -10018740,
"heapUsedBytes": 286889776,
"domNodes": -3343,
"jsHeapTotalBytes": 25681920,
"scriptDurationMs": 86.697,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.990395480225985,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5892.718000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.668000000000006,
"layouts": 20,
"layoutDurationMs": 23.31,
"taskDurationMs": 5739.189999999999,
"heapDeltaBytes": 3905772,
"heapUsedBytes": 286313904,
"domNodes": -3343,
"jsHeapTotalBytes": 25157632,
"scriptDurationMs": 86.869,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.617714285714285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8149.766,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7685.563999999998,
"heapDeltaBytes": 27590132,
"heapUsedBytes": 283514812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.17199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.595438596491224,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8245.795999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7858.103999999999,
"heapDeltaBytes": -107148,
"heapUsedBytes": 273054972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.078,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.060204081632648,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "workflow-execution",
"durationMs": 80.0970000000234,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.799,
"layouts": 5,
"layoutDurationMs": 1.517,
"taskDurationMs": 56.533,
"heapDeltaBytes": 4731100,
"heapUsedBytes": 65424668,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.869000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 89.83800000009978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.9590000000000005,
"layouts": 7,
"layoutDurationMs": 2.5530000000000004,
"taskDurationMs": 61.375,
"heapDeltaBytes": 4655684,
"heapUsedBytes": 64658888,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.492,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 237.88999999999305,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.583,
"layouts": 76,
"layoutDurationMs": 11.924000000000001,
"taskDurationMs": 192.126,
"heapDeltaBytes": 9686936,
"heapUsedBytes": 50296912,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 83.357,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 267.34799999996994,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.662,
"layouts": 76,
"layoutDurationMs": 13.643,
"taskDurationMs": 215.704,
"heapDeltaBytes": 10016936,
"heapUsedBytes": 50610616,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 91.65299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 298.28100000008817,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.567,
"layouts": 76,
"layoutDurationMs": 13.381,
"taskDurationMs": 266.786,
"heapDeltaBytes": -1138152,
"heapUsedBytes": 91618916,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 93.338,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 329.77900000003046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.693,
"layouts": 76,
"layoutDurationMs": 13.547,
"taskDurationMs": 290.329,
"heapDeltaBytes": -2056704,
"heapUsedBytes": 91554772,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 92.339,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎭 Playwright: ✅ 3121 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ac79c46590532ea4f0ae6005f3fbe52252dbdc2f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: same files and the same changed lines as #22153.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.59 #22288 +/- ##
============================================
Coverage 87.46% 87.46%
============================================
Files 2958 2958
Lines 156185 156289 +104
Branches 40096 42267 +2171
============================================
+ Hits 136603 136698 +95
- Misses 18906 18915 +9
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22153 to
core/1.59Automatically created by backport workflow.