Repository navigation
[backport core/1.56] ci: fix E2E coverage packaging (lcov duplicate functions) - #22286
Conversation
## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.57`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.57`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.57` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there). (cherry picked from commit a81f8a0)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T19:51:30.074Z",
"gitSha": "0a0f8f4a4b518cee2891bbb113c8409786ee7735",
"branch": "ci-lcov-ignore-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.6400000000285,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.976000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.496,
"heapDeltaBytes": 1323340,
"heapUsedBytes": 68760836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.635999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.799000000011,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.332,
"heapDeltaBytes": 1345760,
"heapUsedBytes": 68815560,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.221000000000009,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.9309999999905,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.888,
"layouts": 12,
"layoutDurationMs": 4.3420000000000005,
"taskDurationMs": 818.3480000000001,
"heapDeltaBytes": -2108684,
"heapUsedBytes": 65787876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.32599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1820.6840000000284,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.996,
"layouts": 12,
"layoutDurationMs": 4.812,
"taskDurationMs": 858.6940000000001,
"heapDeltaBytes": -2144012,
"heapUsedBytes": 66031852,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 173.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.0390000000425,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.774000000000001,
"layouts": 6,
"layoutDurationMs": 1.0749999999999997,
"taskDurationMs": 368.64200000000005,
"heapDeltaBytes": 4082896,
"heapUsedBytes": 72233068,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.312999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.232000000029,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.875000000000002,
"layouts": 6,
"layoutDurationMs": 1.226,
"taskDurationMs": 373.15199999999993,
"heapDeltaBytes": 4117784,
"heapUsedBytes": 71022532,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.478999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 712.9699999999843,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.55,
"heapDeltaBytes": -7082984,
"heapUsedBytes": 61068780,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 174.19,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 720.23200000001,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.01599999999996,
"heapDeltaBytes": -7437236,
"heapUsedBytes": 60767864,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 181.254,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.7390000000164,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.8889999999999,
"heapDeltaBytes": 16059608,
"heapUsedBytes": 84545700,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 72.09400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 532,
"frameDurationMs": 34.30882352941177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1188.0250000000387,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.459,
"heapDeltaBytes": 15384648,
"heapUsedBytes": 85200212,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 69.382,
"eventListeners": 0,
"totalBlockingTimeMs": 554,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.8089999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.5619999999994,
"heapDeltaBytes": 17802244,
"heapUsedBytes": 104948560,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 177.883,
"eventListeners": 0,
"totalBlockingTimeMs": 241,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 898.0540000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.9469999999997,
"heapDeltaBytes": 17826240,
"heapUsedBytes": 105223728,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 179.00099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11070.833000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10214.772,
"heapDeltaBytes": -4170736,
"heapUsedBytes": 80939488,
"domNodes": -142,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 8598.903000000002,
"eventListeners": -78,
"totalBlockingTimeMs": 1847,
"frameDurationMs": 36.164379084967315,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8754.480000000058,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9790000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8082.974,
"heapDeltaBytes": -17076560,
"heapUsedBytes": 67634096,
"domNodes": -142,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 6833.679,
"eventListeners": -74,
"totalBlockingTimeMs": 886,
"frameDurationMs": 34.58379446640316,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9967.489999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9161.893,
"heapDeltaBytes": -10243004,
"heapUsedBytes": 74666512,
"domNodes": -142,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 7586.6720000000005,
"eventListeners": -74,
"totalBlockingTimeMs": 1270,
"frameDurationMs": 34.36655172413793,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10332.219000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9426.546999999999,
"heapDeltaBytes": -16280212,
"heapUsedBytes": 68106496,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7755.679,
"eventListeners": -74,
"totalBlockingTimeMs": 1226,
"frameDurationMs": 33.44012944983819,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2018.1390000000192,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.170999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.188,
"heapDeltaBytes": 14952840,
"heapUsedBytes": 91238008,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.7089999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.472000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.6830000000001,
"heapDeltaBytes": -9873260,
"heapUsedBytes": 77532872,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 41.867000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3015.4170000000136,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.342999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.8850000000002,
"heapDeltaBytes": -17932092,
"heapUsedBytes": 71687096,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 916.601,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666298342541438,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3097.5009999999656,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1759.4099999999999,
"heapDeltaBytes": -18725744,
"heapUsedBytes": 70926280,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 928.989,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594594594595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3838.122999999996,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.604000000000001,
"layouts": 60,
"layoutDurationMs": 15.126,
"taskDurationMs": 1722.4360000000001,
"heapDeltaBytes": 1816476,
"heapUsedBytes": 70208104,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 836.4069999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3957.345000000032,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.793000000000001,
"layouts": 60,
"layoutDurationMs": 15.685,
"taskDurationMs": 1792.9560000000001,
"heapDeltaBytes": -20966576,
"heapUsedBytes": 69794432,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 852.992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666244725738395,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3157.6109999999744,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.914000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.846,
"heapDeltaBytes": 8495180,
"heapUsedBytes": 77463176,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 1019.6220000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754787234042556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3193.3099999999968,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.928000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2053.373,
"heapDeltaBytes": 8883964,
"heapUsedBytes": 77711128,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1074.662,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84232804232804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.2570000000246,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6959999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.201,
"heapDeltaBytes": -9004064,
"heapUsedBytes": 80891236,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.105,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.454999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.606,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.808,
"heapDeltaBytes": -8973392,
"heapUsedBytes": 80791484,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.629000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.650999999948,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.1629999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.537,
"heapDeltaBytes": -11692344,
"heapUsedBytes": 58117732,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 141.911,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.5299999999943,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.357,
"heapDeltaBytes": -11703124,
"heapUsedBytes": 58109060,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.26600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.9289999999764,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.5360000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.747,
"heapDeltaBytes": 1519140,
"heapUsedBytes": 71289544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.009999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.6550000000334,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8499999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.1549999999999,
"heapDeltaBytes": 1100872,
"heapUsedBytes": 70894980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.155000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.7709999999852,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.442999999999998,
"layouts": 16,
"layoutDurationMs": 6.143,
"taskDurationMs": 780.37,
"heapDeltaBytes": -5943344,
"heapUsedBytes": 64164420,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 119.38699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.5700000000397,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.136999999999997,
"layouts": 16,
"layoutDurationMs": 6.931999999999999,
"taskDurationMs": 882.9399999999999,
"heapDeltaBytes": -6029704,
"heapUsedBytes": 64088208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 128.086,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.3380000000307,
"styleRecalcs": 16,
"styleRecalcDurationMs": 31.486999999999995,
"layouts": 5,
"layoutDurationMs": 16.159,
"taskDurationMs": 1072.2090000000003,
"heapDeltaBytes": 2975964,
"heapUsedBytes": 97320060,
"domNodes": 14227,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 35.462999999999994,
"eventListeners": 2463,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.820270270270257,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9246.218999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.657,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5807.288,
"heapDeltaBytes": -19299768,
"heapUsedBytes": 69483172,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2868.509,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696028880866425,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9199.745000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.971,
"heapDeltaBytes": -17972340,
"heapUsedBytes": 71166632,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2902.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696370235934666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18672.754999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17946.611999999997,
"heapDeltaBytes": -42084604,
"heapUsedBytes": 181620640,
"domNodes": -3045,
"jsHeapTotalBytes": 1417216,
"scriptDurationMs": 281.755,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.988507718696404,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18513.98300000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17690.432,
"heapDeltaBytes": -33548208,
"heapUsedBytes": 179400328,
"domNodes": -3045,
"jsHeapTotalBytes": 6115328,
"scriptDurationMs": 341.748,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 31.59709897610922,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21994.310999999983,
"styleRecalcs": 173,
"styleRecalcDurationMs": 20.291000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21633.547,
"heapDeltaBytes": -28605192,
"heapUsedBytes": 184212816,
"domNodes": -3045,
"jsHeapTotalBytes": 6639616,
"scriptDurationMs": 871.3290000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 17,
"frameDurationMs": 41.19681647940075,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22823.61800000001,
"styleRecalcs": 177,
"styleRecalcDurationMs": 21.358000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22379.61,
"heapDeltaBytes": -21717704,
"heapUsedBytes": 189488968,
"domNodes": -3045,
"jsHeapTotalBytes": 8372224,
"scriptDurationMs": 899.335,
"eventListeners": -14915,
"totalBlockingTimeMs": 13,
"frameDurationMs": 42.20425138632163,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6450.621000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.35000000000004,
"layouts": 20,
"layoutDurationMs": 24.710999999999984,
"taskDurationMs": 6324.62,
"heapDeltaBytes": 14976908,
"heapUsedBytes": 214413080,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 115.51400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.16449704142013,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6570.716000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.91100000000002,
"layouts": 20,
"layoutDurationMs": 24.262000000000008,
"taskDurationMs": 6449.127,
"heapDeltaBytes": 963304,
"heapUsedBytes": 214619504,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 115.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.77771739130436,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9459.37299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9061.499,
"heapDeltaBytes": -44441052,
"heapUsedBytes": 179772688,
"domNodes": -3045,
"jsHeapTotalBytes": 106496,
"scriptDurationMs": 145.50800000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.75536332179931,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9188.348999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8866.587999999998,
"heapDeltaBytes": -37324284,
"heapUsedBytes": 176381472,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 143.45399999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.128813559322033,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 489.90600000001905,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.609,
"layouts": 4,
"layoutDurationMs": 1.9570000000000003,
"taskDurationMs": 135.487,
"heapDeltaBytes": 5942280,
"heapUsedBytes": 71361016,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.212000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 134.71800000002077,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.713999999999999,
"layouts": 4,
"layoutDurationMs": 2.119,
"taskDurationMs": 88.509,
"heapDeltaBytes": 3811496,
"heapUsedBytes": 69255832,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.190000000000009,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1043.089000000009,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.358,
"layouts": 76,
"layoutDurationMs": 29.538999999999998,
"taskDurationMs": 1016.4390000000001,
"heapDeltaBytes": 19287708,
"heapUsedBytes": 91617488,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 419.95099999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 926.6440000000102,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.824,
"layouts": 76,
"layoutDurationMs": 27.622,
"taskDurationMs": 905.686,
"heapDeltaBytes": 18265848,
"heapUsedBytes": 86532016,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 367.563,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1502.992000000063,
"styleRecalcs": 78,
"styleRecalcDurationMs": 277.1,
"layouts": 76,
"layoutDurationMs": 31.146,
"taskDurationMs": 1474.472,
"heapDeltaBytes": -18655344,
"heapUsedBytes": 110893448,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 495.232,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1417.9860000000417,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.129,
"layouts": 76,
"layoutDurationMs": 29.187,
"taskDurationMs": 1383.681,
"heapDeltaBytes": -15686504,
"heapUsedBytes": 111588336,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 449.39199999999994,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.70625,
"p95FrameDurationMs": 33.29999999999927
}
]
}🎭 Playwright: ✅ 2203 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c4bc227906bba0516e66929ead099a89959630ce
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed e04e3f36d8daa4e79ef043d03bc2951857bf8fd6 for core/1.56, including the original #21877 discussion and the linked failed packaging job. The log confirms the same duplicate inner_clicked function produces both inconsistent and corrupt errors. The backport retains the CLI fixture guard and line-output regression that the original review required.
The coverage producer builds/checks out github.sha; passing that same revision into the packaging workflow keeps genhtml's source aligned with the tested merge commit. The incomplete-shard/trend-reporting and mapped-source checks remain intact.
Own validation in an isolated exact-head checkout with its own frozen dependency install: 12 packaging tests, script-project typecheck, type-aware Oxlint, Oxfmt, bash syntax, ShellCheck and Actionlint passed. Reverting only the lcov fix yields 4 failed / 8 passed tests; reverting only the workflow revision fix yields 1 failed / 11 passed. Restoring both yields 12 passed, and the source tree is clean. These execute the shell script with controlled lcov/genhtml fixtures; I did not rerun a live CI job or real lcov/genhtml binary. No application build/browser acceptance is needed for this CI-only diff.
No remaining blocking code findings. Head/open state and full discussions were refreshed before posting.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #22286 +/- ##
=============================================
- Coverage 82.79% 82.23% -0.57%
=============================================
Files 2691 2865 +174
Lines 152078 154731 +2653
Branches 36656 36656
=============================================
+ Hits 125912 127242 +1330
- Misses 25781 27104 +1323
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Clean cherry-pick of #21877 (the same fix already on cloud/1.57, core/1.58 and cloud/1.58).
upload-e2e-coverage / packagefails on every 1.56 PR because lcov rejects a duplicate function while merging shards. Example: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40936003774/job/123677295968. CI-only change; tracked in FRONT-3596.