Repository navigation
[backport cloud/1.56] ci: fix E2E coverage packaging (lcov duplicate functions) - #22285
Conversation
## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.57`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.57`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.57` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there). (cherry picked from commit a81f8a0)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T19:50:00.562Z",
"gitSha": "2805b5fe16a10dfb8a4bcbbf164dcca85f36b475",
"branch": "ci-lcov-ignore-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.6819999999796,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.403999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.12799999999993,
"heapDeltaBytes": 964312,
"heapUsedBytes": 68489768,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.129999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.8659999999554,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0159999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.17900000000003,
"heapDeltaBytes": 22829856,
"heapUsedBytes": 77031520,
"domNodes": -82,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.115999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1846.151999999961,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.198,
"layouts": 12,
"layoutDurationMs": 5.275,
"taskDurationMs": 889.171,
"heapDeltaBytes": -2493864,
"heapUsedBytes": 65024492,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 162.751,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1782.7350000000024,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.86,
"layouts": 12,
"layoutDurationMs": 4.5329999999999995,
"taskDurationMs": 817.6229999999999,
"heapDeltaBytes": -5804696,
"heapUsedBytes": 56140812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.953,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3339999999853,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.534,
"layouts": 6,
"layoutDurationMs": 1.735,
"taskDurationMs": 413.325,
"heapDeltaBytes": 4226376,
"heapUsedBytes": 71766940,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.552999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2000000000198,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.940000000000001,
"layouts": 6,
"layoutDurationMs": 1.094,
"taskDurationMs": 359.1820000000001,
"heapDeltaBytes": 3900456,
"heapUsedBytes": 71164660,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.372999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 747.7459999999496,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5059999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.733,
"heapDeltaBytes": -8039164,
"heapUsedBytes": 58151796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.48000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 712.6590000000306,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.9419999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.65599999999995,
"heapDeltaBytes": -6390176,
"heapUsedBytes": 60915784,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 173.27300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1167.1379999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.0830000000001,
"heapDeltaBytes": 15547072,
"heapUsedBytes": 84007212,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 64.693,
"eventListeners": 0,
"totalBlockingTimeMs": 552,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.3320000000213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.456,
"heapDeltaBytes": 10526692,
"heapUsedBytes": 92283768,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 61.97100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 34.31470588235296,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.390999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.26200000000006,
"heapDeltaBytes": 17565388,
"heapUsedBytes": 101822864,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 143.617,
"eventListeners": 0,
"totalBlockingTimeMs": 188,
"frameDurationMs": 24.020588235294085,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 833.8069999999789,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.2750000000002,
"heapDeltaBytes": 18881140,
"heapUsedBytes": 103200252,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 149.449,
"eventListeners": 0,
"totalBlockingTimeMs": 190,
"frameDurationMs": 23.808571428571458,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9619.650000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8630.743,
"heapDeltaBytes": -15256228,
"heapUsedBytes": 68616772,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 6893.723,
"eventListeners": -78,
"totalBlockingTimeMs": 706,
"frameDurationMs": 33.68280701754386,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8978.42300000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9689999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8200.3,
"heapDeltaBytes": 8790900,
"heapUsedBytes": 85863912,
"domNodes": -142,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 6601.000999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 368,
"frameDurationMs": 32.25323741007195,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9130.032,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3259999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8422.3,
"heapDeltaBytes": -7326020,
"heapUsedBytes": 70122268,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 6727.43,
"eventListeners": -78,
"totalBlockingTimeMs": 579,
"frameDurationMs": 33.45384615384615,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8714.951999999983,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4930000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8045.361999999999,
"heapDeltaBytes": -3162876,
"heapUsedBytes": 73965548,
"domNodes": -142,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 6386.616,
"eventListeners": -78,
"totalBlockingTimeMs": 353,
"frameDurationMs": 32.28259259259259,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2011.3430000000108,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.4000000000001,
"heapDeltaBytes": -10744372,
"heapUsedBytes": 76999452,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.95799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.290000000069,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9290000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.393,
"heapDeltaBytes": -10276004,
"heapUsedBytes": 77767752,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.55499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3132.173000000023,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.3229999999999,
"heapDeltaBytes": -17591672,
"heapUsedBytes": 70391540,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 882.395,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66631016042781,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2846.3140000000067,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.179000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1658.0690000000002,
"heapDeltaBytes": -17973076,
"heapUsedBytes": 70419772,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 850.223,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3977.5849999999764,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.002999999999998,
"layouts": 60,
"layoutDurationMs": 14.790999999999999,
"taskDurationMs": 1805.22,
"heapDeltaBytes": 3971328,
"heapUsedBytes": 84278280,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 820.227,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610878661088,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3741.215000000011,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.289,
"layouts": 60,
"layoutDurationMs": 14.683,
"taskDurationMs": 1698.778,
"heapDeltaBytes": -20415560,
"heapUsedBytes": 69409772,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 785.9809999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665777777777773,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3157.619000000011,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.882999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2037.7210000000002,
"heapDeltaBytes": 14462160,
"heapUsedBytes": 81467772,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1004.7760000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84385026737968,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3135.067999999933,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1905.6750000000002,
"heapDeltaBytes": 9199388,
"heapUsedBytes": 76905636,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 959.994,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.9379999999915,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.859999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.0849999999999,
"heapDeltaBytes": -10313992,
"heapUsedBytes": 77751220,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.771,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.4680000000553,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.22900000000004,
"heapDeltaBytes": -9734232,
"heapUsedBytes": 78824888,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.944999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 715.0920000000269,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.342,
"heapDeltaBytes": -11528052,
"heapUsedBytes": 58125172,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 153.957,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.7940000000899,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.061999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.993,
"heapDeltaBytes": 10532424,
"heapUsedBytes": 74901452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.331,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.0040000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4560000000001,
"heapDeltaBytes": 1109968,
"heapUsedBytes": 70647032,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.937999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.9119999999812,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8689999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.275,
"heapDeltaBytes": 1480932,
"heapUsedBytes": 72306288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.048000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.168000000012,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.197,
"layouts": 16,
"layoutDurationMs": 6.582,
"taskDurationMs": 838.954,
"heapDeltaBytes": -6049268,
"heapUsedBytes": 64108092,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.231,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1910000000325,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.803999999999995,
"layouts": 16,
"layoutDurationMs": 6.773,
"taskDurationMs": 823.331,
"heapDeltaBytes": -5921068,
"heapUsedBytes": 63550812,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.48799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1566.034000000002,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.219000000000005,
"layouts": 5,
"layoutDurationMs": 12.448999999999998,
"taskDurationMs": 1121.6050000000002,
"heapDeltaBytes": 1310908,
"heapUsedBytes": 94094980,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.340999999999994,
"eventListeners": 2463,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.308536585365857,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 11431.565000000035,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.720000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6285.129000000001,
"heapDeltaBytes": -16500020,
"heapUsedBytes": 71163108,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2995.487,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665985401459857,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9411.203999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.293000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5783.771,
"heapDeltaBytes": -18554404,
"heapUsedBytes": 69908164,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2773.82,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695390070921984,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16270.856999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15671.273,
"heapDeltaBytes": -38680268,
"heapUsedBytes": 180196600,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 259.884,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.361191335740074,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 15631.222000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15241.898,
"heapDeltaBytes": -39270952,
"heapUsedBytes": 180002988,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 250.782,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.683853211009172,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19483.804000000022,
"styleRecalcs": 136,
"styleRecalcDurationMs": 19.770999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19249.674,
"heapDeltaBytes": -25485624,
"heapUsedBytes": 187103684,
"domNodes": -3045,
"jsHeapTotalBytes": 3883008,
"scriptDurationMs": 957.986,
"eventListeners": -14915,
"totalBlockingTimeMs": 87,
"frameDurationMs": 36.82911153119093,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 18812.54899999999,
"styleRecalcs": 130,
"styleRecalcDurationMs": 17.352000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18531.467,
"heapDeltaBytes": -29816320,
"heapUsedBytes": 186004572,
"domNodes": -3045,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 834.681,
"eventListeners": -14915,
"totalBlockingTimeMs": 15,
"frameDurationMs": 35.771673003802285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5879.486999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.81099999999999,
"layouts": 20,
"layoutDurationMs": 26.391,
"taskDurationMs": 5783.969999999999,
"heapDeltaBytes": 1262728,
"heapUsedBytes": 213664100,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 105.007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.71436781609196,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5736.996999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.608,
"layouts": 20,
"layoutDurationMs": 25.453000000000003,
"taskDurationMs": 5636.84,
"heapDeltaBytes": -580660,
"heapUsedBytes": 226234956,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 103.266,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.94885057471264,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8219.63999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7985.899000000001,
"heapDeltaBytes": -42366852,
"heapUsedBytes": 168909112,
"domNodes": -3045,
"jsHeapTotalBytes": 4935680,
"scriptDurationMs": 129.868,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.9306338028169,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8265.379999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8020.302999999998,
"heapDeltaBytes": -23021808,
"heapUsedBytes": 179193312,
"domNodes": -3045,
"jsHeapTotalBytes": 6639616,
"scriptDurationMs": 176.18399999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 29.902527075812273,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 130.0960000000373,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.703000000000001,
"layouts": 4,
"layoutDurationMs": 2.4669999999999996,
"taskDurationMs": 99.59599999999999,
"heapDeltaBytes": 3918116,
"heapUsedBytes": 63200680,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.974,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 474.6229999999514,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.945,
"layouts": 3,
"layoutDurationMs": 1.0240000000000002,
"taskDurationMs": 115.50899999999997,
"heapDeltaBytes": 5672452,
"heapUsedBytes": 70947480,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.933999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.285185185185178,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 951.1730000000398,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.56899999999999,
"layouts": 76,
"layoutDurationMs": 27.253,
"taskDurationMs": 915.497,
"heapDeltaBytes": 18403372,
"heapUsedBytes": 90193624,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 366.745,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.964285714285715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 983.7099999999737,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.554,
"layouts": 76,
"layoutDurationMs": 29.206,
"taskDurationMs": 945.447,
"heapDeltaBytes": 19116572,
"heapUsedBytes": 84576392,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 374.899,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1416.9449999999415,
"styleRecalcs": 78,
"styleRecalcDurationMs": 255.831,
"layouts": 76,
"layoutDurationMs": 29.003,
"taskDurationMs": 1403.191,
"heapDeltaBytes": 8855564,
"heapUsedBytes": 114661968,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 454.383,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493836,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1454.5480000000452,
"styleRecalcs": 78,
"styleRecalcDurationMs": 260.522,
"layouts": 76,
"layoutDurationMs": 29.995,
"taskDurationMs": 1431.602,
"heapDeltaBytes": -19308420,
"heapUsedBytes": 115918196,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 460.503,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.089024390243893,
"p95FrameDurationMs": 33.29999999999927
}
]
}🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e27da8644d82563fc3d12a1755378c4305b7cb79
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2206 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 32cbddc1db2708846f1c96085883bdabd2fad0a9 for cloud/1.56, including the original #21877 discussion and the linked failed packaging job. The log confirms the same duplicate inner_clicked function produces both inconsistent and corrupt errors. The backport retains the CLI fixture guard and line-output regression that the original review required.
The coverage producer builds/checks out github.sha; passing that same revision into the packaging workflow keeps genhtml's source aligned with the tested merge commit. The incomplete-shard/trend-reporting and mapped-source checks remain intact.
Own validation in an isolated exact-head checkout with its own frozen dependency install: 12 packaging tests, script-project typecheck, type-aware Oxlint, Oxfmt, bash syntax, ShellCheck and Actionlint passed. Reverting only the lcov fix yields 4 failed / 8 passed tests; reverting only the workflow revision fix yields 1 failed / 11 passed. Restoring both yields 12 passed, and the source tree is clean. These execute the shell script with controlled lcov/genhtml fixtures; I did not rerun a live CI job or real lcov/genhtml binary. No application build/browser acceptance is needed for this CI-only diff.
No remaining blocking code findings. Head/open state and full discussions were refreshed before posting.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #22285 +/- ##
=============================================
Coverage ? 83.16%
=============================================
Files ? 2399
Lines ? 128086
Branches ? 36866
=============================================
Hits ? 106526
Misses ? 21149
Partials ? 411
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Clean cherry-pick of #21877 (the same fix already on cloud/1.57, core/1.58 and cloud/1.58).
upload-e2e-coverage / packagefails on every 1.56 PR because lcov rejects a duplicate function while merging shards. Example: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40936003774/job/123677295968. CI-only change; tracked in FRONT-3596.