Repository navigation
[backport core/1.56] fix(agent): wait for startup tab restore before calling a draft target unavailable (PM-2332) - #22283
Conversation
…t unavailable (PM-2332) (#22048) *PR Created by the Glary-Bot Agent* --- Fixes [PM-2332](https://linear.app/comfyorg/issue/PM-2332). If you refresh while the Agent's target is still an **unsaved** draft, the chat can show "The target workflow is no longer available". The draft hasn't been deleted when this happens. On reload, `resolveRestorationTarget` (`useAgentWorkflowSelection.ts`) decides whether the chat's target still exists: - The cloud listing hides version-less drafts (`latest_version_id IS NULL`, see cloud `common/workflow/repository.go`), so an unsaved Agent draft is always missing from it. - #19873 counts a complete listing that omits the id as proof of deletion **when no local tab owns the id**. It only calls `GET /api/workflows/{id}` when a local tab does own it. That endpoint returns 200 with `latest_version: 0` for drafts. - After a refresh, the only local owner an unsaved draft has is the tab that startup recreates from the local draft store. That happens in `restoreWorkflowTabsState`, called by GraphCanvas after `app.setup()` and `initializeWorkflow()`. - The Agent panel mounts once the app is ready (and from LinearView). It starts hydrating the thread at the same time as the rest of GraphCanvas startup, and nothing orders the two. If the chat restores before startup recreates the draft tab, it sees no owner and marks the target `unavailable`. That state never recovers, even once the tab shows up a moment later. Saved workflows aren't affected, because the listing includes them. - `workflowStore` gets `tabsRestored` and `markTabsRestored()`. `restoreWorkflowTabsState` sets the flag in a `finally`, so it's set however restore ends: success, persistence disabled, load failure, or identity mismatch. GraphCanvas's `finally` also sets it if `initializeWorkflow()` rejects. - `resolveRestorationTarget`: when nothing local owns the id **and** startup hasn't restored tabs yet, it waits for `tabsRestored` plus one tick (`startupTabsRestored`), which lets the binding store adopt the recreated tab. This applies whatever the listing returned (complete, incomplete, or failed), so an incomplete or failed listing no longer opens a null target before the draft tab is back. - The wait is capped at `STARTUP_TAB_RESTORE_TIMEOUT_MS` (15s) so a startup that hangs can't leave the chat restoring forever. - After the wait (and on the fast path) it re-checks `isCurrent()` and looks up the owner again. If the draft tab came back, the existing `GET /api/workflows/{id}` lifecycle check runs. If no tab came back, or the cap was hit, it is treated as `deleted`, the same as on `main`. The wait only runs while startup is still restoring tabs and the target has no local tab. Restores later in the session never wait. - **New:** `PM-2332 waits for a page reload to restore the unsaved draft tab before calling the chat target unavailable`. - Setup: binds a draft for real, then simulates the reload: disposes the binding store so it re-reads persisted bindings, closes the pre-reload tab, and starts restoration before startup recreates the draft tab. - Against `main`'s selection logic it fails: `targetUnavailable` is `true` before the tab is restored. With this change it passes. - **New:** `still calls the target unavailable once a reload restores no tab for it`. Restoration waits, tab restore settles without the draft, and the result is still `deleted`. It also fails against `main`'s selection logic. - **New:** `calls the target unavailable when startup never finishes restoring tabs`. The flag is never set; with fake timers the target is still undecided at 14s and is marked unavailable at 15s. Without the cap, this test times out. - **New:** `waits for the reloaded draft tab even when the listing is incomplete`. Also asserts nothing is synced or warned before the tab comes back. Fails without the change. - `useWorkflowPersistenceV2.test.ts` now asserts the flag is set after a successful restore and after a metadata failure. - The existing harnesses (`setup()` in the selection test, and the root `beforeEach` in `AgentPanelRoot.test.ts`) model a page that has finished startup, so they call `markTabsRestored()`. - Agent composables, `AgentPanelRoot`, workflow persistence and workflow management suites: 1451 passed. - Pre-commit (oxfmt, oxlint, eslint, `typecheck:app`) and pre-push (depcruise, knip, `fallow audit`) hooks pass. - `agentSubgraphDefinitions.test.ts > scans deeply nested definition ids…` (a stack overflow in `lib0` `deepFreeze`) also fails on clean `main`. It is unrelated. - **Browser check:** a local cloud-mode Playwright run (mocked cloud host) where the Agent opens an unsaved draft tab via `agent_active_tab`, followed by a reload. The chat comes back onto the same draft tab with no unavailable notice (screenshot below). I also ran the unsaved-tab (minted draft) flow, with and without a second unsaved tab open. - In that local harness, startup restore finished about 0.5s before the panel hydrated, so `main` also passed there. The race needs startup to be slower than the panel's network round trips. That's why the regression guard is the unit test, not an e2e spec. - After a reload, the unavailable notice for a **truly deleted** target now appears only once startup tab restore finishes, a few hundred ms later. If startup hangs, it appears after the 15s cap. - Not covered here: - If the listing request fails **and** no draft tab comes back, a draft target still gets the "couldn't open" warning. - If startup fails before restoring tabs, or hits the 15s cap, a missing draft is still reported unavailable (same as `main`). - If the local draft is gone (evicted, localStorage quota exceeded, tab closed), the target is still reported unavailable. The server still has the draft (`GET` → 200) and its CRDT document, so a follow-up could rebuild the tab from the server instead. All three are tracked in [FRONT-3665](https://linear.app/comfyorg/issue/FRONT-3665).  --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> (cherry picked from commit dbbd7bb)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T19:13:34.474Z",
"gitSha": "a7340f5ee48737a0406e1fb0ccc37e089e0aca25",
"branch": "backport-22048-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.3740000000275,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.094000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.626,
"heapDeltaBytes": 1217212,
"heapUsedBytes": 69706216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.393999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1997.492999999963,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.311000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.92900000000003,
"heapDeltaBytes": 1285680,
"heapUsedBytes": 68446520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.316999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.3419999999805,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.585,
"layouts": 12,
"layoutDurationMs": 4.543,
"taskDurationMs": 818.886,
"heapDeltaBytes": -2186228,
"heapUsedBytes": 65524916,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 150.19299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.2669999999935,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.750000000000004,
"layouts": 12,
"layoutDurationMs": 4.873,
"taskDurationMs": 796.524,
"heapDeltaBytes": -1837828,
"heapUsedBytes": 66025568,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 150.06200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.0990000000047,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.309,
"layouts": 6,
"layoutDurationMs": 1.437,
"taskDurationMs": 378.72900000000004,
"heapDeltaBytes": 4206112,
"heapUsedBytes": 71732272,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.264000000000006,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.9129999999823,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.616,
"layouts": 6,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 307.839,
"heapDeltaBytes": 4168008,
"heapUsedBytes": 71923408,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.817999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 740.6799999999976,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8979999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.54600000000005,
"heapDeltaBytes": -6743772,
"heapUsedBytes": 60748852,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.12199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 736.2249999999904,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.434,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.04099999999994,
"heapDeltaBytes": 15081196,
"heapUsedBytes": 76101192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.77900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1142.770999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 833.9420000000001,
"heapDeltaBytes": 15240348,
"heapUsedBytes": 85142456,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 55.96500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 34.84545454545454,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1177.3650000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 848.3660000000001,
"heapDeltaBytes": 15462288,
"heapUsedBytes": 84444148,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 59.569999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 554,
"frameDurationMs": 34.8,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.7380000000326,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.8050000000004,
"heapDeltaBytes": 17805944,
"heapUsedBytes": 104968508,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 132.374,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 791.0870000000614,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.8360000000005,
"heapDeltaBytes": 16599532,
"heapUsedBytes": 103748436,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 136.24199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 169,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8474.41599999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6049999999999979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7631.637000000001,
"heapDeltaBytes": 12967164,
"heapUsedBytes": 81778692,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 6159.34,
"eventListeners": -74,
"totalBlockingTimeMs": 314,
"frameDurationMs": 32.43793103448276,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7709.48999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0209999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6900.987000000001,
"heapDeltaBytes": 162004,
"heapUsedBytes": 84410796,
"domNodes": -142,
"jsHeapTotalBytes": -12718080,
"scriptDurationMs": 5559.275000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 104,
"frameDurationMs": 30.1421875,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8326.582999999971,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7600000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7697.545,
"heapDeltaBytes": -5173564,
"heapUsedBytes": 73059620,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 6022.164999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 169,
"frameDurationMs": 31.986153846153844,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8425.049999999941,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7769999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7785.365000000001,
"heapDeltaBytes": 17260568,
"heapUsedBytes": 87365528,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 6107.079,
"eventListeners": -74,
"totalBlockingTimeMs": 131,
"frameDurationMs": 31.404104477611945,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2018.3959999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.957999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.4550000000002,
"heapDeltaBytes": -7385144,
"heapUsedBytes": 78176584,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.01399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.9009999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.654000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.089,
"heapDeltaBytes": -9512628,
"heapUsedBytes": 78780404,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.833999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3003.9170000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.696000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1618.6229999999998,
"heapDeltaBytes": -18543696,
"heapUsedBytes": 70399256,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 829.7679999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666111111111114,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2920.9640000000263,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.867,
"heapDeltaBytes": -18166976,
"heapUsedBytes": 71254564,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 817.12,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3992.9759999999987,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.741,
"layouts": 60,
"layoutDurationMs": 16.895999999999997,
"taskDurationMs": 1716.9859999999999,
"heapDeltaBytes": 6975600,
"heapUsedBytes": 88379652,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 784.4590000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3947.361000000001,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.349,
"layouts": 60,
"layoutDurationMs": 16.769,
"taskDurationMs": 1718.3619999999999,
"heapDeltaBytes": -20822036,
"heapUsedBytes": 69472764,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 788.738,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666244725738395,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.4330000000014,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.642999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.0470000000003,
"heapDeltaBytes": 8833460,
"heapUsedBytes": 77422020,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 959.193,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75508021390374,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3144.2799999999806,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.883,
"heapDeltaBytes": 8156712,
"heapUsedBytes": 77662060,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 964.7109999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.8879999999754,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.946,
"heapDeltaBytes": -11301080,
"heapUsedBytes": 70205608,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.675000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.268999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8140000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.524,
"heapDeltaBytes": -9455180,
"heapUsedBytes": 80715880,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.724999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.7320000000191,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.369,
"heapDeltaBytes": 10793408,
"heapUsedBytes": 74334208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 142.71800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 668.0219999999508,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.550999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.53099999999995,
"heapDeltaBytes": -12023992,
"heapUsedBytes": 58099756,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 136.065,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.1599999999617,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.63,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.996,
"heapDeltaBytes": 1419524,
"heapUsedBytes": 72228224,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.505,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1997.9339999999866,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.19100000000003,
"heapDeltaBytes": 1408380,
"heapUsedBytes": 71261024,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.170000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.8290000000197,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.665,
"layouts": 16,
"layoutDurationMs": 6.4910000000000005,
"taskDurationMs": 784.6489999999999,
"heapDeltaBytes": -5953752,
"heapUsedBytes": 63822348,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.36200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9479999999503,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.437999999999995,
"layouts": 16,
"layoutDurationMs": 6.266000000000001,
"taskDurationMs": 785.7040000000001,
"heapDeltaBytes": -5658016,
"heapUsedBytes": 63894872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.15199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1382.5090000000273,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.970000000000002,
"layouts": 5,
"layoutDurationMs": 11.729,
"taskDurationMs": 922.6000000000001,
"heapDeltaBytes": 2994116,
"heapUsedBytes": 97850560,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.413,
"eventListeners": 2463,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.716901408450713,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9647.918000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5667.990000000001,
"heapDeltaBytes": -17129428,
"heapUsedBytes": 70967804,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2729.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9947.769999999991,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.01,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5779.641,
"heapDeltaBytes": -17259620,
"heapUsedBytes": 71286292,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2788.3769999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693959731543625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15805.187000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15183.641,
"heapDeltaBytes": -47877036,
"heapUsedBytes": 167717500,
"domNodes": -3045,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 264.445,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.602268760907506,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16257.208999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15488.945,
"heapDeltaBytes": -25222676,
"heapUsedBytes": 186045472,
"domNodes": -3045,
"jsHeapTotalBytes": -1204224,
"scriptDurationMs": 268.551,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.457618213660243,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19077.159999999993,
"styleRecalcs": 142,
"styleRecalcDurationMs": 21.125000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18692.933,
"heapDeltaBytes": -55543552,
"heapUsedBytes": 167711068,
"domNodes": -3045,
"jsHeapTotalBytes": -1204224,
"scriptDurationMs": 891.3389999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 24,
"frameDurationMs": 35.207749077490774,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18460.49000000005,
"styleRecalcs": 140,
"styleRecalcDurationMs": 20.858999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18161.397999999997,
"heapDeltaBytes": -29666404,
"heapUsedBytes": 183974460,
"domNodes": -3045,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 901.476,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 35.10627376425856,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5872.208999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.80900000000001,
"layouts": 20,
"layoutDurationMs": 26.695999999999998,
"taskDurationMs": 5708.842,
"heapDeltaBytes": 1172468,
"heapUsedBytes": 217104196,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.394,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.71081081081082,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5773.358999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.73299999999996,
"layouts": 20,
"layoutDurationMs": 26.742,
"taskDurationMs": 5687.527,
"heapDeltaBytes": 1207820,
"heapUsedBytes": 217040824,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 108.08599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.95142857142857,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8118.4729999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7790.658000000002,
"heapDeltaBytes": -27748764,
"heapUsedBytes": 185118064,
"domNodes": -3045,
"jsHeapTotalBytes": -1728512,
"scriptDurationMs": 135.63399999999993,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.123611111111106,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8010.966999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7708.558,
"heapDeltaBytes": -32361696,
"heapUsedBytes": 179221100,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 197.623,
"eventListeners": -14915,
"totalBlockingTimeMs": 24,
"frameDurationMs": 28.672759856630826,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 507.40100000001576,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.644999999999996,
"layouts": 3,
"layoutDurationMs": 2.038,
"taskDurationMs": 156.77999999999997,
"heapDeltaBytes": 6082952,
"heapUsedBytes": 71501208,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.902,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.81724137931034,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 125.62600000001112,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.84,
"layouts": 3,
"layoutDurationMs": 1.9020000000000001,
"taskDurationMs": 83.595,
"heapDeltaBytes": 3665696,
"heapUsedBytes": 69139920,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.909999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 943.8390000000254,
"styleRecalcs": 78,
"styleRecalcDurationMs": 111.489,
"layouts": 76,
"layoutDurationMs": 29.076999999999998,
"taskDurationMs": 913.793,
"heapDeltaBytes": 18682488,
"heapUsedBytes": 84029712,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 355.609,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 937.2759999999971,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.04,
"layouts": 76,
"layoutDurationMs": 28.461,
"taskDurationMs": 908.069,
"heapDeltaBytes": 18573796,
"heapUsedBytes": 84797144,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 355.687,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1155.8919999999944,
"styleRecalcs": 78,
"styleRecalcDurationMs": 251.612,
"layouts": 76,
"layoutDurationMs": 29.11,
"taskDurationMs": 1119.931,
"heapDeltaBytes": 4837076,
"heapUsedBytes": 111752212,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 322.37,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.213207547169834,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1454.8350000000028,
"styleRecalcs": 78,
"styleRecalcDurationMs": 273.642,
"layouts": 76,
"layoutDurationMs": 32.664,
"taskDurationMs": 1430.4859999999999,
"heapDeltaBytes": 8724752,
"heapUsedBytes": 114559908,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 448.49300000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.125,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2205 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8d70c03e36df8871ff1b42644c63fe5320625ea1
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
… tests
On this release branch restoreTarget resolves to a boolean, not the
{ ready, committedWorkflowId } object it returns on main, so the
backported assertions failed typecheck.
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22048 — approving.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.56 #22283 +/- ##
============================================
Coverage 82.79% 82.79%
============================================
Files 2691 2691
Lines 152058 152078 +20
Branches 36654 38701 +2047
============================================
+ Hits 125893 125911 +18
- Misses 25780 25782 +2
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22048 to
core/1.56.Manual: the automatic cherry-pick conflicted on context only.
workflowStoreTypes.tsdoes not exist on this branch; thetabsRestored/markTabsRestoredinterface members went into theWorkflowStoreinterface inworkflowStore.ts.GraphCanvas.vue: nofinishStartup()/disposedguard here, soworkflowStore.markTabsRestored()goes first in the existingfinally.GraphCanvas.test.ts: kept the branch helpers and took only theerrorHandlerparameter and the new test.No logic changes from #22048.
Second commit: on this branch
restoreTargetresolves to a boolean rather than main's{ ready, committedWorkflowId }, so the four new PM-2332 tests asserttrueinstead of the object. Same behaviour checked.