Repository navigation
[backport cloud/1.59] fix(agent): send a tour-held first message when the tour ends in another tab - #22255
Conversation
…her tab (#22238) ## Summary A new user's first message waits behind the intro tour (#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once #21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from #21532); ported to the release lines in #22225, #22232, #22233, #22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T15:42:32.153Z",
"gitSha": "0ba3edd37d0a94678f98addbf83617940118c033",
"branch": "backport-22238-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.2310000000186,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.554,
"layouts": 9,
"layoutDurationMs": 2.7360000000000007,
"taskDurationMs": 528.992,
"heapDeltaBytes": 5499116,
"heapUsedBytes": 75385584,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.301000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.710999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.007,
"layouts": 9,
"layoutDurationMs": 2.286,
"taskDurationMs": 502.39,
"heapDeltaBytes": 1516800,
"heapUsedBytes": 62829328,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.033000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.621999999983,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.747,
"layouts": 9,
"layoutDurationMs": 2.405,
"taskDurationMs": 840.466,
"heapDeltaBytes": -2541376,
"heapUsedBytes": 67641144,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 156.024,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.34799999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.803,
"layouts": 11,
"layoutDurationMs": 2.619,
"taskDurationMs": 853.128,
"heapDeltaBytes": 23957156,
"heapUsedBytes": 84836880,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 155.036,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8639999999918,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.227,
"layouts": 10,
"layoutDurationMs": 2.666,
"taskDurationMs": 394.713,
"heapDeltaBytes": 24474852,
"heapUsedBytes": 86230652,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.665,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.897000000079,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.7170000000000005,
"layouts": 11,
"layoutDurationMs": 2.7909999999999995,
"taskDurationMs": 390.646,
"heapDeltaBytes": 413924,
"heapUsedBytes": 70975596,
"domNodes": 56,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 10.023999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.9070000000088,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7830000000000004,
"layouts": 9,
"layoutDurationMs": 2.265,
"taskDurationMs": 488.446,
"heapDeltaBytes": 4230284,
"heapUsedBytes": 65856016,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 171.97799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 666.1460000000261,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.831,
"layouts": 10,
"layoutDurationMs": 2.79,
"taskDurationMs": 493.67900000000003,
"heapDeltaBytes": 5769564,
"heapUsedBytes": 76633344,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 169.36800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1243.5299999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 935.4269999999999,
"heapDeltaBytes": -1084420,
"heapUsedBytes": 75317348,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 69.622,
"eventListeners": -106,
"totalBlockingTimeMs": 560,
"frameDurationMs": 33.78378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.0749999999703,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 909.2710000000001,
"heapDeltaBytes": -14034600,
"heapUsedBytes": 75093916,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 67.675,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 925.8319999999856,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.5809999999999,
"heapDeltaBytes": -27050744,
"heapUsedBytes": 66376440,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 170.01100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 249,
"frameDurationMs": 25.224324324324304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.9020000000255,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.9809999999997,
"heapDeltaBytes": -29118644,
"heapUsedBytes": 65285424,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 163.40300000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.321621621621638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10709.535999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9859.524000000001,
"heapDeltaBytes": 48693288,
"heapUsedBytes": 131575904,
"domNodes": -257,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 7859.074,
"eventListeners": -68,
"totalBlockingTimeMs": 1069,
"frameDurationMs": 31.844047619047622,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10972.77200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10219.199,
"heapDeltaBytes": 78812860,
"heapUsedBytes": 152699144,
"domNodes": -257,
"jsHeapTotalBytes": 68284416,
"scriptDurationMs": 8301.245,
"eventListeners": -68,
"totalBlockingTimeMs": 1092,
"frameDurationMs": 32.25352941176471,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10055.257000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9279.588,
"heapDeltaBytes": 78977680,
"heapUsedBytes": 153174272,
"domNodes": -257,
"jsHeapTotalBytes": 62779392,
"scriptDurationMs": 7461.357999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 838,
"frameDurationMs": 31.50344827586207,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11507.078000000036,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03600000000000044,
"layouts": 1,
"layoutDurationMs": 0.18400000000000014,
"taskDurationMs": 10743.256000000001,
"heapDeltaBytes": -13763528,
"heapUsedBytes": 60204320,
"domNodes": -257,
"jsHeapTotalBytes": 18214912,
"scriptDurationMs": 8761.5,
"eventListeners": -68,
"totalBlockingTimeMs": 1638,
"frameDurationMs": 32.81136363636363,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 220.9540000000061,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.758,
"layouts": 9,
"layoutDurationMs": 2.5480000000000005,
"taskDurationMs": 162.231,
"heapDeltaBytes": 14622304,
"heapUsedBytes": 74360664,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.078999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 27.087499999999977,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 222.45299999997314,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.408999999999999,
"layouts": 8,
"layoutDurationMs": 2.2190000000000003,
"taskDurationMs": 160.52,
"heapDeltaBytes": 14560572,
"heapUsedBytes": 74010508,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.332999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2056.1309999999935,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9240000000000004,
"layouts": 8,
"layoutDurationMs": 2.175,
"taskDurationMs": 632.9030000000001,
"heapDeltaBytes": -16788208,
"heapUsedBytes": 60617448,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.708999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.716000000075,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8539999999999996,
"layouts": 8,
"layoutDurationMs": 1.865,
"taskDurationMs": 631.8149999999999,
"heapDeltaBytes": -31580892,
"heapUsedBytes": 59420352,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 35.861999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2364.223999999979,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.37,
"layouts": 7,
"layoutDurationMs": 1.8580000000000003,
"taskDurationMs": 1677.023,
"heapDeltaBytes": 809208,
"heapUsedBytes": 76356572,
"domNodes": -257,
"jsHeapTotalBytes": 5857280,
"scriptDurationMs": 828.876,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784397163120563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.565999999978,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.066,
"layouts": 7,
"layoutDurationMs": 1.6409999999999998,
"taskDurationMs": 1675.754,
"heapDeltaBytes": 4979088,
"heapUsedBytes": 81429020,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 823.268,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666433566433565,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3655.746000000022,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.126000000000001,
"layouts": 64,
"layoutDurationMs": 10.293999999999999,
"taskDurationMs": 1791.0660000000003,
"heapDeltaBytes": -11220284,
"heapUsedBytes": 69854824,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 786.3399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3689.8889999999938,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.855,
"layouts": 64,
"layoutDurationMs": 9.747,
"taskDurationMs": 1750.048,
"heapDeltaBytes": -8781040,
"heapUsedBytes": 70443828,
"domNodes": -233,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 772.8340000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3055.876000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.199,
"layouts": 6,
"layoutDurationMs": 1.491,
"taskDurationMs": 1959.0349999999999,
"heapDeltaBytes": 18861496,
"heapUsedBytes": 101699980,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 994.9489999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2951.751999999942,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.316999999999999,
"layouts": 3,
"layoutDurationMs": 0.8389999999999999,
"taskDurationMs": 1904.9870000000003,
"heapDeltaBytes": 17196016,
"heapUsedBytes": 89187700,
"domNodes": 0,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 951.155,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854802259887006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3093.503999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.85,
"layouts": 8,
"layoutDurationMs": 1.916,
"taskDurationMs": 784.1629999999999,
"heapDeltaBytes": -6101404,
"heapUsedBytes": 86794200,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 373.042,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665405405405405,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3068.5170000000426,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7920000000000003,
"layouts": 7,
"layoutDurationMs": 1.8880000000000001,
"taskDurationMs": 775.68,
"heapDeltaBytes": -15679148,
"heapUsedBytes": 77383752,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 361.25600000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.5599999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7929999999999995,
"layouts": 7,
"layoutDurationMs": 1.9230000000000003,
"taskDurationMs": 637.085,
"heapDeltaBytes": 2826876,
"heapUsedBytes": 82011608,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 37.349000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.2270000000017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.319,
"layouts": 7,
"layoutDurationMs": 1.5880000000000003,
"taskDurationMs": 621.5840000000001,
"heapDeltaBytes": 143616,
"heapUsedBytes": 79032688,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.389000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2980.3440000000023,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.139,
"layouts": 7,
"layoutDurationMs": 1.6000000000000003,
"taskDurationMs": 612.2810000000001,
"heapDeltaBytes": -19919960,
"heapUsedBytes": 60743268,
"domNodes": -243,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 189.554,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66573033707865,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2887.398000000019,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.922999999999998,
"layouts": 6,
"layoutDurationMs": 1.3800000000000001,
"taskDurationMs": 616.7499999999999,
"heapDeltaBytes": -12993204,
"heapUsedBytes": 65365844,
"domNodes": -249,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 194.189,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3257.4919999999847,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.712,
"layouts": 7,
"layoutDurationMs": 1.823,
"taskDurationMs": 940.647,
"heapDeltaBytes": -13840908,
"heapUsedBytes": 64971584,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 376.55699999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665128205128205,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3210.9800000000064,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8210000000000006,
"layouts": 8,
"layoutDurationMs": 1.8739999999999999,
"taskDurationMs": 926.891,
"heapDeltaBytes": -1904420,
"heapUsedBytes": 77792380,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 368.79699999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.910000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.61,
"layouts": 10,
"layoutDurationMs": 2.372,
"taskDurationMs": 441.59100000000007,
"heapDeltaBytes": -1381784,
"heapUsedBytes": 60657348,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 149.34,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.4889999999341,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.237,
"layouts": 8,
"layoutDurationMs": 1.8190000000000004,
"taskDurationMs": 431.233,
"heapDeltaBytes": 770836,
"heapUsedBytes": 62281804,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 143.434,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.9490000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4210000000000003,
"layouts": 10,
"layoutDurationMs": 2.578,
"taskDurationMs": 506.363,
"heapDeltaBytes": 1348564,
"heapUsedBytes": 62708180,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.365000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.1730000000562,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4149999999999996,
"layouts": 9,
"layoutDurationMs": 2.518,
"taskDurationMs": 506.37,
"heapDeltaBytes": 1747120,
"heapUsedBytes": 64110048,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 6.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6770000000133,
"styleRecalcs": 78,
"styleRecalcDurationMs": 12.539,
"layouts": 9,
"layoutDurationMs": 2.305,
"taskDurationMs": 805.5250000000001,
"heapDeltaBytes": 17412648,
"heapUsedBytes": 79667984,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 104.045,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.6769999999897,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.445999999999998,
"layouts": 9,
"layoutDurationMs": 2.293,
"taskDurationMs": 791.2379999999999,
"heapDeltaBytes": 16985612,
"heapUsedBytes": 79149156,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 101.56,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.767000000018,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.317000000000004,
"layouts": 5,
"layoutDurationMs": 14.375000000000002,
"taskDurationMs": 1034.263,
"heapDeltaBytes": 13983448,
"heapUsedBytes": 116472876,
"domNodes": 16030,
"jsHeapTotalBytes": 10883072,
"scriptDurationMs": 30.904000000000007,
"eventListeners": 3246,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.553333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8757.098999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.477999999999998,
"layouts": 7,
"layoutDurationMs": 1.7920000000000003,
"taskDurationMs": 5945.223,
"heapDeltaBytes": 5376932,
"heapUsedBytes": 81894892,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2795.678,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69770992366412,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8875.403000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.641000000000002,
"layouts": 9,
"layoutDurationMs": 2.163,
"taskDurationMs": 5804.427000000001,
"heapDeltaBytes": -4884188,
"heapUsedBytes": 86174660,
"domNodes": -257,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 2675.624,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697180451127817,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22881.414999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21915.117,
"heapDeltaBytes": -20753140,
"heapUsedBytes": 261407708,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 315.17,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.96313993174061,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22975.284999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22168.482,
"heapDeltaBytes": -18668520,
"heapUsedBytes": 264828636,
"domNodes": -3373,
"jsHeapTotalBytes": 10477568,
"scriptDurationMs": 310.645,
"eventListeners": -669,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.04,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 27724.608999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.246000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27302.09,
"heapDeltaBytes": -32596648,
"heapUsedBytes": 249954600,
"domNodes": -3343,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 874.137,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 51.45102040816326,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27913.184999999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.43699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27539.099000000002,
"heapDeltaBytes": -28027768,
"heapUsedBytes": 263334568,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 895.9100000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 51.096703296703296,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8115.970000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.407,
"layouts": 20,
"layoutDurationMs": 22.468000000000004,
"taskDurationMs": 7999.866,
"heapDeltaBytes": 3817668,
"heapUsedBytes": 276328888,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 121.64000000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.72687500000001,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8161.743999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.302,
"layouts": 20,
"layoutDurationMs": 33.232,
"taskDurationMs": 8022.772,
"heapDeltaBytes": -19784676,
"heapUsedBytes": 256429120,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 115.685,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.659064327485375,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11485.523000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10953.419999999998,
"heapDeltaBytes": 10020692,
"heapUsedBytes": 284224292,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 169.25599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.05748299319727,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11336.529000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10861.105000000001,
"heapDeltaBytes": -132036,
"heapUsedBytes": 272690404,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.476,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.9446735395189,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 134.2390000000364,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.212000000000002,
"layouts": 8,
"layoutDurationMs": 3.374,
"taskDurationMs": 107.16099999999999,
"heapDeltaBytes": -12486484,
"heapUsedBytes": 63930364,
"domNodes": 107,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.898,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 130.9720000000425,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.954,
"layouts": 8,
"layoutDurationMs": 3.799,
"taskDurationMs": 86.83899999999998,
"heapDeltaBytes": 4601808,
"heapUsedBytes": 72669596,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.3450000000000015,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 570.6460000000106,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.593,
"layouts": 76,
"layoutDurationMs": 15.282,
"taskDurationMs": 518.6569999999999,
"heapDeltaBytes": -3136644,
"heapUsedBytes": 41492532,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 259.461,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 482.5260000000071,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6669999999999999,
"layouts": 76,
"layoutDurationMs": 14.706999999999999,
"taskDurationMs": 441.131,
"heapDeltaBytes": -4191076,
"heapUsedBytes": 40397396,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 213.625,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 519.9089999999842,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.521,
"layouts": 76,
"layoutDurationMs": 13.959,
"taskDurationMs": 484.919,
"heapDeltaBytes": 251548,
"heapUsedBytes": 90798500,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 197.347,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 561.5480000000161,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6,
"layouts": 76,
"layoutDurationMs": 14.586,
"taskDurationMs": 525.135,
"heapDeltaBytes": 1528640,
"heapUsedBytes": 102757644,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 221.693,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.158823529411755,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3115 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f857903d21180abbf9bad28c1d34962e5aca96eb
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22255 +/- ##
=============================================
Coverage ? 87.45%
=============================================
Files ? 2958
Lines ? 156128
Branches ? 40108
=============================================
Hits ? 136546
Misses ? 18906
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff matches the merged original exactly. Approving.
Backport of #22238 to
cloud/1.59Automatically created by backport workflow.