Repository navigation
[backport core/1.59] fix(agent): send a tour-held first message when the tour ends in another tab - #22254
Conversation
…her tab (#22238) ## Summary A new user's first message waits behind the intro tour (#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once #21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from #21532); ported to the release lines in #22225, #22232, #22233, #22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T15:40:17.375Z",
"gitSha": "be940ddfb6af64d13131059cf7491a965deb75e5",
"branch": "backport-22238-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.4130000000139,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.14,
"layouts": 9,
"layoutDurationMs": 1.986,
"taskDurationMs": 398.41800000000006,
"heapDeltaBytes": 2183388,
"heapUsedBytes": 62864672,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.390999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2009.1390000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1449999999999996,
"layouts": 9,
"layoutDurationMs": 2.006,
"taskDurationMs": 408.75000000000006,
"heapDeltaBytes": 1769092,
"heapUsedBytes": 62971148,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.1839999999875,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.642000000000001,
"layouts": 11,
"layoutDurationMs": 2.427,
"taskDurationMs": 685.087,
"heapDeltaBytes": 21697636,
"heapUsedBytes": 82884932,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 114.762,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.655000000002,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.384,
"layouts": 9,
"layoutDurationMs": 1.9200000000000004,
"taskDurationMs": 693.302,
"heapDeltaBytes": 21782464,
"heapUsedBytes": 82642912,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 115.64500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.975000000029,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.345999999999999,
"layouts": 10,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 334.125,
"heapDeltaBytes": 24357480,
"heapUsedBytes": 85141888,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.61,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.051000000045,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.182,
"layouts": 11,
"layoutDurationMs": 2.431,
"taskDurationMs": 306.207,
"heapDeltaBytes": 24751144,
"heapUsedBytes": 86136576,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.082,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 562.7570000000048,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.842,
"layouts": 9,
"layoutDurationMs": 1.931,
"taskDurationMs": 398.442,
"heapDeltaBytes": 4410740,
"heapUsedBytes": 63987716,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 134.864,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 566.9870000000401,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.559,
"layouts": 9,
"layoutDurationMs": 2.0229999999999997,
"taskDurationMs": 402.981,
"heapDeltaBytes": 3358540,
"heapUsedBytes": 64589576,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 137.074,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.2059999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.9900000000001,
"heapDeltaBytes": -1582900,
"heapUsedBytes": 75184612,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 44.12100000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 380,
"frameDurationMs": 29.519999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1054.943000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.9369999999999,
"heapDeltaBytes": -12270808,
"heapUsedBytes": 75026308,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 50.888000000000005,
"eventListeners": -106,
"totalBlockingTimeMs": 385,
"frameDurationMs": 29.169444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 815.9919999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.7170000000004,
"heapDeltaBytes": -25915320,
"heapUsedBytes": 66461112,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 116.129,
"eventListeners": -106,
"totalBlockingTimeMs": 159,
"frameDurationMs": 22.686111111111106,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 815.0549999999726,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.75100000000015,
"heapDeltaBytes": -24439448,
"heapUsedBytes": 66450652,
"domNodes": -191,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 125.713,
"eventListeners": -106,
"totalBlockingTimeMs": 160,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7249.5890000000145,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4710000000000001,
"layouts": 2,
"layoutDurationMs": 0.46699999999999997,
"taskDurationMs": 6457.3,
"heapDeltaBytes": 46117748,
"heapUsedBytes": 119312456,
"domNodes": -257,
"jsHeapTotalBytes": 52293632,
"scriptDurationMs": 4962.382,
"eventListeners": -68,
"totalBlockingTimeMs": 45,
"frameDurationMs": 24.32785234899329,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7636.588000000018,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.556,
"layouts": 2,
"layoutDurationMs": 0.4320000000000001,
"taskDurationMs": 6822.579,
"heapDeltaBytes": 58483632,
"heapUsedBytes": 132918220,
"domNodes": -257,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 5331.914000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 63,
"frameDurationMs": 24.43993610223642,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6990.358000000015,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.078,
"layouts": 4,
"layoutDurationMs": 0.9420000000000002,
"taskDurationMs": 6344.349999999999,
"heapDeltaBytes": -22862356,
"heapUsedBytes": 65517184,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 4952.064,
"eventListeners": -68,
"totalBlockingTimeMs": 131,
"frameDurationMs": 25.11870503597122,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7712.840000000028,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.47800000000000015,
"layouts": 2,
"layoutDurationMs": 0.49,
"taskDurationMs": 6947.226000000001,
"heapDeltaBytes": 66303444,
"heapUsedBytes": 138596972,
"domNodes": -257,
"jsHeapTotalBytes": 61206528,
"scriptDurationMs": 5439.638999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 42,
"frameDurationMs": 24.521337579617835,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 170.5739999999878,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.193,
"layouts": 10,
"layoutDurationMs": 2.807,
"taskDurationMs": 136.26900000000003,
"heapDeltaBytes": 14376172,
"heapUsedBytes": 90413688,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.696,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.828571428571454,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-combo-open",
"durationMs": 180.78600000001188,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.528,
"layouts": 11,
"layoutDurationMs": 2.521,
"taskDurationMs": 131.25300000000001,
"heapDeltaBytes": 14461476,
"heapUsedBytes": 84138548,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.556000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.799999999999986,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2026.2150000000076,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.033,
"layouts": 9,
"layoutDurationMs": 1.8170000000000002,
"taskDurationMs": 502.9030000000001,
"heapDeltaBytes": 6774192,
"heapUsedBytes": 83754432,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 29.804,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7890000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.889,
"layouts": 8,
"layoutDurationMs": 1.7609999999999997,
"taskDurationMs": 509.477,
"heapDeltaBytes": -9551928,
"heapUsedBytes": 64989520,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.326000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2270.4339999999947,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.84,
"layouts": 7,
"layoutDurationMs": 1.676,
"taskDurationMs": 1350.5800000000002,
"heapDeltaBytes": -5958624,
"heapUsedBytes": 86052900,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 657.865,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.4070000000092,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.365,
"layouts": 7,
"layoutDurationMs": 1.4700000000000002,
"taskDurationMs": 1299.9089999999999,
"heapDeltaBytes": -13883848,
"heapUsedBytes": 61047532,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 631.1379999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3517.282999999992,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.475000000000001,
"layouts": 65,
"layoutDurationMs": 10.195,
"taskDurationMs": 1457.3080000000002,
"heapDeltaBytes": 4609336,
"heapUsedBytes": 82319684,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 654.208,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665402843601896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3337.284000000011,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.4,
"layouts": 66,
"layoutDurationMs": 10.102,
"taskDurationMs": 1393.488,
"heapDeltaBytes": -20176224,
"heapUsedBytes": 73512908,
"domNodes": 24,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 621.848,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2650.564000000003,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.175,
"layouts": 6,
"layoutDurationMs": 1.34,
"taskDurationMs": 1651.758,
"heapDeltaBytes": 9246328,
"heapUsedBytes": 81460224,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 842.308,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2315.384999999992,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.218,
"layouts": 7,
"layoutDurationMs": 1.4780000000000002,
"taskDurationMs": 1561.3029999999999,
"heapDeltaBytes": 11515796,
"heapUsedBytes": 89783736,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 772.384,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.787591240875912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2933.785999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8250000000000002,
"layouts": 8,
"layoutDurationMs": 1.576,
"taskDurationMs": 643.8000000000002,
"heapDeltaBytes": -14678820,
"heapUsedBytes": 61539192,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 305.168,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2874.324999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8149999999999997,
"layouts": 8,
"layoutDurationMs": 1.7940000000000003,
"taskDurationMs": 556.467,
"heapDeltaBytes": -12171880,
"heapUsedBytes": 80835268,
"domNodes": -257,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 301.015,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767437,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.7969999999732,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7730000000000004,
"layouts": 7,
"layoutDurationMs": 1.5529999999999997,
"taskDurationMs": 521.782,
"heapDeltaBytes": -9975140,
"heapUsedBytes": 82694252,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 29.921000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.1580000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8450000000000002,
"layouts": 8,
"layoutDurationMs": 1.9020000000000001,
"taskDurationMs": 499.861,
"heapDeltaBytes": 2366716,
"heapUsedBytes": 81651888,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.227000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2723.219,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.168,
"layouts": 8,
"layoutDurationMs": 1.469,
"taskDurationMs": 467.69000000000005,
"heapDeltaBytes": -12360676,
"heapUsedBytes": 81058124,
"domNodes": -251,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 146.974,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2679.826999999989,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.183000000000002,
"layouts": 7,
"layoutDurationMs": 1.2260000000000002,
"taskDurationMs": 414.804,
"heapDeltaBytes": -23176812,
"heapUsedBytes": 69295344,
"domNodes": -241,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 150.01700000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3038.9789999999834,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.809,
"layouts": 8,
"layoutDurationMs": 1.6409999999999998,
"taskDurationMs": 739.362,
"heapDeltaBytes": -19145084,
"heapUsedBytes": 74074780,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 284.57300000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3005.035000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6889999999999996,
"layouts": 8,
"layoutDurationMs": 1.642,
"taskDurationMs": 731.211,
"heapDeltaBytes": -32899796,
"heapUsedBytes": 60032360,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 278.222,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.9440000000009,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.385000000000001,
"layouts": 9,
"layoutDurationMs": 2.003,
"taskDurationMs": 358.67900000000003,
"heapDeltaBytes": -827796,
"heapUsedBytes": 61000792,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 121.643,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.0639999999912,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.512,
"layouts": 10,
"layoutDurationMs": 2.1140000000000003,
"taskDurationMs": 349.769,
"heapDeltaBytes": 2239988,
"heapUsedBytes": 73368984,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 117.871,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.147999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.209,
"layouts": 9,
"layoutDurationMs": 2.1350000000000002,
"taskDurationMs": 408.995,
"heapDeltaBytes": 1066888,
"heapUsedBytes": 62750052,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.095000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.55399999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.541,
"layouts": 11,
"layoutDurationMs": 2.254,
"taskDurationMs": 409.283,
"heapDeltaBytes": 4834072,
"heapUsedBytes": 77067964,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 7.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.2129999999947,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.653999999999998,
"layouts": 9,
"layoutDurationMs": 2.0409999999999995,
"taskDurationMs": 654.8629999999999,
"heapDeltaBytes": 16989944,
"heapUsedBytes": 78889068,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 85.22399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1659999999997,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.431999999999999,
"layouts": 10,
"layoutDurationMs": 2.177,
"taskDurationMs": 644.37,
"heapDeltaBytes": 17387292,
"heapUsedBytes": 79293544,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 86.42800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.9179999999924,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.143000000000004,
"layouts": 5,
"layoutDurationMs": 10.136,
"taskDurationMs": 855.8589999999999,
"heapDeltaBytes": 11608500,
"heapUsedBytes": 112992984,
"domNodes": 16030,
"jsHeapTotalBytes": 5902336,
"scriptDurationMs": 24.575,
"eventListeners": 3246,
"totalBlockingTimeMs": 94,
"frameDurationMs": 18.493150684931507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8578.28600000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.555999999999997,
"layouts": 8,
"layoutDurationMs": 1.8419999999999999,
"taskDurationMs": 4703.685,
"heapDeltaBytes": -11230536,
"heapUsedBytes": 61010168,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 2141.176,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8380.520000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.878999999999998,
"layouts": 9,
"layoutDurationMs": 2.096,
"taskDurationMs": 4582.154,
"heapDeltaBytes": -13355100,
"heapUsedBytes": 63937624,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2142.3399999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699402390438248,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19951.976000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19275.041999999998,
"heapDeltaBytes": -20093636,
"heapUsedBytes": 258171464,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 260.689,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.13985507246377,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 19477.427999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18996.846,
"heapDeltaBytes": -38412244,
"heapUsedBytes": 257915468,
"domNodes": -3343,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 258.266,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.36061643835616,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23913.350999999977,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.877000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23659.225,
"heapDeltaBytes": -25227064,
"heapUsedBytes": 266646928,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 753.447,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 46.04816955684008,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23472.599999999944,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.717999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23226.46,
"heapDeltaBytes": -51533532,
"heapUsedBytes": 250357272,
"domNodes": -3343,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 708.2429999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.32546125461254,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6999.457000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.89999999999998,
"layouts": 20,
"layoutDurationMs": 21.852999999999998,
"taskDurationMs": 6857.323,
"heapDeltaBytes": -37469732,
"heapUsedBytes": 258685572,
"domNodes": -3343,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 104.94899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 13,
"frameDurationMs": 39.54632768361582,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7161.8219999999155,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.955,
"layouts": 20,
"layoutDurationMs": 21.833000000000006,
"taskDurationMs": 7090.154000000001,
"heapDeltaBytes": -16342028,
"heapUsedBytes": 272071044,
"domNodes": -307,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 106.90000000000002,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.15588235294118,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9519.241999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9351.291,
"heapDeltaBytes": -15795892,
"heapUsedBytes": 270335568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.39299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.60472727272727,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9838.722000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9465.328999999998,
"heapDeltaBytes": -14631872,
"heapUsedBytes": 268221312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.18900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.501754385964915,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 454.7749999999837,
"styleRecalcs": 17,
"styleRecalcDurationMs": 8.746,
"layouts": 12,
"layoutDurationMs": 3.3080000000000003,
"taskDurationMs": 109.10700000000001,
"heapDeltaBytes": -10042464,
"heapUsedBytes": 66324228,
"domNodes": 136,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.057,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 90.75000000007094,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.9190000000000005,
"layouts": 7,
"layoutDurationMs": 2.0149999999999997,
"taskDurationMs": 62.842999999999996,
"heapDeltaBytes": -12859812,
"heapUsedBytes": 63618344,
"domNodes": 121,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4.912,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 299.17999999997846,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6,
"layouts": 76,
"layoutDurationMs": 11.093,
"taskDurationMs": 252.47599999999997,
"heapDeltaBytes": 10551964,
"heapUsedBytes": 50706996,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 116.956,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661111111111115,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 277.7529999999615,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.583,
"layouts": 76,
"layoutDurationMs": 11.880999999999998,
"taskDurationMs": 238.186,
"heapDeltaBytes": -3625520,
"heapUsedBytes": 35992412,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 108.90599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 316.9820000000527,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.446,
"layouts": 76,
"layoutDurationMs": 11.14,
"taskDurationMs": 285.337,
"heapDeltaBytes": -1044560,
"heapUsedBytes": 88862192,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.665,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 326.9830000000411,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.126,
"layouts": 76,
"layoutDurationMs": 11.724,
"taskDurationMs": 302.688,
"heapDeltaBytes": -594412,
"heapUsedBytes": 93105132,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 105.127,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3121 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2ca3cf799a5d732024fda30d29ff4a90b00b8981
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22254 +/- ##
=============================================
- Coverage 87.46% 87.46% -0.01%
=============================================
Files 2958 2958
Lines 156126 156133 +7
Branches 40083 42217 +2134
=============================================
+ Hits 136555 136556 +1
- Misses 18895 18901 +6
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff matches the merged original exactly. Approving.
Backport of #22238 to
core/1.59Automatically created by backport workflow.