Repository navigation
[backport cloud/1.58] fix(agent): send a tour-held first message when the tour ends in another tab - #22253
Conversation
…her tab (#22238) ## Summary A new user's first message waits behind the intro tour (#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once #21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from #21532); ported to the release lines in #22225, #22232, #22233, #22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T15:38:51.886Z",
"gitSha": "d28f14270a927597b9d5890084322a128709c5ec",
"branch": "backport-22238-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.4299999999905,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4990000000000006,
"layouts": 11,
"layoutDurationMs": 3.065,
"taskDurationMs": 439.40100000000007,
"heapDeltaBytes": 1520556,
"heapUsedBytes": 89448020,
"domNodes": -180,
"jsHeapTotalBytes": -3866624,
"scriptDurationMs": 11.756,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2026.5899999999988,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.609,
"layouts": 10,
"layoutDurationMs": 2.289,
"taskDurationMs": 292.53,
"heapDeltaBytes": -839952,
"heapUsedBytes": 90595412,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 6.277000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.4870000000135,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.846,
"layouts": 9,
"layoutDurationMs": 2.1790000000000003,
"taskDurationMs": 570.673,
"heapDeltaBytes": 18885388,
"heapUsedBytes": 110108832,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 104.66300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673263,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.9110000000237,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.81,
"layouts": 9,
"layoutDurationMs": 2.027,
"taskDurationMs": 481.8,
"heapDeltaBytes": -1333288,
"heapUsedBytes": 87674388,
"domNodes": -201,
"jsHeapTotalBytes": 65536,
"scriptDurationMs": 96.567,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.0480000000248,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.37,
"layouts": 11,
"layoutDurationMs": 2.3870000000000005,
"taskDurationMs": 314.57099999999997,
"heapDeltaBytes": 2148556,
"heapUsedBytes": 98421848,
"domNodes": 47,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 14.399000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8229999999717,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.092999999999999,
"layouts": 11,
"layoutDurationMs": 2.857,
"taskDurationMs": 299.22499999999997,
"heapDeltaBytes": -3985828,
"heapUsedBytes": 98435384,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.748999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 548.8630000000114,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.33,
"layouts": 10,
"layoutDurationMs": 2.771,
"taskDurationMs": 354.731,
"heapDeltaBytes": 5001620,
"heapUsedBytes": 101935028,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 112.80199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 447.2470000000044,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.928,
"layouts": 11,
"layoutDurationMs": 2.666,
"taskDurationMs": 295.771,
"heapDeltaBytes": 298412,
"heapUsedBytes": 88089500,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 101.918,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 876.0000000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.794,
"heapDeltaBytes": -5080864,
"heapUsedBytes": 102103868,
"domNodes": -210,
"jsHeapTotalBytes": 7704576,
"scriptDurationMs": 33.193999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 253,
"frameDurationMs": 25.23714285714285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 943.0640000000494,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.4010000000001,
"heapDeltaBytes": -13726836,
"heapUsedBytes": 102491352,
"domNodes": -230,
"jsHeapTotalBytes": 15802368,
"scriptDurationMs": 41.934999999999995,
"eventListeners": -168,
"totalBlockingTimeMs": 292,
"frameDurationMs": 26.38888888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.0730000000228,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.2480000000001,
"heapDeltaBytes": -36409128,
"heapUsedBytes": 92860256,
"domNodes": -230,
"jsHeapTotalBytes": -2973696,
"scriptDurationMs": 97.45800000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.4742857142857,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.959999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.8780000000002,
"heapDeltaBytes": -3456592,
"heapUsedBytes": 97106336,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 95.94999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6892.325,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9309999999999995,
"layouts": 3,
"layoutDurationMs": 0.8389999999999999,
"taskDurationMs": 5956.594,
"heapDeltaBytes": 30126280,
"heapUsedBytes": 134384736,
"domNodes": -276,
"jsHeapTotalBytes": 23474176,
"scriptDurationMs": 4447.098,
"eventListeners": -130,
"totalBlockingTimeMs": 128,
"frameDurationMs": 21.509687500000002,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6387.884999999983,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8980000000000004,
"layouts": 3,
"layoutDurationMs": 0.7629999999999998,
"taskDurationMs": 5320.235000000001,
"heapDeltaBytes": 37981108,
"heapUsedBytes": 140480696,
"domNodes": -302,
"jsHeapTotalBytes": 22085632,
"scriptDurationMs": 3963.784,
"eventListeners": -130,
"totalBlockingTimeMs": 17,
"frameDurationMs": 19.04672619047619,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6352.95099999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2649999999999997,
"layouts": 4,
"layoutDurationMs": 1.1740000000000002,
"taskDurationMs": 5305.165000000001,
"heapDeltaBytes": -5256964,
"heapUsedBytes": 113849688,
"domNodes": -276,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 4011.096,
"eventListeners": -130,
"totalBlockingTimeMs": 25,
"frameDurationMs": 20.221974522292992,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5768.3519999999935,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9689999999999994,
"layouts": 4,
"layoutDurationMs": 0.853,
"taskDurationMs": 4774.485000000001,
"heapDeltaBytes": 16094528,
"heapUsedBytes": 121501856,
"domNodes": -297,
"jsHeapTotalBytes": 23658496,
"scriptDurationMs": 3730.151,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 18.84444444444444,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 158.11500000000933,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.377999999999998,
"layouts": 12,
"layoutDurationMs": 3.269,
"taskDurationMs": 122.02300000000001,
"heapDeltaBytes": 15532892,
"heapUsedBytes": 118055332,
"domNodes": 917,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 6.643000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 146.46200000004228,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.149999999999999,
"layouts": 13,
"layoutDurationMs": 3.1149999999999998,
"taskDurationMs": 107.181,
"heapDeltaBytes": 13353500,
"heapUsedBytes": 115916224,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 5.881000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2026.9049999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3360000000000003,
"layouts": 10,
"layoutDurationMs": 2.052,
"taskDurationMs": 398.517,
"heapDeltaBytes": 1719432,
"heapUsedBytes": 108029472,
"domNodes": -276,
"jsHeapTotalBytes": -1601536,
"scriptDurationMs": 23.386000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.2749999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7889999999999997,
"layouts": 8,
"layoutDurationMs": 1.6079999999999999,
"taskDurationMs": 377.624,
"heapDeltaBytes": -15985360,
"heapUsedBytes": 90349480,
"domNodes": -296,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 19.947,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2582.936000000018,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.620999999999999,
"layouts": 8,
"layoutDurationMs": 2.1200000000000006,
"taskDurationMs": 1249.248,
"heapDeltaBytes": 397236,
"heapUsedBytes": 108355184,
"domNodes": -276,
"jsHeapTotalBytes": 458752,
"scriptDurationMs": 566.2539999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665584415584416,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2179.6549999999684,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.703000000000001,
"layouts": 10,
"layoutDurationMs": 2.2979999999999996,
"taskDurationMs": 1050.866,
"heapDeltaBytes": -3863228,
"heapUsedBytes": 103818164,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 521.4159999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3222.2940000000053,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.082999999999998,
"layouts": 68,
"layoutDurationMs": 11.09,
"taskDurationMs": 1158.6919999999998,
"heapDeltaBytes": -12615868,
"heapUsedBytes": 96396372,
"domNodes": -252,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 499.97999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66546391752577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3535.9660000000304,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.850000000000001,
"layouts": 67,
"layoutDurationMs": 11.713999999999999,
"taskDurationMs": 1273.715,
"heapDeltaBytes": -17797432,
"heapUsedBytes": 91282224,
"domNodes": -272,
"jsHeapTotalBytes": -1470464,
"scriptDurationMs": 532.084,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2366.317000000009,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.148,
"layouts": 8,
"layoutDurationMs": 1.903,
"taskDurationMs": 1272.18,
"heapDeltaBytes": 9586888,
"heapUsedBytes": 110355912,
"domNodes": 0,
"jsHeapTotalBytes": 4685824,
"scriptDurationMs": 624.363,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2317.453999999998,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.243,
"layouts": 6,
"layoutDurationMs": 1.438,
"taskDurationMs": 1322.545,
"heapDeltaBytes": 15845256,
"heapUsedBytes": 125854756,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 654.202,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618705035971,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.2819999999656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7439999999999998,
"layouts": 10,
"layoutDurationMs": 2.4679999999999995,
"taskDurationMs": 346.03200000000004,
"heapDeltaBytes": 7173784,
"heapUsedBytes": 109186196,
"domNodes": -276,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 27.712,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2053.5540000000196,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2030000000000003,
"layouts": 9,
"layoutDurationMs": 2.5899999999999994,
"taskDurationMs": 507.092,
"heapDeltaBytes": 1799356,
"heapUsedBytes": 111187956,
"domNodes": -296,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 32.899,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.15899999994645,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.644000000000001,
"layouts": 10,
"layoutDurationMs": 2.5359999999999996,
"taskDurationMs": 296.36899999999997,
"heapDeltaBytes": 22445472,
"heapUsedBytes": 112255892,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 99.31,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 497.27699999999686,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.169,
"layouts": 9,
"layoutDurationMs": 2.365,
"taskDurationMs": 321.132,
"heapDeltaBytes": 329636,
"heapUsedBytes": 99596172,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 103.438,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2026.4340000000232,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7279999999999993,
"layouts": 10,
"layoutDurationMs": 2.269,
"taskDurationMs": 365.379,
"heapDeltaBytes": -103540,
"heapUsedBytes": 89722044,
"domNodes": -222,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 7.431000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.6080000000102,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.174,
"layouts": 10,
"layoutDurationMs": 1.965,
"taskDurationMs": 255.67499999999998,
"heapDeltaBytes": 2468048,
"heapUsedBytes": 92887716,
"domNodes": -218,
"jsHeapTotalBytes": -3342336,
"scriptDurationMs": 5.433000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.9520000000007,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.713,
"layouts": 10,
"layoutDurationMs": 2.6109999999999998,
"taskDurationMs": 562.337,
"heapDeltaBytes": -5126760,
"heapUsedBytes": 85050440,
"domNodes": -210,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 77.69699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.850000000035,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.136000000000001,
"layouts": 10,
"layoutDurationMs": 2.114,
"taskDurationMs": 532.313,
"heapDeltaBytes": 15009060,
"heapUsedBytes": 107476360,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 81.434,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.8919999999998,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.977000000000002,
"layouts": 5,
"layoutDurationMs": 9.636000000000001,
"taskDurationMs": 495.939,
"heapDeltaBytes": 37960928,
"heapUsedBytes": 137124772,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 19.242,
"eventListeners": 3244,
"totalBlockingTimeMs": 65,
"frameDurationMs": 19.51219512195122,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "viewport-pan-sweep",
"durationMs": 8237.442999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.405,
"layouts": 9,
"layoutDurationMs": 2.418,
"taskDurationMs": 3579.794,
"heapDeltaBytes": 3720420,
"heapUsedBytes": 105336704,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 1906.0040000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9808.64600000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.248,
"layouts": 9,
"layoutDurationMs": 2.2259999999999995,
"taskDurationMs": 4462.438,
"heapDeltaBytes": 12955108,
"heapUsedBytes": 114658996,
"domNodes": -276,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 1987.7900000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660441426146,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12492.676000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11548.494000000002,
"heapDeltaBytes": -43483560,
"heapUsedBytes": 290207548,
"domNodes": -3344,
"jsHeapTotalBytes": 28299264,
"scriptDurationMs": 188.489,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.2213921901528,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 16504.189999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15609.225999999999,
"heapDeltaBytes": -18186924,
"heapUsedBytes": 288581228,
"domNodes": -3344,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 249.04299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.723478260869573,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 14312.122999999985,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.379,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13639.157999999998,
"heapDeltaBytes": -21199540,
"heapUsedBytes": 285158304,
"domNodes": -3344,
"jsHeapTotalBytes": 23842816,
"scriptDurationMs": 589.9879999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 25,
"frameDurationMs": 25.219576719576718,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18328.396999999997,
"styleRecalcs": 156,
"styleRecalcDurationMs": 19.507000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17949.721,
"heapDeltaBytes": -26724404,
"heapUsedBytes": 304105820,
"domNodes": -3344,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 647.4000000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.39253187613844,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5446.407000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.828,
"layouts": 20,
"layoutDurationMs": 18.226999999999993,
"taskDurationMs": 5291.2660000000005,
"heapDeltaBytes": -16013716,
"heapUsedBytes": 303757332,
"domNodes": -307,
"jsHeapTotalBytes": 26206208,
"scriptDurationMs": 72.614,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.53353293413174,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 5695.705999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.937,
"layouts": 20,
"layoutDurationMs": 20.789,
"taskDurationMs": 5563.993,
"heapDeltaBytes": -44594184,
"heapUsedBytes": 284808844,
"domNodes": -3344,
"jsHeapTotalBytes": 24629248,
"scriptDurationMs": 86.06599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.72662721893491,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7046.5410000000475,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6627.399000000002,
"heapDeltaBytes": -4363752,
"heapUsedBytes": 294385164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 78.53099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.060409556313996,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7915.88999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7423.277000000003,
"heapDeltaBytes": -3187868,
"heapUsedBytes": 295920144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.72799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.33460207612457,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 88.20600000001377,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.263000000000001,
"layouts": 6,
"layoutDurationMs": 2.156,
"taskDurationMs": 60.403,
"heapDeltaBytes": -19637680,
"heapUsedBytes": 90689268,
"domNodes": 118,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.4399999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 444.7940000000017,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.267999999999999,
"layouts": 12,
"layoutDurationMs": 3.326,
"taskDurationMs": 95.27899999999998,
"heapDeltaBytes": 6938896,
"heapUsedBytes": 95154984,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.686,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 290.9220000000232,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.741,
"layouts": 76,
"layoutDurationMs": 15.417,
"taskDurationMs": 243.25100000000003,
"heapDeltaBytes": -18697256,
"heapUsedBytes": 69825588,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 104.311,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 266.1039999999275,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.639,
"layouts": 76,
"layoutDurationMs": 13.761000000000001,
"taskDurationMs": 217.03699999999998,
"heapDeltaBytes": 9945272,
"heapUsedBytes": 98442252,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 94.026,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 331.13399999990634,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.594,
"layouts": 76,
"layoutDurationMs": 14.333,
"taskDurationMs": 293.111,
"heapDeltaBytes": -1264992,
"heapUsedBytes": 115687712,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 99.55,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 315.68400000003294,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9729999999999999,
"layouts": 76,
"layoutDurationMs": 12.549,
"taskDurationMs": 268.07399999999996,
"heapDeltaBytes": -772868,
"heapUsedBytes": 118955640,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.381,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67368421052628,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2986 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3366b78810bb3262740411c51cc8c5d9a835b233
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (132)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22253 +/- ##
=============================================
Coverage ? 84.51%
=============================================
Files ? 3102
Lines ? 163065
Branches ? 38977
=============================================
Hits ? 137811
Misses ? 24863
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff matches the merged original exactly. Approving.
Backport of #22238 to
cloud/1.58Automatically created by backport workflow.