Repository navigation
[backport cloud/1.57] fix(agent): send a tour-held first message when the tour ends in another tab - #22251
Conversation
…her tab (#22238) ## Summary A new user's first message waits behind the intro tour (#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once #21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from #21532); ported to the release lines in #22225, #22232, #22233, #22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T15:38:52.687Z",
"gitSha": "59e0b0e47529d87e0e7797c84fcc4821b2c79a56",
"branch": "backport-22238-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.683999999979,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8939999999999997,
"layouts": 11,
"layoutDurationMs": 2.639,
"taskDurationMs": 290.516,
"heapDeltaBytes": 22138664,
"heapUsedBytes": 87558560,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.062999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.152999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3899999999999997,
"layouts": 11,
"layoutDurationMs": 2.1660000000000004,
"taskDurationMs": 292.966,
"heapDeltaBytes": 22146536,
"heapUsedBytes": 87973500,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.792,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.543000000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.691,
"layouts": 10,
"layoutDurationMs": 2.26,
"taskDurationMs": 530.4110000000001,
"heapDeltaBytes": -8227076,
"heapUsedBytes": 66669864,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 99.39999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.9319999999984,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.138,
"layouts": 11,
"layoutDurationMs": 2.428,
"taskDurationMs": 522.179,
"heapDeltaBytes": -8057008,
"heapUsedBytes": 67328840,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 96.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6000000000427,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.054,
"layouts": 12,
"layoutDurationMs": 2.227,
"taskDurationMs": 222.34900000000002,
"heapDeltaBytes": 18744764,
"heapUsedBytes": 84497212,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7.73,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6980000000226,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.6930000000000005,
"layouts": 12,
"layoutDurationMs": 2.4990000000000006,
"taskDurationMs": 221.273,
"heapDeltaBytes": 18813340,
"heapUsedBytes": 84708812,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.362999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 432.0219999999608,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.771,
"layouts": 10,
"layoutDurationMs": 2.502,
"taskDurationMs": 311.76800000000003,
"heapDeltaBytes": 7991696,
"heapUsedBytes": 81603060,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 108.054,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 476.5239999999835,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.7990000000000004,
"layouts": 11,
"layoutDurationMs": 2.816,
"taskDurationMs": 307.882,
"heapDeltaBytes": 25585664,
"heapUsedBytes": 91443268,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 105.17800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 921.6769999999883,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.266,
"heapDeltaBytes": 2259716,
"heapUsedBytes": 81688900,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 36.138999999999996,
"eventListeners": -105,
"totalBlockingTimeMs": 275,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 925.03099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.7719999999999,
"heapDeltaBytes": -11612164,
"heapUsedBytes": 81154372,
"domNodes": -192,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 37.669999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 277,
"frameDurationMs": 25.922222222222217,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.4859999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.7330000000001,
"heapDeltaBytes": -4473996,
"heapUsedBytes": 76395520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 93.54799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.0610000000479,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.8830000000001,
"heapDeltaBytes": -5492504,
"heapUsedBytes": 75921340,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 93.778,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6583.046999999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.2960000000000003,
"layouts": 3,
"layoutDurationMs": 0.7849999999999997,
"taskDurationMs": 5428.051,
"heapDeltaBytes": 7387912,
"heapUsedBytes": 84641504,
"domNodes": -258,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 4254.008,
"eventListeners": -68,
"totalBlockingTimeMs": 38,
"frameDurationMs": 22.7,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6416.980000000023,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8570000000000001,
"layouts": 3,
"layoutDurationMs": 0.7360000000000001,
"taskDurationMs": 5161.006,
"heapDeltaBytes": 12710136,
"heapUsedBytes": 90586868,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 3969.5739999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.80339506172839,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6497.4360000000215,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.883000000000001,
"layouts": 3,
"layoutDurationMs": 0.7699999999999998,
"taskDurationMs": 5376.820000000001,
"heapDeltaBytes": -15441324,
"heapUsedBytes": 83145880,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 4116.344000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 52,
"frameDurationMs": 20.2596875,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6505.876999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8240000000000001,
"layouts": 3,
"layoutDurationMs": 0.719,
"taskDurationMs": 5459.902999999999,
"heapDeltaBytes": -9859860,
"heapUsedBytes": 86769600,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 4216.0689999999995,
"eventListeners": -67,
"totalBlockingTimeMs": 23,
"frameDurationMs": 20.75286624203822,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 210.11799999999425,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.796,
"layouts": 12,
"layoutDurationMs": 3.603,
"taskDurationMs": 145.638,
"heapDeltaBytes": -8268880,
"heapUsedBytes": 79357400,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.445000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 9,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 162.30200000001105,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.653,
"layouts": 11,
"layoutDurationMs": 2.891,
"taskDurationMs": 119.82399999999998,
"heapDeltaBytes": -8058420,
"heapUsedBytes": 79760028,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.240000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2024.7889999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6550000000000002,
"layouts": 9,
"layoutDurationMs": 2.237,
"taskDurationMs": 420.91200000000003,
"heapDeltaBytes": -2381612,
"heapUsedBytes": 76569684,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 26.357,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.1339999999896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.651,
"layouts": 10,
"layoutDurationMs": 2.616,
"taskDurationMs": 446.3739999999999,
"heapDeltaBytes": -25649016,
"heapUsedBytes": 72791800,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 31.264,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2264.300999999989,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.39,
"layouts": 9,
"layoutDurationMs": 2.111,
"taskDurationMs": 1116.3480000000002,
"heapDeltaBytes": -11215220,
"heapUsedBytes": 68706088,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 537.791,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617647058823,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2416.2130000000275,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.098999999999998,
"layouts": 8,
"layoutDurationMs": 2.297,
"taskDurationMs": 1249.568,
"heapDeltaBytes": -12433860,
"heapUsedBytes": 67871624,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 589.208,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379312,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3169.212000000016,
"styleRecalcs": 74,
"styleRecalcDurationMs": 8.441999999999998,
"layouts": 67,
"layoutDurationMs": 11.386000000000001,
"taskDurationMs": 1126.307,
"heapDeltaBytes": -2545748,
"heapUsedBytes": 96818628,
"domNodes": 24,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 501.772,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3172.2489999999652,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.578000000000001,
"layouts": 67,
"layoutDurationMs": 11.444,
"taskDurationMs": 1079.287,
"heapDeltaBytes": 2040872,
"heapUsedBytes": 83312032,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 522.585,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2370.6090000000017,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.637,
"layouts": 7,
"layoutDurationMs": 1.597,
"taskDurationMs": 1243.158,
"heapDeltaBytes": 11142988,
"heapUsedBytes": 94515248,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 619.332,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2204.4950000000085,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.634,
"layouts": 6,
"layoutDurationMs": 1.5070000000000001,
"taskDurationMs": 1180.6290000000001,
"heapDeltaBytes": 785440,
"heapUsedBytes": 84574480,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 642.3019999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.5879999999888,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.66,
"layouts": 8,
"layoutDurationMs": 1.5489999999999997,
"taskDurationMs": 382.54600000000005,
"heapDeltaBytes": -2149388,
"heapUsedBytes": 79386656,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 23.246000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.7100000000082,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.272,
"layouts": 10,
"layoutDurationMs": 2.035,
"taskDurationMs": 382.649,
"heapDeltaBytes": -21448084,
"heapUsedBytes": 77131308,
"domNodes": -258,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 23.502000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 380.6680000000142,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.774000000000001,
"layouts": 10,
"layoutDurationMs": 2.412,
"taskDurationMs": 239.04799999999997,
"heapDeltaBytes": 19840032,
"heapUsedBytes": 86743528,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 92.387,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66956521739131,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.63000000001193,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.842999999999999,
"layouts": 10,
"layoutDurationMs": 2.282,
"taskDurationMs": 280.647,
"heapDeltaBytes": -1053568,
"heapUsedBytes": 75926288,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 92.75599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.281000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.224,
"layouts": 10,
"layoutDurationMs": 2.1719999999999997,
"taskDurationMs": 298.293,
"heapDeltaBytes": -636476,
"heapUsedBytes": 76283684,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6.111999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.8330000000478,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.614,
"layouts": 11,
"layoutDurationMs": 2.346,
"taskDurationMs": 229.143,
"heapDeltaBytes": 21603336,
"heapUsedBytes": 88508508,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.257000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5260000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.176000000000002,
"layouts": 10,
"layoutDurationMs": 2.439,
"taskDurationMs": 555.1830000000001,
"heapDeltaBytes": 10840696,
"heapUsedBytes": 77888464,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 88.54500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2940000000135,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.303,
"layouts": 9,
"layoutDurationMs": 3.0689999999999995,
"taskDurationMs": 604.4929999999999,
"heapDeltaBytes": 10914104,
"heapUsedBytes": 77799088,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 92.693,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.7140000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.091000000000005,
"layouts": 5,
"layoutDurationMs": 9.879999999999999,
"taskDurationMs": 668.822,
"heapDeltaBytes": 7298412,
"heapUsedBytes": 105058568,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 20.222000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 74,
"frameDurationMs": 19.259999999999994,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8303.529000000026,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.784,
"layouts": 10,
"layoutDurationMs": 2.269,
"taskDurationMs": 3777.0789999999997,
"heapDeltaBytes": 3853020,
"heapUsedBytes": 82754516,
"domNodes": -258,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 1823.443,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66606425702811,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8251.671000000044,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.540999999999997,
"layouts": 9,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 3801.2509999999997,
"heapDeltaBytes": -10774344,
"heapUsedBytes": 68996624,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 1842.638,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "vue-large-graph-idle",
"durationMs": 15345.355999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14586.898000000001,
"heapDeltaBytes": -19294316,
"heapUsedBytes": 256833688,
"domNodes": -3330,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 186.18,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.7411149825784,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16352.090000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15409.243999999999,
"heapDeltaBytes": -22155064,
"heapUsedBytes": 264402500,
"domNodes": -3330,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 220.72400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.237305699481865,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18325.19199999996,
"styleRecalcs": 152,
"styleRecalcDurationMs": 13.026999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18038.785,
"heapDeltaBytes": -1697276,
"heapUsedBytes": 280224840,
"domNodes": -3330,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 625.204,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 34.20261194029851,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18725.864,
"styleRecalcs": 139,
"styleRecalcDurationMs": 13.857000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18455.318,
"heapDeltaBytes": 826428,
"heapUsedBytes": 283017220,
"domNodes": -3330,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 651.9430000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.656746765249544,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5689.883000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.29,
"layouts": 20,
"layoutDurationMs": 22.04600000000001,
"taskDurationMs": 5599.052000000001,
"heapDeltaBytes": 14846184,
"heapUsedBytes": 287520772,
"domNodes": -3330,
"jsHeapTotalBytes": 34856960,
"scriptDurationMs": 94.125,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.38522727272727,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5567.598999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.13100000000001,
"layouts": 20,
"layoutDurationMs": 19.683999999999994,
"taskDurationMs": 5431.628,
"heapDeltaBytes": -27707512,
"heapUsedBytes": 272862652,
"domNodes": -3330,
"jsHeapTotalBytes": 34856960,
"scriptDurationMs": 78.392,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.1757225433526,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7815.045999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7407.8669999999975,
"heapDeltaBytes": 6925884,
"heapUsedBytes": 291537276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.83999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.496271186440683,
"p95FrameDurationMs": 50.00000000000182
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7317.054999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7024.436,
"heapDeltaBytes": 19779928,
"heapUsedBytes": 287015176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 84.727,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.551342281879194,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "workflow-execution",
"durationMs": 457.90400000004183,
"styleRecalcs": 17,
"styleRecalcDurationMs": 12.758,
"layouts": 13,
"layoutDurationMs": 4.36,
"taskDurationMs": 110.22200000000001,
"heapDeltaBytes": 7084404,
"heapUsedBytes": 79383592,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.047000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 92.03800000000228,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.36,
"layouts": 6,
"layoutDurationMs": 2.0410000000000004,
"taskDurationMs": 64.09599999999999,
"heapDeltaBytes": -10769104,
"heapUsedBytes": 68648496,
"domNodes": 95,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 6.3260000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 189.44600000008904,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.034,
"layouts": 76,
"layoutDurationMs": 10.046,
"taskDurationMs": 156.514,
"heapDeltaBytes": 8738096,
"heapUsedBytes": 93490880,
"domNodes": 4,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 67.37700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658333333333342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 205.61799999995856,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.053,
"layouts": 76,
"layoutDurationMs": 9.962,
"taskDurationMs": 169.64000000000001,
"heapDeltaBytes": -20170708,
"heapUsedBytes": 71964376,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 71.404,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66153846153849,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 237.1019999999362,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.466,
"layouts": 76,
"layoutDurationMs": 9.567,
"taskDurationMs": 191.3,
"heapDeltaBytes": 25709252,
"heapUsedBytes": 140411176,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 61.642999999999994,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 250.70000000005166,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.486,
"layouts": 76,
"layoutDurationMs": 10.273,
"taskDurationMs": 207.147,
"heapDeltaBytes": -7464056,
"heapUsedBytes": 110714588,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 66.94800000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2286 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ac4c439bbced9d42641b91f1e770fc714ca70de4
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #22251 +/- ##
=============================================
Coverage ? 84.09%
=============================================
Files ? 3016
Lines ? 160275
Branches ? 38416
=============================================
Hits ? 134780
Misses ? 25105
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff matches the merged original exactly. Approving.
Backport of #22238 to
cloud/1.57Automatically created by backport workflow.