Repository navigation
[backport core/1.57] fix(agent): send a tour-held first message when the tour ends in another tab - #22250
Conversation
…her tab (#22238) ## Summary A new user's first message waits behind the intro tour (#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once #21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from #21532); ported to the release lines in #22225, #22232, #22233, #22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T15:42:10.422Z",
"gitSha": "882d5e39d57858905394836a4ab1837da1c84285",
"branch": "backport-22238-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.6829999999622,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0419999999999994,
"layouts": 11,
"layoutDurationMs": 3.3550000000000004,
"taskDurationMs": 517.491,
"heapDeltaBytes": -915332,
"heapUsedBytes": 74130384,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.992999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.9880000000549,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3159999999999994,
"layouts": 9,
"layoutDurationMs": 2.283,
"taskDurationMs": 498.479,
"heapDeltaBytes": -907656,
"heapUsedBytes": 74672196,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.277000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.7020000000043,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.709,
"layouts": 9,
"layoutDurationMs": 2.321,
"taskDurationMs": 847.804,
"heapDeltaBytes": -7233604,
"heapUsedBytes": 68633420,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 151.6,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.0540000000383,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.015999999999998,
"layouts": 8,
"layoutDurationMs": 2.112,
"taskDurationMs": 869.656,
"heapDeltaBytes": 15089372,
"heapUsedBytes": 82013520,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 159.768,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3159999999875,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.590000000000001,
"layouts": 11,
"layoutDurationMs": 3.055,
"taskDurationMs": 399.82300000000004,
"heapDeltaBytes": 18299852,
"heapUsedBytes": 85052768,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.077000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.1639999999616,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.515,
"layouts": 11,
"layoutDurationMs": 2.7319999999999998,
"taskDurationMs": 323.309,
"heapDeltaBytes": 18993524,
"heapUsedBytes": 85509632,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.668,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 599.5600000000536,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.595999999999999,
"layouts": 8,
"layoutDurationMs": 2.3840000000000003,
"taskDurationMs": 430.16800000000006,
"heapDeltaBytes": 26481944,
"heapUsedBytes": 91874088,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 169.124,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 643.5159999999769,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7310000000000008,
"layouts": 9,
"layoutDurationMs": 2.7099999999999995,
"taskDurationMs": 480.934,
"heapDeltaBytes": 7220236,
"heapUsedBytes": 82135080,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 162.758,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.6799999999776,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 902.8170000000001,
"heapDeltaBytes": -11625892,
"heapUsedBytes": 81689432,
"domNodes": -212,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 69.38600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.01578947368422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.7170000000488,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 848.642,
"heapDeltaBytes": -11829560,
"heapUsedBytes": 80895208,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 65.22200000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 516,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.0119999999929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.81600000000003,
"heapDeltaBytes": -4379928,
"heapUsedBytes": 76776956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 150.99400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.8309999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.59100000000024,
"heapDeltaBytes": -4004188,
"heapUsedBytes": 75896636,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 137.567,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10156.16399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9149.748,
"heapDeltaBytes": -5854756,
"heapUsedBytes": 88836408,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7307.433,
"eventListeners": -68,
"totalBlockingTimeMs": 501,
"frameDurationMs": 29.334104046242775,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8930.998999999929,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05699999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7971.557,
"heapDeltaBytes": -24243640,
"heapUsedBytes": 75210176,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 6624.954000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 184,
"frameDurationMs": 28.395859872611464,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9402.787999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0439999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8685.057,
"heapDeltaBytes": -16054376,
"heapUsedBytes": 72033564,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6898.722000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 279,
"frameDurationMs": 29.98853503184714,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9231.031999999914,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0510000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8538.430000000002,
"heapDeltaBytes": -6353648,
"heapUsedBytes": 90055188,
"domNodes": -258,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 6802.240000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 212,
"frameDurationMs": 29.730000000000004,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "large-combo-open",
"durationMs": 209.04200000001083,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.294999999999998,
"layouts": 11,
"layoutDurationMs": 3.236,
"taskDurationMs": 152.546,
"heapDeltaBytes": -8108520,
"heapUsedBytes": 79737520,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.414,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 218.85100000008606,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.739999999999997,
"layouts": 11,
"layoutDurationMs": 3.2259999999999995,
"taskDurationMs": 162.49,
"heapDeltaBytes": -8401840,
"heapUsedBytes": 79742280,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.645999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2040.9099999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.364999999999999,
"layouts": 8,
"layoutDurationMs": 2.2729999999999997,
"taskDurationMs": 639.859,
"heapDeltaBytes": -27078400,
"heapUsedBytes": 70576268,
"domNodes": -278,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 31.360000000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.08999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2180000000000004,
"layouts": 9,
"layoutDurationMs": 2.121,
"taskDurationMs": 626.958,
"heapDeltaBytes": -2139352,
"heapUsedBytes": 77321168,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.949999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2294.8650000000157,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.853,
"layouts": 8,
"layoutDurationMs": 2.4080000000000004,
"taskDurationMs": 1621.174,
"heapDeltaBytes": -9203968,
"heapUsedBytes": 71154764,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 770.802,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985512,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2431.7069999999603,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.859000000000001,
"layouts": 7,
"layoutDurationMs": 2.034,
"taskDurationMs": 1702.5620000000001,
"heapDeltaBytes": -8947344,
"heapUsedBytes": 68335304,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 819.407,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78068965517242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3667.1629999999595,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.127000000000002,
"layouts": 63,
"layoutDurationMs": 11.445,
"taskDurationMs": 1785.5820000000003,
"heapDeltaBytes": -9832276,
"heapUsedBytes": 71975904,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 779.582,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74200913242009,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3584.9379999999655,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.760999999999999,
"layouts": 63,
"layoutDurationMs": 11.112,
"taskDurationMs": 1738.6899999999998,
"heapDeltaBytes": -14835932,
"heapUsedBytes": 67648148,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 757.787,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3006.619999999998,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.356,
"layouts": 5,
"layoutDurationMs": 1.481,
"taskDurationMs": 1923.2369999999999,
"heapDeltaBytes": 11129976,
"heapUsedBytes": 94524096,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 960.609,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758888888888887,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3181.436000000076,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.222999999999999,
"layouts": 6,
"layoutDurationMs": 1.542,
"taskDurationMs": 2046.0569999999998,
"heapDeltaBytes": -6754148,
"heapUsedBytes": 77628224,
"domNodes": 0,
"jsHeapTotalBytes": 8216576,
"scriptDurationMs": 1057.027,
"eventListeners": 182,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.112299465240643,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.8500000000108,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.298999999999999,
"layouts": 7,
"layoutDurationMs": 2.1200000000000006,
"taskDurationMs": 638.478,
"heapDeltaBytes": -23460564,
"heapUsedBytes": 75001004,
"domNodes": -258,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 34.20399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.5789999999797,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5469999999999988,
"layouts": 7,
"layoutDurationMs": 1.767,
"taskDurationMs": 613.4529999999999,
"heapDeltaBytes": -2693552,
"heapUsedBytes": 75833416,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.915000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.5090000000241,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.227,
"layouts": 9,
"layoutDurationMs": 2.756,
"taskDurationMs": 471.33900000000006,
"heapDeltaBytes": -1066608,
"heapUsedBytes": 75857092,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 150.26,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.5630000000228,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.894,
"layouts": 11,
"layoutDurationMs": 3.0359999999999996,
"taskDurationMs": 443.63699999999994,
"heapDeltaBytes": -1116400,
"heapUsedBytes": 76348012,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 150.858,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.249999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.490999999999999,
"layouts": 10,
"layoutDurationMs": 2.491,
"taskDurationMs": 498.72600000000006,
"heapDeltaBytes": -255592,
"heapUsedBytes": 77227440,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.451,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.9849999999624,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4279999999999995,
"layouts": 8,
"layoutDurationMs": 2.1670000000000007,
"taskDurationMs": 500.17599999999993,
"heapDeltaBytes": 22081048,
"heapUsedBytes": 89493524,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.543,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.2110000000152,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.365,
"layouts": 9,
"layoutDurationMs": 2.2,
"taskDurationMs": 985.228,
"heapDeltaBytes": -11405400,
"heapUsedBytes": 66032416,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 103.69999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542372,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1962.7450000000408,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.429,
"layouts": 9,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 866.6259999999999,
"heapDeltaBytes": 11661032,
"heapUsedBytes": 79096108,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 103.364,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4689999999882,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.882999999999996,
"layouts": 5,
"layoutDurationMs": 15.665999999999999,
"taskDurationMs": 1089.532,
"heapDeltaBytes": 5174540,
"heapUsedBytes": 97403672,
"domNodes": 15953,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 30.299000000000007,
"eventListeners": 3244,
"totalBlockingTimeMs": 149,
"frameDurationMs": 19.332000000000008,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.648000000017,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.859,
"layouts": 7,
"layoutDurationMs": 1.8380000000000003,
"taskDurationMs": 4942.339000000001,
"heapDeltaBytes": -7843712,
"heapUsedBytes": 70786268,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2582.8569999999995,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733400809716603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8504.763999999908,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.456,
"layouts": 9,
"layoutDurationMs": 2.184,
"taskDurationMs": 5650.087,
"heapDeltaBytes": -29683848,
"heapUsedBytes": 67761676,
"domNodes": -278,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 2575.23,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69862745098039,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23655.646000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23165.477,
"heapDeltaBytes": -47832024,
"heapUsedBytes": 253429124,
"domNodes": -3330,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 378.928,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.12886956521739,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23341.095999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22908.087000000003,
"heapDeltaBytes": -784012,
"heapUsedBytes": 281761088,
"domNodes": -3330,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 337.044,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.369503546099295,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28249.18200000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27966.249000000003,
"heapDeltaBytes": -23186204,
"heapUsedBytes": 277792260,
"domNodes": -3330,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 909.4069999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 57,
"frameDurationMs": 53.87824427480916,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28353.760999999962,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.79800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27866.386,
"heapDeltaBytes": -34699304,
"heapUsedBytes": 256302736,
"domNodes": -3330,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 875.183,
"eventListeners": -651,
"totalBlockingTimeMs": 77,
"frameDurationMs": 53.48849056603774,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 6335.248999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.10500000000002,
"layouts": 20,
"layoutDurationMs": 29.68699999999999,
"taskDurationMs": 6203.527999999999,
"heapDeltaBytes": -26386004,
"heapUsedBytes": 264831068,
"domNodes": -2999,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 102.718,
"eventListeners": -588,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.57921348314607,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8570.109000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.78300000000004,
"layouts": 20,
"layoutDurationMs": 23.403000000000006,
"taskDurationMs": 8424.875,
"heapDeltaBytes": -3604580,
"heapUsedBytes": 269303992,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 157.28699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.94972067039107,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11569.604999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11361.466999999999,
"heapDeltaBytes": -15730464,
"heapUsedBytes": 243915880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.551,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.455913978494614,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11915.56300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11618.565,
"heapDeltaBytes": -185904,
"heapUsedBytes": 248298972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.23699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.42883211678832,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 135.13900000003787,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.346000000000002,
"layouts": 7,
"layoutDurationMs": 3.084,
"taskDurationMs": 111.654,
"heapDeltaBytes": -15297452,
"heapUsedBytes": 67960176,
"domNodes": 123,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.183,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "workflow-execution",
"durationMs": 128.41800000001058,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.685000000000002,
"layouts": 9,
"layoutDurationMs": 3.586,
"taskDurationMs": 86.535,
"heapDeltaBytes": 4472704,
"heapUsedBytes": 77537676,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.385999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 498.3999999999469,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.071,
"layouts": 76,
"layoutDurationMs": 16.003,
"taskDurationMs": 452.572,
"heapDeltaBytes": -13739868,
"heapUsedBytes": 82008160,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 215.255,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 483.6649999999736,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0859999999999999,
"layouts": 76,
"layoutDurationMs": 16.729999999999997,
"taskDurationMs": 438.313,
"heapDeltaBytes": -13840208,
"heapUsedBytes": 81591880,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 207.306,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 601.519000000053,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.837,
"layouts": 76,
"layoutDurationMs": 16.657999999999998,
"taskDurationMs": 559.102,
"heapDeltaBytes": 1060208,
"heapUsedBytes": 128117036,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 227.47099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 595.1680000000579,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.153,
"layouts": 76,
"layoutDurationMs": 16.52,
"taskDurationMs": 566.963,
"heapDeltaBytes": 970480,
"heapUsedBytes": 117652280,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 227.464,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2285 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7e68507dc3085f98d480e27e94a7902e5b6b57c7
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #22250 +/- ##
=============================================
- Coverage 84.04% 84.04% -0.01%
=============================================
Files 3000 3000
Lines 159488 159495 +7
Branches 38575 40774 +2199
=============================================
- Hits 134048 134045 -3
- Misses 25050 25060 +10
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff matches the merged original exactly. Approving.
Backport of #22238 to
core/1.57Automatically created by backport workflow.