Repository navigation
[backport cloud/1.58] feat(agent): report a warning when a stale canvas draft is withheld - #22240
Conversation
…22224) ## ELI5 When the agent's connection drops, the canvas stops sending its copy of the workflow with the next message so an old copy cannot overwrite newer values. This adds one warning each time that happens, so we can see in Sentry that the safeguard is working for real users. ## Summary - `AgentPanelRoot.targetWorkflowDraft` reports `agent_canvas_draft_withheld_stale` (level `warning`, one fingerprint) when the stale-canvas gate from #21268 withholds the draft. - Tags follow the agent taxonomy: `failure_kind: bad_state`, `feature_area: agent`, `operation: send`, `outcome: withheld`; context carries only the workflow id. - No behaviour change: the draft is withheld exactly as before. Relates to PM-2118 (https://linear.app/comfyorg/issue/PM-2118). A scheduled read-only check compares this warning and the lost-edit errors across releases with and without the fix. ## Testing - Red first: `withholds a bound canvas after its subscribed socket drops` now also expects exactly one warning; it failed before the change. - New: `reports nothing when a connected canvas sends its draft`. - `AgentPanelRoot.test.ts`: 555 passed. `pnpm typecheck` and `oxlint --type-aware` on the changed files are clean. <details><summary>Full context for agent readers</summary> - Volume: one event per send while the canvas is stale. Sends are user-paced, so this is bounded by message count; the shared fingerprint keeps it to one Sentry issue. - Not under `crdt/`, so outside the informal freeze. - Backport labels: core/1.58 and cloud/1.58 so the 1.58.x builds that already carry the gate also report it. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T13:24:47.611Z",
"gitSha": "43129f589ab392f8cbd5a761597c3284b91b96a2",
"branch": "backport-22224-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.467000000026,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0580000000000007,
"layouts": 8,
"layoutDurationMs": 2.236,
"taskDurationMs": 572.1099999999999,
"heapDeltaBytes": -3451908,
"heapUsedBytes": 84806956,
"domNodes": -200,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 9.090000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.194000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.457,
"layouts": 10,
"layoutDurationMs": 2.5610000000000004,
"taskDurationMs": 576.5939999999999,
"heapDeltaBytes": -21018660,
"heapUsedBytes": 81417120,
"domNodes": -200,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 9.169,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.3559999999452,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.299,
"layouts": 9,
"layoutDurationMs": 2.2030000000000003,
"taskDurationMs": 781.202,
"heapDeltaBytes": 839056,
"heapUsedBytes": 89138968,
"domNodes": -204,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 151.006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.4490000000606,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.696,
"layouts": 9,
"layoutDurationMs": 2.5090000000000003,
"taskDurationMs": 761.3259999999999,
"heapDeltaBytes": 291332,
"heapUsedBytes": 89159256,
"domNodes": -201,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 144.735,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9600000000437,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.07,
"layouts": 12,
"layoutDurationMs": 2.8139999999999996,
"taskDurationMs": 282.665,
"heapDeltaBytes": 21434552,
"heapUsedBytes": 109305928,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.142,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.742000000073,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.1049999999999995,
"layouts": 12,
"layoutDurationMs": 2.9959999999999996,
"taskDurationMs": 288.83599999999996,
"heapDeltaBytes": 22429524,
"heapUsedBytes": 109508072,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.58,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 692.7650000000085,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5719999999999996,
"layouts": 9,
"layoutDurationMs": 2.157,
"taskDurationMs": 489.447,
"heapDeltaBytes": 818024,
"heapUsedBytes": 92131936,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 166.332,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 722.0029999998587,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.603,
"layouts": 9,
"layoutDurationMs": 2.405,
"taskDurationMs": 489.70899999999995,
"heapDeltaBytes": 750292,
"heapUsedBytes": 88560388,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 167.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1185.9739999999874,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 833.949,
"heapDeltaBytes": -13620412,
"heapUsedBytes": 102492584,
"domNodes": -210,
"jsHeapTotalBytes": 15278080,
"scriptDurationMs": 58.46900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 499,
"frameDurationMs": 31.978378378378373,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.7089999999134,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.48,
"heapDeltaBytes": -10059316,
"heapUsedBytes": 102272488,
"domNodes": -230,
"jsHeapTotalBytes": 13443072,
"scriptDurationMs": 62.666,
"eventListeners": -168,
"totalBlockingTimeMs": 514,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.61600000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.2730000000004,
"heapDeltaBytes": -2953908,
"heapUsedBytes": 97421216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.44100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 892.031999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.1779999999993,
"heapDeltaBytes": -3227096,
"heapUsedBytes": 98448288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.01500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.717142857142868,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9866.745000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8893.575,
"heapDeltaBytes": 34954332,
"heapUsedBytes": 139930504,
"domNodes": -296,
"jsHeapTotalBytes": 28192768,
"scriptDurationMs": 7229.920000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 518,
"frameDurationMs": 30.357846153846157,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9946.108999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9142.414999999999,
"heapDeltaBytes": 49451116,
"heapUsedBytes": 176483732,
"domNodes": -296,
"jsHeapTotalBytes": 57552896,
"scriptDurationMs": 7170.402,
"eventListeners": -130,
"totalBlockingTimeMs": 344,
"frameDurationMs": 30.520245398773003,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9154.858999999988,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3100000000000004,
"layouts": 1,
"layoutDurationMs": 0.30500000000000016,
"taskDurationMs": 8395.797,
"heapDeltaBytes": 36154016,
"heapUsedBytes": 140030396,
"domNodes": -276,
"jsHeapTotalBytes": 27144192,
"scriptDurationMs": 6820.372,
"eventListeners": -130,
"totalBlockingTimeMs": 268,
"frameDurationMs": 29.610355987055012,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9603.001999999946,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0449999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8789.1,
"heapDeltaBytes": 2065880,
"heapUsedBytes": 119738716,
"domNodes": -277,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 7053.669,
"eventListeners": -130,
"totalBlockingTimeMs": 151,
"frameDurationMs": 28.43620178041543,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 203.7350000000515,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.351999999999999,
"layouts": 10,
"layoutDurationMs": 2.813,
"taskDurationMs": 164.19199999999998,
"heapDeltaBytes": 15499120,
"heapUsedBytes": 117989588,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.137000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 264.98900000001413,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.818,
"layouts": 11,
"layoutDurationMs": 3.237,
"taskDurationMs": 212.453,
"heapDeltaBytes": 15472872,
"heapUsedBytes": 118069808,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 9.088000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 22.225000000000062,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2054.552000000058,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0310000000000006,
"layouts": 8,
"layoutDurationMs": 1.762,
"taskDurationMs": 652.6260000000001,
"heapDeltaBytes": 617512,
"heapUsedBytes": 102454472,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 31.147999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.544999999962,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.706,
"layouts": 7,
"layoutDurationMs": 1.7859999999999998,
"taskDurationMs": 646.3140000000001,
"heapDeltaBytes": 253292,
"heapUsedBytes": 102058660,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 34.247,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2321.4440000000423,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.255,
"layouts": 8,
"layoutDurationMs": 2.0730000000000004,
"taskDurationMs": 1626.2810000000002,
"heapDeltaBytes": -31837436,
"heapUsedBytes": 88903996,
"domNodes": -296,
"jsHeapTotalBytes": 655360,
"scriptDurationMs": 756.572,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.773000000141,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.965,
"layouts": 7,
"layoutDurationMs": 1.6699999999999997,
"taskDurationMs": 1630.579,
"heapDeltaBytes": -32924492,
"heapUsedBytes": 87691788,
"domNodes": -296,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 756.07,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3484.8970000000463,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.129,
"layouts": 64,
"layoutDurationMs": 11.042,
"taskDurationMs": 1556.645,
"heapDeltaBytes": 6255892,
"heapUsedBytes": 111190272,
"domNodes": -272,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 763.367,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746153846153845,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3664.8569999999836,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.681,
"layouts": 65,
"layoutDurationMs": 11.232,
"taskDurationMs": 1766.8749999999998,
"heapDeltaBytes": -13360540,
"heapUsedBytes": 95711692,
"domNodes": -273,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 766.8670000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742465753424653,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2708.851999999979,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.8309999999999995,
"layouts": 6,
"layoutDurationMs": 1.6439999999999997,
"taskDurationMs": 1717.7759999999998,
"heapDeltaBytes": -8968984,
"heapUsedBytes": 101531496,
"domNodes": 0,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 951.2389999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.874375000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2961.43700000016,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.235,
"layouts": 4,
"layoutDurationMs": 0.9789999999999999,
"taskDurationMs": 1911.5500000000002,
"heapDeltaBytes": 22382824,
"heapUsedBytes": 128484108,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 933.334,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.1059999998997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5509999999999995,
"layouts": 6,
"layoutDurationMs": 1.646,
"taskDurationMs": 642.8330000000001,
"heapDeltaBytes": -13769396,
"heapUsedBytes": 94265640,
"domNodes": -296,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 31.854999999999993,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.6809999998877,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7409999999999994,
"layouts": 7,
"layoutDurationMs": 1.778,
"taskDurationMs": 479.28399999999993,
"heapDeltaBytes": 1048812,
"heapUsedBytes": 109288456,
"domNodes": -276,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 32.24999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.003999999999,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.881999999999999,
"layouts": 10,
"layoutDurationMs": 2.2880000000000007,
"taskDurationMs": 410.331,
"heapDeltaBytes": 22429916,
"heapUsedBytes": 112519476,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 145.067,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.2800000000316,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.1579999999999995,
"layouts": 9,
"layoutDurationMs": 2.4679999999999995,
"taskDurationMs": 439.308,
"heapDeltaBytes": 1938976,
"heapUsedBytes": 101369960,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 144.376,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.2160000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3049999999999997,
"layouts": 9,
"layoutDurationMs": 2.086,
"taskDurationMs": 422.92900000000003,
"heapDeltaBytes": -565428,
"heapUsedBytes": 89537408,
"domNodes": -218,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 8.148,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.6370000001843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4659999999999993,
"layouts": 9,
"layoutDurationMs": 2.2019999999999995,
"taskDurationMs": 566.604,
"heapDeltaBytes": -21500580,
"heapUsedBytes": 83427036,
"domNodes": -218,
"jsHeapTotalBytes": -2002944,
"scriptDurationMs": 8.016000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.1989999999614,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.543999999999999,
"layouts": 10,
"layoutDurationMs": 2.4099999999999993,
"taskDurationMs": 854.846,
"heapDeltaBytes": -3381400,
"heapUsedBytes": 86402768,
"domNodes": -210,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 102.456,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.3650000001107,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.626,
"layouts": 10,
"layoutDurationMs": 2.545,
"taskDurationMs": 893.739,
"heapDeltaBytes": -3847232,
"heapUsedBytes": 85987448,
"domNodes": -210,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 101.232,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.8589999999976,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.79,
"layouts": 5,
"layoutDurationMs": 15.626999999999995,
"taskDurationMs": 1032.695,
"heapDeltaBytes": 37967600,
"heapUsedBytes": 137561680,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 30.49299999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.90694444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8240.516999999954,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.255999999999997,
"layouts": 9,
"layoutDurationMs": 2.2109999999999994,
"taskDurationMs": 4948.758,
"heapDeltaBytes": 2100432,
"heapUsedBytes": 108668144,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 2551.984,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8971.477999999934,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.229,
"layouts": 8,
"layoutDurationMs": 2.1989999999999994,
"taskDurationMs": 6014.419,
"heapDeltaBytes": 69538380,
"heapUsedBytes": 175865284,
"domNodes": -296,
"jsHeapTotalBytes": 65347584,
"scriptDurationMs": 2686.687,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.728171641791047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16660.663,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15815.877,
"heapDeltaBytes": -7708232,
"heapUsedBytes": 303663808,
"domNodes": -3344,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 283.879,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.143630017452004,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16480.76399999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15651.649999999998,
"heapDeltaBytes": -59641956,
"heapUsedBytes": 274199284,
"domNodes": -3373,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 245.44,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.615625000000005,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 20106.09599999998,
"styleRecalcs": 157,
"styleRecalcDurationMs": 17.768000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19795.782,
"heapDeltaBytes": -15865192,
"heapUsedBytes": 289015316,
"domNodes": -3344,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 853.643,
"eventListeners": -651,
"totalBlockingTimeMs": 39,
"frameDurationMs": 37.851412429378534,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28743.351000000075,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28454.841,
"heapDeltaBytes": 289150436,
"heapUsedBytes": 648180260,
"domNodes": -3344,
"jsHeapTotalBytes": 288538624,
"scriptDurationMs": 923.6320000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 28,
"frameDurationMs": 54.24301886792452,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8492.130999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.03300000000002,
"layouts": 20,
"layoutDurationMs": 30.605999999999995,
"taskDurationMs": 8371.417,
"heapDeltaBytes": -63524360,
"heapUsedBytes": 261584424,
"domNodes": -3344,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 137.82699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.12777777777779,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6497.141000000056,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.19200000000002,
"layouts": 20,
"layoutDurationMs": 28.213000000000015,
"taskDurationMs": 6388.155000000001,
"heapDeltaBytes": -41918068,
"heapUsedBytes": 283139540,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 115.213,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.16264367816092,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11387.854999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11088.410999999998,
"heapDeltaBytes": 19213144,
"heapUsedBytes": 290199156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.366,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.386851211072674,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8380.233999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8148.864,
"heapDeltaBytes": -15074928,
"heapUsedBytes": 274315840,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.74699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.987096774193553,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 138.63900000001195,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.019999999999998,
"layouts": 11,
"layoutDurationMs": 4.787000000000001,
"taskDurationMs": 111.87499999999999,
"heapDeltaBytes": 4981040,
"heapUsedBytes": 106491296,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.091,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 127.41699999992306,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.848000000000003,
"layouts": 9,
"layoutDurationMs": 3.157,
"taskDurationMs": 92.70500000000001,
"heapDeltaBytes": -19898132,
"heapUsedBytes": 92652936,
"domNodes": 94,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.529,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 527.5199999998677,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.816,
"layouts": 76,
"layoutDurationMs": 16.442999999999998,
"taskDurationMs": 475.315,
"heapDeltaBytes": -13633084,
"heapUsedBytes": 81281796,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 225.92200000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 504.07300000006217,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.749,
"layouts": 76,
"layoutDurationMs": 16.578,
"taskDurationMs": 445.83299999999997,
"heapDeltaBytes": 12244040,
"heapUsedBytes": 82162312,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 209.73,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 706.6310000000158,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.221,
"layouts": 76,
"layoutDurationMs": 16.105,
"taskDurationMs": 644.898,
"heapDeltaBytes": 1805012,
"heapUsedBytes": 118864360,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 260.55899999999997,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 605.9159999999792,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.544,
"layouts": 76,
"layoutDurationMs": 15.872,
"taskDurationMs": 563.1080000000001,
"heapDeltaBytes": 880684,
"heapUsedBytes": 118598412,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 223.22400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13055555555555,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2984 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d7e09181a2321142ce7883b10a2cde6573cade58
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (132)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22240 +/- ##
=============================================
Coverage ? 84.51%
=============================================
Files ? 3102
Lines ? 163053
Branches ? 38975
=============================================
Hits ? 137805
Misses ? 24857
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Program backport lane |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head f1389c05fd16443034b05a64afeff57d71b93f6c under the standing Agent release-backport grant. Source #22224 is merged and approved. The normalized two-file patch is identical to the source squash after removing only fingerprint and its expectation, which is required because cloud/1.58 ReportErrorOptions does not expose that newer main-only field. The warning behavior, tags, context, stale-canvas gate, and positive/negative tests are unchanged. Target refresh cleanly incorporated cloud/1.58 tip d7e09181a2321142ce7883b10a2cde6573cade58; local AgentPanelRoot suite passed 482/482; hosted exact-head checks are 90 success / 27 skipped with no adverse result; no review threads or human objections.
Backport of #22224 to
cloud/1.58Automatically created by backport workflow.