Repository navigation
[backport core/1.58] feat(agent): report a warning when a stale canvas draft is withheld - #22239
Conversation
…22224) ## ELI5 When the agent's connection drops, the canvas stops sending its copy of the workflow with the next message so an old copy cannot overwrite newer values. This adds one warning each time that happens, so we can see in Sentry that the safeguard is working for real users. ## Summary - `AgentPanelRoot.targetWorkflowDraft` reports `agent_canvas_draft_withheld_stale` (level `warning`, one fingerprint) when the stale-canvas gate from #21268 withholds the draft. - Tags follow the agent taxonomy: `failure_kind: bad_state`, `feature_area: agent`, `operation: send`, `outcome: withheld`; context carries only the workflow id. - No behaviour change: the draft is withheld exactly as before. Relates to PM-2118 (https://linear.app/comfyorg/issue/PM-2118). A scheduled read-only check compares this warning and the lost-edit errors across releases with and without the fix. ## Testing - Red first: `withholds a bound canvas after its subscribed socket drops` now also expects exactly one warning; it failed before the change. - New: `reports nothing when a connected canvas sends its draft`. - `AgentPanelRoot.test.ts`: 555 passed. `pnpm typecheck` and `oxlint --type-aware` on the changed files are clean. <details><summary>Full context for agent readers</summary> - Volume: one event per send while the canvas is stale. Sends are user-paced, so this is bounded by message count; the shared fingerprint keeps it to one Sentry issue. - Not under `crdt/`, so outside the informal freeze. - Backport labels: core/1.58 and cloud/1.58 so the 1.58.x builds that already carry the gate also report it. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T12:10:33.428Z",
"gitSha": "357ac4233a920b4c64cd1a0e487c2edbaaac5bae",
"branch": "backport-22224-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.1730000000284,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.614,
"layouts": 9,
"layoutDurationMs": 2.8310000000000004,
"taskDurationMs": 428.678,
"heapDeltaBytes": 224468,
"heapUsedBytes": 90656280,
"domNodes": -206,
"jsHeapTotalBytes": 589824,
"scriptDurationMs": 9.328,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2038.7719999999945,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9610000000000003,
"layouts": 9,
"layoutDurationMs": 3.0039999999999996,
"taskDurationMs": 416.18999999999994,
"heapDeltaBytes": 490276,
"heapUsedBytes": 90897400,
"domNodes": -200,
"jsHeapTotalBytes": 1114112,
"scriptDurationMs": 9.104000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.3179999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.442999999999998,
"layouts": 9,
"layoutDurationMs": 2.6049999999999995,
"taskDurationMs": 886.304,
"heapDeltaBytes": -1506932,
"heapUsedBytes": 91059500,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 162.709,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.3819999999887,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.864,
"layouts": 8,
"layoutDurationMs": 2.3409999999999993,
"taskDurationMs": 940.6589999999999,
"heapDeltaBytes": -938680,
"heapUsedBytes": 89873404,
"domNodes": -200,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 169.833,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4549999999872,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.118999999999999,
"layouts": 12,
"layoutDurationMs": 3.01,
"taskDurationMs": 331.555,
"heapDeltaBytes": 32067020,
"heapUsedBytes": 132173576,
"domNodes": 47,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 12.323,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.8679999999677,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.312,
"layouts": 12,
"layoutDurationMs": 3.286,
"taskDurationMs": 292.36400000000003,
"heapDeltaBytes": -205988,
"heapUsedBytes": 90814684,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.356000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 714.5389999999452,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4050000000000002,
"layouts": 10,
"layoutDurationMs": 3.0869999999999993,
"taskDurationMs": 536.954,
"heapDeltaBytes": 4589820,
"heapUsedBytes": 94860176,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 177.077,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 630.1949999999579,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0920000000000005,
"layouts": 9,
"layoutDurationMs": 3.4000000000000004,
"taskDurationMs": 448.11100000000005,
"heapDeltaBytes": 4177084,
"heapUsedBytes": 94513748,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.26200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.4639999999736,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.281,
"heapDeltaBytes": -16009108,
"heapUsedBytes": 101963496,
"domNodes": -230,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 77.88199999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 538,
"frameDurationMs": 32.88378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1217.5929999999653,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.316,
"heapDeltaBytes": -3500260,
"heapUsedBytes": 102526788,
"domNodes": -230,
"jsHeapTotalBytes": 10375168,
"scriptDurationMs": 68.962,
"eventListeners": -168,
"totalBlockingTimeMs": 542,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.3059999999609,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.96899999999965,
"heapDeltaBytes": -4449912,
"heapUsedBytes": 97817068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.13699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.5240000000495,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.47299999999996,
"heapDeltaBytes": -3966972,
"heapUsedBytes": 97711804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.565,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9669.906999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8788.238,
"heapDeltaBytes": 19416528,
"heapUsedBytes": 133252132,
"domNodes": -276,
"jsHeapTotalBytes": 21114880,
"scriptDurationMs": 7230.744,
"eventListeners": -130,
"totalBlockingTimeMs": 927,
"frameDurationMs": 32.114285714285714,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11280.95300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10481.653,
"heapDeltaBytes": 55873532,
"heapUsedBytes": 171242428,
"domNodes": -276,
"jsHeapTotalBytes": 64368640,
"scriptDurationMs": 8537.918000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1539,
"frameDurationMs": 31.966666666666665,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9438.23199999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04799999999999943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8674.894,
"heapDeltaBytes": 15311508,
"heapUsedBytes": 124416616,
"domNodes": -297,
"jsHeapTotalBytes": 25231360,
"scriptDurationMs": 7200.626,
"eventListeners": -130,
"totalBlockingTimeMs": 816,
"frameDurationMs": 32.194539249146764,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9825.761000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9051.114,
"heapDeltaBytes": 57744280,
"heapUsedBytes": 146188464,
"domNodes": -276,
"jsHeapTotalBytes": 37486592,
"scriptDurationMs": 7213.828,
"eventListeners": 0,
"totalBlockingTimeMs": 578,
"frameDurationMs": 31.719032258064516,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 242.94600000001765,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.815,
"layouts": 10,
"layoutDurationMs": 3.0260000000000002,
"taskDurationMs": 210.519,
"heapDeltaBytes": 13309904,
"heapUsedBytes": 118685588,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.158999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.81666666666668,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 237.67900000007103,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.867999999999999,
"layouts": 10,
"layoutDurationMs": 2.938,
"taskDurationMs": 191.27799999999996,
"heapDeltaBytes": 13207076,
"heapUsedBytes": 120674308,
"domNodes": 917,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.197,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.216666666666697,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2042.9489999999646,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.994000000000001,
"layouts": 9,
"layoutDurationMs": 2.7659999999999996,
"taskDurationMs": 476.3329999999999,
"heapDeltaBytes": 177920,
"heapUsedBytes": 110277260,
"domNodes": -297,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 31.966,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.0500000000175,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2929999999999997,
"layouts": 8,
"layoutDurationMs": 1.825,
"taskDurationMs": 486.506,
"heapDeltaBytes": 302340,
"heapUsedBytes": 110834192,
"domNodes": -297,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 36.24699999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2788.665999999978,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.087,
"layouts": 7,
"layoutDurationMs": 2.269,
"taskDurationMs": 1807.058,
"heapDeltaBytes": -1154152,
"heapUsedBytes": 110156804,
"domNodes": -276,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 886.4700000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765868263473056,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2262.395999999967,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.043,
"layouts": 7,
"layoutDurationMs": 1.6420000000000001,
"taskDurationMs": 1548.522,
"heapDeltaBytes": 2246864,
"heapUsedBytes": 113350624,
"domNodes": -276,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 836.617,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617647058823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3533.8009999999827,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.667,
"layouts": 66,
"layoutDurationMs": 11.268,
"taskDurationMs": 1648.203,
"heapDeltaBytes": -36723688,
"heapUsedBytes": 86826568,
"domNodes": -272,
"jsHeapTotalBytes": 311296,
"scriptDurationMs": 779.7620000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744549763033177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3577.5409999999965,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.551000000000002,
"layouts": 66,
"layoutDurationMs": 11.052,
"taskDurationMs": 1603.6299999999999,
"heapDeltaBytes": -24678632,
"heapUsedBytes": 88068296,
"domNodes": -272,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 771.697,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74460093896714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2674.7589999999946,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.492999999999999,
"layouts": 5,
"layoutDurationMs": 1.5,
"taskDurationMs": 1747.283,
"heapDeltaBytes": -11805348,
"heapUsedBytes": 102535760,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 940.3770000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.984713375796176,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2774.501999999984,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.425999999999999,
"layouts": 6,
"layoutDurationMs": 1.346,
"taskDurationMs": 1736.5389999999998,
"heapDeltaBytes": -11761756,
"heapUsedBytes": 102627148,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 950.007,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86951219512195,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.286999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2510000000000003,
"layouts": 7,
"layoutDurationMs": 2.072,
"taskDurationMs": 492.997,
"heapDeltaBytes": -287140,
"heapUsedBytes": 112598356,
"domNodes": -296,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 32.221000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.1590000000597,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8669999999999995,
"layouts": 9,
"layoutDurationMs": 2.83,
"taskDurationMs": 530.187,
"heapDeltaBytes": 33684856,
"heapUsedBytes": 139628964,
"domNodes": -296,
"jsHeapTotalBytes": 20066304,
"scriptDurationMs": 32.858,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.5840000000403,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.177,
"layouts": 10,
"layoutDurationMs": 2.9290000000000003,
"taskDurationMs": 434.4910000000001,
"heapDeltaBytes": 938852,
"heapUsedBytes": 95745008,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 144.49599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.552999999978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.343,
"layouts": 9,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 456.31100000000004,
"heapDeltaBytes": 25278548,
"heapUsedBytes": 116073896,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 146.154,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2058.063000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8260000000000005,
"layouts": 9,
"layoutDurationMs": 2.5679999999999996,
"taskDurationMs": 421.11299999999994,
"heapDeltaBytes": 10030992,
"heapUsedBytes": 100700828,
"domNodes": -198,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 8.986999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.9700000000157,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0760000000000005,
"layouts": 9,
"layoutDurationMs": 2.85,
"taskDurationMs": 585.0310000000001,
"heapDeltaBytes": 2219580,
"heapUsedBytes": 94558652,
"domNodes": -219,
"jsHeapTotalBytes": 65536,
"scriptDurationMs": 8.876999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.2990000000027,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.019,
"layouts": 9,
"layoutDurationMs": 2.552,
"taskDurationMs": 924.731,
"heapDeltaBytes": 11917244,
"heapUsedBytes": 106848312,
"domNodes": -218,
"jsHeapTotalBytes": 12988416,
"scriptDurationMs": 112.708,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.1160000000236,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.587000000000002,
"layouts": 10,
"layoutDurationMs": 2.8609999999999998,
"taskDurationMs": 742.783,
"heapDeltaBytes": 1824808,
"heapUsedBytes": 92760932,
"domNodes": -210,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 109.922,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.5989999999501,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.477,
"layouts": 5,
"layoutDurationMs": 16.971,
"taskDurationMs": 1075.089,
"heapDeltaBytes": 35513792,
"heapUsedBytes": 135109840,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 29.889,
"eventListeners": 3244,
"totalBlockingTimeMs": 168,
"frameDurationMs": 20.043243243243253,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8473.464999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.648000000000003,
"layouts": 7,
"layoutDurationMs": 2.052,
"taskDurationMs": 5344.443,
"heapDeltaBytes": 2309096,
"heapUsedBytes": 112166112,
"domNodes": -276,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 2753.402,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73201581027668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.325000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.879,
"layouts": 9,
"layoutDurationMs": 2.516,
"taskDurationMs": 5170.407,
"heapDeltaBytes": 2496616,
"heapUsedBytes": 112831148,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 2659.0769999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7334008097166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16307.997999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15200.666000000001,
"heapDeltaBytes": -23510608,
"heapUsedBytes": 300873192,
"domNodes": -3344,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 232.96000000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.034364261168385,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 15565.994000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14829.920000000002,
"heapDeltaBytes": -45618964,
"heapUsedBytes": 283902100,
"domNodes": -3344,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 226.49999999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.74570446735395,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27895.54800000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.914000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27532.263,
"heapDeltaBytes": -54562148,
"heapUsedBytes": 274582116,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 869.8430000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 55,
"frameDurationMs": 51.00347349177331,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 18930.476999999995,
"styleRecalcs": 161,
"styleRecalcDurationMs": 14.44100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18571.443,
"heapDeltaBytes": -2427380,
"heapUsedBytes": 303275340,
"domNodes": -3344,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 798.137,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.12541743970315,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5964.522999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.525,
"layouts": 20,
"layoutDurationMs": 21.502999999999993,
"taskDurationMs": 5806.753000000001,
"heapDeltaBytes": -36546816,
"heapUsedBytes": 268277164,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 92.833,
"eventListeners": -653,
"totalBlockingTimeMs": 21,
"frameDurationMs": 34.29022988505747,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5810.1010000000315,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.401,
"layouts": 20,
"layoutDurationMs": 21.534,
"taskDurationMs": 5703.41,
"heapDeltaBytes": -14351040,
"heapUsedBytes": 290649868,
"domNodes": -3344,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 93.75300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 23,
"frameDurationMs": 34.82934131736527,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8207.466000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7667.591999999999,
"heapDeltaBytes": -18621232,
"heapUsedBytes": 279868684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.02999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.0419795221843,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11352.260999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10970.626,
"heapDeltaBytes": -16559848,
"heapUsedBytes": 282496188,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.82999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.73549488054608,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 445.98799999999983,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.589,
"layouts": 12,
"layoutDurationMs": 4.459,
"taskDurationMs": 108.44800000000001,
"heapDeltaBytes": 7059212,
"heapUsedBytes": 97686644,
"domNodes": 100,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 464.79600000009214,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.695000000000002,
"layouts": 12,
"layoutDurationMs": 4.158,
"taskDurationMs": 119.65599999999998,
"heapDeltaBytes": 6752632,
"heapUsedBytes": 99007144,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.015,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 462.709000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.704,
"layouts": 76,
"layoutDurationMs": 15.270999999999999,
"taskDurationMs": 426.668,
"heapDeltaBytes": -14358580,
"heapUsedBytes": 81367476,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 203.686,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.43699999996534,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.67,
"layouts": 76,
"layoutDurationMs": 14.802,
"taskDurationMs": 408.294,
"heapDeltaBytes": 11416912,
"heapUsedBytes": 81377648,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 196.463,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 562.5780000000304,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.195,
"layouts": 76,
"layoutDurationMs": 14.201,
"taskDurationMs": 525.873,
"heapDeltaBytes": 907932,
"heapUsedBytes": 117957052,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 210.696,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 595.0900000000274,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.059,
"layouts": 76,
"layoutDurationMs": 14.359,
"taskDurationMs": 561.1899999999999,
"heapDeltaBytes": 976768,
"heapUsedBytes": 118499392,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 235.683,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13055555555555,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2983 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0097ef706140114d9e240720bda5bc5d30a017ab
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (128)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22239 +/- ##
==========================================
Coverage 84.49% 84.49%
==========================================
Files 3101 3101
Lines 162992 162998 +6
Branches 39459 39460 +1
==========================================
+ Hits 137712 137725 +13
+ Misses 24888 24881 -7
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 6/6 reviewers contributed findings.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at c72495374b95a8b8550d666c05e2028501925d12 against source PR #22224 and core/1.58 tip 0097ef706140114d9e240720bda5bc5d30a017ab. The source patch and first carrier commit have identical stable patch IDs; the second commit only removes the unsupported fingerprint option from both code and assertion. The release-native AgentPanelRoot.test.ts suite passes all 482 tests, and the changed files pass type-aware oxlint and formatting. The Cursor findings preserve intentional source behavior and are dispositioned in their threads.
Backport of #22224 to
core/1.58Automatically created by backport workflow.