Repository navigation
[backport cloud/1.59] FRONT-3626 fix(billing): white Add credits when out of credits and low-credit copy by workspace - #22198
Conversation
…w-credit copy by workspace (#22177) FRONT-3626 / DES-1285 design QA round 3, items 2 and 3. They are in the "before the flag" group: they need to land in 1.59 before `unified_billing_settings` turns on in production. 2. The out-of-credits banner hard-coded a grey Add credits. The Credits card turned white only when the balance was exactly 0 and a top-up had just failed. 3. The low-credits banner used the local Partner Nodes copy everywhere, including Cloud owners and members. 2. `addCreditsEmphasis` (`creditsCard.ts`) makes Add credits white in both the banner and the Credits card when all of these hold: - the balance is 0 or below; - the served auto top-up status is not `on`; - `can_top_up` is served true; - no Subscribe / Choose a plan already holds the white button. Otherwise it stays grey. This is button emphasis only; nothing is granted or hidden by it. 3. On Cloud, the low-credits copy is picked from the served workspace type and `can_top_up`: - team owner: "This workspace has {n} credits left. Add credits before you run out."; - team member: "…Ask the workspace owner to add credits before you run out.", with no button; - personal: "You have {n} credits left. Add credits before you run out.". Local keeps "…Add credits to keep running Partner Nodes." All four have singular and plural forms. A top-up that is still processing at 0 now also shows a white Add credits. The previous rule kept it grey. | AS IS | TO BE | | --- | --- | | _screenshot pending_ | _screenshot pending_ | | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Paused plan row + refill line | QA 1.59 | #22171 | open | | 1 lifecycle banners, 5 parked owner-only, 7 Plans on billing site | FRONT-3626 | sibling PR | open | | **2 white Add credits, 3 low-credit copy** | FRONT-3626 | **this PR** | **open** | | 4 Limit reached, 6 Stay dialog copy | FRONT-3626 | #22175 | open | ```mermaid graph LR T["FRONT-3626 before the flag"] --> A["Items 1, 5, 7"] T --> B["This PR: items 2, 3"] T --> C["PR 22175: items 4, 6"] style B fill:#f9d71c,stroke:#333 ``` Siblings touch `BillingTab.vue` / `BillingTab.test.ts`; whichever lands second merges main and is re-verified. (cherry picked from commit fb8783c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T01:53:54.327Z",
"gitSha": "2938f7f16968b2a324ed141fec15a5b390be7058",
"branch": "backport-22177-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.105000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1060000000000003,
"layouts": 10,
"layoutDurationMs": 3.0019999999999993,
"taskDurationMs": 500.621,
"heapDeltaBytes": 1363124,
"heapUsedBytes": 62492384,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.921000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.2799999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8330000000000006,
"layouts": 9,
"layoutDurationMs": 2.597,
"taskDurationMs": 538.0169999999999,
"heapDeltaBytes": 1403288,
"heapUsedBytes": 62704984,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.909999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.0399999999886,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.530999999999999,
"layouts": 10,
"layoutDurationMs": 2.921,
"taskDurationMs": 831.4710000000001,
"heapDeltaBytes": 24179804,
"heapUsedBytes": 84626668,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 151.341,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.4230000000325,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.233000000000002,
"layouts": 9,
"layoutDurationMs": 3.0509999999999997,
"taskDurationMs": 896.3539999999999,
"heapDeltaBytes": 23162324,
"heapUsedBytes": 84219940,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 166.794,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.4820000000177,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.089,
"layouts": 10,
"layoutDurationMs": 2.49,
"taskDurationMs": 445.168,
"heapDeltaBytes": 24022792,
"heapUsedBytes": 85266472,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.519,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7870000000394,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.273,
"layouts": 10,
"layoutDurationMs": 3.32,
"taskDurationMs": 428.05400000000003,
"heapDeltaBytes": 478972,
"heapUsedBytes": 69731824,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.438000000000004,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 634.4019999999944,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.4119999999999995,
"layouts": 8,
"layoutDurationMs": 2.1380000000000003,
"taskDurationMs": 491.84999999999997,
"heapDeltaBytes": 6170408,
"heapUsedBytes": 67150324,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 170.974,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 671.0580000000164,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5770000000000004,
"layouts": 8,
"layoutDurationMs": 2.3200000000000003,
"taskDurationMs": 497.932,
"heapDeltaBytes": 3103656,
"heapUsedBytes": 64283992,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 166.84900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.0560000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.402,
"heapDeltaBytes": -13469624,
"heapUsedBytes": 74963260,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 76.383,
"eventListeners": -106,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.2690000000198,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 890.732,
"heapDeltaBytes": -1386632,
"heapUsedBytes": 75376596,
"domNodes": -191,
"jsHeapTotalBytes": 15998976,
"scriptDurationMs": 65.751,
"eventListeners": -106,
"totalBlockingTimeMs": 507,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.6320000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.2629999999999,
"heapDeltaBytes": -14360472,
"heapUsedBytes": 65330748,
"domNodes": -191,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 164.04999999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 906.9839999999658,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.2519999999998,
"heapDeltaBytes": -15557136,
"heapUsedBytes": 65474064,
"domNodes": -191,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 174.153,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.324324324324348,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11409.983000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10600.429,
"heapDeltaBytes": 95016492,
"heapUsedBytes": 168193132,
"domNodes": -257,
"jsHeapTotalBytes": 76410880,
"scriptDurationMs": 8628.092999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1476,
"frameDurationMs": 32.38522727272727,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10480.051000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9684.533,
"heapDeltaBytes": -2473944,
"heapUsedBytes": 86252320,
"domNodes": -257,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 7806.2300000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 882,
"frameDurationMs": 31.19910714285714,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9599.043999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8792.75,
"heapDeltaBytes": -9399648,
"heapUsedBytes": 79313608,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7031.4310000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 744,
"frameDurationMs": 31.57763157894737,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10060.046999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9288.128999999999,
"heapDeltaBytes": 58158796,
"heapUsedBytes": 141010816,
"domNodes": -257,
"jsHeapTotalBytes": 63827968,
"scriptDurationMs": 7418.381,
"eventListeners": -68,
"totalBlockingTimeMs": 849,
"frameDurationMs": 31.555799373040756,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 257.9890000000091,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.915000000000001,
"layouts": 12,
"layoutDurationMs": 3.8,
"taskDurationMs": 216.25300000000001,
"heapDeltaBytes": -1547196,
"heapUsedBytes": 68365788,
"domNodes": -2315,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.957999999999998,
"eventListeners": -573,
"totalBlockingTimeMs": 5,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 286.51300000001356,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.573,
"layouts": 12,
"layoutDurationMs": 3.9180000000000006,
"taskDurationMs": 234.201,
"heapDeltaBytes": -6702148,
"heapUsedBytes": 68660916,
"domNodes": 750,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 12.145999999999999,
"eventListeners": 64,
"totalBlockingTimeMs": 42,
"frameDurationMs": 31.4777777777778,
"p95FrameDurationMs": 149.9000000000001
},
{
"name": "large-graph-idle",
"durationMs": 2040.1620000000094,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9769999999999996,
"layouts": 8,
"layoutDurationMs": 2.3089999999999997,
"taskDurationMs": 610.3170000000001,
"heapDeltaBytes": 4742504,
"heapUsedBytes": 81217064,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.39900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.8799999999628,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.464,
"layouts": 8,
"layoutDurationMs": 2.1470000000000002,
"taskDurationMs": 478.187,
"heapDeltaBytes": -3826020,
"heapUsedBytes": 72296648,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.141999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2488.2800000000034,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.526,
"layouts": 7,
"layoutDurationMs": 1.921,
"taskDurationMs": 1709.0669999999998,
"heapDeltaBytes": 10652364,
"heapUsedBytes": 86033512,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 848.765,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2579.197000000022,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.691,
"layouts": 7,
"layoutDurationMs": 1.8149999999999997,
"taskDurationMs": 1700.6029999999996,
"heapDeltaBytes": 12172144,
"heapUsedBytes": 90332972,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 822.391,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66623376623377,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3729.900999999984,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.65,
"layouts": 64,
"layoutDurationMs": 10.715,
"taskDurationMs": 1762.6819999999998,
"heapDeltaBytes": 5169424,
"heapUsedBytes": 85915928,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 794.094,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3721.108000000072,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.006,
"layouts": 64,
"layoutDurationMs": 10.807,
"taskDurationMs": 1770.215,
"heapDeltaBytes": 4963908,
"heapUsedBytes": 81660748,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 770.3979999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3188.8179999999693,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.300000000000001,
"layouts": 5,
"layoutDurationMs": 1.2120000000000004,
"taskDurationMs": 2079.0309999999995,
"heapDeltaBytes": -11286788,
"heapUsedBytes": 70857924,
"domNodes": 0,
"jsHeapTotalBytes": 7692288,
"scriptDurationMs": 1041.711,
"eventListeners": 182,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.019047619047615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2998.6200000000736,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.277,
"layouts": 5,
"layoutDurationMs": 1.3769999999999998,
"taskDurationMs": 1952.4090000000003,
"heapDeltaBytes": 18070972,
"heapUsedBytes": 90745904,
"domNodes": 0,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 954.8459999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759217877094976,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3055.7210000000055,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1060000000000003,
"layouts": 7,
"layoutDurationMs": 1.9519999999999997,
"taskDurationMs": 776.9809999999999,
"heapDeltaBytes": 3080116,
"heapUsedBytes": 83176672,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 354.12699999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3119.703999999956,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4690000000000007,
"layouts": 6,
"layoutDurationMs": 1.5109999999999997,
"taskDurationMs": 809.675,
"heapDeltaBytes": -11053556,
"heapUsedBytes": 66851544,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 384.887,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.609999999991,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8389999999999995,
"layouts": 6,
"layoutDurationMs": 1.9800000000000004,
"taskDurationMs": 630.098,
"heapDeltaBytes": -9659236,
"heapUsedBytes": 67106352,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.774,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.432000000019,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7860000000000003,
"layouts": 6,
"layoutDurationMs": 1.681,
"taskDurationMs": 655.455,
"heapDeltaBytes": -27605364,
"heapUsedBytes": 65498212,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 34.175000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2988.226999999995,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.999000000000002,
"layouts": 8,
"layoutDurationMs": 2.0980000000000003,
"taskDurationMs": 614.9959999999999,
"heapDeltaBytes": -21591372,
"heapUsedBytes": 71531352,
"domNodes": -254,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 182.777,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2792.5369999999816,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.802,
"layouts": 6,
"layoutDurationMs": 1.6179999999999997,
"taskDurationMs": 619.571,
"heapDeltaBytes": -6593812,
"heapUsedBytes": 64772104,
"domNodes": -248,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 202.59700000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3281.052999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6119999999999997,
"layouts": 8,
"layoutDurationMs": 1.8300000000000003,
"taskDurationMs": 919.7189999999999,
"heapDeltaBytes": -15580324,
"heapUsedBytes": 65007592,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 369.80600000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3289.213000000018,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7249999999999999,
"layouts": 6,
"layoutDurationMs": 1.808,
"taskDurationMs": 970.3729999999999,
"heapDeltaBytes": -5663896,
"heapUsedBytes": 74407712,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 381.84499999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751020408163264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.0469999999991,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.98,
"layouts": 10,
"layoutDurationMs": 2.463,
"taskDurationMs": 446.533,
"heapDeltaBytes": 2463740,
"heapUsedBytes": 73336720,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 144.76799999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.3959999999661,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.0920000000000005,
"layouts": 9,
"layoutDurationMs": 2.6949999999999994,
"taskDurationMs": 445.9099999999999,
"heapDeltaBytes": -1198976,
"heapUsedBytes": 60593856,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.94899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.0599999999868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.107,
"layouts": 9,
"layoutDurationMs": 2.247,
"taskDurationMs": 501.31199999999995,
"heapDeltaBytes": 1455628,
"heapUsedBytes": 63474920,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.529000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.2970000000705,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8319999999999994,
"layouts": 9,
"layoutDurationMs": 2.4000000000000004,
"taskDurationMs": 526.9499999999999,
"heapDeltaBytes": 1731580,
"heapUsedBytes": 63746968,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.642999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.799000000008,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.387,
"layouts": 11,
"layoutDurationMs": 3.1679999999999997,
"taskDurationMs": 839.4540000000001,
"heapDeltaBytes": -5851572,
"heapUsedBytes": 65759936,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 109.471,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8059999999286,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.978000000000002,
"layouts": 9,
"layoutDurationMs": 2.785,
"taskDurationMs": 831.5840000000001,
"heapDeltaBytes": -5879216,
"heapUsedBytes": 65749020,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 111.10499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.9219999999968,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.593999999999998,
"layouts": 5,
"layoutDurationMs": 17.211000000000006,
"taskDurationMs": 1125.4020000000003,
"heapDeltaBytes": 9668068,
"heapUsedBytes": 86870500,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 33.23899999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 178,
"frameDurationMs": 20.044594594594585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9838.17399999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.905,
"layouts": 9,
"layoutDurationMs": 2.3150000000000004,
"taskDurationMs": 6034.62,
"heapDeltaBytes": -4028616,
"heapUsedBytes": 72229280,
"domNodes": -257,
"jsHeapTotalBytes": 5562368,
"scriptDurationMs": 2769.548,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660441426146,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9503.507000000012,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.508000000000003,
"layouts": 9,
"layoutDurationMs": 2.519,
"taskDurationMs": 5997.031,
"heapDeltaBytes": 2575864,
"heapUsedBytes": 76854916,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2716.467,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665964912280703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23327.927999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22800.221999999998,
"heapDeltaBytes": -18169376,
"heapUsedBytes": 258853788,
"domNodes": -3343,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 311.89,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.26690265486725,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23214.186999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22620.576,
"heapDeltaBytes": 5568160,
"heapUsedBytes": 286698212,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 331.72,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.445470383275264,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 28196.988000000034,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.666000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27825.884000000002,
"heapDeltaBytes": 9767144,
"heapUsedBytes": 286114352,
"domNodes": -3347,
"jsHeapTotalBytes": 16437248,
"scriptDurationMs": 869.242,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 53.10508474576271,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28316.43299999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.590999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27900.755999999998,
"heapDeltaBytes": -28499688,
"heapUsedBytes": 262945596,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 897.635,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 52.631040892193305,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8319.618999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.25499999999997,
"layouts": 20,
"layoutDurationMs": 22.794999999999995,
"taskDurationMs": 8197.29,
"heapDeltaBytes": -44000272,
"heapUsedBytes": 257038400,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 167.182,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 47.7948275862069,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8296.814999999924,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.91599999999997,
"layouts": 20,
"layoutDurationMs": 28.12199999999998,
"taskDurationMs": 8205.207000000002,
"heapDeltaBytes": -44792972,
"heapUsedBytes": 252306316,
"domNodes": -3343,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 120.358,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.69942528735633,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11441.214000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11114.127,
"heapDeltaBytes": 24443980,
"heapUsedBytes": 281387220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.13900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.153424657534245,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11478.58199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11256.636000000002,
"heapDeltaBytes": -4484944,
"heapUsedBytes": 274883692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.21300000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.95071428571429,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 142.71400000001222,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.124999999999998,
"layouts": 10,
"layoutDurationMs": 4.3549999999999995,
"taskDurationMs": 109.65599999999999,
"heapDeltaBytes": 4921696,
"heapUsedBytes": 72871864,
"domNodes": 113,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.331000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999977,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 122.57199999999102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.525000000000002,
"layouts": 9,
"layoutDurationMs": 3.6409999999999996,
"taskDurationMs": 90.665,
"heapDeltaBytes": 4593852,
"heapUsedBytes": 64192096,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.438999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 507.6810000000478,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.633,
"layouts": 76,
"layoutDurationMs": 14.556,
"taskDurationMs": 456.30099999999993,
"heapDeltaBytes": -3821396,
"heapUsedBytes": 40156000,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 225.517,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 491.96600000004764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6130000000000001,
"layouts": 76,
"layoutDurationMs": 14.965,
"taskDurationMs": 441.992,
"heapDeltaBytes": -4242328,
"heapUsedBytes": 40149996,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 217.043,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 599.8700000000099,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.764,
"layouts": 76,
"layoutDurationMs": 15.735,
"taskDurationMs": 569.7280000000001,
"heapDeltaBytes": 1829708,
"heapUsedBytes": 91310784,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 240.73,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 622.4990000000616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5250000000000001,
"layouts": 76,
"layoutDurationMs": 16.192999999999998,
"taskDurationMs": 583.8509999999999,
"heapDeltaBytes": 858624,
"heapUsedBytes": 94696292,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 248.951,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.118918918918933,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3125 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 73ca28b17b7d752fb74956c9a2cbaeea39a72632
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (217)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22198 +/- ##
=============================================
Coverage ? 87.45%
=============================================
Files ? 2956
Lines ? 156099
Branches ? 40078
=============================================
Hits ? 136521
Misses ? 18903
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this is a faithful cloud/1.59 backport of frontend PR 22177. No package manifest changes.
Full context for agent readers
The only line-level differences are forced by the older branch module layout: workspace billing API and UI imports replace the newer billing package seams. Delivery remains open through merge, consumed build or deploy, and target QA.
Manual backport of #22177 (FRONT-3626 items 2 and 3, M4 before the flag). The bot cherry-pick conflicted on 1.59's older module layout.
Why / Root cause / How
Same as #22177: Add credits turns white when out of credits and auto top-up won't refill, and low-credit copy is picked by workspace from served facts.
Conflict resolution
BillingLocalCreditBanner.vue: 1.59 has nouseBillingUI, soworkspaceTypecomes fromuseWorkspaceUI()(same servedactiveWorkspace.type).creditsCard.ts:AutoReloadSettings/BillingStatusimport from@/platform/workspace/api/workspaceApi(1.59 has no@comfyorg/billing-core).BillingTab.test.ts:billingApi.getBillingAutoReload→workspaceApi.getBillingAutoReload.Billing tab and billing composable tests: 49 files pass.
AS IS / TO BE
See #22177.