Repository navigation
[backport core/1.59] FRONT-3626 fix(billing): white Add credits when out of credits and low-credit copy by workspace - #22197
Conversation
…w-credit copy by workspace (#22177) FRONT-3626 / DES-1285 design QA round 3, items 2 and 3. They are in the "before the flag" group: they need to land in 1.59 before `unified_billing_settings` turns on in production. 2. The out-of-credits banner hard-coded a grey Add credits. The Credits card turned white only when the balance was exactly 0 and a top-up had just failed. 3. The low-credits banner used the local Partner Nodes copy everywhere, including Cloud owners and members. 2. `addCreditsEmphasis` (`creditsCard.ts`) makes Add credits white in both the banner and the Credits card when all of these hold: - the balance is 0 or below; - the served auto top-up status is not `on`; - `can_top_up` is served true; - no Subscribe / Choose a plan already holds the white button. Otherwise it stays grey. This is button emphasis only; nothing is granted or hidden by it. 3. On Cloud, the low-credits copy is picked from the served workspace type and `can_top_up`: - team owner: "This workspace has {n} credits left. Add credits before you run out."; - team member: "…Ask the workspace owner to add credits before you run out.", with no button; - personal: "You have {n} credits left. Add credits before you run out.". Local keeps "…Add credits to keep running Partner Nodes." All four have singular and plural forms. A top-up that is still processing at 0 now also shows a white Add credits. The previous rule kept it grey. | AS IS | TO BE | | --- | --- | | _screenshot pending_ | _screenshot pending_ | | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Paused plan row + refill line | QA 1.59 | #22171 | open | | 1 lifecycle banners, 5 parked owner-only, 7 Plans on billing site | FRONT-3626 | sibling PR | open | | **2 white Add credits, 3 low-credit copy** | FRONT-3626 | **this PR** | **open** | | 4 Limit reached, 6 Stay dialog copy | FRONT-3626 | #22175 | open | ```mermaid graph LR T["FRONT-3626 before the flag"] --> A["Items 1, 5, 7"] T --> B["This PR: items 2, 3"] T --> C["PR 22175: items 4, 6"] style B fill:#f9d71c,stroke:#333 ``` Siblings touch `BillingTab.vue` / `BillingTab.test.ts`; whichever lands second merges main and is re-verified. (cherry picked from commit fb8783c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T01:54:34.166Z",
"gitSha": "a4b6e90195d1264fbfdf7173c938ea18eb3e211d",
"branch": "backport-22177-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.8449999999848,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2430000000000003,
"layouts": 9,
"layoutDurationMs": 3.154,
"taskDurationMs": 617.134,
"heapDeltaBytes": 4472000,
"heapUsedBytes": 75140592,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 12.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.9930000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5250000000000004,
"layouts": 9,
"layoutDurationMs": 3.8089999999999993,
"taskDurationMs": 649.1389999999999,
"heapDeltaBytes": 3327160,
"heapUsedBytes": 64251888,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 13.588000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1852.7409999999804,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.609,
"layouts": 9,
"layoutDurationMs": 2.9219999999999997,
"taskDurationMs": 964.8530000000001,
"heapDeltaBytes": 21098648,
"heapUsedBytes": 81708384,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 172.033,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.6940000000159,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.549000000000001,
"layouts": 9,
"layoutDurationMs": 2.9720000000000004,
"taskDurationMs": 1009.213,
"heapDeltaBytes": 21701808,
"heapUsedBytes": 83221876,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 175.088,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.2750000000192,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.316000000000001,
"layouts": 9,
"layoutDurationMs": 3.307,
"taskDurationMs": 484.03299999999996,
"heapDeltaBytes": 24035396,
"heapUsedBytes": 85618792,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 15.874000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1899999999841,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.4399999999999995,
"layouts": 10,
"layoutDurationMs": 3.601,
"taskDurationMs": 516.7969999999999,
"heapDeltaBytes": 579560,
"heapUsedBytes": 70346704,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 16.521,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 746.4899999999943,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.882,
"layouts": 9,
"layoutDurationMs": 2.998,
"taskDurationMs": 524.906,
"heapDeltaBytes": 3724956,
"heapUsedBytes": 64511368,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 172.46999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 758.6989999999787,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3689999999999998,
"layouts": 10,
"layoutDurationMs": 3.307,
"taskDurationMs": 557.644,
"heapDeltaBytes": 7406308,
"heapUsedBytes": 77330996,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 180.32299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1286.167000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1011.069,
"heapDeltaBytes": -12220260,
"heapUsedBytes": 75182000,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 80.798,
"eventListeners": -106,
"totalBlockingTimeMs": 589,
"frameDurationMs": 33.771052631578954,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1368.1229999999687,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1113.1770000000001,
"heapDeltaBytes": -14508424,
"heapUsedBytes": 74698248,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 73.87,
"eventListeners": -106,
"totalBlockingTimeMs": 660,
"frameDurationMs": 35.96052631578947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.5059999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.545,
"heapDeltaBytes": -13373664,
"heapUsedBytes": 66593288,
"domNodes": -191,
"jsHeapTotalBytes": 2228224,
"scriptDurationMs": 167.92599999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.321621621621638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.2950000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.2529999999999,
"heapDeltaBytes": 24040232,
"heapUsedBytes": 88186308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.50000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11603.01099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10701.340999999999,
"heapDeltaBytes": 4539936,
"heapUsedBytes": 92649228,
"domNodes": -257,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 8641.632,
"eventListeners": -68,
"totalBlockingTimeMs": 1300,
"frameDurationMs": 32.22083333333334,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11192.878000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10389.254,
"heapDeltaBytes": 81652928,
"heapUsedBytes": 154028940,
"domNodes": -257,
"jsHeapTotalBytes": 75362304,
"scriptDurationMs": 8292.793999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1278,
"frameDurationMs": 31.50112676056338,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10475.577000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9638.365,
"heapDeltaBytes": 57983316,
"heapUsedBytes": 131388960,
"domNodes": -257,
"jsHeapTotalBytes": 65138688,
"scriptDurationMs": 7702.17,
"eventListeners": -68,
"totalBlockingTimeMs": 965,
"frameDurationMs": 31.014792899408285,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11613.045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10777.764000000001,
"heapDeltaBytes": 66618248,
"heapUsedBytes": 140306124,
"domNodes": -257,
"jsHeapTotalBytes": 73789440,
"scriptDurationMs": 8616.257000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1459,
"frameDurationMs": 31.692622950819672,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 325.0160000000051,
"styleRecalcs": 28,
"styleRecalcDurationMs": 17.5,
"layouts": 11,
"layoutDurationMs": 4.380999999999999,
"taskDurationMs": 272.838,
"heapDeltaBytes": -16427460,
"heapUsedBytes": 59308532,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 11.349000000000002,
"eventListeners": -640,
"totalBlockingTimeMs": 5,
"frameDurationMs": 22.62142857142856,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 281.09200000005785,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.049999999999999,
"layouts": 9,
"layoutDurationMs": 3.711,
"taskDurationMs": 234.42300000000003,
"heapDeltaBytes": -8303648,
"heapUsedBytes": 68241760,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.357,
"eventListeners": -573,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.60833333333335,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2054.6899999999937,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6490000000000005,
"layouts": 8,
"layoutDurationMs": 2.4949999999999997,
"taskDurationMs": 758.0649999999999,
"heapDeltaBytes": -26838124,
"heapUsedBytes": 64251404,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 37.537,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2053.41599999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5059999999999993,
"layouts": 7,
"layoutDurationMs": 2.6000000000000005,
"taskDurationMs": 792.3349999999999,
"heapDeltaBytes": -20830576,
"heapUsedBytes": 70497100,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 39.37799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2777.5869999999827,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.097,
"layouts": 6,
"layoutDurationMs": 1.7200000000000002,
"taskDurationMs": 1902.551,
"heapDeltaBytes": -29407252,
"heapUsedBytes": 62827164,
"domNodes": -257,
"jsHeapTotalBytes": 7503872,
"scriptDurationMs": 916.193,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766867469879518,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2786.4789999999857,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.312000000000001,
"layouts": 7,
"layoutDurationMs": 1.8410000000000002,
"taskDurationMs": 1848.768,
"heapDeltaBytes": 7814648,
"heapUsedBytes": 85774572,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 884.9019999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3891.4570000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.491,
"layouts": 64,
"layoutDurationMs": 11.823,
"taskDurationMs": 1935.1659999999997,
"heapDeltaBytes": 6765136,
"heapUsedBytes": 85899400,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 849.209,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666094420600857,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3953.1150000000252,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.152999999999999,
"layouts": 64,
"layoutDurationMs": 11.259,
"taskDurationMs": 2005.4550000000004,
"heapDeltaBytes": 2698448,
"heapUsedBytes": 84057776,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 850.696,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582278481013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3441.7530000000056,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.6819999999999995,
"layouts": 5,
"layoutDurationMs": 1.5230000000000001,
"taskDurationMs": 2283.728,
"heapDeltaBytes": -11138624,
"heapUsedBytes": 61309696,
"domNodes": -257,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 1102.587,
"eventListeners": -54,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.828921568627447,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3578.1220000000076,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.2299999999999995,
"layouts": 4,
"layoutDurationMs": 1.4470000000000003,
"taskDurationMs": 2385.3979999999997,
"heapDeltaBytes": -12344180,
"heapUsedBytes": 70105360,
"domNodes": -257,
"jsHeapTotalBytes": 6119424,
"scriptDurationMs": 1148.276,
"eventListeners": -48,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82311320754717,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3118.3200000000115,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7270000000000003,
"layouts": 7,
"layoutDurationMs": 1.889,
"taskDurationMs": 843.4280000000001,
"heapDeltaBytes": 2505516,
"heapUsedBytes": 78965852,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 374.179,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3221.9449999998915,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7559999999999998,
"layouts": 6,
"layoutDurationMs": 1.865,
"taskDurationMs": 930.201,
"heapDeltaBytes": 6925600,
"heapUsedBytes": 78051268,
"domNodes": -257,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 430.197,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752604166666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2045.7059999999956,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.503,
"layouts": 7,
"layoutDurationMs": 2.5360000000000005,
"taskDurationMs": 756.5070000000001,
"heapDeltaBytes": -12310260,
"heapUsedBytes": 65121888,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 39.565000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.9870000000155,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.216,
"layouts": 7,
"layoutDurationMs": 2.351,
"taskDurationMs": 806.3840000000001,
"heapDeltaBytes": -9028124,
"heapUsedBytes": 72483688,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 40.05400000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2904.1309999999785,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.784,
"layouts": 6,
"layoutDurationMs": 1.824,
"taskDurationMs": 667.9989999999999,
"heapDeltaBytes": 104864,
"heapUsedBytes": 75653484,
"domNodes": -253,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 209.15399999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762427745664745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2934.5400000000836,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.481000000000002,
"layouts": 6,
"layoutDurationMs": 1.9829999999999999,
"taskDurationMs": 685.699,
"heapDeltaBytes": -9841976,
"heapUsedBytes": 61287596,
"domNodes": -250,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 216.043,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3431.929999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0539999999999994,
"layouts": 7,
"layoutDurationMs": 1.938,
"taskDurationMs": 1069.913,
"heapDeltaBytes": -3956764,
"heapUsedBytes": 72383492,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 440.47,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746829268292686,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3432.780999999977,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1190000000000002,
"layouts": 4,
"layoutDurationMs": 1.121,
"taskDurationMs": 1132.357,
"heapDeltaBytes": -30532612,
"heapUsedBytes": 62973696,
"domNodes": -257,
"jsHeapTotalBytes": 7503872,
"scriptDurationMs": 464.108,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74731707317073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 679.9060000000168,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.743,
"layouts": 9,
"layoutDurationMs": 2.796,
"taskDurationMs": 479.24,
"heapDeltaBytes": 405480,
"heapUsedBytes": 62795912,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 155.102,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 724.1179999999758,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.782,
"layouts": 10,
"layoutDurationMs": 2.7509999999999994,
"taskDurationMs": 497.96399999999994,
"heapDeltaBytes": 2089912,
"heapUsedBytes": 73857564,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 156.84,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2040.6190000000493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8040000000000003,
"layouts": 10,
"layoutDurationMs": 3.7970000000000006,
"taskDurationMs": 642.029,
"heapDeltaBytes": 5041064,
"heapUsedBytes": 76876296,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.248000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.5780000000668,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0739999999999994,
"layouts": 8,
"layoutDurationMs": 3.1270000000000002,
"taskDurationMs": 663.7239999999999,
"heapDeltaBytes": 3640888,
"heapUsedBytes": 65898484,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 13.911,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0669999999673,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.711,
"layouts": 9,
"layoutDurationMs": 2.974,
"taskDurationMs": 894.212,
"heapDeltaBytes": 18375496,
"heapUsedBytes": 80652924,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 118.96499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.833000000066,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.207,
"layouts": 9,
"layoutDurationMs": 2.771,
"taskDurationMs": 957.5899999999999,
"heapDeltaBytes": 18886200,
"heapUsedBytes": 81326556,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 127.55299999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1535.0139999999897,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.981,
"layouts": 5,
"layoutDurationMs": 15.291000000000002,
"taskDurationMs": 1258.9629999999995,
"heapDeltaBytes": 11770444,
"heapUsedBytes": 107562736,
"domNodes": 16030,
"jsHeapTotalBytes": 10883072,
"scriptDurationMs": 36.116,
"eventListeners": 3246,
"totalBlockingTimeMs": 188,
"frameDurationMs": 20.17631578947368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10321.86200000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.25,
"layouts": 8,
"layoutDurationMs": 2.475,
"taskDurationMs": 6687.061,
"heapDeltaBytes": 7340404,
"heapUsedBytes": 82367384,
"domNodes": -257,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 3067.776,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607431340872,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10076.303999999936,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.469,
"layouts": 6,
"layoutDurationMs": 1.8480000000000003,
"taskDurationMs": 6533.956,
"heapDeltaBytes": 680940,
"heapUsedBytes": 76997880,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2927.76,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693864013266996,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24218.503999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23604.526,
"heapDeltaBytes": -6706852,
"heapUsedBytes": 269824892,
"domNodes": -3347,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 357.058,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.78392226148409,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 25319.15200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24847.308999999997,
"heapDeltaBytes": -23938768,
"heapUsedBytes": 276447688,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 362.708,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.28747763864043,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 29266.007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29012.126000000004,
"heapDeltaBytes": -34952552,
"heapUsedBytes": 267046768,
"domNodes": -3343,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 959.923,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 55.24924528301887,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29657.39899999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.112000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29399.224,
"heapDeltaBytes": -20278552,
"heapUsedBytes": 256060620,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 975.7839999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 56.581679389312974,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8720.336999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.39699999999998,
"layouts": 20,
"layoutDurationMs": 32.016000000000005,
"taskDurationMs": 8606.719,
"heapDeltaBytes": -22162072,
"heapUsedBytes": 249974620,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 137.84099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.061797752809,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 9025.537999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.65400000000002,
"layouts": 20,
"layoutDurationMs": 26.926000000000005,
"taskDurationMs": 8934.568000000001,
"heapDeltaBytes": -6952672,
"heapUsedBytes": 269977596,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 141.193,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.46368715083799,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12151.474000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11694.772,
"heapDeltaBytes": 41284,
"heapUsedBytes": 273259764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.35499999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.99010600706714,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12249.14000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11944.279999999999,
"heapDeltaBytes": -607052,
"heapUsedBytes": 251208112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.35999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.688928571428576,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 140.31099999999697,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.668,
"layouts": 9,
"layoutDurationMs": 4.545000000000001,
"taskDurationMs": 110.11800000000001,
"heapDeltaBytes": 4819176,
"heapUsedBytes": 64269164,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.201,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 147.39400000007663,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.561,
"layouts": 9,
"layoutDurationMs": 4.697,
"taskDurationMs": 100.738,
"heapDeltaBytes": 4602876,
"heapUsedBytes": 72813484,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.027,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 663.3399999999483,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.839,
"layouts": 76,
"layoutDurationMs": 18.697,
"taskDurationMs": 602.931,
"heapDeltaBytes": -2645764,
"heapUsedBytes": 43563248,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 294.026,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 636.2729999999601,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.789,
"layouts": 76,
"layoutDurationMs": 19.182000000000002,
"taskDurationMs": 580.215,
"heapDeltaBytes": -2789132,
"heapUsedBytes": 42653668,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 274.375,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 666.2000000000035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.436,
"layouts": 76,
"layoutDurationMs": 15.828999999999999,
"taskDurationMs": 626.4530000000001,
"heapDeltaBytes": 2333788,
"heapUsedBytes": 103644284,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 259.955,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 726.9830000000184,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.296,
"layouts": 76,
"layoutDurationMs": 16.991,
"taskDurationMs": 694.647,
"heapDeltaBytes": 2952652,
"heapUsedBytes": 101069112,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 278.644,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3582af91156bb540eaf5d4ea4d737936b772a4da
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (217)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22197 +/- ##
=============================================
- Coverage 87.46% 87.46% -0.01%
=============================================
Files 2956 2956
Lines 156065 156081 +16
Branches 40025 40039 +14
=============================================
+ Hits 136499 136512 +13
- Misses 18891 18894 +3
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this is a faithful core/1.59 backport of frontend PR 22177. No package manifest changes.
Full context for agent readers
The only line-level differences are forced by the older branch module layout: workspace billing API and UI imports replace the newer billing package seams. Delivery remains open through merge, consumed build or deploy, and target QA.
Manual backport of #22177 (FRONT-3626 items 2 and 3, M4 before the flag). The bot cherry-pick conflicted on 1.59's older module layout.
Why / Root cause / How
Same as #22177: Add credits turns white when out of credits and auto top-up won't refill, and low-credit copy is picked by workspace from served facts.
Conflict resolution
BillingLocalCreditBanner.vue: 1.59 has nouseBillingUI, soworkspaceTypecomes fromuseWorkspaceUI()(same servedactiveWorkspace.type).creditsCard.ts:AutoReloadSettings/BillingStatusimport from@/platform/workspace/api/workspaceApi(1.59 has no@comfyorg/billing-core).BillingTab.test.ts:billingApi.getBillingAutoReload→workspaceApi.getBillingAutoReload.Billing tab and billing composable tests: 49 files pass.
AS IS / TO BE
See #22177.