Repository navigation
Conversation
…ox align button The More Options menu merges Align Selected To and Distribute Nodes into one Arrange submenu: Tidy up, the four align options, then the two distribute options, with separators between the groups. Tidy up no longer lands under Extensions. The selection toolbox gets an align button beside Tidy up. It opens the same six options as an icon row beneath the toolbox, which lifts to make room, the way the Tidy up gap bar does. Only one of the two bars is open at a time, and the toolbox stays lifted while switching between them. Both surfaces read the option list in useNodeArrangement. Tidy up and the align button share the bar's popover, offsets and keep-open rule. From the toolbox's More Options menu, align now uses the selection's edges, like the toolbox row; right-clicking a node still aligns the selection to that node.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T21:00:26.672Z",
"gitSha": "38e59c041c6b7793f1776a8e96df58bd3396a22e",
"branch": "willie/arrange-menu",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.5699999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.055,
"layouts": 9,
"layoutDurationMs": 2.049,
"taskDurationMs": 400.409,
"heapDeltaBytes": 1672368,
"heapUsedBytes": 63741724,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.6960000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2006.5709999998944,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7349999999999994,
"layouts": 10,
"layoutDurationMs": 2.628,
"taskDurationMs": 421.27799999999996,
"heapDeltaBytes": 1347524,
"heapUsedBytes": 62759212,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.389000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.8679999999758,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.866999999999999,
"layouts": 9,
"layoutDurationMs": 2.082,
"taskDurationMs": 682.3140000000001,
"heapDeltaBytes": 21373728,
"heapUsedBytes": 82796400,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 114.954,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.062999999952,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.392,
"layouts": 9,
"layoutDurationMs": 1.961,
"taskDurationMs": 668.1210000000001,
"heapDeltaBytes": -2787920,
"heapUsedBytes": 67947588,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 113.762,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.9340000000138,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.644,
"layouts": 9,
"layoutDurationMs": 2.4600000000000004,
"taskDurationMs": 326.507,
"heapDeltaBytes": 24402392,
"heapUsedBytes": 84111468,
"domNodes": 57,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.44,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.482999999911,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.700000000000001,
"layouts": 10,
"layoutDurationMs": 2.8339999999999996,
"taskDurationMs": 341.898,
"heapDeltaBytes": 23947480,
"heapUsedBytes": 85389040,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.604,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.5860000000098,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.6699999999999995,
"layouts": 10,
"layoutDurationMs": 2.4229999999999996,
"taskDurationMs": 399.624,
"heapDeltaBytes": 6375948,
"heapUsedBytes": 77020488,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 134.82799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 565.2669999999489,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9679999999999995,
"layouts": 10,
"layoutDurationMs": 2.574,
"taskDurationMs": 405.448,
"heapDeltaBytes": 3443540,
"heapUsedBytes": 64720928,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 134.964,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1053.7160000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.0309999999998,
"heapDeltaBytes": -13619728,
"heapUsedBytes": 75390756,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 54.079,
"eventListeners": -106,
"totalBlockingTimeMs": 379,
"frameDurationMs": 29.166666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1118.4420000000728,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.6639999999999,
"heapDeltaBytes": -13786724,
"heapUsedBytes": 75476532,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 56.843,
"eventListeners": -106,
"totalBlockingTimeMs": 436,
"frameDurationMs": 30.181081081081075,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.6650000000341,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.43899999999974,
"heapDeltaBytes": -26010208,
"heapUsedBytes": 66366724,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 121.90600000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 169,
"frameDurationMs": 23.147222222222226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.8400000000747,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.26900000000023,
"heapDeltaBytes": -28917444,
"heapUsedBytes": 66081864,
"domNodes": -191,
"jsHeapTotalBytes": 4849664,
"scriptDurationMs": 125.57,
"eventListeners": -106,
"totalBlockingTimeMs": 160,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7710.621000000003,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4129999999999993,
"layouts": 2,
"layoutDurationMs": 0.39599999999999963,
"taskDurationMs": 6935.101000000001,
"heapDeltaBytes": 57326432,
"heapUsedBytes": 136044456,
"domNodes": -257,
"jsHeapTotalBytes": 56487936,
"scriptDurationMs": 5415.743,
"eventListeners": -68,
"totalBlockingTimeMs": 68,
"frameDurationMs": 24.496190476190478,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7387.511000000018,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8209999999999997,
"layouts": 3,
"layoutDurationMs": 0.7530000000000002,
"taskDurationMs": 6580.795,
"heapDeltaBytes": 52791316,
"heapUsedBytes": 131334956,
"domNodes": -257,
"jsHeapTotalBytes": 50458624,
"scriptDurationMs": 5047.359,
"eventListeners": -68,
"totalBlockingTimeMs": 51,
"frameDurationMs": 24.127777777777776,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7793.051999999989,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5370000000000001,
"layouts": 2,
"layoutDurationMs": 0.5310000000000002,
"taskDurationMs": 6964.716,
"heapDeltaBytes": 57694864,
"heapUsedBytes": 136669888,
"domNodes": -257,
"jsHeapTotalBytes": 53604352,
"scriptDurationMs": 5418.198,
"eventListeners": -68,
"totalBlockingTimeMs": 145,
"frameDurationMs": 24.552050473186117,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6959.475999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8590000000000004,
"layouts": 3,
"layoutDurationMs": 0.8310000000000002,
"taskDurationMs": 6202.242,
"heapDeltaBytes": 52328300,
"heapUsedBytes": 134024316,
"domNodes": -257,
"jsHeapTotalBytes": 53866496,
"scriptDurationMs": 4989.397,
"eventListeners": -68,
"totalBlockingTimeMs": 52,
"frameDurationMs": 24.470774647887325,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 178.76200000000608,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.301000000000002,
"layouts": 11,
"layoutDurationMs": 2.6940000000000004,
"taskDurationMs": 139.15,
"heapDeltaBytes": 14467216,
"heapUsedBytes": 84913380,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.123000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 207.5880000001007,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.027000000000001,
"layouts": 11,
"layoutDurationMs": 3.15,
"taskDurationMs": 162.107,
"heapDeltaBytes": 14539728,
"heapUsedBytes": 83968524,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.482,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.233333333333324,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2023.4530000000177,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.490999999999999,
"layouts": 9,
"layoutDurationMs": 2.2510000000000003,
"taskDurationMs": 536.473,
"heapDeltaBytes": -9203068,
"heapUsedBytes": 78787760,
"domNodes": -257,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 30.964000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2060.1090000000113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1229999999999998,
"layouts": 9,
"layoutDurationMs": 2.018,
"taskDurationMs": 563.921,
"heapDeltaBytes": -5122896,
"heapUsedBytes": 81407860,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 31.82,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2303.472999999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.78,
"layouts": 9,
"layoutDurationMs": 1.9400000000000002,
"taskDurationMs": 1352.385,
"heapDeltaBytes": -11817648,
"heapUsedBytes": 76531108,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 662.994,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2265.733999999952,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.222000000000001,
"layouts": 9,
"layoutDurationMs": 2.2840000000000003,
"taskDurationMs": 1362.8850000000002,
"heapDeltaBytes": 5556348,
"heapUsedBytes": 85983116,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 672.964,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617647058823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3353.5079999999766,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.673000000000002,
"layouts": 65,
"layoutDurationMs": 10.442,
"taskDurationMs": 1446.1999999999998,
"heapDeltaBytes": 5139516,
"heapUsedBytes": 94912496,
"domNodes": 24,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 649.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666169154228854,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3382.056000000034,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.708000000000002,
"layouts": 65,
"layoutDurationMs": 10.426,
"taskDurationMs": 1469.97,
"heapDeltaBytes": -9409788,
"heapUsedBytes": 79584040,
"domNodes": -233,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 647.309,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2620.0170000000185,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.255,
"layouts": 6,
"layoutDurationMs": 1.4100000000000001,
"taskDurationMs": 1603.942,
"heapDeltaBytes": 15794912,
"heapUsedBytes": 93862536,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 805.685,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2431.9189999999935,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.5409999999999995,
"layouts": 7,
"layoutDurationMs": 1.6740000000000002,
"taskDurationMs": 1597.42,
"heapDeltaBytes": -14260920,
"heapUsedBytes": 80030872,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 797.0939999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2980.131999999969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7560000000000007,
"layouts": 8,
"layoutDurationMs": 1.609,
"taskDurationMs": 656.1320000000001,
"heapDeltaBytes": -26460936,
"heapUsedBytes": 65120188,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 316.473,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2976.609999999937,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9129999999999998,
"layouts": 8,
"layoutDurationMs": 1.655,
"taskDurationMs": 657.732,
"heapDeltaBytes": -28427252,
"heapUsedBytes": 60826180,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 305.125,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.2830000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7310000000000008,
"layouts": 8,
"layoutDurationMs": 1.655,
"taskDurationMs": 506.73100000000005,
"heapDeltaBytes": -13716964,
"heapUsedBytes": 78172392,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 27.928,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2033.5460000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.281,
"layouts": 8,
"layoutDurationMs": 2.259000000000001,
"taskDurationMs": 539.539,
"heapDeltaBytes": -4098632,
"heapUsedBytes": 85322424,
"domNodes": -261,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 29.735000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2713.382999999965,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.965000000000002,
"layouts": 8,
"layoutDurationMs": 1.441,
"taskDurationMs": 421.566,
"heapDeltaBytes": -10190524,
"heapUsedBytes": 78523860,
"domNodes": -238,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 151.46599999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2710.201999999981,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.487999999999998,
"layouts": 8,
"layoutDurationMs": 1.762,
"taskDurationMs": 493.30299999999994,
"heapDeltaBytes": -16975416,
"heapUsedBytes": 72361132,
"domNodes": -253,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 153.034,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3055.7230000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.66,
"layouts": 9,
"layoutDurationMs": 1.5999999999999999,
"taskDurationMs": 748.6530000000001,
"heapDeltaBytes": -18708324,
"heapUsedBytes": 70866052,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 292.029,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3031.0950000000503,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8050000000000002,
"layouts": 8,
"layoutDurationMs": 1.5,
"taskDurationMs": 711.8249999999999,
"heapDeltaBytes": 8452268,
"heapUsedBytes": 97674856,
"domNodes": 0,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 283.894,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 516.7989999999918,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.684000000000001,
"layouts": 9,
"layoutDurationMs": 1.9779999999999998,
"taskDurationMs": 313.218,
"heapDeltaBytes": 22048960,
"heapUsedBytes": 84719460,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 120.53,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.335999999993,
"styleRecalcs": 43,
"styleRecalcDurationMs": 3.618,
"layouts": 5,
"layoutDurationMs": 1.1119999999999997,
"taskDurationMs": 365.49399999999997,
"heapDeltaBytes": -1160756,
"heapUsedBytes": 60575460,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 123.579,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.0739999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.546,
"layouts": 10,
"layoutDurationMs": 2.3989999999999996,
"taskDurationMs": 424.73800000000006,
"heapDeltaBytes": 941292,
"heapUsedBytes": 62988764,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.450000000039,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.529,
"layouts": 10,
"layoutDurationMs": 2.381,
"taskDurationMs": 438.3830000000001,
"heapDeltaBytes": 901540,
"heapUsedBytes": 63554604,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.429,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.19900000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.44,
"layouts": 10,
"layoutDurationMs": 2.1390000000000002,
"taskDurationMs": 645.6990000000001,
"heapDeltaBytes": 17397572,
"heapUsedBytes": 79927628,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 84.18100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673263,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.6799999999666,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.184000000000001,
"layouts": 9,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 692.966,
"heapDeltaBytes": 17233228,
"heapUsedBytes": 79396040,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 92.94800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673263,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.7509999999675,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.997999999999994,
"layouts": 5,
"layoutDurationMs": 10.249,
"taskDurationMs": 851.45,
"heapDeltaBytes": 38070160,
"heapUsedBytes": 114653736,
"domNodes": 16030,
"jsHeapTotalBytes": 10883072,
"scriptDurationMs": 37.995999999999995,
"eventListeners": 3246,
"totalBlockingTimeMs": 95,
"frameDurationMs": 18.808571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9110.345999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.298,
"layouts": 9,
"layoutDurationMs": 2.102,
"taskDurationMs": 4927.045,
"heapDeltaBytes": -24376820,
"heapUsedBytes": 62429288,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 2275.4159999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617915904936,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8964.663999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.417,
"layouts": 10,
"layoutDurationMs": 2.4090000000000003,
"taskDurationMs": 4892.092,
"heapDeltaBytes": -7529116,
"heapUsedBytes": 78160604,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2240.678,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665985130111522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19867.399999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19102.566000000003,
"heapDeltaBytes": -30432008,
"heapUsedBytes": 261951764,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 260.757,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.0044014084507,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 19845.238999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19162.983,
"heapDeltaBytes": -24784448,
"heapUsedBytes": 276827928,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 264.979,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.2563055062167,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23743.23000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.742000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23462.213,
"heapDeltaBytes": -35309548,
"heapUsedBytes": 256404556,
"domNodes": -3343,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 712.342,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 45.63923076923077,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 23888.387999999963,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.27899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23565.954999999998,
"heapDeltaBytes": -21758528,
"heapUsedBytes": 255656860,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 782.9399999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.403802281368826,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7003.900000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.95100000000002,
"layouts": 20,
"layoutDurationMs": 21.499000000000006,
"taskDurationMs": 6936.4,
"heapDeltaBytes": 3007280,
"heapUsedBytes": 281131052,
"domNodes": -3343,
"jsHeapTotalBytes": 22798336,
"scriptDurationMs": 98.15600000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.47639751552796,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7090.8640000000105,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.83200000000001,
"layouts": 20,
"layoutDurationMs": 28.618000000000006,
"taskDurationMs": 6965.435,
"heapDeltaBytes": -2806220,
"heapUsedBytes": 279721332,
"domNodes": -3343,
"jsHeapTotalBytes": 21749760,
"scriptDurationMs": 107.035,
"eventListeners": -653,
"totalBlockingTimeMs": 11,
"frameDurationMs": 40.016949152542374,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9967.565000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9591.154999999999,
"heapDeltaBytes": -1681524,
"heapUsedBytes": 260191616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.32700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.37299270072993,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9794.674999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9483.189,
"heapDeltaBytes": -4187624,
"heapUsedBytes": 257201488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.80000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.69563636363636,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 114.97399999996105,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.688,
"layouts": 8,
"layoutDurationMs": 3.2319999999999998,
"taskDurationMs": 80.75699999999999,
"heapDeltaBytes": 4966376,
"heapUsedBytes": 65684244,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.844999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.45799999994142,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.679,
"layouts": 7,
"layoutDurationMs": 2.002,
"taskDurationMs": 59.937000000000005,
"heapDeltaBytes": 4560572,
"heapUsedBytes": 72121076,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.52,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 295.556999999917,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.773,
"layouts": 76,
"layoutDurationMs": 12.149000000000001,
"taskDurationMs": 266.41499999999996,
"heapDeltaBytes": 10580648,
"heapUsedBytes": 51916304,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 123.80999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 287.03199999995377,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5680000000000001,
"layouts": 76,
"layoutDurationMs": 11.939,
"taskDurationMs": 248.885,
"heapDeltaBytes": 10342048,
"heapUsedBytes": 50804696,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 114.575,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 325.5940000000237,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.843,
"layouts": 76,
"layoutDurationMs": 11.664000000000001,
"taskDurationMs": 293.728,
"heapDeltaBytes": -2010440,
"heapUsedBytes": 88704220,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.961,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 343.69600000002265,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.899,
"layouts": 76,
"layoutDurationMs": 11.687,
"taskDurationMs": 313.289,
"heapDeltaBytes": -1754140,
"heapUsedBytes": 88947368,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 111.111,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3140 passed, 0 failed · 2 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 2 screenshots taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9301b49ac67e91b548c24f8163b420ba8c5b6a31
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (236)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## fix/tidy-stack-review #22178 +/- ##
=========================================================
- Coverage 87.29% 86.79% -0.51%
=========================================================
Files 2952 2920 -32
Lines 159558 158344 -1214
Branches 42475 41157 -1318
=========================================================
- Hits 139288 137435 -1853
- Misses 19400 20205 +805
+ Partials 870 704 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 303 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
Panel: 6/6 reviewers contributed findings.
…on two editable nodes Tidy up and the align button now clear their open state when they unmount, so a toolbox that hides on drag start does not bring a bar back open, unlifted and without a Tidy up session. useNodeArrangement exposes canArrange: the canvas is editable and at least two nodes are selected. It disables the align button, its options and the Arrange submenu's align and distribute items, the way canTidy gates Tidy up.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 2 — ledger: 3 prior finding(s) across 1 round(s) (0 never answered).
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40791543695 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.png` | modified | 52467B -> 52725B | | `browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png` | modified | 52938B -> 53287B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
3494e22 to
5974807
Compare
Summary
Stacks on #21612. The More Options menu merges Align Selected To and Distribute Nodes into one Arrange submenu: Tidy up, the four align options, then the two distribute options. The selection toolbox gets an align button beside Tidy up. The button opens the same six options as an icon row beneath the toolbox, and the toolbox lifts to make room, as the Tidy up gap bar does.
Decisions to review:
useNodeArrangement.ts. Tidy up and the align button shareSelectionToolboxBar.vueand the lift constants.{ type: 'divider' }entries, andNodeContextMenurenders them as separators.align-center-*).Design: Figma, design canvas.
Verification
pnpm test:uniton the selection toolbox,NodeContextMenu,composables/graphandselectionGrid: 369 passed. New tests:AlignButton.test.ts, bar switching and button visibility inSelectionToolbox.test.ts, and the Arrange submenu inNodeContextMenu.test.tsanduseSelectionMenuOptions.test.ts.aligns the selection to its top edge from the align bar and from More Optionspasses. It fails when the menu uses the old first-selected-node target. The updated align and distribute tests incontextMenuCoverage.spec.tspass.copy via More Options menuandshould open mask editor via context menufail on feat: tidy selected nodes and edit gaps (DES-1271) #21612 locally too (macOS paste shortcut, no example image in the scratch backend).selection-toolbox-multiple-nodes-borderandselection-toolbox-multiple-selections-borderchange because the toolbox has one more button. They need a rebaseline in CI.typecheck:appandtypecheck:browserpass.tools/architecture --checkpasses on Node 26.