Repository navigation
fix: remove icon enlargement transforms from dialog controls - #22169
Conversation
📦 Bundle: 11.9 MB gzip 🟢 -31 BDetailsSummary
Category Glance App Entry Points — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 872 kB (baseline 872 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 154 kB (baseline 154 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 3 added / 3 removed / 14 unchanged UI Components — 343 kB (baseline 343 kB) • ⚪ 0 BReusable component library chunks Status: 30 unchanged Data & Services — 1.83 MB (baseline 1.83 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 40 unchanged Utilities & Hooks — 2.44 MB (baseline 2.44 MB) • 🟢 -10 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed / 84 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🟢 -30 BBundles that do not match a named category
Status: 6 added / 6 removed / 738 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-28T22:26:39.087Z",
"gitSha": "fbda4970db1cd24eb87c27a4a93aeade9988e372",
"branch": "fix/unscaled-lucide-icons",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.50000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.86,
"layouts": 10,
"layoutDurationMs": 3.109,
"taskDurationMs": 532.299,
"heapDeltaBytes": 2075600,
"heapUsedBytes": 63712260,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.626999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.587000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.586,
"layouts": 9,
"layoutDurationMs": 2.3150000000000004,
"taskDurationMs": 552.267,
"heapDeltaBytes": 1450692,
"heapUsedBytes": 63317032,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.608999999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.988999999999999,
"layouts": 9,
"layoutDurationMs": 2.195,
"taskDurationMs": 882.36,
"heapDeltaBytes": -2361220,
"heapUsedBytes": 67662908,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 161.603,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.0309999999672,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.622000000000002,
"layouts": 10,
"layoutDurationMs": 2.992,
"taskDurationMs": 906.5430000000001,
"heapDeltaBytes": -1783804,
"heapUsedBytes": 68257544,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 165.267,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.2940000000103,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.053999999999999,
"layouts": 9,
"layoutDurationMs": 2.5,
"taskDurationMs": 413.40600000000006,
"heapDeltaBytes": 990544,
"heapUsedBytes": 70720472,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.886999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0829999999269,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.769999999999999,
"layouts": 11,
"layoutDurationMs": 2.903,
"taskDurationMs": 397.726,
"heapDeltaBytes": -896428,
"heapUsedBytes": 60149712,
"domNodes": 57,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.095,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 713.9769999999999,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1210000000000004,
"layouts": 9,
"layoutDurationMs": 2.78,
"taskDurationMs": 505.82300000000004,
"heapDeltaBytes": 3421972,
"heapUsedBytes": 64738840,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 172.93999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666657,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.5609999999115,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.122,
"layouts": 9,
"layoutDurationMs": 2.6359999999999997,
"taskDurationMs": 499.418,
"heapDeltaBytes": 7571832,
"heapUsedBytes": 77552340,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 169.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.8969999999886,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.8479999999998,
"heapDeltaBytes": -12552996,
"heapUsedBytes": 75037556,
"domNodes": -203,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 72.77300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 535,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.4180000000233,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 909.646,
"heapDeltaBytes": -895456,
"heapUsedBytes": 75640816,
"domNodes": -203,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 74.69,
"eventListeners": -106,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.015789473684194,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.8660000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.6900000000002,
"heapDeltaBytes": -17860256,
"heapUsedBytes": 77275428,
"domNodes": -203,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 161.99799999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 258,
"frameDurationMs": 25.714285714285687,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 906.5309999999727,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.9750000000001,
"heapDeltaBytes": -28573884,
"heapUsedBytes": 66508820,
"domNodes": -203,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 171.99599999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 229,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11481.728000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10618.779,
"heapDeltaBytes": 77522968,
"heapUsedBytes": 159469696,
"domNodes": -269,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 8558.411,
"eventListeners": -68,
"totalBlockingTimeMs": 1493,
"frameDurationMs": 32.43971830985915,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11072.451999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10312.116,
"heapDeltaBytes": 63197040,
"heapUsedBytes": 142862476,
"domNodes": -269,
"jsHeapTotalBytes": 76410880,
"scriptDurationMs": 8335.221,
"eventListeners": -68,
"totalBlockingTimeMs": 1302,
"frameDurationMs": 31.799425287356318,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11160.11900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10428.246,
"heapDeltaBytes": 53980508,
"heapUsedBytes": 148028072,
"domNodes": -269,
"jsHeapTotalBytes": 71168000,
"scriptDurationMs": 8390.854000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1492,
"frameDurationMs": 31.81225071225071,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9628.632999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8819.927,
"heapDeltaBytes": 67999940,
"heapUsedBytes": 147067208,
"domNodes": -269,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 7292.789,
"eventListeners": -68,
"totalBlockingTimeMs": 811,
"frameDurationMs": 31.480718954248367,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 223.5680000000002,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.362,
"layouts": 8,
"layoutDurationMs": 2.4430000000000005,
"taskDurationMs": 159.77400000000003,
"heapDeltaBytes": 14524528,
"heapUsedBytes": 73345676,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.018,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-combo-open",
"durationMs": 224.81699999991633,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.977000000000002,
"layouts": 9,
"layoutDurationMs": 3.2880000000000003,
"taskDurationMs": 175.697,
"heapDeltaBytes": 14634172,
"heapUsedBytes": 74601044,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.241000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.20000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2040.789000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4749999999999996,
"layouts": 8,
"layoutDurationMs": 2.438,
"taskDurationMs": 640.0709999999999,
"heapDeltaBytes": -28013576,
"heapUsedBytes": 59955164,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 31.163000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.3460000000423,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.667,
"layouts": 5,
"layoutDurationMs": 1.945,
"taskDurationMs": 678.3529999999998,
"heapDeltaBytes": -19559760,
"heapUsedBytes": 69792684,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.273999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2589.9220000000014,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.425,
"layouts": 7,
"layoutDurationMs": 1.8460000000000003,
"taskDurationMs": 1746.6000000000001,
"heapDeltaBytes": -4382932,
"heapUsedBytes": 85019292,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 842.1890000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666025641025644,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2535.1670000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.489,
"layouts": 7,
"layoutDurationMs": 1.722,
"taskDurationMs": 1737.7699999999998,
"heapDeltaBytes": -5393952,
"heapUsedBytes": 86343380,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 830.9989999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666225165562913,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3700.5659999999807,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.378999999999998,
"layouts": 63,
"layoutDurationMs": 10.388000000000002,
"taskDurationMs": 1771.658,
"heapDeltaBytes": 6438484,
"heapUsedBytes": 83039828,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 804.7449999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665315315315315,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3692.0310000000427,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.454,
"layouts": 64,
"layoutDurationMs": 10.764999999999999,
"taskDurationMs": 1757.9320000000002,
"heapDeltaBytes": 6774628,
"heapUsedBytes": 96513944,
"domNodes": 24,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 797.9730000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3151.597000000038,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.526,
"layouts": 4,
"layoutDurationMs": 1.082,
"taskDurationMs": 1977.3710000000003,
"heapDeltaBytes": 22497856,
"heapUsedBytes": 95681180,
"domNodes": 0,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 999.082,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754787234042553,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3023.253000000068,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9620000000000015,
"layouts": 5,
"layoutDurationMs": 1.2830000000000004,
"taskDurationMs": 1949.034,
"heapDeltaBytes": 18595676,
"heapUsedBytes": 90329504,
"domNodes": 0,
"jsHeapTotalBytes": 2777088,
"scriptDurationMs": 961.427,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758333333333333,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3121.5649999999755,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9060000000000006,
"layouts": 6,
"layoutDurationMs": 1.7690000000000001,
"taskDurationMs": 819.6030000000001,
"heapDeltaBytes": -33147264,
"heapUsedBytes": 60017472,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 375.413,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3068.9319999999043,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7760000000000007,
"layouts": 6,
"layoutDurationMs": 1.7240000000000002,
"taskDurationMs": 806.8560000000001,
"heapDeltaBytes": -10669440,
"heapUsedBytes": 79035136,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 373.92900000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665760869565215,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.504999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.705999999999999,
"layouts": 9,
"layoutDurationMs": 3.888,
"taskDurationMs": 685.4420000000001,
"heapDeltaBytes": -16274604,
"heapUsedBytes": 74601104,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 33.091,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2042.2509999999647,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.987,
"layouts": 6,
"layoutDurationMs": 1.8789999999999996,
"taskDurationMs": 658.7950000000001,
"heapDeltaBytes": -26284692,
"heapUsedBytes": 63868060,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 34.772999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2771.386000000007,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.074000000000002,
"layouts": 7,
"layoutDurationMs": 1.8620000000000003,
"taskDurationMs": 594.928,
"heapDeltaBytes": -9414236,
"heapUsedBytes": 80964848,
"domNodes": -263,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 190.34099999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2734.835999999973,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.546000000000001,
"layouts": 7,
"layoutDurationMs": 2.1750000000000003,
"taskDurationMs": 560.53,
"heapDeltaBytes": 4936932,
"heapUsedBytes": 94464940,
"domNodes": 19,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 191.15300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3279.855999999995,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.3969999999999998,
"layouts": 5,
"layoutDurationMs": 1.343,
"taskDurationMs": 964.3089999999999,
"heapDeltaBytes": -10064304,
"heapUsedBytes": 65773208,
"domNodes": -269,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 374.98400000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751282051282054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3316.3450000000694,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.895,
"layouts": 7,
"layoutDurationMs": 1.7000000000000002,
"taskDurationMs": 974.4549999999999,
"heapDeltaBytes": -28047864,
"heapUsedBytes": 64932064,
"domNodes": -269,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 399.66200000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666161616161617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.315000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.647000000000001,
"layouts": 9,
"layoutDurationMs": 2.33,
"taskDurationMs": 459.4,
"heapDeltaBytes": -208996,
"heapUsedBytes": 62765724,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 148.998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.068000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.567999999999999,
"layouts": 9,
"layoutDurationMs": 2.157,
"taskDurationMs": 437.066,
"heapDeltaBytes": -1932108,
"heapUsedBytes": 60710788,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 143.819,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.756000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4299999999999997,
"layouts": 8,
"layoutDurationMs": 2.4179999999999997,
"taskDurationMs": 521.1850000000001,
"heapDeltaBytes": 1464816,
"heapUsedBytes": 63557120,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.686999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.085000000051,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.68,
"layouts": 8,
"layoutDurationMs": 2.384,
"taskDurationMs": 586.2539999999999,
"heapDeltaBytes": 1518004,
"heapUsedBytes": 63889692,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.822999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1769999999542,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.171,
"layouts": 10,
"layoutDurationMs": 2.863,
"taskDurationMs": 840.6289999999999,
"heapDeltaBytes": -5462084,
"heapUsedBytes": 67106028,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 110.53,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5569999999516,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.99,
"layouts": 10,
"layoutDurationMs": 2.998,
"taskDurationMs": 870.7969999999999,
"heapDeltaBytes": 17326088,
"heapUsedBytes": 79583116,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 115.06,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.748999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.301000000000002,
"layouts": 5,
"layoutDurationMs": 14.404,
"taskDurationMs": 1085.243,
"heapDeltaBytes": 38034140,
"heapUsedBytes": 114676572,
"domNodes": 16029,
"jsHeapTotalBytes": 6950912,
"scriptDurationMs": 41.74100000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 155,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9076.558999999976,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.947000000000003,
"layouts": 8,
"layoutDurationMs": 2.2230000000000003,
"taskDurationMs": 5930.362000000001,
"heapDeltaBytes": -2212244,
"heapUsedBytes": 71414268,
"domNodes": -269,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2711.596,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69668508287293,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9408.676000000014,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.694000000000003,
"layouts": 8,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 6112.3460000000005,
"heapDeltaBytes": -5575200,
"heapUsedBytes": 82478980,
"domNodes": -269,
"jsHeapTotalBytes": 4026368,
"scriptDurationMs": 2872.4,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23241.546000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22623.213,
"heapDeltaBytes": -20600956,
"heapUsedBytes": 258201292,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 345.733,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.84991423670669,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23142.301999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22638.103000000003,
"heapDeltaBytes": 3276192,
"heapUsedBytes": 285988808,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 304.108,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.37085514834206,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 27865.143000000047,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.66799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27500.628,
"heapDeltaBytes": -14531532,
"heapUsedBytes": 263122812,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 882.0340000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 50.94241316270567,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28104.24499999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.716000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27661.989999999994,
"heapDeltaBytes": -6105428,
"heapUsedBytes": 271008792,
"domNodes": -3343,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 892.787,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 51.93881700554528,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8226.792000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.75099999999998,
"layouts": 20,
"layoutDurationMs": 20.90700000000001,
"taskDurationMs": 8085.913999999999,
"heapDeltaBytes": -23175388,
"heapUsedBytes": 254009564,
"domNodes": -3343,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 124.269,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.0485380116959,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8241.678999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.17,
"layouts": 20,
"layoutDurationMs": 21.408000000000012,
"taskDurationMs": 8115.010000000002,
"heapDeltaBytes": 5385504,
"heapUsedBytes": 282470296,
"domNodes": -3342,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 122.51799999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.86627906976743,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11378.571999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11133.583000000002,
"heapDeltaBytes": -4996356,
"heapUsedBytes": 253761612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.134,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.59357142857143,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11463.728999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11144.023000000001,
"heapDeltaBytes": 3534804,
"heapUsedBytes": 255835928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.49900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.745551601423486,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 138.2820000000038,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.188,
"layouts": 10,
"layoutDurationMs": 4.081,
"taskDurationMs": 104.303,
"heapDeltaBytes": 4941960,
"heapUsedBytes": 64745436,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.920000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 561.8849999999611,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.085999999999999,
"layouts": 12,
"layoutDurationMs": 4.705000000000001,
"taskDurationMs": 148.84600000000003,
"heapDeltaBytes": 6908788,
"heapUsedBytes": 67033000,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.155000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 438.48800000000665,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.63,
"layouts": 76,
"layoutDurationMs": 14.194999999999999,
"taskDurationMs": 391.481,
"heapDeltaBytes": -4786960,
"heapUsedBytes": 39618844,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 187.98999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.3790000000463,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.656,
"layouts": 76,
"layoutDurationMs": 14.155,
"taskDurationMs": 424.705,
"heapDeltaBytes": -4430588,
"heapUsedBytes": 41026424,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 202.592,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 440.6429999999091,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.536,
"layouts": 76,
"layoutDurationMs": 13.710999999999999,
"taskDurationMs": 403.619,
"heapDeltaBytes": -999120,
"heapUsedBytes": 92915476,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.468,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 662.6520000000937,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.564,
"layouts": 76,
"layoutDurationMs": 15.796999999999999,
"taskDurationMs": 612.769,
"heapDeltaBytes": 1433124,
"heapUsedBytes": 92307076,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 262.574,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3157 passed, 0 failed · 1 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 9 screenshots taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (18 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9458ec900a2dce532bffbcd79164ebe48715de38
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (271)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 9
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
| Layer / File(s) | Summary |
|---|---|
Remove icon scaling classes packages/design-system/src/components/layout/BaseModalLayout.vue, src/platform/account/components/CurrentUserPopoverWorkspace.vue, src/renderer/extensions/maskEditor/components/dialog/TopBarHeader.vue |
The default modal close icon and workspace-switcher chevron lose scale-150. The mask-editor save and cancel icons lose scale-125 and scale-150, respectively. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related issues
- Comfy-Org/ComfyUI_frontend issue 16724: The mask-editor icon class changes affect glyph rendering in the same dialog covered by the issue’s screenshot tolerance objective.
Suggested reviewers: christian-byrne
Merge Risk: 
Minimal · previous review a5741
-
The scoped visual adjustment is ready to merge.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
packages/design-system/src/components/layout/BaseModalLayout.vue,src/platform/account/components/CurrentUserPopoverWorkspace.vue, andsrc/renderer/extensions/maskEditor/components/dialog/TopBarHeader.vue. None are undersrc/lib/litegraph/,src/ecs/, or graph-entity-related paths. The ADR compliance check is not applicable.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
Suggestion only, not a merge requirement. The PR changes user-facing icon sizing in
src/andpackages/: users can open the workspace switcher, a modal, or the mask editor and see the affected controls. The available changed-file list contains no added or updated spec underbrowser_tests/.Resolution
Add or extend an existing spec under
browser_tests/: - Open the workspace switcher and verify that the chevron is not enlarged. - Open a modal and verify that the close icon is not enlarged. - Open the mask editor and verify that the Save icon is not enlarged. - Open the mask editor and verify that the Cancel icon is not enlarged.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22169 +/- ##
==========================================
- Coverage 87.52% 87.47% -0.06%
==========================================
Files 2924 2922 -2
Lines 158748 158438 -310
Branches 41571 43451 +1880
==========================================
- Hits 138951 138587 -364
- Misses 18876 18930 +54
Partials 921 921
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40774571252 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/currentUserPopoverCredits.spec.ts-snapshots/workspace-selector-menu-item-cloud-linux.png` | modified | 2762B -> 2723B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-2xl-chromium-linux.png` | modified | 36103B -> 35980B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 34949B -> 34834B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-md-chromium-linux.png` | modified | 22964B -> 22887B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-mobile-chromium-linux.png` | modified | 22794B -> 22692B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-sm-chromium-linux.png` | modified | 22726B -> 22592B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-wide-chromium-linux.png` | modified | 35485B -> 35358B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-xl-chromium-linux.png` | modified | 34502B -> 34376B | | `browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png` | modified | 21717B -> 21566B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Summary
Remove enlargement transforms from the workspace chevron, modal close icon, and mask-editor Save/Cancel icons. Keep explicit dimensions and shared icon defaults, along with the accepted sidebar
scale-90adjustment.Follow-up to #22084, addressing the sizing feedback.
Verification
Reversible styling change. Risk is limited to icon appearance and visual baselines.