Skip to content

docs: standardize icon docs on Lucide - #22164

Merged
DrJKL merged 1 commit into
docs/icon-sizing-and-deprecationsfrom
docs/icons-lucide-only
Oct 28, 2026
Merged

DrJKL merged 1 commit into
docs/icon-sizing-and-deprecationsfrom
docs/icons-lucide-only

Conversation

@DrJKL

@DrJKL DrJKL commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #22163. Standardizes the icon docs on Lucide as the only third-party icon set.

 ### 1. Lucide Icons
   <i class="icon-[lucide--download]" />
-  <i-heroicons:document-text />
-  <i-tabler:brand-github />
-  <i-carbon:cloud-upload />
-## Using Iconify Icons / Popular Collections
+## Finding Lucide Icons
-## Adding Icon Collections
  • Icons README: removes the Heroicons, Tabler, and Carbon examples, the "Popular Collections" list, the "Adding Icon Collections" guide, and the Iconify browser links. "Finding Lucide Icons" points to lucide.dev and the icon-[lucide--<name>] form.
  • CONTRIBUTING: lists Lucide as the only third-party set and says not to add icons from other sets.

Evidence

  • oxfmt --check passes on both files; no remaining references to Heroicons, Tabler, Carbon, or the Iconify icon browser besides the "don't add" note.

Merge Danger

Door: two-way

Blast Radius: docs

Drop the Heroicons, Tabler, and Carbon examples, the popular collections
list, and the guide to adding icon collections, so the docs present
Lucide as the only third-party icon set.

Amp-Thread-ID: https://ampcode.com/threads/T-d71d9cc0-669b-431c-9298-fc9aa13cecf2
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2a5df78 and 37cc383.

Files selected for processing: 2
  • CONTRIBUTING.md
  • packages/design-system/src/icons/README.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The contribution guide and design-system icon README now identify Lucide as the supported third-party icon set. The README updates its quick-start and icon-finding guidance and removes instructions for adding icon collections.

Changes: Icon guidance

Layer / File(s) Summary
Document Lucide icon policy
CONTRIBUTING.md, packages/design-system/src/icons/README.md
The guides identify Lucide as the supported third-party icon set. The README updates its examples and icon-finding format, and removes instructions for adding icon collections.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Suggested reviewers: christian-byrne, ltdrdata

Merge Risk: Minimal · up to 37cc3

The documentation updates are mergeable with no identified runtime or compatibility risk.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title "docs: standardize icon docs on Lucide" matches the main change. The PR makes Lucide the only third-party icon set in the icon docs and removes the Heroicons, Tabler, and Carbon examples, th…
Description check Passed The description follows the template's Summary section. It states the purpose in one line and gives a diff of the removed and added content. It also explains the changes to the icons README and CONTRI…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed The changed files are CONTRIBUTING.md and packages/design-system/src/icons/README.md. The diff changes documentation only. It does not change frontend behavior or add a user-facing feature, so an end-…
Adr Compliance For Entity/Litegraph Changes Passed The changed files are CONTRIBUTING.md and packages/design-system/src/icons/README.md. None are under src/lib/litegraph/, src/ecs/, or graph-entity-related paths. The ADR compliance check does …
Full details: Title check

Explanation

The title "docs: standardize icon docs on Lucide" matches the main change. The PR makes Lucide the only third-party icon set in the icon docs and removes the Heroicons, Tabler, and Carbon examples, the popular collections list, the adding-collections guide, and Iconify browser links. The title is short, specific, and follows a conventional docs prefix.

Full details: Description check

Explanation

The description follows the template's Summary section. It states the purpose in one line and gives a diff of the removed and added content. It also explains the changes to the icons README and CONTRIBUTING.md, and it lists verification evidence (oxfmt --check passes, and no remaining references to the removed sets). The template's Verification section is covered by the Evidence section, though it does not describe tests or human QA. The Summary does not include a 'Fixes #' line, which is appropriate for a docs change with no linked issue. The description also notes it is stacked on #22163, which is useful context. Missing items are minor: a clearer statement of the problem being solved, and a note about whether the template's 'Fixes' line applies.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The changed files are CONTRIBUTING.md and packages/design-system/src/icons/README.md. The diff changes documentation only. It does not change frontend behavior or add a user-facing feature, so an end-to-end Playwright test is not suggested.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed files are CONTRIBUTING.md and packages/design-system/src/icons/README.md. None are under src/lib/litegraph/, src/ecs/, or graph-entity-related paths. The ADR compliance check does not apply.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/28/2026, 08:51:29 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2a5df78fb2b0b83b8e96d3f6b14b6df76033ce3d

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (268)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/concatSegmentPreviews.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/concatSegmentPreviews.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/linkedConcatSlots.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/syncConcatOrderWithLinks.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/syncConcatOrderWithLinks.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useClipStripReorder.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useSequencePlayback.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useSequencePlayback.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useVideoConcatClips.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useVideoConcatClips.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useVideoConcatOrder.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/useVideoConcatOrder.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/videoConcatOrder.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/videoConcatOrder.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/videoSequence.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/videoConcat/videoSequence.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/autogrowConvertToSubgraph.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicInputsConvertToSubgraph.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 218 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                        Coverage Diff                         @@
##           docs/icon-sizing-and-deprecations   #22164   +/-   ##
==================================================================
  Coverage                              87.55%   87.55%           
==================================================================
  Files                                   2920     2920           
  Lines                                 158769   158769           
  Branches                               41702    41702           
==================================================================
  Hits                                  139007   139007           
  Misses                                 18886    18886           
  Partials                                 876      876           
Flag Coverage Δ
billing-web-unit 92.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL added this pull request to stack #22165 October 28, 2026 20:51
@DrJKL
DrJKL enabled stacked auto-merge October 28, 2026 20:52
@DrJKL
DrJKL added this pull request to the merge queue Oct 28, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 28, 2026
Merged via the queue into main with commit 2e0dc2c Oct 28, 2026
83 checks passed
@DrJKL
DrJKL deleted the docs/icons-lucide-only branch October 28, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants