Repository navigation
docs: standardize icon docs on Lucide - #22164
Conversation
Drop the Heroicons, Tabler, and Carbon examples, the popular collections list, and the guide to adding icon collections, so the docs present Lucide as the only third-party icon set. Amp-Thread-ID: https://ampcode.com/threads/T-d71d9cc0-669b-431c-9298-fc9aa13cecf2
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Document Lucide icon policy CONTRIBUTING.md, packages/design-system/src/icons/README.md |
The guides identify Lucide as the supported third-party icon set. The README updates its examples and icon-finding format, and removes instructions for adding icon collections. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#22084: Migrates first-party PrimeIcons to Lucide; this PR documents Lucide as the supported third-party icon set.
- Comfy-Org/ComfyUI_frontend#22163: Also updates icon documentation.
Suggested reviewers: christian-byrne, ltdrdata
Merge Risk: 
Minimal · up to 37cc3
-
The documentation updates are mergeable with no identified runtime or compatibility risk.
Pre-merge checks: 
6
-
Full details: Title check
-
Explanation
The title "docs: standardize icon docs on Lucide" matches the main change. The PR makes Lucide the only third-party icon set in the icon docs and removes the Heroicons, Tabler, and Carbon examples, the popular collections list, the adding-collections guide, and Iconify browser links. The title is short, specific, and follows a conventional docs prefix.
Full details: Description check
-
Explanation
The description follows the template's Summary section. It states the purpose in one line and gives a diff of the removed and added content. It also explains the changes to the icons README and CONTRIBUTING.md, and it lists verification evidence (oxfmt --check passes, and no remaining references to the removed sets). The template's Verification section is covered by the Evidence section, though it does not describe tests or human QA. The Summary does not include a 'Fixes #' line, which is appropriate for a docs change with no linked issue. The description also notes it is stacked on
#22163, which is useful context. Missing items are minor: a clearer statement of the problem being solved, and a note about whether the template's 'Fixes' line applies.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The changed files are CONTRIBUTING.md and packages/design-system/src/icons/README.md. The diff changes documentation only. It does not change frontend behavior or add a user-facing feature, so an end-to-end Playwright test is not suggested.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
CONTRIBUTING.mdandpackages/design-system/src/icons/README.md. None are undersrc/lib/litegraph/,src/ecs/, or graph-entity-related paths. The ADR compliance check does not apply.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2a5df78fb2b0b83b8e96d3f6b14b6df76033ce3d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (268)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## docs/icon-sizing-and-deprecations #22164 +/- ##
==================================================================
Coverage 87.55% 87.55%
==================================================================
Files 2920 2920
Lines 158769 158769
Branches 41702 41702
==================================================================
Hits 139007 139007
Misses 18886 18886
Partials 876 876
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Stacked on #22163. Standardizes the icon docs on Lucide as the only third-party icon set.
icon-[lucide--<name>]form.Evidence
oxfmt --checkpasses on both files; no remaining references to Heroicons, Tabler, Carbon, or the Iconify icon browser besides the "don't add" note.Merge Danger
Door: two-way
Blast Radius: docs