Repository navigation
[backport cloud/1.58] fix: keep agent-written option ids out of superseded-answer telemetry - #22115
Conversation
…#21327) ## ELI5 When an answer to one of the agent's questions gets overridden by an answer given somewhere else, we log an error. That error used to include the agent's own option text, which could contain parts of the user's prompt and split identical errors into thousands of separate buckets. Now it logs a fixed message plus how many options each answer picked, whether the picked options, the typed text, or both changed, and whether the server said which options won at all. ## Summary `agent_ask_answer_superseded` built its `Error` message from the raw option ids of both answers. `ask_user` option ids are free-form text the agent writes, so the message could carry prompt-derived content, and each distinct id pair grouped as its own error. The message is now the fixed string `agent ask resolved with a different answer`, and the detail moves into bounded tags: `committed_selected_count` / `submitted_selected_count`, plus `selection_changed` / `other_text_changed` booleans from the same comparison that decides supersession, so a same-length selection change and a free-text-only change stay distinguishable. `selection_known` says whether the committed body carried a `selected` array; when it did not, `committed_selected_count` is omitted so "the server did not say" is not read as "the winner picked nothing". The user-facing "answered somewhere else" notice and the supersede detection are unchanged. Risk: telemetry only. A dashboard or alert that matches on the old `agent ask resolved as …` text needs the new message; grouping by `errorType` is unaffected. ## Verification - Rebased onto main after #21829 (free-text-only committed answers). Its "selection known" guard is kept: when the committed body carries no `selected` array, `selection_changed` is `false`, `selection_known` is `false` and `committed_selected_count` is omitted, and only `other_text_changed` can fire, so the report still matches main's supersede rule. - `useAgentSession.test.ts`: 275 pass (1 expected fail). `reports the answer the 202 committed when another one won` asserts the exact fixed message and all four tags; the run-approval superseded test asserts the tags; the table of superseding answers and the 409 free-text-only test (null and missing `selected`) asserts the full tag set, including `selection_known: false` and no committed count. - `pnpm typecheck`, oxfmt, oxlint, eslint: clean. - Doc-drift sweep: no doc, fixture or spec quotes the old message, the `agent_ask_answer_superseded` slug or the new tag names. The other matches were generic `agent`/`reportError` mentions. ## Provenance - **Authored by:** agent-work loop - **Verified:** - Rebased onto current main; the merge with main's free-text-only guard keeps both behaviours - `useAgentSession.test.ts` 275 pass at head, including the exact-message, change-tag and `selection_known` assertions - The updated superseded tests failed against the old message code - `pnpm typecheck`, oxfmt, oxlint and eslint are clean at head - Doc-drift sweep: nothing outside the changed code mentions the message, slug or tag names - **Deviations:** - The ticket gives "ask kind" as an example field. I left it out because the report site only has the ask id and the resolution, not the card type, so adding it would mean a new store lookup just for telemetry. I added the selected-id counts and the two change booleans (the booleans came from review). ## Residual - The ask kind (run approval vs `ask_user`) is not on the report. Adding it would need a lookup of the card type by ask id at the report site. - I could not see any dashboards or alerts that match on the old message text. Whoever owns agent error monitoring should check them.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-28T02:47:00.994Z",
"gitSha": "816fba2e07dcbc9b938f5820ce2382b22f1a0b9a",
"branch": "backport-21327-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.4219999999918,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.125,
"layouts": 9,
"layoutDurationMs": 2.893,
"taskDurationMs": 516.8620000000001,
"heapDeltaBytes": 3596436,
"heapUsedBytes": 94379616,
"domNodes": -200,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 14.192,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2042.116999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.182,
"layouts": 9,
"layoutDurationMs": 3.434,
"taskDurationMs": 554.407,
"heapDeltaBytes": 3089824,
"heapUsedBytes": 93446888,
"domNodes": -200,
"jsHeapTotalBytes": 581632,
"scriptDurationMs": 15.355,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.683000000002,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.722000000000001,
"layouts": 10,
"layoutDurationMs": 3.653,
"taskDurationMs": 845.4929999999999,
"heapDeltaBytes": 8099520,
"heapUsedBytes": 97910592,
"domNodes": -180,
"jsHeapTotalBytes": 1892352,
"scriptDurationMs": 170.402,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.188999999933,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.232,
"layouts": 9,
"layoutDurationMs": 3.249,
"taskDurationMs": 904.8119999999999,
"heapDeltaBytes": 1632888,
"heapUsedBytes": 92481992,
"domNodes": -200,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 177.722,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.466000000034,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.136,
"layouts": 11,
"layoutDurationMs": 3.6369999999999996,
"taskDurationMs": 390.09399999999994,
"heapDeltaBytes": 25442236,
"heapUsedBytes": 115185924,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 16.597,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6890000000358,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.555000000000001,
"layouts": 10,
"layoutDurationMs": 3.1429999999999993,
"taskDurationMs": 392.19800000000004,
"heapDeltaBytes": 24152288,
"heapUsedBytes": 113967856,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.302999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.789999999992,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1060000000000003,
"layouts": 9,
"layoutDurationMs": 2.757,
"taskDurationMs": 477.6980000000001,
"heapDeltaBytes": 4225144,
"heapUsedBytes": 94403240,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 177.57600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.5919999999569,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9229999999999996,
"layouts": 9,
"layoutDurationMs": 2.5359999999999996,
"taskDurationMs": 477.947,
"heapDeltaBytes": 5770632,
"heapUsedBytes": 96857064,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 177.648,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1215.233000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.537,
"heapDeltaBytes": -14882160,
"heapUsedBytes": 102600076,
"domNodes": -230,
"jsHeapTotalBytes": 16056320,
"scriptDurationMs": 70.39599999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 527,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1325.8900000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1029.1549999999997,
"heapDeltaBytes": -15082220,
"heapUsedBytes": 102470432,
"domNodes": -230,
"jsHeapTotalBytes": 16056320,
"scriptDurationMs": 76.337,
"eventListeners": -168,
"totalBlockingTimeMs": 630,
"frameDurationMs": 35.583783783783794,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.5620000000113,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.40299999999957,
"heapDeltaBytes": -3525780,
"heapUsedBytes": 97875836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 177.064,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.7509999999838,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.51199999999994,
"heapDeltaBytes": -2064596,
"heapUsedBytes": 98288416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.74599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10289.153999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9414.698000000002,
"heapDeltaBytes": 24225364,
"heapUsedBytes": 138059916,
"domNodes": -276,
"jsHeapTotalBytes": 26103808,
"scriptDurationMs": 7780.599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1189,
"frameDurationMs": 32.33647798742138,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11366.443000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10569.556,
"heapDeltaBytes": 43881440,
"heapUsedBytes": 148216580,
"domNodes": -296,
"jsHeapTotalBytes": 46718976,
"scriptDurationMs": 8412.599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1151,
"frameDurationMs": 31.352209944751376,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11272.658999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10477.927,
"heapDeltaBytes": 58311548,
"heapUsedBytes": 162565040,
"domNodes": -296,
"jsHeapTotalBytes": 47767552,
"scriptDurationMs": 8444.590999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1420,
"frameDurationMs": 31.5577030812325,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11769.313000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10890.833,
"heapDeltaBytes": 48333464,
"heapUsedBytes": 152721464,
"domNodes": -276,
"jsHeapTotalBytes": 51699712,
"scriptDurationMs": 9066.303000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 1835,
"frameDurationMs": 33.763218390804596,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 260.09100000001695,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.969,
"layouts": 11,
"layoutDurationMs": 3.409,
"taskDurationMs": 211.376,
"heapDeltaBytes": 15470940,
"heapUsedBytes": 120877880,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.126,
"eventListeners": 196,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25.75454545454539,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 224.86100000003262,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.221,
"layouts": 11,
"layoutDurationMs": 3.44,
"taskDurationMs": 177.76299999999998,
"heapDeltaBytes": 13273920,
"heapUsedBytes": 119438688,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.139999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2073.9399999999932,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.019,
"layouts": 8,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 643.0419999999999,
"heapDeltaBytes": 1431852,
"heapUsedBytes": 111754632,
"domNodes": -276,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 41.051,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2073.556999999937,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.828,
"layouts": 8,
"layoutDurationMs": 2.4680000000000004,
"taskDurationMs": 814.1800000000001,
"heapDeltaBytes": 1030004,
"heapUsedBytes": 110838352,
"domNodes": -276,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 39.596999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2295.368999999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.511000000000001,
"layouts": 6,
"layoutDurationMs": 1.7020000000000004,
"taskDurationMs": 1634.043,
"heapDeltaBytes": 1210512,
"heapUsedBytes": 112768848,
"domNodes": -277,
"jsHeapTotalBytes": -1028096,
"scriptDurationMs": 853.213,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786861313868613,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2884.5790000000306,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.117,
"layouts": 5,
"layoutDurationMs": 1.581,
"taskDurationMs": 1922.259,
"heapDeltaBytes": -24301216,
"heapUsedBytes": 87166536,
"domNodes": -296,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 924.636,
"eventListeners": -128,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.060355029585804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3962.34800000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.622000000000002,
"layouts": 64,
"layoutDurationMs": 11.647,
"taskDurationMs": 1990.825,
"heapDeltaBytes": -2672196,
"heapUsedBytes": 110793004,
"domNodes": -278,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 838.759,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.736286919831223,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4028.4689999999728,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.421,
"layouts": 63,
"layoutDurationMs": 11.124,
"taskDurationMs": 1974.4099999999999,
"heapDeltaBytes": -24874788,
"heapUsedBytes": 88143620,
"domNodes": -272,
"jsHeapTotalBytes": -73728,
"scriptDurationMs": 842.4730000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3186.7239999999697,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.510999999999999,
"layouts": 4,
"layoutDurationMs": 1.35,
"taskDurationMs": 1961.607,
"heapDeltaBytes": 19320988,
"heapUsedBytes": 122154056,
"domNodes": 0,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 1037.175,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93068783068783,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3364.695999999981,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.359,
"layouts": 4,
"layoutDurationMs": 1.163,
"taskDurationMs": 2320.031,
"heapDeltaBytes": -4536408,
"heapUsedBytes": 112643384,
"domNodes": -296,
"jsHeapTotalBytes": 1748992,
"scriptDurationMs": 1122.403,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.917085427135678,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2068.804,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9459999999999997,
"layouts": 5,
"layoutDurationMs": 1.8770000000000002,
"taskDurationMs": 816.9110000000001,
"heapDeltaBytes": 143428,
"heapUsedBytes": 112994856,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 41.75899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2073.2639999999947,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4739999999999998,
"layouts": 6,
"layoutDurationMs": 1.964,
"taskDurationMs": 835.9280000000001,
"heapDeltaBytes": -5811140,
"heapUsedBytes": 99644776,
"domNodes": -296,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 46.77199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 697.1739999999613,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.66,
"layouts": 8,
"layoutDurationMs": 2.829,
"taskDurationMs": 481.977,
"heapDeltaBytes": 2194844,
"heapUsedBytes": 102686540,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 155.398,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.492000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.789999999999999,
"layouts": 8,
"layoutDurationMs": 2.3000000000000003,
"taskDurationMs": 424.565,
"heapDeltaBytes": -1033844,
"heapUsedBytes": 89896060,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 157.742,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2054.7859999999787,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0949999999999998,
"layouts": 8,
"layoutDurationMs": 3.036,
"taskDurationMs": 550.6560000000001,
"heapDeltaBytes": 5816308,
"heapUsedBytes": 97120944,
"domNodes": -218,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 14.298,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.9839999999804,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.594,
"layouts": 9,
"layoutDurationMs": 3.164,
"taskDurationMs": 551.823,
"heapDeltaBytes": 6655512,
"heapUsedBytes": 98013792,
"domNodes": -218,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 13.876999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1845.0229999999692,
"styleRecalcs": 57,
"styleRecalcDurationMs": 14.346999999999998,
"layouts": 7,
"layoutDurationMs": 3.103,
"taskDurationMs": 920.1450000000001,
"heapDeltaBytes": 4768144,
"heapUsedBytes": 95752820,
"domNodes": -190,
"jsHeapTotalBytes": 2940928,
"scriptDurationMs": 124.887,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.706000000061,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.953000000000001,
"layouts": 9,
"layoutDurationMs": 2.9259999999999997,
"taskDurationMs": 987.454,
"heapDeltaBytes": -13609188,
"heapUsedBytes": 87249568,
"domNodes": -190,
"jsHeapTotalBytes": 7933952,
"scriptDurationMs": 124.42500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1536.0689999999977,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.782999999999998,
"layouts": 5,
"layoutDurationMs": 17.950999999999997,
"taskDurationMs": 1247.712,
"heapDeltaBytes": 37892112,
"heapUsedBytes": 137447716,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 38.413,
"eventListeners": 3244,
"totalBlockingTimeMs": 200,
"frameDurationMs": 20.72162162162163,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 11098.797999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.471,
"layouts": 7,
"layoutDurationMs": 2.2079999999999997,
"taskDurationMs": 6824.641,
"heapDeltaBytes": 79498884,
"heapUsedBytes": 184224512,
"domNodes": -296,
"jsHeapTotalBytes": 62472192,
"scriptDurationMs": 3058.165,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666066066066065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10841.495999999894,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.75899999999999,
"layouts": 7,
"layoutDurationMs": 2.2869999999999995,
"taskDurationMs": 6619.779,
"heapDeltaBytes": -2665772,
"heapUsedBytes": 114191008,
"domNodes": -297,
"jsHeapTotalBytes": 24576,
"scriptDurationMs": 2890.372,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691692307692307,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16660.979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15873.708,
"heapDeltaBytes": -14926564,
"heapUsedBytes": 285372360,
"domNodes": -307,
"jsHeapTotalBytes": 26988544,
"scriptDurationMs": 250.43099999999995,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.63573883161512,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16926.462000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16259.478000000001,
"heapDeltaBytes": -25845160,
"heapUsedBytes": 282910136,
"domNodes": -3344,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 294.60699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.215889464594127,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 20638.71499999999,
"styleRecalcs": 157,
"styleRecalcDurationMs": 20.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20197.396,
"heapDeltaBytes": 4744812,
"heapUsedBytes": 309613188,
"domNodes": -3344,
"jsHeapTotalBytes": 16957440,
"scriptDurationMs": 905.6659999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 38.56523364485981,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20188.887000000024,
"styleRecalcs": 157,
"styleRecalcDurationMs": 20.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19845.889,
"heapDeltaBytes": -18820856,
"heapUsedBytes": 291287916,
"domNodes": -3344,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 896.654,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.26789667896679,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 8583.927000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.08200000000001,
"layouts": 20,
"layoutDurationMs": 26.09700000000001,
"taskDurationMs": 8479.151,
"heapDeltaBytes": -7720760,
"heapUsedBytes": 293688676,
"domNodes": -3344,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 134.702,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.488823529411754,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8580.083999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.867,
"layouts": 20,
"layoutDurationMs": 24.242999999999988,
"taskDurationMs": 8411.552,
"heapDeltaBytes": -22816104,
"heapUsedBytes": 282739344,
"domNodes": -3344,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 129.554,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.1252808988764,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11767.646000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11525.968000000003,
"heapDeltaBytes": -24678656,
"heapUsedBytes": 269682080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.65000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.51517241379311,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8288.79500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8037.132000000001,
"heapDeltaBytes": 14866556,
"heapUsedBytes": 289711792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.268,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.96153846153846,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 146.82200000004286,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.491999999999999,
"layouts": 8,
"layoutDurationMs": 4.465999999999999,
"taskDurationMs": 116.54100000000001,
"heapDeltaBytes": 4944292,
"heapUsedBytes": 95006684,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.858,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67777777777782,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 480.23700000010194,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.729,
"layouts": 11,
"layoutDurationMs": 5.119000000000001,
"taskDurationMs": 129.648,
"heapDeltaBytes": 6900928,
"heapUsedBytes": 97382164,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.100000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 617.0419999999694,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.882,
"layouts": 76,
"layoutDurationMs": 19.421999999999997,
"taskDurationMs": 575.5859999999999,
"heapDeltaBytes": 13313088,
"heapUsedBytes": 83375704,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 273.572,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 657.2740000000294,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.731,
"layouts": 76,
"layoutDurationMs": 19.558,
"taskDurationMs": 600.7739999999999,
"heapDeltaBytes": 13614200,
"heapUsedBytes": 86939104,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 288.529,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 703.5879999999679,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4090000000000003,
"layouts": 76,
"layoutDurationMs": 18.415,
"taskDurationMs": 660.7180000000001,
"heapDeltaBytes": 1492468,
"heapUsedBytes": 119161404,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 272.049,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 633.7379999999939,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.548,
"layouts": 76,
"layoutDurationMs": 16.552999999999997,
"taskDurationMs": 601.683,
"heapDeltaBytes": 1258340,
"heapUsedBytes": 118854476,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 238.86700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2987 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2b6a504b0287562689fd0ed9cecc0e2d8f281c85
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (131)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 1 finding(s).
| Severity | Count |
|---|---|
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
| ) { | ||
| return { | ||
| selection_changed: | ||
| selectionKnown && xor(submitted.selected, committed.selected).length > 0, |
There was a problem hiding this comment.
⚪ Nit — When the committed source has no selected array (selectionKnown is false), selection_changed is sent as false. That reads as "unchanged" when the real answer is "unknown". The selection_known tag can tell the two apart, but a dashboard filtering on selection_changed:false alone will count the null-selection and free-text-only cases as confirmed same-selection outcomes. Leaving selection_changed undefined in that case, as committed_selected_count already does, would keep the tag accurate on its own.
Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22115 +/- ##
=============================================
Coverage ? 85.95%
=============================================
Files ? 2595
Lines ? 135523
Branches ? 41393
=============================================
Hits ? 116495
Misses ? 18611
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Clean backport of #21327: the diff matches the main merge line for line. Required checks pass at this head.
Backport of #21327 to
cloud/1.58Automatically created by backport workflow.