Skip to content

[backport cloud/1.57] fix(agent): restore a completed turn's thinking on reload and chat switch (PM-717) (#21600) - #22105

Closed
christian-byrne wants to merge 2 commits into
cloud/1.57from
backport-21600-to-cloud-1.57
Closed

christian-byrne wants to merge 2 commits into
cloud/1.57from
backport-21600-to-cloud-1.57

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #21600 to cloud/1.57.

Full context for agent readers

Why this train. cloud/1.57 is a current Agent backport train and does not contain #21600 (merged to main as 5d44835). The backend half, Comfy-Org/cloud#14903, is already live on Comfy Cloud and in the local agent package, so the frontend is the missing piece for users on this train. Without the backend field the change is a no-op.

Conflicts (auto cherry-pick failed).

  • agentTranscript.ts: import specifiers only. This branch uses relative paths; kept them and added ThinkingPart / zPersistedThinkingEntry. Logic hunks applied cleanly.
  • agentToolCallHistoryPersistence.spec.ts: this branch already labels the restored Add node row as an unconfirmed canvas write (toolNotConfirmedOnCanvas). The expected trace keeps that label and adds the three thinking rows, matching upstream's order: thinking, Search nodes, thinking, Add node (unconfirmed), thinking.
  • agentApiSchema.ts, agentConversationStore.ts and both unit test files applied cleanly.

Verification. Local install/test runs were not possible on this host (it is heavily loaded; dependency install timed out), and the commit was pushed with hooks skipped for that reason. Hosted CI on this PR (lint-and-format, test, e2e) is the verification; the browser spec above is the red/green proof upstream (fails on the parent with only tool rows, passes with the fix).

…itch (PM-717) (#21600)

- Reopening a chat from history lost the thinking. Tool calls stayed.
- The transcript now restores `content.thinking` into the Worked trace,
each entry at its round.
- Needs Comfy-Org/cloud#14903 to persist the field. Until that lands
this is a no-op.

Tracks [PM-717](https://linear.app/comfyorg/issue/PM-717) (fresh Windows
QA report, case Q4: "Thinking and tool call summary survive a chat
switch").

<details><summary>Full context for agent readers</summary>

**Before.** `hydrate()` replaces the conversation with
`normalizeAgentTranscript(history)`. An assistant row contributed tool
parts from `content.tool_calls` (FE #18282) and its reply text, and
nothing else. The thinking the live turn streamed through
`agent_thinking` existed only in memory, so after New Chat → reopen, or
after a reload, the Worked trace showed tool rows only. That matches the
reporter's screenshots.

**After.** Comfy-Org/cloud#14903 stores each round's live thinking text
on the completed row:

```json
"thinking": [{ "text": "...", "tool_call_id": "call-1" }, { "text": "..." }]
```

`appendAssistantContent` restores each entry as a done `ThinkingPart` in
front of the tool part whose `callId` matches `tool_call_id`. An entry
with no anchor, or one whose call is not in the transcript, goes after
the calls and before the reply. Entries are parsed one at a time with
`zPersistedThinkingEntry.safeParse`. A malformed or blank entry is
skipped, and the row still loads. No rendering change:
`WorkSummary`/`ActivityTrace` already render thinking parts.

- **Black-box harness, red → green.**
`agentToolCallHistoryPersistence.spec.ts` now mocks the history row with
`content.thinking` (the cloud#14903 contract). It asserts the trace
reads `thinking, Search nodes, thinking, Add node, thinking` after a
reload and again after New Chat → reopen from history.
- On parent `7178296cf5`: **fails**. Received only `Search nodes, Add
node`.
  - On this head: **passes**.
- Unit: one new `agentTranscript.test.ts` case covers a malformed or
blank entry being skipped, and a missing-call anchor falling after the
calls.
- `vitest run src/workbench/extensions/agent/`: 178 files, 4038 passed,
1 expected fail.
- `pnpm typecheck`, eslint, oxfmt, pre-commit, pre-push (knip/fallow):
clean.
- Local setup: cloud-distribution dev server with
`VITE_USE_LEGACY_DEFAULT_GRAPH=true`, own backend container (ci image
0.0.28), `--project=cloud --retries=0`, Node 26.10, Chromium.
- Screenshots were inspected locally. Before: the expanded Worked trace
holds two tool rows and no thinking. After the chat switch: thinking
rows sit between and after the tool rows, and the layout is intact.

</details>

(cherry picked from commit 5d44835)
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 28, 2026
@christian-byrne christian-byrne self-assigned this Oct 28, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 28, 2026 01:27
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 9 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 627ms TBT · 77.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.6 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 223ms TBT · 72.8 MB heap
extension-clean-combined-draw: · 30.9 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1528ms TBT · 89.1 MB heap
extension-rgthree-prototype-draw: · 31.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1543ms TBT · 88.0 MB heap
large-combo-open: · 40.0 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 3ms TBT · 76.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
large-graph-zoom: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 59.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
subgraph-transition-enter: · 49.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 176ms TBT · 110.4 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
vue-large-graph-idle: · 28.3 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 0ms TBT · 257.3 MB heap
vue-large-graph-pan: · 18.6 avg FPS · 9.2 P5 FPS ❌ (target: ≥52) · 53ms TBT · 252.5 MB heap
vue-node-resize-workload: · 20.6 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 251.9 MB heap
vue-zoom-out-idle: · 23.9 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 251.5 MB heap
workflow-execution: · 56.0 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 0ms TBT · 65.5 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
agent-composer-long-conversation-typing: · 59.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 145.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 4ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 644ms
canvas-idle: script duration 15ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.3 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 972ms
canvas-mouse-sweep: script duration 181ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.2 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 385ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.2 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 513ms
dom-widget-clipping: script duration 181ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 81.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 1066ms
dom-widget-order-dense-n200-w200-i120: script duration 81ms
dom-widget-order-dense-n200-w200-i120: TBT 627ms
dom-widget-order-dense-n200-w200-i120: heap used 77.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -212
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 523ms
dom-widget-order-sparse-n1000-w20-i120: script duration 168ms
dom-widget-order-sparse-n1000-w20-i120: TBT 223ms
dom-widget-order-sparse-n1000-w20-i120: heap used 72.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 10791ms
extension-clean-combined-draw: script duration 8776ms
extension-clean-combined-draw: TBT 1528ms
extension-clean-combined-draw: heap used 89.1 MB
extension-clean-combined-draw: DOM nodes -268
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10651ms
extension-rgthree-prototype-draw: script duration 8636ms
extension-rgthree-prototype-draw: TBT 1543ms
extension-rgthree-prototype-draw: heap used 88.0 MB
extension-rgthree-prototype-draw: DOM nodes -258
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 25ms
large-combo-open: p95 frame time 100ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 18ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 191ms
large-combo-open: script duration 10ms
large-combo-open: TBT 3ms
large-combo-open: heap used 76.5 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 8
large-graph-idle: task duration 683ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.6 MB
large-graph-idle: DOM nodes -258
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 7ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1876ms
large-graph-pan: script duration 894ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.1 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1935ms
large-graph-zoom: script duration 851ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes -105
large-graph-zoom: event listeners -34
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2173ms
legacy-node-drag: script duration 1040ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.8 MB
legacy-node-drag: DOM nodes -258
legacy-node-drag: event listeners -65
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 3ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 676ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.4 MB
minimap-idle: DOM nodes -258
minimap-idle: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 487ms
subgraph-dom-widget-clipping: script duration 151ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 563ms
subgraph-idle: script duration 14ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 79.2 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 8
subgraph-mouse-sweep: style recalc count 82
subgraph-mouse-sweep: task duration 1032ms
subgraph-mouse-sweep: script duration 125ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.5 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 989ms
subgraph-transition-enter: script duration 49ms
subgraph-transition-enter: TBT 176ms
subgraph-transition-enter: heap used 110.4 MB
subgraph-transition-enter: DOM nodes 15953
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 20ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6356ms
viewport-pan-sweep: script duration 2845ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.3 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 35ms
vue-large-graph-idle: p95 frame time 75ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 19798ms
vue-large-graph-idle: script duration 305ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 257.3 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 54ms
vue-large-graph-pan: p95 frame time 108ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 28283ms
vue-large-graph-pan: script duration 922ms
vue-large-graph-pan: TBT 53ms
vue-large-graph-pan: heap used 252.5 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 48ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8343ms
vue-node-resize-workload: script duration 151ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 251.9 MB
vue-node-resize-workload: DOM nodes -3330
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 42ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11537ms
vue-zoom-out-idle: script duration 171ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 251.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 18ms
workflow-execution: p95 frame time 25ms
workflow-execution: layout duration 5ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 9
workflow-execution: style recalc count 10
workflow-execution: task duration 106ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.5 MB
workflow-execution: DOM nodes 105
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 17ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 544ms
agent-composer-empty-conversation-typing: script duration 270ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 80.6 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 3ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 590ms
agent-composer-long-conversation-typing: script duration 238ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 145.9 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-28T03:00:38.390Z",
  "gitSha": "aa678ca0b6e101de6652ff119b9ab965d55a14d7",
  "branch": "backport-21600-to-cloud-1.57",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.5339999999974,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.1909999999999994,
      "layouts": 9,
      "layoutDurationMs": 3.3249999999999997,
      "taskDurationMs": 624.878,
      "heapDeltaBytes": -893912,
      "heapUsedBytes": 74916708,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 14.306999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.0830000000187,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.6439999999999997,
      "layouts": 11,
      "layoutDurationMs": 4.068,
      "taskDurationMs": 662.181,
      "heapDeltaBytes": -928440,
      "heapUsedBytes": 74512096,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 15.708,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1891.4749999999572,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 18.311999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.8899999999999997,
      "taskDurationMs": 981.8269999999999,
      "heapDeltaBytes": -7252500,
      "heapUsedBytes": 68103448,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 183.444,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665486725663715,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1859.7069999999576,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 16.369,
      "layouts": 10,
      "layoutDurationMs": 2.5129999999999995,
      "taskDurationMs": 961.6370000000001,
      "heapDeltaBytes": -7287476,
      "heapUsedBytes": 68596264,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 177.925,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665765765765762,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1699.1550000000188,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.296000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.894,
      "taskDurationMs": 361.63900000000007,
      "heapDeltaBytes": 18767640,
      "heapUsedBytes": 84628644,
      "domNodes": 47,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 16.379,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.091000000044,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.293000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.693,
      "taskDurationMs": 408.866,
      "heapDeltaBytes": -4501932,
      "heapUsedBytes": 71022240,
      "domNodes": 47,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 12.759000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 741.989999999987,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.688,
      "layouts": 8,
      "layoutDurationMs": 2.9139999999999997,
      "taskDurationMs": 480.097,
      "heapDeltaBytes": 25275712,
      "heapUsedBytes": 92009636,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 179.194,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668181818181832,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 760.042999999996,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.3649999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.97,
      "taskDurationMs": 545.233,
      "heapDeltaBytes": 3923048,
      "heapUsedBytes": 79365708,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 182.289,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1337.3269999999593,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1075.9050000000002,
      "heapDeltaBytes": -13573736,
      "heapUsedBytes": 81229796,
      "domNodes": -212,
      "jsHeapTotalBytes": 20455424,
      "scriptDurationMs": 85.46799999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 632,
      "frameDurationMs": 35.086842105263166,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1317.448000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1056.894,
      "heapDeltaBytes": 609504,
      "heapUsedBytes": 81225836,
      "domNodes": -212,
      "jsHeapTotalBytes": 14426112,
      "scriptDurationMs": 75.85799999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 621,
      "frameDurationMs": 34.64736842105264,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 855.3980000000365,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.4440000000004,
      "heapDeltaBytes": -4789916,
      "heapUsedBytes": 76129216,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 164.572,
      "eventListeners": 0,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 24.9970588235294,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 870.9920000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.5790000000004,
      "heapDeltaBytes": -4262564,
      "heapUsedBytes": 76544408,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 170.56299999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 224,
      "frameDurationMs": 25.488235294117658,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 12401.468999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11432.881,
      "heapDeltaBytes": -4496880,
      "heapUsedBytes": 90322392,
      "domNodes": -278,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 9318.675000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1812,
      "frameDurationMs": 33.42183288409703,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10949.71899999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10148.81,
      "heapDeltaBytes": 2509952,
      "heapUsedBytes": 96635708,
      "domNodes": -258,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 8233.951,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1243,
      "frameDurationMs": 31.284285714285716,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11573.256000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10713.195000000002,
      "heapDeltaBytes": 2934992,
      "heapUsedBytes": 97024676,
      "domNodes": -258,
      "jsHeapTotalBytes": 6156288,
      "scriptDurationMs": 8675.767,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1702,
      "frameDurationMs": 31.77554945054945,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11359.96499999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10589.412,
      "heapDeltaBytes": -12128312,
      "heapUsedBytes": 87572956,
      "domNodes": -258,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 8597.06,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1384,
      "frameDurationMs": 31.880898876404494,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-combo-open",
      "durationMs": 250.01900000000887,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 17.406,
      "layouts": 11,
      "layoutDurationMs": 3.787,
      "taskDurationMs": 192.582,
      "heapDeltaBytes": -7528524,
      "heapUsedBytes": 80094960,
      "domNodes": 917,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 10.107,
      "eventListeners": 196,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-combo-open",
      "durationMs": 243.00800000003164,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 18.54,
      "layouts": 11,
      "layoutDurationMs": 3.377,
      "taskDurationMs": 189.505,
      "heapDeltaBytes": -7534088,
      "heapUsedBytes": 80323248,
      "domNodes": 917,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 9.994000000000002,
      "eventListeners": 196,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.688999999982,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.3689999999999998,
      "layouts": 7,
      "layoutDurationMs": 2.366,
      "taskDurationMs": 603.448,
      "heapDeltaBytes": -2331504,
      "heapUsedBytes": 76524848,
      "domNodes": -258,
      "jsHeapTotalBytes": 2748416,
      "scriptDurationMs": 39.732,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666129032258066,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.3369999999477,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.7030000000000007,
      "layouts": 8,
      "layoutDurationMs": 2.5610000000000004,
      "taskDurationMs": 761.8050000000001,
      "heapDeltaBytes": -18900168,
      "heapUsedBytes": 77727904,
      "domNodes": -258,
      "jsHeapTotalBytes": 4096000,
      "scriptDurationMs": 40.4,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225806,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2817.196000000024,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 6.886,
      "layouts": 7,
      "layoutDurationMs": 2.396,
      "taskDurationMs": 1844.9879999999998,
      "heapDeltaBytes": 329812,
      "heapUsedBytes": 77837552,
      "domNodes": -278,
      "jsHeapTotalBytes": 3235840,
      "scriptDurationMs": 886.1940000000001,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568047337278,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2933.721999999989,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 6.854999999999999,
      "layouts": 7,
      "layoutDurationMs": 2.115,
      "taskDurationMs": 1907.0259999999998,
      "heapDeltaBytes": -10524728,
      "heapUsedBytes": 67002792,
      "domNodes": -278,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 901.07,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66590909090909,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4056.096000000025,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 8.24,
      "layouts": 63,
      "layoutDurationMs": 10.869,
      "taskDurationMs": 2015.1700000000003,
      "heapDeltaBytes": -31931288,
      "heapUsedBytes": 67716308,
      "domNodes": -234,
      "jsHeapTotalBytes": 5144576,
      "scriptDurationMs": 876.283,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.734567901234563,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3953.6620000000084,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 8.043999999999999,
      "layouts": 64,
      "layoutDurationMs": 11.248000000000001,
      "taskDurationMs": 1854.9509999999998,
      "heapDeltaBytes": 5926640,
      "heapUsedBytes": 88001656,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 825.976,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7364406779661,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3267.563999999993,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.047999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.3219999999999998,
      "taskDurationMs": 2172.781,
      "heapDeltaBytes": 1598876,
      "heapUsedBytes": 85050096,
      "domNodes": -258,
      "jsHeapTotalBytes": 5001216,
      "scriptDurationMs": 1041.1000000000001,
      "eventListeners": -64,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.923711340206186,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3243.0779999999686,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.309999999999999,
      "layouts": 5,
      "layoutDurationMs": 1.689,
      "taskDurationMs": 2172.787,
      "heapDeltaBytes": 779012,
      "heapUsedBytes": 84409072,
      "domNodes": -258,
      "jsHeapTotalBytes": 6049792,
      "scriptDurationMs": 1038.252,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.839062499999997,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2055.3280000000314,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.416000000000001,
      "layouts": 7,
      "layoutDurationMs": 1.9980000000000002,
      "taskDurationMs": 775.1309999999999,
      "heapDeltaBytes": 6880248,
      "heapUsedBytes": 85080988,
      "domNodes": -258,
      "jsHeapTotalBytes": -659456,
      "scriptDurationMs": 40.894999999999996,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.7130000000916,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.601,
      "layouts": 8,
      "layoutDurationMs": 3.037,
      "taskDurationMs": 575.903,
      "heapDeltaBytes": -2102216,
      "heapUsedBytes": 79391088,
      "domNodes": -258,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 36.91199999999999,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 751.0930000000258,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.637,
      "layouts": 9,
      "layoutDurationMs": 2.613,
      "taskDurationMs": 512.943,
      "heapDeltaBytes": -1121584,
      "heapUsedBytes": 76346208,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 153.988,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 672.9759999999487,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.957,
      "layouts": 9,
      "layoutDurationMs": 2.569,
      "taskDurationMs": 461.701,
      "heapDeltaBytes": 3170256,
      "heapUsedBytes": 80308416,
      "domNodes": 0,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 147.698,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2045.10700000003,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.4810000000000008,
      "layouts": 7,
      "layoutDurationMs": 2.299,
      "taskDurationMs": 657.181,
      "heapDeltaBytes": -262632,
      "heapUsedBytes": 77099708,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 13.541,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.0280000000294,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.136,
      "layouts": 10,
      "layoutDurationMs": 2.7899999999999996,
      "taskDurationMs": 468.226,
      "heapDeltaBytes": 22444712,
      "heapUsedBytes": 89089012,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 15.276,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1987.5020000000063,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 19.024,
      "layouts": 8,
      "layoutDurationMs": 2.523,
      "taskDurationMs": 1184.465,
      "heapDeltaBytes": 11596144,
      "heapUsedBytes": 79052468,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 130.933,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666386554621848,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.5059999999958,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 17.036,
      "layouts": 8,
      "layoutDurationMs": 2.259,
      "taskDurationMs": 880.3899999999999,
      "heapDeltaBytes": 11683704,
      "heapUsedBytes": 79244276,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 119.366,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1467.219,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.885999999999996,
      "layouts": 5,
      "layoutDurationMs": 15.675,
      "taskDurationMs": 988.6389999999998,
      "heapDeltaBytes": 35798204,
      "heapUsedBytes": 115810544,
      "domNodes": 15953,
      "jsHeapTotalBytes": 11407360,
      "scriptDurationMs": 48.586,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 176,
      "frameDurationMs": 20.319178082191783,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10331.912999999986,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 20.438,
      "layouts": 6,
      "layoutDurationMs": 1.5759999999999996,
      "taskDurationMs": 6535.519000000001,
      "heapDeltaBytes": 9144616,
      "heapUsedBytes": 87863108,
      "domNodes": -258,
      "jsHeapTotalBytes": 3989504,
      "scriptDurationMs": 2913.9210000000003,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.692891760904686,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9873.30600000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 19.607,
      "layouts": 7,
      "layoutDurationMs": 2.304,
      "taskDurationMs": 6177.179000000001,
      "heapDeltaBytes": 13873404,
      "heapUsedBytes": 93203120,
      "domNodes": -278,
      "jsHeapTotalBytes": 3989504,
      "scriptDurationMs": 2776.817,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.694077834179357,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23633.658000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23186.153,
      "heapDeltaBytes": -26547736,
      "heapUsedBytes": 268362792,
      "domNodes": -3330,
      "jsHeapTotalBytes": 12046336,
      "scriptDurationMs": 331.814,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.31538461538461,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17028.861000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16408.907,
      "heapDeltaBytes": -10355552,
      "heapUsedBytes": 271314228,
      "domNodes": -3330,
      "jsHeapTotalBytes": 23060480,
      "scriptDurationMs": 277.57300000000004,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.4681660899654,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 29224.295000000042,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 21.310999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 28937.688,
      "heapDeltaBytes": -18696860,
      "heapUsedBytes": 257627336,
      "domNodes": -3330,
      "jsHeapTotalBytes": 13357056,
      "scriptDurationMs": 973.5420000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 55.36401515151515,
      "p95FrameDurationMs": 116.60000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27935.959999999908,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 16.842999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27628.905999999995,
      "heapDeltaBytes": -28640172,
      "heapUsedBytes": 271842424,
      "domNodes": -3330,
      "jsHeapTotalBytes": 10215424,
      "scriptDurationMs": 870.354,
      "eventListeners": -651,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 51.88754646840148,
      "p95FrameDurationMs": 100.10000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8708.582999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.04699999999997,
      "layouts": 20,
      "layoutDurationMs": 25.785000000000004,
      "taskDurationMs": 8575.134,
      "heapDeltaBytes": -36988108,
      "heapUsedBytes": 259007016,
      "domNodes": -3330,
      "jsHeapTotalBytes": 16764928,
      "scriptDurationMs": 134.174,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 50.579651162790704,
      "p95FrameDurationMs": 100.09999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8274.085000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.28599999999999,
      "layouts": 20,
      "layoutDurationMs": 22.092,
      "taskDurationMs": 8109.905999999999,
      "heapDeltaBytes": -31607880,
      "heapUsedBytes": 269241480,
      "domNodes": -3330,
      "jsHeapTotalBytes": 17289216,
      "scriptDurationMs": 167.586,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.27430167597765,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 12222.758999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11705.923999999999,
      "heapDeltaBytes": -24282292,
      "heapUsedBytes": 250589760,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 178.39100000000008,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 42.47534722222221,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11521.968000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11368.454000000002,
      "heapDeltaBytes": 9113028,
      "heapUsedBytes": 276883492,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 163.628,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.188928571428576,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "workflow-execution",
      "durationMs": 142.1420000000353,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.96,
      "layouts": 9,
      "layoutDurationMs": 6.703,
      "taskDurationMs": 109.331,
      "heapDeltaBytes": -10367804,
      "heapUsedBytes": 69143984,
      "domNodes": 116,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 9.444999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666615,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 140.79000000003816,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 10.463000000000001,
      "layouts": 8,
      "layoutDurationMs": 3.4960000000000004,
      "taskDurationMs": 102.613,
      "heapDeltaBytes": -15474904,
      "heapUsedBytes": 68208304,
      "domNodes": 94,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 6.810999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.042857142857105,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 633.9309999999614,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.495,
      "layouts": 76,
      "layoutDurationMs": 18.037000000000003,
      "taskDurationMs": 587.163,
      "heapDeltaBytes": 13270672,
      "heapUsedBytes": 96221524,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 291.39200000000005,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 549.3039999998928,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.1280000000000001,
      "layouts": 76,
      "layoutDurationMs": 16.362000000000002,
      "taskDurationMs": 501.659,
      "heapDeltaBytes": -20617708,
      "heapUsedBytes": 72880404,
      "domNodes": 4,
      "jsHeapTotalBytes": 12058624,
      "scriptDurationMs": 247.999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 600.8759999999711,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.5509999999999997,
      "layouts": 76,
      "layoutDurationMs": 15.056999999999999,
      "taskDurationMs": 556.419,
      "heapDeltaBytes": 716096,
      "heapUsedBytes": 122758944,
      "domNodes": 4,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 226.387,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 664.3219999999701,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.693,
      "layouts": 76,
      "layoutDurationMs": 17.133,
      "taskDurationMs": 623.527,
      "heapDeltaBytes": 18913372,
      "heapUsedBytes": 183166380,
      "domNodes": 4,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 248.831,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.094871794871814,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.5%

Coverage totals
Metric Covered Total Pct
Lines 56276 87260 64.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 47.5% 245
src/core/webSessionIdentity.ts 3.3% 231
src/core/graph/widgets/dynamicGroupWidget.ts 0.4% 224
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2286 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2264 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/28/2026, 02:48:16 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 21364a588de45873cbbbd7c9e13e5de7ad85bf27

Full docs: ADR-DEVEX-LINT-0015

@github-actions
github-actions Bot requested a review from thedatalife October 28, 2026 01:27
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 28, 2026
@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.57   #22105   +/-   ##
=============================================
  Coverage              ?   84.13%           
=============================================
  Files                 ?     3006           
  Lines                 ?   160208           
  Branches              ?    40811           
=============================================
  Hits                  ?   134789           
  Misses                ?    25029           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.93% <ø> (?)
unit 85.22% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
...extensions/agent/services/agent/agentTranscript.ts 97.71% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 96.79% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful cherry-pick of #21600: the production-code hunks in agentTranscript.ts, agentApiSchema.ts, and agentConversationStore.ts are byte-identical to upstream, and cloud/1.57 already has everything the patch assumes (ThinkingPart in agentMessageParts.ts, the relative-import style used, enMessages.agent.toolNotConfirmedOnCanvas, interleaveLocalParts/anchorLocalParts). The only adapted file is the browser spec's TRACE, which matches this branch's pre-existing toolNotConfirmedOnCanvas label for the Add node row, and the e2e/unit/typecheck checks on this PR pass. The bug itself is real: before this change there is no code path that restores content.thinking into the transcript at all, so a chat reopen genuinely drops a completed turn's thinking (tool rows only) — the spec's before/after description is accurate.

One blocking carry-over issue from the original PR (same code, so it applies here too) is anchored inline below.

* One persisted `content.thinking` entry: a model round's thinking text,
* anchored to that round's first tool call when it made one.
*/
export const zPersistedThinkingEntry = z.object({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: this hand-declares a full local schema for a server-response shape that @comfyorg/ingest-types already generates. packages/ingest-types/src/zod.gen.ts exports zAgentThinkingEntry = z.object({ text: z.string(), tool_call_id: z.string().optional() }), generated straight from AgentMessage.content.thinking's OpenAPI schema. Per this repo's rule on generated API types, a hand-declared copy like this silently drifts from the real contract (that's exactly what caused the two bugs in #14771).

The .nullish() vs .optional() difference looks intentional (same Go-nullable-pointer reasoning documented a few lines up for zPersistedToolCallSummary's tool_call_id override), but the fix for that is to extend the generated schema the same way zPersistedToolCallSummary already does — zToolCallSummary.extend({ tool_call_id: z.string().nullish(), ... }) — not to redeclare it from scratch:

export const zPersistedThinkingEntry = zAgentThinkingEntry.extend({
  tool_call_id: z.string().nullish()
})

This keeps text's type sourced from the generated contract so a future backend shape change (e.g. text becoming nullable, or a new field being added) shows up here instead of silently diverging. Could we switch this to extend zAgentThinkingEntry?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible on this branch: 1.57 generated types have no zAgentThinkingEntry (not in packages/ingest-types/src/zod.gen.ts here). Keeping the local copy so 1.57 matches its own contract. Main and the 1.58 backports now extend the generated schema: #22109.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch-specific correction is right: I checked this exact cloud/1.57 checkout, and neither generated zAgentThinkingEntry nor AgentThinkingEntry exists. The previous review's assertion that the export already existed on this train was incorrect.

issue: that absence means the generated contract dependency must be backported before this consumer; it does not make a full local response schema compliant. Please bring the generated shared-package schema onto this train, then derive zPersistedThinkingEntry from it, retaining the intentional null compatibility. Do not hand-edit generated output. This follows up on the existing inline #22105 (comment) rather than duplicating it.

Own validation on 653cb1544bd2e441b4514a84002344dbdc21074d, after fetching main and a separate frozen install: PASS 212 schema/transcript/conversation tests, app typecheck, cloud production build, full six-file type-aware Oxlint/format, production-file ESLint and Knip. ESLint ignores the three test/spec files; no lint coverage is claimed for them. Restored tests PASS 212. Removing thinking restoration fails 2 targeted transcript rows. Keeping local thinking alongside persisted thinking fails only the persisted-replacement row; deleting local thinking unconditionally fails only the legacy row-without-thinking case. The opposite row stays green in each mutation.

PASS the actual Chromium reload-and-chat-switch spec on this exact-head development app with a private local ComfyUI backend and controlled Agent history/auth responses. This is not production Cloud or live LLM evidence. All source mutations were restored; owned servers stopped.

Production Cloud, real persisted backend thinking and combined-main execution: NOT_RUN; no deployment or merge claim.

Repo rule: no added non-JSDoc comments. The branch-specific trace rationale
is in the PR description.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release-note comment finding is resolved: the spec comment was removed at this head, and test behavior is unchanged.

The generated-schema finding is still open (#22105 (comment)). zPersistedThinkingEntry at agentApiSchema.ts:147 is still a hand-declared z.object. This branch's packages/ingest-types/src/zod.gen.ts has no zAgentThinkingEntry because the types update #21508 (cloud@2d86ea8c) was backported only to 1.58 (#21764 / #21765). Backporting #21508 to this branch first, the same way, would add the generated export. Then this PR can use the same zAgentThinkingEntry.pick({ text: true }).extend({ tool_call_id: z.string().nullish() }) as the 1.58 backports, along with #22109's explicit-null test.

The rest is a faithful copy of #21600 (merged as 5d44835). Every non-spec file is byte-identical to upstream, which is why this PR is +163 while the 1.58 backports are +178: those also carry #22109's 15-line explicit-null unit case. The spec is adapted to this branch's existing toolNotConfirmedOnCanvas Add node label.

Checks: the transcript, conversation-store and schema tests pass locally (212). CI is green.

@christian-byrne

christian-byrne commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Closing: no 1.57 user can hit this.

Full context for agent readers

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@dante01yoon FYI on your backport-the-contract-first request here and on #22106: I closed both instead of porting #21508. No 1.57 user can reach this surface, so a 55-file port has nothing to protect. Your review stands as not addressed, not as done. If you see a 1.57 path I missed, reopen and I'll do the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants