Repository navigation
feat: Show an error toast on the consent card - #22079
Conversation
The video fills the card width. The primary button hugs its text. The docs link sits on the same row as the buttons. The sign-in hint stays with the primary button.
The docs link uses 14px text and a 16px icon again.
The card uses its own width to stack the actions. The primary action sits first on a narrow card. The docs link moves under the copy on a narrow card.
The two-column video uses the column height and keeps a 16:9 shape. The compact video uses the leftover card height. The picture is not stretched.
Replace the plain red error text with the design-system Message, add a contact-form feedback link, and change the primary action to Try again.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
📦 Bundle: 11.9 MB gzip 🔴 +3.23 kBDetailsSummary
Category Glance App Entry Points — 6.68 kB (baseline 6.66 kB) • 🔴 +27 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • 🔴 +205 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 873 kB (baseline 872 kB) • 🔴 +154 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 156 kB (baseline 156 kB) • 🔴 +31 BAuthentication, profile, and account management bundles
Status: 10 added / 10 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • 🔴 +54 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 345 kB (baseline 343 kB) • 🔴 +1.93 kBReusable component library chunks
Status: 9 added / 9 removed / 21 unchanged Data & Services — 1.9 MB (baseline 1.83 MB) • 🔴 +72.4 kBStores, services, APIs, and repositories
Status: 36 added / 35 removed / 6 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +74 BHelpers, composables, and utility bundles
Status: 49 added / 49 removed / 35 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🟢 -67.8 kBBundles that do not match a named category
Status: 117 added / 115 removed / 630 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T03:56:50.324Z",
"gitSha": "5299da0994d0e477a5172eadcc8c99a11b1eae8a",
"branch": "uytieu/des-1291-consent-error-toast",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.1729999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4079999999999995,
"layouts": 9,
"layoutDurationMs": 2.4949999999999997,
"taskDurationMs": 482.11199999999997,
"heapDeltaBytes": 1592452,
"heapUsedBytes": 63243296,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.701,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.2479999999805,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3970000000000007,
"layouts": 9,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 477.244,
"heapDeltaBytes": 1899916,
"heapUsedBytes": 62684712,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.8580000000402,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.534,
"layouts": 10,
"layoutDurationMs": 2.692,
"taskDurationMs": 765.838,
"heapDeltaBytes": 21522316,
"heapUsedBytes": 81931104,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 130.114,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.624999999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.382000000000001,
"layouts": 9,
"layoutDurationMs": 2.3749999999999996,
"taskDurationMs": 783.2470000000001,
"heapDeltaBytes": 21906444,
"heapUsedBytes": 82913892,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 134.744,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5260000000258,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.93,
"layouts": 11,
"layoutDurationMs": 2.6990000000000003,
"taskDurationMs": 374.028,
"heapDeltaBytes": 20061036,
"heapUsedBytes": 81165904,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.181,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0589999999875,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.303000000000001,
"layouts": 11,
"layoutDurationMs": 2.506,
"taskDurationMs": 367.477,
"heapDeltaBytes": -1752612,
"heapUsedBytes": 59049736,
"domNodes": 57,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.891,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 615.820000000042,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.476,
"layouts": 9,
"layoutDurationMs": 2.6470000000000002,
"taskDurationMs": 441.244,
"heapDeltaBytes": 3208728,
"heapUsedBytes": 65477908,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 149.04399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 646.1540000000241,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4670000000000005,
"layouts": 9,
"layoutDurationMs": 2.3420000000000005,
"taskDurationMs": 454.00600000000003,
"heapDeltaBytes": 3632356,
"heapUsedBytes": 65492440,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 150.18300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.2119999999677,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.1909999999999,
"heapDeltaBytes": -13873856,
"heapUsedBytes": 75327252,
"domNodes": -203,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 52.12099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 477,
"frameDurationMs": 31.941666666666656,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.1110000000563,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 821.3489999999999,
"heapDeltaBytes": -12215904,
"heapUsedBytes": 75097072,
"domNodes": -203,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 57.49400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 460,
"frameDurationMs": 31.477777777777785,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3890000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.75700000000035,
"heapDeltaBytes": -27076408,
"heapUsedBytes": 66547584,
"domNodes": -203,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 140.33800000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 164,
"frameDurationMs": 22.972972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.8749999999864,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.73500000000035,
"heapDeltaBytes": -27631412,
"heapUsedBytes": 65461972,
"domNodes": -223,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 126.72599999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 150,
"frameDurationMs": 22.688888888888894,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9612.003999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8650.678,
"heapDeltaBytes": 65829188,
"heapUsedBytes": 145838372,
"domNodes": -269,
"jsHeapTotalBytes": 72478720,
"scriptDurationMs": 6716.822,
"eventListeners": -68,
"totalBlockingTimeMs": 281,
"frameDurationMs": 28.282941176470587,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8349.254999999972,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5310000000000002,
"layouts": 2,
"layoutDurationMs": 0.46900000000000025,
"taskDurationMs": 7478.4890000000005,
"heapDeltaBytes": 54292896,
"heapUsedBytes": 134314820,
"domNodes": -269,
"jsHeapTotalBytes": 55963648,
"scriptDurationMs": 5689.607000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 87,
"frameDurationMs": 25.22567975830816,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8678.488999999985,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5739999999999998,
"layouts": 2,
"layoutDurationMs": 0.4710000000000001,
"taskDurationMs": 7761.05,
"heapDeltaBytes": 63019824,
"heapUsedBytes": 145126488,
"domNodes": -269,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 5989.063,
"eventListeners": -68,
"totalBlockingTimeMs": 195,
"frameDurationMs": 25.792857142857148,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8781.920999999955,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.2919999999999997,
"layouts": 2,
"layoutDurationMs": 0.5500000000000002,
"taskDurationMs": 7845.647,
"heapDeltaBytes": 56813584,
"heapUsedBytes": 136392712,
"domNodes": -269,
"jsHeapTotalBytes": 58060800,
"scriptDurationMs": 6013.775,
"eventListeners": -68,
"totalBlockingTimeMs": 148,
"frameDurationMs": 25.859292035398234,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 255.49399999999878,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.557999999999998,
"layouts": 11,
"layoutDurationMs": 3.3060000000000005,
"taskDurationMs": 205.32500000000002,
"heapDeltaBytes": -6893696,
"heapUsedBytes": 68475696,
"domNodes": 742,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.059000000000003,
"eventListeners": 64,
"totalBlockingTimeMs": 40,
"frameDurationMs": 29.633333333333365,
"p95FrameDurationMs": 133.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 262.5859999999989,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.815,
"layouts": 12,
"layoutDurationMs": 3.8859999999999997,
"taskDurationMs": 208.827,
"heapDeltaBytes": -7372476,
"heapUsedBytes": 75292660,
"domNodes": 936,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.376000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.24545454545453,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.960000000051,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.217,
"layouts": 9,
"layoutDurationMs": 2.4540000000000006,
"taskDurationMs": 608.7810000000001,
"heapDeltaBytes": -23104088,
"heapUsedBytes": 64419604,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 34.784,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.0000000000164,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2070000000000007,
"layouts": 8,
"layoutDurationMs": 2.354,
"taskDurationMs": 590.0040000000001,
"heapDeltaBytes": -13985996,
"heapUsedBytes": 59816528,
"domNodes": -269,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.41799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2239.9950000000217,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.141,
"layouts": 7,
"layoutDurationMs": 1.523,
"taskDurationMs": 1596.6229999999998,
"heapDeltaBytes": -11866668,
"heapUsedBytes": 76825340,
"domNodes": -269,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 758.993,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2211.185999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.386,
"layouts": 8,
"layoutDurationMs": 1.9820000000000002,
"taskDurationMs": 1558.1309999999999,
"heapDeltaBytes": -7378256,
"heapUsedBytes": 81268032,
"domNodes": -269,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 738.05,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834588,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3505.2479999999946,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.969999999999999,
"layouts": 65,
"layoutDurationMs": 11.977,
"taskDurationMs": 1626.3660000000002,
"heapDeltaBytes": 6343864,
"heapUsedBytes": 95528932,
"domNodes": 24,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 696.0730000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3543.0300000000443,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.721000000000002,
"layouts": 64,
"layoutDurationMs": 11.713,
"taskDurationMs": 1699.8300000000002,
"heapDeltaBytes": -18669692,
"heapUsedBytes": 64300864,
"domNodes": -245,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 724.551,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2717.8289999999947,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.067000000000001,
"layouts": 5,
"layoutDurationMs": 1.0899999999999999,
"taskDurationMs": 1777.7279999999998,
"heapDeltaBytes": 16693960,
"heapUsedBytes": 95322080,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 852.521,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769135802469137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2855.1989999999705,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.002000000000001,
"layouts": 4,
"layoutDurationMs": 0.905,
"taskDurationMs": 1791.543,
"heapDeltaBytes": 16892432,
"heapUsedBytes": 88766472,
"domNodes": 0,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 862.0629999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76411764705883,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3107.0660000000316,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0880000000000005,
"layouts": 9,
"layoutDurationMs": 2.1359999999999997,
"taskDurationMs": 760.9390000000001,
"heapDeltaBytes": -4315212,
"heapUsedBytes": 87143076,
"domNodes": -269,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 363.416,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3036.5810000000124,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.105,
"layouts": 8,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 754.884,
"heapDeltaBytes": -15262112,
"heapUsedBytes": 73150728,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 324.347,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.335000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8449999999999993,
"layouts": 7,
"layoutDurationMs": 1.7009999999999998,
"taskDurationMs": 591.967,
"heapDeltaBytes": -16318676,
"heapUsedBytes": 59935700,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.06400000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.1560000000336,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.758,
"layouts": 7,
"layoutDurationMs": 1.738,
"taskDurationMs": 586.1039999999999,
"heapDeltaBytes": -27490480,
"heapUsedBytes": 64844100,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 30.544,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3081.5109999999777,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.954,
"layouts": 9,
"layoutDurationMs": 2.065,
"taskDurationMs": 599.2930000000001,
"heapDeltaBytes": -24871040,
"heapUsedBytes": 65179396,
"domNodes": -268,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 169.91099999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2756.1000000000035,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.073,
"layouts": 8,
"layoutDurationMs": 1.8079999999999996,
"taskDurationMs": 575.16,
"heapDeltaBytes": -16065916,
"heapUsedBytes": 72924336,
"domNodes": -265,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 166.45200000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3215.54100000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9030000000000002,
"layouts": 8,
"layoutDurationMs": 1.8579999999999999,
"taskDurationMs": 895.0150000000001,
"heapDeltaBytes": -13734908,
"heapUsedBytes": 75198384,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 339.67900000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3266.6459999999233,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6619999999999995,
"layouts": 8,
"layoutDurationMs": 2.142,
"taskDurationMs": 901.9179999999999,
"heapDeltaBytes": -4325508,
"heapUsedBytes": 88947412,
"domNodes": -269,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 367.99,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751546391752576,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.733999999954,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.023000000000001,
"layouts": 9,
"layoutDurationMs": 2.261,
"taskDurationMs": 417.231,
"heapDeltaBytes": -1977676,
"heapUsedBytes": 60667536,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 134.105,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.0929999999144,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.510000000000001,
"layouts": 10,
"layoutDurationMs": 2.2110000000000003,
"taskDurationMs": 395.98,
"heapDeltaBytes": -1382736,
"heapUsedBytes": 61069884,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 127.20199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.5470000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.444,
"layouts": 9,
"layoutDurationMs": 2.346,
"taskDurationMs": 468.86299999999994,
"heapDeltaBytes": 2224216,
"heapUsedBytes": 64589248,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.166999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.717999999978,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3170000000000006,
"layouts": 9,
"layoutDurationMs": 2.451,
"taskDurationMs": 477.03400000000005,
"heapDeltaBytes": 3939808,
"heapUsedBytes": 65979488,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8.879,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.6180000000245,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.145,
"layouts": 9,
"layoutDurationMs": 2.0979999999999994,
"taskDurationMs": 744.197,
"heapDeltaBytes": 17585968,
"heapUsedBytes": 78741848,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 94.905,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9969999999676,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.100999999999999,
"layouts": 10,
"layoutDurationMs": 2.595,
"taskDurationMs": 732.115,
"heapDeltaBytes": 18694788,
"heapUsedBytes": 81051300,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 92.979,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.412999999995,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.492,
"layouts": 5,
"layoutDurationMs": 11.74,
"taskDurationMs": 927.7069999999999,
"heapDeltaBytes": 9337508,
"heapUsedBytes": 101198872,
"domNodes": 16029,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 28.334000000000007,
"eventListeners": 3246,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.716901408450713,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8249.610000000019,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.348000000000003,
"layouts": 9,
"layoutDurationMs": 2.084,
"taskDurationMs": 5398.232,
"heapDeltaBytes": -28539856,
"heapUsedBytes": 61162264,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 2403.2140000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666194331983807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.74800000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.64,
"layouts": 8,
"layoutDurationMs": 2.0559999999999996,
"taskDurationMs": 5428.361,
"heapDeltaBytes": -1668192,
"heapUsedBytes": 76628808,
"domNodes": -269,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2443.611,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18716.433000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18106.237999999998,
"heapDeltaBytes": -17388204,
"heapUsedBytes": 260876620,
"domNodes": -3343,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 266.472,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.125309734513266,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18572.93500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17811.896,
"heapDeltaBytes": -4222876,
"heapUsedBytes": 276542164,
"domNodes": -3343,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 287.186,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.14982698961938,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 23086.599999999977,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.226000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22692.716999999997,
"heapDeltaBytes": -15860856,
"heapUsedBytes": 261675116,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 833.2900000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 42.82448979591837,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23381.592999999953,
"styleRecalcs": 176,
"styleRecalcDurationMs": 22.136000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23085.659,
"heapDeltaBytes": -28932584,
"heapUsedBytes": 254176568,
"domNodes": -3343,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 822.656,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 44.36869070208729,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6986.507000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.814,
"layouts": 20,
"layoutDurationMs": 23.247000000000003,
"taskDurationMs": 6890.741,
"heapDeltaBytes": -33770136,
"heapUsedBytes": 258374860,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 111.096,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.794999999999995,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6712.800999999899,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.906000000000006,
"layouts": 20,
"layoutDurationMs": 22.597000000000005,
"taskDurationMs": 6621.923,
"heapDeltaBytes": -20083676,
"heapUsedBytes": 271942820,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 109.72300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.82312138728324,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9288.415999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8880.657000000001,
"heapDeltaBytes": -58168,
"heapUsedBytes": 274166576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.96799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.23229166666667,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9308.398000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9106.798,
"heapDeltaBytes": -18592848,
"heapUsedBytes": 251186208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.32399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.45125448028673,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 479.787999999985,
"styleRecalcs": 19,
"styleRecalcDurationMs": 9.646999999999998,
"layouts": 13,
"layoutDurationMs": 4.053999999999999,
"taskDurationMs": 133.611,
"heapDeltaBytes": -10239724,
"heapUsedBytes": 66359468,
"domNodes": 136,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 12.902000000000003,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 481.0420000000022,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.781999999999998,
"layouts": 10,
"layoutDurationMs": 3.658,
"taskDurationMs": 120.096,
"heapDeltaBytes": 6913172,
"heapUsedBytes": 66694544,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.014999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 367.42500000002565,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.69,
"layouts": 76,
"layoutDurationMs": 13.615,
"taskDurationMs": 327.011,
"heapDeltaBytes": -5359708,
"heapUsedBytes": 37924832,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 147.15800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 404.7600000000102,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.69,
"layouts": 76,
"layoutDurationMs": 14.302999999999999,
"taskDurationMs": 355.686,
"heapDeltaBytes": -5126384,
"heapUsedBytes": 38000012,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 160.221,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 477.9640000000427,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7249999999999999,
"layouts": 76,
"layoutDurationMs": 13.985,
"taskDurationMs": 438.108,
"heapDeltaBytes": -34936,
"heapUsedBytes": 90450452,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 168.096,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 445.27400000004036,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.664,
"layouts": 76,
"layoutDurationMs": 13.936,
"taskDurationMs": 403.99,
"heapDeltaBytes": 209168,
"heapUsedBytes": 95229420,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 151.13199999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3158 passed, 0 failed · 1 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 1 screenshot taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 55ae79427b9e51090eba198a282593a030dd414d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (273)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22079 +/- ##
==========================================
- Coverage 87.46% 87.36% -0.11%
==========================================
Files 2923 2815 -108
Lines 158649 155309 -3340
Branches 41494 42311 +817
==========================================
- Hits 138767 135684 -3083
+ Misses 18961 18870 -91
+ Partials 921 755 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 118 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Pull request was converted to draft
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40805281277 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/agent/agentConsent.spec.ts-snapshots/agent-consent-light-palette-cloud-linux.png` | modified | 30570B -> 29784B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40805089504 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/agent/agentConsent.spec.ts-snapshots/agent-consent-light-palette-cloud-linux.png` | modified | 30570B -> 29784B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed only what changed since my last review (2b07a721 → c6abea64). Everything else in that range is main merges plus the skip-label change, which was added and then reverted.
The one PR-owned change is in useAgentConsent.test.ts, and it resolves my earlier suggestion:
- The
it.forwithif (!opens) dismissConsent(dialog)is now two separate tests on top of a sharedretryFailedLoad(stored)helper. The no-consent case waits for an enabled Accept button, asserts noonOpen, no introduction response and notrackAgentConsentResolved, then dismisses. The stored-consent case awaits the request, expects oneonOpen, and asserts the same no-decision facts. Neither test has conditional logic now. - The repeated-failure test now keeps the
withConsentrequest, dismisses the card after its assertions, and awaits the request, so it no longer leaves a promise floating when the test ends.
The production code (useAgentConsent.ts, AgentConsentCard.vue, consentCardError.ts) is unchanged since my last approval. All three gates are still clear: this is a UX change rather than a bug fix, it derives no server state on the client, and it hand-declares no API types.
CI on this head: 84 passing and 1 Playwright cloud shard still pending. Dependencies aren't installed in this checkout, so I didn't run vitest locally and relied on CI's unit job. Approving.
|
@coderabbitai approve |
✅ Action performed
|
## Summary This change fixes the Agent consent card layout. The card now fits stacked, compact, and columns layouts. - The video has an 8px inset and rounded corners in all layouts. On short screens the video keeps a 16:9 ratio and fits inside its wrap, so the heading, copy, and actions stay on screen. - The buttons hug their text. On a wide footer they sit on one line with the docs link and are vertically centered. The wide check uses the card shell width so a 576px card stays wide. - Narrow width (576px breakpoint, from Comfy-Org#17908) stacks full-width buttons with the primary first. It moves the docs link under the copy. - The dialog centers on the viewport. It zeros `--workspace-inset-right` and ignores the docked agent panel inset (`centerOnViewport`). - The signed-out button says "Agree and continue with sign in". The separate sign-in hint is gone. The error toast is in a stacked PR: Comfy-Org#22079. Linear: https://linear.app/comfyorg/issue/DES-1291/des-fix-consent-card-layout ## Verification - `pnpm test:unit` on `AgentConsentCard.test.ts` and `GlobalDialog.test.ts`. - New E2E test `browser_tests/tests/dialogs/globalDialogViewportCenter.spec.ts` checks that a dialog stays centered with a docked panel inset, when maximized and after restore. - `browser_tests/tests/agent/agentConsent.spec.ts` is the layout contract. CI is the signal (this VM cannot run the E2E container). - `pnpm typecheck` and lint on the changed files. Storybook stories to review: - `agent-consentcard--default` - `agent-consentcard--signed-out` - `agent-consentcard--in-narrow-panel` - `agent-consentcard--in-light-app` Short-screen columns: Default story at about 1280×600. Compact: Default story at about 640×660. ## Screenshots | State | Dark | Light | | --- | --- | --- | | Default (stacked, wide) | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/default-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/default-light.png"> | | Signed out | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/signed-out-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/signed-out-light.png"> | | In narrow panel | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/narrow-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/narrow-light.png"> | | Short screen (columns) | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/columns-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/columns-light.png"> | | Compact | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/c7f00f0ce812bb85670dcef97126e1cac6198ea1/.github/pr-images/DES-1291/compact-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/c7f00f0ce812bb85670dcef97126e1cac6198ea1/.github/pr-images/DES-1291/compact-light.png"> | --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
When the card cannot save consent, load the saved choice, or open sign-in, it shows a dismissible error toast on the card. It does not show a line of red text or a second global toast.
Messagesave,load, orsignIn)signInError. Did not changebody2BeforeSignIn.Linear: https://linear.app/comfyorg/issue/DES-1291/des-fix-consent-card-layout
Verification
pnpm test:unitonAgentConsentCard.test.ts,useAgentConsent.test.ts, andGlobalDialog.test.ts: 88 passed.pnpm typecheckon the changed app and browser-test files: passed.796a779: 109 checks green, including E2E and Playwright Videos.Storybook stories to review:
agent-consentcard--erroragent-consentcard--error-in-narrow-panelagent-consentcard--sign-in-errorScreenshots