Repository navigation
Conversation
…#21941) The shared document keeps a DynamicGroup row's values when the row count drops. The row is hidden, not deleted, so growing the group again restores those values (comfy-multi-player ADR-039, [#292](Comfy-Org/comfy-multi-player#292)). The follower got two things wrong about those kept rows: - **Regrow showed template defaults.** A frame that only changes the row count applied just the count, so the regrown rows were built at template defaults. The document, and every reader that projects it, still had the kept values. The applier now also applies the kept fields of the rows that the count change regrows, at root and in subgraph interiors. - **Hidden rows were reported as missing widgets.** On a full or catch-up frame after a shrink, each kept field of a hidden row resolved to no widget and emitted `agent_graph_widget_missing`. That counted as a failure and polluted a signal that alerts are being built on. A field of a row at or above its group's current count is no longer reported. This covers both frontend readers that ADR-039 lists as needing a change. ADR-039 now keeps the added-row announce: a local Add creates a default-valued row, and #21091 stays a V1 residual. A frame that regrows a row but then fails on one of its fields is queued for retry. The applier now keeps the fields it picked for that regrow until they apply, so the retry restores the kept value even though the row is already visible. Any later application of that node's widgets that completes, including a full frame, drops them. | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover hidden DynamicGroup rows the document keeps on a follower` (3160c8c) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40203156801) | Proves the tests catch both bugs | | `fix: restore and stop reporting hidden DynamicGroup rows on followers` (00ac373) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40204313495) | Proves the fix resolves them | | `test: regrow a hidden interior DynamicGroup row on a follower` (4c135be) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40207085346) | Cursor: the subgraph-interior path still regrew at defaults | | `fix: restore hidden DynamicGroup rows in subgraph interiors and match the closest controller` (87787d7) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40208343932) | Interior path uses the same check | | `test: keep visible DynamicGroup rows on a remote row count change` (814476a) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40209717958) | Cursor: a count change re-applied the document to visible rows | | `fix: re-read only DynamicGroup rows a count change regrows` (59c4341) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40211011790) | Only rows at or above the live count are re-read | | `test: replay a frame whose DynamicGroup row regrew but whose kept field failed` (3bb224a) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40422225266) | Review: a retry after a partial regrow skipped the kept field | | `fix: keep the regrown DynamicGroup rows of a failed frame for its retry` (6fee7f6) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40423284253) | The retry restores the kept value | | `test: forget a failed DynamicGroup regrow once a full frame restores the row` (e2523f8) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40430683560) | CodeRabbit: the kept fields outlived a full frame and later overwrote a local edit | | `fix: forget a failed DynamicGroup regrow once the node's widgets apply` (41a4ec6) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40431610356) | Final behavior: the kept fields are dropped once the node's widgets apply | The runs for 87787d7 and 814476a were cancelled by the next push after their unit jobs finished, so the colors above are their unit job results. The first green run's E2E shard failed on an artifact download (`ECONNRESET`) and passed on rerun. - [x] CI red on each test-only commit, with only the new cases failing - [x] CI green on each fix commit - On a real `LGraph` follower with a followed Yjs document: shrinking a two-row group to one and growing it back shows the kept `0.7`, not the template default `1`. The same holds for a DynamicGroup inside a subgraph interior. A local value on a visible row survives a remote count change. A catch-up frame after the shrink records no failure and no `reportError`. When a kept field's callback throws during the regrow, `retryFailed` (interior) and a replay of the same frame (root) restore the kept value and report no failure. - Only fields of rows at or above the live count count as hidden. The key needs a canonical index and a field name, the longest matching controller wins, and a non-number count hides nothing. - Out of scope: alias-addressed groups on DynamicCombo nodes (#21297), and capping hidden indices at `max` (#21288, #21788). - Cursor review: 3 rounds. Round 3 raised two points. The retry point is now fixed after review. The other is kept as is, with reasons in its thread. - `vitest run src/workbench/extensions/agent src/core/graph/widgets src/stores`: 5968 passed on the first fix. The one failure, a polling-backoff timing test in `useAgentSession.test.ts`, passes on its own and is unrelated. (cherry picked from commit 4f874ba)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T09:41:21.682Z",
"gitSha": "67af32ebacbf03e9cb6dae68a69f7991c346f558",
"branch": "backport-21941-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.2820000000236,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.857,
"layouts": 8,
"layoutDurationMs": 2.902,
"taskDurationMs": 549.6419999999999,
"heapDeltaBytes": 5047160,
"heapUsedBytes": 75433948,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.886999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.6769999999779,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1659999999999995,
"layouts": 9,
"layoutDurationMs": 3.0540000000000003,
"taskDurationMs": 559.2840000000001,
"heapDeltaBytes": 1826936,
"heapUsedBytes": 62006320,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.443999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.7139999999984,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.826,
"layouts": 9,
"layoutDurationMs": 2.5880000000000005,
"taskDurationMs": 896.94,
"heapDeltaBytes": 21120332,
"heapUsedBytes": 81732336,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 165.39000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.8190000000031,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.187,
"layouts": 9,
"layoutDurationMs": 2.8740000000000006,
"taskDurationMs": 879.935,
"heapDeltaBytes": 21451104,
"heapUsedBytes": 82577032,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 163.219,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4399999999864,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.289000000000001,
"layouts": 10,
"layoutDurationMs": 3.295,
"taskDurationMs": 404.989,
"heapDeltaBytes": 24124408,
"heapUsedBytes": 85422136,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.522,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.505000000022,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.947,
"layouts": 11,
"layoutDurationMs": 4.032,
"taskDurationMs": 439.898,
"heapDeltaBytes": 23976220,
"heapUsedBytes": 85383044,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 14.247,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 707.7540000000226,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.127,
"layouts": 9,
"layoutDurationMs": 2.661,
"taskDurationMs": 502.47799999999995,
"heapDeltaBytes": 3877548,
"heapUsedBytes": 64597156,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 176.81900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 643.7670000000253,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 9,
"layoutDurationMs": 2.5709999999999997,
"taskDurationMs": 486.489,
"heapDeltaBytes": 3532732,
"heapUsedBytes": 64596124,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 165.14600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1244.1110000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 962.189,
"heapDeltaBytes": -11745876,
"heapUsedBytes": 75742588,
"domNodes": -191,
"jsHeapTotalBytes": 22290432,
"scriptDurationMs": 76.71199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 561,
"frameDurationMs": 33.78108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.6000000000226,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 884.7180000000001,
"heapDeltaBytes": -12211612,
"heapUsedBytes": 75136020,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 67.939,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.7199999999823,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.011,
"heapDeltaBytes": -13766576,
"heapUsedBytes": 65675616,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 167.24099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 895.1550000000452,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.655,
"heapDeltaBytes": -27269628,
"heapUsedBytes": 66478120,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 166.20499999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10872.824999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9981.537,
"heapDeltaBytes": 63950500,
"heapUsedBytes": 136669208,
"domNodes": -257,
"jsHeapTotalBytes": 69332992,
"scriptDurationMs": 8314.685000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1481,
"frameDurationMs": 33.38312883435583,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11124.44099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10309.369999999999,
"heapDeltaBytes": -24651756,
"heapUsedBytes": 64284048,
"domNodes": -257,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 8358.226,
"eventListeners": -68,
"totalBlockingTimeMs": 1173,
"frameDurationMs": 31.40169491525424,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10893.777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10126.473,
"heapDeltaBytes": 76846048,
"heapUsedBytes": 150369136,
"domNodes": -257,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 8183.231000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1209,
"frameDurationMs": 31.502023121387285,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10085.781999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0499999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9322.434000000001,
"heapDeltaBytes": 36002244,
"heapUsedBytes": 118664672,
"domNodes": -257,
"jsHeapTotalBytes": 54128640,
"scriptDurationMs": 7428.409,
"eventListeners": -68,
"totalBlockingTimeMs": 835,
"frameDurationMs": 31.410903426791275,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 260.76100000000224,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.241,
"layouts": 11,
"layoutDurationMs": 3.362,
"taskDurationMs": 213.601,
"heapDeltaBytes": -911472,
"heapUsedBytes": 69231584,
"domNodes": -2315,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 9.196,
"eventListeners": -573,
"totalBlockingTimeMs": 8,
"frameDurationMs": 22.718181818181826,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 235.81899999999223,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.802999999999999,
"layouts": 9,
"layoutDurationMs": 2.9560000000000004,
"taskDurationMs": 176.724,
"heapDeltaBytes": 14507380,
"heapUsedBytes": 74255824,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.424,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25.922222222222192,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2054.815000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3750000000000004,
"layouts": 8,
"layoutDurationMs": 1.825,
"taskDurationMs": 654.013,
"heapDeltaBytes": -10665844,
"heapUsedBytes": 64277576,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.244,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.0059999999858,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4270000000000005,
"layouts": 7,
"layoutDurationMs": 2.308,
"taskDurationMs": 646.644,
"heapDeltaBytes": -13831556,
"heapUsedBytes": 61027280,
"domNodes": -277,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.31999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2247.35400000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.286000000000001,
"layouts": 6,
"layoutDurationMs": 1.6060000000000003,
"taskDurationMs": 1506.0280000000002,
"heapDeltaBytes": 6854360,
"heapUsedBytes": 84757600,
"domNodes": -257,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 806.6020000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2652.7379999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.088000000000001,
"layouts": 7,
"layoutDurationMs": 1.9230000000000003,
"taskDurationMs": 1738.7510000000002,
"heapDeltaBytes": -11186540,
"heapUsedBytes": 81189176,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 836.986,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770886075949367,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3835.989999999981,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.191,
"layouts": 64,
"layoutDurationMs": 10.802,
"taskDurationMs": 1835.28,
"heapDeltaBytes": -843844,
"heapUsedBytes": 79399692,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 796.736,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666521739130435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3921.314999999936,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.983,
"layouts": 64,
"layoutDurationMs": 10.558,
"taskDurationMs": 1889.2570000000003,
"heapDeltaBytes": 3421952,
"heapUsedBytes": 83860664,
"domNodes": -233,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 828.547,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3114.9019999999723,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.972,
"layouts": 4,
"layoutDurationMs": 1.2470000000000003,
"taskDurationMs": 1981.261,
"heapDeltaBytes": 9740288,
"heapUsedBytes": 81947388,
"domNodes": 0,
"jsHeapTotalBytes": 3108864,
"scriptDurationMs": 967.876,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84385026737968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3096.5549999999666,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.373,
"layouts": 5,
"layoutDurationMs": 1.2409999999999999,
"taskDurationMs": 2003.1319999999998,
"heapDeltaBytes": 18063744,
"heapUsedBytes": 90808832,
"domNodes": 0,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 966.8530000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675676,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3084.7219999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9830000000000003,
"layouts": 7,
"layoutDurationMs": 1.8449999999999993,
"taskDurationMs": 813.303,
"heapDeltaBytes": -11663084,
"heapUsedBytes": 65254284,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 376.702,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66540540540541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3103.01400000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.966,
"layouts": 7,
"layoutDurationMs": 2.067,
"taskDurationMs": 779.1259999999999,
"heapDeltaBytes": -32766656,
"heapUsedBytes": 60454548,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 368.87399999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.2649999999817,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1610000000000005,
"layouts": 7,
"layoutDurationMs": 1.9779999999999998,
"taskDurationMs": 635.1790000000002,
"heapDeltaBytes": -11891712,
"heapUsedBytes": 65218420,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 36.793,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.257000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4279999999999995,
"layouts": 7,
"layoutDurationMs": 2.247,
"taskDurationMs": 674.865,
"heapDeltaBytes": -10232364,
"heapUsedBytes": 66902964,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 35.17000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2802.595999999994,
"styleRecalcs": 24,
"styleRecalcDurationMs": 11.565000000000003,
"layouts": 5,
"layoutDurationMs": 1.399,
"taskDurationMs": 591.976,
"heapDeltaBytes": -942068,
"heapUsedBytes": 75835004,
"domNodes": -252,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 185.29700000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2947.014000000024,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.59,
"layouts": 7,
"layoutDurationMs": 1.6560000000000001,
"taskDurationMs": 635.4649999999999,
"heapDeltaBytes": -11697008,
"heapUsedBytes": 67354548,
"domNodes": -248,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 212.39600000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3248.356000000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4139999999999995,
"layouts": 5,
"layoutDurationMs": 1.3859999999999997,
"taskDurationMs": 902.1739999999999,
"heapDeltaBytes": -10273668,
"heapUsedBytes": 72635484,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 411.122,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751546391752576,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3309.49099999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7099999999999997,
"layouts": 7,
"layoutDurationMs": 1.827,
"taskDurationMs": 961.2860000000001,
"heapDeltaBytes": -9328860,
"heapUsedBytes": 69338140,
"domNodes": -263,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 377.901,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151514,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.4929999999822,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.153,
"layouts": 9,
"layoutDurationMs": 2.5450000000000004,
"taskDurationMs": 447.86600000000004,
"heapDeltaBytes": 24389428,
"heapUsedBytes": 85518800,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 147.616,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 743.2410000000118,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.043,
"layouts": 9,
"layoutDurationMs": 2.607,
"taskDurationMs": 494.59400000000005,
"heapDeltaBytes": 240484,
"heapUsedBytes": 62683644,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 158.983,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.6469999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.236,
"layouts": 9,
"layoutDurationMs": 2.789,
"taskDurationMs": 532.585,
"heapDeltaBytes": 3180056,
"heapUsedBytes": 64531712,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 9.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.998999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.882,
"layouts": 9,
"layoutDurationMs": 2.92,
"taskDurationMs": 504.25700000000006,
"heapDeltaBytes": 1752192,
"heapUsedBytes": 63694032,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.646,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.8290000000134,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.876999999999997,
"layouts": 9,
"layoutDurationMs": 2.4149999999999996,
"taskDurationMs": 865.0720000000001,
"heapDeltaBytes": 17384788,
"heapUsedBytes": 79279904,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 114.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.8119999999662,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.454999999999998,
"layouts": 11,
"layoutDurationMs": 2.875,
"taskDurationMs": 826.052,
"heapDeltaBytes": -5782120,
"heapUsedBytes": 66349464,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 107.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.2780000000353,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.662999999999997,
"layouts": 5,
"layoutDurationMs": 16.863999999999997,
"taskDurationMs": 1066.347,
"heapDeltaBytes": 7506740,
"heapUsedBytes": 92899084,
"domNodes": 16030,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 29.64200000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.81891891891891,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10059.47900000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.650999999999996,
"layouts": 8,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 6162.984,
"heapDeltaBytes": -6386000,
"heapUsedBytes": 71500704,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2829.671,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693687707641196,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10209.518000000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.375,
"layouts": 7,
"layoutDurationMs": 1.961,
"taskDurationMs": 6339.177,
"heapDeltaBytes": -15189448,
"heapUsedBytes": 62670224,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2879.209,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69345335515548,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23449.501999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22924.203,
"heapDeltaBytes": -19049028,
"heapUsedBytes": 263410664,
"domNodes": -3343,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 313.673,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.639688041594454,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23932.90400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23213.83,
"heapDeltaBytes": -26083080,
"heapUsedBytes": 270430588,
"domNodes": -3343,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 343.105,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.021955403087475,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28195.37200000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27902.439000000002,
"heapDeltaBytes": -8271148,
"heapUsedBytes": 268398628,
"domNodes": -3343,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 885.284,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 52.90581613508443,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28676.167000000078,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.613999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28287.088,
"heapDeltaBytes": 8588464,
"heapUsedBytes": 285040924,
"domNodes": -3343,
"jsHeapTotalBytes": 16175104,
"scriptDurationMs": 925.941,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.98380414312618,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8384.05800000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.582,
"layouts": 20,
"layoutDurationMs": 22.046999999999997,
"taskDurationMs": 8281.392,
"heapDeltaBytes": -3060056,
"heapUsedBytes": 279334428,
"domNodes": -3343,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 142.86599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.361581920903944,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8543.793999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.24800000000002,
"layouts": 20,
"layoutDurationMs": 24.62099999999999,
"taskDurationMs": 8418.099000000002,
"heapDeltaBytes": -20080152,
"heapUsedBytes": 252654780,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 136.993,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.40500000000001,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11601.235000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11386.968,
"heapDeltaBytes": 15023112,
"heapUsedBytes": 270553184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.56500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.279359430604984,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11806.704000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11476.204,
"heapDeltaBytes": 23118760,
"heapUsedBytes": 277155744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.354,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.191156462585035,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 140.0960000000282,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.927,
"layouts": 10,
"layoutDurationMs": 4.5009999999999994,
"taskDurationMs": 101.338,
"heapDeltaBytes": 4991912,
"heapUsedBytes": 72596264,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.876999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 132.2460000000092,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.069999999999999,
"layouts": 9,
"layoutDurationMs": 6.496000000000001,
"taskDurationMs": 94.466,
"heapDeltaBytes": 4601472,
"heapUsedBytes": 65012888,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.442000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 437.22700000000714,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.665,
"layouts": 76,
"layoutDurationMs": 14.545,
"taskDurationMs": 390.66,
"heapDeltaBytes": -2371804,
"heapUsedBytes": 43059720,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 183.273,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 564.5999999999276,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.616,
"layouts": 76,
"layoutDurationMs": 15.388,
"taskDurationMs": 516.7550000000001,
"heapDeltaBytes": -3325988,
"heapUsedBytes": 40000512,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 255.343,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 581.5240000000585,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.842,
"layouts": 76,
"layoutDurationMs": 15.037999999999998,
"taskDurationMs": 541.906,
"heapDeltaBytes": -12868,
"heapUsedBytes": 91387896,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 220.177,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 707.7450000000454,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.366,
"layouts": 76,
"layoutDurationMs": 17.000999999999998,
"taskDurationMs": 667.906,
"heapDeltaBytes": 3086756,
"heapUsedBytes": 101111528,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 286.757,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190475,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3125 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5dba0362e6829996ccc778c36cdb32d2d8a78b43
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (210)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22060 +/- ##
=============================================
Coverage ? 87.50%
=============================================
Files ? 2945
Lines ? 155887
Branches ? 39999
=============================================
Hits ? 136410
Misses ? 18802
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Closing without merging. We decided not to backport #21941 to |
Backport of #21941 to
cloud/1.59.Manual backport. The cherry-pick conflicted in
applyWidgets: main has a positional-widget early return from #21973, which isn't oncloud/1.59. I kept thecloud/1.59side. Positional widgets go through the same loop there, so theunappliedRegrownRows.delete(node)at the end ofapplyWidgetsstill runs for them.Ran locally:
vitest run src/workbench/extensions/agent/crdt(1283 passed, 1 expected fail) andpnpm typecheck.